From unknown Fri Sep 12 05:30:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35981: [PATCH] Use ngettext in `count-lines-page' Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 May 2019 09:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35981 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 35981@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.155912247625457 (code B ref -1); Wed, 29 May 2019 09:35:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 May 2019 09:34:36 +0000 Received: from localhost ([127.0.0.1]:58108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVuyi-0006cX-B3 for submit@debbugs.gnu.org; Wed, 29 May 2019 05:34:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVuyf-0006cK-Ub for submit@debbugs.gnu.org; Wed, 29 May 2019 05:34:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:33644) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hVuya-0000oA-RR for submit@debbugs.gnu.org; Wed, 29 May 2019 05:34:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVuyZ-0000XU-AU for bug-gnu-emacs@gnu.org; Wed, 29 May 2019 05:34:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVuyY-0000nW-Lc for bug-gnu-emacs@gnu.org; Wed, 29 May 2019 05:34:27 -0400 Received: from mail-it1-f171.google.com ([209.85.166.171]:36043) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hVuyY-0000n2-Hn for bug-gnu-emacs@gnu.org; Wed, 29 May 2019 05:34:26 -0400 Received: by mail-it1-f171.google.com with SMTP id e184so2453652ite.1 for ; Wed, 29 May 2019 02:34:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=goRE13WwzHd+WscwcuaA4c6qgUw+DssMqYolzxoHIt0=; b=I3dOZ60u1vVEXtFeBHmOwoaWKtqwk147NSqYOkEP/XYZG2D/F81RFEt4CfzfzHmrqp LqAKV6uer8PPaLhW7o+wE5Hw5pFTG1FU7ap1WHFIOEKS6BOYX/oqQCCrbuVRpjf++fvb KfeZZ1UcNcYdVwdxyPQJgJAIOEHKTjvQPCbuRw06HsfsrIh8rRLZOxCwP92B93f2yH7r +xa7z+oyVLFZ1Iw9LI7528DRNXck7jk8hhTrgAVdt6og+digsthxp1/x4sSMAsBoW7YB ffCSeqXOSu0eh85aw5uts06fhkyVAcZhuabZTxVNpy+76VSdHi2XRBHGeDAv1tqaW0r4 ipOg== X-Gm-Message-State: APjAAAVQyjK4KgvXEYcgZOyt+gCRbtOrNYr5vb/JKf+dbWw4FBO+a4QL AYHERGEnmgsP78H2X15IG/i86oCXPRw+Uy7VzM4UTsyk X-Google-Smtp-Source: APXvYqxCpp4IgxwAXQLvd3fsWqLPdSjkFK4dRsvg9MfRrDM5AZhhgN6fpoT+cxbnGCOXzKGGedLlX19ryyEgGxRucmk= X-Received: by 2002:a02:3506:: with SMTP id k6mr5968394jaa.41.1559122465048; Wed, 29 May 2019 02:34:25 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Wed, 29 May 2019 11:34:12 +0200 Message-ID: Content-Type: multipart/mixed; boundary="000000000000b0ee87058a037c0d" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.166.171 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --000000000000b0ee87058a037c0d Content-Type: text/plain; charset="UTF-8" See attached patch to correctly use ngettext in `count-lines-page' to get pluralization. Thanks, Stefan Kangas --000000000000b0ee87058a037c0d Content-Type: application/octet-stream; name="0001-Use-ngettext-in-count-lines-page.patch" Content-Disposition: attachment; filename="0001-Use-ngettext-in-count-lines-page.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jw918rka0 RnJvbSA5MzA5MmFhMThjYTQzNDhkMTRjMzE1NGE2ZmZiZGZjNTM1NTM2Y2JhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBXZWQsIDI5IE1heSAyMDE5IDExOjI3OjIyICswMjAwClN1YmplY3Q6IFtQQVRDSF0g VXNlIG5nZXR0ZXh0IGluIGBjb3VudC1saW5lcy1wYWdlJwoKKiB0ZXh0bW9kZXMvcGFnZS5lbCAo Y291bnQtbGluZXMtcGFnZSk6IFVzZSBuZ2V0dGV4dC4KLS0tCiBsaXNwL3RleHRtb2Rlcy9wYWdl LmVsIHwgNSArKysrLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlv bigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvdGV4dG1vZGVzL3BhZ2UuZWwgYi9saXNwL3RleHRtb2Rl cy9wYWdlLmVsCmluZGV4IDIyMGVmMmQ3ZmQuLjEzNzk4ODAzNzQgMTAwNjQ0Ci0tLSBhL2xpc3Av dGV4dG1vZGVzL3BhZ2UuZWwKKysrIGIvbGlzcC90ZXh0bW9kZXMvcGFnZS5lbApAQCAtMTQyLDcg KzE0MiwxMCBAQCBjb3VudC1saW5lcy1wYWdlCiAgICAgICAoc2V0cSB0b3RhbCAoY291bnQtbGlu ZXMgYmVnIGVuZCkKIAkgICAgYmVmb3JlIChjb3VudC1saW5lcyBiZWcgb3BvaW50KQogCSAgICBh ZnRlciAoY291bnQtbGluZXMgb3BvaW50IGVuZCkpCi0gICAgICAobWVzc2FnZSAiUGFnZSBoYXMg JWQgbGluZXMgKCVkICsgJWQpIiB0b3RhbCBiZWZvcmUgYWZ0ZXIpKSkpCisgICAgICAobWVzc2Fn ZSAiUGFnZSBoYXMgJXMgKCVkICsgJWQpIgorICAgICAgICAgICAgICAgKGZvcm1hdC1tZXNzYWdl IChuZ2V0dGV4dCAiJWQgbGluZSIgIiVkIGxpbmVzIiB0b3RhbCkgdG90YWwpCisgICAgICAgICAg ICAgICBiZWZvcmUKKyAgICAgICAgICAgICAgIGFmdGVyKSkpKQogCiAoZGVmdW4gd2hhdC1wYWdl ICgpCiAgICJQcmludCBwYWdlIGFuZCBsaW5lIG51bWJlciBvZiBwb2ludC4iCi0tIAoyLjIxLjAK Cg== --000000000000b0ee87058a037c0d-- From unknown Fri Sep 12 05:30:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35981: [PATCH] Use ngettext in `count-lines-page' Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 May 2019 11:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35981 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: 35981@debbugs.gnu.org Received: via spool by 35981-submit@debbugs.gnu.org id=B35981.155913011323627 (code B ref 35981); Wed, 29 May 2019 11:42:02 +0000 Received: (at 35981) by debbugs.gnu.org; 29 May 2019 11:41:53 +0000 Received: from localhost ([127.0.0.1]:58238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVwxs-00068z-NR for submit@debbugs.gnu.org; Wed, 29 May 2019 07:41:52 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:37180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVwxq-00068W-ND for 35981@debbugs.gnu.org; Wed, 29 May 2019 07:41:51 -0400 Received: by mail-ed1-f66.google.com with SMTP id w37so3305191edw.4 for <35981@debbugs.gnu.org>; Wed, 29 May 2019 04:41:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=cLkK43/SP90vPzgkFL2YqezuPfUUMpA+MfLSaJ4vcRo=; b=rZDLbeqa1/H3o8L2FyM98WDWPEsqotaHXUM22OiwxM2Ud9MuOmIB5FMstj8vqVPdhy FOHvymVZL2E327/wJ/eFHzHt1QL4JIm2/vJTCJJq2O1QpBBimz5Gp7uH0Td2J0PBs2DB KqMcAqRqxB0cxYIWHlNoCClegOml5X6h8n6SIUHAd2AJ2VaQE0VjyhApzmRBcQyPPNKH E2fdL70B9pCkFW53XhQtD68T2sbpX0FKs5NfrmV/J8zWXdt9a48ED8Lz9sJT/z0WybdC TBXcy3s0NdnEWKoHqA6QFy88e83+D4zU9PssNfqmN2ooe0AJCjWDC2xRBJrTc790SLjx +tdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=cLkK43/SP90vPzgkFL2YqezuPfUUMpA+MfLSaJ4vcRo=; b=D5r7sjB6llVWW14tG3ZsbdFHFkLM01X2RCgbdbvur4HGCmBMPrzTdMXQSeDr2/EXpV R618ylKO3Jappr9KeIraf9DrmfiyY/bdzQypaeJbZKvvI5PE4pIq6Mdi4FokivJVsC7Z UoIruICWVN4vAVd37YFWGoHLibO6OD+qZnem21CtLofVO/m3eFJrYePrKN4mI0FuSJhY LUL4pWwt8eVEENZ7v7U5O9DRpu9RX37IlOsUT6hAR3YST1DwN/JeH0h/ufqR17yI5CRR /I4G776qzPi+rqIgkcwkssqfoDSFG1rVtbssUGArUJtrh3rE7412VQt79ooeBTzZaWOj AESA== X-Gm-Message-State: APjAAAVwEW3f/rK96FwGkFIyvC+cwgg5XchttuMNg7oBaT8UYxHcLj1c v74XiRXPzSdnGjwwoBdzoCFh5Q== X-Google-Smtp-Source: APXvYqzo+7MWgChkIGGPsZc7g4UMoVVbkyCjWP/LiwFFJ88ja/+3Bhun2ixPlFkEiBSzTfe/CxecYQ== X-Received: by 2002:aa7:c641:: with SMTP id z1mr135511911edr.142.1559130104812; Wed, 29 May 2019 04:41:44 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:8cad:ae29:555d:852d]) by smtp.gmail.com with ESMTPSA id a17sm4970240edt.63.2019.05.29.04.41.43 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 29 May 2019 04:41:43 -0700 (PDT) From: "Basil L. Contovounesios" References: Date: Wed, 29 May 2019 12:41:42 +0100 In-Reply-To: (Stefan Kangas's message of "Wed, 29 May 2019 11:34:12 +0200") Message-ID: <87sgsxfpxl.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain severity 35981 minor quit > From 93092aa18ca4348d14c3154a6ffbdfc535536cba Mon Sep 17 00:00:00 2001 > From: Stefan Kangas > Date: Wed, 29 May 2019 11:27:22 +0200 > Subject: [PATCH] Use ngettext in `count-lines-page' > > * textmodes/page.el (count-lines-page): Use ngettext. > --- > lisp/textmodes/page.el | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lisp/textmodes/page.el b/lisp/textmodes/page.el > index 220ef2d7fd..1379880374 100644 > --- a/lisp/textmodes/page.el > +++ b/lisp/textmodes/page.el > @@ -142,7 +142,10 @@ count-lines-page > (setq total (count-lines beg end) > before (count-lines beg opoint) > after (count-lines opoint end)) > - (message "Page has %d lines (%d + %d)" total before after)))) > + (message "Page has %s (%d + %d)" > + (format-message (ngettext "%d line" "%d lines" total) total) > + before > + after)))) I don't think it's right to split the phrase into two parts "Page has" and "N lines" for i18n purposes. How about the following instead: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=page.diff diff --git a/lisp/textmodes/page.el b/lisp/textmodes/page.el index 220ef2d7fd..d7214f610f 100644 --- a/lisp/textmodes/page.el +++ b/lisp/textmodes/page.el @@ -142,7 +142,8 @@ count-lines-page (setq total (count-lines beg end) before (count-lines beg opoint) after (count-lines opoint end)) - (message "Page has %d lines (%d + %d)" total before after)))) + (let ((fmt (ngettext "Page has %d line" "Page has %d lines" total))) + (message "%s (%d + %d)" (format-message fmt total) before after))))) (defun what-page () "Print page and line number of point." --=-=-= Content-Type: text/plain Thanks, -- Basil --=-=-=-- From unknown Fri Sep 12 05:30:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35981: [PATCH] Use ngettext in `count-lines-page' Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 May 2019 11:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35981 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: "Basil L. Contovounesios" Cc: 35981@debbugs.gnu.org Received: via spool by 35981-submit@debbugs.gnu.org id=B35981.155913039829652 (code B ref 35981); Wed, 29 May 2019 11:47:01 +0000 Received: (at 35981) by debbugs.gnu.org; 29 May 2019 11:46:38 +0000 Received: from localhost ([127.0.0.1]:58257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVx2T-0007hx-IS for submit@debbugs.gnu.org; Wed, 29 May 2019 07:46:37 -0400 Received: from mail-it1-f179.google.com ([209.85.166.179]:53218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVx2R-0007dR-W8 for 35981@debbugs.gnu.org; Wed, 29 May 2019 07:46:36 -0400 Received: by mail-it1-f179.google.com with SMTP id t184so3203970itf.2 for <35981@debbugs.gnu.org>; Wed, 29 May 2019 04:46:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0dOcBbaG3ZCJIv9SuLOEwukgYN11D7gukr2bpyubnEg=; b=Vv2wBwMLgVcgMfaS1+aR1AxEE4jT3oggL2jOecBTVzP1Zdu48ypR58TEsz+DQCUKdm fBTbkjSEWbhKXYNNdiWbULRZoFkrsU1Y8Jf3++ci8bRbD3EOS8HC17ryYR08jmR7LTtC xEl4FMp7sJfB4/hrZ/LeOF7mc70Li7XRqLYI8dr/90GDVYuzr8T1tM8cIB1h9W4L5Zzc jIyYsCk0JIOjujaURHfqVOeythTLuOlliV+RIr03mkK3qcs0XXfgDRm5nzJ9BNnY5wK8 lo5GQTGMXWZrIZNHcsrZKxMhdyKnzyKJ/MYQphuCjMnw8XdmR0TdGLXy92hDF6XHHNyi yW7A== X-Gm-Message-State: APjAAAXR2OKUxwFSQs68ja7LPH4POxH2vrPcVLQ2q+9RC0oFnbXQj4V4 nRyEJTy5SXPKJpHXKs13GNSRsRjl9gKARUYRVNPn89s2 X-Google-Smtp-Source: APXvYqxv5IPpYcGI+XYKcCoIlEWxKyr/eaNGFyboUlt9P8Bn4TCveaKBrizN0ygVgo6MTy+vJcj+o8hA0+oBNEMjEjQ= X-Received: by 2002:a24:680c:: with SMTP id v12mr6662948itb.67.1559130390392; Wed, 29 May 2019 04:46:30 -0700 (PDT) MIME-Version: 1.0 References: <87sgsxfpxl.fsf@tcd.ie> In-Reply-To: <87sgsxfpxl.fsf@tcd.ie> From: Stefan Kangas Date: Wed, 29 May 2019 13:46:19 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Basil L. Contovounesios writes: > How about the following instead: Looks good to me. Thanks, Stefan Kangas From unknown Fri Sep 12 05:30:33 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Stefan Kangas Subject: bug#35981: closed (Re: [PATCH] Use ngettext in `count-lines-page') Message-ID: References: <12809efa-ea54-d399-84c2-4fce74ab42f2@cs.ucla.edu> X-Gnu-PR-Message: they-closed 35981 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 35981@debbugs.gnu.org Date: Mon, 10 Jun 2019 00:05:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1560125102-30426-1" This is a multi-part message in MIME format... ------------=_1560125102-30426-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #35981: [PATCH] Use ngettext in `count-lines-page' which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 35981@debbugs.gnu.org. --=20 35981: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D35981 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1560125102-30426-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 35981-done) by debbugs.gnu.org; 10 Jun 2019 00:04:02 +0000 Received: from localhost ([127.0.0.1]:55623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ha7n7-0007tA-Tw for submit@debbugs.gnu.org; Sun, 09 Jun 2019 20:04:02 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:57888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ha7n6-0007sr-Cp for 35981-done@debbugs.gnu.org; Sun, 09 Jun 2019 20:04:00 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 6FE9716164F; Sun, 9 Jun 2019 17:03:53 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id CH6gsPkgor4l; Sun, 9 Jun 2019 17:03:52 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9CEDA161533; Sun, 9 Jun 2019 17:03:52 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0VjKYkqC9hnp; Sun, 9 Jun 2019 17:03:52 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 7B4FE1614C7; Sun, 9 Jun 2019 17:03:52 -0700 (PDT) To: Stefan Kangas From: Paul Eggert Subject: Re: [PATCH] Use ngettext in `count-lines-page' Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: <12809efa-ea54-d399-84c2-4fce74ab42f2@cs.ucla.edu> Date: Sun, 9 Jun 2019 17:03:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------B0F9A1297DF943F14A84822C" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35981-done Cc: "Basil L. Contovounesios" , 35981-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------B0F9A1297DF943F14A84822C Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit When a diagnostic this short it's typically more straightforward to give the translators the whole diagnostic than to ask them to figure out how it's pieced together and to restrict their translations algorithmically, so I installed the attached patch instead. Thanks for reporting the problem. --------------B0F9A1297DF943F14A84822C Content-Type: text/x-patch; name="0001-Fig-grammar-of-count-lines-page.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fig-grammar-of-count-lines-page.patch" >From bcea7e843936da41619df67faedf5f508db7d722 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sun, 9 Jun 2019 16:59:43 -0700 Subject: [PATCH] Fig grammar of count-lines-page * lisp/textmodes/page.el (count-lines-page): Say "Page has 1 line", not "Page has 1 lines" (Bug#35981). --- lisp/textmodes/page.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/textmodes/page.el b/lisp/textmodes/page.el index 2b0cea4c64..8921b697f3 100644 --- a/lisp/textmodes/page.el +++ b/lisp/textmodes/page.el @@ -141,7 +141,9 @@ count-lines-page (setq total (count-lines beg end) before (count-lines beg opoint) after (count-lines opoint end)) - (message "Page has %d lines (%d + %d)" total before after)))) + (message (ngettext "Page has %d line (%d + %d)" + "Page has %d lines (%d + %d)" total) + total before after)))) (defun what-page () "Print page and line number of point." -- 2.21.0 --------------B0F9A1297DF943F14A84822C-- ------------=_1560125102-30426-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 29 May 2019 09:34:36 +0000 Received: from localhost ([127.0.0.1]:58108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVuyi-0006cX-B3 for submit@debbugs.gnu.org; Wed, 29 May 2019 05:34:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVuyf-0006cK-Ub for submit@debbugs.gnu.org; Wed, 29 May 2019 05:34:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:33644) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hVuya-0000oA-RR for submit@debbugs.gnu.org; Wed, 29 May 2019 05:34:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVuyZ-0000XU-AU for bug-gnu-emacs@gnu.org; Wed, 29 May 2019 05:34:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVuyY-0000nW-Lc for bug-gnu-emacs@gnu.org; Wed, 29 May 2019 05:34:27 -0400 Received: from mail-it1-f171.google.com ([209.85.166.171]:36043) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hVuyY-0000n2-Hn for bug-gnu-emacs@gnu.org; Wed, 29 May 2019 05:34:26 -0400 Received: by mail-it1-f171.google.com with SMTP id e184so2453652ite.1 for ; Wed, 29 May 2019 02:34:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=goRE13WwzHd+WscwcuaA4c6qgUw+DssMqYolzxoHIt0=; b=I3dOZ60u1vVEXtFeBHmOwoaWKtqwk147NSqYOkEP/XYZG2D/F81RFEt4CfzfzHmrqp LqAKV6uer8PPaLhW7o+wE5Hw5pFTG1FU7ap1WHFIOEKS6BOYX/oqQCCrbuVRpjf++fvb KfeZZ1UcNcYdVwdxyPQJgJAIOEHKTjvQPCbuRw06HsfsrIh8rRLZOxCwP92B93f2yH7r +xa7z+oyVLFZ1Iw9LI7528DRNXck7jk8hhTrgAVdt6og+digsthxp1/x4sSMAsBoW7YB ffCSeqXOSu0eh85aw5uts06fhkyVAcZhuabZTxVNpy+76VSdHi2XRBHGeDAv1tqaW0r4 ipOg== X-Gm-Message-State: APjAAAVQyjK4KgvXEYcgZOyt+gCRbtOrNYr5vb/JKf+dbWw4FBO+a4QL AYHERGEnmgsP78H2X15IG/i86oCXPRw+Uy7VzM4UTsyk X-Google-Smtp-Source: APXvYqxCpp4IgxwAXQLvd3fsWqLPdSjkFK4dRsvg9MfRrDM5AZhhgN6fpoT+cxbnGCOXzKGGedLlX19ryyEgGxRucmk= X-Received: by 2002:a02:3506:: with SMTP id k6mr5968394jaa.41.1559122465048; Wed, 29 May 2019 02:34:25 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Wed, 29 May 2019 11:34:12 +0200 Message-ID: Subject: [PATCH] Use ngettext in `count-lines-page' To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000b0ee87058a037c0d" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.166.171 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --000000000000b0ee87058a037c0d Content-Type: text/plain; charset="UTF-8" See attached patch to correctly use ngettext in `count-lines-page' to get pluralization. Thanks, Stefan Kangas --000000000000b0ee87058a037c0d Content-Type: application/octet-stream; name="0001-Use-ngettext-in-count-lines-page.patch" Content-Disposition: attachment; filename="0001-Use-ngettext-in-count-lines-page.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jw918rka0 RnJvbSA5MzA5MmFhMThjYTQzNDhkMTRjMzE1NGE2ZmZiZGZjNTM1NTM2Y2JhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBXZWQsIDI5IE1heSAyMDE5IDExOjI3OjIyICswMjAwClN1YmplY3Q6IFtQQVRDSF0g VXNlIG5nZXR0ZXh0IGluIGBjb3VudC1saW5lcy1wYWdlJwoKKiB0ZXh0bW9kZXMvcGFnZS5lbCAo Y291bnQtbGluZXMtcGFnZSk6IFVzZSBuZ2V0dGV4dC4KLS0tCiBsaXNwL3RleHRtb2Rlcy9wYWdl LmVsIHwgNSArKysrLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlv bigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvdGV4dG1vZGVzL3BhZ2UuZWwgYi9saXNwL3RleHRtb2Rl cy9wYWdlLmVsCmluZGV4IDIyMGVmMmQ3ZmQuLjEzNzk4ODAzNzQgMTAwNjQ0Ci0tLSBhL2xpc3Av dGV4dG1vZGVzL3BhZ2UuZWwKKysrIGIvbGlzcC90ZXh0bW9kZXMvcGFnZS5lbApAQCAtMTQyLDcg KzE0MiwxMCBAQCBjb3VudC1saW5lcy1wYWdlCiAgICAgICAoc2V0cSB0b3RhbCAoY291bnQtbGlu ZXMgYmVnIGVuZCkKIAkgICAgYmVmb3JlIChjb3VudC1saW5lcyBiZWcgb3BvaW50KQogCSAgICBh ZnRlciAoY291bnQtbGluZXMgb3BvaW50IGVuZCkpCi0gICAgICAobWVzc2FnZSAiUGFnZSBoYXMg JWQgbGluZXMgKCVkICsgJWQpIiB0b3RhbCBiZWZvcmUgYWZ0ZXIpKSkpCisgICAgICAobWVzc2Fn ZSAiUGFnZSBoYXMgJXMgKCVkICsgJWQpIgorICAgICAgICAgICAgICAgKGZvcm1hdC1tZXNzYWdl IChuZ2V0dGV4dCAiJWQgbGluZSIgIiVkIGxpbmVzIiB0b3RhbCkgdG90YWwpCisgICAgICAgICAg ICAgICBiZWZvcmUKKyAgICAgICAgICAgICAgIGFmdGVyKSkpKQogCiAoZGVmdW4gd2hhdC1wYWdl ICgpCiAgICJQcmludCBwYWdlIGFuZCBsaW5lIG51bWJlciBvZiBwb2ludC4iCi0tIAoyLjIxLjAK Cg== --000000000000b0ee87058a037c0d-- ------------=_1560125102-30426-1--