GNU bug report logs - #3597
23.0.94; [PATCH] org-store-link broken within kbd macros

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andreas Seltenreich <seltenreich <at> gmx.de>
Subject: bug#3597: closed (Re: 23.0.94; [PATCH] org-store-link broken
 within kbd macros)
Date: Thu, 03 Mar 2011 21:16:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#3597: 23.0.94; [PATCH] org-store-link broken within kbd macros

which was filed against the emacs,org-mode package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 3597 <at> debbugs.gnu.org.

-- 
3597: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3597
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 3597-done <at> debbugs.gnu.org
Subject: Re: 23.0.94; [PATCH] org-store-link broken within kbd macros
Date: Thu, 03 Mar 2011 16:15:42 -0500

Version: 23.2

Looks like this patch was in 23.2.

[Message part 3 (message/rfc822, inline)]

From: Andreas Seltenreich <seltenreich <at> gmx.de>
To: emacs-pretest-bug <at> gnu.org
Cc: emacs-orgmode <at> gnu.org
Subject: 23.0.94; [PATCH] org-store-link broken within kbd macros
Date: Wed, 17 Jun 2009 13:15:38 +0200

> Your bug report will be posted to the emacs-pretest-bug <at> gnu.org mailing list.

> Please describe exactly what actions triggered the bug
> and the precise symptoms of the bug:

org-store-link works fine when recording a keyboard macro but it is a
NOP when executing it.  The following change appears to fix it.

regards,
andreas

> In GNU Emacs 23.0.94.1 (x86_64-unknown-linux-gnu)
>  of 2009-05-28 on tengen

--8<---------------cut here---------------start------------->8---
*** org.el.~1.48.~	2009-02-20 10:02:49.000000000 +0100
--- org.el	2009-06-17 12:55:15.000000000 +0200
***************
*** 6594,6600 ****
  	  desc (or desc cpltxt))
      (if (equal desc "NONE") (setq desc nil))
  
!     (if (and (interactive-p) link)
  	(progn
  	  (setq org-stored-links
  		(cons (list link desc) org-stored-links))
--- 6594,6600 ----
  	  desc (or desc cpltxt))
      (if (equal desc "NONE") (setq desc nil))
  
!     (if (and (or (interactive-p) executing-kbd-macro) link)
  	(progn
  	  (setq org-stored-links
  		(cons (list link desc) org-stored-links))
--8<---------------cut here---------------end--------------->8---

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.