GNU bug report logs - #35968
Release 26.3

Previous Next

Package: emacs;

Reported by: npostavs <at> gmail.com

Date: Tue, 28 May 2019 21:15:02 UTC

Severity: normal

Fixed in version 26.3

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

Forwarded to https://lists.gnu.org/archive/html/emacs-devel/2019-08/msg00577.html

Full log

View this message in rfc822 format

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 35968 <at> debbugs.gnu.org
Subject: bug#35968: Proposed clean-compile patches for release 26.3
Date: Thu, 30 May 2019 15:30:15 -0700

On 5/30/19 7:03 AM, Eli Zaretskii wrote:
> This hunk seems to be just an aesthetic cleanup. Does it cause any 
> warnings/errors during compilation? If not, I'd prefer to leave it 
> out, for paranoia reasons.

Yes, if the hunk is omitted, _fraghead is defined twice and GCC complains:

  gmalloc.c:353:20: error: redundant redeclaration of ‘_fraghead’ 
[-Werror=redundant-decls]
    353 | static struct list _fraghead[BLOCKLOG];
    |                    ^~~~~~~~~
  gmalloc.c:185:20: note: previous declaration of ‘_fraghead’ was here
    185 | static struct list _fraghead[BLOCKLOG];
    |                    ^~~~~~~~~

So I installed the patches as-is.
This bug report was last modified 5 years and 344 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.