GNU bug report logs - #35967
[PATCH] avoid flyspell error if point is at bob

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alex Branham <alex.branham <at> gmail.com>
Cc: 35967 <at> debbugs.gnu.org
Subject: bug#35967: [PATCH] avoid flyspell error if point is at bob
Date: Wed, 29 May 2019 19:08:18 +0300

> From: Alex Branham <alex.branham <at> gmail.com>
> Date: Tue, 28 May 2019 15:43:53 -0500
> 
> >From e130dfcb542af667fbef6e6eb867c46eee6d9746 Mon Sep 17 00:00:00 2001
> From: Alex Branham <alex.branham <at> gmail.com>
> Date: Tue, 28 May 2019 15:40:26 -0500
> Subject: [PATCH] Avoid a flyspell error if point is at beginning of buffer
> 
> * lisp/textmodes/flyspell.el (flyspell-generic-progmode-verify):
> Check if point is at bob.  This prevents an error when e.g.
> 'flyspell-auto-correct-word' gets called with point at the
> beginning of the buffer.
> ---
>  lisp/textmodes/flyspell.el | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/lisp/textmodes/flyspell.el b/lisp/textmodes/flyspell.el
> index d18916dfd0..e711fe72b2 100644
> --- a/lisp/textmodes/flyspell.el
> +++ b/lisp/textmodes/flyspell.el
> @@ -424,8 +424,9 @@ like <img alt=\"Some thing.\">."
>  (defun flyspell-generic-progmode-verify ()
>    "Used for `flyspell-generic-check-word-predicate' in programming modes."
>    ;; (point) is next char after the word. Must check one char before.
> -  (let ((f (get-text-property (- (point) 1) 'face)))
> -    (memq f flyspell-prog-text-faces)))
> +  (unless (bobp)
> +    (let ((f (get-text-property (- (point) 1) 'face)))
> +      (memq f flyspell-prog-text-faces))))

Thanks.

Maybe it's just me, but whenever I see bobp, I always have to consult
the docs regarding what happens in a narrowed buffer.  For that
reason, I prefer comparison with point-min instead.

Am I the only one troubled by that?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.