GNU bug report logs - #35940
[PATCH] bookmark.el: Remove support for renaming ancient "~/.emacs-bkmrks" file

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35940 in the body.
You can then email your comments to 35940 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] bookmark.el: Remove support for renaming ancient
 "~/.emacs-bkmrks" file
Date: Tue, 28 May 2019 03:23:26 +0200

[Message part 1 (text/plain, inline)]

Since at least 1995, there has been a variable `bookmark-old-default-file'
referring to an old default file name "~/.emacs-bkmrks", and some
accompanying code to rename from the old file name to the new one.

Since it's extremely unlikely that someone has a need to recover this kind
of file from before 1995 and use it in a modern Emacs, I think it's about
time to retire this code.  Please see the attached patch for a suggestion.

Thanks,
Stefan Kangas

[0001-Make-bookmark-old-default-file-variable-obsolete.patch (application/octet-stream, attachment)]

Message #8 received at 35940 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 35940 <at> debbugs.gnu.org
Subject: Re: bug#35940: [PATCH] bookmark.el: Remove support for renaming
 ancient "~/.emacs-bkmrks" file
Date: Thu, 30 May 2019 13:08:17 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

> Since at least 1995, there has been a variable `bookmark-old-default-file'
> referring to an old default file name "~/.emacs-bkmrks", and some
> accompanying code to rename from the old file name to the new one.
>
> Since it's extremely unlikely that someone has a need to recover this kind
> of file from before 1995 and use it in a modern Emacs, I think it's about
> time to retire this code.  Please see the attached patch for a suggestion.

Looks fine to me, but I suggest simultaneously making bookmark-file
(the old name of bookmark-default-file[1]) an obsolete varalias of
bookmark-default-file.

[1: e343798900]: Insure that all entry points call [...]
  1995-03-11 02:05:20 +0000
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e34379890042bdb66263d962e845328ac0b63f67

Thanks,

-- 
Basil

Message #11 received at 35940 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 35940 <at> debbugs.gnu.org
Subject: Re: bug#35940: [PATCH] bookmark.el: Remove support for renaming
 ancient "~/.emacs-bkmrks" file
Date: Thu, 30 May 2019 14:23:53 +0200

Thank you for having a look.

Basil L. Contovounesios <contovob <at> tcd.ie> writes:
> Looks fine to me, but I suggest simultaneously making bookmark-file
> (the old name of bookmark-default-file[1]) an obsolete varalias of
> bookmark-default-file.

Agreed, I've actually already submitted a separate patch for that:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35917

Thanks,
Stefan Kangas

Message #14 received at 35940 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 35940 <at> debbugs.gnu.org
Subject: Re: bug#35940: [PATCH] bookmark.el: Remove support for renaming
 ancient "~/.emacs-bkmrks" file
Date: Thu, 30 May 2019 13:50:43 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

> Thank you for having a look.

Thank you for working on this.

> Basil L. Contovounesios <contovob <at> tcd.ie> writes:
>> Looks fine to me, but I suggest simultaneously making bookmark-file
>> (the old name of bookmark-default-file[1]) an obsolete varalias of
>> bookmark-default-file.
>
> Agreed, I've actually already submitted a separate patch for that:
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35917

Right, I saw that just after I sent my previous message.

Both changes LGTM, so I'll push them in the coming week if there are no
other comments before then and no-one beats me to it.

But could you please first amend the commit messages to mention their
bug#numbers and list file names relative to the project root,
i.e. lisp/bookmark.el instead of bookmark.el?

Thanks,

-- 
Basil

Message #17 received at 35940 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 35940 <at> debbugs.gnu.org
Subject: Re: bug#35940: [PATCH] bookmark.el: Remove support for renaming
 ancient "~/.emacs-bkmrks" file
Date: Wed, 5 Jun 2019 13:02:49 +0200

[Message part 1 (text/plain, inline)]

[Accidentally sent this only to Basil - sorry about that. Resending.]

Basil L. Contovounesios <contovob <at> tcd.ie> writes:
> Both changes LGTM, so I'll push them in the coming week if there are no
> other comments before then and no-one beats me to it.

Very good, thanks.

> But could you please first amend the commit messages to mention their
> bug#numbers and list file names relative to the project root,
> i.e. lisp/bookmark.el instead of bookmark.el?

Sure, I've attached a fixed patch here and I'll send new versions of
the others too.

Thanks,
Stefan Kangas

[Message part 2 (text/html, inline)]

[0001-Make-bookmark-old-default-file-variable-obsolete-2.patch (application/octet-stream, attachment)]

Message #22 received at 35940-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 35940-done <at> debbugs.gnu.org
Subject: Re: bookmark.el: Remove support for renaming ancient
 "~/.emacs-bkmrks" file
Date: Sun, 9 Jun 2019 16:49:01 -0700

Thanks, I installed that.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.