From unknown Sat Jun 14 14:24:58 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#35935 <35935@debbugs.gnu.org> To: bug#35935 <35935@debbugs.gnu.org> Subject: Status: [PATCH] guix: import: simplify recursive import Reply-To: bug#35935 <35935@debbugs.gnu.org> Date: Sat, 14 Jun 2025 21:24:58 +0000 retitle 35935 [PATCH] guix: import: simplify recursive import reassign 35935 guix-patches submitter 35935 Robert Vollmert severity 35935 normal tag 35935 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon May 27 16:07:48 2019 Received: (at submit) by debbugs.gnu.org; 27 May 2019 20:07:48 +0000 Received: from localhost ([127.0.0.1]:54218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVLuN-0008WO-Q5 for submit@debbugs.gnu.org; Mon, 27 May 2019 16:07:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVLuL-0008WA-LS for submit@debbugs.gnu.org; Mon, 27 May 2019 16:07:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:51510) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hVLuG-0006FD-KK for submit@debbugs.gnu.org; Mon, 27 May 2019 16:07:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVLuF-0004MC-D6 for guix-patches@gnu.org; Mon, 27 May 2019 16:07:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVLuE-0006Cm-Bj for guix-patches@gnu.org; Mon, 27 May 2019 16:07:39 -0400 Received: from mx1.mailbox.org ([2001:67c:2050:104:0:1:25:1]:59276) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hVLuE-0006AD-3m for guix-patches@gnu.org; Mon, 27 May 2019 16:07:38 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx1.mailbox.org (Postfix) with ESMTPS id 6EA654C4B8; Mon, 27 May 2019 22:07:35 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter03.heinlein-hosting.de (spamfilter03.heinlein-hosting.de [80.241.56.117]) (amavisd-new, port 10030) with ESMTP id u6BsX2mUdSP8; Mon, 27 May 2019 22:07:34 +0200 (CEST) From: Robert Vollmert To: guix-patches@gnu.org Subject: [PATCH] guix: import: simplify recursive import Date: Mon, 27 May 2019 22:07:31 +0200 Message-Id: <20190527200731.59990-1-rob@vllmrt.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:67c:2050:104:0:1:25:1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: Robert Vollmert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) This simplifies the logic of recursive-import, intending no major functional changes. The package import function is no longer called twice per package. Failed imports now make it to the package stream as '() instead of #f. * guix/import/utils.scm: Simplify recursive-import. --- guix/import/utils.scm | 86 ++++++++++++++++--------------------------- 1 file changed, 32 insertions(+), 54 deletions(-) diff --git a/guix/import/utils.scm b/guix/import/utils.scm index 516c0cfaa2..ff548b809a 100644 --- a/guix/import/utils.scm +++ b/guix/import/utils.scm @@ -378,57 +378,35 @@ separated by PRED." #:allow-other-keys) "Generate a stream of package expressions for PACKAGE-NAME and all its dependencies." - (receive (package . dependencies) - (repo->guix-package package-name repo) - (if (not package) - stream-null - - ;; Generate a lazy stream of package expressions for all unknown - ;; dependencies in the graph. - (let* ((make-state (lambda (queue done) - (cons queue done))) - (next (match-lambda - (((next . rest) . done) next))) - (imported (match-lambda - ((queue . done) done))) - (done? (match-lambda - ((queue . done) - (zero? (length queue))))) - (unknown? (lambda* (dependency #:optional (done '())) - (and (not (member dependency - done)) - (null? (find-packages-by-name - (guix-name dependency)))))) - (update (lambda (state new-queue) - (match state - (((head . tail) . done) - (make-state (lset-difference - equal? - (lset-union equal? new-queu= e tail) - done) - (cons head done))))))) - (stream-cons - package - (stream-unfold - ;; map: produce a stream element - (lambda (state) - (repo->guix-package (next state) repo)) - - ;; predicate - (negate done?) - - ;; generator: update the queue - (lambda (state) - (receive (package . dependencies) - (repo->guix-package (next state) repo) - (if package - (update state (filter (cut unknown? <> - (cons (next state) - (imported state))) - (car dependencies))) - ;; TODO: Try the other archives before giving up - (update state (imported state))))) - - ;; initial state - (make-state (filter unknown? (car dependencies)) - (list package-name)))))))) + (define (exists? dependency) + (not (null? (find-packages-by-name (guix-name dependency))))) + (define initial-state (list #f (list package-name) (list))) + (define (step state) + (match state + ((prev (next . rest) done) + (define (handle? dep) + (and + (not (equal? dep next)) + (not (member dep done)) + (not (exists? dep)))) + (receive (package . dependencies) (repo->guix-package next repo) + (list + (if package package '()) ;; default #f on failure would inter= rupt + (if package + (lset-union equal? rest (filter handle? (car dependencies))= ) + rest) + (cons next done)))) + ((prev '() done) + (list #f '() done)))) + + ;; Generate a lazy stream of package expressions for all unknown + ;; dependencies in the graph. + (stream-unfold + ;; map: produce a stream element + (match-lambda ((latest queue done) latest)) + ;; predicate + (match-lambda ((latest queue done) latest)) + ;; generator: update the queue + step + ;; initial state + (step initial-state))) --=20 2.20.1 (Apple Git-117) From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 02 15:52:59 2019 Received: (at 35935) by debbugs.gnu.org; 2 Jun 2019 19:52:59 +0000 Received: from localhost ([127.0.0.1]:40920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXWXL-0003IA-Hv for submit@debbugs.gnu.org; Sun, 02 Jun 2019 15:52:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53573) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXWXJ-0003Hx-DO for 35935@debbugs.gnu.org; Sun, 02 Jun 2019 15:52:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57942) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hXWXB-0001vx-1N; Sun, 02 Jun 2019 15:52:49 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59328 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hXWXA-0004S6-6D; Sun, 02 Jun 2019 15:52:48 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Robert Vollmert Subject: Re: [bug#35935] [PATCH] guix: import: simplify recursive import References: <20190527200731.59990-1-rob@vllmrt.net> Date: Sun, 02 Jun 2019 21:52:45 +0200 In-Reply-To: <20190527200731.59990-1-rob@vllmrt.net> (Robert Vollmert's message of "Mon, 27 May 2019 22:07:31 +0200") Message-ID: <87a7ez933m.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35935 Cc: Oleg Pykhalov , 35935@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Robert, Robert Vollmert skribis: > This simplifies the logic of recursive-import, intending no > major functional changes. The package import function is no > longer called twice per package. Failed imports now make it > to the package stream as '() instead of #f. > > * guix/import/utils.scm: Simplify recursive-import. ^ Minor issue: please make sure to mention the modified entities here (procedures, variables, etc.); see . I think Oleg worked on this part before; Oleg, could you comment and/or apply? =E2=80=98tests/import-utils.scm=E2=80=99 doesn=E2=80=99t seem to be testing= this procedure, perhaps that=E2=80=99s something we should fix eventually. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 02 16:19:59 2019 Received: (at 35935) by debbugs.gnu.org; 2 Jun 2019 20:20:00 +0000 Received: from localhost ([127.0.0.1]:40958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXWxT-00066c-Jr for submit@debbugs.gnu.org; Sun, 02 Jun 2019 16:19:59 -0400 Received: from mx1.mailbox.org ([80.241.60.212]:9706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXWxQ-00066N-Fb for 35935@debbugs.gnu.org; Sun, 02 Jun 2019 16:19:57 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx1.mailbox.org (Postfix) with ESMTPS id 465D84EC96; Sun, 2 Jun 2019 22:19:49 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter02.heinlein-hosting.de (spamfilter02.heinlein-hosting.de [80.241.56.116]) (amavisd-new, port 10030) with ESMTP id EuCXGjy9REJP; Sun, 2 Jun 2019 22:19:48 +0200 (CEST) From: Robert Vollmert To: 35935@debbugs.gnu.org Subject: [PATCH] guix: import: Simplify recursive import. Date: Sun, 2 Jun 2019 22:19:46 +0200 Message-Id: <20190602201946.84145-1-rob@vllmrt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 35935 Cc: Robert Vollmert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This simplifies the logic of recursive-import, intending no major functional changes. The package import function is no longer called twice per package. Failed imports now make it to the package stream as '() instead of #f. * guix/import/utils.scm (recursive-import): Simplify. --- guix/import/utils.scm | 86 ++++++++++++++++--------------------------- 1 file changed, 32 insertions(+), 54 deletions(-) diff --git a/guix/import/utils.scm b/guix/import/utils.scm index 516c0cfaa2..ff548b809a 100644 --- a/guix/import/utils.scm +++ b/guix/import/utils.scm @@ -378,57 +378,35 @@ separated by PRED." #:allow-other-keys) "Generate a stream of package expressions for PACKAGE-NAME and all its dependencies." - (receive (package . dependencies) - (repo->guix-package package-name repo) - (if (not package) - stream-null - - ;; Generate a lazy stream of package expressions for all unknown - ;; dependencies in the graph. - (let* ((make-state (lambda (queue done) - (cons queue done))) - (next (match-lambda - (((next . rest) . done) next))) - (imported (match-lambda - ((queue . done) done))) - (done? (match-lambda - ((queue . done) - (zero? (length queue))))) - (unknown? (lambda* (dependency #:optional (done '())) - (and (not (member dependency - done)) - (null? (find-packages-by-name - (guix-name dependency)))))) - (update (lambda (state new-queue) - (match state - (((head . tail) . done) - (make-state (lset-difference - equal? - (lset-union equal? new-queue tail) - done) - (cons head done))))))) - (stream-cons - package - (stream-unfold - ;; map: produce a stream element - (lambda (state) - (repo->guix-package (next state) repo)) - - ;; predicate - (negate done?) - - ;; generator: update the queue - (lambda (state) - (receive (package . dependencies) - (repo->guix-package (next state) repo) - (if package - (update state (filter (cut unknown? <> - (cons (next state) - (imported state))) - (car dependencies))) - ;; TODO: Try the other archives before giving up - (update state (imported state))))) - - ;; initial state - (make-state (filter unknown? (car dependencies)) - (list package-name)))))))) + (define (exists? dependency) + (not (null? (find-packages-by-name (guix-name dependency))))) + (define initial-state (list #f (list package-name) (list))) + (define (step state) + (match state + ((prev (next . rest) done) + (define (handle? dep) + (and + (not (equal? dep next)) + (not (member dep done)) + (not (exists? dep)))) + (receive (package . dependencies) (repo->guix-package next repo) + (list + (if package package '()) ;; default #f on failure would interrupt + (if package + (lset-union equal? rest (filter handle? (car dependencies))) + rest) + (cons next done)))) + ((prev '() done) + (list #f '() done)))) + + ;; Generate a lazy stream of package expressions for all unknown + ;; dependencies in the graph. + (stream-unfold + ;; map: produce a stream element + (match-lambda ((latest queue done) latest)) + ;; predicate + (match-lambda ((latest queue done) latest)) + ;; generator: update the queue + step + ;; initial state + (step initial-state))) -- 2.20.1 (Apple Git-117) From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 02 16:24:14 2019 Received: (at 35935) by debbugs.gnu.org; 2 Jun 2019 20:24:14 +0000 Received: from localhost ([127.0.0.1]:40972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXX1Z-0006EY-SR for submit@debbugs.gnu.org; Sun, 02 Jun 2019 16:24:14 -0400 Received: from mx2.mailbox.org ([80.241.60.215]:60828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXX1X-0006EK-Fw for 35935@debbugs.gnu.org; Sun, 02 Jun 2019 16:24:12 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx2.mailbox.org (Postfix) with ESMTPS id B5F50A1052; Sun, 2 Jun 2019 22:24:04 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter03.heinlein-hosting.de (spamfilter03.heinlein-hosting.de [80.241.56.117]) (amavisd-new, port 10030) with ESMTP id rGbYkUKKel-Q; Sun, 2 Jun 2019 22:23:56 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [bug#35935] [PATCH] guix: import: simplify recursive import From: Robert Vollmert In-Reply-To: <87a7ez933m.fsf@gnu.org> Date: Sun, 2 Jun 2019 22:23:56 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20190527200731.59990-1-rob@vllmrt.net> <87a7ez933m.fsf@gnu.org> To: =?utf-8?Q?Ludovic_Court=C3=A8s?= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 35935 Cc: 35935@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > On 2. Jun 2019, at 21:52, Ludovic Court=C3=A8s wrote: > Robert Vollmert skribis: >> * guix/import/utils.scm: Simplify recursive-import. > ^ > Minor issue: please make sure to mention the modified entities here > (procedures, variables, etc.); see > . Fixed, thanks for the heads up. > I think Oleg worked on this part before; Oleg, could you comment > and/or apply? >=20 > =E2=80=98tests/import-utils.scm=E2=80=99 doesn=E2=80=99t seem to be = testing this procedure, > perhaps that=E2=80=99s something we should fix eventually. Agreed. It does seem to be covered somewhat by tests/gem.scm. I also tested it a bit by hand, with some haskell packages. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 03 15:56:37 2019 Received: (at 35935) by debbugs.gnu.org; 3 Jun 2019 19:56:38 +0000 Received: from localhost ([127.0.0.1]:43196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXt4P-0000Q0-Mo for submit@debbugs.gnu.org; Mon, 03 Jun 2019 15:56:37 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:43327) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXt4O-0000Po-Fz for 35935@debbugs.gnu.org; Mon, 03 Jun 2019 15:56:37 -0400 Received: by mail-wr1-f65.google.com with SMTP id r18so4384663wrm.10 for <35935@debbugs.gnu.org>; Mon, 03 Jun 2019 12:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=mPrAP8Hvy0IacoiB2+bZPQ3wEACihglyDTu9Hmf1Kgg=; b=Lu5z6EIN1g653eP7N7GqdFI3ejYe2KoGfore+KjCtJLPRfDPCOie6rep4wejT3VK94 p2fco2oavdUnnrXL8uzNgvPEbpvKK8OEtIQ5LlPRhzAgGwx+9Ad3Y6WTk2lqXguIOFmq z/kdxkCU8h//7UiQMlrbvZSeLP6Y+/UB2TbKejaJDHTjuZorxo7jTt3UgR0xFQ4IQX4V vT+x/1+RDoZM/wJXrlQOdU62IRG8zH8AZlzsHP4PlGHrBfx1efWLsQ5U/mefl3XLER3E oSazEhYoJTzGOSdjnPFVLz6Wk+FIQNQ9t5ceKtvL+LRclYG0LNTh6z0J6g38kwozUPj5 aC2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=mPrAP8Hvy0IacoiB2+bZPQ3wEACihglyDTu9Hmf1Kgg=; b=IlP/iJIYycIM2Md2aB/n/8q8XYcqog+SZrm0Y4UDTJ/fBY5g5WquCItBBKaNP38uSL V1hszWiyGD6ph0HitvHDzLr+J0Z5wE90Z7QIXbBfRPI74+wsixFuCayej4VCc/LcVFn7 NqnVCZ3OPhWDO5EHMBoPCclZeyZiQyXRvNEEao3D+yfK0pE+1Z0sj4SfxL5AvjR+gj59 OVBHEXDxkD8IAemLrMlfwZzTCh3a+YH/YyKqtSI8ADwLpeBwEaSXMPkJYKFsZnuqhZsP ZYqyQmlajU9f6CzNb39Xd6GdMCVJn7V6zQ2XpsRqDqA1PVDDI9XGGHuUTyRXKzIG1r/y oinA== X-Gm-Message-State: APjAAAWC0I0VQAAQLNR4JqfriL09AHWERsrzn6HKBphr2qbYXvX/sYEU d7w7IuxToxihk31zDsjY2O5ioH4nUxE= X-Google-Smtp-Source: APXvYqwERzcf47JnMSHeq9puIHVK2H6r7aZtfeXBp+suKvbAhjtc6jg3AWLBL1AszxDmptSS8N2Q2Q== X-Received: by 2002:a5d:6243:: with SMTP id m3mr4138809wrv.41.1559591790141; Mon, 03 Jun 2019 12:56:30 -0700 (PDT) Received: from guixsd (ppp78-37-144-173.pppoe.avangarddsl.ru. [78.37.144.173]) by smtp.gmail.com with ESMTPSA id 6sm29572050wrd.51.2019.06.03.12.56.29 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 03 Jun 2019 12:56:29 -0700 (PDT) From: Oleg Pykhalov To: Robert Vollmert Subject: Re: [bug#35935] [PATCH] guix: import: simplify recursive import References: <20190527200731.59990-1-rob@vllmrt.net> <87a7ez933m.fsf@gnu.org> Date: Mon, 03 Jun 2019 22:56:21 +0300 In-Reply-To: (Robert Vollmert's message of "Sun, 2 Jun 2019 22:23:56 +0200") Message-ID: <871s0asasa.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35935 Cc: 35935@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Robert, Robert Vollmert writes: [=E2=80=A6] >> I think Oleg worked on this part before; Oleg, could you comment >> and/or apply? >>=20 >> =E2=80=98tests/import-utils.scm=E2=80=99 doesn=E2=80=99t seem to be test= ing this procedure, >> perhaps that=E2=80=99s something we should fix eventually. > > Agreed. It does seem to be covered somewhat by tests/gem.scm. > I also tested it a bit by hand, with some haskell packages. True, =E2=80=98tests/gem.scm=E2=80=99 file tests =E2=80=98recursive-import= =E2=80=99 procedure by invoking =E2=80=98gem-recursive-import=E2=80=99. I think this test is good= enough for our purpose - use =E2=80=98recursive-import=E2=80=99 in other package impor= ters and make sure it works. Thoughts? I also added a copyright line if you don't mind: ;;; Copyright =C2=A9 2019 Robert Vollmert Is it OK, Robert? I tested manually with =E2=80=98gem=E2=80=99 and =E2=80= =98elpa=E2=80=99 recursive importers and ready to push :-) Thanks, Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAlz1e2UACgkQFn+OpQAa +pzY1w/+Kdon/5c5DEmX+HjdDSBc0TUm0iiJefO6k9YOHyCQG6SlBa0L47J309t0 irg2ViUffM5vjbkCaPwXeOKxTsENpOqGKKduyU7LXNBRFzXi69Ky2zbTW4rFX/3N gfnpTVgq6Myof0XIa1qLFmyWujZcMJ16JCxd68OYQDhTEcS9WE8bQZlGStNgRXwC Uzj0wRSSgG0dyeqk045BYjL/GEVbhw8QTz8CtiFgutIMRtcF7xNntNjDSZKJpjw9 lAbJLACkHP6qyBWa8TmwLaeIIxnUqhNo90Me3orWEJOsd/gfVsMtPnZ3HZNPW251 zWU0kw7kPZW+bCX0R56Qr19+oXcthYY7UZ+V+ChlgSCb06COzqCaURod5f/oXeFQ IOJSg3MY+GyYWmP3riH5vGQi9zQT2zHF3E18P7YokzsZKSaPuwVUPBbCV8kMM2n9 F4cRPqM6AOK1RouTmOI5GyRpJY6i8shaBU5zO/nQLrfCl3KVsBv24jwhpZY+h4Tf aM9Llyu771lGf+2uBW+e6LnoYt8NLrX/QUAsRfJ0Gf+moZVJ4A/SL+dvcAx558y3 qLeSfiupcNVkzhy8xeE2XrPrXiDx0sVV2NL+DaCmfPFhKXDczeRsd6WCdQlNDJxm ADn8mELirdktFebJMdo6kUR+QcIFNJOr6MdswiMHZ2jgkwaqlYw= =cPSA -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 03 15:59:40 2019 Received: (at 35935) by debbugs.gnu.org; 3 Jun 2019 19:59:40 +0000 Received: from localhost ([127.0.0.1]:43208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXt7L-0000at-JF for submit@debbugs.gnu.org; Mon, 03 Jun 2019 15:59:40 -0400 Received: from mx1.mailbox.org ([80.241.60.212]:41760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXt7J-0000aJ-Br for 35935@debbugs.gnu.org; Mon, 03 Jun 2019 15:59:38 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx1.mailbox.org (Postfix) with ESMTPS id 347EB5080F; Mon, 3 Jun 2019 21:59:31 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter05.heinlein-hosting.de (spamfilter05.heinlein-hosting.de [80.241.56.123]) (amavisd-new, port 10030) with ESMTP id Fqr4P1cmrZK4; Mon, 3 Jun 2019 21:59:25 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [bug#35935] [PATCH] guix: import: simplify recursive import From: Robert Vollmert In-Reply-To: <871s0asasa.fsf@gmail.com> Date: Mon, 3 Jun 2019 21:59:24 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <9002D873-4504-4F35-A229-238316ACEC71@vllmrt.net> References: <20190527200731.59990-1-rob@vllmrt.net> <87a7ez933m.fsf@gnu.org> <871s0asasa.fsf@gmail.com> To: Oleg Pykhalov X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 35935 Cc: 35935@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Oleg, thanks for having a look. > On 3. Jun 2019, at 21:56, Oleg Pykhalov wrote: [=E2=80=A6] > I also added a copyright line if you don't mind: >=20 > ;;; Copyright =C2=A9 2019 Robert Vollmert >=20 > Is it OK, Robert? I tested manually with =E2=80=98gem=E2=80=99 and = =E2=80=98elpa=E2=80=99 recursive > importers and ready to push :-) Yes, of course. (Should I generally be adding copyright lines when edit a file? Cheers Robert From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 03 16:31:16 2019 Received: (at 35935-done) by debbugs.gnu.org; 3 Jun 2019 20:31:16 +0000 Received: from localhost ([127.0.0.1]:43263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXtbu-0001oD-MS for submit@debbugs.gnu.org; Mon, 03 Jun 2019 16:31:16 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:45327) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXtbr-0001ny-4r for 35935-done@debbugs.gnu.org; Mon, 03 Jun 2019 16:31:12 -0400 Received: by mail-wr1-f66.google.com with SMTP id b18so13454031wrq.12 for <35935-done@debbugs.gnu.org>; Mon, 03 Jun 2019 13:31:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=p3K6zECRypNNK/GDtvxh38dgRT53wO+aDyNVpptdiEU=; b=ORRl9WN4O8YgFWUMY9RUZofW7xboDcFeSEd6DelxOAh4iccFm+a3oBdh/5IjKB5Ecj AZjVIN/XD/Q+nK8eP32WxWrnyKAxQfxfm5FK7It30zRpo6GeCWwy84l4wqs5By6PDX0w LbSsfURNxlP5w7PjxCncN0DNmiXXS/IoWXehudajkUNQeNqP5GmpoEqLyh2DpPVJ2VhD A4DvvCaQDFAfEQcnOtvHwid5x3kGqAL6sHNFwHWqzt1+UYcjU9DYcUXYWAKhTNWnzSQ8 kxQRcsdemfQNy6BOPmxaS9+Ik6jVF24tlUHx/aKpybrK+ZF46tfVCthmLQllCZaXB40W fjmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=p3K6zECRypNNK/GDtvxh38dgRT53wO+aDyNVpptdiEU=; b=FI9n4Ffh+EOxKoToldctfngd44prCoGc176lotGI7AbsACKSJh6trdwnkksQYtk/hx 3lo2oI6oO6z4vP0DAbJYWRpeWqaKmz0Gdt2mIeJcMTd/666hsa3hpzAwHtScC32yr1Lw VBY4ZrW7e+x2SWSMa7m3KZBIeYk2LkNzkDYJ/HZvAqiu2nS53i+KrSwoxqWpArU3en0y hd5HRDPr69gSbNKJ69UgH270tlSYgWOk0oRZv2acHUo05g7N898wtyhBlelzvai4jrjS 4jE0sXA7dKQAQg7C3N0tLI6vJpoJkaLeqLwtjTRtBUBwRnVSIx025IebIxTS5rM1i8bO Ahdw== X-Gm-Message-State: APjAAAWXzkWdyBZGguZ18haM95nt7yL1+shTLg+i68nX4vMAJRAejCV4 QkMuQHufiHvooA8oy98Vwfdlsi75ZDY= X-Google-Smtp-Source: APXvYqzGspNHPUZ2anOPQ9guMVB7/Tr0Y4nOo/VS0O7Sp0Oqr6JHteCzBrZqBG9vHtiwDd+I9dSjAA== X-Received: by 2002:a5d:6709:: with SMTP id o9mr3943146wru.301.1559593865098; Mon, 03 Jun 2019 13:31:05 -0700 (PDT) Received: from guixsd (ppp78-37-144-173.pppoe.avangarddsl.ru. [78.37.144.173]) by smtp.gmail.com with ESMTPSA id j82sm14340427wmj.40.2019.06.03.13.31.03 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 03 Jun 2019 13:31:03 -0700 (PDT) From: Oleg Pykhalov To: Robert Vollmert Subject: Re: [bug#35935] [PATCH] guix: import: simplify recursive import References: <20190527200731.59990-1-rob@vllmrt.net> <87a7ez933m.fsf@gnu.org> <871s0asasa.fsf@gmail.com> <9002D873-4504-4F35-A229-238316ACEC71@vllmrt.net> Date: Mon, 03 Jun 2019 23:31:00 +0300 In-Reply-To: <9002D873-4504-4F35-A229-238316ACEC71@vllmrt.net> (Robert Vollmert's message of "Mon, 3 Jun 2019 21:59:24 +0200") Message-ID: <87woi2qum3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 35935-done Cc: 35935-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Robert Vollmert writes: [=E2=80=A6] >> I also added a copyright line if you don't mind: >>=20 >> ;;; Copyright =C2=A9 2019 Robert Vollmert >>=20 >> Is it OK, Robert? I tested manually with =E2=80=98gem=E2=80=99 and =E2= =80=98elpa=E2=80=99 recursive >> importers and ready to push :-) > > Yes, of course. (Should I generally be adding copyright lines when edit > a file? Yes. Pushed as 5b315f3ea93020df52bc11105064a1398687e572 to master. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAlz1g4QACgkQFn+OpQAa +pybJg/+MJhqXBXGg08+6md58IZH76e9GWEceDGdBcrxgue8k7/QYxEazljo6Xcc KLUIqMn3tIXOonCBKKE6oJz10O2EUUyloigl2QMmSx+kjpmcM/YAvZe4eo+M2rbV oBhOqXjTndLnMsukIqIIXH9Qk/WAdEFchS/A2ueh3/zQmzQSv4cBXA2hpCB9sprC b1c3xi1VMv8qeIfhqgi5a8SPxFDRNlekvRNvELSRttKj718YzcBDCg6JJy7Z4S9o 26ZDr+6bljddO2lPavgXhdhD+FCwn1Q1QPGuKLwVi8L+9Q2GEuLlIZ456fatc7DB PcFdiFYx1KiqRQ0qDeg9O5l0YWrZNviTzZ96oKsYmKOCZstLbdpffL1RlGk1R5UP YgCJjfa/TxgfGHehEp97rh3E9w+Gnwzti7DU5rzAdZc35xFVLHUuEku5uWAG7l5n sieoMcqdT49xiRT4IqJxGypVBKYOC/ez7A4PFEZewcvgnWJQo4BtSIfu8VCIkLwe +Nvx9V/Sx2wGJFUgOpCozt6Y9+uyPWAMpE7Z04zzwWy677MoqB7umqlWSQYe0ejk HkicufuPz8wyjAo3JNplhE3ewz8VLATgF0wGZ92lZhx4lPmzN0dIJlJDJjyszqGB nQnotjhHjl1/Pi2WRNsYtlwNOBqJJt+OaCEoaUJtnxmcdXAone8= =jku5 -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Jun 14 14:24:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 02 Jul 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator