Subject: bug#35918: [PATCH] bookmark.el: Make bookmark-maybe-message obsolete

From: Stefan Kangas <[email-masked]>
Date: Sun, 26 May 2019 14:45:36 +0200

The `bookmark-maybe-message' function checks the `baud-rate' variable before
displaying a message.  I don't believe this is necessary nowadays.

I therefore suggest that we make it an obsolete function alias for
`message'.

Thanks,
Stefan Kangas
From a030df951f35f9accc9138728c3968f512084efe Mon Sep 17 00:00:00 2001
From: Stefan Kangas <[email-masked]>
Date: Sun, 26 May 2019 14:32:55 +0200
Subject: [PATCH] Make bookmark-maybe-message obsolete

* bookmark.el (bookmark-maybe-message): Redefine as obsolete function
alias for `message'.
---
 lisp/bookmark.el | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)

diff --git a/lisp/bookmark.el b/lisp/bookmark.el
index b1fe690dac..9b93c099af 100644
--- a/lisp/bookmark.el
+++ b/lisp/bookmark.el
@@ -745,16 +745,10 @@ bookmark-insert-file-format-version-stamp
 ;;; end file-format stuff
 
 
-;;; Generic helpers.
-
-(defun bookmark-maybe-message (fmt &rest args)
-  "Apply `message' to FMT and ARGS, but only if the display is fast enough."
-  (if (>= baud-rate 9600)
-      (apply 'message fmt args)))
-
-
 ;;; Core code:
 
+(define-obsolete-function-alias 'bookmark-maybe-message 'message "27.1")
+
 (defvar bookmark-minibuffer-read-name-map
   (let ((map (make-sparse-keymap)))
     (set-keymap-parent map minibuffer-local-map)
@@ -1429,7 +1423,7 @@ bookmark-save
 
 (defun bookmark-write-file (file)
   "Write `bookmark-alist' to FILE."
-  (bookmark-maybe-message "Saving bookmarks to file %s..." file)
+  (message "Saving bookmarks to file %s..." file)
   (with-current-buffer (get-buffer-create " *Bookmarks*")
     (goto-char (point-min))
     (delete-region (point-min) (point-max))
@@ -1468,8 +1462,7 @@ bookmark-write-file
           (file-error (message "Can't write %s" file)))
         (setq bookmark-file-coding-system coding-system-for-write)
         (kill-buffer (current-buffer))
-        (bookmark-maybe-message
-         "Saving bookmarks to file %s...done" file)))))
+        (message "Saving bookmarks to file %s...done" file)))))

 (defun bookmark-import-new-list (new-list)
@@ -1527,7 +1520,7 @@ bookmark-load
   (if (not (file-readable-p file))
       (error "Cannot read bookmark file %s" file)
     (if (null no-msg)
-        (bookmark-maybe-message "Loading bookmarks from %s..." file))
+        (message "Loading bookmarks from %s..." file))
     (with-current-buffer (let ((enable-local-variables nil))
                            (find-file-noselect file))
       (goto-char (point-min))
@@ -1553,7 +1546,7 @@ bookmark-load
           (error "Invalid bookmark list in %s" file)))
       (kill-buffer (current-buffer)))
     (if (null no-msg)
-        (bookmark-maybe-message "Loading bookmarks from %s...done" file))))
+        (message "Loading bookmarks from %s...done" file))))

 
-- 
2.11.0