GNU bug report logs - #35918
[PATCH] bookmark.el: Make bookmark-maybe-message obsolete

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Sun, 26 May 2019 15:36:03 UTC

Severity: minor

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35918 in the body.
You can then email your comments to 35918 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#35918; Package emacs. (Sun, 26 May 2019 15:36:03 GMT) Full text and rfc822 format available.
Acknowledgement sent to Stefan Kangas <stefan <at> marxist.se>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 26 May 2019 15:36:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] bookmark.el: Make bookmark-maybe-message obsolete
Date: Sun, 26 May 2019 14:45:36 +0200

[Message part 1 (text/plain, inline)]
The `bookmark-maybe-message' function checks the `baud-rate' variable before
displaying a message.  I don't believe this is necessary nowadays.

I therefore suggest that we make it an obsolete function alias for
`message'.

Thanks,
Stefan Kangas

[Message part 2 (text/html, inline)]
[0001-Make-bookmark-maybe-message-obsolete.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#35918; Package emacs. (Thu, 30 May 2019 12:45:02 GMT) Full text and rfc822 format available.

Message #8 received at 35918 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 35918 <at> debbugs.gnu.org
Subject: Re: bug#35918: [PATCH] bookmark.el: Make bookmark-maybe-message
 obsolete
Date: Thu, 30 May 2019 13:44:38 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

> The `bookmark-maybe-message' function checks the `baud-rate' variable before
> displaying a message.  I don't believe this is necessary nowadays.
>
> I therefore suggest that we make it an obsolete function alias for `message'.

I agree with making it an obsolete function alias of message, but
instead of replacing its calls with message, why not use a progress
reporter?

Thanks,

-- 
Basil
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#35918; Package emacs. (Thu, 30 May 2019 19:52:02 GMT) Full text and rfc822 format available.

Message #11 received at 35918 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 35918 <at> debbugs.gnu.org
Subject: Re: bug#35918: [PATCH] bookmark.el: Make bookmark-maybe-message
 obsolete
Date: Thu, 30 May 2019 21:51:33 +0200

[Message part 1 (text/plain, inline)]
Basil L. Contovounesios <contovob <at> tcd.ie> writes:
> I agree with making it an obsolete function alias of message, but
> instead of replacing its calls with message, why not use a progress
> reporter?

Good idea.  Please see this updated patch.

Thanks,
Stefan Kangas

[0001-Make-bookmark-maybe-message-obsolete.patch (text/x-patch, attachment)]
Reply sent to Paul Eggert <eggert <at> cs.ucla.edu>:
You have taken responsibility. (Sun, 09 Jun 2019 23:41:04 GMT) Full text and rfc822 format available.
Notification sent to Stefan Kangas <stefan <at> marxist.se>:
bug acknowledged by developer. (Sun, 09 Jun 2019 23:41:04 GMT) Full text and rfc822 format available.

Message #16 received at 35918-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 35918-done <at> debbugs.gnu.org
Subject: Re: [PATCH] bookmark.el: Make bookmark-maybe-message obsolete
Date: Sun, 9 Jun 2019 16:40:23 -0700

Thanks, I installed that. Working my way through your patches....
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 08 Jul 2019 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 5 years and 350 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.