GNU bug report logs - #35916
[PATCH] checkdoc fixes in bookmark.el

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 35916 <at> debbugs.gnu.org
Subject: bug#35916: [PATCH] checkdoc fixes in bookmark.el
Date: Sat, 08 Jun 2019 11:37:42 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Thu, 30 May 2019 19:53:58 +0200
> Cc: 35916 <at> debbugs.gnu.org
> 
> Please find attached an updated version of the patch with an improved commit
> message.

Thanks, this is OK, with one comment:

>  (defun bookmark-bmenu-other-window-with-mouse (event)
> -  "Select bookmark at the mouse pointer in other window, leaving bookmark menu visible."
> +  "Select bookmark at the mouse pointer in other window.
> +Move point to the position of EVENT, and leave bookmark menu
> +visible."

The first line of the doc string should mention the arguments, in this
case EVENT.  Could you please rework this hunk and resubmit the patch?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.