From unknown Thu Aug 14 21:49:19 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#35916 <35916@debbugs.gnu.org> To: bug#35916 <35916@debbugs.gnu.org> Subject: Status: [PATCH] checkdoc fixes in bookmark.el Reply-To: bug#35916 <35916@debbugs.gnu.org> Date: Fri, 15 Aug 2025 04:49:19 +0000 retitle 35916 [PATCH] checkdoc fixes in bookmark.el reassign 35916 emacs submitter 35916 Stefan Kangas severity 35916 minor tag 35916 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun May 26 11:35:13 2019 Received: (at submit) by debbugs.gnu.org; 26 May 2019 15:35:13 +0000 Received: from localhost ([127.0.0.1]:51456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUvB2-0002M8-JM for submit@debbugs.gnu.org; Sun, 26 May 2019 11:35:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42057) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUr8F-0007f1-MS for submit@debbugs.gnu.org; Sun, 26 May 2019 07:16:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:45131) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hUr8A-0002G9-Hx for submit@debbugs.gnu.org; Sun, 26 May 2019 07:15:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUr88-0007mR-AV for bug-gnu-emacs@gnu.org; Sun, 26 May 2019 07:15:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hUqsE-0005Hy-Bu for bug-gnu-emacs@gnu.org; Sun, 26 May 2019 06:59:33 -0400 Received: from mail-wr1-f53.google.com ([209.85.221.53]:36435) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hUqsA-00054O-18 for bug-gnu-emacs@gnu.org; Sun, 26 May 2019 06:59:28 -0400 Received: by mail-wr1-f53.google.com with SMTP id s17so14043492wru.3 for ; Sun, 26 May 2019 03:59:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=G4BWUdiFUmvjPMaohVCmmPqMzyfzcs9UdNxzk16Jq+8=; b=ir0/5Rok83W/Ya2gsXw/wQuFSKGSvg7JJ5xSLIdu7Pa+5t7B5+LvPxfJUQVsPhaGAF AOQ4j0rTrB9a6R379csHVNba3MovkDNQkK8aMvj9fzs4udZmLuuimhLvPcODlkgMdAYB vxJiucor0R56aXzHAJklg515/QAKYyzE3E18+hUA35BAUew3cXVCkohlyvPwwxOjxpzC YEAgqRxQ+y1/W4bcIVW3qnyP+irscGedLguEuSxeAPgUYuvlDVaMwbSoNBv8d1BOQf9m coRia/BON7ZZAykdh/sieIuQhaFcuQNP/9+YNzJ+qWXztcdaVoNZsS7CLkHGi5f4XApC xufw== X-Gm-Message-State: APjAAAU2nHiVQJ0T/5M+iMkBmF3KVxGd/HCfI5l1ZSDr4Ky7wPAElmw+ h7S+W44jm8Lk0m2IveKR1fN5nn3/6vLxMJKwug1CeBzL X-Google-Smtp-Source: APXvYqyKxOok0W/Y3h2T2KwLvytSu7sIePuX66uX+UnA56OOpXvXXUxbf4YhJhDmi4vZ6u1JwUx1xF01vqe9jED/8hU= X-Received: by 2002:adf:e482:: with SMTP id i2mr793109wrm.85.1558868362971; Sun, 26 May 2019 03:59:22 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Sun, 26 May 2019 12:59:11 +0200 Message-ID: Subject: [PATCH] checkdoc fixes in bookmark.el To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="00000000000006f0490589c85373" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.53 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 26 May 2019 11:35:10 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --00000000000006f0490589c85373 Content-Type: multipart/alternative; boundary="00000000000006f0480589c85371" --00000000000006f0480589c85371 Content-Type: text/plain; charset="UTF-8" I ran checkdoc on bookmark.el and fixed some of the errors. Please see attached patch. Thanks, Stefan Kangas --00000000000006f0480589c85371 Content-Type: text/html; charset="UTF-8"
I ran checkdoc on bookmark.el and fixed some of the errors.
Please see attached patch.

Thanks,
Stefan Kangas

--00000000000006f0480589c85371-- --00000000000006f0490589c85373 Content-Type: text/x-patch; charset="US-ASCII"; name="checkdoc-fixes-in-bookmark.el.patch" Content-Disposition: attachment; filename="checkdoc-fixes-in-bookmark.el.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jw4twd680 RnJvbSBkNDZlZWY2MTQ2MzEwYzcwMGNkMDRmNDk5MTE5YzE2NGY1NDYxMzkxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDI2IE1heSAyMDE5IDEyOjQ4OjI2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g Q2hlY2tkb2MgZml4ZXMgaW4gYm9va21hcmsuZWwKCiogYm9va21hcmsuZWwgKGJvb2ttYXJrLWJt ZW51LWlubGluZS1oZWFkZXItaGVpZ2h0KQooYm9va21hcmstYm1lbnUtbWFya3Mtd2lkdGgsIGJv b2ttYXJrLW1hcCwgYm9va21hcmstYWxpc3QpCihib29rbWFyay1xdWl0LWZsYWcsIGJvb2ttYXJr LW5hbWUtZnJvbS1mdWxsLXJlY29yZCkKKGJvb2ttYXJrLXNldC1pbnRlcm5hbCwgYm9va21hcmst aW5zZXJ0LWFubm90YXRpb24pCihib29rbWFyay0tanVtcC12aWEsIGJvb2ttYXJrLWJtZW51LXNl dC1oZWFkZXIpCihib29rbWFyay1zaG93LWFubm90YXRpb24sIGJvb2ttYXJrLWJtZW51LW90aGVy LXdpbmRvdy13aXRoLW1vdXNlKQooYm9va21hcmstYm1lbnUtcmVsb2NhdGUpOiBDaGVja2RvYyBk b2NzdHJpbmcgZml4ZXMuCi0tLQogbGlzcC9ib29rbWFyay5lbCB8IDQwICsrKysrKysrKysrKysr KysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyMiBpbnNlcnRpb25z KCspLCAxOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2Jvb2ttYXJrLmVsIGIvbGlz cC9ib29rbWFyay5lbAppbmRleCBiMWZlNjkwZGFjLi5lZjAzMDIzOTY1IDEwMDY0NAotLS0gYS9s aXNwL2Jvb2ttYXJrLmVsCisrKyBiL2xpc3AvYm9va21hcmsuZWwKQEAgLTEzNiwxMiArMTM2LDEz IEBAIGJvb2ttYXJrLWJtZW51LXVzZS1oZWFkZXItbGluZQogICA6Z3JvdXAgJ2Jvb2ttYXJrKQog CiAoZGVmY29uc3QgYm9va21hcmstYm1lbnUtaW5saW5lLWhlYWRlci1oZWlnaHQgMgotICAiTnVt YmVyIG9mIGxpbmVzIHVzZWQgZm9yIHRoZSAqQm9va21hcmsgTGlzdCogaGVhZGVyCi1cKG9ubHkg c2lnbmlmaWNhbnQgd2hlbiBgYm9va21hcmstYm1lbnUtdXNlLWhlYWRlci1saW5lJyBpcyBuaWwp LiIpCisgICJOdW1iZXIgb2YgbGluZXMgdXNlZCBmb3IgdGhlICpCb29rbWFyayBMaXN0KiBoZWFk ZXIuCitcKFRoaXMgaXMgb25seSBzaWduaWZpY2FudCB3aGVuIGBib29rbWFyay1ibWVudS11c2Ut aGVhZGVyLWxpbmUnCitpcyBuaWwuKSIpCiAKIChkZWZjb25zdCBib29rbWFyay1ibWVudS1tYXJr cy13aWR0aCAyCi0gICJOdW1iZXIgb2YgY29sdW1ucyAoY2hhcnMpIHVzZWQgZm9yIHRoZSAqQm9v a21hcmsgTGlzdCogbWFya3MgY29sdW1uLAotaW5jbHVkaW5nIHRoZSBhbm5vdGF0aW9ucyBjb2x1 bW4uIikKKyAgIk51bWJlciBvZiBjb2x1bW5zIChjaGFycykgdXNlZCBmb3IgdGhlICpCb29rbWFy ayBMaXN0KiBtYXJrcyBjb2x1bW4uCitUaGlzIGluY2x1ZGVzIHRoZSBhbm5vdGF0aW9ucyBjb2x1 bW4uIikKIAogKGRlZmN1c3RvbSBib29rbWFyay1ibWVudS1maWxlLWNvbHVtbiAzMAogICAiQ29s dW1uIGF0IHdoaWNoIHRvIGRpc3BsYXkgZmlsZW5hbWVzIGluIGEgYnVmZmVyIGxpc3RpbmcgYm9v a21hcmtzLgpAQCAtMjIxLDcgKzIyMiw3IEBAIGJvb2ttYXJrLW1hcAogICAiS2V5bWFwIGNvbnRh aW5pbmcgYmluZGluZ3MgdG8gYm9va21hcmsgZnVuY3Rpb25zLgogSXQgaXMgbm90IGJvdW5kIHRv IGFueSBrZXkgYnkgZGVmYXVsdDogdG8gYmluZCBpdAogc28gdGhhdCB5b3UgaGF2ZSBhIGJvb2tt YXJrIHByZWZpeCwganVzdCB1c2UgYGdsb2JhbC1zZXQta2V5JyBhbmQgYmluZCBhCi1rZXkgb2Yg eW91ciBjaG9pY2UgdG8gYGJvb2ttYXJrLW1hcCcuICBBbGwgaW50ZXJhY3RpdmUgYm9va21hcmsK K2tleSBvZiB5b3VyIGNob2ljZSB0byB2YXJpYWJsZSBgYm9va21hcmstbWFwJy4gIEFsbCBpbnRl cmFjdGl2ZSBib29rbWFyawogZnVuY3Rpb25zIGhhdmUgYSBiaW5kaW5nIGluIHRoaXMga2V5bWFw LiIpCiAKIDs7OyMjI2F1dG9sb2FkIChmc2V0ICdib29rbWFyay1tYXAgYm9va21hcmstbWFwKQpA QCAtMjYwLDcgKzI2MSw3IEBAIGJvb2ttYXJrLWFsaXN0CiAgQU5OT1RBVElPTiBpcyBhIHN0cmlu ZyB0aGF0IGRlc2NyaWJlcyB0aGUgYm9va21hcmsuCiAgICBTZWUgb3B0aW9ucyBgYm9va21hcmst dXNlLWFubm90YXRpb25zJyBhbmQKICAgIGBib29rbWFyay1hdXRvbWF0aWNhbGx5LXNob3ctYW5u b3RhdGlvbnMnLgotIEhBTkRMRVIgaXMgYSBmdW5jdGlvbiB0aGF0IHByb3ZpZGVzIHRoZSBib29r bWFyay1qdW1wIGJlaGF2aW9yIGZvciBhCisgSEFORExFUiBpcyBhIGZ1bmN0aW9uIHRoYXQgcHJv dmlkZXMgdGhlIGBib29rbWFyay1qdW1wJyBiZWhhdmlvciBmb3IgYQogIHNwZWNpZmljIGtpbmQg b2YgYm9va21hcmsuICBUaGlzIGlzIHRoZSBjYXNlIGZvciBJbmZvIGJvb2ttYXJrcywKICBmb3Ig aW5zdGFuY2UuICBIQU5ETEVSIG11c3QgYWNjZXB0IGEgYm9va21hcmsgYXMgaXRzIHNpbmdsZSBh cmd1bWVudC4iKQogCkBAIC0zMDEsNyArMzAyLDcgQEAgYm9va21hcmsteWFuay1wb2ludAogCiAK IChkZWZ2YXIgYm9va21hcmstcXVpdC1mbGFnIG5pbAotICAiTm9uIG5pbCBtYWtlIGBib29rbWFy ay1ibWVudS1zZWFyY2gnIHF1aXQgaW1tZWRpYXRlbHkuIikKKyAgIk5vbi1uaWwgbWVhbnMgYGJv b2ttYXJrLWJtZW51LXNlYXJjaCcgcXVpdHMgaW1tZWRpYXRlbHkuIikKIAwKIDs7IEhlbHBlciBm dW5jdGlvbnMgYW5kIG1hY3Jvcy4KIApAQCAtMzE4LDggKzMxOSw4IEBAIHdpdGgtYnVmZmVyLW1v ZGlmaWVkLXVubW9kaWZpZWQKIDs7IEV2ZXJ5b25lIGVsc2Ugc2hvdWxkIGdvIHRocm91Z2ggdGhl bS4KIAogKGRlZnVuIGJvb2ttYXJrLW5hbWUtZnJvbS1mdWxsLXJlY29yZCAoYm9va21hcmstcmVj b3JkKQotICAiUmV0dXJuIHRoZSBuYW1lIG9mIEJPT0tNQVJLLVJFQ09SRC4gIEJPT0tNQVJLLVJF Q09SRCBpcywgZS5nLiwKLW9uZSBlbGVtZW50IGZyb20gYGJvb2ttYXJrLWFsaXN0Jy4iCisgICJS ZXR1cm4gdGhlIG5hbWUgb2YgQk9PS01BUkstUkVDT1JELgorQk9PS01BUkstUkVDT1JEIGlzLCBl LmcuLCBvbmUgZWxlbWVudCBmcm9tIGBib29rbWFyay1hbGlzdCcuIgogICAoY2FyIGJvb2ttYXJr LXJlY29yZCkpCiAKIApAQCAtODExLDcgKzgxMiw3IEBAIGJvb2ttYXJrLXNldC1pbnRlcm5hbAog ICAgICAgICAgICAoY29uZAogICAgICAgICAgICAgKChlcSBvdmVyd3JpdGUtb3ItcHVzaCBuaWwp CiAgICAgICAgICAgICAgKGlmIChib29rbWFyay1nZXQtYm9va21hcmsgc3RyIHQpCi0gICAgICAg ICAgICAgICAgIChlcnJvciAiQSBib29rbWFyayBuYW1lZCBcIiVzXCIgYWxyZWFkeSBleGlzdHMu IiBzdHIpCisgICAgICAgICAgICAgICAgIChlcnJvciAiQSBib29rbWFyayBuYW1lZCBcIiVzXCIg YWxyZWFkeSBleGlzdHMiIHN0cikKICAgICAgICAgICAgICAgIChib29rbWFyay1zdG9yZSBzdHIg KGNkciByZWNvcmQpIG5pbCkpKQogICAgICAgICAgICAgKChlcSBvdmVyd3JpdGUtb3ItcHVzaCAn b3ZlcndyaXRlKQogICAgICAgICAgICAgIChib29rbWFyay1zdG9yZSBzdHIgKGNkciByZWNvcmQp IG5pbCkpCkBAIC05MzYsNiArOTM3LDcgQEAgYm9va21hcmstZWRpdC1hbm5vdGF0aW9uLW1vZGUt bWFwCiAgICJLZXltYXAgZm9yIGVkaXRpbmcgYW4gYW5ub3RhdGlvbiBvZiBhIGJvb2ttYXJrLiIp CiAKIChkZWZ1biBib29rbWFyay1pbnNlcnQtYW5ub3RhdGlvbiAoYm9va21hcmstbmFtZS1vci1y ZWNvcmQpCisgICJJbnNlcnQgYW5ub3RhdGlvbiBmb3IgQk9PS01BUkstTkFNRS1PUi1SRUNPUkQg YXQgcG9pbnQuIgogICAoaW5zZXJ0IChmdW5jYWxsIGJvb2ttYXJrLWVkaXQtYW5ub3RhdGlvbi10 ZXh0LWZ1bmMgYm9va21hcmstbmFtZS1vci1yZWNvcmQpKQogICAobGV0ICgoYW5ub3RhdGlvbiAo Ym9va21hcmstZ2V0LWFubm90YXRpb24gYm9va21hcmstbmFtZS1vci1yZWNvcmQpKSkKICAgICAo aWYgKGFuZCBhbm5vdGF0aW9uIChub3QgKHN0cmluZy1lcXVhbCBhbm5vdGF0aW9uICIiKSkpCkBA IC0xMDY1LDggKzEwNjcsOCBAQCBib29rbWFyay1hZnRlci1qdW1wLWhvb2sKIFVzZWZ1bCBmb3Ig ZXhhbXBsZSB0byB1bmhpZGUgdGV4dCBpbiBgb3V0bGluZS1tb2RlJy4iKQogCiAoZGVmdW4gYm9v a21hcmstLWp1bXAtdmlhIChib29rbWFyay1uYW1lLW9yLXJlY29yZCBkaXNwbGF5LWZ1bmN0aW9u KQotICAiSGFuZGxlIEJPT0tNQVJLLU5BTUUtT1ItUkVDT1JELCB0aGVuIGNhbGwgRElTUExBWS1G VU5DVElPTiB3aXRoCi1jdXJyZW50IGJ1ZmZlciBhcyBhcmd1bWVudC4KKyAgIkhhbmRsZSBCT09L TUFSSy1OQU1FLU9SLVJFQ09SRCwgdGhlbiBjYWxsIERJU1BMQVktRlVOQ1RJT04uCitESVNQTEFZ LUZVTkNUSU9OIGlzIGNhbGxlZCB3aXRoIHRoZSBjdXJyZW50IGJ1ZmZlciBhcyBhcmd1bWVudC4K IAogQWZ0ZXIgY2FsbGluZyBESVNQTEFZLUZVTkNUSU9OLCBzZXQgd2luZG93IHBvaW50IHRvIHRo ZSBwb2ludCBzcGVjaWZpZWQKIGJ5IEJPT0tNQVJLLU5BTUUtT1ItUkVDT1JELCBpZiBuZWNlc3Nh cnksIHJ1biBgYm9va21hcmstYWZ0ZXItanVtcC1ob29rJywKQEAgLTE2NzUsNyArMTY3Nyw3IEBA ICdsaXN0LWJvb2ttYXJrcwogKGRlZmFsaWFzICdlZGl0LWJvb2ttYXJrcyAnYm9va21hcmstYm1l bnUtbGlzdCkKIAogKGRlZnVuIGJvb2ttYXJrLWJtZW51LXNldC1oZWFkZXIgKCkKLSAgIlNldHMg dGhlIGltbXV0YWJsZSBoZWFkZXIgbGluZS4iCisgICJTZXQgdGhlIGltbXV0YWJsZSBoZWFkZXIg bGluZS4iCiAgIChsZXQgKChoZWFkZXIgKGNvbmNhdCAiJSUgIiAiQm9va21hcmsiKSkpCiAgICAg KHdoZW4gYm9va21hcmstYm1lbnUtdG9nZ2xlLWZpbGVuYW1lcwogICAgICAgKHNldHEgaGVhZGVy IChjb25jYXQgaGVhZGVyCkBAIC0xODM1LDggKzE4MzcsOCBAQCBib29rbWFyay1ibWVudS1ib29r bWFyawogCiAKIChkZWZ1biBib29rbWFyay1zaG93LWFubm90YXRpb24gKGJvb2ttYXJrLW5hbWUt b3ItcmVjb3JkKQotICAiRGlzcGxheSB0aGUgYW5ub3RhdGlvbiBmb3IgQk9PS01BUkstTkFNRS1P Ui1SRUNPUkQgaW4gYSBidWZmZXIsCi1pZiBhbiBhbm5vdGF0aW9uIGV4aXN0cy4iCisgICJEaXNw bGF5IHRoZSBhbm5vdGF0aW9uIGZvciBCT09LTUFSSy1OQU1FLU9SLVJFQ09SRCBpbiBhIGJ1ZmZl ci4KK0lmIHRoZSBhbm5vdGF0aW9uIGRvZXMgbm90IGV4aXN0cywgZG8gbm90aGluZy4iCiAgIChs ZXQgKChhbm5vdGF0aW9uIChib29rbWFyay1nZXQtYW5ub3RhdGlvbiBib29rbWFyay1uYW1lLW9y LXJlY29yZCkpKQogICAgICh3aGVuIChhbmQgYW5ub3RhdGlvbiAobm90IChzdHJpbmctZXF1YWwg YW5ub3RhdGlvbiAiIikpKQogICAgICAgKHNhdmUtZXhjdXJzaW9uCkBAIC0xOTk3LDcgKzE5OTks OSBAQCBib29rbWFyay1ibWVudS1zd2l0Y2gtb3RoZXItd2luZG93CiAgICAgKGJvb2ttYXJrLS1q dW1wLXZpYSBib29rbWFyayBmdW4pKSkKIAogKGRlZnVuIGJvb2ttYXJrLWJtZW51LW90aGVyLXdp bmRvdy13aXRoLW1vdXNlIChldmVudCkKLSAgIlNlbGVjdCBib29rbWFyayBhdCB0aGUgbW91c2Ug cG9pbnRlciBpbiBvdGhlciB3aW5kb3csIGxlYXZpbmcgYm9va21hcmsgbWVudSB2aXNpYmxlLiIK KyAgIlNlbGVjdCBib29rbWFyayBhdCB0aGUgbW91c2UgcG9pbnRlciBpbiBvdGhlciB3aW5kb3cu CitNb3ZlIHBvaW50IHRvIHRoZSBwb3NpdGlvbiBvZiBFVkVOVCwgYW5kIGxlYXZlIGJvb2ttYXJr IG1lbnUKK3Zpc2libGUuIgogICAoaW50ZXJhY3RpdmUgImUiKQogICAod2l0aC1jdXJyZW50LWJ1 ZmZlciAod2luZG93LWJ1ZmZlciAocG9zbi13aW5kb3cgKGV2ZW50LWVuZCBldmVudCkpKQogICAg IChzYXZlLWV4Y3Vyc2lvbgpAQCAtMjEyMyw4ICsyMTI3LDggQEAgYm9va21hcmstYm1lbnUtbG9j YXRlCiAgICAgKG1lc3NhZ2UgIiVzIiAoYm9va21hcmstbG9jYXRpb24gYm1yaykpKSkKIAogKGRl ZnVuIGJvb2ttYXJrLWJtZW51LXJlbG9jYXRlICgpCi0gICJDaGFuZ2UgdGhlIGZpbGUgcGF0aCBv ZiB0aGUgYm9va21hcmsgb24gdGhlIGN1cnJlbnQgbGluZSwKLSAgcHJvbXB0aW5nIHdpdGggY29t cGxldGlvbiBmb3IgdGhlIG5ldyBwYXRoLiIKKyAgIkNoYW5nZSB0aGUgZmlsZSBwYXRoIG9mIHRo ZSBib29rbWFyayBvbiB0aGUgY3VycmVudCBsaW5lLgorUHJvbXB0IHdpdGggY29tcGxldGlvbiBm b3IgdGhlIG5ldyBwYXRoLiIKICAgKGludGVyYWN0aXZlKQogICAobGV0ICgoYm1yayAoYm9va21h cmstYm1lbnUtYm9va21hcmspKQogICAgICAgICAodGhpc3BvaW50IChwb2ludCkpKQotLSAKMi4x MS4wCgo= --00000000000006f0490589c85373-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 26 23:52:58 2019 Received: (at 35916) by debbugs.gnu.org; 27 May 2019 03:52:58 +0000 Received: from localhost ([127.0.0.1]:52381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hV6gz-00083A-DY for submit@debbugs.gnu.org; Sun, 26 May 2019 23:52:58 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:35326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hV6gx-00082t-UT for 35916@debbugs.gnu.org; Sun, 26 May 2019 23:52:56 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4R3n9DR063199; Mon, 27 May 2019 03:52:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=esxiTSSflHu36r3Rq2UGeV84GhIXNo7/2M1yfHKeA4g=; b=huOIVQ9KEZAHKaoPoGhXu4uNl92EPzCkI8NEB0624ranp227h1CRFv/oq4eDspZ5rndW pJNHbjepAM5g90dkOORZz8EUkVvC2PGJu0H6vniolMRGKSGLPWhmxk4B2rtTk2qxNsTl AEBDDSOqZ6IEOOgqD87KT9rezSRlH9ha3kGYTHOB8n5GE7ifOAIktMcRhDXaGstXSLgT 2r+D9MPrmLbPdrm6IuZgSMaytUIwDdE4/hMYRdIHLEIBBcJIQlWx62l28y05gDaX1S2x VpnxurNK876s85UqPrgxh5h3AW5aoiOgwzhzavWjf2T6fASUx4G1VVRn3AMhEm+QXzZj iQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2spw4t3w11-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 May 2019 03:52:49 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4R3pmGE007484; Mon, 27 May 2019 03:52:48 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 2sqcmjhjs2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 May 2019 03:52:48 +0000 Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x4R3qhA8010684; Mon, 27 May 2019 03:52:44 GMT MIME-Version: 1.0 Message-ID: <3d7f02e2-c064-4da4-b6e0-e7b52d0d357d@default> Date: Sun, 26 May 2019 20:52:42 -0700 (PDT) From: Drew Adams To: Stefan Kangas , 35916@debbugs.gnu.org Subject: RE: bug#35916: [PATCH] checkdoc fixes in bookmark.el References: In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4849.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9269 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905270025 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9269 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905270025 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35916 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) (Minor feedback.)=20 1. This one is wrong, IMO: - HANDLER is a function that provides the bookmark-jump behavior for a + HANDLER is a function that provides the `bookmark-jump' behavior for a That use of "bookmark-jump" is just an adjective, not the name of the speci= fic command `bookmark-jump'. The point of the handler is to provide alternative behavior from what comma= nd `bookmark-jump' provides. But in all cases that alternative is some kin= d of a "bookmark-jump behavior" - not behavior of command `bookmark-jump' b= ut some bookmark-jumping behavior. You could in fact alternatively say "bookmark-jumping behavior". But there= 's no need to (and it's not about a bookmark jumping but about jumping to a= bookmark location). 2. This one has a typo: +If the annotation does not exists, do nothing." ^ exist 3. This one makes some helpful corrections, but Emacs doesn't call this a "file path". It calls it an "absolute file name". + "Change the file path of the bookmark on the current line. +Prompt with completion for the new path." All the other changes look like improvements, to me. Thx. (And bug reports #35917 and #35918 are also welcome.) From debbugs-submit-bounces@debbugs.gnu.org Mon May 27 17:36:20 2019 Received: (at 35916) by debbugs.gnu.org; 27 May 2019 21:36:20 +0000 Received: from localhost ([127.0.0.1]:54408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVNI3-0004W2-I9 for submit@debbugs.gnu.org; Mon, 27 May 2019 17:36:19 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:45305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVNI1-0004Vh-1U for 35916@debbugs.gnu.org; Mon, 27 May 2019 17:36:17 -0400 Received: by mail-wr1-f47.google.com with SMTP id b18so18004246wrq.12 for <35916@debbugs.gnu.org>; Mon, 27 May 2019 14:36:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l2edVyF/HrA/oTvW9KCTaGEzJp6zzmTjJ5Xpds5JWw0=; b=RCya232Kb3vLt4eeoNEJjthZMxBbbPMm0lEyrvRaOlVMSyjXBer7r0/Z++Pt1OgE6z APb+/gUBG1VOrz2WM/O2oDPTM2ah1JzvTWQBVw+vKKGrCdHlDMqbVH1EqBrlKk/ojKS7 jW74SND3yMFDy6pTTRgMZAH98BHMkStJTSM2zEFGDc/trAS4gw/Y4jlx5YtXlWdZ/1at ZUbDk28Av2LYxzkCUbUAHhdLZhLEnSaT4JVC0QDYHqzGWfy88+NzbcYoUA6vfGLOSlIf 6ZLwxUZep0s/iInk1cH4FoPpNSD49+ILXcR6hb/og/bjOPzrT+HtN56NP3XBqETbbaPy C7Mw== X-Gm-Message-State: APjAAAVkcdRoi++CcaSQ0H8FYYrTWKV/1AAxWnCwbWBhrXrWuxo7a6mR BrW0F4hobLIVMaASv7q6nVmgd+PDs0sU/rrgzDY= X-Google-Smtp-Source: APXvYqxdQefsEWOFklW/HFlGby3WssvldarHlC7/PtdhohKTc277cE4ngSGey233tC+U6+rE1DmB/xy1vAOoPM45p0A= X-Received: by 2002:adf:90c3:: with SMTP id i61mr62239448wri.48.1558992971202; Mon, 27 May 2019 14:36:11 -0700 (PDT) MIME-Version: 1.0 References: <3d7f02e2-c064-4da4-b6e0-e7b52d0d357d@default> In-Reply-To: <3d7f02e2-c064-4da4-b6e0-e7b52d0d357d@default> From: Stefan Kangas Date: Mon, 27 May 2019 23:36:00 +0200 Message-ID: Subject: Re: bug#35916: [PATCH] checkdoc fixes in bookmark.el To: Drew Adams Content-Type: multipart/mixed; boundary="00000000000041a3cc0589e55682" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 35916 Cc: 35916@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --00000000000041a3cc0589e55682 Content-Type: text/plain; charset="UTF-8" Drew Adams writes: > (Minor feedback.) Fixed all your comments in the attached patch. > All the other changes look like improvements, to me. Thx. Thank you for providing this feedback. Best regards, Stefan Kangas --00000000000041a3cc0589e55682 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Checkdoc-fixes-in-bookmark.el.patch" Content-Disposition: attachment; filename="0001-Checkdoc-fixes-in-bookmark.el.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jw6w3c1z0 RnJvbSA1ZGVhYmMzNTBhNTUzYTQxZTM3OTM5OTMzNWFlZWFjYjhiYjY2MjhiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDI2IE1heSAyMDE5IDEyOjQ4OjI2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g Q2hlY2tkb2MgZml4ZXMgaW4gYm9va21hcmsuZWwKCiogYm9va21hcmsuZWwgKGJvb2ttYXJrLWJt ZW51LWlubGluZS1oZWFkZXItaGVpZ2h0KQooYm9va21hcmstYm1lbnUtbWFya3Mtd2lkdGgsIGJv b2ttYXJrLW1hcCwgYm9va21hcmstcXVpdC1mbGFnKQooYm9va21hcmstbmFtZS1mcm9tLWZ1bGwt cmVjb3JkLCBib29rbWFyay1zZXQtaW50ZXJuYWwpCihib29rbWFyay1pbnNlcnQtYW5ub3RhdGlv biwgYm9va21hcmstLWp1bXAtdmlhKQooYm9va21hcmstYm1lbnUtc2V0LWhlYWRlciwgYm9va21h cmstc2hvdy1hbm5vdGF0aW9uKQooYm9va21hcmstYm1lbnUtb3RoZXItd2luZG93LXdpdGgtbW91 c2UsIGJvb2ttYXJrLWJtZW51LXJlbG9jYXRlKToKQ2hlY2tkb2MgZG9jc3RyaW5nIGZpeGVzLgot LS0KIGxpc3AvYm9va21hcmsuZWwgfCAzOCArKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0t LS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKyksIDE3IGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2xpc3AvYm9va21hcmsuZWwgYi9saXNwL2Jvb2ttYXJrLmVsCmluZGV4 IGIxZmU2OTBkYWMuLmMzODk5YmNmYzAgMTAwNjQ0Ci0tLSBhL2xpc3AvYm9va21hcmsuZWwKKysr IGIvbGlzcC9ib29rbWFyay5lbApAQCAtMTM2LDEyICsxMzYsMTMgQEAgYm9va21hcmstYm1lbnUt dXNlLWhlYWRlci1saW5lCiAgIDpncm91cCAnYm9va21hcmspCiAKIChkZWZjb25zdCBib29rbWFy ay1ibWVudS1pbmxpbmUtaGVhZGVyLWhlaWdodCAyCi0gICJOdW1iZXIgb2YgbGluZXMgdXNlZCBm b3IgdGhlICpCb29rbWFyayBMaXN0KiBoZWFkZXIKLVwob25seSBzaWduaWZpY2FudCB3aGVuIGBi b29rbWFyay1ibWVudS11c2UtaGVhZGVyLWxpbmUnIGlzIG5pbCkuIikKKyAgIk51bWJlciBvZiBs aW5lcyB1c2VkIGZvciB0aGUgKkJvb2ttYXJrIExpc3QqIGhlYWRlci4KK1woVGhpcyBpcyBvbmx5 IHNpZ25pZmljYW50IHdoZW4gYGJvb2ttYXJrLWJtZW51LXVzZS1oZWFkZXItbGluZScKK2lzIG5p bC4pIikKIAogKGRlZmNvbnN0IGJvb2ttYXJrLWJtZW51LW1hcmtzLXdpZHRoIDIKLSAgIk51bWJl ciBvZiBjb2x1bW5zIChjaGFycykgdXNlZCBmb3IgdGhlICpCb29rbWFyayBMaXN0KiBtYXJrcyBj b2x1bW4sCi1pbmNsdWRpbmcgdGhlIGFubm90YXRpb25zIGNvbHVtbi4iKQorICAiTnVtYmVyIG9m IGNvbHVtbnMgKGNoYXJzKSB1c2VkIGZvciB0aGUgKkJvb2ttYXJrIExpc3QqIG1hcmtzIGNvbHVt bi4KK1RoaXMgaW5jbHVkZXMgdGhlIGFubm90YXRpb25zIGNvbHVtbi4iKQogCiAoZGVmY3VzdG9t IGJvb2ttYXJrLWJtZW51LWZpbGUtY29sdW1uIDMwCiAgICJDb2x1bW4gYXQgd2hpY2ggdG8gZGlz cGxheSBmaWxlbmFtZXMgaW4gYSBidWZmZXIgbGlzdGluZyBib29rbWFya3MuCkBAIC0yMjEsNyAr MjIyLDcgQEAgYm9va21hcmstbWFwCiAgICJLZXltYXAgY29udGFpbmluZyBiaW5kaW5ncyB0byBi b29rbWFyayBmdW5jdGlvbnMuCiBJdCBpcyBub3QgYm91bmQgdG8gYW55IGtleSBieSBkZWZhdWx0 OiB0byBiaW5kIGl0CiBzbyB0aGF0IHlvdSBoYXZlIGEgYm9va21hcmsgcHJlZml4LCBqdXN0IHVz ZSBgZ2xvYmFsLXNldC1rZXknIGFuZCBiaW5kIGEKLWtleSBvZiB5b3VyIGNob2ljZSB0byBgYm9v a21hcmstbWFwJy4gIEFsbCBpbnRlcmFjdGl2ZSBib29rbWFyawora2V5IG9mIHlvdXIgY2hvaWNl IHRvIHZhcmlhYmxlIGBib29rbWFyay1tYXAnLiAgQWxsIGludGVyYWN0aXZlIGJvb2ttYXJrCiBm dW5jdGlvbnMgaGF2ZSBhIGJpbmRpbmcgaW4gdGhpcyBrZXltYXAuIikKIAogOzs7IyMjYXV0b2xv YWQgKGZzZXQgJ2Jvb2ttYXJrLW1hcCBib29rbWFyay1tYXApCkBAIC0zMDEsNyArMzAyLDcgQEAg Ym9va21hcmsteWFuay1wb2ludAogCiAKIChkZWZ2YXIgYm9va21hcmstcXVpdC1mbGFnIG5pbAot ICAiTm9uIG5pbCBtYWtlIGBib29rbWFyay1ibWVudS1zZWFyY2gnIHF1aXQgaW1tZWRpYXRlbHku IikKKyAgIk5vbi1uaWwgbWVhbnMgYGJvb2ttYXJrLWJtZW51LXNlYXJjaCcgcXVpdHMgaW1tZWRp YXRlbHkuIikKIAwKIDs7IEhlbHBlciBmdW5jdGlvbnMgYW5kIG1hY3Jvcy4KIApAQCAtMzE4LDgg KzMxOSw4IEBAIHdpdGgtYnVmZmVyLW1vZGlmaWVkLXVubW9kaWZpZWQKIDs7IEV2ZXJ5b25lIGVs c2Ugc2hvdWxkIGdvIHRocm91Z2ggdGhlbS4KIAogKGRlZnVuIGJvb2ttYXJrLW5hbWUtZnJvbS1m dWxsLXJlY29yZCAoYm9va21hcmstcmVjb3JkKQotICAiUmV0dXJuIHRoZSBuYW1lIG9mIEJPT0tN QVJLLVJFQ09SRC4gIEJPT0tNQVJLLVJFQ09SRCBpcywgZS5nLiwKLW9uZSBlbGVtZW50IGZyb20g YGJvb2ttYXJrLWFsaXN0Jy4iCisgICJSZXR1cm4gdGhlIG5hbWUgb2YgQk9PS01BUkstUkVDT1JE LgorQk9PS01BUkstUkVDT1JEIGlzLCBlLmcuLCBvbmUgZWxlbWVudCBmcm9tIGBib29rbWFyay1h bGlzdCcuIgogICAoY2FyIGJvb2ttYXJrLXJlY29yZCkpCiAKIApAQCAtODExLDcgKzgxMiw3IEBA IGJvb2ttYXJrLXNldC1pbnRlcm5hbAogICAgICAgICAgICAoY29uZAogICAgICAgICAgICAgKChl cSBvdmVyd3JpdGUtb3ItcHVzaCBuaWwpCiAgICAgICAgICAgICAgKGlmIChib29rbWFyay1nZXQt Ym9va21hcmsgc3RyIHQpCi0gICAgICAgICAgICAgICAgIChlcnJvciAiQSBib29rbWFyayBuYW1l ZCBcIiVzXCIgYWxyZWFkeSBleGlzdHMuIiBzdHIpCisgICAgICAgICAgICAgICAgIChlcnJvciAi QSBib29rbWFyayBuYW1lZCBcIiVzXCIgYWxyZWFkeSBleGlzdHMiIHN0cikKICAgICAgICAgICAg ICAgIChib29rbWFyay1zdG9yZSBzdHIgKGNkciByZWNvcmQpIG5pbCkpKQogICAgICAgICAgICAg KChlcSBvdmVyd3JpdGUtb3ItcHVzaCAnb3ZlcndyaXRlKQogICAgICAgICAgICAgIChib29rbWFy ay1zdG9yZSBzdHIgKGNkciByZWNvcmQpIG5pbCkpCkBAIC05MzYsNiArOTM3LDcgQEAgYm9va21h cmstZWRpdC1hbm5vdGF0aW9uLW1vZGUtbWFwCiAgICJLZXltYXAgZm9yIGVkaXRpbmcgYW4gYW5u b3RhdGlvbiBvZiBhIGJvb2ttYXJrLiIpCiAKIChkZWZ1biBib29rbWFyay1pbnNlcnQtYW5ub3Rh dGlvbiAoYm9va21hcmstbmFtZS1vci1yZWNvcmQpCisgICJJbnNlcnQgYW5ub3RhdGlvbiBmb3Ig Qk9PS01BUkstTkFNRS1PUi1SRUNPUkQgYXQgcG9pbnQuIgogICAoaW5zZXJ0IChmdW5jYWxsIGJv b2ttYXJrLWVkaXQtYW5ub3RhdGlvbi10ZXh0LWZ1bmMgYm9va21hcmstbmFtZS1vci1yZWNvcmQp KQogICAobGV0ICgoYW5ub3RhdGlvbiAoYm9va21hcmstZ2V0LWFubm90YXRpb24gYm9va21hcmst bmFtZS1vci1yZWNvcmQpKSkKICAgICAoaWYgKGFuZCBhbm5vdGF0aW9uIChub3QgKHN0cmluZy1l cXVhbCBhbm5vdGF0aW9uICIiKSkpCkBAIC0xMDY1LDggKzEwNjcsOCBAQCBib29rbWFyay1hZnRl ci1qdW1wLWhvb2sKIFVzZWZ1bCBmb3IgZXhhbXBsZSB0byB1bmhpZGUgdGV4dCBpbiBgb3V0bGlu ZS1tb2RlJy4iKQogCiAoZGVmdW4gYm9va21hcmstLWp1bXAtdmlhIChib29rbWFyay1uYW1lLW9y LXJlY29yZCBkaXNwbGF5LWZ1bmN0aW9uKQotICAiSGFuZGxlIEJPT0tNQVJLLU5BTUUtT1ItUkVD T1JELCB0aGVuIGNhbGwgRElTUExBWS1GVU5DVElPTiB3aXRoCi1jdXJyZW50IGJ1ZmZlciBhcyBh cmd1bWVudC4KKyAgIkhhbmRsZSBCT09LTUFSSy1OQU1FLU9SLVJFQ09SRCwgdGhlbiBjYWxsIERJ U1BMQVktRlVOQ1RJT04uCitESVNQTEFZLUZVTkNUSU9OIGlzIGNhbGxlZCB3aXRoIHRoZSBjdXJy ZW50IGJ1ZmZlciBhcyBhcmd1bWVudC4KIAogQWZ0ZXIgY2FsbGluZyBESVNQTEFZLUZVTkNUSU9O LCBzZXQgd2luZG93IHBvaW50IHRvIHRoZSBwb2ludCBzcGVjaWZpZWQKIGJ5IEJPT0tNQVJLLU5B TUUtT1ItUkVDT1JELCBpZiBuZWNlc3NhcnksIHJ1biBgYm9va21hcmstYWZ0ZXItanVtcC1ob29r JywKQEAgLTE2NzUsNyArMTY3Nyw3IEBAICdsaXN0LWJvb2ttYXJrcwogKGRlZmFsaWFzICdlZGl0 LWJvb2ttYXJrcyAnYm9va21hcmstYm1lbnUtbGlzdCkKIAogKGRlZnVuIGJvb2ttYXJrLWJtZW51 LXNldC1oZWFkZXIgKCkKLSAgIlNldHMgdGhlIGltbXV0YWJsZSBoZWFkZXIgbGluZS4iCisgICJT ZXQgdGhlIGltbXV0YWJsZSBoZWFkZXIgbGluZS4iCiAgIChsZXQgKChoZWFkZXIgKGNvbmNhdCAi JSUgIiAiQm9va21hcmsiKSkpCiAgICAgKHdoZW4gYm9va21hcmstYm1lbnUtdG9nZ2xlLWZpbGVu YW1lcwogICAgICAgKHNldHEgaGVhZGVyIChjb25jYXQgaGVhZGVyCkBAIC0xODM1LDggKzE4Mzcs OCBAQCBib29rbWFyay1ibWVudS1ib29rbWFyawogCiAKIChkZWZ1biBib29rbWFyay1zaG93LWFu bm90YXRpb24gKGJvb2ttYXJrLW5hbWUtb3ItcmVjb3JkKQotICAiRGlzcGxheSB0aGUgYW5ub3Rh dGlvbiBmb3IgQk9PS01BUkstTkFNRS1PUi1SRUNPUkQgaW4gYSBidWZmZXIsCi1pZiBhbiBhbm5v dGF0aW9uIGV4aXN0cy4iCisgICJEaXNwbGF5IHRoZSBhbm5vdGF0aW9uIGZvciBCT09LTUFSSy1O QU1FLU9SLVJFQ09SRCBpbiBhIGJ1ZmZlci4KK0lmIHRoZSBhbm5vdGF0aW9uIGRvZXMgbm90IGV4 aXN0LCBkbyBub3RoaW5nLiIKICAgKGxldCAoKGFubm90YXRpb24gKGJvb2ttYXJrLWdldC1hbm5v dGF0aW9uIGJvb2ttYXJrLW5hbWUtb3ItcmVjb3JkKSkpCiAgICAgKHdoZW4gKGFuZCBhbm5vdGF0 aW9uIChub3QgKHN0cmluZy1lcXVhbCBhbm5vdGF0aW9uICIiKSkpCiAgICAgICAoc2F2ZS1leGN1 cnNpb24KQEAgLTE5OTcsNyArMTk5OSw5IEBAIGJvb2ttYXJrLWJtZW51LXN3aXRjaC1vdGhlci13 aW5kb3cKICAgICAoYm9va21hcmstLWp1bXAtdmlhIGJvb2ttYXJrIGZ1bikpKQogCiAoZGVmdW4g Ym9va21hcmstYm1lbnUtb3RoZXItd2luZG93LXdpdGgtbW91c2UgKGV2ZW50KQotICAiU2VsZWN0 IGJvb2ttYXJrIGF0IHRoZSBtb3VzZSBwb2ludGVyIGluIG90aGVyIHdpbmRvdywgbGVhdmluZyBi b29rbWFyayBtZW51IHZpc2libGUuIgorICAiU2VsZWN0IGJvb2ttYXJrIGF0IHRoZSBtb3VzZSBw b2ludGVyIGluIG90aGVyIHdpbmRvdy4KK01vdmUgcG9pbnQgdG8gdGhlIHBvc2l0aW9uIG9mIEVW RU5ULCBhbmQgbGVhdmUgYm9va21hcmsgbWVudQordmlzaWJsZS4iCiAgIChpbnRlcmFjdGl2ZSAi ZSIpCiAgICh3aXRoLWN1cnJlbnQtYnVmZmVyICh3aW5kb3ctYnVmZmVyIChwb3NuLXdpbmRvdyAo ZXZlbnQtZW5kIGV2ZW50KSkpCiAgICAgKHNhdmUtZXhjdXJzaW9uCkBAIC0yMTIzLDggKzIxMjcs OCBAQCBib29rbWFyay1ibWVudS1sb2NhdGUKICAgICAobWVzc2FnZSAiJXMiIChib29rbWFyay1s b2NhdGlvbiBibXJrKSkpKQogCiAoZGVmdW4gYm9va21hcmstYm1lbnUtcmVsb2NhdGUgKCkKLSAg IkNoYW5nZSB0aGUgZmlsZSBwYXRoIG9mIHRoZSBib29rbWFyayBvbiB0aGUgY3VycmVudCBsaW5l LAotICBwcm9tcHRpbmcgd2l0aCBjb21wbGV0aW9uIGZvciB0aGUgbmV3IHBhdGguIgorICAiQ2hh bmdlIHRoZSBhYnNvbHV0ZSBmaWxlIG5hbWUgb2YgdGhlIGJvb2ttYXJrIG9uIHRoZSBjdXJyZW50 IGxpbmUuCitQcm9tcHQgd2l0aCBjb21wbGV0aW9uIGZvciB0aGUgbmV3IHBhdGguIgogICAoaW50 ZXJhY3RpdmUpCiAgIChsZXQgKChibXJrIChib29rbWFyay1ibWVudS1ib29rbWFyaykpCiAgICAg ICAgICh0aGlzcG9pbnQgKHBvaW50KSkpCi0tIAoyLjExLjAKCg== --00000000000041a3cc0589e55682-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 30 13:54:18 2019 Received: (at 35916) by debbugs.gnu.org; 30 May 2019 17:54:18 +0000 Received: from localhost ([127.0.0.1]:33826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWPFp-0004UC-CU for submit@debbugs.gnu.org; Thu, 30 May 2019 13:54:18 -0400 Received: from mail-it1-f173.google.com ([209.85.166.173]:36726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWPFn-0004Tx-GX for 35916@debbugs.gnu.org; Thu, 30 May 2019 13:54:16 -0400 Received: by mail-it1-f173.google.com with SMTP id e184so10832615ite.1 for <35916@debbugs.gnu.org>; Thu, 30 May 2019 10:54:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:cc; bh=jnkzh2X5UnWf7FwtLTY0HFeHcYqFnM+Ozl0LF3hKXXU=; b=s2s0F1SGdBw1+ZnJFvIqAriMAmR181gGYyiHa0vfXq80a8gKL3338ao+0xDfwIkmBq UlSwjgoSslPOk9K34uJNbaLRI2Obr2SDamF2XG4nYLyoyZTP99V0DagGrJzYQtAiX/5E RLM3vpbX+g7/AEKbHo2q8VGUlrlKk/Gx6Ih861aBVUbv2k37s+TH+dCYwYr9xCxZXy9r LXnRtpmIJVxzPCMSUL2JpChdMGrb6YH79MqkspXbly/t7XS+Erouq3MP1IQhFDlPzqAj hzMPvd4gJXd7/IHtcy78//qBvY/GGAnhfqRQrA9foEnfBQeassxib7HbQj4caiAtHNNL lARw== X-Gm-Message-State: APjAAAWhcgjif5/KDhwgs2Im+CCMF58JTbE39xTF92F+5He9dqwL971F sSqWBAgb9Wk/3BtyM1EtyR6TYT2bTE4Wvws6jA0TTqge X-Google-Smtp-Source: APXvYqxEg+tNd3YPXKjWrLkwxD5KHBidqxBr7lUYSIbuZVRcgTYtYXcJO88Agbb4YthT1WGUxC+WyA1ocB1Ks8V+gV8= X-Received: by 2002:a24:680c:: with SMTP id v12mr3770697itb.67.1559238849630; Thu, 30 May 2019 10:54:09 -0700 (PDT) MIME-Version: 1.0 References: <3d7f02e2-c064-4da4-b6e0-e7b52d0d357d@default> In-Reply-To: From: Stefan Kangas Date: Thu, 30 May 2019 19:53:58 +0200 Message-ID: Subject: Re: bug#35916: [PATCH] checkdoc fixes in bookmark.el Content-Type: multipart/mixed; boundary="000000000000c0daf1058a1e9526" X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Please find attached an updated version of the patch with an improved commit message. Thanks, Stefan Kangas From dac22dd0b713844743a361b6245973b2e38bd783 Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Sun, 26 May 2019 12:48:26 +0200 Subject: [PATCH] Checkdoc fixes in lisp/bookma [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.2 MISSING_HEADERS Missing To: header -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.166.173 listed in list.dnswl.org] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: 35916 Cc: 35916@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/) --000000000000c0daf1058a1e9526 Content-Type: text/plain; charset="UTF-8" Please find attached an updated version of the patch with an improved commit message. Thanks, Stefan Kangas --000000000000c0daf1058a1e9526 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Checkdoc-fixes-in-lisp-bookmark.el.patch" Content-Disposition: attachment; filename="0001-Checkdoc-fixes-in-lisp-bookmark.el.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jwayi6py0 RnJvbSBkYWMyMmRkMGI3MTM4NDQ3NDNhMzYxYjYyNDU5NzNiMmUzOGJkNzgzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDI2IE1heSAyMDE5IDEyOjQ4OjI2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g Q2hlY2tkb2MgZml4ZXMgaW4gbGlzcC9ib29rbWFyay5lbAoKKiBsaXNwL2Jvb2ttYXJrLmVsIChi b29rbWFyay1ibWVudS1pbmxpbmUtaGVhZGVyLWhlaWdodCkKKGJvb2ttYXJrLWJtZW51LW1hcmtz LXdpZHRoLCBib29rbWFyay1tYXAsIGJvb2ttYXJrLXF1aXQtZmxhZykKKGJvb2ttYXJrLW5hbWUt ZnJvbS1mdWxsLXJlY29yZCwgYm9va21hcmstc2V0LWludGVybmFsKQooYm9va21hcmstaW5zZXJ0 LWFubm90YXRpb24sIGJvb2ttYXJrLS1qdW1wLXZpYSkKKGJvb2ttYXJrLWJtZW51LXNldC1oZWFk ZXIsIGJvb2ttYXJrLXNob3ctYW5ub3RhdGlvbikKKGJvb2ttYXJrLWJtZW51LW90aGVyLXdpbmRv dy13aXRoLW1vdXNlLCBib29rbWFyay1ibWVudS1yZWxvY2F0ZSk6CkNoZWNrZG9jIGRvY3N0cmlu ZyBmaXhlcy4gIChCdWcjMzU5MTYpCi0tLQogbGlzcC9ib29rbWFyay5lbCB8IDM4ICsrKysrKysr KysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMjEgaW5zZXJ0 aW9ucygrKSwgMTcgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9ib29rbWFyay5lbCBi L2xpc3AvYm9va21hcmsuZWwKaW5kZXggYjFmZTY5MGRhYy4uYzM4OTliY2ZjMCAxMDA2NDQKLS0t IGEvbGlzcC9ib29rbWFyay5lbAorKysgYi9saXNwL2Jvb2ttYXJrLmVsCkBAIC0xMzYsMTIgKzEz NiwxMyBAQCBib29rbWFyay1ibWVudS11c2UtaGVhZGVyLWxpbmUKICAgOmdyb3VwICdib29rbWFy aykKIAogKGRlZmNvbnN0IGJvb2ttYXJrLWJtZW51LWlubGluZS1oZWFkZXItaGVpZ2h0IDIKLSAg Ik51bWJlciBvZiBsaW5lcyB1c2VkIGZvciB0aGUgKkJvb2ttYXJrIExpc3QqIGhlYWRlcgotXChv bmx5IHNpZ25pZmljYW50IHdoZW4gYGJvb2ttYXJrLWJtZW51LXVzZS1oZWFkZXItbGluZScgaXMg bmlsKS4iKQorICAiTnVtYmVyIG9mIGxpbmVzIHVzZWQgZm9yIHRoZSAqQm9va21hcmsgTGlzdCog aGVhZGVyLgorXChUaGlzIGlzIG9ubHkgc2lnbmlmaWNhbnQgd2hlbiBgYm9va21hcmstYm1lbnUt dXNlLWhlYWRlci1saW5lJworaXMgbmlsLikiKQogCiAoZGVmY29uc3QgYm9va21hcmstYm1lbnUt bWFya3Mtd2lkdGggMgotICAiTnVtYmVyIG9mIGNvbHVtbnMgKGNoYXJzKSB1c2VkIGZvciB0aGUg KkJvb2ttYXJrIExpc3QqIG1hcmtzIGNvbHVtbiwKLWluY2x1ZGluZyB0aGUgYW5ub3RhdGlvbnMg Y29sdW1uLiIpCisgICJOdW1iZXIgb2YgY29sdW1ucyAoY2hhcnMpIHVzZWQgZm9yIHRoZSAqQm9v a21hcmsgTGlzdCogbWFya3MgY29sdW1uLgorVGhpcyBpbmNsdWRlcyB0aGUgYW5ub3RhdGlvbnMg Y29sdW1uLiIpCiAKIChkZWZjdXN0b20gYm9va21hcmstYm1lbnUtZmlsZS1jb2x1bW4gMzAKICAg IkNvbHVtbiBhdCB3aGljaCB0byBkaXNwbGF5IGZpbGVuYW1lcyBpbiBhIGJ1ZmZlciBsaXN0aW5n IGJvb2ttYXJrcy4KQEAgLTIyMSw3ICsyMjIsNyBAQCBib29rbWFyay1tYXAKICAgIktleW1hcCBj b250YWluaW5nIGJpbmRpbmdzIHRvIGJvb2ttYXJrIGZ1bmN0aW9ucy4KIEl0IGlzIG5vdCBib3Vu ZCB0byBhbnkga2V5IGJ5IGRlZmF1bHQ6IHRvIGJpbmQgaXQKIHNvIHRoYXQgeW91IGhhdmUgYSBi b29rbWFyayBwcmVmaXgsIGp1c3QgdXNlIGBnbG9iYWwtc2V0LWtleScgYW5kIGJpbmQgYQota2V5 IG9mIHlvdXIgY2hvaWNlIHRvIGBib29rbWFyay1tYXAnLiAgQWxsIGludGVyYWN0aXZlIGJvb2tt YXJrCitrZXkgb2YgeW91ciBjaG9pY2UgdG8gdmFyaWFibGUgYGJvb2ttYXJrLW1hcCcuICBBbGwg aW50ZXJhY3RpdmUgYm9va21hcmsKIGZ1bmN0aW9ucyBoYXZlIGEgYmluZGluZyBpbiB0aGlzIGtl eW1hcC4iKQogCiA7OzsjIyNhdXRvbG9hZCAoZnNldCAnYm9va21hcmstbWFwIGJvb2ttYXJrLW1h cCkKQEAgLTMwMSw3ICszMDIsNyBAQCBib29rbWFyay15YW5rLXBvaW50CiAKIAogKGRlZnZhciBi b29rbWFyay1xdWl0LWZsYWcgbmlsCi0gICJOb24gbmlsIG1ha2UgYGJvb2ttYXJrLWJtZW51LXNl YXJjaCcgcXVpdCBpbW1lZGlhdGVseS4iKQorICAiTm9uLW5pbCBtZWFucyBgYm9va21hcmstYm1l bnUtc2VhcmNoJyBxdWl0cyBpbW1lZGlhdGVseS4iKQogDAogOzsgSGVscGVyIGZ1bmN0aW9ucyBh bmQgbWFjcm9zLgogCkBAIC0zMTgsOCArMzE5LDggQEAgd2l0aC1idWZmZXItbW9kaWZpZWQtdW5t b2RpZmllZAogOzsgRXZlcnlvbmUgZWxzZSBzaG91bGQgZ28gdGhyb3VnaCB0aGVtLgogCiAoZGVm dW4gYm9va21hcmstbmFtZS1mcm9tLWZ1bGwtcmVjb3JkIChib29rbWFyay1yZWNvcmQpCi0gICJS ZXR1cm4gdGhlIG5hbWUgb2YgQk9PS01BUkstUkVDT1JELiAgQk9PS01BUkstUkVDT1JEIGlzLCBl LmcuLAotb25lIGVsZW1lbnQgZnJvbSBgYm9va21hcmstYWxpc3QnLiIKKyAgIlJldHVybiB0aGUg bmFtZSBvZiBCT09LTUFSSy1SRUNPUkQuCitCT09LTUFSSy1SRUNPUkQgaXMsIGUuZy4sIG9uZSBl bGVtZW50IGZyb20gYGJvb2ttYXJrLWFsaXN0Jy4iCiAgIChjYXIgYm9va21hcmstcmVjb3JkKSkK IAogCkBAIC04MTEsNyArODEyLDcgQEAgYm9va21hcmstc2V0LWludGVybmFsCiAgICAgICAgICAg IChjb25kCiAgICAgICAgICAgICAoKGVxIG92ZXJ3cml0ZS1vci1wdXNoIG5pbCkKICAgICAgICAg ICAgICAoaWYgKGJvb2ttYXJrLWdldC1ib29rbWFyayBzdHIgdCkKLSAgICAgICAgICAgICAgICAg KGVycm9yICJBIGJvb2ttYXJrIG5hbWVkIFwiJXNcIiBhbHJlYWR5IGV4aXN0cy4iIHN0cikKKyAg ICAgICAgICAgICAgICAgKGVycm9yICJBIGJvb2ttYXJrIG5hbWVkIFwiJXNcIiBhbHJlYWR5IGV4 aXN0cyIgc3RyKQogICAgICAgICAgICAgICAgKGJvb2ttYXJrLXN0b3JlIHN0ciAoY2RyIHJlY29y ZCkgbmlsKSkpCiAgICAgICAgICAgICAoKGVxIG92ZXJ3cml0ZS1vci1wdXNoICdvdmVyd3JpdGUp CiAgICAgICAgICAgICAgKGJvb2ttYXJrLXN0b3JlIHN0ciAoY2RyIHJlY29yZCkgbmlsKSkKQEAg LTkzNiw2ICs5MzcsNyBAQCBib29rbWFyay1lZGl0LWFubm90YXRpb24tbW9kZS1tYXAKICAgIktl eW1hcCBmb3IgZWRpdGluZyBhbiBhbm5vdGF0aW9uIG9mIGEgYm9va21hcmsuIikKIAogKGRlZnVu IGJvb2ttYXJrLWluc2VydC1hbm5vdGF0aW9uIChib29rbWFyay1uYW1lLW9yLXJlY29yZCkKKyAg Ikluc2VydCBhbm5vdGF0aW9uIGZvciBCT09LTUFSSy1OQU1FLU9SLVJFQ09SRCBhdCBwb2ludC4i CiAgIChpbnNlcnQgKGZ1bmNhbGwgYm9va21hcmstZWRpdC1hbm5vdGF0aW9uLXRleHQtZnVuYyBi b29rbWFyay1uYW1lLW9yLXJlY29yZCkpCiAgIChsZXQgKChhbm5vdGF0aW9uIChib29rbWFyay1n ZXQtYW5ub3RhdGlvbiBib29rbWFyay1uYW1lLW9yLXJlY29yZCkpKQogICAgIChpZiAoYW5kIGFu bm90YXRpb24gKG5vdCAoc3RyaW5nLWVxdWFsIGFubm90YXRpb24gIiIpKSkKQEAgLTEwNjUsOCAr MTA2Nyw4IEBAIGJvb2ttYXJrLWFmdGVyLWp1bXAtaG9vawogVXNlZnVsIGZvciBleGFtcGxlIHRv IHVuaGlkZSB0ZXh0IGluIGBvdXRsaW5lLW1vZGUnLiIpCiAKIChkZWZ1biBib29rbWFyay0tanVt cC12aWEgKGJvb2ttYXJrLW5hbWUtb3ItcmVjb3JkIGRpc3BsYXktZnVuY3Rpb24pCi0gICJIYW5k bGUgQk9PS01BUkstTkFNRS1PUi1SRUNPUkQsIHRoZW4gY2FsbCBESVNQTEFZLUZVTkNUSU9OIHdp dGgKLWN1cnJlbnQgYnVmZmVyIGFzIGFyZ3VtZW50LgorICAiSGFuZGxlIEJPT0tNQVJLLU5BTUUt T1ItUkVDT1JELCB0aGVuIGNhbGwgRElTUExBWS1GVU5DVElPTi4KK0RJU1BMQVktRlVOQ1RJT04g aXMgY2FsbGVkIHdpdGggdGhlIGN1cnJlbnQgYnVmZmVyIGFzIGFyZ3VtZW50LgogCiBBZnRlciBj YWxsaW5nIERJU1BMQVktRlVOQ1RJT04sIHNldCB3aW5kb3cgcG9pbnQgdG8gdGhlIHBvaW50IHNw ZWNpZmllZAogYnkgQk9PS01BUkstTkFNRS1PUi1SRUNPUkQsIGlmIG5lY2Vzc2FyeSwgcnVuIGBi b29rbWFyay1hZnRlci1qdW1wLWhvb2snLApAQCAtMTY3NSw3ICsxNjc3LDcgQEAgJ2xpc3QtYm9v a21hcmtzCiAoZGVmYWxpYXMgJ2VkaXQtYm9va21hcmtzICdib29rbWFyay1ibWVudS1saXN0KQog CiAoZGVmdW4gYm9va21hcmstYm1lbnUtc2V0LWhlYWRlciAoKQotICAiU2V0cyB0aGUgaW1tdXRh YmxlIGhlYWRlciBsaW5lLiIKKyAgIlNldCB0aGUgaW1tdXRhYmxlIGhlYWRlciBsaW5lLiIKICAg KGxldCAoKGhlYWRlciAoY29uY2F0ICIlJSAiICJCb29rbWFyayIpKSkKICAgICAod2hlbiBib29r bWFyay1ibWVudS10b2dnbGUtZmlsZW5hbWVzCiAgICAgICAoc2V0cSBoZWFkZXIgKGNvbmNhdCBo ZWFkZXIKQEAgLTE4MzUsOCArMTgzNyw4IEBAIGJvb2ttYXJrLWJtZW51LWJvb2ttYXJrCiAKIAog KGRlZnVuIGJvb2ttYXJrLXNob3ctYW5ub3RhdGlvbiAoYm9va21hcmstbmFtZS1vci1yZWNvcmQp Ci0gICJEaXNwbGF5IHRoZSBhbm5vdGF0aW9uIGZvciBCT09LTUFSSy1OQU1FLU9SLVJFQ09SRCBp biBhIGJ1ZmZlciwKLWlmIGFuIGFubm90YXRpb24gZXhpc3RzLiIKKyAgIkRpc3BsYXkgdGhlIGFu bm90YXRpb24gZm9yIEJPT0tNQVJLLU5BTUUtT1ItUkVDT1JEIGluIGEgYnVmZmVyLgorSWYgdGhl IGFubm90YXRpb24gZG9lcyBub3QgZXhpc3QsIGRvIG5vdGhpbmcuIgogICAobGV0ICgoYW5ub3Rh dGlvbiAoYm9va21hcmstZ2V0LWFubm90YXRpb24gYm9va21hcmstbmFtZS1vci1yZWNvcmQpKSkK ICAgICAod2hlbiAoYW5kIGFubm90YXRpb24gKG5vdCAoc3RyaW5nLWVxdWFsIGFubm90YXRpb24g IiIpKSkKICAgICAgIChzYXZlLWV4Y3Vyc2lvbgpAQCAtMTk5Nyw3ICsxOTk5LDkgQEAgYm9va21h cmstYm1lbnUtc3dpdGNoLW90aGVyLXdpbmRvdwogICAgIChib29rbWFyay0tanVtcC12aWEgYm9v a21hcmsgZnVuKSkpCiAKIChkZWZ1biBib29rbWFyay1ibWVudS1vdGhlci13aW5kb3ctd2l0aC1t b3VzZSAoZXZlbnQpCi0gICJTZWxlY3QgYm9va21hcmsgYXQgdGhlIG1vdXNlIHBvaW50ZXIgaW4g b3RoZXIgd2luZG93LCBsZWF2aW5nIGJvb2ttYXJrIG1lbnUgdmlzaWJsZS4iCisgICJTZWxlY3Qg Ym9va21hcmsgYXQgdGhlIG1vdXNlIHBvaW50ZXIgaW4gb3RoZXIgd2luZG93LgorTW92ZSBwb2lu dCB0byB0aGUgcG9zaXRpb24gb2YgRVZFTlQsIGFuZCBsZWF2ZSBib29rbWFyayBtZW51Cit2aXNp YmxlLiIKICAgKGludGVyYWN0aXZlICJlIikKICAgKHdpdGgtY3VycmVudC1idWZmZXIgKHdpbmRv dy1idWZmZXIgKHBvc24td2luZG93IChldmVudC1lbmQgZXZlbnQpKSkKICAgICAoc2F2ZS1leGN1 cnNpb24KQEAgLTIxMjMsOCArMjEyNyw4IEBAIGJvb2ttYXJrLWJtZW51LWxvY2F0ZQogICAgICht ZXNzYWdlICIlcyIgKGJvb2ttYXJrLWxvY2F0aW9uIGJtcmspKSkpCiAKIChkZWZ1biBib29rbWFy ay1ibWVudS1yZWxvY2F0ZSAoKQotICAiQ2hhbmdlIHRoZSBmaWxlIHBhdGggb2YgdGhlIGJvb2tt YXJrIG9uIHRoZSBjdXJyZW50IGxpbmUsCi0gIHByb21wdGluZyB3aXRoIGNvbXBsZXRpb24gZm9y IHRoZSBuZXcgcGF0aC4iCisgICJDaGFuZ2UgdGhlIGFic29sdXRlIGZpbGUgbmFtZSBvZiB0aGUg Ym9va21hcmsgb24gdGhlIGN1cnJlbnQgbGluZS4KK1Byb21wdCB3aXRoIGNvbXBsZXRpb24gZm9y IHRoZSBuZXcgcGF0aC4iCiAgIChpbnRlcmFjdGl2ZSkKICAgKGxldCAoKGJtcmsgKGJvb2ttYXJr LWJtZW51LWJvb2ttYXJrKSkKICAgICAgICAgKHRoaXNwb2ludCAocG9pbnQpKSkKLS0gCjIuMTEu MAoK --000000000000c0daf1058a1e9526-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 08 04:37:57 2019 Received: (at 35916) by debbugs.gnu.org; 8 Jun 2019 08:37:57 +0000 Received: from localhost ([127.0.0.1]:52824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZWrN-0006NL-0a for submit@debbugs.gnu.org; Sat, 08 Jun 2019 04:37:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZWrL-0006N8-Ms for 35916@debbugs.gnu.org; Sat, 08 Jun 2019 04:37:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38725) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hZWrG-0003Rw-H9; Sat, 08 Jun 2019 04:37:50 -0400 Received: from [176.228.60.248] (port=2676 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hZWrF-00081c-Aq; Sat, 08 Jun 2019 04:37:49 -0400 Date: Sat, 08 Jun 2019 11:37:42 +0300 Message-Id: <83zhmso4kp.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: (message from Stefan Kangas on Thu, 30 May 2019 19:53:58 +0200) Subject: Re: bug#35916: [PATCH] checkdoc fixes in bookmark.el References: <3d7f02e2-c064-4da4-b6e0-e7b52d0d357d@default> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35916 Cc: 35916@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Thu, 30 May 2019 19:53:58 +0200 > Cc: 35916@debbugs.gnu.org > > Please find attached an updated version of the patch with an improved commit > message. Thanks, this is OK, with one comment: > (defun bookmark-bmenu-other-window-with-mouse (event) > - "Select bookmark at the mouse pointer in other window, leaving bookmark menu visible." > + "Select bookmark at the mouse pointer in other window. > +Move point to the position of EVENT, and leave bookmark menu > +visible." The first line of the doc string should mention the arguments, in this case EVENT. Could you please rework this hunk and resubmit the patch? From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 08 13:22:58 2019 Received: (at 35916) by debbugs.gnu.org; 8 Jun 2019 17:22:58 +0000 Received: from localhost ([127.0.0.1]:53653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZf3S-0002do-07 for submit@debbugs.gnu.org; Sat, 08 Jun 2019 13:22:58 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]:38254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZf3P-0002da-PX for 35916@debbugs.gnu.org; Sat, 08 Jun 2019 13:22:56 -0400 Received: by mail-wm1-f52.google.com with SMTP id s15so2179480wmj.3 for <35916@debbugs.gnu.org>; Sat, 08 Jun 2019 10:22:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TZ1ff2jw8gPDVrhxIueatVlxunTsbJWSLkJ1WvP/IzI=; b=uZ2D93+sYlwZHWZcHwpsCf3l7WCLP2K6iMBmtuIgTlJRyc6yQhIZQrBCxB2RSv/05/ nn3GOmX4ArsEjGZNr4Kjz93ZAXvdVnuZSCDtzUCulGJz28L9oD21tb0Ik8uuawp6+/jf 85XOMM87a7vwBFKFvgNQ7MGwfLWRQrsxafmBzW4kLmeoq5PP7KKSi1jqPUmCmR+CpRzm iqMWH7jxUe6ovOyn4ny+GKQHFzRi4IncCNG7HqxNKdpV+j/Kfnlb/MkBOPPS9BlBiwUx pj8KKQioOdb2ccbeNiFrN0nllLrThiqJQNt5Jncm3nzPCXsIiuAp+okUzPFMnL49/Rxi TnDA== X-Gm-Message-State: APjAAAX2SjlBIOogMBbPNG57t7lKNicFjdQzv619+BikmaonUspe+3cd w13Og6DRBsLMLPzipFCzUhEFxEtLCbCaBo36tik= X-Google-Smtp-Source: APXvYqxlNF3+TCxwN+KRePdE/fKRmFblumPIyUKqqQkxMWvF8bI/AmKdoWXKoCnSn+S8udNVHkYs42mA7Yn7p56nvD0= X-Received: by 2002:a1c:9696:: with SMTP id y144mr7651640wmd.73.1560014570106; Sat, 08 Jun 2019 10:22:50 -0700 (PDT) MIME-Version: 1.0 References: <3d7f02e2-c064-4da4-b6e0-e7b52d0d357d@default> <83zhmso4kp.fsf@gnu.org> In-Reply-To: <83zhmso4kp.fsf@gnu.org> From: Stefan Kangas Date: Sat, 8 Jun 2019 19:22:38 +0200 Message-ID: Subject: Re: bug#35916: [PATCH] checkdoc fixes in bookmark.el To: Eli Zaretskii Content-Type: multipart/mixed; boundary="0000000000004be567058ad33201" X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 35916 Cc: 35916@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.6 (-) --0000000000004be567058ad33201 Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: > The first line of the doc string should mention the arguments, in this > case EVENT. Could you please rework this hunk and resubmit the patch? Sure. I've attached a patch with the following fix: (defun bookmark-bmenu-other-window-with-mouse (event) - "Select bookmark at the mouse pointer in other window, leaving bookmark menu visible." + "Jump to bookmark at mouse EVENT position in other window. +Move point in menu buffer to the position of EVENT and leave +bookmark menu visible." [Gmail might add some line breaks here, sorry about that...] I also included the following additional fix: (defun bookmark-get-bookmark-record (bookmark-name-or-record) - "Return the record portion of the entry for BOOKMARK-NAME-OR-RECORD in -`bookmark-alist' (that is, all information but the name)." + "Return the record portion of BOOKMARK-NAME-OR-RECORD in `bookmark-alist'. +In other words, return all information but the name." Thanks, Stefan Kangas --0000000000004be567058ad33201 Content-Type: application/octet-stream; name="0001-Checkdoc-fixes-in-lisp-bookmark.el-4.patch" Content-Disposition: attachment; filename="0001-Checkdoc-fixes-in-lisp-bookmark.el-4.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jwnsd2pr0 RnJvbSBhMWM1YzE5OWI1Mzg3ZjgwZjdmZDFjNWNmNTc1ZWIxZTFmN2M1YjczIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDI2IE1heSAyMDE5IDEyOjQ4OjI2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g Q2hlY2tkb2MgZml4ZXMgaW4gbGlzcC9ib29rbWFyay5lbAoKKiBsaXNwL2Jvb2ttYXJrLmVsIChi b29rbWFyay1ibWVudS1pbmxpbmUtaGVhZGVyLWhlaWdodCkKKGJvb2ttYXJrLWJtZW51LW1hcmtz LXdpZHRoLCBib29rbWFyay1tYXAsIGJvb2ttYXJrLXF1aXQtZmxhZykKKGJvb2ttYXJrLW5hbWUt ZnJvbS1mdWxsLXJlY29yZCwgYm9va21hcmstc2V0LWludGVybmFsKQooYm9va21hcmstaW5zZXJ0 LWFubm90YXRpb24sIGJvb2ttYXJrLS1qdW1wLXZpYSkKKGJvb2ttYXJrLWJtZW51LXNldC1oZWFk ZXIsIGJvb2ttYXJrLXNob3ctYW5ub3RhdGlvbikKKGJvb2ttYXJrLWJtZW51LW90aGVyLXdpbmRv dy13aXRoLW1vdXNlLCBib29rbWFyay1ibWVudS1yZWxvY2F0ZSk6CkNoZWNrZG9jIGRvY3N0cmlu ZyBmaXhlcy4gIChCdWcjMzU5MTYpCi0tLQogbGlzcC9ib29rbWFyay5lbCB8IDQyICsrKysrKysr KysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDIzIGlu c2VydGlvbnMoKyksIDE5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvYm9va21hcmsu ZWwgYi9saXNwL2Jvb2ttYXJrLmVsCmluZGV4IGVkNzFkZDFhZGUuLmRkODQ3MDE2OGMgMTAwNjQ0 Ci0tLSBhL2xpc3AvYm9va21hcmsuZWwKKysrIGIvbGlzcC9ib29rbWFyay5lbApAQCAtMTM2LDEy ICsxMzYsMTMgQEAgYm9va21hcmstYm1lbnUtdXNlLWhlYWRlci1saW5lCiAgIDpncm91cCAnYm9v a21hcmspCiAKIChkZWZjb25zdCBib29rbWFyay1ibWVudS1pbmxpbmUtaGVhZGVyLWhlaWdodCAy Ci0gICJOdW1iZXIgb2YgbGluZXMgdXNlZCBmb3IgdGhlICpCb29rbWFyayBMaXN0KiBoZWFkZXIK LVwob25seSBzaWduaWZpY2FudCB3aGVuIGBib29rbWFyay1ibWVudS11c2UtaGVhZGVyLWxpbmUn IGlzIG5pbCkuIikKKyAgIk51bWJlciBvZiBsaW5lcyB1c2VkIGZvciB0aGUgKkJvb2ttYXJrIExp c3QqIGhlYWRlci4KK1woVGhpcyBpcyBvbmx5IHNpZ25pZmljYW50IHdoZW4gYGJvb2ttYXJrLWJt ZW51LXVzZS1oZWFkZXItbGluZScKK2lzIG5pbC4pIikKIAogKGRlZmNvbnN0IGJvb2ttYXJrLWJt ZW51LW1hcmtzLXdpZHRoIDIKLSAgIk51bWJlciBvZiBjb2x1bW5zIChjaGFycykgdXNlZCBmb3Ig dGhlICpCb29rbWFyayBMaXN0KiBtYXJrcyBjb2x1bW4sCi1pbmNsdWRpbmcgdGhlIGFubm90YXRp b25zIGNvbHVtbi4iKQorICAiTnVtYmVyIG9mIGNvbHVtbnMgKGNoYXJzKSB1c2VkIGZvciB0aGUg KkJvb2ttYXJrIExpc3QqIG1hcmtzIGNvbHVtbi4KK1RoaXMgaW5jbHVkZXMgdGhlIGFubm90YXRp b25zIGNvbHVtbi4iKQogCiAoZGVmY3VzdG9tIGJvb2ttYXJrLWJtZW51LWZpbGUtY29sdW1uIDMw CiAgICJDb2x1bW4gYXQgd2hpY2ggdG8gZGlzcGxheSBmaWxlbmFtZXMgaW4gYSBidWZmZXIgbGlz dGluZyBib29rbWFya3MuCkBAIC0yMjEsNyArMjIyLDcgQEAgYm9va21hcmstbWFwCiAgICJLZXlt YXAgY29udGFpbmluZyBiaW5kaW5ncyB0byBib29rbWFyayBmdW5jdGlvbnMuCiBJdCBpcyBub3Qg Ym91bmQgdG8gYW55IGtleSBieSBkZWZhdWx0OiB0byBiaW5kIGl0CiBzbyB0aGF0IHlvdSBoYXZl IGEgYm9va21hcmsgcHJlZml4LCBqdXN0IHVzZSBgZ2xvYmFsLXNldC1rZXknIGFuZCBiaW5kIGEK LWtleSBvZiB5b3VyIGNob2ljZSB0byBgYm9va21hcmstbWFwJy4gIEFsbCBpbnRlcmFjdGl2ZSBi b29rbWFyawora2V5IG9mIHlvdXIgY2hvaWNlIHRvIHZhcmlhYmxlIGBib29rbWFyay1tYXAnLiAg QWxsIGludGVyYWN0aXZlIGJvb2ttYXJrCiBmdW5jdGlvbnMgaGF2ZSBhIGJpbmRpbmcgaW4gdGhp cyBrZXltYXAuIikKIAogOzs7IyMjYXV0b2xvYWQgKGZzZXQgJ2Jvb2ttYXJrLW1hcCBib29rbWFy ay1tYXApCkBAIC0zMDEsNyArMzAyLDcgQEAgYm9va21hcmsteWFuay1wb2ludAogCiAKIChkZWZ2 YXIgYm9va21hcmstcXVpdC1mbGFnIG5pbAotICAiTm9uIG5pbCBtYWtlIGBib29rbWFyay1ibWVu dS1zZWFyY2gnIHF1aXQgaW1tZWRpYXRlbHkuIikKKyAgIk5vbi1uaWwgbWVhbnMgYGJvb2ttYXJr LWJtZW51LXNlYXJjaCcgcXVpdHMgaW1tZWRpYXRlbHkuIikKIAwKIDs7IEhlbHBlciBmdW5jdGlv bnMgYW5kIG1hY3Jvcy4KIApAQCAtMzE4LDggKzMxOSw4IEBAIHdpdGgtYnVmZmVyLW1vZGlmaWVk LXVubW9kaWZpZWQKIDs7IEV2ZXJ5b25lIGVsc2Ugc2hvdWxkIGdvIHRocm91Z2ggdGhlbS4KIAog KGRlZnVuIGJvb2ttYXJrLW5hbWUtZnJvbS1mdWxsLXJlY29yZCAoYm9va21hcmstcmVjb3JkKQot ICAiUmV0dXJuIHRoZSBuYW1lIG9mIEJPT0tNQVJLLVJFQ09SRC4gIEJPT0tNQVJLLVJFQ09SRCBp cywgZS5nLiwKLW9uZSBlbGVtZW50IGZyb20gYGJvb2ttYXJrLWFsaXN0Jy4iCisgICJSZXR1cm4g dGhlIG5hbWUgb2YgQk9PS01BUkstUkVDT1JELgorQk9PS01BUkstUkVDT1JEIGlzLCBlLmcuLCBv bmUgZWxlbWVudCBmcm9tIGBib29rbWFyay1hbGlzdCcuIgogICAoY2FyIGJvb2ttYXJrLXJlY29y ZCkpCiAKIApAQCAtMzQ2LDggKzM0Nyw4IEBAIGJvb2ttYXJrLWdldC1ib29rbWFyawogCiAKIChk ZWZ1biBib29rbWFyay1nZXQtYm9va21hcmstcmVjb3JkIChib29rbWFyay1uYW1lLW9yLXJlY29y ZCkKLSAgIlJldHVybiB0aGUgcmVjb3JkIHBvcnRpb24gb2YgdGhlIGVudHJ5IGZvciBCT09LTUFS Sy1OQU1FLU9SLVJFQ09SRCBpbgotYGJvb2ttYXJrLWFsaXN0JyAodGhhdCBpcywgYWxsIGluZm9y bWF0aW9uIGJ1dCB0aGUgbmFtZSkuIgorICAiUmV0dXJuIHRoZSByZWNvcmQgcG9ydGlvbiBvZiBC T09LTUFSSy1OQU1FLU9SLVJFQ09SRCBpbiBgYm9va21hcmstYWxpc3QnLgorSW4gb3RoZXIgd29y ZHMsIHJldHVybiBhbGwgaW5mb3JtYXRpb24gYnV0IHRoZSBuYW1lLiIKICAgKGxldCAoKGFsaXN0 IChjZHIgKGJvb2ttYXJrLWdldC1ib29rbWFyayBib29rbWFyay1uYW1lLW9yLXJlY29yZCkpKSkK ICAgICA7OyBUaGUgYm9va21hcmsgb2JqZWN0cyBjYW4gZWl0aGVyIGxvb2sgbGlrZSAoTkFNRSBB TElTVCkgb3IKICAgICA7OyAoTkFNRSAuIEFMSVNUKSwgc28gd2UgaGF2ZSB0byBkaXN0aW5ndWlz aCB0aGUgdHdvIGhlcmUuCkBAIC04MTIsNyArODEzLDcgQEAgYm9va21hcmstc2V0LWludGVybmFs CiAgICAgICAgICAgIChjb25kCiAgICAgICAgICAgICAoKGVxIG92ZXJ3cml0ZS1vci1wdXNoIG5p bCkKICAgICAgICAgICAgICAoaWYgKGJvb2ttYXJrLWdldC1ib29rbWFyayBzdHIgdCkKLSAgICAg ICAgICAgICAgICAgKGVycm9yICJBIGJvb2ttYXJrIG5hbWVkIFwiJXNcIiBhbHJlYWR5IGV4aXN0 cy4iIHN0cikKKyAgICAgICAgICAgICAgICAgKGVycm9yICJBIGJvb2ttYXJrIG5hbWVkIFwiJXNc IiBhbHJlYWR5IGV4aXN0cyIgc3RyKQogICAgICAgICAgICAgICAgKGJvb2ttYXJrLXN0b3JlIHN0 ciAoY2RyIHJlY29yZCkgbmlsKSkpCiAgICAgICAgICAgICAoKGVxIG92ZXJ3cml0ZS1vci1wdXNo ICdvdmVyd3JpdGUpCiAgICAgICAgICAgICAgKGJvb2ttYXJrLXN0b3JlIHN0ciAoY2RyIHJlY29y ZCkgbmlsKSkKQEAgLTkzNyw2ICs5MzgsNyBAQCBib29rbWFyay1lZGl0LWFubm90YXRpb24tbW9k ZS1tYXAKICAgIktleW1hcCBmb3IgZWRpdGluZyBhbiBhbm5vdGF0aW9uIG9mIGEgYm9va21hcmsu IikKIAogKGRlZnVuIGJvb2ttYXJrLWluc2VydC1hbm5vdGF0aW9uIChib29rbWFyay1uYW1lLW9y LXJlY29yZCkKKyAgIkluc2VydCBhbm5vdGF0aW9uIGZvciBCT09LTUFSSy1OQU1FLU9SLVJFQ09S RCBhdCBwb2ludC4iCiAgIChpbnNlcnQgKGZ1bmNhbGwgYm9va21hcmstZWRpdC1hbm5vdGF0aW9u LXRleHQtZnVuYyBib29rbWFyay1uYW1lLW9yLXJlY29yZCkpCiAgIChsZXQgKChhbm5vdGF0aW9u IChib29rbWFyay1nZXQtYW5ub3RhdGlvbiBib29rbWFyay1uYW1lLW9yLXJlY29yZCkpKQogICAg IChpZiAoYW5kIGFubm90YXRpb24gKG5vdCAoc3RyaW5nLWVxdWFsIGFubm90YXRpb24gIiIpKSkK QEAgLTEwNjYsOCArMTA2OCw4IEBAIGJvb2ttYXJrLWFmdGVyLWp1bXAtaG9vawogVXNlZnVsIGZv ciBleGFtcGxlIHRvIHVuaGlkZSB0ZXh0IGluIGBvdXRsaW5lLW1vZGUnLiIpCiAKIChkZWZ1biBi b29rbWFyay0tanVtcC12aWEgKGJvb2ttYXJrLW5hbWUtb3ItcmVjb3JkIGRpc3BsYXktZnVuY3Rp b24pCi0gICJIYW5kbGUgQk9PS01BUkstTkFNRS1PUi1SRUNPUkQsIHRoZW4gY2FsbCBESVNQTEFZ LUZVTkNUSU9OIHdpdGgKLWN1cnJlbnQgYnVmZmVyIGFzIGFyZ3VtZW50LgorICAiSGFuZGxlIEJP T0tNQVJLLU5BTUUtT1ItUkVDT1JELCB0aGVuIGNhbGwgRElTUExBWS1GVU5DVElPTi4KK0RJU1BM QVktRlVOQ1RJT04gaXMgY2FsbGVkIHdpdGggdGhlIGN1cnJlbnQgYnVmZmVyIGFzIGFyZ3VtZW50 LgogCiBBZnRlciBjYWxsaW5nIERJU1BMQVktRlVOQ1RJT04sIHNldCB3aW5kb3cgcG9pbnQgdG8g dGhlIHBvaW50IHNwZWNpZmllZAogYnkgQk9PS01BUkstTkFNRS1PUi1SRUNPUkQsIGlmIG5lY2Vz c2FyeSwgcnVuIGBib29rbWFyay1hZnRlci1qdW1wLWhvb2snLApAQCAtMTY3Niw3ICsxNjc4LDcg QEAgJ2xpc3QtYm9va21hcmtzCiAoZGVmYWxpYXMgJ2VkaXQtYm9va21hcmtzICdib29rbWFyay1i bWVudS1saXN0KQogCiAoZGVmdW4gYm9va21hcmstYm1lbnUtc2V0LWhlYWRlciAoKQotICAiU2V0 cyB0aGUgaW1tdXRhYmxlIGhlYWRlciBsaW5lLiIKKyAgIlNldCB0aGUgaW1tdXRhYmxlIGhlYWRl ciBsaW5lLiIKICAgKGxldCAoKGhlYWRlciAoY29uY2F0ICIlJSAiICJCb29rbWFyayIpKSkKICAg ICAod2hlbiBib29rbWFyay1ibWVudS10b2dnbGUtZmlsZW5hbWVzCiAgICAgICAoc2V0cSBoZWFk ZXIgKGNvbmNhdCBoZWFkZXIKQEAgLTE4MzYsOCArMTgzOCw4IEBAIGJvb2ttYXJrLWJtZW51LWJv b2ttYXJrCiAKIAogKGRlZnVuIGJvb2ttYXJrLXNob3ctYW5ub3RhdGlvbiAoYm9va21hcmstbmFt ZS1vci1yZWNvcmQpCi0gICJEaXNwbGF5IHRoZSBhbm5vdGF0aW9uIGZvciBCT09LTUFSSy1OQU1F LU9SLVJFQ09SRCBpbiBhIGJ1ZmZlciwKLWlmIGFuIGFubm90YXRpb24gZXhpc3RzLiIKKyAgIkRp c3BsYXkgdGhlIGFubm90YXRpb24gZm9yIEJPT0tNQVJLLU5BTUUtT1ItUkVDT1JEIGluIGEgYnVm ZmVyLgorSWYgdGhlIGFubm90YXRpb24gZG9lcyBub3QgZXhpc3QsIGRvIG5vdGhpbmcuIgogICAo bGV0ICgoYW5ub3RhdGlvbiAoYm9va21hcmstZ2V0LWFubm90YXRpb24gYm9va21hcmstbmFtZS1v ci1yZWNvcmQpKSkKICAgICAod2hlbiAoYW5kIGFubm90YXRpb24gKG5vdCAoc3RyaW5nLWVxdWFs IGFubm90YXRpb24gIiIpKSkKICAgICAgIChzYXZlLWV4Y3Vyc2lvbgpAQCAtMTk5OCw3ICsyMDAw LDkgQEAgYm9va21hcmstYm1lbnUtc3dpdGNoLW90aGVyLXdpbmRvdwogICAgIChib29rbWFyay0t anVtcC12aWEgYm9va21hcmsgZnVuKSkpCiAKIChkZWZ1biBib29rbWFyay1ibWVudS1vdGhlci13 aW5kb3ctd2l0aC1tb3VzZSAoZXZlbnQpCi0gICJTZWxlY3QgYm9va21hcmsgYXQgdGhlIG1vdXNl IHBvaW50ZXIgaW4gb3RoZXIgd2luZG93LCBsZWF2aW5nIGJvb2ttYXJrIG1lbnUgdmlzaWJsZS4i CisgICJKdW1wIHRvIGJvb2ttYXJrIGF0IG1vdXNlIEVWRU5UIHBvc2l0aW9uIGluIG90aGVyIHdp bmRvdy4KK01vdmUgcG9pbnQgaW4gbWVudSBidWZmZXIgdG8gdGhlIHBvc2l0aW9uIG9mIEVWRU5U IGFuZCBsZWF2ZQorYm9va21hcmsgbWVudSB2aXNpYmxlLiIKICAgKGludGVyYWN0aXZlICJlIikK ICAgKHdpdGgtY3VycmVudC1idWZmZXIgKHdpbmRvdy1idWZmZXIgKHBvc24td2luZG93IChldmVu dC1lbmQgZXZlbnQpKSkKICAgICAoc2F2ZS1leGN1cnNpb24KQEAgLTIxMjQsOCArMjEyOCw4IEBA IGJvb2ttYXJrLWJtZW51LWxvY2F0ZQogICAgIChtZXNzYWdlICIlcyIgKGJvb2ttYXJrLWxvY2F0 aW9uIGJtcmspKSkpCiAKIChkZWZ1biBib29rbWFyay1ibWVudS1yZWxvY2F0ZSAoKQotICAiQ2hh bmdlIHRoZSBmaWxlIHBhdGggb2YgdGhlIGJvb2ttYXJrIG9uIHRoZSBjdXJyZW50IGxpbmUsCi0g IHByb21wdGluZyB3aXRoIGNvbXBsZXRpb24gZm9yIHRoZSBuZXcgcGF0aC4iCisgICJDaGFuZ2Ug dGhlIGFic29sdXRlIGZpbGUgbmFtZSBvZiB0aGUgYm9va21hcmsgb24gdGhlIGN1cnJlbnQgbGlu ZS4KK1Byb21wdCB3aXRoIGNvbXBsZXRpb24gZm9yIHRoZSBuZXcgcGF0aC4iCiAgIChpbnRlcmFj dGl2ZSkKICAgKGxldCAoKGJtcmsgKGJvb2ttYXJrLWJtZW51LWJvb2ttYXJrKSkKICAgICAgICAg KHRoaXNwb2ludCAocG9pbnQpKSkKLS0gCjIuMjEuMAoK --0000000000004be567058ad33201-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 09 02:51:53 2019 Received: (at 35916-done) by debbugs.gnu.org; 9 Jun 2019 06:51:53 +0000 Received: from localhost ([127.0.0.1]:54129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZrgH-0003cH-96 for submit@debbugs.gnu.org; Sun, 09 Jun 2019 02:51:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZrgD-0003c3-QH for 35916-done@debbugs.gnu.org; Sun, 09 Jun 2019 02:51:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hZrg8-0000nS-Bn; Sun, 09 Jun 2019 02:51:44 -0400 Received: from [176.228.60.248] (port=1877 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hZrg5-0004Bp-Tl; Sun, 09 Jun 2019 02:51:42 -0400 Date: Sun, 09 Jun 2019 09:51:36 +0300 Message-Id: <831s03ckuf.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: (message from Stefan Kangas on Sat, 8 Jun 2019 19:22:38 +0200) Subject: Re: bug#35916: [PATCH] checkdoc fixes in bookmark.el References: <3d7f02e2-c064-4da4-b6e0-e7b52d0d357d@default> <83zhmso4kp.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35916-done Cc: 35916-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Sat, 8 Jun 2019 19:22:38 +0200 > Cc: 35916@debbugs.gnu.org > > Eli Zaretskii writes: > > The first line of the doc string should mention the arguments, in this > > case EVENT. Could you please rework this hunk and resubmit the patch? > > Sure. I've attached a patch with the following fix: Thanks, pushed to the master branch. From unknown Thu Aug 14 21:49:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 07 Jul 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator