GNU bug report logs - #35901
Installer first check for wifi then format the disk

Previous Next

Package: guix-patches;

Reported by: juh <juh+bug-guix <at> mailbox.org>

Date: Sat, 25 May 2019 15:21:02 UTC

Severity: normal

Merged with 36132

Done: Tobias Geerinckx-Rice <me <at> tobias.gr>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 36132 <at> debbugs.gnu.org, 35901 <at> debbugs.gnu.org
Subject: [bug#35901] [bug#36132] [PATCH 2/2] installer: Show, don't Hide.
Date: Tue, 11 Jun 2019 10:05:56 +0200

Hi,

Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:

> * gnu/installer/newt/user.scm (run-user-add-page): Change the input
> visibility checkbox's text to ‘Show’, and default to unchecked.
> * gnu/installer/newt/page.scm (run-input-page): Likewise.
> Rename INPUT-HIDE-CHECKBOX? argument to INPUT-SHOW-CHECKBOX?.

I think the argument should perhaps be ‘input-visibility-checkbox?’,
otherwise I find it a bit unclear (both before and after the patch
actually.)

Other than that LGTM, thank you!

Ludo’.
This bug report was last modified 5 years and 270 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.