GNU bug report logs - #35895
[PATCH 0/1] linux-container: Remove networking service when network is shared with host.

Previous Next

Full log

Message #17 received at 35895 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 35895 <at> debbugs.gnu.org
Subject: Re: [bug#35895] [PATCH] linux-container: Remove networking service
 when network is shared with host.
Date: Mon, 3 Jun 2019 19:11:36 +0200

[Message part 1 (text/plain, inline)]

On Sat, 25 May 2019 13:37:51 +0100
Christopher Baines <mail <at> cbaines.net> wrote:

> Arun Isaac <arunisaac <at> systemreboot.net> writes:
> 
> > * gnu/system/linux-container.scm (dummy-networking-shepherd-service): New
> > procedure.
> > (dummy-networking-service-type): New variable.
> > (containerized-operating-system): If network is shared with host, replace
> > static-networking-service-type with dummy-networking-service-type.  
> 
> Sounds good. It would be good to have the motivation/reasoning behind
> this change in the commit message though.

IMO in a comment, not in a commit message :)

Let's not make commit messages the documentation--except when it's impossible
to document otherwise.

In this case it's pretty clear what the form in containerized-operating-system
does, but yeah, maybe a comment like the following:

;; Many Guix services (which?) depend on a 'networking' shepherd service, so
;; make sure to provide a dummy 'networking' service when we are sure that
;; networking is already set up in the host and can be used.
;; That prevents double-setup.

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.