From unknown Sat Sep 06 07:59:06 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#35895 <35895@debbugs.gnu.org> To: bug#35895 <35895@debbugs.gnu.org> Subject: Status: [PATCH 0/1] linux-container: Remove networking service when network is shared with host. Reply-To: bug#35895 <35895@debbugs.gnu.org> Date: Sat, 06 Sep 2025 14:59:06 +0000 retitle 35895 [PATCH 0/1] linux-container: Remove networking service when n= etwork is shared with host. reassign 35895 guix-patches submitter 35895 Arun Isaac severity 35895 normal tag 35895 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat May 25 03:15:23 2019 Received: (at submit) by debbugs.gnu.org; 25 May 2019 07:15:23 +0000 Received: from localhost ([127.0.0.1]:48037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUQtn-0004rB-Ey for submit@debbugs.gnu.org; Sat, 25 May 2019 03:15:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUQtj-0004qu-RO for submit@debbugs.gnu.org; Sat, 25 May 2019 03:15:21 -0400 Received: from lists.gnu.org ([209.51.188.17]:46793) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hUQte-0007Rs-4v for submit@debbugs.gnu.org; Sat, 25 May 2019 03:15:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUQtd-0000VB-1J for guix-patches@gnu.org; Sat, 25 May 2019 03:15:14 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hUQgd-0001zg-QO for guix-patches@gnu.org; Sat, 25 May 2019 03:01:48 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:49372) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hUQgc-0001tp-Lf for guix-patches@gnu.org; Sat, 25 May 2019 03:01:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Y6CJE5hAsL+wL3iyvghYX2zBSVfCQW530ZGkbpYUGCc=; b=deoZDOqBfsN+hkN6ONQIdUnvNn 1Gbyr1To/ena1avCrhOVEk7AxrrlP25ihUPd4weM6j0xU0cNQPH0ThwEPCrjdV/wdvCnl6pDkKwi7 h0nYWG9KGDclOoDXzrNROjh2rui+gIZ3DR1n8k06Y+2qs50v06HLh9W39FUVXHoxJ6Z0=; Received: from [49.206.13.26] (helo=steel.lan) by systemreboot.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1hUQgR-00030F-P9; Sat, 25 May 2019 12:31:35 +0530 From: Arun Isaac To: guix-patches@gnu.org Subject: [PATCH 0/1] linux-container: Remove networking service when network is shared with host. Date: Sat, 25 May 2019 12:31:13 +0530 Message-Id: <20190525070113.5576-1-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 139.59.75.54 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) When the container network is shared with the host, the loopback and networking services fail. This causes other services, like nginx, which depend on the loopback and networking services to also fail. Hence, when the network is to be shared with the host, we must replace the static-networking-service-type with a new dummy-networking-service-type that does nothing but simply provide loopback and networking. Arun Isaac (1): linux-container: Remove networking service when network is shared with host. gnu/system/linux-container.scm | 32 +++++++++++++++++++++++++++----- 1 file changed, 27 insertions(+), 5 deletions(-) -- 2.21.0 From debbugs-submit-bounces@debbugs.gnu.org Sat May 25 03:20:55 2019 Received: (at 35895) by debbugs.gnu.org; 25 May 2019 07:20:55 +0000 Received: from localhost ([127.0.0.1]:48042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUQz9-00050C-5n for submit@debbugs.gnu.org; Sat, 25 May 2019 03:20:55 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:38854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUQz7-000504-6N for 35895@debbugs.gnu.org; Sat, 25 May 2019 03:20:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MAqlsNKUSab3E1qNc2/AzHjAh7edULDNIZ6U1vBgHJs=; b=jxqWRCj9kmRzx9Kb41s5/WaGpz cUPaAb4Y+RTx0GM6QpGm8v0NtOTvq+mFvQchoAav9hwXjICgfhxNN1fcTDx6Z2quwAkxfhphfuLkY PE1Nu0hgFs6lSRkuJBViEjQtSyafe+z37YFPl2ep8v/X/FQnbbODwZij3Qi5IhZKk33w=; Received: from [49.206.13.26] (helo=steel.lan) by systemreboot.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1hUQz4-00031Y-3b; Sat, 25 May 2019 12:50:50 +0530 From: Arun Isaac To: 35895@debbugs.gnu.org Subject: [PATCH] linux-container: Remove networking service when network is shared with host. Date: Sat, 25 May 2019 12:50:30 +0530 Message-Id: <20190525072030.7739-1-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35895 Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/system/linux-container.scm (dummy-networking-shepherd-service): New procedure. (dummy-networking-service-type): New variable. (containerized-operating-system): If network is shared with host, replace static-networking-service-type with dummy-networking-service-type. --- gnu/system/linux-container.scm | 32 +++++++++++++++++++++++++++----- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/gnu/system/linux-container.scm b/gnu/system/linux-container.scm index c1e963d047..ee2a476e4c 100644 --- a/gnu/system/linux-container.scm +++ b/gnu/system/linux-container.scm @@ -30,6 +30,7 @@ #:use-module (gnu build linux-container) #:use-module (gnu services) #:use-module (gnu services base) + #:use-module (gnu services shepherd) #:use-module (gnu system) #:use-module (gnu system file-systems) #:export (system-container @@ -65,6 +66,22 @@ from OS that are needed on the bare metal and not in a container." files))) base))) +(define (dummy-networking-shepherd-service _) + (shepherd-service + (documentation "Provide loopback and networking without actually doing +anything.") + (provision '(loopback networking)) + (start #~(const #t)))) + +(define dummy-networking-service-type + (service-type + (name 'dummy-networking) + (extensions + (list (service-extension + shepherd-root-service-type + (compose list dummy-networking-shepherd-service)))) + (default-value #f))) + (define* (containerized-operating-system os mappings #:key shared-network? @@ -96,7 +113,8 @@ containerized OS. EXTRA-FILE-SYSTEMS is a list of file systems to add to OS." agetty-service-type) ;; Remove nscd service if network is shared with the host. (if shared-network? - (list nscd-service-type) + (list nscd-service-type + static-networking-service-type) (list)))) (operating-system @@ -105,10 +123,14 @@ containerized OS. EXTRA-FILE-SYSTEMS is a list of file systems to add to OS." (essential-services (container-essential-services this-operating-system #:shared-network? shared-network?)) - (services (remove (lambda (service) - (memq (service-kind service) - useless-services)) - (operating-system-user-services os))) + (services (append + (remove (lambda (service) + (memq (service-kind service) + useless-services)) + (operating-system-user-services os)) + (if shared-network? + (list (service dummy-networking-service-type)) + (list)))) (file-systems (append (map mapping->fs (if shared-network? (append %network-file-mappings mappings) -- 2.21.0 From debbugs-submit-bounces@debbugs.gnu.org Sat May 25 08:37:58 2019 Received: (at 35895) by debbugs.gnu.org; 25 May 2019 12:37:58 +0000 Received: from localhost ([127.0.0.1]:48338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUVvx-0002wV-Th for submit@debbugs.gnu.org; Sat, 25 May 2019 08:37:58 -0400 Received: from mira.cbaines.net ([212.71.252.8]:49156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUVvw-0002wN-6T for 35895@debbugs.gnu.org; Sat, 25 May 2019 08:37:56 -0400 Received: from localhost (148.185.93.209.dyn.plus.net [209.93.185.148]) by mira.cbaines.net (Postfix) with ESMTPSA id 809EF16FFC; Sat, 25 May 2019 13:37:54 +0100 (BST) Received: from phact (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 220a92f4; Sat, 25 May 2019 12:37:54 +0000 (UTC) References: <20190525070113.5576-1-arunisaac@systemreboot.net> <20190525072030.7739-1-arunisaac@systemreboot.net> User-agent: mu4e 1.2.0; emacs 26.2 From: Christopher Baines To: guix-patches@gnu.org Subject: Re: [bug#35895] [PATCH] linux-container: Remove networking service when network is shared with host. In-reply-to: <20190525072030.7739-1-arunisaac@systemreboot.net> Date: Sat, 25 May 2019 13:37:51 +0100 Message-ID: <8736l2iuao.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 35895 Cc: 35895@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Arun Isaac writes: > * gnu/system/linux-container.scm (dummy-networking-shepherd-service): New > procedure. > (dummy-networking-service-type): New variable. > (containerized-operating-system): If network is shared with host, replace > static-networking-service-type with dummy-networking-service-type. Sounds good. It would be good to have the motivation/reasoning behind this change in the commit message though. > --- > gnu/system/linux-container.scm | 32 +++++++++++++++++++++++++++----- > 1 file changed, 27 insertions(+), 5 deletions(-) > > diff --git a/gnu/system/linux-container.scm b/gnu/system/linux-container.= scm > index c1e963d047..ee2a476e4c 100644 > --- a/gnu/system/linux-container.scm > +++ b/gnu/system/linux-container.scm > @@ -30,6 +30,7 @@ > #:use-module (gnu build linux-container) > #:use-module (gnu services) > #:use-module (gnu services base) > + #:use-module (gnu services shepherd) > #:use-module (gnu system) > #:use-module (gnu system file-systems) > #:export (system-container > @@ -65,6 +66,22 @@ from OS that are needed on the bare metal and not in a= container." > files))) > base))) >=20=20 > +(define (dummy-networking-shepherd-service _) > + (shepherd-service > + (documentation "Provide loopback and networking without actually doing > +anything.") > + (provision '(loopback networking)) > + (start #~(const #t)))) > + > +(define dummy-networking-service-type > + (service-type > + (name 'dummy-networking) > + (extensions > + (list (service-extension > + shepherd-root-service-type > + (compose list dummy-networking-shepherd-service)))) > + (default-value #f))) > + Something like this seems a little neater to me: (define dummy-networking-service-type (service-type (name 'dummy-networking) (extensions (list (service-extension shepherd-root-service-type (const (list (shepherd-service (documentation "Provide loopback and networking without actually doing an= ything.") (provision '(loopback networking)) (start #~(const #t)))))))) (default-value #f))) Just becasue const is being used. Although maybe the shepherd-service itself could do with being extracted to a variable. > (define* (containerized-operating-system os mappings > #:key > shared-network? > @@ -96,7 +113,8 @@ containerized OS. EXTRA-FILE-SYSTEMS is a list of fil= e systems to add to OS." > agetty-service-type) > ;; Remove nscd service if network is shared with the host. > (if shared-network? > - (list nscd-service-type) > + (list nscd-service-type > + static-networking-service-type) > (list)))) >=20=20 > (operating-system > @@ -105,10 +123,14 @@ containerized OS. EXTRA-FILE-SYSTEMS is a list of = file systems to add to OS." > (essential-services (container-essential-services > this-operating-system > #:shared-network? shared-network?)) > - (services (remove (lambda (service) > - (memq (service-kind service) > - useless-services)) > - (operating-system-user-services os))) > + (services (append > + (remove (lambda (service) > + (memq (service-kind service) > + useless-services)) > + (operating-system-user-services os)) > + (if shared-network? > + (list (service dummy-networking-service-type)) > + (list)))) > (file-systems (append (map mapping->fs > (if shared-network? > (append %network-file-mappings mappin= gs) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlzpNx9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xc1RA/9HSidWTM3qXiG6Ug6XvzxieM/3CEF+ZV9LbXEOlqdGoAV7S9jMWT3Il54 geI9NCjWfPvERa4Sm0zBMmPA4HCB8uNL+QEBfclMp8CovhU7we609F21OFNtwfXO 8oGlvkIBK04mULhiqH7hGpMCrkPly1XX6PsMBN6HWUpfIu7+BbtWvw8S5Zb0CtJL 4ANVqAzr08ruk7iEDzYY4qlgp2ZaaqBdSRrHyGRNRgqWvX2Qzj8xRDmwa39V1RH3 x8VTx2RDSjxQSsc0oCyQsbt2fysA50YXMcKYGB0RjFaj0q3AxH/1ezNDKCehqQht PXmsjuVcnb7Zg9bevV1ci2FpaBqUyya2cruZWV+nD5AVmY6sxhfQgola51E4ialR MvnrHa9EIWQDKCXbKsDztMs2hYYhF5k0dTkp5TjnuDKfDeuiDOhEwRVWamLSP5Ff +WhB/uqAO1nKwcFmQILgFwSKw3qv5OA6ViWaPSumBe7ZpZpzAN9O6QBuyJDqwh8l zWZm9wlxgbwc/3E/YNukFIbjxjs5Ikg+dELF8eD9O2RitjGClB4bQdYHS3NCVUDL hluwp5oeJBRln6PjtLaLgGTNIsG6CbHvoI7Bl3tqi+Arb3P1xxvcvsmj5MEhaeL/ 7bWELK8g/HV92lHd2m9Djpdxs4RpSFsVrMJF9mm7/LTZGLB3zjE= =ryEY -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 03 13:11:46 2019 Received: (at 35895) by debbugs.gnu.org; 3 Jun 2019 17:11:46 +0000 Received: from localhost ([127.0.0.1]:42970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXqUs-0006I9-CQ for submit@debbugs.gnu.org; Mon, 03 Jun 2019 13:11:46 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:34256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXqUp-0006Hw-4z for 35895@debbugs.gnu.org; Mon, 03 Jun 2019 13:11:44 -0400 Received: from localhost (178.113.175.254.wireless.dyn.drei.com [178.113.175.254]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 4A871336003A; Mon, 3 Jun 2019 19:11:41 +0200 (CEST) Date: Mon, 3 Jun 2019 19:11:36 +0200 From: Danny Milosavljevic To: Christopher Baines Subject: Re: [bug#35895] [PATCH] linux-container: Remove networking service when network is shared with host. Message-ID: <20190603191031.7e751c2a@scratchpost.org> In-Reply-To: <8736l2iuao.fsf@cbaines.net> References: <20190525070113.5576-1-arunisaac@systemreboot.net> <20190525072030.7739-1-arunisaac@systemreboot.net> <8736l2iuao.fsf@cbaines.net> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/hW_WWszX9bvfFT2nSuWJenc"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 35895 Cc: 35895@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/hW_WWszX9bvfFT2nSuWJenc Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 25 May 2019 13:37:51 +0100 Christopher Baines wrote: > Arun Isaac writes: >=20 > > * gnu/system/linux-container.scm (dummy-networking-shepherd-service): N= ew > > procedure. > > (dummy-networking-service-type): New variable. > > (containerized-operating-system): If network is shared with host, repla= ce > > static-networking-service-type with dummy-networking-service-type. =20 >=20 > Sounds good. It would be good to have the motivation/reasoning behind > this change in the commit message though. IMO in a comment, not in a commit message :) Let's not make commit messages the documentation--except when it's impossib= le to document otherwise. In this case it's pretty clear what the form in containerized-operating-sys= tem does, but yeah, maybe a comment like the following: ;; Many Guix services (which?) depend on a 'networking' shepherd service, so ;; make sure to provide a dummy 'networking' service when we are sure that ;; networking is already set up in the host and can be used. ;; That prevents double-setup. --Sig_/hW_WWszX9bvfFT2nSuWJenc Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlz1VMkACgkQ5xo1VCww uqWBUQgAlAwQfYNflvynDqLhIMvmUj+X126PFfNNYSLakWjqt8bAhRk3PhjSrGPK 7AB4qOb0IMrHTpBlNpJqkgAzkvJBHNV1ys/Sn9GUMoUiV/IUu982UytTOH5DJFMS JGmtJ/5GAIE/eSwQoQL3utWVC0KxKc3TC1k2upyLYxnXDOayvmcWegmbIm7ewM4O RaCIpqNyhIIFiQ3+aMdRFucRd2+Tb4FzN+zZF+08MVpE9jCZ3/kHQNBAga9B9qTv hYSu/1w1xTd8JNOAEsQGDmLCcLE86bEigb48EiSsMY4zTKWdfm8I9r4227iL42cM DlRvDMARbf5PPGTXXZM9/2tti7PdOQ== =xGV/ -----END PGP SIGNATURE----- --Sig_/hW_WWszX9bvfFT2nSuWJenc-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 09 16:35:46 2019 Received: (at 35895) by debbugs.gnu.org; 9 Jun 2019 20:35:46 +0000 Received: from localhost ([127.0.0.1]:55468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ha4XZ-0002uf-EP for submit@debbugs.gnu.org; Sun, 09 Jun 2019 16:35:46 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:46658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ha4XV-0002uO-PN for 35895@debbugs.gnu.org; Sun, 09 Jun 2019 16:35:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=MbLb/vMAulfI8NSufp3iOrqSZN6naNN0w+/NdfJFukY=; b=M6CPoo42pv702n7Th9xm9o6N9 sobDTZDL/83hzpsFdFf7niSCx9wtYOOe64tLEovAv9u57Vi71iPkUFQZoQ5V7EqxGeKxNJFTDlKvc edaFku7xk1FzWbzXBADdaaHDkNlg3KpWM5jVxnGczeGxkNKZ63JOTSL00AUfKCdwWh3Ss=; Received: from [49.206.15.26] (helo=steel) by systemreboot.net with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ha4XR-0002xJ-Oy; Mon, 10 Jun 2019 02:05:37 +0530 From: Arun Isaac To: Danny Milosavljevic , Christopher Baines Subject: Re: [bug#35895] [PATCH] linux-container: Remove networking service when network is shared with host. In-Reply-To: <20190603191031.7e751c2a@scratchpost.org> References: <20190525070113.5576-1-arunisaac@systemreboot.net> <20190525072030.7739-1-arunisaac@systemreboot.net> <8736l2iuao.fsf@cbaines.net> <20190603191031.7e751c2a@scratchpost.org> Date: Mon, 10 Jun 2019 02:05:08 +0530 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35895 Cc: 35895@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Thank you both for the review. I have made the suggested changes. Please find attached an updated patch. In the future, please address me in the Cc or To fields so that I take note sooner. I found your mails only a couple of days ago while going through all my unread mails. :-( --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-linux-container-Remove-networking-service-when-netwo.patch Content-Transfer-Encoding: quoted-printable From=20a7b795d9af3347330b48470d3988d43b8038c2c1 Mon Sep 17 00:00:00 2001 From: Arun Isaac Date: Sat, 25 May 2019 11:49:42 +0530 Subject: [PATCH] linux-container: Remove networking service when network is shared with host. * gnu/system/linux-container.scm (dummy-networking-shepherd-service): New procedure. (dummy-networking-service-type): New variable. (containerized-operating-system): If network is shared with host, replace static-networking-service-type with dummy-networking-service-type. =2D-- gnu/system/linux-container.scm | 36 +++++++++++++++++++++++++++++----- 1 file changed, 31 insertions(+), 5 deletions(-) diff --git a/gnu/system/linux-container.scm b/gnu/system/linux-container.scm index c1e963d047..95b56b6f4f 100644 =2D-- a/gnu/system/linux-container.scm +++ b/gnu/system/linux-container.scm @@ -30,6 +30,7 @@ #:use-module (gnu build linux-container) #:use-module (gnu services) #:use-module (gnu services base) + #:use-module (gnu services shepherd) #:use-module (gnu system) #:use-module (gnu system file-systems) #:export (system-container @@ -65,6 +66,22 @@ from OS that are needed on the bare metal and not in a c= ontainer." files))) base))) =20 +(define dummy-networking-shepherd-service + (shepherd-service + (documentation "Provide loopback and networking without actually doing +anything.") + (provision '(loopback networking)) + (start #~(const #t)))) + +(define dummy-networking-service-type + (service-type + (name 'dummy-networking) + (extensions + (list (service-extension + shepherd-root-service-type + (const (list dummy-networking-shepherd-service))))) + (default-value #f))) + (define* (containerized-operating-system os mappings #:key shared-network? @@ -96,7 +113,8 @@ containerized OS. EXTRA-FILE-SYSTEMS is a list of file = systems to add to OS." agetty-service-type) ;; Remove nscd service if network is shared with the host. (if shared-network? =2D (list nscd-service-type) + (list nscd-service-type + static-networking-service-type) (list)))) =20 (operating-system @@ -105,10 +123,18 @@ containerized OS. EXTRA-FILE-SYSTEMS is a list of fi= le systems to add to OS." (essential-services (container-essential-services this-operating-system #:shared-network? shared-network?)) =2D (services (remove (lambda (service) =2D (memq (service-kind service) =2D useless-services)) =2D (operating-system-user-services os))) + (services (append + (remove (lambda (service) + (memq (service-kind service) + useless-services)) + (operating-system-user-services os)) + ;; Many Guix services depend on a 'networking' shepherd + ;; service, so make sure to provide a dummy 'networking' + ;; service when we are sure that networking is already set = up + ;; in the host and can be used. That prevents double setup. + (if shared-network? + (list (service dummy-networking-service-type)) + (list)))) (file-systems (append (map mapping->fs (if shared-network? (append %network-file-mappings mappings) =2D-=20 2.21.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAlz9bX0ACgkQLiXui2GA K7ORXwf9F1mzSt5rFo0xM5IzoaKdmaqaqfJ5nZYGwHlFA/x8f1g0dVWoWoolHqyg v4vZd7MStjHh/GQRZDwXSst/QB3fCO+HFTylkYUdE622vIU0tJJudbSzETLgoYTN ExRb3mVs/HLxDkldVNXfOlRm6MdmxJh9rIUL6yXVbw1lvf3ct9so+13IxN9oBvwa bA2EDAh4oRdaYOxO7AV+LhzbL2DtRa4ZAKO1pkun6kUukP63IEENoC5Qu3DCMgd2 OG6Ih3IRA8i6ggji6XsnC5+4+NdoP8B6dutFbsYVNabS4yCCLXgBfQZyt490YHQ2 ituukuI/esabi9kR4FHpNj/s3QVLdQ== =wkT1 -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 13 17:02:39 2019 Received: (at 35895) by debbugs.gnu.org; 13 Jun 2019 21:02:39 +0000 Received: from localhost ([127.0.0.1]:36218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbWrn-0007hn-DD for submit@debbugs.gnu.org; Thu, 13 Jun 2019 17:02:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbWrk-0007hZ-V9 for 35895@debbugs.gnu.org; Thu, 13 Jun 2019 17:02:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40753) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hbWre-0004VH-Ht; Thu, 13 Jun 2019 17:02:30 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=39422 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hbWrd-0002ro-P7; Thu, 13 Jun 2019 17:02:30 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Arun Isaac Subject: Re: [bug#35895] [PATCH] linux-container: Remove networking service when network is shared with host. References: <20190525070113.5576-1-arunisaac@systemreboot.net> <20190525072030.7739-1-arunisaac@systemreboot.net> <8736l2iuao.fsf@cbaines.net> <20190603191031.7e751c2a@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 25 Prairial an 227 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 13 Jun 2019 23:02:26 +0200 In-Reply-To: (Arun Isaac's message of "Mon, 10 Jun 2019 02:05:08 +0530") Message-ID: <87a7el19nh.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35895 Cc: Danny Milosavljevic , Christopher Baines , 35895@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Arun Isaac skribis: > From a7b795d9af3347330b48470d3988d43b8038c2c1 Mon Sep 17 00:00:00 2001 > From: Arun Isaac > Date: Sat, 25 May 2019 11:49:42 +0530 > Subject: [PATCH] linux-container: Remove networking service when network = is > shared with host. > > * gnu/system/linux-container.scm (dummy-networking-shepherd-service): New > procedure. > (dummy-networking-service-type): New variable. > (containerized-operating-system): If network is shared with host, replace > static-networking-service-type with dummy-networking-service-type. [...] > +(define dummy-networking-shepherd-service > + (shepherd-service > + (documentation "Provide loopback and networking without actually doing > +anything.") > + (provision '(loopback networking)) > + (start #~(const #t)))) > + > +(define dummy-networking-service-type > + (service-type > + (name 'dummy-networking) > + (extensions > + (list (service-extension > + shepherd-root-service-type > + (const (list dummy-networking-shepherd-service))))) > + (default-value #f))) You can use =E2=80=98shepherd-service-type=E2=80=99 as a shorthand for thes= e two definitions. > + (services (append > + (remove (lambda (service) > + (memq (service-kind service) > + useless-services)) > + (operating-system-user-services os)) > + ;; Many Guix services depend on a 'networking' shepherd > + ;; service, so make sure to provide a dummy 'networking' > + ;; service when we are sure that networking is already se= t up > + ;; in the host and can be used. That prevents double set= up. > + (if shared-network? > + (list (service dummy-networking-service-type)) > + (list)))) I=E2=80=99m really nitpicking here, but I like to have the first argument to =E2=80=98append=E2=80=99 on the same line, and I also visually recognize '(= ) more easily than (list). Anyway, LGTM! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 18 07:38:04 2019 Received: (at 35895) by debbugs.gnu.org; 18 Jun 2019 11:38:04 +0000 Received: from localhost ([127.0.0.1]:43854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdCRA-00038A-Ct for submit@debbugs.gnu.org; Tue, 18 Jun 2019 07:38:04 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:52708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdCR6-00037i-Rq for 35895@debbugs.gnu.org; Tue, 18 Jun 2019 07:38:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=pZuhrCBkJzbszyrPx/Nl6Ztces+5/3/ngvoly0tlOkk=; b=LFxxjvMMV0tSjQDDQm748vor6 mFHAh36/k1eUUAwOvWMI/Y/P54G9UqTG4AOG8NETJDRMfIyjHmOILEEPxhNc/meGixiXwUwSgZI0c i2R8pP8+iO+oaK0SXWUgwNYkCNexp8YoX23ji0nxCuTMQsLcudTKhiSebEHcHh31t8zXU=; Received: from [14.139.128.10] (helo=steel) by systemreboot.net with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hdCR1-0000zo-DF; Tue, 18 Jun 2019 17:07:55 +0530 From: Arun Isaac To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#35895] [PATCH] linux-container: Remove networking service when network is shared with host. In-Reply-To: <87a7el19nh.fsf@gnu.org> References: <20190525070113.5576-1-arunisaac@systemreboot.net> <20190525072030.7739-1-arunisaac@systemreboot.net> <8736l2iuao.fsf@cbaines.net> <20190603191031.7e751c2a@scratchpost.org> <87a7el19nh.fsf@gnu.org> Date: Tue, 18 Jun 2019 17:07:54 +0530 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35895 Cc: Danny Milosavljevic , Christopher Baines , 35895@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain I've made the suggested changes. Please find attached an updated patch. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-linux-container-Remove-networking-service-when-netwo.patch Content-Transfer-Encoding: quoted-printable From=204b50e35e3d2b8adea1e496e0336d23f35d0c9def Mon Sep 17 00:00:00 2001 From: Arun Isaac Date: Sat, 25 May 2019 11:49:42 +0530 Subject: [PATCH] linux-container: Remove networking service when network is shared with host. * gnu/system/linux-container.scm (dummy-networking-shepherd-service): New procedure. (dummy-networking-service-type): New variable. (containerized-operating-system): If network is shared with host, replace static-networking-service-type with dummy-networking-service-type. =2D-- gnu/system/linux-container.scm | 29 ++++++++++++++++++++++++----- 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/gnu/system/linux-container.scm b/gnu/system/linux-container.scm index c1e963d047..61248c62b9 100644 =2D-- a/gnu/system/linux-container.scm +++ b/gnu/system/linux-container.scm @@ -30,6 +30,7 @@ #:use-module (gnu build linux-container) #:use-module (gnu services) #:use-module (gnu services base) + #:use-module (gnu services shepherd) #:use-module (gnu system) #:use-module (gnu system file-systems) #:export (system-container @@ -65,6 +66,16 @@ from OS that are needed on the bare metal and not in a c= ontainer." files))) base))) =20 +(define dummy-networking-service-type + (shepherd-service-type + 'dummy-networking + (const (shepherd-service + (documentation "Provide loopback and networking without actually +doing anything.") + (provision '(loopback networking)) + (start #~(const #t)))) + #f)) + (define* (containerized-operating-system os mappings #:key shared-network? @@ -96,7 +107,8 @@ containerized OS. EXTRA-FILE-SYSTEMS is a list of file = systems to add to OS." agetty-service-type) ;; Remove nscd service if network is shared with the host. (if shared-network? =2D (list nscd-service-type) + (list nscd-service-type + static-networking-service-type) (list)))) =20 (operating-system @@ -105,10 +117,17 @@ containerized OS. EXTRA-FILE-SYSTEMS is a list of fi= le systems to add to OS." (essential-services (container-essential-services this-operating-system #:shared-network? shared-network?)) =2D (services (remove (lambda (service) =2D (memq (service-kind service) =2D useless-services)) =2D (operating-system-user-services os))) + (services (append (remove (lambda (service) + (memq (service-kind service) + useless-services)) + (operating-system-user-services os)) + ;; Many Guix services depend on a 'networking' sheph= erd + ;; service, so make sure to provide a dummy 'network= ing' + ;; service when we are sure that networking is alrea= dy set up + ;; in the host and can be used. That prevents doubl= e setup. + (if shared-network? + (list (service dummy-networking-service-type)) + '()))) (file-systems (append (map mapping->fs (if shared-network? (append %network-file-mappings mappings) =2D-=20 2.22.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAl0IzRIACgkQLiXui2GA K7NoGggAwOmtAXeO7o98E20XIc6/0+DqMAaXm7t0/RNWhdnXKp/+wEEWJyRQSSbC lZqdAN3LkJzWZvUvjKqCmZUFFLC9AaYh3Z6MXtFrwL4yImohyIAKjI9fvsVqc2EK sChHxCvTGwP3lh3UqxtEf4jp2LE5UzH2py8E6iSbceinGGa1uNsoYPZMt7/Ic2Lv PBBrZPoiUnDVivVCt0wJW8vNPnO6UssGvVKkg8apuM1lHIdcymmO4tnPoDlIAgp+ im9GZpEey9APEfzvB8YYC8Fesv2GccsNHDc29uTi04zd76IDzZtIBsIvt/4FLrrm mJPOc22fdp1aZDuPThxNfMb6eU+KfA== =Kgnr -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 18 10:20:06 2019 Received: (at 35895) by debbugs.gnu.org; 18 Jun 2019 14:20:06 +0000 Received: from localhost ([127.0.0.1]:45364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdExy-0001Rf-CG for submit@debbugs.gnu.org; Tue, 18 Jun 2019 10:20:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdExw-0001Qw-K2 for 35895@debbugs.gnu.org; Tue, 18 Jun 2019 10:20:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hdExq-0003AH-A1; Tue, 18 Jun 2019 10:19:58 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=33932 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hdExp-0007dP-Lt; Tue, 18 Jun 2019 10:19:58 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Arun Isaac Subject: Re: [bug#35895] [PATCH] linux-container: Remove networking service when network is shared with host. References: <20190525070113.5576-1-arunisaac@systemreboot.net> <20190525072030.7739-1-arunisaac@systemreboot.net> <8736l2iuao.fsf@cbaines.net> <20190603191031.7e751c2a@scratchpost.org> <87a7el19nh.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 30 Prairial an 227 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 18 Jun 2019 16:19:56 +0200 In-Reply-To: (Arun Isaac's message of "Tue, 18 Jun 2019 17:07:54 +0530") Message-ID: <87fto73rhv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35895 Cc: Danny Milosavljevic , Christopher Baines , 35895@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Arun Isaac skribis: > From 4b50e35e3d2b8adea1e496e0336d23f35d0c9def Mon Sep 17 00:00:00 2001 > From: Arun Isaac > Date: Sat, 25 May 2019 11:49:42 +0530 > Subject: [PATCH] linux-container: Remove networking service when network = is > shared with host. > > * gnu/system/linux-container.scm (dummy-networking-shepherd-service): New > procedure. > (dummy-networking-service-type): New variable. > (containerized-operating-system): If network is shared with host, replace > static-networking-service-type with dummy-networking-service-type. LGTM, thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 18 14:57:53 2019 Received: (at 35895-done) by debbugs.gnu.org; 18 Jun 2019 18:57:53 +0000 Received: from localhost ([127.0.0.1]:45600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdJIm-0005Xx-Qq for submit@debbugs.gnu.org; Tue, 18 Jun 2019 14:57:53 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:57354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdJIj-0005Xi-Da for 35895-done@debbugs.gnu.org; Tue, 18 Jun 2019 14:57:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=7oyNPKSVTSg8DZvGe5lcMqc600G8ukJb6/Bd4UJBUnw=; b=p4qvfffEYdC2TWry10m+8nnDX 3vyVWJH3qLdqg8yIo9s+cLucLbw4V4UyRdXeZ8UUkj5ubXnZha6cqbCNwXq9xoBrRW37WqWeP+VnA HL5uE82E829WENApZW4clBuTGHeSPnbTi086ZSugkBmzX6Z7+ewfKgOrii13c12C/oiJQ=; Received: from [49.206.9.88] (helo=steel) by systemreboot.net with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hdJIc-0001ga-No; Wed, 19 Jun 2019 00:27:42 +0530 From: Arun Isaac To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#35895] [PATCH] linux-container: Remove networking service when network is shared with host. In-Reply-To: <87fto73rhv.fsf@gnu.org> References: <20190525070113.5576-1-arunisaac@systemreboot.net> <20190525072030.7739-1-arunisaac@systemreboot.net> <8736l2iuao.fsf@cbaines.net> <20190603191031.7e751c2a@scratchpost.org> <87a7el19nh.fsf@gnu.org> <87fto73rhv.fsf@gnu.org> Date: Wed, 19 Jun 2019 00:27:42 +0530 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35895-done Cc: Danny Milosavljevic , Christopher Baines , 35895-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain I had forgotten to update the commit message after the last set of changes. I updated the commit message and pushed. Thanks for the peer review, everyone! :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAl0JNCYACgkQLiXui2GA K7PgMwgAtADAfrvNJ1manuuOD6dg9/Vm+pGgPfFiApBPTn9fvmP9kgHB9ghHNL+o yAqTnUMHpZ1uC0psDxFCBPYunvQvs/uM91Wtnx+j0WgSMk9KyFHCPeQDoiTflAJm 1eCnbu4YEWeXAAXMeDfZ13MpwuMmHWkOlKrPMSlLLvZrr76G+fPGOLehL6vjQypo UoPi6bDWCX/oRvHCWEancOch7LXHT/JXIQL6UKhgKl0/JHIMq8RjOQn7yYfxR8sF t+8W0Pyf0G1C+jXzsXBgMejHGILIInB6MZv/MQY3A9YX6p+z+XWLogLuja7jNeV5 CYsGnvIhvcIA3jggKQUbcKWPPc0YpQ== =JJh9 -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Sep 06 07:59:06 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 17 Jul 2019 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator