From debbugs-submit-bounces@debbugs.gnu.org Thu May 23 10:16:23 2019 Received: (at submit) by debbugs.gnu.org; 23 May 2019 14:16:23 +0000 Received: from localhost ([127.0.0.1]:44959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hToW3-0005DV-SR for submit@debbugs.gnu.org; Thu, 23 May 2019 10:16:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hThEQ-0006N9-02 for submit@debbugs.gnu.org; Thu, 23 May 2019 02:29:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:50494) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hThEJ-0006V8-61 for submit@debbugs.gnu.org; Thu, 23 May 2019 02:29:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51738) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hThEH-0007Va-Ke for guix-patches@gnu.org; Thu, 23 May 2019 02:29:31 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hThEF-0006OU-1o for guix-patches@gnu.org; Thu, 23 May 2019 02:29:28 -0400 Received: from mout.perfora.net ([74.208.4.194]:35603) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hThED-0006LR-F7 for guix-patches@gnu.org; Thu, 23 May 2019 02:29:25 -0400 Received: from orion.hitronhub.home ([70.68.94.152]) by mrelay.perfora.net (mreueus004 [74.208.5.2]) with ESMTPSA (Nemesis) id 1MgwK1-1h0Nbl04Mv-00hKb0; Thu, 23 May 2019 08:24:12 +0200 From: mike rosset To: guix-patches@gnu.org Subject: [PATCH] gnu: Add qtwebengine. Date: Wed, 22 May 2019 23:23:44 -0700 Message-Id: <20190523062344.20601-1-mrosset@bufio.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:UKl7mFWA97Zg38sUBZa0Dq5HhHorYCVtTClMnZCILkleOvctL2U aK5MODs82PWA7t6Kx1lm2dWdyLM+Obx6CmYPDnQOhckMTWL6Xk9R4ypiW7umyMsWI0bzQq+ wUcSAXI26NaI9a/tNpccATXk3CQD9WTZkBpNFCdw/WfbjAEkYww+jlhNkRY5hW+WG8vovlj CsWsYiWOu3i/xBKU7LNJg== X-UI-Out-Filterresults: notjunk:1;V03:K0:P4Y1fgSE884=:uosjdkGLCNvzvPMpURjeiz Cvk5WzqvEMywaIYMqLlGW3becrV9mVM96htCddUW9j1VslxwBtx2tCA654H5R7hH8tckUz9Hp V8+/IAMCJdykYunP1h8g3LFJUEdHzh3nMDZqCfVqWDnm9uLNx6qdh6r9Eym8r9DiHQWhUgCA/ tex3EKYr4JVbqYrMYsYxAKdEO7awj7zqUmtnuUv3aDkTmv2rA6Ex4pOos6OAbb2szl/c8pFIX fOHXC6+rm56AfP8DK475vduJEjc5FySFiVAtVWb/1ji+fK/K/6pnpk+2t6IqqplDKfYKNNjDn fSNSkB7plhe0j7BSI95m4lTooRnoHH6OUuXGfwFIERIHKfZObZ+qNPy4jMYOKZQWJDLk5hCH1 iS7Y18yE6bSkVQTEXDIeWa8v0F0tbf0pI9zGcFl8Sto2mtCUpDyNszicBcX0RSX5vXlh57dMr tIM/1UU1oojdo8rpYQ6pfFkj/Y1vnBcq22/uICan37GRTP6wz27NpDeG1/kaoXQ4rrtmLmPud LGwk6Lj930+nOO7E0LYTPXq/aLQ27OGK7MW8H0KGczp81PyfZ0DVPRkb1H7KYAzSkwsiXy6SS D+lkO3Jz/ltflOony+5rXJBZ0o4Ce1WMt4p/FHE8J2RIrdsxcoFXpyAapTxBBFI4XRYrT5X2z uBJJOFYdJDbGmH2TlYiFOyB944aYMx9OOoooUq5XZa/EQYkeK6jQjdzSEGKHFwEn9SWHFVrEc hfzFWW0/MhZDVjBjuz1zDUpXNsc3r9S4cgbCHA== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 74.208.4.194 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 23 May 2019 10:16:18 -0400 Cc: mike.rosset@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) From: mike rosset * gnu/packages/qt.scm (qtwebengine): New variable. --- gnu/packages/qt.scm | 133 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 133 insertions(+) diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index afc4d8dc06..d00cc2692a 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -48,6 +48,7 @@ #:use-module (gnu packages freedesktop) #:use-module (gnu packages gl) #:use-module (gnu packages glib) + #:use-module (gnu packages gnupg) #:use-module (gnu packages gperf) #:use-module (gnu packages gstreamer) #:use-module (gnu packages gtk) @@ -55,6 +56,7 @@ #:use-module (gnu packages image) #:use-module (gnu packages linux) #:use-module (gnu packages maths) + #:use-module (gnu packages ninja) #:use-module (gnu packages nss) #:use-module (gnu packages pciutils) #:use-module (gnu packages pcre) @@ -63,6 +65,7 @@ #:use-module (gnu packages pulseaudio) #:use-module (gnu packages python) #:use-module (gnu packages python-xyz) + #:use-module (gnu packages re2c) #:use-module (gnu packages ruby) #:use-module (gnu packages sdl) #:use-module (gnu packages sqlite) @@ -2274,3 +2277,133 @@ user-friendly than the default @code{QColorDialog} and several other color-related widgets.") ;; Includes a license exception for combining with GPL2 code. (license license:lgpl3+)))) + +(define-public qtwebengine + (package + (name "qtwebengine") + (version (package-version qtbase)) + (source + (origin + (method url-fetch) + (uri + (string-append "https://download.qt.io/official_releases/qt/" + (substring version 0 4) + "/" version "/submodules/" + (string-append name "-everywhere-src-" version) + ".tar.xz")) + (sha256 + (base32 + "1zmqsdais85cdfh2jh8h4a5jcamp1mzdk3vgqm6xnldqf6nrxd2v")))) + (build-system gnu-build-system) + (native-inputs + `( + ("perl" ,perl) + ("python-2" ,python-2) + ("pkg-config" ,pkg-config) + ("flex" ,flex) + ("bison" ,bison) + ("ruby" ,ruby) + ("ninja" ,ninja) + )) + (inputs + `( + ("qtbase" ,qtbase) + ("qtdeclarative" ,qtdeclarative) + ("libxcb" ,libxcb) + ("xcb-util" ,xcb-util) + ("libxkbcommon" ,libxkbcommon) + ("libx11" ,libx11) + ("libxrender" ,libxrender) + ("libxi" ,libxi) + ;; OpenGL + ("mesa" ,mesa) + ;; qt web engine + ("libgcrypt" ,libgcrypt) + ("pciutils" ,pciutils) + ("nss" ,nss) + ("libxtst" ,libxtst) + ("gperf" ,gperf) + ("cups-minimal" ,cups-minimal) + ("pulseaudio" ,pulseaudio) + ("udev" ,eudev) + ;; systemd-devel? no systemd on guix + ("libcap" ,libcap) + ("alsa-lib" ,alsa-lib) + ("dbus" ,dbus) + ("libxrandr" ,libxrandr) + ("libxcomposite" ,libxcomposite) + ("libxcursor" ,libxcursor) + ("fontconfig" ,fontconfig) + ("qtwebchannel" ,qtwebchannel) + ("atk" ,atk) + ("qtmultimedia" ,qtmultimedia) + ("re2c" ,re2c) + )) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-before 'configure 'configure-qmake + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (qtbase (assoc-ref inputs "qtbase")) + (tmpdir (string-append (getenv "TMPDIR"))) + (qmake (string-append tmpdir "/qmake")) + (qt.conf (string-append tmpdir "/qt.conf"))) + ;; Use qmake with a customized qt.conf to override install + ;; paths to $out. + (symlink (which "qmake") qmake) + (setenv "CC" "gcc") + (setenv "PATH" (string-append tmpdir ":" (getenv "PATH"))) + (with-output-to-file qt.conf + (lambda () + (format #t "[Paths] +Prefix=~a +ArchData=lib/qt5 +Data=share/qt5 +Documentation=share/doc/qt5 +Headers=include/qt5 +Libraries=lib +LibraryExecutables=lib/qt5/libexec +Binaries=bin +Tests=tests +Plugins=lib/qt5/plugins +Imports=lib/qt5/imports +Qml2Imports=lib/qt5/qml +Translations=share/qt5/translations +Settings=etc/xdg +Examples=share/doc/qt5/examples +HostPrefix=~a +HostData=lib/qt5 +HostBinaries=bin +HostLibraries=lib + +[EffectiveSourcePaths] +HostPrefix=~a +HostData=lib/qt5 +" out out qtbase))) + #t))) + (replace 'configure + (lambda* (#:key inputs outputs #:allow-other-keys) + ;; Valid QT_BUILD_PARTS variables are: + ;; libs tools tests examples demos docs translations + (invoke "qmake" "QT_BUILD_PARTS = libs tools"))) + (add-before 'check 'set-display + (lambda _ + ;; make Qt render "offscreen", required for tests + (setenv "QT_QPA_PLATFORM" "offscreen") + #t)) + (add-after 'install-binaries 'install-qt.conf + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (tmpdir (string-append (getenv "TMPDIR"))) + (in.conf (string-append tmpdir "/qt.conf")) + (out.conf (string-append out "/lib/qt5/libexec/qt.conf"))) + (copy-file in.conf out.conf)) + #t)) + ))) + (home-page "https://www.qt.io") + (synopsis "Qt5WebEngine") + (description "Qt5WebEngine provides support for web +applications using the Chromium browser project.") + (license + (package-license qt)))) -- 2.21.0 From debbugs-submit-bounces@debbugs.gnu.org Mon May 27 17:13:43 2019 Received: (at 35866) by debbugs.gnu.org; 27 May 2019 21:13:43 +0000 Received: from localhost ([127.0.0.1]:54340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVMwA-0003ut-VB for submit@debbugs.gnu.org; Mon, 27 May 2019 17:13:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVMw8-0003ue-PA for 35866@debbugs.gnu.org; Mon, 27 May 2019 17:13:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45259) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVMoD-0003si-Jk; Mon, 27 May 2019 17:05:32 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=55340 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hVMnz-0000XO-37; Mon, 27 May 2019 17:05:20 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: mike rosset Subject: Re: [bug#35866] [PATCH] gnu: Add qtwebengine. References: <20190523062344.20601-1-mrosset@bufio.org> Date: Mon, 27 May 2019 23:05:08 +0200 In-Reply-To: <20190523062344.20601-1-mrosset@bufio.org> (mike rosset's message of "Wed, 22 May 2019 23:23:44 -0700") Message-ID: <87zhn7pq0r.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35866 Cc: mike.rosset@gmail.com, 35866@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Mike, mike rosset skribis: > From: mike rosset > > * gnu/packages/qt.scm (qtwebengine): New variable. looks pretty exciting, which motivates me to take a look at this patch. :-) > + (synopsis "Qt5WebEngine") > + (description "Qt5WebEngine provides support for web > +applications using the Chromium browser project.") As you may know, Guix contains a variant of =E2=80=98ungoogled-chromium=E2= =80=99, which goes to great lengths to remove non-free software, DRM support, spyware, et= c. The problem is that QtWebEngine bundles Chromium. We would need to =E2=80=9Cunbundle=E2=80=9D it and/or replace it with =E2=80=98ungoogled-chr= omium=E2=80=99. I=E2=80=99m not sure how hard that is. Have you thought about this? Would you like to give it a try? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue May 28 14:30:45 2019 Received: (at 35866) by debbugs.gnu.org; 28 May 2019 18:30:45 +0000 Received: from localhost ([127.0.0.1]:57093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVgs0-0002Q5-Tu for submit@debbugs.gnu.org; Tue, 28 May 2019 14:30:45 -0400 Received: from mout.perfora.net ([74.208.4.196]:58279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVgDi-0001HH-59 for 35866@debbugs.gnu.org; Tue, 28 May 2019 13:49:07 -0400 Received: from orion ([70.68.94.152]) by mrelay.perfora.net (mreueus004 [74.208.5.2]) with ESMTPSA (Nemesis) id 1MaISf-1h8BQg25tV-00WDIu; Tue, 28 May 2019 19:48:55 +0200 From: mrosset@bufio.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#35866] [PATCH] gnu: Add qtwebengine. References: <20190523062344.20601-1-mrosset@bufio.org> <87zhn7pq0r.fsf@gnu.org> Date: Tue, 28 May 2019 10:48:52 -0700 In-Reply-To: <87zhn7pq0r.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 27 May 2019 23:05:08 +0200") Message-ID: <87y32qii63.fsf@bufio.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:p8d9/Q6PFvNl3djXq/T8Ijp7XQkoVbR8/WL10Bs82HOP/OA0GpV 8qC3235PcxaQYc5+zT6OitpDSERm3C1rvQoJtvmQIlQ2Vc6Ski9fmU8GCu2fn030TnEiKeu OPZcUkwHseZb1RJtuopleyTD/sDKNGlUgU9KwEo05XOiWzTzkb1GprnsAhCeisuxIOGrZLF PHlWszZH9qM8uUKBkl3Lg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:zgTcWkjN19k=:wViLX7kj7zagrFkpzlzC5F SRCcN1UWba/ZmHwe/GMtDjcE/sF4G7WGWklEbhYJt+ENbCul2KQizTF6JuIYAAj+gzttTO+ra 9kFmePk8NYAkENw/kAJn8qc62ERAOi1GmwDgKqiHZ1kLW0YLCPg6llH/x60S2EjBbeRix/qbY D/bIB1UHV1dD0MTnS3rKxVCT+BGwoazHYJEdVFh8AGQToWCa1fE/77q+irhjkh1uzNK3HGvii G+CaS5uM8VFvyT7qOjHBt0KBelr2JivDhqt73Z6W+GOCaRIti36IDtYlwyCWaYSK6Lc14+2DF 7k0amkQDL64fPra9Fn27wa56arjEOTgb9wI+2bAwayiXkPzk1V1di8bEkdiCzqxEevt6FHht9 ubail5sQX96ZDb/F5506TmedhseIf98CkGlqMYGK1UPukux/Ovk5Ew43zzrY+xkIktFGAcnuM 51Gqe7AI8Ql72qJvcJv0cQe54oGE3UrXix4MZ0xds8vCqWbQiLMUQeZr4OqVVYvTdnErflIxb +43egYdd6K4mOW7tCmm6tHNKjyIl+Ba3PhdxZ9ZRh7S3HEwxpM4NfqHlW+zHtDzsncxITPWt5 kCsA4a4H0h2uzMQi9F2Xv7zID9sDJMCIK5fQZ0QtvViovk4eXIEOKZMhoFbpfHmL1x3dNRjVF p2YHF/RoGneuDR7FcVDxl1icaP53HOkIPeZUW186T0MXMazB5tu8hi94IFCymJnCO1W5wmacg U8ohrXj5bcRt7HOQomqHi5bUSigdQ23A81yh+uSyuc69gFt6mYuNCVxlgss= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35866 X-Mailman-Approved-At: Tue, 28 May 2019 14:30:43 -0400 Cc: mike.rosset@gmail.com, 35866@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ludovic Court=C3=A8s writes: Hello Ludovic, thank you for looking at this. > > looks pretty exciting, which > motivates me to take a look at this patch. :-) This is my motivation for having this included with guix. the main URL is https://savannah.nongnu.org/projects/nomad/ and the main source is http://git.savannah.nongnu.org/cgit/nomad.git?h=3Dfeature-qt. Development is currently being done on the feature-qt branch. Nomad is still very much WIP. And some early documentation can be found here. http://git.savannah.nongnu.org/cgit/nomad.git/tree/org/README.txt?h= =3Dfeature-qt. In short Nomad is an extensible web browser that uses GNU guile as it's extension language. And is heavily modeled after Emacs. >> + (synopsis "Qt5WebEngine") >> + (description "Qt5WebEngine provides support for web >> +applications using the Chromium browser project.") > > As you may know, Guix contains a variant of =E2=80=98ungoogled-chromium= =E2=80=99, which > goes to great lengths to remove non-free software, DRM support, spyware, = etc. > > The problem is that QtWebEngine bundles Chromium. We would need to > =E2=80=9Cunbundle=E2=80=9D it and/or replace it with =E2=80=98ungoogled-c= hromium=E2=80=99. I=E2=80=99m not sure > how hard that is. I have done some research as to how best to handle the chromium sources that are distributed with qtwebengine. From my understanding so far. QT has similar goals as ungoogle-chromium. Based off of the information found here https://wiki.qt.io/QtWebEngine. Binaries are stripped from source tree. Services that talk to Google are removed. And the code is refactored to use system libraries like OpenSSL. There is a more in depth break down on the chromium rebase process found here. https://wiki.qt.io/QtWebEngine/Rebase_on_New_Chromium . It seems to me that QT is already doing the right thing here. Unfortunately I don't think it will be easy to reuse the ungoogle-chrome code base. It would probably require manually re-basing then applying qt patches. Also there is no clear benefit for it. Since updating ungoogle-chromium would not directly benefit qtwebengine. In short QT seems to already be doing the necessary work. I can though now, do my best to ensure that the least amount of 3rd party libraries are used. I'll update my patch as soon as possible. And I will explore the chromium source issue more in the process. Regards, Mike Rosset From debbugs-submit-bounces@debbugs.gnu.org Wed May 29 19:37:30 2019 Received: (at 35866) by debbugs.gnu.org; 29 May 2019 23:37:30 +0000 Received: from localhost ([127.0.0.1]:60309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hW88P-0006fq-UW for submit@debbugs.gnu.org; Wed, 29 May 2019 19:37:30 -0400 Received: from mout.perfora.net ([74.208.4.194]:46909) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hW88K-0006fU-WF for 35866@debbugs.gnu.org; Wed, 29 May 2019 19:37:25 -0400 Received: from orion.hitronhub.home ([70.68.94.152]) by mrelay.perfora.net (mreueus004 [74.208.5.2]) with ESMTPSA (Nemesis) id 1M3lDb-1hVImj2E3X-000uUi; Thu, 30 May 2019 01:37:18 +0200 From: Mike Rosset To: 35866@debbugs.gnu.org Subject: Date: Wed, 29 May 2019 16:37:04 -0700 Message-Id: <20190529233705.21127-1-mrosset@bufio.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:+4Wz8DO91EOWZhCVcBQ1J4J0kkqJlBIkxK4zgXNq9USld+v0JP9 qI2zoMwb7VFcE0aj9GdKrraTot96Y5Gsiwb/2gSb+gC4GiXwPXSNhbgNAhtTFtQAjrqt6bV V2OhA2nztju8NhTE05W21f0A7wvvqqp5MzOBMmtSf7CQtCp7Gooe/D9rXTGi9cDnEahrlB8 jOBFMjNC716VxlLq05IlA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:B3ArBEm0rOY=:ZtperKv9dfu2GwafyGvicY yVEIApdfbqtdzzcxc9TSw7RdZ3upXlU2nkmE609vRXPgfgKq/0xg80fLsw8Wn6Z7CVD0/8lHK D0zM8iwDtkNA1MnKCVkn0DTxBpH/3ajBVYtktxq1CBbEwxHGlq0Tvo86DOQ7ET+YYTZhOf98f VWSoGSoVYujwb0AK5Kgg2lahLzVD/lgv9w6cdHxIdcrS9rjf9qHOLHryjPqSkun1n5VdYt7pd KqI6TUs3+50kfhWEi7KiFc3Eo2KfiondxVp719K8UAD5rk5TQuMHsGLaHKxJO/rpXUkzB9p1d +/HM9TA/8nwPZs7B96ZO9rw5g/oEkGG0QYU+EqfJaz3VMfGWlAgISq2CF549+2BjkdWhxiegl 6fQTNSfebCr3yEc7ikUynRmo8+Oe/fcJ8eCMOy+sKCUaaEsrz0sfsmEX9oui5cUbYubekkEpB UrkBLJgbiyW0R7WS0moE27hogAPffH+hth6JQu0i+vBerGNVTV7Z1mdLHspwTyCMLTj3rBixF q0oFvyCqcTnJR7fWHvuzSyqP+LOPcjR+BVJgXkpCp6VMU5mQXmfVCHg0j9MxFbTgqDeofepx0 mfjAUzvucMYxGrbbCUUqjdX1woBVsyPO8WmznEUJYV0FH8CdewfDDJSatKskwcgvrYsZzCw7L VP/e0PcfIMCYgkZXpoxm6dm7jwWXi2IwrtrKaOAwXdGbjBUKpUDuS6G/qZVsSGX2b+4cyfL2i lWv3MbmV76WCDTenSBUvJ56whHqvyliJjlckEQ== X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This patch ensures qtwebengine uses only Guix libraries. There are some libraries that fail to be detect or are missing features. I have documented them within the input expression. Note. I'm not sure if I've sent this patch right. If this is wrong I can resend the complete series Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [74.208.4.194 listed in list.dnswl.org] 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: 35866 Cc: mike.rosset@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) This patch ensures qtwebengine uses only Guix libraries. There are some libraries that fail to be detect or are missing features. I have documented them within the input expression. Note. I'm not sure if I've sent this patch right. If this is wrong I can resend the complete series From debbugs-submit-bounces@debbugs.gnu.org Wed May 29 19:37:42 2019 Received: (at 35866) by debbugs.gnu.org; 29 May 2019 23:37:42 +0000 Received: from localhost ([127.0.0.1]:60312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hW88b-0006gQ-7E for submit@debbugs.gnu.org; Wed, 29 May 2019 19:37:42 -0400 Received: from mout.perfora.net ([74.208.4.194]:51315) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hW88Y-0006g2-V4 for 35866@debbugs.gnu.org; Wed, 29 May 2019 19:37:39 -0400 Received: from orion.hitronhub.home ([70.68.94.152]) by mrelay.perfora.net (mreueus004 [74.208.5.2]) with ESMTPSA (Nemesis) id 1N2ma8-1gTTkW3aMW-0136JL; Thu, 30 May 2019 01:37:33 +0200 From: Mike Rosset To: 35866@debbugs.gnu.org Subject: [PATCH] gnu: qtwebengine: Do not use 3rd party libraries. Date: Wed, 29 May 2019 16:37:05 -0700 Message-Id: <20190529233705.21127-2-mrosset@bufio.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190529233705.21127-1-mrosset@bufio.org> References: <20190529233705.21127-1-mrosset@bufio.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:RErsd6B81LLVIjZ6z7rQJZyIY2t3JL7qCg29l5CgSlM4zHX3tLS SnqaMATMQTot7BLow7UPdbZfbrCV/Qy8+Odbld660ItfvLRyVSfvW6Tu+SPOsIlYcTIJxwe Cl8O5ybXCWR1Kr9kzCn+sA8+EHkfRqYwWRotr7ZrqUBitskcxciWqjSVGPaorbY6V29pBL7 WcgfKAx4Ie47zblnGRGCQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:/7gmPKF6kWQ=:vRVh2VttoQVhuApboOkgwM /R86jpZBwsAehLFf3Ahdv5x7/acXwV4Hgy8oPLCw4O1SfhrVOBVWeB5xElqYynQOWI9CrOuzY 4KHAYi+gdimd8tX+RZsOQWiwGmn5qpY2G1avWg1aCoWT1jI7mPoFtgLRLjVVJeE2a6YSESjzi 1luQcQUNU4E7ai55GGLI9IVuN7wpUw3gTfjlS5c5zgh1YklfW5nT1/DLDaEV/PH6ReCJvDxPD 47hL2NB/n/q7lZ9hXNUja6cGyPEg9ExSfR1u5m0cYV8SvIApThdNjyx2j6JbPLmeZfAAjb3h9 OHsSpXuKzRkDLrK64lHXm8hmy+tfgyhYwryIP4ylBX5LUoHt2tycq10MzqzhcQU3H8CgQ3UJf 2ADw4liGZda3SnYsZWVtDgbsm7fPGak0OIk8P42v/Z0QSJwd+kZbrIPrgwWTbocM2FeoMdykU SSnZ4t6dsN8vM8SjQ1FmyEfVok62mM9NWl8EgK5pgs3BxrZ7XJX1gGyHKXOivi3P4KqS1dVbv Unmf2SDQgqGtKJ17U9+PsYkLmMT4BVgUKJgir0PBjdARQt3Rv3Fa048x5nbmXqoi0E2DKRy5s 6GVpmQQHgMqHkwFcWyv9zY2M/+mfrqbMUeLxndZrmygzZsvCe6/TlLEXaKKQVpq76qjEMEAyn 9Bjj1QrT3usdt9UP56i2AXKWUqPNUdbXkNujCS3R/vrjlTDCzIPrIvr4i9es+RtNK8w+qG7+J HeRhxgO/EJUwXpOCPnXLReCN/DTDz7rtgCq57g== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35866 Cc: mike.rosset@gmail.com, Mike Rosset X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Most in tree third party libraries are now linked to Guix libraries. There are a few Guix libraries that break the build or are not automatically detected these are now documented in the input expression. gnu: qtwebengine: PDF and printing support is now disabled. PDF and printing requires pepper plugins. which is not enabled. --- gnu/packages/qt.scm | 87 +++++++++++++++++++++++++++++---------------- 1 file changed, 57 insertions(+), 30 deletions(-) diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index d00cc2692a..658946f4a1 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -46,6 +46,7 @@ #:use-module (gnu packages fontutils) #:use-module (gnu packages flex) #:use-module (gnu packages freedesktop) + #:use-module (gnu packages ghostscript) #:use-module (gnu packages gl) #:use-module (gnu packages glib) #:use-module (gnu packages gnupg) @@ -55,6 +56,7 @@ #:use-module (gnu packages icu4c) #:use-module (gnu packages image) #:use-module (gnu packages linux) + #:use-module (gnu packages libevent) #:use-module (gnu packages maths) #:use-module (gnu packages ninja) #:use-module (gnu packages nss) @@ -62,16 +64,21 @@ #:use-module (gnu packages pcre) #:use-module (gnu packages perl) #:use-module (gnu packages pkg-config) + #:use-module (gnu packages protobuf) #:use-module (gnu packages pulseaudio) #:use-module (gnu packages python) #:use-module (gnu packages python-xyz) - #:use-module (gnu packages re2c) + #:use-module (gnu packages regex) #:use-module (gnu packages ruby) #:use-module (gnu packages sdl) #:use-module (gnu packages sqlite) + #:use-module (gnu packages serialization) #:use-module (gnu packages tls) + #:use-module (gnu packages telephony) + #:use-module (gnu packages video) #:use-module (gnu packages vulkan) #:use-module (gnu packages xdisorg) + #:use-module (gnu packages xiph) #:use-module (gnu packages xorg) #:use-module (gnu packages xml) #:use-module (srfi srfi-1)) @@ -2297,47 +2304,63 @@ color-related widgets.") (build-system gnu-build-system) (native-inputs `( + ("bison" ,bison) + ("flex" ,flex) + ("gperf" ,gperf) + ("ninja" ,ninja) ("perl" ,perl) - ("python-2" ,python-2) ("pkg-config" ,pkg-config) - ("flex" ,flex) - ("bison" ,bison) + ("python-2" ,python-2) ("ruby" ,ruby) - ("ninja" ,ninja) )) (inputs `( - ("qtbase" ,qtbase) - ("qtdeclarative" ,qtdeclarative) + ("alsa-lib" ,alsa-lib) + ("atk" ,atk) + ("cups-minimal" ,cups-minimal) + ("dbus" ,dbus) + ("ffmpeg" ,ffmpeg) + ("fontconfig" ,fontconfig) + ("harbuzz" ,harfbuzz) + ("icu4c" ,icu4c) + ("jsoncpp" ,jsoncpp) + ("lcms" ,lcms) + ("libcap" ,libcap) + ("libevent" ,libevent) + ("libgcrypt" ,libgcrypt) + ("libjpeg" ,libjpeg-turbo) + ;; libsrtp not found by qmake. seems to not have config.tests? + ("libsrtp" ,libsrtp) + ;; FIXME: error: ?struct vpx_svc_ref_frame_config? has no member named ?frame_flags? + ;; ("libvpx" ,libvpx) + ("libwebp" ,libwebp) + ("libx11" ,libx11) ("libxcb" ,libxcb) - ("xcb-util" ,xcb-util) + ("libxcomposite" ,libxcomposite) + ("libxcursor" ,libxcursor) + ("libxi" ,libxi) ("libxkbcommon" ,libxkbcommon) - ("libx11" ,libx11) + ;; libxml not found due to icu not enabled in libxml? + ("libxml2" ,libxml2) + ("libxrandr" ,libxrandr) ("libxrender" ,libxrender) - ("libxi" ,libxi) - ;; OpenGL + ("libxslt" ,libxslt) + ("libxtst" ,libxtst) ("mesa" ,mesa) - ;; qt web engine - ("libgcrypt" ,libgcrypt) - ("pciutils" ,pciutils) + ("minizip" ,minizip) ("nss" ,nss) - ("libxtst" ,libxtst) - ("gperf" ,gperf) - ("cups-minimal" ,cups-minimal) + ("opus" ,opus) + ("pciutils" ,pciutils) + ("protobuf" ,protobuf) ("pulseaudio" ,pulseaudio) - ("udev" ,eudev) - ;; systemd-devel? no systemd on guix - ("libcap" ,libcap) - ("alsa-lib" ,alsa-lib) - ("dbus" ,dbus) - ("libxrandr" ,libxrandr) - ("libxcomposite" ,libxcomposite) - ("libxcursor" ,libxcursor) - ("fontconfig" ,fontconfig) - ("qtwebchannel" ,qtwebchannel) - ("atk" ,atk) + ("qtbase" ,qtbase) + ("qtdeclarative" ,qtdeclarative) ("qtmultimedia" ,qtmultimedia) - ("re2c" ,re2c) + ("qtwebchannel" ,qtwebchannel) + ("re2" ,re2) + ("snappy" ,snappy) + ("udev" ,eudev) + ("xcb-util" ,xcb-util) )) (arguments `(#:phases @@ -2386,7 +2409,11 @@ HostData=lib/qt5 (lambda* (#:key inputs outputs #:allow-other-keys) ;; Valid QT_BUILD_PARTS variables are: ;; libs tools tests examples demos docs translations - (invoke "qmake" "QT_BUILD_PARTS = libs tools"))) + (invoke "qmake" "QT_BUILD_PARTS = libs tools" "--" + "--webengine-printing-and-pdf=no" + "--webengine-ffmpeg=system" + "--webengine-icu=system" + "--webengine-pepper-plugins=no"))) (add-before 'check 'set-display (lambda _ ;; make Qt render "offscreen", required for tests -- 2.21.0 From debbugs-submit-bounces@debbugs.gnu.org Fri May 31 15:28:39 2019 Received: (at 35866) by debbugs.gnu.org; 31 May 2019 19:28:39 +0000 Received: from localhost ([127.0.0.1]:36267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWnCh-0000nb-7n for submit@debbugs.gnu.org; Fri, 31 May 2019 15:28:39 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:35149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWnCe-0000nH-MR for 35866@debbugs.gnu.org; Fri, 31 May 2019 15:28:38 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 04FBA1438; Fri, 31 May 2019 15:28:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 31 May 2019 15:28:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=mxoc4J/ODzj1iMJKykyFUuMaYV F7mxMz7JGq3INjxg8=; b=W5D8kVrHutGllmYQ/1L39OYpZqrd8+FkQSnOr2ovPb dH9cnekRCHY6KAsdiwWes//Lkcn4yWrrxPZo3IkVH54JC0h29hf3CIv5e+OtRJyi Y8GL9aAXuKpcPdpbPsKew97ShMEg1n68st/lbvD0WGRQJY7h7AgBT27W01vFJGKk RaxtbkzW59PKJJrztRU8YW9XDMZUDuQDghZAukFSfyX3M8FA+I37abiKhINjleID doVo8r2Gup/fynbRt0AcZn2iuGJ7tTJOsD1O6DckBtzCUP5aaljH5J8deRy0tMQR o/I4dxK2SZ6QiPkSeXy8Y2eyp4WXgfuERDQytOpzPsOQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=mxoc4J /ODzj1iMJKykyFUuMaYVF7mxMz7JGq3INjxg8=; b=BKOXRTUNYt34GkqnyIe6S2 qBoxxF8ZqdAaJVuwyT2LtsxFNzFiXU2IqzdLFxzXo+QwII8kRbLvPd+5CKJJrt7S HzFYH0YBSjKnG/pXggSXwJ6yBtEQRE3YiBC2Io2FBPAlSiU0GytKoJg5EWpCER39 xN8AMEFT4WD1lkY5jDGAfJbdTUg/AuqOhipJpa0Z1UI30XX0BWg4wMygB2snYQcp LA2H+nYvn7HahdTP78zkqdmmnNRk9asMiB8N7tGSQbmkD50oYvLeJK49S2oJLVqd /fcvTw4kZ0q8hpxI350lRqp8qBZD1A7cciN3mt/POeRDmEZcWk4jXmPknWdyF2gA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudefuddgudegtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffgffkfggtgesghdtreertdertdenucfhrhhomhepofgrrhhi uhhsuceurghkkhgvuceomhgsrghkkhgvsehfrghsthhmrghilhdrtghomheqnecuffhomh grihhnpehgihhtlhgrsgdrtghomhenucfkphepiedvrdduiedrvddviedrudegtdenucfr rghrrghmpehmrghilhhfrhhomhepmhgsrghkkhgvsehfrghsthhmrghilhdrtghomhenuc evlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (140.226.16.62.customer.cdi.no [62.16.226.140]) by mail.messagingengine.com (Postfix) with ESMTPA id A1FE98005A; Fri, 31 May 2019 15:28:29 -0400 (EDT) From: Marius Bakke To: Mike Rosset , 35866@debbugs.gnu.org Subject: Re: [bug#35866] [PATCH] gnu: qtwebengine: Do not use 3rd party libraries. In-Reply-To: <20190529233705.21127-2-mrosset@bufio.org> References: <20190529233705.21127-1-mrosset@bufio.org> <20190529233705.21127-2-mrosset@bufio.org> User-Agent: Notmuch/0.28.4 (https://notmuchmail.org) Emacs/26.2 (x86_64-pc-linux-gnu) Date: Fri, 31 May 2019 21:28:28 +0200 Message-ID: <8736kubezn.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 35866 Cc: mike.rosset@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Hi Mike, Mike Rosset writes: > Most in tree third party libraries are now linked to Guix libraries. There > are a few Guix libraries that break the build or are not automatically > detected these are now documented in the input expression. > > gnu: qtwebengine: PDF and printing support is now disabled. > > PDF and printing requires pepper plugins. which is not enabled. Thank you very much for this work. I have looked into QtWebEngine before and do think they are doing "the right thing" (apart from using Blink in the first place) wrt binaries and spyware. The patch LGTM overall, but I would like to see the unused "third_party" directories removed if possible. You might be able to reuse much of this snippet: Can you give it a try? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlzxgFwACgkQoqBt8qM6 VPqIaAgArfabwhPUehc9EecxM4XtxOtKzD68smI1r0SV30i2qxMel98XUvW7czKv iJzA5NFgkv1O3GxRmLcg1WswNAvN858Mfxjt1jkXQx09FkOtskTaKpKNJzztAThS n9tw5S9xfvq2mp6QJumyZQoo9gxpeUelGRyP2Wuc4AIY3ekAXKwOxDndtN4yC+yQ jknvRPzpxuEswc/Gig1lZTaP4L3de/g8vJwaKhTLBh0Bz/8ZQ2fuLAl3/NUIzBY2 KPDCFRA0haVBiPR8dstrIyTAaWw+uLkrDZ2Qt44+TmXE0iSSl9hXiUi7vc46E9BP i1AmLBYXSVYru03rLFslH1DPalm8JA== =C6Py -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 31 19:22:34 2019 Received: (at 35866) by debbugs.gnu.org; 31 May 2019 23:22:34 +0000 Received: from localhost ([127.0.0.1]:36591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWqr4-0003vn-9p for submit@debbugs.gnu.org; Fri, 31 May 2019 19:22:34 -0400 Received: from mout.perfora.net ([74.208.4.197]:55159) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWqr1-0003vR-AE for 35866@debbugs.gnu.org; Fri, 31 May 2019 19:22:33 -0400 Received: from orion ([70.68.94.152]) by mrelay.perfora.net (mreueus001 [74.208.5.2]) with ESMTPSA (Nemesis) id 0LhMBi-1gkGOu1NxI-00mcHE; Sat, 01 Jun 2019 01:16:56 +0200 From: mrosset@bufio.org To: Marius Bakke Subject: Re: [bug#35866] [PATCH] gnu: qtwebengine: Do not use 3rd party libraries. References: <20190529233705.21127-1-mrosset@bufio.org> <20190529233705.21127-2-mrosset@bufio.org> <8736kubezn.fsf@devup.no> Date: Fri, 31 May 2019 16:16:54 -0700 In-Reply-To: <8736kubezn.fsf@devup.no> (Marius Bakke's message of "Fri, 31 May 2019 21:28:28 +0200") Message-ID: <87sgsuusd5.fsf@bufio.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:fbOSfM+9vVMfFVl2pnErwLwDVGB6YyA08O8urXnP8GOrFfeJeEa xuNBsx2ls4TGIIP/FnP4ZqqbQanyrRaYOigBd9AU19VjFdV91RmIUHxIkjBrWR31oYUOZt9 3HbSvJCXGDueYcfS3RzRptddCL9prD0h1ZC5GYh2TXke+yIze4A/hNZ5NceLGoSwCfjmwvT SL68b1u+YfU6rsw/gC6mg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:O3DArg5tRDc=:JGDbDdRHYz2XFIKFrLToe5 pTElFOSOUf3LoYHCL9ACHzxcpD7MH/RrqC761Q2/S5wzboquIX49e+7TuUYsiKxaI5u1S25Eq cVtbc8H6FaszjVrxvZSVXHeaYqFpdiBPCRURTTRtZ0GRictAKhgTckci/FUHbrRjw1dxFCZGM aIdCIM6Mj/F1nxOT8FMWKyTSz4CBvF0SXx13c5jQk6etpoHcViE+kMkMnfkcKMZYiUYkHlMZd 8b7CaD5XvPg6KEhyPtNKmesbZJnSN1wLud1Uu/aFIt0TAnSRsaCiOP+/MlNK9hTeeKZagjGv6 4k1KT8n5Kcr1db+FIsepw0OMFlg62rKbDdrXSRuLxQUnNmOfnbwRacQkz6XcDF83K13gshZ4G lZ009KWnY35XSruMWXxUL4UDBBV5EVui+28c7jpnK8LHyfdoQmt7yefPPb98vjsTWfnZ2YXdc 5HnGQBDB4hRYQGrDV7mtsZMU6btBhDTj3BnASuMKy08FhSj6d8bEwsgh0YvPPxPyKPfm0wVcC yo5SBTmSu2nHr13JupgA1e8UeVxddT4iOqmsP8tpB2Q3DkaqgkiteV5Ujml79c3TkTaq1AF+d nr7tNplOkoiXHqcFg22YtNRa1fzFBuK9vg4BWSZqcLNL01vD0KtGZscMqGEKvZZqb/7YqznDY X8xSNWuQFpUp4eh1vTAXJXs/JSm9RnlcH8txouYKBy9TF8bhNcFj7uRrV0MwKu5Mt8f1q0mdm CHyj6jKmrJsjfIcP4gFFPvi+jPqizK3bJSWTiAgyQ879/jNLCIZf10CWFeE= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35866 Cc: mike.rosset@gmail.com, 35866@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Marius Bakke writes: > Thank you very much for this work. I have looked into QtWebEngine > before and do think they are doing "the right thing" (apart from using > Blink in the first place) wrt binaries and spyware. > > The patch LGTM overall, but I would like to see the unused "third_party" > directories removed if possible. You might be able to reuse much of > this snippet: > > > > Can you give it a try? This is a good idea, not sure why I had not thought to do this myself. I'll remove everything I can then update my patches series From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 01 05:46:23 2019 Received: (at 35866) by debbugs.gnu.org; 1 Jun 2019 09:46:23 +0000 Received: from localhost ([127.0.0.1]:37109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hX0al-0004rr-CI for submit@debbugs.gnu.org; Sat, 01 Jun 2019 05:46:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hX0aj-0004rd-Uf for 35866@debbugs.gnu.org; Sat, 01 Jun 2019 05:46:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36055) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hX0ae-0007EJ-Cy; Sat, 01 Jun 2019 05:46:16 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=54370 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hX0ad-0000Df-OI; Sat, 01 Jun 2019 05:46:16 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: mrosset@bufio.org Subject: Re: [bug#35866] [PATCH] gnu: Add qtwebengine. References: <20190523062344.20601-1-mrosset@bufio.org> <87zhn7pq0r.fsf@gnu.org> <87y32qii63.fsf@bufio.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 Prairial an 227 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 01 Jun 2019 11:46:13 +0200 In-Reply-To: <87y32qii63.fsf@bufio.org> (mrosset@bufio.org's message of "Tue, 28 May 2019 10:48:52 -0700") Message-ID: <877ea5k596.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35866 Cc: mike.rosset@gmail.com, 35866@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, mrosset@bufio.org skribis: > It seems to me that QT is already doing the right thing > here. Unfortunately I don't think it will be easy to reuse the > ungoogle-chrome code base. It would probably require manually re-basing > then applying qt patches. Also there is no clear benefit for it. Since > updating ungoogle-chromium would not directly benefit qtwebengine. In > short QT seems to already be doing the necessary work. I think this would require a careful analysis like the one Marius Bakke carried out when packaging =E2=80=98ungoogled-chromium=E2=80=99. It would be both nicer and easier if QtWebEngine could be tweaked to use our own =E2=80=98ungoogled-chromium=E2=80=99 directly instead of rebuilding= one, but yeah, that sounds tricky. > I can though now, do my best to ensure that the least amount of 3rd > party libraries are used. I'll update my patch as soon as possible. And > I will explore the chromium source issue more in the process. OK. Thank you! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 18 05:26:10 2019 Received: (at 35866) by debbugs.gnu.org; 18 Jul 2019 09:26:10 +0000 Received: from localhost ([127.0.0.1]:53438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho2fy-00053e-4y for submit@debbugs.gnu.org; Thu, 18 Jul 2019 05:26:10 -0400 Received: from a2062.mx.srv.dfn.de ([194.95.232.172]:60445) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho2fw-00053U-C6 for 35866@debbugs.gnu.org; Thu, 18 Jul 2019 05:26:09 -0400 Received: from localhost (localhost [127.0.0.1]) by a2062.mx.srv.dfn.de (Postfix) with ESMTP id 04693A0098; Thu, 18 Jul 2019 11:26:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mdc-berlin.de; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:date:date:subject:subject:from:from:user-agent :received:received:received; s=mdc; t=1563441965; x=1565256366; bh=vjnPMliCr8SXKRE/q2/hYclaQiMNxKj/SIG+6TM6GXY=; b=jH5LrqJYWKJl X1OSKLDj342toaJkibNPFC3HFP8dOcUnJ54S2ZTt6IAn3diwb7T+t7aaEvQaayPP pcvTh0pUw0kf+87rtxNTi4bJMhe8POaF4fMTWDrnogA024VY91HZ5XldRndWMV7i NkFEXi/yyrLIrqA7Ttrl7bMJTP2G0Zw= Received: from a2062.mx.srv.dfn.de ([127.0.0.1]) by localhost (mgw4-han.srv.dfn.de [127.0.0.1]) (amavisd-new, port 20134) with ESMTP id 44sSYegmkJLm; Thu, 18 Jul 2019 11:26:05 +0200 (CEST) Received: from SW-IT-P-CAS1.mdc-berlin.net (mgw10-1.mdc-berlin.de [141.80.113.53]) by a2062.mx.srv.dfn.de (Postfix) with ESMTPS; Thu, 18 Jul 2019 11:26:05 +0200 (CEST) Received: from localhost (141.80.247.250) by SW-IT-P-CAS1.mdc-berlin.net (141.80.113.53) with Microsoft SMTP Server (TLS) id 14.3.468.0; Thu, 18 Jul 2019 11:26:04 +0200 User-agent: mu4e 1.2.0; emacs 26.2 From: Ricardo Wurmus To: <35866@debbugs.gnu.org> Subject: [PATCH] gnu: Add qtwebengine. X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Thu, 18 Jul 2019 11:26:05 +0200 Message-ID: <87v9vzg0cy.fsf@mdc-berlin.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [141.80.247.250] X-TM-AS-Product-Ver: SMEX-12.5.0.1684-8.5.1010-24772.003 X-TM-AS-Result: No-4.690900-8.000000-10 X-TMASE-MatchedRID: jNbG/17KYGWeH1x0y0x/SqHs7urN7C7g57e8iWh64HdXPwnnY5XL5Gcc 1m8K3FDI0mzuRbTieYVxMefmM+JBkUjjCdrwCglg9FQh3flUIh4vnJ25kMIK25soi2XrUn/JxbG vmM9nj5NQSFbL1bvQAcK21zBg2Klfw38dXReMtXc2gykcDlW+E7PE5i5Uh+hT8yhzfETf/YxTZV 96ok2EhyQl5L8RGBkgZFqh3SvSrNirypw/80Nbru4vq25ojtYH2o5NNtWunWw= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--4.690900-8.000000 X-TMASE-Version: SMEX-12.5.0.1684-8.5.1010-24772.003 X-TM-SNTS-SMTP: 61946E28A4B338DD4AC8EC73D8B95D9A1B44FEB8DEBCFFBF1BAD31E8A32AD4DF2000:9 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35866 Cc: mrosset@bufio.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Mike, I=E2=80=99m curious about the current state of this patch. Have you been a= ble to take a look at whether we could use our ungoogled-chromium package here? I=E2=80=99m working on getting the latest R Studio into Guix (upgrading and moving it from the guix-bimsb channel) and since all versions since 1.2 depend on qtwebengine I have some motivation to see this patch make it into Guix at some point :) -- Ricardo From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 24 10:06:23 2019 Received: (at 35866) by debbugs.gnu.org; 24 Jul 2019 14:06:23 +0000 Received: from localhost ([127.0.0.1]:37823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqHuR-0006c1-0D for submit@debbugs.gnu.org; Wed, 24 Jul 2019 10:06:23 -0400 Received: from mx2.mailbox.org ([80.241.60.215]:37890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqHuN-0006bo-Ve for 35866@debbugs.gnu.org; Wed, 24 Jul 2019 10:06:20 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx2.mailbox.org (Postfix) with ESMTPS id 0F80DA0177 for <35866@debbugs.gnu.org>; Wed, 24 Jul 2019 16:06:13 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1563977173; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=Lm2nbaz+w2XfqFZAo3cKDk8n1P04MZmX7W5OzcBDspU=; b=oLg7fY2g2YHfW3sDC8mMA94Dicl9/qqbG0FuisaXNtoOlh3F9qKDQDFlpiHHPRVyj4kaU2 9NAhHRz5Gxxa86aXMD/G13mesLZv8xH+JKnXXU4rlcFrjTrkHcnBe8GM5e3565miMinTZK 1v4+3no1CSZhV3hw7SxazgIjrjacwdU9wixe92lNuFk1102oihfC1mSWjhux8fyY/bKeWW K1zc6vU0vmBMGORuzSaaW2eUCKLRaT3muA4Kubhe7FnFX+Pa3X4yXvHGxJL4Bv+z9yPjty +amIdLE3KUOM/1lKUpr4eK1mUpJMMLYFdYI/4AHh7vhCWRmoPKB5XkWDpDhtKg== Received: from smtp2.mailbox.org ([80.241.60.241]) by gerste.heinlein-support.de (gerste.heinlein-support.de [91.198.250.173]) (amavisd-new, port 10030) with ESMTP id BcTNa9pqGO9I for <35866@debbugs.gnu.org>; Wed, 24 Jul 2019 16:06:08 +0200 (CEST) To: 35866@debbugs.gnu.org From: Brendan Tildesley Subject: [PATCH] gnu: Add qtwebengine. Message-ID: <23703ef1-c21d-5b52-7848-fc3d2c6fc907@brendan.scot> Date: Thu, 25 Jul 2019 00:06:02 +1000 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-AU X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 35866 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) I was able to apply this patch and succeeded in building qtwebengine. I then tried to add  it as a dependency to python-pyqt and build it, but I get this error: sip/QtPrintSupport/qprinter.sip:28:22: fatal error: qprinter.h: No such file or directory It sounds like some simple search path error. Anyone know how that can be fixed? From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 06 11:46:11 2019 Received: (at 35866) by debbugs.gnu.org; 6 Oct 2019 15:46:11 +0000 Received: from localhost ([127.0.0.1]:46708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iH8jb-00058E-H6 for submit@debbugs.gnu.org; Sun, 06 Oct 2019 11:46:11 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:39305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iH8jS-00057X-Px for 35866@debbugs.gnu.org; Sun, 06 Oct 2019 11:46:05 -0400 X-Originating-IP: 92.169.151.76 Received: from bababa (lfbn-1-4156-76.w92-169.abo.wanadoo.fr [92.169.151.76]) (Authenticated sender: pierre@atlas.engineer) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id B92CA40003; Sun, 6 Oct 2019 15:45:59 +0000 (UTC) From: Pierre Neidhardt To: Ricardo Wurmus Subject: Re: [bug#35866] [PATCH] gnu: Add qtwebengine. References: <20190523062344.20601-1-mrosset@bufio.org> <87v9vzg0cy.fsf@mdc-berlin.de> Date: Sun, 06 Oct 2019 17:45:58 +0200 In-Reply-To: <87v9vzg0cy.fsf@mdc-berlin.de> (Ricardo Wurmus's message of "Thu, 18 Jul 2019 11:26:05 +0200") Message-ID: <87h84lg9mx.fsf@ambrevar.xyz> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 35866 Cc: Marius Bakke , mrosset@bufio.org, Ludovic =?utf-8?Q?Court=C3=A8s?= , mike.rosset@gmail.com, 35866@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable +1! :) As far as I can tell, in its current state the package will trigger the following error when we try to make a webengine view: =2D-8<---------------cut here---------------start------------->8--- 15:50:10 INFO: Run :adblock-update to get adblock lists. 15:50:10 CRITICAL: Could not find QtWebEngineProcess =2D-8<---------------cut here---------------end--------------->8--- Maybe something like this would help? =2D-8<---------------cut here---------------start------------->8--- (native-search-paths (list (search-path-specification (variable "QTWEBENGINEPROCESS_PATH") (files '("lib/qt5/libexec/QtWebEngineProcess"))))) =2D-8<---------------cut here---------------end--------------->8--- =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl2aDDYACgkQm9z0l6S7 zH/TuQf/e0PLLDoP7hD60S8s0vEkMrbEHhyvRcZut1YzFPvSfbPty+cob7zNqZkR Oz4qrrj5jmOkgNg1aywZ+KAPzzN6JTnZ0PAtE/vdK08i3w5cOxn6lxyTL+7So4Dc FVeNm7nlVcEGc9BlLr7sqThzsczK3DNQlJzsbys0RXrRoAK6z3zH63wAqKuGzYlE HZzX631P5ufU+jNlF2Eieot7hgm4tOGc7qcaBO/hzWcBWdK1m+2pOqX+F4MlPxzv dCypIsv4GvyV09A9tIecc5Adc5WHgEqmqVYt37LZbQ6/To89H586aTVsiod+b1d1 mDFuhiPvAX1zIf17scoLji7AsAkNPQ== =dht6 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 07 11:49:46 2019 Received: (at 35866) by debbugs.gnu.org; 7 Oct 2019 15:49:46 +0000 Received: from localhost ([127.0.0.1]:48921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHVGb-0001xB-Tg for submit@debbugs.gnu.org; Mon, 07 Oct 2019 11:49:46 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:33849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHVGZ-0001wv-Uh for 35866@debbugs.gnu.org; Mon, 07 Oct 2019 11:49:44 -0400 Received: by mail-pl1-f195.google.com with SMTP id k7so7077139pll.1 for <35866@debbugs.gnu.org>; Mon, 07 Oct 2019 08:49:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=DeaRtQvVjLGFalgANLBJLJLCTyEGT6G4/yGhQ9JXMZ8=; b=eeftnAMOTfDHS8rqSfjUaKLXSCbfrha2EjG1/CRVgpsKxffwXm2Qh1rfmA1EkUsFb5 HQp1HHl61+59T+PgixF8bRXyJm2Ylplbt4PkDHMX0t/5cu+GTtZXs4fZ3M5t4j8uj+Iq E/AfH5HmaKmPBAlhNT1BiGDogzXqAAzgoj8fus57uyFL/1EGIL1Tzs1gZkYBkHk7cPnm lJvPVv2Ri0jfBedvILkqpHlNpwJULYBZom6wQDY3DJF9T3n+hRvSrH/Zn9xJJmU+ptz4 caDxYrZRcVLNDXZa23chkJR8RfDIE9vQcAxSccioD9ZeAcJqgSgdgm60ptkw3632ahq3 pvPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=DeaRtQvVjLGFalgANLBJLJLCTyEGT6G4/yGhQ9JXMZ8=; b=sPK585ufc5ySVd6yQGISecshWbRJy7SElK6rMeCBhfUbiKNphlc5fqxX+KIWgmuEq0 Z0LqkV6LBrnZveeMm4AALSGRzmwcltMrQvyYAAG2YeHSamniDtDgBMxUEmkufpf06DCe NhL+AptaNcYNj84jqHkDe4jt6MfT9lX30bnbYyhXWebxiY9VaJxB3eHe97V2U5BO2CNj 2gIY6rVyodZyqOWVFHxcR1eI9oe4DvWsEKP1478nOyoKxa1dXk850nlUDq7GvZD9J4Ko bu4DBQc81aJ49i49OQbg7Ag4F9ox3EtPc9TvGYIWuI38LXCsTBBg54Sim1bLqZ4UIS9m r1LA== X-Gm-Message-State: APjAAAWpTj5hNR9lUb2DfjenmpxlOycodQ1bpg7BUrSTsE7Y5QoYDd6l lbgj1QRb+akKJSCLQzdng94= X-Google-Smtp-Source: APXvYqyTYErX2DKsO/DKvH13sMNGpZ17H/luriY+OUOwA8TmB1hUngfvyHSU8FuSjSToQ7I4Jm3FeA== X-Received: by 2002:a17:902:684a:: with SMTP id f10mr18815134pln.91.1570463377952; Mon, 07 Oct 2019 08:49:37 -0700 (PDT) Received: from neutron (node-1w7jr9qlfahmdec6251b8nced.ipv6.telus.net. [2001:569:74e0:7d00:6818:7fdd:4b33:285]) by smtp.gmail.com with ESMTPSA id 127sm16237946pfw.6.2019.10.07.08.49.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2019 08:49:36 -0700 (PDT) From: mike.rosset@gmail.com To: Pierre Neidhardt Subject: Re: [bug#35866] [PATCH] gnu: Add qtwebengine. References: <20190523062344.20601-1-mrosset@bufio.org> <87v9vzg0cy.fsf@mdc-berlin.de> <87h84lg9mx.fsf@ambrevar.xyz> Date: Mon, 07 Oct 2019 08:49:35 -0700 In-Reply-To: <87h84lg9mx.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Sun, 06 Oct 2019 17:45:58 +0200") Message-ID: <878spwblo0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35866 Cc: Marius Bakke , Ricardo Wurmus , Ludovic =?utf-8?Q?Court=C3=A8s?= , mrosset@bufio.org, 35866@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pierre Neidhardt writes: > Maybe something like this would help? > > (native-search-paths > (list (search-path-specification > (variable "QTWEBENGINEPROCESS_PATH") > (files '("lib/qt5/libexec/QtWebEngineProcess"))))) Right I think this is what I was going to propose for https://gitlab.com/nonguix/nonguix/blob/master/nongnu/packages/qt.scm#L58. Though you can temporarily get around this with this ugly hack. export QTWEBENGINEPROCESS_PATH="$(guix build qtwebengine)/lib/qt5/libexec/QtWebEngineProcess" I'll add the native-search-path to the nonguix package ASAP. Note. Once you get past this issues. You will then have problems with locales. Since the module QT packages assumes you are installing to the same prefix as qtbase. Which is not feasible with how guix packages things. For my experimental QT nomad I had some hacks to get around this, which are not feasible or ideal when creating a package that is a library and uses qtwebengine. I'm still not sure how to best resolve this issue. Maybe creating a package that is a union of qtbase and qtwebengine might help. Regards, Mike From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 16 10:30:08 2019 Received: (at 35866) by debbugs.gnu.org; 16 Dec 2019 15:30:08 +0000 Received: from localhost ([127.0.0.1]:40246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igsJz-0000ku-O1 for submit@debbugs.gnu.org; Mon, 16 Dec 2019 10:30:07 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:39040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igsJx-0000jn-CK for 35866@debbugs.gnu.org; Mon, 16 Dec 2019 10:30:06 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 47c4vv59Z5z1rVvj; Mon, 16 Dec 2019 16:30:03 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 47c4vv4knJz1qql0; Mon, 16 Dec 2019 16:30:03 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id pv9gfK3IcfTV; Mon, 16 Dec 2019 16:30:02 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-188-174-59-242.dynamic.mnet-online.de [188.174.59.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Mon, 16 Dec 2019 16:30:02 +0100 (CET) Received: from thisbe.goebel-consult.de (hermia.goebel-consult.de [192.168.110.7]) by hermia.goebel-consult.de (Postfix) with ESMTP id B9CB0600BD; Mon, 16 Dec 2019 16:31:06 +0100 (CET) To: 35866@debbugs.gnu.org Subject: Re: gnu: Add qtwebengine. From: Hartmut Goebel Autocrypt: addr=h.goebel@crazy-compilers.com; prefer-encrypt=mutual; keydata= mQINBFJQM3oBEACiUXmMppc3+A7JpF3lPz8O/mRhfz1U6F4EOTlacTrCcm7Xg5U2JsPPNapV r5+vHnKBK+xbaX3s/A/G+SwrUZhi1X1HRnSNY1CqL8CT7rZmOtfjg4ExnOuCjie2bKhb9JKm lJ7MrNimIbNQoX1mRcQ4VMEflhyWfaPGbT73siuMkbr020ExhzW8T18JIC01SgWMULYMBXOB oGY21am/vaTFCK8bym1P4HVN8i64uOWL0agkAMHbju6SZtG2fYJ68eS3P/97bXRg1pveEdpa FgaFZhquecw4WdedwLwt1xNcjAg/p6tN73W3asEZTgMHa+iNzbJgcyhWpci09wQZfZ1uL0Hd M+ohng38ccgu9hJx6YzCN7Fe14JooKbPukG/WfClAgAzZSHRKpS4zGdGlg6D6EWayyWWoLR3 KoMA4LIIlaQbqaOhfe85b4mNgB1hqd0uRTHOah/6T+FUoSQ1IAeKLIDqj6rW7X4ISRn1CXGS LGDn2QKqR3KtU3cLf8hAeDeO7Qe1jTvLrG1Mfca8lEmC7/yN1gI7L4/cs6lhmXUgMaevuxss BxO2kkh0OS8HVFf+QQ7LZ5vt91yQVT9HVvOuVob0YtG+3rvkpMaHQilKloNoEkmMiHpwypBa IfAC6NP9smgionvvmQ5RWSEaH5/pfSUAYbqzWbqDxtqEF/mPOwARAQABtC1IYXJ0bXV0IEdv ZWJlbCA8aC5nb2ViZWxAY3JhenktY29tcGlsZXJzLmNvbT6JAj0EEwEKACcCGwMCHgECF4AF CwkIBwMFFQoJCAsFFgIDAQAFAluyK5QFCQ0kXxEACgkQe3UoEb93O2XMlw//Z2/aXbZO3lJv uvfDBU3fJBKxp87EButnuwudFyaNupKxO13R7rBKB/Oti/rNP7IlK56WwU10ldK6C1PYnqru 5L1VCjWRi2Jd/XlvgXlc1jqstbM7NfU7pGOzctJGYpKh+7b1EdSM4V1KnDKcbKicLKC7zS+d HUdsch5w5XJj+pZRE4R0KEA/vEBB4ba+m+b59WqzaLin2pOqyo4Ff9o5uVgxlNrLIJQsg74T MTQP8khyDLfmyiN42VVkOBOIPMLA8ljEA1I7I4WwW3bT3mxOXHUExey/YsOdpqYX+kh7u/tj 7kbjKQbdCwdwUqSOPLmW9/9Wxyf2/xi+3lCvxzwPPElnK62yKlxLhVMt+Ah3J2QeLmrVGG5X PQzplrmQ6ptpEC9evrK3ALBJ+UGGxyyLp7sPb0SbDq70tZLRtbcE6QnpQA2IQIPTTy40lGVy 3a3iXiDM7hzbljWS0XSaEHoZ/WdgKLV+OzVZ9vrhP+7HrK7hEzdYqCvNfcW6bk2KrMN0RxBB OAbiRne8E0iTffh9uTyW7sAE0UDA9J3KtD3fpkld9cQrhwUVsjuPfbCqnhCk0B7ro1OR0DHB bgMVEylEsACnHEU4XWvo+U+0MgJtDQjzIy+XZfXDCs1VOy+murgcs0YIFqesyYOaaF1eP1S0 Yr18n/pfAPCFfg0rhMQUyoK5Ag0EUlAzegEQAL3lOz+uhHudEvovJVdExl+MTHLpYcajA0QL zDXe0jiAYdB+Jpvm7CAKani61/eo1SnHyRORELjxl/fL3ytjg3yRvVAM2I+xg7lIB4qXL5rR 5K8iF4px/jYV2CBIiwOKQ6gVEVk2hpl/tPqP3QdOKXdLu3sOM1Ygg3PN5fc+I7B6luchx6Bu 7NAR7nWKn6D1NdOI1UZL6Dr6Me/6hNVJBGvDF3Fm2x0CoIHujFksfOxZtwoZMXn13N18ZDyQ OMA89eHNQlFri9i5xG3laMAW2M0bozf+FwTBXomIWkT2Tkj3omW8ZIcfags2SpRkQl45pE65 nLKK36eRNoNbBovqKalMyhKstFTpIjjTZRMI5EZ87j7gYX/ghCss2LZz4X0WfvH6lYt8Yvjv I9Stl4ENvNukQZSZgIpaaAgZceXyuLaj+FY1cVXK3AoTh+lordfXr3TSBxlb1z7cNHqsI9vd RwsfC+Ng+yRrNGnNw008fgDq9fhaZus1krtPQzTyJzMw9xnLKuHhHFbkHDaW1Gb9dnECBF8a T0kjffgENEa5K6bfyAGGZ5zikBuK9EZdIQ0KgLP55hdnY7PigXazSsvYxVB62+B0kRYxjyM7 UAX55+QeD7pkPhBmRozeNYZzQxu9cyeD83e1Yf7ddnBkkLXVyTzKIutGh2R2BkcmkbBKTv27 ABEBAAGJAjwEGAEKACYCGwwWIQTUrYucFnt1fE8I6Hd7dSgRv3c7ZQUCW7IswAUJDSRgPgAK CRB7dSgRv3c7ZbFUD/97iHXgPYSZWyZ9r8pgpRuyoIK2TKmClUxck1a0WUkTMjzi0gW4kOIj 2wNOUnsRqioxOVXAg0R9ix1l6+LBC8+m/VFoR37BYQsC5WrzkmeaFChrBPs+YlND0V7TWNq0 elBvsNuApVxSOzaJuxCnH9WLe3s4fIveymScNAZOm31DHgmkDcb1/NXg97nohqSeW+k3eQbh borMRT3kMaXrPTI8qal9TsYf6KhfPi61fbnGW6bNJ0LnWQj2b7nb6nIR99cr0sNymqOsC6Gq 0yHhTceRl2/DRBe+QCxoiFKs1s6f7Af+U9r/JkHfdOLCRxjmAyl22zlhmBeNlGSvDbJqy5AE 7fKo1/mVQ2CNskF0BcOhrrntVf4A1gy3OlIXnCV//HH6w7qRBpw0inpD5c9Ny20aNdo8mS3y szcGZLczkdx8qzYEXBCO8zSDiRllrf6e8H5AaQdtHInxQ2Ywdqz/Ho81irbcPaHwI7P9/qvm zYnPZ3ULNlrI/+mq0oYkCB8oB9HW0C/YGZ/nIYY0vxDoy6n6EhEzntdAjF6Pav+QHB216fBs LMLs8X4+PXOc+MaAmQQTyTF9C8vfQk86E4eRmQErYw0aYVR7bUqyYfX8e2c5geqeSm6O+Brv 6LQtDbOJIcmJW1NS8XVmDG9JmkbtYqhnRDQMT+YFJircfDYmUvL4Ww== Organization: crazy-compilers.com Message-ID: <0af1d64d-09e4-1f00-b0c9-27376b7e1e06@crazy-compilers.com> Date: Mon, 16 Dec 2019 16:29:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 35866 Cc: Pierre Neidhardt , mike.rosset@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, has anybody tried this patch(es) recently? Some "search-path" issues have been fixed recently, so maybe some issues are gone now. I also wonder whether this could be based on qtsvg, too. I can not spot any differences in the build-system arguments compared to qtsvg. -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 16 11:02:27 2019 Received: (at 35866) by debbugs.gnu.org; 16 Dec 2019 16:02:28 +0000 Received: from localhost ([127.0.0.1]:40300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igspH-0003VT-O8 for submit@debbugs.gnu.org; Mon, 16 Dec 2019 11:02:27 -0500 Received: from mail-pl1-f177.google.com ([209.85.214.177]:44920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igspG-0003R9-NM for 35866@debbugs.gnu.org; Mon, 16 Dec 2019 11:02:27 -0500 Received: by mail-pl1-f177.google.com with SMTP id az3so4641235plb.11 for <35866@debbugs.gnu.org>; Mon, 16 Dec 2019 08:02:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=GQnKvXIslCdmrG3w7jf7vsMbJTy+hEgOom+QCe3vOj0=; b=aRmqpUavTlfOwGm2vw1rNX+Zc370orxaZBxDW3TikYMSSRZ19J5CE8QHgQNgb6JriZ hyc+2YzHlOKJ0Wx1flHrOTmM+Fz4bQUIfMVpnBg4Kkwoq3prcy/oRLjlXw+zIArL+CTX hvyHssnb6EZD85VEG81fYpPXRtgHSg6sHGWWFGyWzEwGDtyHhlREDltTrJVFO83ABrGR egcHESLvPGb6SKkbzevKrl56qyJSoFFkdtDoyHb+gLXxmM92A5OqjG7fIYL5GEbDJuoq HW3IHWH8pAPPzuxKHMEOQreoB2H8k013hZwFNvwKmbhckX7JGacqr6y2ZjAArZm7IJVQ QH4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=GQnKvXIslCdmrG3w7jf7vsMbJTy+hEgOom+QCe3vOj0=; b=RCecfVuc4hA3fK+QHcN9RIwPaGgukEp9tgt7m1HCLXhNTmMrOOxVIxxrlkOLT7rcQS EbBz/30fd0QKqlEa4dKiOO8gTqWXixiG5BIN8QNZV7Ke4Fsp+8ysG/iysNhVbmp33utd TCY++I2y355aUN0nWAgLr7ea+6wJfYYOcQKmjo+j0XT3aMgFaDgdYBZCsk/V8HGV9roj /AanCSp2x84wkzFDMN/wzMZ72kQWdUZLAjX6gj2uPdM1hEgWyFe533Per7gE2VdQEtZI fP5xMudpFAqNL5z2h+UDEnR9k4kRURkWMeedX+Iq7hhxfAMC84WWL8CbXOWDyr158uRP q3TQ== X-Gm-Message-State: APjAAAXVVVrkZD+a/xcuZm0gqftqgJRBmjhYyyPAF1eYiYyhiD0R3CoX /6clvRH8Dtqs7xltA3TiSrI= X-Google-Smtp-Source: APXvYqy7qrSd3qPSvnH6G9RUm5p2Lj4PJx5tE07p59xXyjdbygHvTl6go7cbV2w/Z+n70Nr3OXFWKQ== X-Received: by 2002:a17:902:9885:: with SMTP id s5mr16745157plp.217.1576512140824; Mon, 16 Dec 2019 08:02:20 -0800 (PST) Received: from neutron (node-1w7jr9qlfahmev9dakqkc7if6.ipv6.telus.net. [2001:569:74e0:7d00:c8c3:b228:84c0:5502]) by smtp.gmail.com with ESMTPSA id z130sm23794093pgz.6.2019.12.16.08.02.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2019 08:02:20 -0800 (PST) From: mike.rosset@gmail.com To: Hartmut Goebel Subject: Re: gnu: Add qtwebengine. References: <0af1d64d-09e4-1f00-b0c9-27376b7e1e06@crazy-compilers.com> Date: Mon, 16 Dec 2019 08:02:19 -0800 In-Reply-To: <0af1d64d-09e4-1f00-b0c9-27376b7e1e06@crazy-compilers.com> (Hartmut Goebel's message of "Mon, 16 Dec 2019 16:29:59 +0100") Message-ID: <87mubsp8c4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35866 Cc: Pierre Neidhardt , 35866@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hartmut Goebel writes: > Hi, > > has anybody tried this patch(es) recently? Some "search-path" issues > have been fixed recently, so maybe some issues are gone now. > > I also wonder whether this could be based on qtsvg, too. I can not spot > any differences in the build-system arguments compared to qtsvg. If I recall correctly I tried inheriting from qtsvg but there was significant divergence to warrant a custom qt.conf for the locale hacks. Why don't I resubmit this patch? I believe I have a more up to date local version. And based on our other threads a module qtwebengine is more ideal for guix then the monolithic ones. At least this way I can put a test case together that demonstrates the locale issues. Mike From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 16 13:01:45 2019 Received: (at 35866) by debbugs.gnu.org; 16 Dec 2019 18:01:45 +0000 Received: from localhost ([127.0.0.1]:40349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igugj-0006ql-DI for submit@debbugs.gnu.org; Mon, 16 Dec 2019 13:01:45 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:36937) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igugh-0006qd-0I for 35866@debbugs.gnu.org; Mon, 16 Dec 2019 13:01:43 -0500 X-Originating-IP: 92.169.151.76 Received: from mimimi (lfbn-idf2-1-1340-76.w92-169.abo.wanadoo.fr [92.169.151.76]) (Authenticated sender: mail@ambrevar.xyz) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id D51DE60008; Mon, 16 Dec 2019 18:01:40 +0000 (UTC) From: Pierre Neidhardt To: mike.rosset@gmail.com, Hartmut Goebel Subject: Re: gnu: Add qtwebengine. In-Reply-To: <87mubsp8c4.fsf@gmail.com> References: <0af1d64d-09e4-1f00-b0c9-27376b7e1e06@crazy-compilers.com> <87mubsp8c4.fsf@gmail.com> Date: Mon, 16 Dec 2019 19:01:39 +0100 Message-ID: <87d0cop2t8.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 35866 Cc: 35866@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Please do! I'll try to test it this week. Just for fun, to see how long it takes to build :) =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl33xoMACgkQm9z0l6S7 zH/qNwf+Kb6V8cNXS+4w3fbKsEF0xYG0ulMTndg8rLNdWgPPcA64OczvxkPnOwdp bb3iL0hnHVulIok/Eq+mqC0ewCM+J95/k+N6yPkUdufFYE8t5kjzbP7RvcPTbcxO ThSa5gZrQnwqakzsfUUJI010dcUWwYiZ3PBBjHC1FayOFIQeYqbo1ZklL6sU88Dl PyBZoVCXd7hClkRr6eDjs9vqVPvUqWgSHGBTgEeC1WXSS3OtwhTr88IJluQISDpn mIZV3yDOA1WKhvnzdWhMvfsN+Dnx0btz0LnaEb2qrh3gqLsfJRzr76A9/bGHmFzo lhIyMNOw8ccFEya35PK/88JH+E3Xig== =EhU+ -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 18 15:32:50 2019 Received: (at 35866) by debbugs.gnu.org; 18 Dec 2019 20:32:50 +0000 Received: from localhost ([127.0.0.1]:43986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihg01-0001ep-Il for submit@debbugs.gnu.org; Wed, 18 Dec 2019 15:32:50 -0500 Received: from mout.perfora.net ([74.208.4.197]:60841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihfzz-0001eb-S7 for 35866@debbugs.gnu.org; Wed, 18 Dec 2019 15:32:48 -0500 Received: from neutron.telus ([50.98.116.177]) by mrelay.perfora.net (mreueus001 [74.208.5.2]) with ESMTPSA (Nemesis) id 0Lwpjy-1hbSDJ0JZo-016SaM; Wed, 18 Dec 2019 21:32:41 +0100 From: Mike Rosset To: 35866@debbugs.gnu.org Subject: [PATCH] gnu: Add qtwebengine. Date: Wed, 18 Dec 2019 12:32:23 -0800 Message-Id: <20191218203223.22861-1-mike.rosset@gmail.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:xqWoY1HEcnT7zjHTkLkjO7XXLMWZSTRjbiDnjChzfEcC+1pU05q jlpmgOE4xAUar7KkEj7cs06lh75YB6TOZD5q/HgQsMGwhcFm/zk9MloWE4V/cMwih+EEQxU JC2rtk/4tlcs15W5ka+lQmd7s89u8kjVPMiDXOOokcwJGJfCQ0oAKMqOsjkE8Yk5xN1PNye nXDFG4gjOmKKjmRzAmckg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:bZYuEUBmZcY=:ybOv6PQNSQDa9l1/Zm8/Ap TzT0Ofhw3tmQfLTmM51u6abppUzrgWfgC/iLHPHe4KpyG+N66TCdelltqhLWG9PJo6d9kNL/n YRjYky9zDSqfP7WpvgiVmI5e4S5pOrZylj6eHa5AjEM86ppwUZli+lsVqx97p7rY9KDb36/qh fFQ6qNAjBUWljpD3XGrBc+H9o9fraRO4zGtfUTyTud6VdJtCf6wlj07SUfnMGzBtKe5ikP1K9 903gBa19AselzAqQRERM/y+ekMZMnVIA2WEwlxMcznQdGVe3FF15tHHeo516n0+60VZlH6QO0 Qq7ipcHhK/mvA5TWOxGUriK8zOkd5rM14FuBQvDGkWPfw47woYQl8PotgE+vfNweObAd26ovR zsEY2iCMgc96PwlUiLll0MOyYAVk9tCZ/vrwGDnnUg99GuLMPA9RjEo2JNgweknKDSYwm5Kx/ L0n/SIZbcueKgFTeWZLxAeIfc1mSnKBoeY8knzejWO+wHpaNfoFLkfk8n2LLETk7VvVn5kWMr zVToh8HG9UPAQgDJAp1t3gzYq/HuoRsRnSVrjtZlIInDNRQ+yZoYCpJ0ZIaFpRVpGWa3j8/si mduCAuJASSXcNv6ukM/mLzGirTGarQ9Jiyp2zRsgw4uruSWumM4RQCQ1Y8oMJZO5CmX5XcTZ/ 9kKUaJrGWHwMAfKaYi9iEpad76tpoiV0LWPaOQqgBxV/Z0caVQQI1C6eegxiOSMFM6HKlbqDz 30saRcF1Tb5O3I7zV0RA9HJkyuENHQiuZjpU0vjy/siogyXpSlVTIXj4b62gM5JtAEWjkN4Iy NqNDQFhfWU9xfmtRsmG1gJJJfhbPHwdz2Fie/hpSU8W9WLo08ev7U1b5Pfgjze6gRvbftOR7v drNiTg6CLTwgaZ1emW9JSATXU9ooZQZJHzrHir7V8= X-Spam-Score: 4.5 (++++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/qt.scm (qtwebengine): New variable. This is a new qtwebengine patch with working locales. qtwebengine now inherits qtsvg Content analysis details: (4.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: nss_util.cc] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (mike.rosset[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received' headers 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [74.208.4.197 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [74.208.4.197 listed in list.dnswl.org] 0.5 URI_NOVOWEL URI: URI hostname has long non-vowel sequence 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: 35866 Cc: mike.rosset@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/qt.scm (qtwebengine): New variable. This is a new qtwebengine patch with working locales. qtwebengine now inherits qtsvg Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: udev1_loader.cc] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [74.208.4.197 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [74.208.4.197 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (mike.rosset[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received' headers 0.5 URI_NOVOWEL URI: URI hostname has long non-vowel sequence -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders * gnu/packages/qt.scm (qtwebengine): New variable. This is a new qtwebengine patch with working locales. qtwebengine now inherits qtsvg This also uses substitute-keyword-arguments to only replace configure phase. --- gnu/packages/qt.scm | 129 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 129 insertions(+) diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index c0d652a407..12028fd64c 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -52,30 +52,40 @@ #:use-module (gnu packages flex) #:use-module (gnu packages freedesktop) #:use-module (gnu packages gcc) + #:use-module (gnu packages ghostscript) #:use-module (gnu packages gl) #:use-module (gnu packages glib) + #:use-module (gnu packages gnupg) #:use-module (gnu packages gperf) #:use-module (gnu packages gstreamer) #:use-module (gnu packages gtk) #:use-module (gnu packages icu4c) #:use-module (gnu packages image) + #:use-module (gnu packages libevent) #:use-module (gnu packages linux) #:use-module (gnu packages llvm) #:use-module (gnu packages maths) + #:use-module (gnu packages ninja) #:use-module (gnu packages nss) #:use-module (gnu packages pciutils) #:use-module (gnu packages pcre) #:use-module (gnu packages perl) #:use-module (gnu packages pkg-config) #:use-module (gnu packages pulseaudio) + #:use-module (gnu packages protobuf) #:use-module (gnu packages python) #:use-module (gnu packages python-xyz) + #:use-module (gnu packages regex) #:use-module (gnu packages ruby) #:use-module (gnu packages sdl) + #:use-module (gnu packages serialization) #:use-module (gnu packages sqlite) + #:use-module (gnu packages telephony) #:use-module (gnu packages tls) + #:use-module (gnu packages video) #:use-module (gnu packages vulkan) #:use-module (gnu packages xdisorg) + #:use-module (gnu packages xiph) #:use-module (gnu packages xorg) #:use-module (gnu packages xml) #:use-module (srfi srfi-1)) @@ -2020,6 +2030,125 @@ time Web content can be enhanced with native controls.") (license license:lgpl2.1+))) +(define-public qtwebengine + (package (inherit qtsvg) + (name "qtwebengine") + (version (package-version qtbase)) + (source + (origin + (method url-fetch) + (uri + (string-append "https://download.qt.io/official_releases/qt/" + (substring version 0 4) + "/" version "/submodules/" + (string-append name "-everywhere-src-" version) + ".tar.xz")) + (sha256 + (base32 + "08c60nh95m98mcqk444axs76xi6m9x0wvdxrzk9c2cxwqdbz59fa")))) + (build-system gnu-build-system) + (native-inputs + `(("bison" ,bison) + ("flex" ,flex) + ("gperf" ,gperf) + ("ninja" ,ninja) + ("perl" ,perl) + ("pkg-config" ,pkg-config) + ("python-2" ,python-2) + ("ruby" ,ruby) + )) + (inputs + `(("alsa-lib" ,alsa-lib) + ("atk" ,atk) + ("cups-minimal" ,cups-minimal) + ("dbus" ,dbus) + ("ffmpeg" ,ffmpeg) + ("fontconfig" ,fontconfig) + ("harbuzz" ,harfbuzz) + ("icu4c" ,icu4c) + ("jsoncpp" ,jsoncpp) + ("lcms" ,lcms) + ("libcap" ,libcap) + ("libevent" ,libevent) + ("libgcrypt" ,libgcrypt) + ("libjpeg" ,libjpeg-turbo) + ;; libsrtp not found by qmake. seems to not have config.tests? + ("libsrtp" ,libsrtp) + ;; FIXME: error: ?struct vpx_svc_ref_frame_config? has no member named ?frame_flags? + ;; ("libvpx" ,libvpx) + ("libwebp" ,libwebp) + ("libx11" ,libx11) + ("libxcb" ,libxcb) + ("libxcomposite" ,libxcomposite) + ("libxcursor" ,libxcursor) + ("libxi" ,libxi) + ("libxkbcommon" ,libxkbcommon) + ;; libxml not found due to icu not enabled in libxml? + ("libxml2" ,libxml2) + ("libxrandr" ,libxrandr) + ("libxrender" ,libxrender) + ("libxslt" ,libxslt) + ("libxtst" ,libxtst) + ("mesa" ,mesa) + ("minizip" ,minizip) + ("nss" ,nss) + ("opus" ,opus) + ("pciutils" ,pciutils) + ("protobuf" ,protobuf) + ;; ("pulseaudio" ,pulseaudio) + ("qtbase" ,qtbase) + ("qtdeclarative" ,qtdeclarative) + ("qtmultimedia" ,qtmultimedia) + ("qtwebchannel" ,qtwebchannel) + ("re2" ,re2) + ("snappy" ,snappy) + ("udev" ,eudev) + ("xcb-util" ,xcb-util))) + (arguments + (substitute-keyword-arguments (package-arguments qtsvg) + ((#:phases phases) + `(modify-phases ,phases + (replace 'configure + (lambda* (#:key inputs outputs #:allow-other-keys) + ;; Avoids potential race conditions + (setenv "PYTHONDONTWRITEBYTECODE" "1") + ;; Make build output less verbose + (setenv "NINJAFLAGS" "-k1") + ;; Use this output translations not qtbase + (substitute* "src/core/web_engine_library_info.cpp" + (("QLibraryInfo::location\\(QLibraryInfo::TranslationsPath\\)") + (format #f "QLatin1String(\"~a\")" (string-append (assoc-ref outputs "out") "/share/qt5/translations"))) + (("QLibraryInfo::location\\(QLibraryInfo::DataPath\\)") + (format #f "QLatin1String(\"~a\")" (string-append (assoc-ref outputs "out") "/share/qt5")))) + ;; Substitute full dynamic path for nss + (substitute* "src/3rdparty/chromium/crypto/nss_util.cc" + (("libnssckbi.so") + (string-append (assoc-ref inputs "nss") "/lib/nss/libnssckbi.so"))) + ;; Substitute full dynamic path for udev + (substitute* "src/3rdparty/chromium/device/udev_linux/udev1_loader.cc" + (("libudev.so.1") + (string-append (assoc-ref inputs "udev") "/lib/libudev.so.1"))) + ;; Valid QT_BUILD_PARTS variables are: + ;; libs tools tests examples demos docs translations + (invoke "qmake" "QT_BUILD_PARTS = libs tools" "--" + "--webengine-printing-and-pdf=no" + "--webengine-ffmpeg=system" + "--webengine-icu=system" + "--webengine-pepper-plugins=no"))))) + ((#:tests? _ #f) #f))) + (native-search-paths + (list (search-path-specification + (file-type 'regular) + (separator #f) + (variable "QTWEBENGINEPROCESS_PATH") + (files '("lib/qt5/libexec/QtWebEngineProcess"))))) + (home-page "https://www.qt.io") + (synopsis "Qt WebEngine Module") + (description "Qt5WebEngine provides support for web +applications using the Chromium browser project.") + (license + (package-license qt)))) + (define-public dotherside (package (name "dotherside") -- 2.24.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 18 15:46:05 2019 Received: (at 35866) by debbugs.gnu.org; 18 Dec 2019 20:46:05 +0000 Received: from localhost ([127.0.0.1]:43998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihgCq-00022u-MD for submit@debbugs.gnu.org; Wed, 18 Dec 2019 15:46:05 -0500 Received: from mail-pl1-f172.google.com ([209.85.214.172]:37639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihgCn-00022B-V9 for 35866@debbugs.gnu.org; Wed, 18 Dec 2019 15:46:03 -0500 Received: by mail-pl1-f172.google.com with SMTP id c23so1511821plz.4 for <35866@debbugs.gnu.org>; Wed, 18 Dec 2019 12:46:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3RdJ9GvR/6sgnmrKySiRH2iiRpGak2Pwrutlb7IqLdw=; b=hg7iz9lbZBIjUhle9sLyAK/wtrJFzEyKH3BBbJiXn+0JsQPnyWxhnUgQegflsxIsQJ Az2IWTvO8ncmsTTCk7YGicpu4uAjD7OgK4TTDN1GDokicSYXPNKvutthK1FLGPamU/zk 85Iq/bZDcJGXhP6g1WLiwOeKDNgRnFZoB5GcsCqe6WSkKr+PGIeO2ibd5YNtIunO/Dxi O6ke5MM0otM02v5HLjFTbg9V4ZcmHlLWjmh0nqC1ZP64+pArz2UH996zL9tYaB9VPvlk 1j8hEsgvtVv4pvkMVt+2vCmLrzG41lReLOGQuMvbxe/orBQZngUtENS/Xl7NPjMKEuNp 1VLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3RdJ9GvR/6sgnmrKySiRH2iiRpGak2Pwrutlb7IqLdw=; b=UUpDiNEzwfz/NzEEotKtZzJCOaQbt9LIkUEqSz0ElOuOVvZ4QPNYiotir8taQ6zdSR KHPBfco0nAh6ieQ702d3VI9nCmFyEn6HYET3LbTOfjHQS9nBrrXgCcWpjP2KrtQ4UA5B +dsuu8RHKWJQojZkURNvk2j60dKh/zgkS1y3YWZWqojAuSm5q1RjnbXrIS3AXWeYUFWZ EY86u8uyDMWQJknk4uOQaTf4NKELlYM2riQE+9MjCFABuOA2MyQRLBPsm+Ztot8Ki98r oiBNnjpErD1rGgLGImIbHEEsnqxbvQiixq3QniXfSKJsuTpdpxQEkItlNWudy2V5jr8u lGLw== X-Gm-Message-State: APjAAAW3R3aaTVTU0PH2Hkz9lkS4h2yJkvP3Rx/V6mX/QI8m50clAbOe QwkUj5bPaT2QvWOM4hS3QVZhQLrg X-Google-Smtp-Source: APXvYqzenQ/h0ecDjNcdldhnl5l1DT3QBPk4ri2dWP9kLFWa7oC8kLFyVa7+1ymQRzP6njMrYQiVGA== X-Received: by 2002:a17:902:a516:: with SMTP id s22mr4990976plq.89.1576701955620; Wed, 18 Dec 2019 12:45:55 -0800 (PST) Received: from neutron.telus (node-1w7jr9qlfahmev9dakqkc7if6.ipv6.telus.net. [2001:569:74e0:7d00:c8c3:b228:84c0:5502]) by smtp.gmail.com with ESMTPSA id c68sm4591479pfc.156.2019.12.18.12.45.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2019 12:45:55 -0800 (PST) From: Mike Rosset To: 35866@debbugs.gnu.org Subject: [PATCH] gnu: Add qtwebengine. Date: Wed, 18 Dec 2019 12:45:37 -0800 Message-Id: <20191218204537.24069-1-mike.rosset@gmail.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 35866 Cc: mike.rosset@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) * gnu/packages/qt.scm (qtwebengine): New variable. This is a new qtwebengine patch with working locales. qtwebengine now inherits qtsvg This also uses substitute-keyword-arguments to only replace configure phase. --- gnu/packages/qt.scm | 129 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 129 insertions(+) diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index c0d652a407..12028fd64c 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -52,30 +52,40 @@ #:use-module (gnu packages flex) #:use-module (gnu packages freedesktop) #:use-module (gnu packages gcc) + #:use-module (gnu packages ghostscript) #:use-module (gnu packages gl) #:use-module (gnu packages glib) + #:use-module (gnu packages gnupg) #:use-module (gnu packages gperf) #:use-module (gnu packages gstreamer) #:use-module (gnu packages gtk) #:use-module (gnu packages icu4c) #:use-module (gnu packages image) + #:use-module (gnu packages libevent) #:use-module (gnu packages linux) #:use-module (gnu packages llvm) #:use-module (gnu packages maths) + #:use-module (gnu packages ninja) #:use-module (gnu packages nss) #:use-module (gnu packages pciutils) #:use-module (gnu packages pcre) #:use-module (gnu packages perl) #:use-module (gnu packages pkg-config) #:use-module (gnu packages pulseaudio) + #:use-module (gnu packages protobuf) #:use-module (gnu packages python) #:use-module (gnu packages python-xyz) + #:use-module (gnu packages regex) #:use-module (gnu packages ruby) #:use-module (gnu packages sdl) + #:use-module (gnu packages serialization) #:use-module (gnu packages sqlite) + #:use-module (gnu packages telephony) #:use-module (gnu packages tls) + #:use-module (gnu packages video) #:use-module (gnu packages vulkan) #:use-module (gnu packages xdisorg) + #:use-module (gnu packages xiph) #:use-module (gnu packages xorg) #:use-module (gnu packages xml) #:use-module (srfi srfi-1)) @@ -2020,6 +2030,125 @@ time Web content can be enhanced with native controls.") (license license:lgpl2.1+))) +(define-public qtwebengine + (package (inherit qtsvg) + (name "qtwebengine") + (version (package-version qtbase)) + (source + (origin + (method url-fetch) + (uri + (string-append "https://download.qt.io/official_releases/qt/" + (substring version 0 4) + "/" version "/submodules/" + (string-append name "-everywhere-src-" version) + ".tar.xz")) + (sha256 + (base32 + "08c60nh95m98mcqk444axs76xi6m9x0wvdxrzk9c2cxwqdbz59fa")))) + (build-system gnu-build-system) + (native-inputs + `(("bison" ,bison) + ("flex" ,flex) + ("gperf" ,gperf) + ("ninja" ,ninja) + ("perl" ,perl) + ("pkg-config" ,pkg-config) + ("python-2" ,python-2) + ("ruby" ,ruby) + )) + (inputs + `(("alsa-lib" ,alsa-lib) + ("atk" ,atk) + ("cups-minimal" ,cups-minimal) + ("dbus" ,dbus) + ("ffmpeg" ,ffmpeg) + ("fontconfig" ,fontconfig) + ("harbuzz" ,harfbuzz) + ("icu4c" ,icu4c) + ("jsoncpp" ,jsoncpp) + ("lcms" ,lcms) + ("libcap" ,libcap) + ("libevent" ,libevent) + ("libgcrypt" ,libgcrypt) + ("libjpeg" ,libjpeg-turbo) + ;; libsrtp not found by qmake. seems to not have config.tests? + ("libsrtp" ,libsrtp) + ;; FIXME: error: ?struct vpx_svc_ref_frame_config? has no member named ?frame_flags? + ;; ("libvpx" ,libvpx) + ("libwebp" ,libwebp) + ("libx11" ,libx11) + ("libxcb" ,libxcb) + ("libxcomposite" ,libxcomposite) + ("libxcursor" ,libxcursor) + ("libxi" ,libxi) + ("libxkbcommon" ,libxkbcommon) + ;; libxml not found due to icu not enabled in libxml? + ("libxml2" ,libxml2) + ("libxrandr" ,libxrandr) + ("libxrender" ,libxrender) + ("libxslt" ,libxslt) + ("libxtst" ,libxtst) + ("mesa" ,mesa) + ("minizip" ,minizip) + ("nss" ,nss) + ("opus" ,opus) + ("pciutils" ,pciutils) + ("protobuf" ,protobuf) + ;; ("pulseaudio" ,pulseaudio) + ("qtbase" ,qtbase) + ("qtdeclarative" ,qtdeclarative) + ("qtmultimedia" ,qtmultimedia) + ("qtwebchannel" ,qtwebchannel) + ("re2" ,re2) + ("snappy" ,snappy) + ("udev" ,eudev) + ("xcb-util" ,xcb-util))) + (arguments + (substitute-keyword-arguments (package-arguments qtsvg) + ((#:phases phases) + `(modify-phases ,phases + (replace 'configure + (lambda* (#:key inputs outputs #:allow-other-keys) + ;; Avoids potential race conditions + (setenv "PYTHONDONTWRITEBYTECODE" "1") + ;; Make build output less verbose + (setenv "NINJAFLAGS" "-k1") + ;; Use this output translations not qtbase + (substitute* "src/core/web_engine_library_info.cpp" + (("QLibraryInfo::location\\(QLibraryInfo::TranslationsPath\\)") + (format #f "QLatin1String(\"~a\")" (string-append (assoc-ref outputs "out") "/share/qt5/translations"))) + (("QLibraryInfo::location\\(QLibraryInfo::DataPath\\)") + (format #f "QLatin1String(\"~a\")" (string-append (assoc-ref outputs "out") "/share/qt5")))) + ;; Substitute full dynamic path for nss + (substitute* "src/3rdparty/chromium/crypto/nss_util.cc" + (("libnssckbi.so") + (string-append (assoc-ref inputs "nss") "/lib/nss/libnssckbi.so"))) + ;; Substitute full dynamic path for udev + (substitute* "src/3rdparty/chromium/device/udev_linux/udev1_loader.cc" + (("libudev.so.1") + (string-append (assoc-ref inputs "udev") "/lib/libudev.so.1"))) + ;; Valid QT_BUILD_PARTS variables are: + ;; libs tools tests examples demos docs translations + (invoke "qmake" "QT_BUILD_PARTS = libs tools" "--" + "--webengine-printing-and-pdf=no" + "--webengine-ffmpeg=system" + "--webengine-icu=system" + "--webengine-pepper-plugins=no"))))) + ((#:tests? _ #f) #f))) + (native-search-paths + (list (search-path-specification + (file-type 'regular) + (separator #f) + (variable "QTWEBENGINEPROCESS_PATH") + (files '("lib/qt5/libexec/QtWebEngineProcess"))))) + (home-page "https://www.qt.io") + (synopsis "Qt WebEngine Module") + (description "Qt5WebEngine provides support for web +applications using the Chromium browser project.") + (license + (package-license qt)))) + (define-public dotherside (package (name "dotherside") -- 2.24.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 19 13:29:47 2019 Received: (at 35866) by debbugs.gnu.org; 19 Dec 2019 18:29:47 +0000 Received: from localhost ([127.0.0.1]:45499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ii0YS-0008WU-44 for submit@debbugs.gnu.org; Thu, 19 Dec 2019 13:29:47 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:60015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ii0YQ-0008WK-QG for 35866@debbugs.gnu.org; Thu, 19 Dec 2019 13:29:43 -0500 X-Originating-IP: 92.169.151.76 Received: from bababa (lfbn-idf2-1-1340-76.w92-169.abo.wanadoo.fr [92.169.151.76]) (Authenticated sender: mail@ambrevar.xyz) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id C109040006; Thu, 19 Dec 2019 18:29:40 +0000 (UTC) From: Pierre Neidhardt To: Mike Rosset Subject: Re: [bug#35866] [PATCH] gnu: Add qtwebengine. References: <20190523062344.20601-1-mrosset@bufio.org> <20191218203223.22861-1-mike.rosset@gmail.com> Date: Thu, 19 Dec 2019 19:29:40 +0100 In-Reply-To: <20191218203223.22861-1-mike.rosset@gmail.com> (Mike Rosset's message of "Wed, 18 Dec 2019 12:32:23 -0800") Message-ID: <877e2sf9t7.fsf@ambrevar.xyz> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 35866 Cc: 35866@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Looking good! Comments below: > qtwebengine now inherits qtsvg > > This also uses substitute-keyword-arguments to only replace configure pha= se. I think those 2 lines can be omitted or maybe rephrased. We didn't have qtwebengine before, so you'd need to explain what's up with qtsvg, why it was problematic to use it. > +(define-public qtwebengine > + (package (inherit qtsvg) > + (name "qtwebengine") > + (version (package-version qtbase)) > + (source > + (origin > + (method url-fetch) > + (uri > + (string-append "https://download.qt.io/official_releases/qt/" > + (substring version 0 4) Use (version-major+minor ...) or similar. > + "/" version "/submodules/" > + (string-append name "-everywhere-src-" version) > + ".tar.xz")) > + (sha256 > + (base32 > + "08c60nh95m98mcqk444axs76xi6m9x0wvdxrzk9c2cxwqdbz59fa")))) > + (build-system gnu-build-system) > + (native-inputs > + `(("bison" ,bison) > + ("flex" ,flex) > + ("gperf" ,gperf) > + ("ninja" ,ninja) > + ("perl" ,perl) > + ("pkg-config" ,pkg-config) > + ("python-2" ,python-2) > + ("ruby" ,ruby) > + )) Dangling parentheses. > + (inputs > + `(("alsa-lib" ,alsa-lib) > + ("atk" ,atk) > + ("cups-minimal" ,cups-minimal) > + ("dbus" ,dbus) > + ("ffmpeg" ,ffmpeg) > + ("fontconfig" ,fontconfig) > + ("harbuzz" ,harfbuzz) > + ("icu4c" ,icu4c) > + ("jsoncpp" ,jsoncpp) > + ("lcms" ,lcms) > + ("libcap" ,libcap) > + ("libevent" ,libevent) > + ("libgcrypt" ,libgcrypt) > + ("libjpeg" ,libjpeg-turbo) > + ;; libsrtp not found by qmake. seems to not have config.tests? > + ("libsrtp" ,libsrtp) What does it entail? Is libsrtp ignored then? If there is a problem, please add a "FIXME:" comment or similar. > + ;; FIXME: error: ?struct vpx_svc_ref_frame_config? has no member = named ?frame_flags? > + ;; ("libvpx" ,libvpx) > + ("libwebp" ,libwebp) > + ("libx11" ,libx11) > + ("libxcb" ,libxcb) > + ("libxcomposite" ,libxcomposite) > + ("libxcursor" ,libxcursor) > + ("libxi" ,libxi) > + ("libxkbcommon" ,libxkbcommon) > + ;; libxml not found due to icu not enabled in libxml? You mean libxml2? Is it ignored then? Same as above, prefix with a FIXME if needed. > + ("libxml2" ,libxml2) > + ("libxrandr" ,libxrandr) > + ("libxrender" ,libxrender) > + ("libxslt" ,libxslt) > + ("libxtst" ,libxtst) > + ("mesa" ,mesa) > + ("minizip" ,minizip) > + ("nss" ,nss) > + ("opus" ,opus) > + ("pciutils" ,pciutils) > + ("protobuf" ,protobuf) > + ;; ("pulseaudio" ,pulseaudio) Please explain why you left pulseaudio commented out. > + ("qtbase" ,qtbase) > + ("qtdeclarative" ,qtdeclarative) > + ("qtmultimedia" ,qtmultimedia) > + ("qtwebchannel" ,qtwebchannel) > + ("re2" ,re2) > + ("snappy" ,snappy) > + ("udev" ,eudev) > + ("xcb-util" ,xcb-util))) > + (arguments > + (substitute-keyword-arguments (package-arguments qtsvg) > + ((#:phases phases) > + `(modify-phases ,phases > + (replace 'configure > + (lambda* (#:key inputs outputs #:allow-other-keys) > + ;; Avoids potential race conditions > + (setenv "PYTHONDONTWRITEBYTECODE" "1") > + ;; Make build output less verbose > + (setenv "NINJAFLAGS" "-k1") > + ;; Use this output translations not qtbase This comment is not very clear, maybe it could be rephrased, e.g. "Replace the qtbase translations with those from qtwebengine. > + (substitute* "src/core/web_engine_library_info.cpp" > + (("QLibraryInfo::location\\(QLibraryInfo::TranslationsP= ath\\)") > + (format #f "QLatin1String(\"~a\")" (string-append (ass= oc-ref outputs "out") "/share/qt5/translations"))) > + (("QLibraryInfo::location\\(QLibraryInfo::DataPath\\)") > + (format #f "QLatin1String(\"~a\")" (string-append (ass= oc-ref outputs "out") "/share/qt5")))) > + ;; Substitute full dynamic path for nss > + (substitute* "src/3rdparty/chromium/crypto/nss_util.cc" > + (("libnssckbi.so") > + (string-append (assoc-ref inputs "nss") "/lib/nss/libn= ssckbi.so"))) > + ;; Substitute full dynamic path for udev > + (substitute* "src/3rdparty/chromium/device/udev_linux/ude= v1_loader.cc" > + (("libudev.so.1") > + (string-append (assoc-ref inputs "udev") "/lib/libudev= .so.1"))) > + ;; Valid QT_BUILD_PARTS variables are: > + ;; libs tools tests examples demos docs translations > + (invoke "qmake" "QT_BUILD_PARTS =3D libs tools" "--" > + "--webengine-printing-and-pdf=3Dno" > + "--webengine-ffmpeg=3Dsystem" > + "--webengine-icu=3Dsystem" > + "--webengine-pepper-plugins=3Dno"))))) > + ((#:tests? _ #f) #f))) No tests? > + (native-search-paths > + (list (search-path-specification > + (file-type 'regular) > + (separator #f) > + (variable "QTWEBENGINEPROCESS_PATH") > + (files '("lib/qt5/libexec/QtWebEngineProcess"))))) > + (home-page "https://www.qt.io") > + (synopsis "Qt WebEngine Module") Probably no capital for "module." Great work, thanks again! =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl37wZQACgkQm9z0l6S7 zH8bdgf+KhuwlDhMjSFEkt8ica7JS7Bb3i+VPFpqcjtNcnGeQFLzG2AoVO6TuhWd CrA+cHWGslfXX2BnbmKovPLU4tlH5sXyRg+TGqhPGfUF2nIMIoawD4XM4jAk6iNx kAaCkGmZIW3u4occ19O6ILamXrgPDy1HtNjKLK1BAU319G/djDrK7XM+cwmIllNU pjtKQ0Orq119n9YFdmfQ9u/zgvyWAWqVdnQxpFiqGgCTrAssK+o2u40rBKv+M5/u tWDclDBUDdiZ2WVogwNi4lDYYrr/KwsuS7MQNNAJploEI89m1k6mJ7HcqZyjGwia IaohVqo9RVUBU7gi1QLbF4lDPJTnZg== =QUz7 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 19 15:20:04 2019 Received: (at 35866) by debbugs.gnu.org; 19 Dec 2019 20:20:05 +0000 Received: from localhost ([127.0.0.1]:45564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ii2HE-0002lX-MS for submit@debbugs.gnu.org; Thu, 19 Dec 2019 15:20:04 -0500 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21129) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ii2HC-0002lO-Mo for 35866@debbugs.gnu.org; Thu, 19 Dec 2019 15:20:03 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1576786797; cv=none; d=zohomail.com; s=zohoarc; b=WS7AGMDhGQtVdZUOs7gbudwwTm/e8BcMglDdaaLtgF1zQU6bppbQF2UjkfppFd/qgs8MkNJozm47QfBBSBWzj+8JdNk9Tkep8WfvxuNy7Zha6Y+bQw8a1oxC74l3uNms/38Qn9HT4oAakA2FwDdIZ0/I2GlFt8YAA9GsXXduCv4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576786797; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=lCjmOTkJsUF5hmfBzDJRnNXoH+3tAtQ/cWi7H/26kxY=; b=cCb9mzL3leBRvIGfjFRlkMmqBRsCo0ze8X/aKxUCvHjWkZRAaiAAe/qJlNUDW+lVcMETmVWCbRJIGtDJ5UK8BNa4OmqrDsbJKJH5sDu8/z4B6fmbW+3uZRZT6X+2Alq5Dx8ynXMDIOjxLjPK1CA757j/VdZwHoWfSyKOKPAIsPY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1576786797; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=lCjmOTkJsUF5hmfBzDJRnNXoH+3tAtQ/cWi7H/26kxY=; b=gJD3buxLIs2i8diYVFivR+oo0MUqeBjT1y77STfJHaJrpLyBuFqqZBUnAuNSjzQ7 gro5ft+5LZo6U6oxqxvUhvMzOV818V4k0JASyNzSyDNbnkcCJUtGCrP3PpuhYd0YHD5 DpL0czzB6aO8h+FBBADfVy2wkVIxIPUjDq8o3Ybo= Received: from localhost (p54AD4BA3.dip0.t-ipconnect.de [84.173.75.163]) by mx.zohomail.com with SMTPS id 1576786792879375.99979068044024; Thu, 19 Dec 2019 12:19:52 -0800 (PST) References: <20190523062344.20601-1-mrosset@bufio.org> <20191218203223.22861-1-mike.rosset@gmail.com> User-agent: mu4e 1.2.0; emacs 26.3 From: Ricardo Wurmus To: mike.rosset@gmail.com Subject: Re: [bug#35866] [PATCH] gnu: Add qtwebengine. In-reply-to: <20191218203223.22861-1-mike.rosset@gmail.com> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Thu, 19 Dec 2019 21:19:49 +0100 Message-ID: <87d0ckqd96.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35866 Cc: Marius Bakke , GNU Guix maintainers , 35866@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Mike, > * gnu/packages/qt.scm (qtwebengine): New variable. > > This is a new qtwebengine patch with working locales. Thank you very much for working on this! This doesn=E2=80=99t look like an= easy package. > + (description "Qt5WebEngine provides support for web > +applications using the Chromium browser project.") Does this include the unmodified Chromium source code? We need to ensure that the variant we are distributing here does not contain any misfeatures that Chromium is known for (e.g. DRM support) and that only free software is included. Marius and others previously worked very hard on making sure that the ungoogled-chromium package complied with our expectations for Chromium. I wonder what work needs to be done on the sources included in this package to accomplish the same goal. Did you happen to investigate this? -- Ricardo From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 19 19:02:56 2019 Received: (at 35866) by debbugs.gnu.org; 20 Dec 2019 00:02:56 +0000 Received: from localhost ([127.0.0.1]:45722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ii5ku-0008EI-0a for submit@debbugs.gnu.org; Thu, 19 Dec 2019 19:02:56 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:33886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ii5ks-0008E4-4p for 35866@debbugs.gnu.org; Thu, 19 Dec 2019 19:02:54 -0500 Received: by mail-pg1-f194.google.com with SMTP id r11so4010128pgf.1 for <35866@debbugs.gnu.org>; Thu, 19 Dec 2019 16:02:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=qYCIZ5xyPwL50hEmyslMa2INpfL4H9gLuAJ6cnJYpe8=; b=CmL6NBSbbh17uwyuAK+n/3BitlKk7rnueQhqzLwCjVBo6JVFhSvFsp9V+hZ+Sgz1YB 69KflK6pBtjCjUfZK7PNtaC9NY9lXmuUzUkr1j9AOoFtfs+xkIN6DufVTGckJnqUH7Wn FFyFNKZah9qW8jFTmsgn5enj2tCIWlLSL7Lv6qSbvC8z4aCAzo/hY9nnYXwf5sXDeG55 DOoI3cCu/VJeT/6U1BAwr6bKArwt3ij5PaaMWM9pp/4Lbbt8R06uYFaqPpEksg8382+E /yaZk2wqknaprW555IoYr35RWnWuRXEYDQYmP0D5k0Zx6XSQnEBbTchbfu93iURjm6Bd 3jrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=qYCIZ5xyPwL50hEmyslMa2INpfL4H9gLuAJ6cnJYpe8=; b=n98irj1+gjEiQpDKlgv6eXLbJrOe2MajUXkUxaGBH9O6T1Wenj22OE28DXd/PpYwVT K43ojXqOgOetFfVqRJB0oPBP80QyNmWwgqs+7mQd2YWN3X+DzsRfYS3g9E7VkSlPlHB2 a+pRAQFUg8zJXjBxIcJ2FLksegSY3WcCX40LfI0IbaTxyQWoA0owXamT84s64WVphN5p 7+vz5Msv9GE7KAOvBYHJnnO0WnC+DK9wU79AXU6eHgfhgM+2qr8pk6xbMVuv+3fkOkxo ZwmeTutXM/MzkuVS0M/jaozgmv8L/R9HjC9SEzyoTetJQgRXbb88yeeJagAYZeXzMWAV EfbA== X-Gm-Message-State: APjAAAXa8ed2a4+oZxXQNMadPQcw5OwMKY4eY/5Wyq3s0yAWmFXDD6Mf wsRKW+sWUrv7PFqmbdprXbo= X-Google-Smtp-Source: APXvYqwHr+UjjAEurRkb4fEyGv06MYD5A6JIynfoa/e3NcVSG/8FW5yeH+1tBA8vONYkecxlUZF2MA== X-Received: by 2002:aa7:91c8:: with SMTP id z8mr12959324pfa.223.1576800168123; Thu, 19 Dec 2019 16:02:48 -0800 (PST) Received: from neutron (node-1w7jr9qlfahmev9dakqkc7if6.ipv6.telus.net. [2001:569:74e0:7d00:c8c3:b228:84c0:5502]) by smtp.gmail.com with ESMTPSA id q25sm9670191pfg.41.2019.12.19.16.02.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 16:02:47 -0800 (PST) From: mike.rosset@gmail.com To: Ricardo Wurmus Subject: Re: [bug#35866] [PATCH] gnu: Add qtwebengine. References: <20190523062344.20601-1-mrosset@bufio.org> <20191218203223.22861-1-mike.rosset@gmail.com> <87d0ckqd96.fsf@elephly.net> Date: Thu, 19 Dec 2019 16:02:46 -0800 In-Reply-To: <87d0ckqd96.fsf@elephly.net> (Ricardo Wurmus's message of "Thu, 19 Dec 2019 21:19:49 +0100") Message-ID: <874kxv7tjt.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35866 Cc: Marius Bakke , GNU Guix maintainers , 35866@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ricardo Wurmus writes: >> + (description "Qt5WebEngine provides support for web >> +applications using the Chromium browser project.") > > Does this include the unmodified Chromium source code? We need to > ensure that the variant we are distributing here does not contain any > misfeatures that Chromium is known for (e.g. DRM support) and that only > free software is included. The chromium source is modified to remove google services etc. quoting from https://wiki.qt.io/QtWebEngine. - Binary files are stripped out - Auxiliary services that talk to Google platforms are stripped out - The codebase is modularized to allow use of system libraries like OpenSSL There is also a rebase patch process to allow upgrading to the current chromium. > Marius and others previously worked very hard on making sure that the > ungoogled-chromium package complied with our expectations for Chromium. > I wonder what work needs to be done on the sources included in this > package to accomplish the same goal. > > Did you happen to investigate this? It was proposed that maybe the ungoogled-chrome sources/changes could be used. But to me it seems to Qt is already doing the right thing here. I'm just not confident with the size of this code base, and with the QT specific front end. the ungoogled sources could be dropped in and expected to work. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 20 10:52:22 2019 Received: (at 35866) by debbugs.gnu.org; 20 Dec 2019 15:52:22 +0000 Received: from localhost ([127.0.0.1]:47191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iiKZh-0000t7-VP for submit@debbugs.gnu.org; Fri, 20 Dec 2019 10:52:22 -0500 Received: from mail-pl1-f174.google.com ([209.85.214.174]:37652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iiKZg-0000st-LM for 35866@debbugs.gnu.org; Fri, 20 Dec 2019 10:52:21 -0500 Received: by mail-pl1-f174.google.com with SMTP id c23so4270954plz.4 for <35866@debbugs.gnu.org>; Fri, 20 Dec 2019 07:52:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Fm1SIq3PY5stSyNZmOI7/gbUdbOrOun+vsSMoMXbfhQ=; b=enAdjYZws5t7lE0okMIDS7yoEJ5t+m/fQKOoA9KW+YoYCZyHvI6eT6ribg23m2RNnq UtQKLgUnts3RkNciL6AL4Gm9NKNweSGuS/noIOUKNAoPoO29xU7XBA6n+z44lOS2Btjq MZ/k7gjzSuLjybileGNFGy3+gL0pBXiFMI/X4hKsdCjFDrbhn0rAIVTYW1f1SW7yhzF5 +BiYeaHUoD4/IXEBqOnE3L/qC0ZPD0RVUANnz1ibIIwfb7SXWvC37/0G2iBkD1a7L75f UmD/6w//zSjUvjgVemMh3oTJCI9hcRQOw10Y3GJFDigUp/l6rghAtO5DKUIyeAOQc/98 P2Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Fm1SIq3PY5stSyNZmOI7/gbUdbOrOun+vsSMoMXbfhQ=; b=Eb68+TnLrR0So5wtC5bE8PFXKZQADSdNY6aK67ZoLxGmg++tN9CS2eXyvV0lXvDfFV G3i+Ql2R9tqj7NiojkwC7Wk1OG4eL2qmbnj8TMvsgbXRLbyO9Yn01JGxrSyMN9B/eFie 1GPVRuyWikX5DZh013gt9XpH6Xu8FSvb3C8w92gDnjhA+M/kxxUzkfSR7p2KeKoiqHEC Mtul7AzkY9yo6cepQEWpJe9OpPX62ZN8/jcb1elSifltxu1bzBq0rxM9J6Njb6Mxd9xq 6H0u/IWqKNwQ/852EQdHCYz5EJAWLWPY2jRXZZ6NqScplKHqTGgPWYlvZCKDONaqGcXK ZXJg== X-Gm-Message-State: APjAAAWH57f8GgAJTaeKWh1gVzsWCMQbV+GWMUrP+kdBgLs6Zlqx+z+Z Nj5sGlxqZnV1WKAAtERGECaxNKSO X-Google-Smtp-Source: APXvYqy0L7KSk8GeavHzO9Uwmh0FhL2fxbRGwyoA9luinE8fWMD73V7bkVW7Rfsh1KPsOCInJcIc0w== X-Received: by 2002:a17:902:a407:: with SMTP id p7mr15192335plq.4.1576857134367; Fri, 20 Dec 2019 07:52:14 -0800 (PST) Received: from neutron.telus (node-1w7jr9qlfahmev9dakqkc7if6.ipv6.telus.net. [2001:569:74e0:7d00:c8c3:b228:84c0:5502]) by smtp.gmail.com with ESMTPSA id r66sm13936702pfc.74.2019.12.20.07.52.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Dec 2019 07:52:13 -0800 (PST) From: Mike Rosset To: 35866@debbugs.gnu.org Subject: [PATCH 2/2] gnu: qtwebengine now uses pulseaudio Date: Fri, 20 Dec 2019 07:52:01 -0800 Message-Id: <20191220155201.12594-1-mike.rosset@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <87zhfn6ebv.fsf@gmail.com> References: <87zhfn6ebv.fsf@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 35866 Cc: mike.rosset@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) This also documents know input issues and improves the package expression syntax --- gnu/packages/qt.scm | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index 12028fd64c..ae356e533b 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -2039,10 +2039,9 @@ time Web content can be enhanced with native controls.") (method url-fetch) (uri (string-append "https://download.qt.io/official_releases/qt/" - (substring version 0 4) - "/" version "/submodules/" - (string-append name "-everywhere-src-" version) - ".tar.xz")) + (version-major+minor version) "/" version + "/submodules/" name "-everywhere-src-" + version ".tar.xz")) (sha256 (base32 "08c60nh95m98mcqk444axs76xi6m9x0wvdxrzk9c2cxwqdbz59fa")))) @@ -2055,8 +2054,7 @@ time Web content can be enhanced with native controls.") ("perl" ,perl) ("pkg-config" ,pkg-config) ("python-2" ,python-2) - ("ruby" ,ruby) - )) + ("ruby" ,ruby))) (inputs `(("alsa-lib" ,alsa-lib) ("atk" ,atk) @@ -2072,8 +2070,6 @@ time Web content can be enhanced with native controls.") ("libevent" ,libevent) ("libgcrypt" ,libgcrypt) ("libjpeg" ,libjpeg-turbo) - ;; libsrtp not found by qmake. seems to not have config.tests? - ("libsrtp" ,libsrtp) ;; FIXME: error: ?struct vpx_svc_ref_frame_config? has no member named ?frame_flags? ;; ("libvpx" ,libvpx) ("libwebp" ,libwebp) @@ -2083,7 +2079,9 @@ time Web content can be enhanced with native controls.") ("libxcursor" ,libxcursor) ("libxi" ,libxi) ("libxkbcommon" ,libxkbcommon) - ;; libxml not found due to icu not enabled in libxml? + ;; FIXME: libxml2 needs to built with icu support though it links to + ;; libxml2 configure summary still states. Checking for compatible + ;; system libxml2... no ("libxml2" ,libxml2) ("libxrandr" ,libxrandr) ("libxrender" ,libxrender) @@ -2095,7 +2093,7 @@ time Web content can be enhanced with native controls.") ("opus" ,opus) ("pciutils" ,pciutils) ("protobuf" ,protobuf) - ;; ("pulseaudio" ,pulseaudio) + ("pulseaudio" ,pulseaudio) ("qtbase" ,qtbase) ("qtdeclarative" ,qtdeclarative) ("qtmultimedia" ,qtmultimedia) @@ -2112,19 +2110,22 @@ time Web content can be enhanced with native controls.") (lambda* (#:key inputs outputs #:allow-other-keys) ;; Avoids potential race conditions (setenv "PYTHONDONTWRITEBYTECODE" "1") - ;; Make build output less verbose + ;; Make ninja build output less verbose (setenv "NINJAFLAGS" "-k1") - ;; Use this output translations not qtbase + ;; Qtwebengine is not installed into the same prefix as + ;; qtbase. Some qtbase QTLibraryInfo constants will not + ;; work. Replace with the full path to the qtwebengine + ;; translations and locales in the store. (substitute* "src/core/web_engine_library_info.cpp" (("QLibraryInfo::location\\(QLibraryInfo::TranslationsPath\\)") (format #f "QLatin1String(\"~a\")" (string-append (assoc-ref outputs "out") "/share/qt5/translations"))) (("QLibraryInfo::location\\(QLibraryInfo::DataPath\\)") (format #f "QLatin1String(\"~a\")" (string-append (assoc-ref outputs "out") "/share/qt5")))) - ;; Substitute full dynamic path for nss + ;; Substitute full dynamic library path for nss (substitute* "src/3rdparty/chromium/crypto/nss_util.cc" (("libnssckbi.so") (string-append (assoc-ref inputs "nss") "/lib/nss/libnssckbi.so"))) - ;; Substitute full dynamic path for udev + ;; Substitute full dynamic library path for udev (substitute* "src/3rdparty/chromium/device/udev_linux/udev1_loader.cc" (("libudev.so.1") (string-append (assoc-ref inputs "udev") "/lib/libudev.so.1"))) @@ -2143,7 +2144,7 @@ time Web content can be enhanced with native controls.") (variable "QTWEBENGINEPROCESS_PATH") (files '("lib/qt5/libexec/QtWebEngineProcess"))))) (home-page "https://www.qt.io") - (synopsis "Qt WebEngine Module") + (synopsis "Qt WebEngine module") (description "Qt5WebEngine provides support for web applications using the Chromium browser project.") (license -- 2.24.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 31 08:10:17 2019 Received: (at 35866) by debbugs.gnu.org; 31 Dec 2019 13:10:17 +0000 Received: from localhost ([127.0.0.1]:33856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imHHs-0004cK-SB for submit@debbugs.gnu.org; Tue, 31 Dec 2019 08:10:17 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:51919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imHHr-0004cC-1c for 35866@debbugs.gnu.org; Tue, 31 Dec 2019 08:10:16 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 47nF5d6KgBz1rHDb; Tue, 31 Dec 2019 14:10:13 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 47nF5d4lTRz1rFGX; Tue, 31 Dec 2019 14:10:13 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id ONWEZVQHmiqN; Tue, 31 Dec 2019 14:10:11 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-188-174-54-129.dynamic.mnet-online.de [188.174.54.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Tue, 31 Dec 2019 14:10:11 +0100 (CET) Received: from thisbe.goebel-consult.de (hermia.goebel-consult.de [192.168.110.7]) by hermia.goebel-consult.de (Postfix) with ESMTP id 9925460138; Tue, 31 Dec 2019 14:11:44 +0100 (CET) Subject: Re: [PATCH] gnu: Add qtwebengine. To: Mike Rosset , 35866@debbugs.gnu.org References: <20191218204537.24069-1-mike.rosset@gmail.com> From: Hartmut Goebel Autocrypt: addr=h.goebel@crazy-compilers.com; prefer-encrypt=mutual; keydata= mQINBFJQM3oBEACiUXmMppc3+A7JpF3lPz8O/mRhfz1U6F4EOTlacTrCcm7Xg5U2JsPPNapV r5+vHnKBK+xbaX3s/A/G+SwrUZhi1X1HRnSNY1CqL8CT7rZmOtfjg4ExnOuCjie2bKhb9JKm lJ7MrNimIbNQoX1mRcQ4VMEflhyWfaPGbT73siuMkbr020ExhzW8T18JIC01SgWMULYMBXOB oGY21am/vaTFCK8bym1P4HVN8i64uOWL0agkAMHbju6SZtG2fYJ68eS3P/97bXRg1pveEdpa FgaFZhquecw4WdedwLwt1xNcjAg/p6tN73W3asEZTgMHa+iNzbJgcyhWpci09wQZfZ1uL0Hd M+ohng38ccgu9hJx6YzCN7Fe14JooKbPukG/WfClAgAzZSHRKpS4zGdGlg6D6EWayyWWoLR3 KoMA4LIIlaQbqaOhfe85b4mNgB1hqd0uRTHOah/6T+FUoSQ1IAeKLIDqj6rW7X4ISRn1CXGS LGDn2QKqR3KtU3cLf8hAeDeO7Qe1jTvLrG1Mfca8lEmC7/yN1gI7L4/cs6lhmXUgMaevuxss BxO2kkh0OS8HVFf+QQ7LZ5vt91yQVT9HVvOuVob0YtG+3rvkpMaHQilKloNoEkmMiHpwypBa IfAC6NP9smgionvvmQ5RWSEaH5/pfSUAYbqzWbqDxtqEF/mPOwARAQABtC1IYXJ0bXV0IEdv ZWJlbCA8aC5nb2ViZWxAY3JhenktY29tcGlsZXJzLmNvbT6JAj0EEwEKACcCGwMCHgECF4AF CwkIBwMFFQoJCAsFFgIDAQAFAluyK5QFCQ0kXxEACgkQe3UoEb93O2XMlw//Z2/aXbZO3lJv uvfDBU3fJBKxp87EButnuwudFyaNupKxO13R7rBKB/Oti/rNP7IlK56WwU10ldK6C1PYnqru 5L1VCjWRi2Jd/XlvgXlc1jqstbM7NfU7pGOzctJGYpKh+7b1EdSM4V1KnDKcbKicLKC7zS+d HUdsch5w5XJj+pZRE4R0KEA/vEBB4ba+m+b59WqzaLin2pOqyo4Ff9o5uVgxlNrLIJQsg74T MTQP8khyDLfmyiN42VVkOBOIPMLA8ljEA1I7I4WwW3bT3mxOXHUExey/YsOdpqYX+kh7u/tj 7kbjKQbdCwdwUqSOPLmW9/9Wxyf2/xi+3lCvxzwPPElnK62yKlxLhVMt+Ah3J2QeLmrVGG5X PQzplrmQ6ptpEC9evrK3ALBJ+UGGxyyLp7sPb0SbDq70tZLRtbcE6QnpQA2IQIPTTy40lGVy 3a3iXiDM7hzbljWS0XSaEHoZ/WdgKLV+OzVZ9vrhP+7HrK7hEzdYqCvNfcW6bk2KrMN0RxBB OAbiRne8E0iTffh9uTyW7sAE0UDA9J3KtD3fpkld9cQrhwUVsjuPfbCqnhCk0B7ro1OR0DHB bgMVEylEsACnHEU4XWvo+U+0MgJtDQjzIy+XZfXDCs1VOy+murgcs0YIFqesyYOaaF1eP1S0 Yr18n/pfAPCFfg0rhMQUyoK5Ag0EUlAzegEQAL3lOz+uhHudEvovJVdExl+MTHLpYcajA0QL zDXe0jiAYdB+Jpvm7CAKani61/eo1SnHyRORELjxl/fL3ytjg3yRvVAM2I+xg7lIB4qXL5rR 5K8iF4px/jYV2CBIiwOKQ6gVEVk2hpl/tPqP3QdOKXdLu3sOM1Ygg3PN5fc+I7B6luchx6Bu 7NAR7nWKn6D1NdOI1UZL6Dr6Me/6hNVJBGvDF3Fm2x0CoIHujFksfOxZtwoZMXn13N18ZDyQ OMA89eHNQlFri9i5xG3laMAW2M0bozf+FwTBXomIWkT2Tkj3omW8ZIcfags2SpRkQl45pE65 nLKK36eRNoNbBovqKalMyhKstFTpIjjTZRMI5EZ87j7gYX/ghCss2LZz4X0WfvH6lYt8Yvjv I9Stl4ENvNukQZSZgIpaaAgZceXyuLaj+FY1cVXK3AoTh+lordfXr3TSBxlb1z7cNHqsI9vd RwsfC+Ng+yRrNGnNw008fgDq9fhaZus1krtPQzTyJzMw9xnLKuHhHFbkHDaW1Gb9dnECBF8a T0kjffgENEa5K6bfyAGGZ5zikBuK9EZdIQ0KgLP55hdnY7PigXazSsvYxVB62+B0kRYxjyM7 UAX55+QeD7pkPhBmRozeNYZzQxu9cyeD83e1Yf7ddnBkkLXVyTzKIutGh2R2BkcmkbBKTv27 ABEBAAGJAjwEGAEKACYCGwwWIQTUrYucFnt1fE8I6Hd7dSgRv3c7ZQUCW7IswAUJDSRgPgAK CRB7dSgRv3c7ZbFUD/97iHXgPYSZWyZ9r8pgpRuyoIK2TKmClUxck1a0WUkTMjzi0gW4kOIj 2wNOUnsRqioxOVXAg0R9ix1l6+LBC8+m/VFoR37BYQsC5WrzkmeaFChrBPs+YlND0V7TWNq0 elBvsNuApVxSOzaJuxCnH9WLe3s4fIveymScNAZOm31DHgmkDcb1/NXg97nohqSeW+k3eQbh borMRT3kMaXrPTI8qal9TsYf6KhfPi61fbnGW6bNJ0LnWQj2b7nb6nIR99cr0sNymqOsC6Gq 0yHhTceRl2/DRBe+QCxoiFKs1s6f7Af+U9r/JkHfdOLCRxjmAyl22zlhmBeNlGSvDbJqy5AE 7fKo1/mVQ2CNskF0BcOhrrntVf4A1gy3OlIXnCV//HH6w7qRBpw0inpD5c9Ny20aNdo8mS3y szcGZLczkdx8qzYEXBCO8zSDiRllrf6e8H5AaQdtHInxQ2Ywdqz/Ho81irbcPaHwI7P9/qvm zYnPZ3ULNlrI/+mq0oYkCB8oB9HW0C/YGZ/nIYY0vxDoy6n6EhEzntdAjF6Pav+QHB216fBs LMLs8X4+PXOc+MaAmQQTyTF9C8vfQk86E4eRmQErYw0aYVR7bUqyYfX8e2c5geqeSm6O+Brv 6LQtDbOJIcmJW1NS8XVmDG9JmkbtYqhnRDQMT+YFJircfDYmUvL4Ww== Organization: crazy-compilers.com Message-ID: Date: Tue, 31 Dec 2019 14:10:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20191218204537.24069-1-mike.rosset@gmail.com> Content-Type: multipart/alternative; boundary="------------CA573C5F5E482682A7771D13" Content-Language: en-US X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 35866 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------CA573C5F5E482682A7771D13 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Hi, in addtion to other remarks: Am 18.12.19 um 21:45 schrieb Mike Rosset > + (uri > + (string-append "https://download.qt.io/official_releases/qt/" > + (substring version 0 4) > + "/" version "/submodules/" > + (string-append name "-everywhere-src-" version) > + ".tar.xz")) Please use the same code and formatting as sued for qtsvg. This helps keeping the code consistent. > + `(modify-phases ,phases > + (replace 'configure > + (lambda* (#:key inputs outputs #:allow-other-keys) > + ;; Avoids potential race conditions I suggest to put this into *two* new phases: `patch-source` (or so) containing the substitute stuff, and `setup-configure` for setting the environment variables. > + (substitute* "src/core/web_engine_library_info.cpp" > + (("QLibraryInfo::location\\(QLibraryInfo::TranslationsPath\\)") > + (format #f "QLatin1String(\"~a\")" (string-append (assoc-ref outputs "out") "/share/qt5/translations"))) > + (("QLibraryInfo::location\\(QLibraryInfo::DataPath\\)") > + (format #f "QLatin1String(\"~a\")" (string-append (assoc-ref outputs "out") "/share/qt5")))) I suggest *not* using `format`, as we rarely use it in substitutes and you are using `string-append` anyway. I also suggest to define a variable `out` to be used here (same for `nss`, `udev` below) to avoid having `assic-ref` here, see [0] as an example. Then `format` might even be beneficial: +                  (format #f "QLatin1String(\"~a/share/qt5/translations\")" out) +                  (string-append "QLatin1String(\"" out "/share/qt5/translations\")") [0] > + ;; Valid QT_BUILD_PARTS variables are: > + ;; libs tools tests examples demos docs translations > + (invoke "qmake" "QT_BUILD_PARTS = libs tools" "--" > + "--webengine-printing-and-pdf=no" > + "--webengine-ffmpeg=system" > + "--webengine-icu=system" > + "--webengine-pepper-plugins=no"))))) Would setting `#:configure-flags` with "-DBUILD_TESTS=off" (see e.g. [1]) work, too, instead of passing "QT_BUILD_PARTS"? [1] -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | --------------CA573C5F5E482682A7771D13 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit
Hi,
in addtion to other remarks:

Am 18.12.19 um 21:45 schrieb Mike Rosset 
+       (uri
+        (string-append "https://download.qt.io/official_releases/qt/"
+                       (substring version 0 4)
+                       "/" version "/submodules/"
+                       (string-append name "-everywhere-src-" version)
+                       ".tar.xz"))


Please use the same code and formatting as sued for qtsvg. This helps keeping the code consistent. 

+        `(modify-phases ,phases
+           (replace 'configure
+             (lambda* (#:key inputs outputs #:allow-other-keys)
+               ;; Avoids potential race conditions
I suggest to put this into *two* new phases: `patch-source` (or so) containing the substitute stuff, and `setup-configure` for setting the environment variables.


+               (substitute* "src/core/web_engine_library_info.cpp"
+                 (("QLibraryInfo::location\\(QLibraryInfo::TranslationsPath\\)")
+                  (format #f "QLatin1String(\"~a\")" (string-append (assoc-ref outputs "out") "/share/qt5/translations")))
+                 (("QLibraryInfo::location\\(QLibraryInfo::DataPath\\)")
+                  (format #f "QLatin1String(\"~a\")" (string-append (assoc-ref outputs "out") "/share/qt5"))))

I suggest *not* using `format`, as we rarely use it in substitutes and you are using `string-append` anyway. I also suggest to define a variable `out` to be used here (same for `nss`, `udev` below) to avoid having `assic-ref` here, see [0] as an example. Then `format` might even be beneficial:

+                  (format #f "QLatin1String(\"~a/share/qt5/translations\")" out)

+                  (string-append "QLatin1String(\"" out "/share/qt5/translations\")")


[0] <https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/qt.scm#n605>

+               ;; Valid QT_BUILD_PARTS variables are:
+               ;; libs tools tests examples demos docs translations
+               (invoke "qmake" "QT_BUILD_PARTS = libs tools" "--"
+                       "--webengine-printing-and-pdf=no"
+                       "--webengine-ffmpeg=system"
+                       "--webengine-icu=system"
+                       "--webengine-pepper-plugins=no")))))

Would setting `#:configure-flags` with "-DBUILD_TESTS=off" (see e.g. [1]) work, too, instead of passing "QT_BUILD_PARTS"?


[1] <https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/qt.scm#n2119>


-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |
--------------CA573C5F5E482682A7771D13-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 11:04:07 2020 Received: (at 35866) by debbugs.gnu.org; 1 Jan 2020 16:04:07 +0000 Received: from localhost ([127.0.0.1]:37406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imgTf-0001HL-Ac for submit@debbugs.gnu.org; Wed, 01 Jan 2020 11:04:07 -0500 Received: from mail-pl1-f176.google.com ([209.85.214.176]:41612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imgTd-0001Gs-EQ for 35866@debbugs.gnu.org; Wed, 01 Jan 2020 11:04:06 -0500 Received: by mail-pl1-f176.google.com with SMTP id bd4so16886878plb.8 for <35866@debbugs.gnu.org>; Wed, 01 Jan 2020 08:04:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=z5QRvbf1TRp/mzsJ7eNgllH9c5aexmBOK15CXtQYXWk=; b=AX0qvmk4BA/NQs0D8gtga60EHchsssyieeHlXXDalgAxP7F+8b+qzzFXRlA58PqRkf d0WyQh3b2OcMtqMkHg0vK1EEeHSz7cFpp/WHmCb4NTA7ktNvEAjAfT02otoZSJK4j4NK dAP04bf9l7DTv/Gxaiu0l9tYS2UJ0LDSHfV64XQUqnTDn8jAgIaTNol+/rK8wvHWyAvm YT/zb9lXFUuyBreAywWfdZXDG4fbK+fs8MekdwNLpFDMM4mfbj0NBxosItExLJ5iNcml lBGQXQ6AhwZPZDSMzlDXRzZe+wWZ1yihWTOuuvIk9CbJdG1Q3EkafGX5MyNKytUtbVpd NxJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=z5QRvbf1TRp/mzsJ7eNgllH9c5aexmBOK15CXtQYXWk=; b=PPk9+48HS/D0yJKJpCDi1uAwyir34X1bw353/hmrj+5wG/xcJNyYe2XVJ1LbVvwIoJ ScwkgVtSSeNmU8OAFYAqszwTOsSr4fSxo/FG0LcZjc9akGFIv5k8YnNxWWDpucT+IZ1P YFo+uRVWcDeZKrOchpki83Dwz1BGkAMJB8v5Jvc0gfDE1GSIBzmtIxRnXQ+FDUCivGtY 8Kzc22QIpr1NTs9Pei6pnhXJtTzp/QoUJkcAQkpVNxem/9U3KXxOl1kSlGO3idcx8j89 T4lbnoMPZJOcIH4lck3MOKF3D3GJqGlHzxF7m8qr3v+LBquGkuFAHWWA4J2V1a5VDNPG JtSw== X-Gm-Message-State: APjAAAWM0W+068QCr7Et5fAFSwdpi8AUVhnNkn8x4RuQfZDcLI475LcS Dxp6iv50cbAA2QgkXsZDCbFV6F09Lgk= X-Google-Smtp-Source: APXvYqzYeA56bANajHy40juIZ5TCnB99T+rMwWJXEF3G+/zDtJacg0bZZ6aEV80LMaTrZtfM83fz7w== X-Received: by 2002:a17:90a:2351:: with SMTP id f75mr14392632pje.133.1577894639198; Wed, 01 Jan 2020 08:03:59 -0800 (PST) Received: from neutron.telus (node-1w7jr9qlfahmev9dakqkc7if6.ipv6.telus.net. [2001:569:74e0:7d00:c8c3:b228:84c0:5502]) by smtp.gmail.com with ESMTPSA id o14sm54524337pgm.67.2020.01.01.08.03.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jan 2020 08:03:58 -0800 (PST) From: Mike Rosset To: 35866@debbugs.gnu.org Subject: [PATCH 1/4] gnu: Add qtwebengine. Date: Wed, 1 Jan 2020 08:03:52 -0800 Message-Id: <20200101160355.32604-1-mike.rosset@gmail.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 35866 Cc: mike.rosset@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) * gnu/packages/qt.scm (qtwebengine): New variable. This is a new qtwebengine patch with working locales. --- gnu/packages/qt.scm | 129 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 129 insertions(+) diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index 795b5e9d2b..2b4b167a14 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -52,30 +52,40 @@ #:use-module (gnu packages flex) #:use-module (gnu packages freedesktop) #:use-module (gnu packages gcc) + #:use-module (gnu packages ghostscript) #:use-module (gnu packages gl) #:use-module (gnu packages glib) + #:use-module (gnu packages gnupg) #:use-module (gnu packages gperf) #:use-module (gnu packages gstreamer) #:use-module (gnu packages gtk) #:use-module (gnu packages icu4c) #:use-module (gnu packages image) + #:use-module (gnu packages libevent) #:use-module (gnu packages linux) #:use-module (gnu packages llvm) #:use-module (gnu packages maths) + #:use-module (gnu packages ninja) #:use-module (gnu packages nss) #:use-module (gnu packages pciutils) #:use-module (gnu packages pcre) #:use-module (gnu packages perl) #:use-module (gnu packages pkg-config) #:use-module (gnu packages pulseaudio) + #:use-module (gnu packages protobuf) #:use-module (gnu packages python) #:use-module (gnu packages python-xyz) + #:use-module (gnu packages regex) #:use-module (gnu packages ruby) #:use-module (gnu packages sdl) + #:use-module (gnu packages serialization) #:use-module (gnu packages sqlite) + #:use-module (gnu packages telephony) #:use-module (gnu packages tls) + #:use-module (gnu packages video) #:use-module (gnu packages vulkan) #:use-module (gnu packages xdisorg) + #:use-module (gnu packages xiph) #:use-module (gnu packages xorg) #:use-module (gnu packages xml) #:use-module (srfi srfi-1)) @@ -2020,6 +2030,125 @@ time Web content can be enhanced with native controls.") (license license:lgpl2.1+))) +(define-public qtwebengine + (package (inherit qtsvg) + (name "qtwebengine") + (version (package-version qtbase)) + (source + (origin + (method url-fetch) + (uri + (string-append "https://download.qt.io/official_releases/qt/" + (substring version 0 4) + "/" version "/submodules/" + (string-append name "-everywhere-src-" version) + ".tar.xz")) + (sha256 + (base32 + "08c60nh95m98mcqk444axs76xi6m9x0wvdxrzk9c2cxwqdbz59fa")))) + (build-system gnu-build-system) + (native-inputs + `(("bison" ,bison) + ("flex" ,flex) + ("gperf" ,gperf) + ("ninja" ,ninja) + ("perl" ,perl) + ("pkg-config" ,pkg-config) + ("python-2" ,python-2) + ("ruby" ,ruby) + )) + (inputs + `(("alsa-lib" ,alsa-lib) + ("atk" ,atk) + ("cups-minimal" ,cups-minimal) + ("dbus" ,dbus) + ("ffmpeg" ,ffmpeg) + ("fontconfig" ,fontconfig) + ("harbuzz" ,harfbuzz) + ("icu4c" ,icu4c) + ("jsoncpp" ,jsoncpp) + ("lcms" ,lcms) + ("libcap" ,libcap) + ("libevent" ,libevent) + ("libgcrypt" ,libgcrypt) + ("libjpeg" ,libjpeg-turbo) + ;; libsrtp not found by qmake. seems to not have config.tests? + ("libsrtp" ,libsrtp) + ;; FIXME: error: ?struct vpx_svc_ref_frame_config? has no member named ?frame_flags? + ;; ("libvpx" ,libvpx) + ("libwebp" ,libwebp) + ("libx11" ,libx11) + ("libxcb" ,libxcb) + ("libxcomposite" ,libxcomposite) + ("libxcursor" ,libxcursor) + ("libxi" ,libxi) + ("libxkbcommon" ,libxkbcommon) + ;; libxml not found due to icu not enabled in libxml? + ("libxml2" ,libxml2) + ("libxrandr" ,libxrandr) + ("libxrender" ,libxrender) + ("libxslt" ,libxslt) + ("libxtst" ,libxtst) + ("mesa" ,mesa) + ("minizip" ,minizip) + ("nss" ,nss) + ("opus" ,opus) + ("pciutils" ,pciutils) + ("protobuf" ,protobuf) + ;; ("pulseaudio" ,pulseaudio) + ("qtbase" ,qtbase) + ("qtdeclarative" ,qtdeclarative) + ("qtmultimedia" ,qtmultimedia) + ("qtwebchannel" ,qtwebchannel) + ("re2" ,re2) + ("snappy" ,snappy) + ("udev" ,eudev) + ("xcb-util" ,xcb-util))) + (arguments + (substitute-keyword-arguments (package-arguments qtsvg) + ((#:phases phases) + `(modify-phases ,phases + (replace 'configure + (lambda* (#:key inputs outputs #:allow-other-keys) + ;; Avoids potential race conditions + (setenv "PYTHONDONTWRITEBYTECODE" "1") + ;; Make build output less verbose + (setenv "NINJAFLAGS" "-k1") + ;; Use this output translations not qtbase + (substitute* "src/core/web_engine_library_info.cpp" + (("QLibraryInfo::location\\(QLibraryInfo::TranslationsPath\\)") + (format #f "QLatin1String(\"~a\")" (string-append (assoc-ref outputs "out") "/share/qt5/translations"))) + (("QLibraryInfo::location\\(QLibraryInfo::DataPath\\)") + (format #f "QLatin1String(\"~a\")" (string-append (assoc-ref outputs "out") "/share/qt5")))) + ;; Substitute full dynamic path for nss + (substitute* "src/3rdparty/chromium/crypto/nss_util.cc" + (("libnssckbi.so") + (string-append (assoc-ref inputs "nss") "/lib/nss/libnssckbi.so"))) + ;; Substitute full dynamic path for udev + (substitute* "src/3rdparty/chromium/device/udev_linux/udev1_loader.cc" + (("libudev.so.1") + (string-append (assoc-ref inputs "udev") "/lib/libudev.so.1"))) + ;; Valid QT_BUILD_PARTS variables are: + ;; libs tools tests examples demos docs translations + (invoke "qmake" "QT_BUILD_PARTS = libs tools" "--" + "--webengine-printing-and-pdf=no" + "--webengine-ffmpeg=system" + "--webengine-icu=system" + "--webengine-pepper-plugins=no"))))) + ((#:tests? _ #f) #f))) + (native-search-paths + (list (search-path-specification + (file-type 'regular) + (separator #f) + (variable "QTWEBENGINEPROCESS_PATH") + (files '("lib/qt5/libexec/QtWebEngineProcess"))))) + (home-page "https://www.qt.io") + (synopsis "Qt WebEngine Module") + (description "Qt5WebEngine provides support for web +applications using the Chromium browser project.") + (license + (package-license qt)))) + (define-public dotherside (package (name "dotherside") -- 2.24.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 11:04:21 2020 Received: (at 35866) by debbugs.gnu.org; 1 Jan 2020 16:04:21 +0000 Received: from localhost ([127.0.0.1]:37410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imgTs-0001Hu-PH for submit@debbugs.gnu.org; Wed, 01 Jan 2020 11:04:21 -0500 Received: from mail-pf1-f171.google.com ([209.85.210.171]:38894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imgTr-0001HZ-GJ for 35866@debbugs.gnu.org; Wed, 01 Jan 2020 11:04:19 -0500 Received: by mail-pf1-f171.google.com with SMTP id x185so20916750pfc.5 for <35866@debbugs.gnu.org>; Wed, 01 Jan 2020 08:04:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WJwQNbtSbaoelNMnKFX2q2AL96Bnvz7Ta8pnBVCbWCg=; b=qmi1jh2m1S/ohLYnswQKmIghoFtLWJfN0H6r9blkcMg9Nf0q16qWRo1PAWv3zWk1Wp lpiRed6oAwsXR4x/a0qMlhH4XnTWpFVUqAzSE1tSMqIfFXvvHhrf6VqfqrZMkKfrUFbT 6cGW3d2byQvT0HF/ZycdQIFTmepvnp5+KN+hFabjuDQGtuImXfM88dNDUI2Xe0PYmbtw qIY9q4Amd6Pa0QFl/cQMLzVKgRHp9Pzq51VhS3Niq1mmLRay0F7hxp+D1nZsJLArH1qp MtyT6IsE5Mm7xlWplxGE95wJKBS336dXDoGznyssRrv1vLEABzmgNc8wKraFC6L9Egqv sThg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WJwQNbtSbaoelNMnKFX2q2AL96Bnvz7Ta8pnBVCbWCg=; b=kOCYsa9kXgX0Ub1mlMQEb2FAag7/zwio71CGCh4g3TpBV72SzIv4LF+BV+eo8CnaYr n2apkP1NggA7SfBHjF9m/nUwTAAKrfFcXYLlrWHddB+Lz4hp85jGf1qPg6WvvWHr1xMp oVGJDdyeUa5bLr9MaGDSQAJ+m2g4ED10COR5p9eDEUezS3DEyDDx7Qsys+bvSzs+6uTW TIJPdWxIwYUwGWkG01/kn/14C3yaB1hVjQbps2HE9AEoWL4knsgRwSxp0AG+A6VBS2kA ZK+cX6r5uTUaK/V34HchyTzrOcUxFHIW2n8+sg4Wh9+9TIUTcspuVdRthgLMiY0+YiXe 6HHQ== X-Gm-Message-State: APjAAAU8hJekpoaJIAnmqTkWm0KUX48AnIuoF9iCOVIEfj3ZqY5Q+1xZ xRofiN9uCEXGZ9J0MFAXT3s3eZ4stlE= X-Google-Smtp-Source: APXvYqypS716sEhGfigpfUIiiTNmGtWNnipC1/HHtYWnREK2Q9Ifbge3sZBcCLr0Sj4aj9WITd/KSA== X-Received: by 2002:a63:950c:: with SMTP id p12mr85641582pgd.85.1577894653244; Wed, 01 Jan 2020 08:04:13 -0800 (PST) Received: from neutron.telus (node-1w7jr9qlfahmev9dakqkc7if6.ipv6.telus.net. [2001:569:74e0:7d00:c8c3:b228:84c0:5502]) by smtp.gmail.com with ESMTPSA id o14sm54524337pgm.67.2020.01.01.08.04.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jan 2020 08:04:12 -0800 (PST) From: Mike Rosset To: 35866@debbugs.gnu.org Subject: [PATCH 2/4] gnu: qtwebengine now uses pulseaudio Date: Wed, 1 Jan 2020 08:03:53 -0800 Message-Id: <20200101160355.32604-2-mike.rosset@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200101160355.32604-1-mike.rosset@gmail.com> References: <20200101160355.32604-1-mike.rosset@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 35866 Cc: mike.rosset@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) This also documents know input issues and improves the package expression syntax --- gnu/packages/qt.scm | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index 2b4b167a14..456b394230 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -2039,10 +2039,9 @@ time Web content can be enhanced with native controls.") (method url-fetch) (uri (string-append "https://download.qt.io/official_releases/qt/" - (substring version 0 4) - "/" version "/submodules/" - (string-append name "-everywhere-src-" version) - ".tar.xz")) + (version-major+minor version) "/" version + "/submodules/" name "-everywhere-src-" + version ".tar.xz")) (sha256 (base32 "08c60nh95m98mcqk444axs76xi6m9x0wvdxrzk9c2cxwqdbz59fa")))) @@ -2055,8 +2054,7 @@ time Web content can be enhanced with native controls.") ("perl" ,perl) ("pkg-config" ,pkg-config) ("python-2" ,python-2) - ("ruby" ,ruby) - )) + ("ruby" ,ruby))) (inputs `(("alsa-lib" ,alsa-lib) ("atk" ,atk) @@ -2072,8 +2070,6 @@ time Web content can be enhanced with native controls.") ("libevent" ,libevent) ("libgcrypt" ,libgcrypt) ("libjpeg" ,libjpeg-turbo) - ;; libsrtp not found by qmake. seems to not have config.tests? - ("libsrtp" ,libsrtp) ;; FIXME: error: ?struct vpx_svc_ref_frame_config? has no member named ?frame_flags? ;; ("libvpx" ,libvpx) ("libwebp" ,libwebp) @@ -2083,7 +2079,9 @@ time Web content can be enhanced with native controls.") ("libxcursor" ,libxcursor) ("libxi" ,libxi) ("libxkbcommon" ,libxkbcommon) - ;; libxml not found due to icu not enabled in libxml? + ;; FIXME: libxml2 needs to built with icu support though it links to + ;; libxml2 configure summary still states. Checking for compatible + ;; system libxml2... no ("libxml2" ,libxml2) ("libxrandr" ,libxrandr) ("libxrender" ,libxrender) @@ -2095,7 +2093,7 @@ time Web content can be enhanced with native controls.") ("opus" ,opus) ("pciutils" ,pciutils) ("protobuf" ,protobuf) - ;; ("pulseaudio" ,pulseaudio) + ("pulseaudio" ,pulseaudio) ("qtbase" ,qtbase) ("qtdeclarative" ,qtdeclarative) ("qtmultimedia" ,qtmultimedia) @@ -2112,19 +2110,22 @@ time Web content can be enhanced with native controls.") (lambda* (#:key inputs outputs #:allow-other-keys) ;; Avoids potential race conditions (setenv "PYTHONDONTWRITEBYTECODE" "1") - ;; Make build output less verbose + ;; Make ninja build output less verbose (setenv "NINJAFLAGS" "-k1") - ;; Use this output translations not qtbase + ;; Qtwebengine is not installed into the same prefix as + ;; qtbase. Some qtbase QTLibraryInfo constants will not + ;; work. Replace with the full path to the qtwebengine + ;; translations and locales in the store. (substitute* "src/core/web_engine_library_info.cpp" (("QLibraryInfo::location\\(QLibraryInfo::TranslationsPath\\)") (format #f "QLatin1String(\"~a\")" (string-append (assoc-ref outputs "out") "/share/qt5/translations"))) (("QLibraryInfo::location\\(QLibraryInfo::DataPath\\)") (format #f "QLatin1String(\"~a\")" (string-append (assoc-ref outputs "out") "/share/qt5")))) - ;; Substitute full dynamic path for nss + ;; Substitute full dynamic library path for nss (substitute* "src/3rdparty/chromium/crypto/nss_util.cc" (("libnssckbi.so") (string-append (assoc-ref inputs "nss") "/lib/nss/libnssckbi.so"))) - ;; Substitute full dynamic path for udev + ;; Substitute full dynamic library path for udev (substitute* "src/3rdparty/chromium/device/udev_linux/udev1_loader.cc" (("libudev.so.1") (string-append (assoc-ref inputs "udev") "/lib/libudev.so.1"))) @@ -2143,7 +2144,7 @@ time Web content can be enhanced with native controls.") (variable "QTWEBENGINEPROCESS_PATH") (files '("lib/qt5/libexec/QtWebEngineProcess"))))) (home-page "https://www.qt.io") - (synopsis "Qt WebEngine Module") + (synopsis "Qt WebEngine module") (description "Qt5WebEngine provides support for web applications using the Chromium browser project.") (license -- 2.24.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 11:04:22 2020 Received: (at 35866) by debbugs.gnu.org; 1 Jan 2020 16:04:22 +0000 Received: from localhost ([127.0.0.1]:37413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imgTu-0001I8-4N for submit@debbugs.gnu.org; Wed, 01 Jan 2020 11:04:22 -0500 Received: from mail-pj1-f66.google.com ([209.85.216.66]:53988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imgTs-0001Hb-27 for 35866@debbugs.gnu.org; Wed, 01 Jan 2020 11:04:20 -0500 Received: by mail-pj1-f66.google.com with SMTP id n96so2243804pjc.3 for <35866@debbugs.gnu.org>; Wed, 01 Jan 2020 08:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/eycnMPHgIJcsH50EaE4xSSAxKZkjvIxRZ8F4CC8pVc=; b=Wb744bpjI3JTk1EFHQZrne+7o+it+j/uO3tD1mg7UD9rncnvpxK9IAmeNEhNwWN3m1 McvExYP5UIBFO6RQY6HL0SerLHZPvVFMo8ODGqhX5aH8acHF/uiLQ1FKJyh0+sWFyQ0X 9brM9ZnnXH+UHoUUXjjqqcKDSlb4QLn9vpQznOvW8sP3qeILYHTO2oYqoSM2Yx+QyhXH jhP+f3qSQWmWapkV5+dYhhc/VpnAvsLq8cuD9/P+/AIuG7pIYYniaUYq0qWPYWLzajP1 GaBPV85kcgpP3ucHAS+DhziGhPUIAol7/+Mw5pgJl7r7em1RLPFwWomyoQ3gCgYGiZud 5sIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/eycnMPHgIJcsH50EaE4xSSAxKZkjvIxRZ8F4CC8pVc=; b=VzD1JMkZiNQM9OioTfJVnOh1qsTU0qgILxYWYPp7HxtOFvO+jLYM1yoJVy6SDqjSO+ Izgy0lo0VK4ExRT43aFb6rpElVLHGg+9S+mUu7hKcu+p4gTCZVNxR92GwsFX34f0QKAJ C2lP/BUM+25rXBPdgNyUN9HQFIoXfxErsq54QibQYEHgknSDGjw9w0T0GzQpFFNvdtNI LweKWYCqNBQRpTIkWJhSRxQ5k0NZ+jYr6yXKKz2RERRxcrKWMnzfAU4b4ondkyKCCEDW vyIlao+aDE7X2zwaVp0ML5IxlbEFiJCdETLWcmSgPeHpPECbCriRoK69hLboqiLz19fH TaGQ== X-Gm-Message-State: APjAAAU+TOM3arc9e3t/2075lOF0iaPYsvOnTtmNppRBKgs+xp7KvQdv 6mQeuthhzFND48xqMkX9FG/lPFI5pFI= X-Google-Smtp-Source: APXvYqzm1dfQsa0uixxGBSsMNLyN6F3Ssrncht4efPk84x/5is8KMCt9PPF+B0oBE10oRA+q8EPODw== X-Received: by 2002:a17:902:8344:: with SMTP id z4mr83632675pln.41.1577894654183; Wed, 01 Jan 2020 08:04:14 -0800 (PST) Received: from neutron.telus (node-1w7jr9qlfahmev9dakqkc7if6.ipv6.telus.net. [2001:569:74e0:7d00:c8c3:b228:84c0:5502]) by smtp.gmail.com with ESMTPSA id o14sm54524337pgm.67.2020.01.01.08.04.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jan 2020 08:04:13 -0800 (PST) From: Mike Rosset To: 35866@debbugs.gnu.org Subject: [PATCH 3/4] gnu: qtwebengine: now uses system libvpx Date: Wed, 1 Jan 2020 08:03:54 -0800 Message-Id: <20200101160355.32604-3-mike.rosset@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200101160355.32604-1-mike.rosset@gmail.com> References: <20200101160355.32604-1-mike.rosset@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35866 Cc: mike.rosset@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/qt.scm (qtwebengine): This also documents why qtwebengine test phase is disabled. --- gnu/packages/qt.scm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index 456b394230..f4908d1f27 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -2070,8 +2070,9 @@ time Web content can be enhanced with native controls.") ("libevent" ,libevent) ("libgcrypt" ,libgcrypt) ("libjpeg" ,libjpeg-turbo) - ;; FIXME: error: ?struct vpx_svc_ref_frame_config? has no member named ?frame_flags? - ;; ("libvpx" ,libvpx) + ("libvpx" ,libvpx) + ;; FIXME: configure does not find system lcms + ;; ("lcms" ,lcms) ("libwebp" ,libwebp) ("libx11" ,libx11) ("libxcb" ,libxcb) @@ -2136,6 +2137,9 @@ time Web content can be enhanced with native controls.") "--webengine-ffmpeg=system" "--webengine-icu=system" "--webengine-pepper-plugins=no"))))) + ;; Tests are disabled due to Could not find QtWebEngineProcess error + ;; It's possible this can be fixed by setting QTWEBENGINEPROCESS_PATH + ;; before running tests It's also possible some tests need a network ((#:tests? _ #f) #f))) (native-search-paths (list (search-path-specification -- 2.24.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 11:04:23 2020 Received: (at 35866) by debbugs.gnu.org; 1 Jan 2020 16:04:23 +0000 Received: from localhost ([127.0.0.1]:37415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imgTv-0001IJ-B8 for submit@debbugs.gnu.org; Wed, 01 Jan 2020 11:04:23 -0500 Received: from mail-pj1-f65.google.com ([209.85.216.65]:52482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imgTs-0001Hf-UV for 35866@debbugs.gnu.org; Wed, 01 Jan 2020 11:04:21 -0500 Received: by mail-pj1-f65.google.com with SMTP id a6so2248097pjh.2 for <35866@debbugs.gnu.org>; Wed, 01 Jan 2020 08:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4Aaa9N265Hlg6Vpd/fFBbCc3uLzPZUmvA2K6vF0Edas=; b=dCSjpFSHDgPRbdtpGIgS7r/qcoiLup1w3dP/5Mh0JYlx4O1Ot9cUjStMrnyOxXTXUJ 1Ea+8zidNfs+g/v6U/11JBR3l8wzcpB5PZ/bNmyTWNSZKJdogW13Huq+XkaCx6LeWnKG jk1PSh0pWHTddIBbNlMvaNb4pIAO0b0beRstgdPjSgS+oZG/L9e6TriiwT+KY9vuxxlY NqAcLtRRKaw5XRM+P9HQVjtXCbpHrqapYwvu09EGQdg0/5XVFgX5ejuF/quyBtoDhThS T+mfpnefbaJSteaz+cTaD1h3NmPdE75fcmroRtkyLQ2vyR17KNBkpXo1KKzyUO9cXJv0 fewg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4Aaa9N265Hlg6Vpd/fFBbCc3uLzPZUmvA2K6vF0Edas=; b=Ehba/cg1k2LlQHH3qxHVOV46Eg8w4aIJAhzBNSAGxbsff+f0+n8+kiBKSBVpzgLddW o4zqD/HZ0opKUkxinJaH7d54RVVUy3idi2YxrcLbtAF9HbIZbXyCEtaFC3ejCjXggk6x l1aG5Q5cSv1z9LlKEXNOGHaHwWenlNk4cOKIv9XFzn/Xn45g3a7uupgC+UDy4qv2i2I/ O2MqWR81gSO9yHUqDPLAwmdUYrJj8LDVJFm/aebKoyJGQWI14u8a/zdVvjAc8/Dz9h0i 1m5lloNlzQyz5dM4ildyMaysyPlxvzJnxPIWGZ7HmL+ceN2dU6bRQ9e+KhWVjlwt2DwT q+QA== X-Gm-Message-State: APjAAAV82k/o1CkbgGgPGirxk+DlvU6VR+fMkLnH8zPsaTtylqOyNf6C 3QJqK60lE6FB0+VSXN0WeVHCMLyiS/M= X-Google-Smtp-Source: APXvYqxQ4QfNha0XjyaTF231KOmzDWkNKueCcOrYmF1mLXvmJ1kFOVHQxdf7OuP6BOjM1D/suYENaA== X-Received: by 2002:a17:902:b596:: with SMTP id a22mr77900266pls.297.1577894655045; Wed, 01 Jan 2020 08:04:15 -0800 (PST) Received: from neutron.telus (node-1w7jr9qlfahmev9dakqkc7if6.ipv6.telus.net. [2001:569:74e0:7d00:c8c3:b228:84c0:5502]) by smtp.gmail.com with ESMTPSA id o14sm54524337pgm.67.2020.01.01.08.04.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jan 2020 08:04:14 -0800 (PST) From: Mike Rosset To: 35866@debbugs.gnu.org Subject: [PATCH 4/4] gnu: qtwebengine: separate substitution and configure phase Date: Wed, 1 Jan 2020 08:03:55 -0800 Message-Id: <20200101160355.32604-4-mike.rosset@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200101160355.32604-1-mike.rosset@gmail.com> References: <20200101160355.32604-1-mike.rosset@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 35866 Cc: mike.rosset@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) * gnu/packages/qt.scm (qtwebengine)[phases]: This moves the store substitutions to a substitute-source phase. And now a set-env phase sets environment build variables. format is no longer used when substituting translations and data paths --- gnu/packages/qt.scm | 65 ++++++++++++++++++++++++--------------------- 1 file changed, 35 insertions(+), 30 deletions(-) diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index f4908d1f27..a4a039dc80 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -2034,17 +2034,15 @@ time Web content can be enhanced with native controls.") (package (inherit qtsvg) (name "qtwebengine") (version (package-version qtbase)) - (source - (origin - (method url-fetch) - (uri - (string-append "https://download.qt.io/official_releases/qt/" - (version-major+minor version) "/" version - "/submodules/" name "-everywhere-src-" - version ".tar.xz")) - (sha256 - (base32 - "08c60nh95m98mcqk444axs76xi6m9x0wvdxrzk9c2cxwqdbz59fa")))) + (source (origin + (method url-fetch) + (uri (string-append "https://download.qt.io/official_releases/qt/" + (version-major+minor version) "/" version + "/submodules/" name "-everywhere-src-" + version ".tar.xz")) + (sha256 + (base32 + "08c60nh95m98mcqk444axs76xi6m9x0wvdxrzk9c2cxwqdbz59fa")))) (build-system gnu-build-system) (native-inputs `(("bison" ,bison) @@ -2107,29 +2105,36 @@ time Web content can be enhanced with native controls.") (substitute-keyword-arguments (package-arguments qtsvg) ((#:phases phases) `(modify-phases ,phases - (replace 'configure + (add-before 'configure 'substitue-source (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out")) + (nss (assoc-ref inputs "nss")) + (udev (assoc-ref inputs "udev"))) + ;; Qtwebengine is not installed into the same prefix as + ;; qtbase. Some qtbase QTLibraryInfo constants will not + ;; work. Replace with the full path to the qtwebengine + ;; translations and locales in the store. + (substitute* "src/core/web_engine_library_info.cpp" + (("QLibraryInfo::location\\(QLibraryInfo::TranslationsPath\\)") + (string-append "QLatin1String(\"" out "/share/qt5/translations\")")) + (("QLibraryInfo::location\\(QLibraryInfo::DataPath\\)") + (string-append "QLatin1String(\"" out "/share/qt5\")"))) + ;; Substitute full dynamic library path for nss + (substitute* "src/3rdparty/chromium/crypto/nss_util.cc" + (("libnssckbi.so") + (string-append nss "/lib/nss/libnssckbi.so"))) + ;; Substitute full dynamic library path for udev + (substitute* "src/3rdparty/chromium/device/udev_linux/udev1_loader.cc" + (("libudev.so.1") + (string-append udev "/lib/libudev.so.1")))))) + (add-before 'configure 'set-env + (lambda _ ;; Avoids potential race conditions (setenv "PYTHONDONTWRITEBYTECODE" "1") ;; Make ninja build output less verbose - (setenv "NINJAFLAGS" "-k1") - ;; Qtwebengine is not installed into the same prefix as - ;; qtbase. Some qtbase QTLibraryInfo constants will not - ;; work. Replace with the full path to the qtwebengine - ;; translations and locales in the store. - (substitute* "src/core/web_engine_library_info.cpp" - (("QLibraryInfo::location\\(QLibraryInfo::TranslationsPath\\)") - (format #f "QLatin1String(\"~a\")" (string-append (assoc-ref outputs "out") "/share/qt5/translations"))) - (("QLibraryInfo::location\\(QLibraryInfo::DataPath\\)") - (format #f "QLatin1String(\"~a\")" (string-append (assoc-ref outputs "out") "/share/qt5")))) - ;; Substitute full dynamic library path for nss - (substitute* "src/3rdparty/chromium/crypto/nss_util.cc" - (("libnssckbi.so") - (string-append (assoc-ref inputs "nss") "/lib/nss/libnssckbi.so"))) - ;; Substitute full dynamic library path for udev - (substitute* "src/3rdparty/chromium/device/udev_linux/udev1_loader.cc" - (("libudev.so.1") - (string-append (assoc-ref inputs "udev") "/lib/libudev.so.1"))) + (setenv "NINJAFLAGS" "-k1"))) + (replace 'configure + (lambda _ ;; Valid QT_BUILD_PARTS variables are: ;; libs tools tests examples demos docs translations (invoke "qmake" "QT_BUILD_PARTS = libs tools" "--" -- 2.24.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 11:29:20 2020 Received: (at 35866) by debbugs.gnu.org; 1 Jan 2020 16:29:20 +0000 Received: from localhost ([127.0.0.1]:37457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imgs4-0001z7-6Y for submit@debbugs.gnu.org; Wed, 01 Jan 2020 11:29:20 -0500 Received: from mail-pf1-f178.google.com ([209.85.210.178]:40813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imgs2-0001yi-Nn for 35866@debbugs.gnu.org; Wed, 01 Jan 2020 11:29:19 -0500 Received: by mail-pf1-f178.google.com with SMTP id q8so20935276pfh.7 for <35866@debbugs.gnu.org>; Wed, 01 Jan 2020 08:29:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=vQPVcbEzaBH/W++HzC+D32QExIAUPSiN8X4gANQ7a78=; b=k7kxMOnvkppmxdIQuzqa+loqILMzwAz9WMEgZzNpyEVwWdyhTejqYnXukH1KX6Oeav 2elyY0P2JWq+HKWDpQDf9CkORfce0PLjJgUPBxKanGMmDYnF0PycfUga3PoBXUL9P0Qo hgp8xUstu+9PxA3JaqWQf99Q690V+qYYiS0HVJRvZGtE6nQZlHKKGAvNxTDABla5Kr3H lsWLpjnMyYSscup2SPOBVbuCmDN0LI4pOKRKv7Obc9dfe7SGF7KcoUhAlGglxdmlCY9O YjRnycqT/MDAyA6ohBzObDaWHpzGjE5rza3pa5JLy5NRPgWJeCfkRg/82rkr4ntLwUUI 8rQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=vQPVcbEzaBH/W++HzC+D32QExIAUPSiN8X4gANQ7a78=; b=dcBujp8Li9Zfm6Rr/iTBBZu968cmjQi6MNZbt1NTEGbhlBfTLt5paIYwzyN79Xnj0l H8Vyf7y8+s+/E5bPztsZRV5CzwDhGiUIzqMKu5ss1JBWb7dSoPOPHlTju/fFloiyBMrx hP4AvA87RxdlBlKbyXiTluwBL2A5+bhCxFDQqEKG84wb3gwI5mLJAOiWK+sHl/znALxS R3/BkyNnHLLCNPwd8nePeZeWMSg6cKvIWa+HtGkHg5k5mJ3NwwImcLJZEXkOVHdVnIMb 1x4FHNnLhnv4GS1d1wdPIJ7lgdxeZyacIlZiJK0UbV1FQy5PqHnko3YQKQ3qANBDSUqw yavQ== X-Gm-Message-State: APjAAAUafDqOmai1kk8IOvnacEbQTtQkMrZ1tNk3JXIXCCVPyuY3kX/g 99GfwQ3ckMStWx9civcb++s8JqSikqU= X-Google-Smtp-Source: APXvYqyVAAXHja/U5eP788PMOUbgU0g6hSm3jxum3kbNKQ5GTv0emPNUnkmRw9BRUFC+aYdoBL09xA== X-Received: by 2002:a63:2fc4:: with SMTP id v187mr83677248pgv.55.1577896152344; Wed, 01 Jan 2020 08:29:12 -0800 (PST) Received: from neutron (node-1w7jr9qlfahmev9dakqkc7if6.ipv6.telus.net. [2001:569:74e0:7d00:c8c3:b228:84c0:5502]) by smtp.gmail.com with ESMTPSA id a12sm55084802pga.11.2020.01.01.08.29.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jan 2020 08:29:11 -0800 (PST) From: mike.rosset@gmail.com To: Hartmut Goebel Subject: Re: [PATCH] gnu: Add qtwebengine. References: <20191218204537.24069-1-mike.rosset@gmail.com> Date: Wed, 01 Jan 2020 08:29:11 -0800 In-Reply-To: (Hartmut Goebel's message of "Tue, 31 Dec 2019 14:10:08 +0100") Message-ID: <87v9pvkunc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35866 Cc: 35866@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hartmut Goebel writes: > Hi, > in addtion to other remarks: > > Am 18.12.19 um 21:45 schrieb Mike Rosset > > > + (uri > + (string-append "https://download.qt.io/official_releases/qt/" > + (substring version 0 4) > + "/" version "/submodules/" > + (string-append name "-everywhere-src-" version) > + ".tar.xz")) > > Please use the same code and formatting as sued for qtsvg. This helps keeping the code consistent. > > + `(modify-phases ,phases > + (replace 'configure > + (lambda* (#:key inputs outputs #:allow-other-keys) > + ;; Avoids potential race conditions > > I suggest to put this into *two* new phases: `patch-source` (or so) containing the substitute stuff, and `setup-configure` for setting the environment variables. > > > + (substitute* "src/core/web_engine_library_info.cpp" > + (("QLibraryInfo::location\\(QLibraryInfo::TranslationsPath\\)") > + (format #f "QLatin1String(\"~a\")" (string-append (assoc-ref outputs "out") "/share/qt5/translations"))) > + (("QLibraryInfo::location\\(QLibraryInfo::DataPath\\)") > + (format #f "QLatin1String(\"~a\")" (string-append (assoc-ref outputs "out") "/share/qt5")))) > > I suggest *not* using `format`, as we rarely use it in substitutes and you are using `string-append` anyway. I also suggest to define a variable `out` to be used here (same for `nss`, `udev` below) to avoid having `assic-ref` here, see [0] as an example. Then `format` might even be beneficial: > > + (format #f "QLatin1String(\"~a/share/qt5/translations\")" out) > > + (string-append "QLatin1String(\"" out "/share/qt5/translations\")") > > [0] > I have made all these changes as requested they should be in 0004 of series. I've re emailed the complete series. I believe there was an issue mailing 003. > > + ;; Valid QT_BUILD_PARTS variables are: > + ;; libs tools tests examples demos docs translations > + (invoke "qmake" "QT_BUILD_PARTS = libs tools" "--" > + "--webengine-printing-and-pdf=no" > + "--webengine-ffmpeg=system" > + "--webengine-icu=system" > + "--webengine-pepper-plugins=no"))))) > > Would setting `#:configure-flags` with "-DBUILD_TESTS=off" (see e.g. [1]) work, too, instead of passing "QT_BUILD_PARTS"? > > [1] It's possible that this might work. But I don't think it's worth the effort. I kept this in line qtsvg hopefully I can switch the tests on at one point. I have documented why the tests can not be run as of now. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 05 11:10:23 2020 Received: (at 35866) by debbugs.gnu.org; 5 Jan 2020 16:10:23 +0000 Received: from localhost ([127.0.0.1]:44515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1io8Tv-00014a-3V for submit@debbugs.gnu.org; Sun, 05 Jan 2020 11:10:23 -0500 Received: from mail-pg1-f182.google.com ([209.85.215.182]:40745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1io8Ts-00014N-La for 35866@debbugs.gnu.org; Sun, 05 Jan 2020 11:10:21 -0500 Received: by mail-pg1-f182.google.com with SMTP id k25so25704109pgt.7 for <35866@debbugs.gnu.org>; Sun, 05 Jan 2020 08:10:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ErZ4YbCywqkg0Ays5TWX+58jHIvP9k5rXM93kH1C0ck=; b=OsuBsz/ouqqM/FxoUav3A95nsw4AdptO9dlyDWkPIVW+mpuJkk6F/RzJeXS3SbK0Yt +Qrtvt4J0xv2xmSwufDtlWQc3Ugd/jzajnfvDFKRpzBUPVa77POVxyELIktdoiL+b0SI ObzPuwNiTdTgw2VCz+9CoL1nKlzPbVUZZkX90TwYTgNIB71yitbHuK/VW8bGBN8R5JSk Xh+I1rf7f39iPiwup88Jr1bLQNQQ4X4mozP1RL9pT1Osr2UQaJ7nxNvg3xKp3saWX4jX WbttZNjGHufDMdFhkJ0jCDzFFww4+ZuLHGiuIuNhugX29IHJ4oi6X9st0TiwOQe32gp7 5sYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ErZ4YbCywqkg0Ays5TWX+58jHIvP9k5rXM93kH1C0ck=; b=eVSereJebPFCoBjV81zwn2cKbYMQDXyGH1eygU8UCEwIV7TqwxrtMXERZt9IgpTSYN hTD5jXE/sBo55PsC+fSxzmBLek1As4AwFyige2PAYZ8iP70CKEv47+kBrBdqYaJQjT/u Xk0KZ4waM8Gpq/lc4Ea/G6iaSMfhT+S8Ovj4AwF6n+2hsBFRAwwHUjuZKSzqgKZRn+Bo p6fhu4OxxOUqt2sFdhbv/7nTvszxJe7bdjhKZhzwHGlHb0/KwM6e3FG5R5bMAe7R9rx5 0ole9VF0pvMJBWkEboLNAdXq0bCSGxBoEyIAKLn0/tR74RJrc7W1wvIG2caOMxCqMhht iluw== X-Gm-Message-State: APjAAAVhM3IOc/sQ09fEYQJQ2zX/uhjX/Z7ez6OcZgkybLxfMhVUMNwy 9T53L9GPGZVZIXByRQSoSoIUY48Z X-Google-Smtp-Source: APXvYqzme5FFTmkWmhCRdq7vCVSo31Ip9+FgX2L7Ny9v9qgsnV8CIK1SeBji3XHn5KFSeJ3C03LRYg== X-Received: by 2002:a63:d807:: with SMTP id b7mr109872390pgh.52.1578240614516; Sun, 05 Jan 2020 08:10:14 -0800 (PST) Received: from neutron (S010664777da04f43.vf.shawcable.net. [70.68.94.152]) by smtp.gmail.com with ESMTPSA id 207sm76600720pfu.88.2020.01.05.08.10.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jan 2020 08:10:13 -0800 (PST) From: mike.rosset@gmail.com To: Hartmut Goebel Subject: Re: qtwenengine anybody? References: <87a77sqtdq.fsf@ambrevar.xyz> <87immgqryj.fsf@gmail.com> <871rt4qnp9.fsf@gmail.com> <87immgp582.fsf@gmail.com> <5955729d-ef57-ffb8-feb8-36a9f53658a2@crazy-compilers.com> <87d0clpbt6.fsf@gmail.com> <87y2v7e0g4.fsf@ambrevar.xyz> <87v9qb56gg.fsf@gmail.com> <87sglfotvj.fsf@ambrevar.xyz> <87o8w354m5.fsf@gmail.com> <87blrod2so.fsf@ambrevar.xyz> <878smsd2pe.fsf@ambrevar.xyz> <87mub7krlq.fsf@gmail.com> <87tv5e9acb.fsf@ambrevar.xyz> <871rsilshf.fsf@gmail.com> <87imltk3mz.fsf@gmail.com> <31765744-6c8f-9fae-bc52-c79c6a3a370d@crazy-compilers.com> Date: Sun, 05 Jan 2020 08:10:12 -0800 In-Reply-To: <31765744-6c8f-9fae-bc52-c79c6a3a370d@crazy-compilers.com> (Hartmut Goebel's message of "Fri, 3 Jan 2020 15:57:45 +0100") Message-ID: <87v9ppdguz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 35866 Cc: Guix-devel , Pierre Neidhardt , 35866@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hartmut Goebel writes: > Am 02.01.20 um 21:24 schrieb mike.rosset@gmail.com: >> Apologies this is probably a failure in my ML workflow. And just my luck >> I'm in the process of doing some working related moving todoy. Here is a >> complete diff >> https://gitlab.com/mike.rosset/guix/compare/master...qtwebengine hope >> this helps. > > Many thanks, this is quite helpful. > > For me it looks okay except of two minor points: > > - The description should contain at least a brief note about Qt patched > the embedded chromium to (partially) un-google it. If you know details, > this would be great. This of course could be enhanced later, since > changing the description does not force a rebuild of he package. > > - Please still honor Ricardo's remark about DRM and phoning home. Hello Hartmut, I've upgraded the description field as request see attached. And CC to 35866@debbugs.gnu.org I've also addressed in depth some Ricardo's concerns. More then likely you will have problems applying this with git am again. This final declaration though based on my original submission. Was moved manually out and back in again. So there is probably inconsequential git history missing. I could create a new bug report maybe? Or you can still use the complete diff from https://gitlab.com/mike.rosset/guix/compare/master...qtwebengine --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0005-gnu-qtwebengine-description-field-now-notes-source-r.patch >From e67e9e7a6a6b346c9a99759ae75040735e5336d1 Mon Sep 17 00:00:00 2001 From: Mike Rosset Date: Sun, 5 Jan 2020 07:34:47 -0800 Subject: [PATCH 5/5] gnu: qtwebengine: description field now notes source re base summary To: 35866@debbugs.gnu.org * gnu/packages/qt.scm (qtwebengine)[description]: Note Qt Chromium source re base details. --- gnu/packages/qt.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index a4a039dc80..e199c67c4f 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -2154,8 +2154,9 @@ time Web content can be enhanced with native controls.") (files '("lib/qt5/libexec/QtWebEngineProcess"))))) (home-page "https://www.qt.io") (synopsis "Qt WebEngine module") - (description "Qt5WebEngine provides support for web -applications using the Chromium browser project.") + (description "Qt5WebEngine provides support for web applications using the +Chromium browser project. The Chromium source base has Google services and +binaries removed along with modular support for system libraries.") (license (package-license qt)))) -- 2.24.1 --=-=-= Content-Type: text/plain Mike --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 05 11:47:57 2020 Received: (at 35866) by debbugs.gnu.org; 5 Jan 2020 16:47:57 +0000 Received: from localhost ([127.0.0.1]:44547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1io94H-00022v-8b for submit@debbugs.gnu.org; Sun, 05 Jan 2020 11:47:57 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:50804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1io94E-00022j-Q6 for 35866@debbugs.gnu.org; Sun, 05 Jan 2020 11:47:55 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 47rPhT3Jxyz1qqkd; Sun, 5 Jan 2020 17:47:53 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 47rPhT2g3Nz1qrkC; Sun, 5 Jan 2020 17:47:53 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id hfwhPuBhHuQu; Sun, 5 Jan 2020 17:47:52 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-188-174-61-140.dynamic.mnet-online.de [188.174.61.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Sun, 5 Jan 2020 17:47:52 +0100 (CET) Received: from [192.168.110.31] (lenashee.fritz.box [192.168.110.31]) by hermia.goebel-consult.de (Postfix) with ESMTP id 58CD16023D; Sun, 5 Jan 2020 17:47:51 +0100 (CET) Subject: Re: qtwenengine anybody? To: mike.rosset@gmail.com References: <87a77sqtdq.fsf@ambrevar.xyz> <87immgqryj.fsf@gmail.com> <871rt4qnp9.fsf@gmail.com> <87immgp582.fsf@gmail.com> <5955729d-ef57-ffb8-feb8-36a9f53658a2@crazy-compilers.com> <87d0clpbt6.fsf@gmail.com> <87y2v7e0g4.fsf@ambrevar.xyz> <87v9qb56gg.fsf@gmail.com> <87sglfotvj.fsf@ambrevar.xyz> <87o8w354m5.fsf@gmail.com> <87blrod2so.fsf@ambrevar.xyz> <878smsd2pe.fsf@ambrevar.xyz> <87mub7krlq.fsf@gmail.com> <87tv5e9acb.fsf@ambrevar.xyz> <871rsilshf.fsf@gmail.com> <87imltk3mz.fsf@gmail.com> <31765744-6c8f-9fae-bc52-c79c6a3a370d@crazy-compilers.com> <87v9ppdguz.fsf@gmail.com> From: Hartmut Goebel Autocrypt: addr=h.goebel@crazy-compilers.com; prefer-encrypt=mutual; keydata= mQINBFJQM3oBEACiUXmMppc3+A7JpF3lPz8O/mRhfz1U6F4EOTlacTrCcm7Xg5U2JsPPNapV r5+vHnKBK+xbaX3s/A/G+SwrUZhi1X1HRnSNY1CqL8CT7rZmOtfjg4ExnOuCjie2bKhb9JKm lJ7MrNimIbNQoX1mRcQ4VMEflhyWfaPGbT73siuMkbr020ExhzW8T18JIC01SgWMULYMBXOB oGY21am/vaTFCK8bym1P4HVN8i64uOWL0agkAMHbju6SZtG2fYJ68eS3P/97bXRg1pveEdpa FgaFZhquecw4WdedwLwt1xNcjAg/p6tN73W3asEZTgMHa+iNzbJgcyhWpci09wQZfZ1uL0Hd M+ohng38ccgu9hJx6YzCN7Fe14JooKbPukG/WfClAgAzZSHRKpS4zGdGlg6D6EWayyWWoLR3 KoMA4LIIlaQbqaOhfe85b4mNgB1hqd0uRTHOah/6T+FUoSQ1IAeKLIDqj6rW7X4ISRn1CXGS LGDn2QKqR3KtU3cLf8hAeDeO7Qe1jTvLrG1Mfca8lEmC7/yN1gI7L4/cs6lhmXUgMaevuxss BxO2kkh0OS8HVFf+QQ7LZ5vt91yQVT9HVvOuVob0YtG+3rvkpMaHQilKloNoEkmMiHpwypBa IfAC6NP9smgionvvmQ5RWSEaH5/pfSUAYbqzWbqDxtqEF/mPOwARAQABtC1IYXJ0bXV0IEdv ZWJlbCA8aC5nb2ViZWxAY3JhenktY29tcGlsZXJzLmNvbT6JAj0EEwEKACcCGwMCHgECF4AF CwkIBwMFFQoJCAsFFgIDAQAFAluyK5QFCQ0kXxEACgkQe3UoEb93O2XMlw//Z2/aXbZO3lJv uvfDBU3fJBKxp87EButnuwudFyaNupKxO13R7rBKB/Oti/rNP7IlK56WwU10ldK6C1PYnqru 5L1VCjWRi2Jd/XlvgXlc1jqstbM7NfU7pGOzctJGYpKh+7b1EdSM4V1KnDKcbKicLKC7zS+d HUdsch5w5XJj+pZRE4R0KEA/vEBB4ba+m+b59WqzaLin2pOqyo4Ff9o5uVgxlNrLIJQsg74T MTQP8khyDLfmyiN42VVkOBOIPMLA8ljEA1I7I4WwW3bT3mxOXHUExey/YsOdpqYX+kh7u/tj 7kbjKQbdCwdwUqSOPLmW9/9Wxyf2/xi+3lCvxzwPPElnK62yKlxLhVMt+Ah3J2QeLmrVGG5X PQzplrmQ6ptpEC9evrK3ALBJ+UGGxyyLp7sPb0SbDq70tZLRtbcE6QnpQA2IQIPTTy40lGVy 3a3iXiDM7hzbljWS0XSaEHoZ/WdgKLV+OzVZ9vrhP+7HrK7hEzdYqCvNfcW6bk2KrMN0RxBB OAbiRne8E0iTffh9uTyW7sAE0UDA9J3KtD3fpkld9cQrhwUVsjuPfbCqnhCk0B7ro1OR0DHB bgMVEylEsACnHEU4XWvo+U+0MgJtDQjzIy+XZfXDCs1VOy+murgcs0YIFqesyYOaaF1eP1S0 Yr18n/pfAPCFfg0rhMQUyoK5Ag0EUlAzegEQAL3lOz+uhHudEvovJVdExl+MTHLpYcajA0QL zDXe0jiAYdB+Jpvm7CAKani61/eo1SnHyRORELjxl/fL3ytjg3yRvVAM2I+xg7lIB4qXL5rR 5K8iF4px/jYV2CBIiwOKQ6gVEVk2hpl/tPqP3QdOKXdLu3sOM1Ygg3PN5fc+I7B6luchx6Bu 7NAR7nWKn6D1NdOI1UZL6Dr6Me/6hNVJBGvDF3Fm2x0CoIHujFksfOxZtwoZMXn13N18ZDyQ OMA89eHNQlFri9i5xG3laMAW2M0bozf+FwTBXomIWkT2Tkj3omW8ZIcfags2SpRkQl45pE65 nLKK36eRNoNbBovqKalMyhKstFTpIjjTZRMI5EZ87j7gYX/ghCss2LZz4X0WfvH6lYt8Yvjv I9Stl4ENvNukQZSZgIpaaAgZceXyuLaj+FY1cVXK3AoTh+lordfXr3TSBxlb1z7cNHqsI9vd RwsfC+Ng+yRrNGnNw008fgDq9fhaZus1krtPQzTyJzMw9xnLKuHhHFbkHDaW1Gb9dnECBF8a T0kjffgENEa5K6bfyAGGZ5zikBuK9EZdIQ0KgLP55hdnY7PigXazSsvYxVB62+B0kRYxjyM7 UAX55+QeD7pkPhBmRozeNYZzQxu9cyeD83e1Yf7ddnBkkLXVyTzKIutGh2R2BkcmkbBKTv27 ABEBAAGJAjwEGAEKACYCGwwWIQTUrYucFnt1fE8I6Hd7dSgRv3c7ZQUCW7IswAUJDSRgPgAK CRB7dSgRv3c7ZbFUD/97iHXgPYSZWyZ9r8pgpRuyoIK2TKmClUxck1a0WUkTMjzi0gW4kOIj 2wNOUnsRqioxOVXAg0R9ix1l6+LBC8+m/VFoR37BYQsC5WrzkmeaFChrBPs+YlND0V7TWNq0 elBvsNuApVxSOzaJuxCnH9WLe3s4fIveymScNAZOm31DHgmkDcb1/NXg97nohqSeW+k3eQbh borMRT3kMaXrPTI8qal9TsYf6KhfPi61fbnGW6bNJ0LnWQj2b7nb6nIR99cr0sNymqOsC6Gq 0yHhTceRl2/DRBe+QCxoiFKs1s6f7Af+U9r/JkHfdOLCRxjmAyl22zlhmBeNlGSvDbJqy5AE 7fKo1/mVQ2CNskF0BcOhrrntVf4A1gy3OlIXnCV//HH6w7qRBpw0inpD5c9Ny20aNdo8mS3y szcGZLczkdx8qzYEXBCO8zSDiRllrf6e8H5AaQdtHInxQ2Ywdqz/Ho81irbcPaHwI7P9/qvm zYnPZ3ULNlrI/+mq0oYkCB8oB9HW0C/YGZ/nIYY0vxDoy6n6EhEzntdAjF6Pav+QHB216fBs LMLs8X4+PXOc+MaAmQQTyTF9C8vfQk86E4eRmQErYw0aYVR7bUqyYfX8e2c5geqeSm6O+Brv 6LQtDbOJIcmJW1NS8XVmDG9JmkbtYqhnRDQMT+YFJircfDYmUvL4Ww== Organization: crazy-compilers.com Message-ID: <29d9ff25-4674-8125-96e0-a439af1cd04d@crazy-compilers.com> Date: Sun, 5 Jan 2020 17:47:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <87v9ppdguz.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 35866 Cc: Guix-devel , Pierre Neidhardt , 35866@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Mike, > I've upgraded the description field as request see attached. And CC to > 35866@debbugs.gnu.org > > I've also addressed in depth some Ricardo's concerns. For me this would be okay. Ricardo needs to state whether his concerns are covered. > https://gitlab.com/mike.rosset/guix/compare/master...qtwebengine This was perfectly fine for reviewing. Thanks. -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 23 19:16:44 2020 Received: (at 35866-done) by debbugs.gnu.org; 24 Jan 2020 00:16:44 +0000 Received: from localhost ([127.0.0.1]:53330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iumeR-0003CT-RC for submit@debbugs.gnu.org; Thu, 23 Jan 2020 19:16:44 -0500 Received: from mail-pg1-f174.google.com ([209.85.215.174]:43011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iumeP-0003C9-Mp for 35866-done@debbugs.gnu.org; Thu, 23 Jan 2020 19:16:42 -0500 Received: by mail-pg1-f174.google.com with SMTP id u131so69809pgc.10 for <35866-done@debbugs.gnu.org>; Thu, 23 Jan 2020 16:16:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:in-reply-to:message-id:user-agent:mime-version; bh=cMrcV7bT7RevUZeLT1lZeP1mDGa93H8Yu0rGVOBuczw=; b=FQ0sxuOnND8qolhajHCtsTqFvJBTd2X9Ovrxfj0ChCBa91xDhYOLG4fVyCaLTThRQC mCo3CRXapTpobKOarfpXVNy4UP8o24WBnEcDrCjgwxf9usvYDeDGYvA9qXAkbb/Mqe7Y UDoVKeKzV5a75OSZeIk5ocgpZbvZIwlKQq/XiXR73k510Ki2SguoBFMut3AeEh76qMhy awRBSN5NW60Pc5WiKL0fGx/ly6kRH+NOMk9k4N+8Nebl+hIYxwcmSixeLA2SHNCEY0Py kppa3pvmAkqDdmGB6EGpyoSECBPCWsNIlj7hQHDkTXsuE5sxwxVCBx5wUjGFJH8y9urn 1WYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:in-reply-to:message-id :user-agent:mime-version; bh=cMrcV7bT7RevUZeLT1lZeP1mDGa93H8Yu0rGVOBuczw=; b=Jx+iVaQq06tM0uIa5DuCbzhwdO8q6a1WC7Qqvji7Q7fO+qAvb8s3F7oMZmr5aXX8Em Pqtba5/jYHgofYKf5C5jSIvArQX+rzMWieIgrP+6yTofUjynh1XT4vYRGoOWLb117MVp Sx/00SGwZbZCd1PMxYc6mTxYcVaHYe2qoTWa+K2rxIe/+2oPImCTBgzWLxl6BjStRj9d u4xOBdzi2IrxRKB5xIeLCTi+SfFtUHpHi/purJI2VamaIvhpncof1xMaLxVdCWXHcm49 wOgmZmOi3jP1iwLkjQ5zASeOtOR+6QTJUw8DZYcfjCNan8XkG+vFr5CLegNQyD9vIs6/ tbvA== X-Gm-Message-State: APjAAAUursEd+6f4RyiXrb+hepMzzJWT/up3iNOa4tjIaQp90Nxtqp6/ qBR+SU+aDiYZ/Q4TYq0n8gvz+Qvi X-Google-Smtp-Source: APXvYqyvwp2W9ePRo3pbXDCb95g2ratXGbEQr4YJp5MhSsVvMCWKZ94dtdXzFXRfZuPssEfBvetkiw== X-Received: by 2002:a63:4b24:: with SMTP id y36mr1068250pga.176.1579824995647; Thu, 23 Jan 2020 16:16:35 -0800 (PST) Received: from neutron (S010664777da04f43.vf.shawcable.net. [70.68.94.152]) by smtp.gmail.com with ESMTPSA id 7sm3896058pfx.52.2020.01.23.16.16.34 for <35866-done@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jan 2020 16:16:35 -0800 (PST) From: Mike Rosset To: bug#35866 <35866-done@debbugs.gnu.org> Subject: Re: Status: [PATCH] gnu: Add qtwebengine. Date: Thu, 23 Jan 2020 16:16:30 -0800 In-Reply-To: bug's message of "Fri\, 24 Jan 2020 00\:13\:54 +0000" Message-ID: <87pnf9emjl.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: merged Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (mike.rosset[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.215.174 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.215.174 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 FAKE_REPLY_C No description available. 2.5 BODY_SINGLE_WORD Message body is only one word (no spaces) X-Debbugs-Envelope-To: 35866-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: merged Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.215.174 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.215.174 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (mike.rosset[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 FAKE_REPLY_C No description available. 2.5 BODY_SINGLE_WORD Message body is only one word (no spaces) merged From unknown Fri Jun 13 10:50:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 21 Feb 2020 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator