GNU bug report logs - #35854
[PATCH] lxqt: lxqt-panel: fix taskbar plugin's application list issue.

Previous Next

Full log

Message #13 received at 35854-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Reza Alizadeh Majd <r.majd <at> pantherx.org>
Cc: 35854-done <at> debbugs.gnu.org
Subject: Re: [bug#35854] [PATCH] lxqt: lxqt-panel: fix taskbar plugin's
 application list issue.
Date: Fri, 24 May 2019 18:05:03 +0200

[Message part 1 (text/plain, inline)]

Reza Alizadeh Majd <r.majd <at> pantherx.org> skribis:

> * gnu/packages/lxqt.scm (lxqt-panel): move `kwindowsystem` from `inputs`
> to `propagated-inputs`

Applied, but I added a comment based on your message (see below).  In
general, ‘propagated-inputs’ should be used only when strictly
necessary, so when we use them, it’s important to add comments
explaining why we do so.

Thanks for the patch!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index c3b25e5417..a8699b3d09 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -583,7 +583,9 @@ of other programs.")
        ("lxqt-build-tools" ,lxqt-build-tools)
        ("qttools" ,qttools)))
     (propagated-inputs
-      `(("kwindowsystem" ,kwindowsystem)))
+     ;; Propagating KWINDOWSYSTEM so that the list of opened applications
+     ;; shows up in lxqt-panel's taskbar plugin.
+     `(("kwindowsystem" ,kwindowsystem)))
     (arguments
      '(#:tests? #f                      ; no tests
        #:phases

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.