Subject: bug#35854: closed (Re: [bug#35854] [PATCH] lxqt: lxqt-panel: fix taskbar plugin's application list issue.)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 24 May 2019 16:06:02 +0000

Your bug report

#35854: [PATCH] lxqt: lxqt-panel: fix taskbar plugin's application list issue.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
35854: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35854
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#35854] [PATCH] lxqt: lxqt-panel: fix taskbar plugin's application list issue.
From: Ludovic Courtès <[email-masked]>
To: Reza Alizadeh Majd <[email-masked]>
Cc: [email-masked]
Date: Fri, 24 May 2019 18:05:03 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Reza Alizadeh Majd <[email-masked]> skribis:

> * gnu/packages/lxqt.scm (lxqt-panel): move `kwindowsystem` from `inputs`
> to `propagated-inputs`

Applied, but I added a comment based on your message (see below).  In
general, ‘propagated-inputs’ should be used only when strictly
necessary, so when we use them, it’s important to add comments
explaining why we do so.

Thanks for the patch!

Ludo’.

diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index c3b25e5417..a8699b3d09 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -583,7 +583,9 @@ of other programs.")
        ("lxqt-build-tools" ,lxqt-build-tools)
        ("qttools" ,qttools)))
     (propagated-inputs
-      `(("kwindowsystem" ,kwindowsystem)))
+     ;; Propagating KWINDOWSYSTEM so that the list of opened applications
+     ;; shows up in lxqt-panel's taskbar plugin.
+     `(("kwindowsystem" ,kwindowsystem)))
     (arguments
      '(#:tests? #f                      ; no tests
        #:phases

Subject: [PATCH] lxqt: lxqt-panel: fix taskbar plugin's application list issue.
From: Reza Alizadeh Majd <[email-masked]>
To: [email-masked]
Cc: Reza Alizadeh Majd <[email-masked]>
Date: Wed, 22 May 2019 11:57:16 +0430
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/lxqt.scm (lxqt-panel): move `kwindowsystem` from `inputs`
to `propagated-inputs`
---
 gnu/packages/lxqt.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index d91efe715d..a03a93e5c5 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -7,6 +7,7 @@
 ;;; Copyright © 2018, 2019 Tobias Geerinckx-Rice <[email-masked]>
 ;;; Copyright © 2018, 2019 Meiyo Peng <[email-masked]>
 ;;; Copyright © 2018 Ricardo Wurmus <[email-masked]>
+;;; Copyright © 2019 Reza Alizadeh Majd <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -559,7 +560,6 @@ of other programs.")
     (inputs
      `(("alsa-lib" ,alsa-lib)
        ("kguiaddons" ,kguiaddons)
-       ("kwindowsystem" ,kwindowsystem)
        ("libdbusmenu-qt" ,libdbusmenu-qt)
        ("liblxqt" ,liblxqt)
        ("libqtxdg" ,libqtxdg)
@@ -582,6 +582,8 @@ of other programs.")
      `(("pkg-config" ,pkg-config)
        ("lxqt-build-tools" ,lxqt-build-tools)
        ("qttools" ,qttools)))
+    (propagated-inputs
+      `(("kwindowsystem" ,kwindowsystem)))
     (arguments
      '(#:tests? #f                      ; no tests
        #:phases
-- 
2.19.0