From debbugs-submit-bounces@debbugs.gnu.org Tue May 21 09:02:09 2019 Received: (at submit) by debbugs.gnu.org; 21 May 2019 13:02:10 +0000 Received: from localhost ([127.0.0.1]:38933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hT4PB-0002bn-Lo for submit@debbugs.gnu.org; Tue, 21 May 2019 09:02:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38533) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hT4P9-0002bZ-PW for submit@debbugs.gnu.org; Tue, 21 May 2019 09:02:08 -0400 Received: from lists.gnu.org ([209.51.188.17]:35311) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hT4P4-0000a0-Ek for submit@debbugs.gnu.org; Tue, 21 May 2019 09:02:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hT4P3-0002V0-Dy for bug-gnu-emacs@gnu.org; Tue, 21 May 2019 09:02:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hT4P1-0000Xp-23 for bug-gnu-emacs@gnu.org; Tue, 21 May 2019 09:02:00 -0400 Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]:46650) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hT4P0-0000V6-Of for bug-gnu-emacs@gnu.org; Tue, 21 May 2019 09:01:58 -0400 Received: by mail-qt1-x82c.google.com with SMTP id z19so20238823qtz.13 for ; Tue, 21 May 2019 06:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=clIeuM3nu4hiZ4LiufZmFNxWAuX39+SBuGxqX9GbaCI=; b=eF5hw1kZXzHvrQI5uSaaYvDvvDWw+eHwsQyBio+Q/Hl/7P9dYAyK+PiGud0zJFKA3k rUU0xSmq0KqFAJLv2kjxog5AmDTv0zSK98HvCE2/nrHF+5s72mjE52Rts53RhTd9TDHD zZsion34xtcgnvVX2UK2YpMIgvLZnURGrrQnifHia9Kz77QtvcNnNG2lGxKXK08NfK3L N0Ymq6Y5lNvBrBuUgVR2Dq6CT68q3DgmoNkJuA0w8Xtt8+9gJv+ROzWC+a2PgJVZ28V4 BTTmuO4a5LGcYyqKYx9WPAGGZYgVPp1jVr0Th5RlsT47GgNgMC0USgYCJ5C9R4M+7xhs jnSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=clIeuM3nu4hiZ4LiufZmFNxWAuX39+SBuGxqX9GbaCI=; b=GkclKk/X85ISs0sGtcef9pUhqWGFW1oDGJRiDfjzkZ9sZ2wxuDv7HsdS0usaYI2zYE v7vI3YA2vWuuRXJR61ECHBmWbJE8pmKLS9zUubn8vNMXBoXfIjgK4pNHq45H95zi/0xu NfXgSW4vObwooS04Ui5dvIbiwxCxopT3XjtM8q3rlJquTD8DqiiQKbtP/jVMlrwQyfAr 27iyJ5Iz6TUHOHe0USupk1n1qp9r3FoZbhb+CGQ7cAYwp/8VHvdQlAAsx/s8kf8gxiyF oPBEX02e4+wzg97vfftdNYxapY3y/ustF4uoN2A4YaMeKSsta0hLBf+7+CMgyoA5V+TE ktCw== X-Gm-Message-State: APjAAAXCMosdOkEavi+eSNteNgowq3Isu7NJXLy1OWx/+abymkavFI/0 63giMz5WZic85XmVoO/dEXZrVrW6vrGHR9IEBqgIE+lGTpqPTA== X-Google-Smtp-Source: APXvYqxX5x2CZp+hjLt6Uzrbjwi5NTLHKMrGKGzv67+vJDpscgzOVrYcTHkGvyoZlKu5VFg7rAjQkPi+8QO/k3A7jvY= X-Received: by 2002:a0c:d251:: with SMTP id o17mr63711638qvh.181.1558443714945; Tue, 21 May 2019 06:01:54 -0700 (PDT) MIME-Version: 1.0 From: Taegil Bae Date: Tue, 21 May 2019 22:01:38 +0900 Message-ID: Subject: PNG warning: Interlace handling should be turned on when using png_read_image To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::82c X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, I got the following warning in Messages buffer: PNG warning: Interlace handling should be turned on when using png_read_image This is caused by the spacemacs log, which is an interlaced png image. According to the libpng source code, a caller to png_read_update_info(), png_read_image() has to turn on interlace handling. After I patched emacs source code as below, the PNG waring disappeared: diff --git a/src/image.c b/src/image.c index 35ca3e2d66d..e0f6bbcc581 100644 --- a/src/image.c +++ b/src/image.c @@ -6214,6 +6214,8 @@ png_load_body (struct frame *f, struct image *img, struct png_load_context *c) } /* Update info structure. */ + if (png_get_interlace_type(png_ptr, info_ptr) != PNG_INTERLACE_NONE) + png_set_interlace_handling(png_ptr); png_read_update_info (png_ptr, info_ptr); /* Get number of channels. Valid values are 1 for grayscale images Best regards, Taegil From debbugs-submit-bounces@debbugs.gnu.org Tue May 21 11:56:17 2019 Received: (at 35843-done) by debbugs.gnu.org; 21 May 2019 15:56:17 +0000 Received: from localhost ([127.0.0.1]:40666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hT77h-0001I5-9s for submit@debbugs.gnu.org; Tue, 21 May 2019 11:56:17 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:54562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hT77e-0001Hn-Fr for 35843-done@debbugs.gnu.org; Tue, 21 May 2019 11:56:16 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 73BCF161BC1; Tue, 21 May 2019 08:56:07 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Kv1y63K1XdEw; Tue, 21 May 2019 08:56:06 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 28ACB161BC4; Tue, 21 May 2019 08:56:06 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id vP3owFY3iJfl; Tue, 21 May 2019 08:56:06 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id D9480161B58; Tue, 21 May 2019 08:56:05 -0700 (PDT) To: Taegil Bae From: Paul Eggert Subject: PNG warning: Interlace handling should be turned on when using, png_read_image Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: Date: Tue, 21 May 2019 08:56:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------687029353096963AAD5128F3" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35843-done Cc: 35843-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------687029353096963AAD5128F3 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for reporting the problem. It's not clear why interlace handling needs to be enabled manually when GNU Emacs will merely read the whole image (isn't libpng smart enough to do that on its own?) but I guess it's better to pacify libpng, if only to prevent users from worrying. I installed the attached patch. --------------687029353096963AAD5128F3 Content-Type: text/x-patch; name="0001-Pacify-libpng-on-interlaced-images-Bug-35843.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Pacify-libpng-on-interlaced-images-Bug-35843.patch" >From eeebdc49c0e113f1dd31b11c6addbc7082a406d6 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Tue, 21 May 2019 08:51:48 -0700 Subject: [PATCH] Pacify libpng on interlaced images (Bug#35843) * src/image.c (png_set_interlace_handling) [WINDOWSNT]: New function to link. (init_png_functions): Link it. (png_load_body): Call it before calling png_read_update_info. --- src/image.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/image.c b/src/image.c index 35ca3e2d66..57b405f6db 100644 --- a/src/image.c +++ b/src/image.c @@ -5802,6 +5802,7 @@ DEF_DLL_FN (png_uint_32, png_get_valid, (png_structp, png_infop, png_uint_32)); DEF_DLL_FN (void, png_set_strip_16, (png_structp)); DEF_DLL_FN (void, png_set_expand, (png_structp)); DEF_DLL_FN (void, png_set_gray_to_rgb, (png_structp)); +DEF_DLL_FN (int, png_set_interlace_handling, (png_structp)); DEF_DLL_FN (void, png_set_background, (png_structp, png_color_16p, int, int, double)); DEF_DLL_FN (png_uint_32, png_get_bKGD, @@ -5840,6 +5841,7 @@ init_png_functions (void) LOAD_DLL_FN (library, png_set_strip_16); LOAD_DLL_FN (library, png_set_expand); LOAD_DLL_FN (library, png_set_gray_to_rgb); + LOAD_DLL_FN (library, png_set_interlace_handling); LOAD_DLL_FN (library, png_set_background); LOAD_DLL_FN (library, png_get_bKGD); LOAD_DLL_FN (library, png_read_update_info); @@ -5875,6 +5877,7 @@ init_png_functions (void) # undef png_set_background # undef png_set_expand # undef png_set_gray_to_rgb +# undef png_set_interlace_handling # undef png_set_longjmp_fn # undef png_set_read_fn # undef png_set_sig_bytes @@ -5899,6 +5902,7 @@ init_png_functions (void) # define png_set_background fn_png_set_background # define png_set_expand fn_png_set_expand # define png_set_gray_to_rgb fn_png_set_gray_to_rgb +# define png_set_interlace_handling fn_png_set_interlace_handling # define png_set_longjmp_fn fn_png_set_longjmp_fn # define png_set_read_fn fn_png_set_read_fn # define png_set_sig_bytes fn_png_set_sig_bytes @@ -6213,7 +6217,7 @@ png_load_body (struct frame *f, struct image *img, struct png_load_context *c) } } - /* Update info structure. */ + png_set_interlace_handling (png_ptr); png_read_update_info (png_ptr, info_ptr); /* Get number of channels. Valid values are 1 for grayscale images -- 2.21.0 --------------687029353096963AAD5128F3-- From unknown Sun Aug 17 10:17:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 19 Jun 2019 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator