GNU bug report logs - #35813
[PATCH] import: crate: add recursive option

Previous Next

Full log

Message #11 received at 35813 <at> debbugs.gnu.org (full text, mbox):

From: Ivan Petkov <ivanppetkov <at> gmail.com>
To: 35813 <at> debbugs.gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>,
 Karl Meakin <karl.w.f.meakin <at> gmail.com>, Karl Meakin <Karlwfmeakin <at> gmail.com>
Subject: Re: [bug#35813] [PATCH] import: crate: add recursive option
Date: Sat, 25 May 2019 12:38:08 -0700

[Message part 1 (text/plain, inline)]

Hi Karl,

Thanks for the patch, overall the implementation looks good to me!

> On May 24, 2019, at 8:42 AM, Ludovic Courtès <ludo <at> gnu.org> wrote:
> 
> would it be possible to augment ‘tests/crate.scm’ with tests for
> recursive imports?  That would be great.

I second Ludo’s comment here, having some tests around this would be great!

Also, have you had a chance to test this by importing a Rust application?
I tried to import hexyl (which has a small dependency closure compared to other
applications), but the final result had some missing crate input definitions
(e.g. Maybe a crate depends on rust-foo, but rust-foo wasn't defined in the
output either). Maybe I did something wrong, but it would be good to confirm!

Also, don't worry about actually trying to build any imported packages as of
yet, you might hit a cycle issue between proc-macro2 and quote. I've got a
patch open[0] for fixing the cargo-build-system to handle this!

--Ivan

[0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35318 <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35318>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.