GNU bug report logs - #35812
[PATCH] fix hackage cabal tests

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Robert Vollmert <rob <at> vllmrt.net>
Subject: bug#35812: closed (Re: [bug#35812] [PATCH] fix hackage cabal tests)
Date: Sun, 26 May 2019 21:24:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#35812: [PATCH] fix hackage cabal tests

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 35812 <at> debbugs.gnu.org.

-- 
35812: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35812
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Robert Vollmert <rob <at> vllmrt.net>
Cc: 35812-done <at> debbugs.gnu.org
Subject: Re: [bug#35812] [PATCH] fix hackage cabal tests
Date: Sun, 26 May 2019 23:23:27 +0200

Hi,

Robert Vollmert <rob <at> vllmrt.net> skribis:

>> On 21. May 2019, at 16:48, Ludovic Courtès <ludo <at> gnu.org> wrote:
>> Robert Vollmert <rob <at> vllmrt.net> skribis:
>> 
>>> Hackage cabal tests didn’t run independently due to memoization,
>>> and test-cabal-6 was failing.
>> 
>> I don’t think memoization can get in the way here: the argument list is
>> used as a key in the memoization hash table.  Thus, if you pass
>> different arguments, you get a cache miss and call the underlying
>> procedure.
>> 
>> Or am I missing something?
>
> I agree that memoization of a pure function shouldn’t have such effects,
> but my (limited) understanding is that hackage->guix-packages would
> cache import results by package name on the assumption that cabal
> files for the same package name don’t change between calls.

Oh, got it.

I pushed a variant of the patch as commit
ad7466aafd7f166d0b6be5eb32dda1d3ee8a6445.

Thanks!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Robert Vollmert <rob <at> vllmrt.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] fix hackage cabal tests
Date: Mon, 20 May 2019 21:06:59 +0200

[Message part 4 (text/plain, inline)]

Hackage cabal tests didn’t run independently due to memoization,
and test-cabal-6 was failing.

Let me know if anything should be done differently.

[0001-tests-fix-cabal-tests-to-test-and-pass.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.