GNU bug report logs - #35804
[PATCH] libnotify didn't have propagated-inputs

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Uko Kokņevičs <perkontevs <at> gmail.com>
Subject: bug#35804: closed (Re: [bug#35804] [PATCH] libnotify didn't have
 propagated-inputs)
Date: Tue, 21 May 2019 15:30:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#35804: [PATCH] libnotify didn't have propagated-inputs

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 35804 <at> debbugs.gnu.org.

-- 
35804: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35804
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Marius Bakke <mbakke <at> fastmail.com>
To: Uko Kokņevičs <perkontevs <at> gmail.com>,
 35804-done <at> debbugs.gnu.org
Subject: Re: [bug#35804] [PATCH] libnotify didn't have propagated-inputs
Date: Tue, 21 May 2019 17:29:39 +0200

[Message part 3 (text/plain, inline)]

Hi Uko,

Uko Kokņevičs <perkontevs <at> gmail.com> writes:

> libnotify doesn't propagate other needed libraries for linking against
> it resulting in pkg-config errors like
>
>> Package gdk-pixbuf-2.0 was not found in the pkg-config search path.
>> Perhaps you should add the directory containing `gdk-pixbuf-2.0.pc'
>> to the PKG_CONFIG_PATH environment variable
>
> The following patch should fix that.

Thank you!  I added a commit message that follows our convention, and
left a comment in the code explaining why these have to be propagated.

Pushed as 7ef08efa21900e6e43415b9f9db0e51a04e17fa5.

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Uko Kokņevičs <perkontevs <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] libnotify didn't have propagated-inputs
Date: Mon, 20 May 2019 02:23:30 +0300

libnotify doesn't propagate other needed libraries for linking against
it resulting in pkg-config errors like

> Package gdk-pixbuf-2.0 was not found in the pkg-config search path.
> Perhaps you should add the directory containing `gdk-pixbuf-2.0.pc'
> to the PKG_CONFIG_PATH environment variable

The following patch should fix that.


From 4cb942cd6b5389c29fa80d9af8442c3fa364406f Mon Sep 17 00:00:00 2001
From: Uko Koknevics <perkontevs <at> gmail.com>
Date: Mon, 20 May 2019 01:49:05 +0300
Subject: [PATCH] Added propagated-inputs to libnotify

---
 gnu/packages/gnome.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 9070673..9c0cce9 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -1108,10 +1108,11 @@ configuring CUPS.")
        (base32
         "017wgq9n00hx39n0hm784zn18hl721hbaijda868cm96bcqwxd4w"))))
     (build-system gnu-build-system)
-    (inputs
+    (propagated-inputs
      `(("gdk-pixbuf" ,gdk-pixbuf)
-       ("glib" ,glib)
-       ("gtk+" ,gtk+)
+       ("glib" ,glib)))
+    (inputs
+     `(("gtk+" ,gtk+)
        ("libpng" ,libpng)))
     (native-inputs
       `(("pkg-config" ,pkg-config)
--
2.21.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.