GNU bug report logs - #35790
[PATCH] scripts: lint: Handle warnings with a record type.

Previous Next

Package: guix-patches;

Reported by: Christopher Baines <mail <at> cbaines.net>

Date: Sat, 18 May 2019 09:43:02 UTC

Severity: normal

Tags: patch

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

Full log

Message #44 received at 35790 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 35790 <at> debbugs.gnu.org
Subject: Re: [bug#35790] [PATCH] scripts: lint: Separate the message warning
 text and data.
Date: Mon, 24 Jun 2019 10:36:43 +0200

Hello,

Christopher Baines <mail <at> cbaines.net> skribis:

> +(define-syntax make-warning
> +  (syntax-rules (G_)
> +    ((_ package (G_ message) rest ...)
> +     (%make-warning package message rest ...))
> +    ((_ package message rest ...)
> +     (%make-warning package message rest ...))))

I think you can remove the second clause: that will ensure we never
forget to add a G_ around messages.

Otherwise LGTM!

Ludo’.
This bug report was last modified 6 years and 30 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.