GNU bug report logs - #35790
[PATCH] scripts: lint: Handle warnings with a record type.

Previous Next

Package: guix-patches;

Reported by: Christopher Baines <mail <at> cbaines.net>

Date: Sat, 18 May 2019 09:43:02 UTC

Severity: normal

Tags: patch

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 35790 <at> debbugs.gnu.org
Subject: [bug#35790] [PATCH] scripts: lint: Handle warnings with a record type.
Date: Fri, 07 Jun 2019 09:44:33 +0200
Hello,

Christopher Baines <mail <at> cbaines.net> skribis:

> Rather than emiting warnings directly to a port, have the checkers return the
> warning or warnings.
>
> This makes it easier to use the warnings in different ways, for example,
> loading the data in to a database, as you can work with the <lint-warning>
> records directly, rather than having to parse the output to determine the
> package and location.

I like it!

Maybe we should just ignore the i18n issue for now and keep
already-translated messages in <lint-warning>.

One question I have: before, warnings would be emitted as we go; now, we
first collect all the warnings for a given package, and emit all of them
at once.  How does it look in terms of UX?

Perhaps an improvement would be to use SRFI-41 streams instead of lists
to address this issue, but… future work.  :-)

WDYT?

Ludo’.




This bug report was last modified 6 years and 30 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.