Subject: Re: bug#35784: emacs 26 crash

From: Noam Postavsky <[email-masked]>
Date: Sun, 19 May 2019 13:11:40 -0400

tags 35784 + patch
quit

martin rudalics <[email-masked]> writes:

>>> -  if (WINDOWP (object))
>>> +  if (WINDOW_LIVE_P (object))
>>>       {
>>>         struct window *w = XWINDOW (object);
>>>         mark_window_display_accurate (object, false);
>>
>> Thanks, this fix is fine with me.  Martin?
>
> Fine with me as well.

For emacs-26, I presume?

>From 1a05e19a2eab5a3b36e27f11ec39b857aff09cde Mon Sep 17 00:00:00 2001
From: Noam Postavsky <[email-masked]>
Date: Sun, 19 May 2019 13:05:55 -0400
Subject: [PATCH] Don't segfault on force-window-update of deleted window

* src/window.c (Fforce_window_update): Do nothing for deleted
windows (Bug#35784).
---
 src/window.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/window.c b/src/window.c
index dfac3b5b87..4d5ddeea14 100644
--- a/src/window.c
+++ b/src/window.c
@@ -3637,7 +3637,7 @@ displaying that buffer.  */)
       return Qt;
     }
 
-  if (WINDOWP (object))
+  if (WINDOW_LIVE_P (object))
     {
       struct window *w = XWINDOW (object);
       mark_window_display_accurate (object, false);
-- 
2.11.0