Subject: Re: bug#35770: [PATCH] Broken duplicate case elimination in switch byte-compilation

From: Noam Postavsky <[email-masked]>
Date: Sat, 01 Jun 2019 09:58:42 -0400

Mattias Engdegård <[email-masked]> writes:

> Trying to revert 'the rest' (the switch code generation) while keeping
> the switch op itself seems indeed to be risky and a lot of work
> compared to just turning off the generation. It is not a matter of
> finding a few commits to revert; there are fixes upon fixes, and
> changes that need to be untangled. It does not sound very practical.

So, is this patch okay for emacs-26?

>From 257a750a10ebb77277a5d7d771c01d66a69a66e4 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <[email-masked]>
Date: Sat, 1 Jun 2019 09:53:35 -0400
Subject: [PATCH] Disable byte-compile-cond-use-jump-table (Bug#35770)

* lisp/emacs-lisp/bytecomp.el (byte-compile-cond-use-jump-table): Set
to nil by default.

Don't merge to master, the bug is already fixed there.
---
 lisp/emacs-lisp/bytecomp.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index e3b34c189f..9273626c80 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -234,9 +234,9 @@ (defcustom byte-compile-delete-errors nil
   :group 'bytecomp
   :type 'boolean)
 
-(defcustom byte-compile-cond-use-jump-table t
+(defcustom byte-compile-cond-use-jump-table nil
   "Compile `cond' clauses to a jump table implementation (using a hash-table)."
-  :version "26.1"
+  :version "26.3" ;; Disabled due to Bug#35770.
   :group 'bytecomp
   :type 'boolean)
 
-- 
2.11.0