GNU bug report logs - #35756
[PATCH] file-size-human-readable: fix glitches and add optional space

Previous Next

Package: emacs;

Reported by: Mattias Engdegård <mattiase <at> acm.org>

Date: Wed, 15 May 2019 20:11:01 UTC

Severity: minor

Tags: patch

Done: Mattias Engdegård <mattiase <at> acm.org>

Bug is archived. No further changes may be made.

Full log


Message #21 received at 35756-done <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattiase <at> acm.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 35756-done <at> debbugs.gnu.org
Subject: Re: bug#35756: [PATCH] file-size-human-readable: fix glitches and add
 optional space
Date: Sun, 23 Jun 2019 20:29:47 +0200
23 juni 2019 kl. 18.56 skrev Lars Ingebrigtsen <larsi <at> gnus.org>:
> 
> Looks good to me.  The only thing is:
> 
> In end of data:
> files.el:7717:1:Warning: the function `string-empty-p' is not known to be
>    defined.
> 
> That function is from subr-x, and I if I remember correctly, files.el
> isn't supposed to load that file...

Thanks, pushed with that function call eliminated in favour of (string= x "").





This bug report was last modified 5 years and 331 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.