GNU bug report logs - #35756
[PATCH] file-size-human-readable: fix glitches and add optional space

Previous Next

Full log

View this message in rfc822 format

From: Mattias Engdegård <mattiase <at> acm.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 35756 <at> debbugs.gnu.org
Subject: bug#35756: [PATCH] file-size-human-readable: fix glitches and add optional space
Date: Fri, 17 May 2019 13:01:19 +0200

[Message part 1 (text/plain, inline)]

17 maj 2019 kl. 07.56 skrev Eli Zaretskii <eliz <at> gnu.org>:
> 
> This uses the passive tense too much.  The "if nil or omitted, the
> empty string is used" part could be worded more clearly as "it
> defaults to the empty string".  The "It is recommended" part is better
> worded as "We recommend".

Thank you, fixed.

>> +Optional third argument SPACE is a string put between the number and unit.
>> +If nil or omitted, the empty string is used.
> 
> Same here.

Fixed.

I also added the optional argument UNIT to settle that problem. New patch attached.

[0001-Optional-space-and-unit-in-file-size-human-readable-.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.