From unknown Mon Aug 18 04:43:18 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#35749] [PATCH] services: sddm: fix root login failure issue. Resent-From: Reza Alizadeh Majd Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 15 May 2019 14:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35749 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 35749@debbugs.gnu.org Cc: Reza Alizadeh Majd X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.155793033824424 (code B ref -1); Wed, 15 May 2019 14:26:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 May 2019 14:25:38 +0000 Received: from localhost ([127.0.0.1]:53120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQuqg-0006Ls-7X for submit@debbugs.gnu.org; Wed, 15 May 2019 10:25:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQuqd-0006Le-OK for submit@debbugs.gnu.org; Wed, 15 May 2019 10:25:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:40912) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hQuqY-0005FD-IO for submit@debbugs.gnu.org; Wed, 15 May 2019 10:25:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQuqX-0003Wa-F4 for guix-patches@gnu.org; Wed, 15 May 2019 10:25:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_50,NO_DNS_FOR_FROM, RDNS_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQuqW-0005BL-EQ for guix-patches@gnu.org; Wed, 15 May 2019 10:25:29 -0400 Received: from [5.230.148.152] (port=53337 helo=Rezas-MacBook-Pro-2.local) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQuqW-00055y-04 for guix-patches@gnu.org; Wed, 15 May 2019 10:25:28 -0400 Received: by Rezas-MacBook-Pro-2.local (Postfix, from userid 501) id E0EAD101AF85C0; Wed, 15 May 2019 18:42:37 +0430 (+0430) From: Reza Alizadeh Majd Date: Wed, 15 May 2019 18:41:54 +0430 Message-Id: <20190515141154.31832-1-r.majd@pantherx.org> X-Mailer: git-send-email 2.19.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Mac OS X [generic] [fuzzy] X-Received-From: 5.230.148.152 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) * gnu/services/sddm.scm (sdm-pam-service): set uid from config. (sdm-autologin-pam-service): set uid from config. (sdm-pam-services): pass sddm-configuration to sddm-pam-service and sddm-autologin-pam-service --- gnu/services/sddm.scm | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/gnu/services/sddm.scm b/gnu/services/sddm.scm index b433c59e12..b0e6d40260 100644 --- a/gnu/services/sddm.scm +++ b/gnu/services/sddm.scm @@ -175,7 +175,7 @@ Relogin=3D" (if (sddm-configuration-relo= gin? config) (define (sddm-etc-service config) (list `("sddm.conf" ,(sddm-configuration-file config)))) =20 -(define (sddm-pam-service) +(define (sddm-pam-service config) "Return a PAM service for @command{sddm}." (pam-service (name "sddm") @@ -190,7 +190,9 @@ Relogin=3D" (if (sddm-configuration-relo= gin? config) (pam-entry (control "required") (module "pam_succeed_if.so") - (arguments (list "uid >=3D 1000" "quiet"))) + (arguments (list (string-append "uid >=3D " + (number->string (sddm-configuratio= n-minimum-uid config))) + "quiet"))) ;; should be factored out into system-auth (pam-entry (control "required") @@ -249,7 +251,7 @@ Relogin=3D" (if (sddm-configuration-relo= gin? config) (control "required") (module "pam_unix.so")))))) =20 -(define (sddm-autologin-pam-service) +(define (sddm-autologin-pam-service config) "Return a PAM service for @command{sddm-autologin}" (pam-service (name "sddm-autologin") @@ -261,7 +263,9 @@ Relogin=3D" (if (sddm-configuration-relo= gin? config) (pam-entry (control "required") (module "pam_succeed_if.so") - (arguments (list "uid >=3D 1000" "quiet"))) + (arguments (list (string-append "uid >=3D " + (number->string (sddm-configuratio= n-minimum-uid config))) + "quiet"))) (pam-entry (control "required") (module "pam_permit.so")))) @@ -282,9 +286,9 @@ Relogin=3D" (if (sddm-configuration-relo= gin? config) (module "sddm")))))) =20 (define (sddm-pam-services config) - (list (sddm-pam-service) + (list (sddm-pam-service config) (sddm-greeter-pam-service) - (sddm-autologin-pam-service))) + (sddm-autologin-pam-service config))) =20 (define %sddm-accounts (list (user-group (name "sddm") (system? #t)) --=20 2.19.0 From unknown Mon Aug 18 04:43:18 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#35749] SDDM root login issue References: <20190515141154.31832-1-r.majd@pantherx.org> In-Reply-To: <20190515141154.31832-1-r.majd@pantherx.org> Resent-From: "Reza Alizadeh Majd" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 15 May 2019 14:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35749 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 35749@debbugs.gnu.org Received: via spool by 35749-submit@debbugs.gnu.org id=B35749.155793090325426 (code B ref 35749); Wed, 15 May 2019 14:36:01 +0000 Received: (at 35749) by debbugs.gnu.org; 15 May 2019 14:35:03 +0000 Received: from localhost ([127.0.0.1]:53137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQuzn-0006c2-I3 for submit@debbugs.gnu.org; Wed, 15 May 2019 10:35:03 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:57401) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQuzl-0006bR-MD for 35749@debbugs.gnu.org; Wed, 15 May 2019 10:35:02 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 9CE274AD for <35749@debbugs.gnu.org>; Wed, 15 May 2019 10:34:55 -0400 (EDT) Received: from imap5 ([10.202.2.55]) by compute5.internal (MEProxy); Wed, 15 May 2019 10:34:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= mime-version:message-id:date:from:to:subject:content-type; s= fm2; bh=TB3RI/leGhNg2C8HjAhgFtnQBJ8MeUgCQiJyzizJj6Y=; b=HQqs9gZH DOGKp8EqdnIEK6du99Tv2BuF3mvci9eHHpKVoHuIhhpIHi1WnA4EOIbuJOZwMeHr 4JPcZGcEvZnshiS98xMOPv9YAQNf2VrAzZumGXtoMECNCaqjnM4zA3hhSkDXUVBQ noDZBSDiUvKX8YZle4wsYPuWhAJglxWFiqyChW1fxNehnByoGLP3ahXoICVlCHeA jAnR57OnLOBUMbTG2DRfYSSvYHTYzblW+Ilv5+T7fBsl7C7DqC+LapXQSvKpb+3g lKX2eHj7HX8p0ud3XFd5M07A+YnFvtPdkOfSUrWm9iWB0MPHRs5J5FINk2UqPLXF dDSHprcpkPWtKw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=TB3RI/leGhNg2C8HjAhgFtnQBJ8Me UgCQiJyzizJj6Y=; b=roun99TKcVlbYma/8gc2iXGHkdKnlx1U39mADLH71iwpH 0N9ThA3G6b5aK0pYtZakCHtI5ZaFy4V9kohGMYGX8miOGuPndCBd7h0UH6r6aGXh XxfMnhwLYSzNrarz7zAumJRIFG1e+FfPJF1mnbebs+YH3ss0A3bDiaCzby5F19SA Z9A+ulQamz9lCl9I8w31qVIQ6+Vj3e46kq0mabdyiJdtWyjcCDjZT28IjRYRHGqR C8zW1wSsEAl2U28XQaEtkVkaEf7HYzvPKimcVwX60o0coe769jag/K6koWwxpi33 feQGU4BTasEMHtbQlSP6U4gMZlvs00lGigYr/U/AA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrleekgdejjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkfffhvffutgesthdtredtre ertdenucfhrhhomhepfdftvgiirgcutehlihiirgguvghhucforghjugdfuceorhdrmhgr jhgusehprghnthhhvghrgidrohhrgheqnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrrd hmrghjugesphgrnhhthhgvrhigrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id D0796310EF; Wed, 15 May 2019 10:34:54 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.6-541-gda5ca9a-fmstable-20190515v2 Mime-Version: 1.0 Message-Id: Date: Wed, 15 May 2019 19:04:54 +0430 From: "Reza Alizadeh Majd" Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) There was an issue for root login using SDDM, that was related to hard-coded uid in sddm-pam-service. this patch set's the uid based on `minimum-uid` option in `sddm-configuration`. Best, Reza From unknown Mon Aug 18 04:43:18 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#35749] [PATCH] services: sddm: fix root login failure issue. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 20 May 2019 21:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35749 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Reza Alizadeh Majd Cc: 35749@debbugs.gnu.org Received: via spool by 35749-submit@debbugs.gnu.org id=B35749.15583869877193 (code B ref 35749); Mon, 20 May 2019 21:17:02 +0000 Received: (at 35749) by debbugs.gnu.org; 20 May 2019 21:16:27 +0000 Received: from localhost ([127.0.0.1]:38169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSpdy-0001rw-JQ for submit@debbugs.gnu.org; Mon, 20 May 2019 17:16:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSpdw-0001rj-Sl for 35749@debbugs.gnu.org; Mon, 20 May 2019 17:16:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60884) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSpdr-0007jB-OV; Mon, 20 May 2019 17:16:19 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=57998 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hSpdr-0001KO-Aa; Mon, 20 May 2019 17:16:19 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20190515141154.31832-1-r.majd@pantherx.org> Date: Mon, 20 May 2019 23:16:15 +0200 In-Reply-To: <20190515141154.31832-1-r.majd@pantherx.org> (Reza Alizadeh Majd's message of "Wed, 15 May 2019 18:41:54 +0430") Message-ID: <87y330omhs.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Reza Alizadeh Majd skribis: > * gnu/services/sddm.scm > (sdm-pam-service): set uid from config. > (sdm-autologin-pam-service): set uid from config. > (sdm-pam-services): pass sddm-configuration to sddm-pam-service and > sddm-autologin-pam-service > --- > gnu/services/sddm.scm | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) Could you send an updated patch that documents the =E2=80=98minimum-uid=E2= =80=99 field in doc/guix.texi, under =E2=80=98sddm-configuration=E2=80=99? Apart from that it LGTM. Thanks for fixing this! Ludo=E2=80=99. From unknown Mon Aug 18 04:43:18 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#35749] [PATCH] services: sddm: fix root login failure issue. Resent-From: "Reza Alizadeh Majd" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 May 2019 11:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35749 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 35749@debbugs.gnu.org Received: via spool by 35749-submit@debbugs.gnu.org id=B35749.15584379798152 (code B ref 35749); Tue, 21 May 2019 11:27:01 +0000 Received: (at 35749) by debbugs.gnu.org; 21 May 2019 11:26:19 +0000 Received: from localhost ([127.0.0.1]:38767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hT2uR-00027Q-Ip for submit@debbugs.gnu.org; Tue, 21 May 2019 07:26:19 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:34661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hT2uQ-00027E-3f for 35749@debbugs.gnu.org; Tue, 21 May 2019 07:26:18 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 3619523C7C; Tue, 21 May 2019 07:26:12 -0400 (EDT) Received: from imap5 ([10.202.2.55]) by compute5.internal (MEProxy); Tue, 21 May 2019 07:26:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type:content-transfer-encoding; s=fm2; bh=yxDQZ in5O+ePvlDXtqOVH3QHowHETdjGVqiEw4oR22U=; b=TItlerWNykqthMixpEVkG g/xstX9A3x9ImNUBrk/QkcsEbopoV78RLIy8e/dJuac730AGi2IfBVDoGmg7OzKa 3TlqSJzPTaJjKMWSNUuYiRrXWZA/NgZcWUDFxOWvtzxOcmk4f3+v87KABLVSlEl1 xebIJdY8b2x2xtd01HZQxKvREynsuf7v8cCi86DJEevB7jeIWeQgENHrQDY5JC/K x6gB9rWSgdpefAqFM7VECnw2bkqkPI2BpvMUnHCAldovXmdmPglxJgM9f+aoaY4x LJABIdOnD7W+JyVpdgvBa0mmF44s0RB0lYxmoDAw2rk17npzztLjcyVTG3c0DvAx w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=yxDQZin5O+ePvlDXtqOVH3QHowHETdjGVqiEw4oR2 2U=; b=au9DVIWhGpYlbt23oj3kDfq9lXVL/Mvb4xaoOj679j2Aq/y1fJBYWno5I oEHZj+gN5k+44sZPXhxzeYHcZOa1qw/8bNY2USUp89h3SZ+65+w9lDinROZ0i2U+ jwJF3OMNSWkxywHbMW80ZOeqioXTs9thmR1sXt5vXVTFSRoAld1Q8WQU6w+pvPso k03SdVCA6q6P7JMwa9qs19y4l9jALGlZX7gBFNWtOygUlYcOh/T0RpEmM4WYdQ3o HrQbI0TTf7kEGuB/RY/bXz51rkBTE7FdITKNFu0sHEoVdDSALwR1KxgaOk34zBru 45uib6yw30F5m6GigKRD0GLXuG23w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddruddutddggedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgfgsehtqhertderreejnecuhfhrohhmpedftfgv iigrucetlhhiiigruggvhhcuofgrjhgufdcuoehrrdhmrghjugesphgrnhhthhgvrhigrd horhhgqeenucfrrghrrghmpehmrghilhhfrhhomheprhdrmhgrjhgusehprghnthhhvghr gidrohhrghenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 66F4D31139; Tue, 21 May 2019 07:26:11 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.6-550-g29afa21-fmstable-20190520v1 Mime-Version: 1.0 Message-Id: <41a6a5e2-86cc-42d6-995e-a20c0217924e@www.fastmail.com> In-Reply-To: <87y330omhs.fsf@gnu.org> References: <20190515141154.31832-1-r.majd@pantherx.org> <87y330omhs.fsf@gnu.org> Date: Tue, 21 May 2019 15:56:11 +0430 From: "Reza Alizadeh Majd" Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi,=20 > Could you send an updated patch that documents the =E2=80=98minimum-ui= d=E2=80=99 field > in doc/guix.texi, under =E2=80=98sddm-configuration=E2=80=99? Is it possible to submit further changes to this patch, or I need to sub= mit a new one with whole changes?=20 Thanks,=20 Reza From unknown Mon Aug 18 04:43:18 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#35749] [PATCH 1/2] services: sddm: fix root login failure issue. References: <20190515141154.31832-1-r.majd@pantherx.org> In-Reply-To: <20190515141154.31832-1-r.majd@pantherx.org> Resent-From: Reza Alizadeh Majd Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 May 2019 11:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35749 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 35749@debbugs.gnu.org Cc: Reza Alizadeh Majd Received: via spool by 35749-submit@debbugs.gnu.org id=B35749.155843899017897 (code B ref 35749); Tue, 21 May 2019 11:44:02 +0000 Received: (at 35749) by debbugs.gnu.org; 21 May 2019 11:43:10 +0000 Received: from localhost ([127.0.0.1]:38794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hT3Ak-0004eb-99 for submit@debbugs.gnu.org; Tue, 21 May 2019 07:43:10 -0400 Received: from [5.230.148.152] (port=60387 helo=Rezas-MacBook-Pro-2.local) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hT3Ai-0004eR-Js for 35749@debbugs.gnu.org; Tue, 21 May 2019 07:43:09 -0400 Received: by Rezas-MacBook-Pro-2.local (Postfix, from userid 501) id F3809101B300DB; Tue, 21 May 2019 16:13:04 +0430 (+0430) From: Reza Alizadeh Majd Date: Tue, 21 May 2019 16:12:45 +0430 Message-Id: <20190521114246.82283-1-r.majd@pantherx.org> X-Mailer: git-send-email 2.19.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/services/sddm.scm (sdm-pam-service): set uid from config. (sdm-autologin-pam-service): set uid from config. (sdm-pam-services): pass sddm-configuration to sddm-pam-service and sddm-autologin-pam [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.4 NO_DNS_FOR_FROM DNS: Envelope sender has no MX or A DNS records 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: pam_unix.so] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) * gnu/services/sddm.scm (sdm-pam-service): set uid from config. (sdm-autologin-pam-service): set uid from config. (sdm-pam-services): pass sddm-configuration to sddm-pam-service and sddm-autologin-pam-service --- gnu/services/sddm.scm | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/gnu/services/sddm.scm b/gnu/services/sddm.scm index b433c59e12..b0e6d40260 100644 --- a/gnu/services/sddm.scm +++ b/gnu/services/sddm.scm @@ -175,7 +175,7 @@ Relogin=" (if (sddm-configuration-relogin? config) (define (sddm-etc-service config) (list `("sddm.conf" ,(sddm-configuration-file config)))) -(define (sddm-pam-service) +(define (sddm-pam-service config) "Return a PAM service for @command{sddm}." (pam-service (name "sddm") @@ -190,7 +190,9 @@ Relogin=" (if (sddm-configuration-relogin? config) (pam-entry (control "required") (module "pam_succeed_if.so") - (arguments (list "uid >= 1000" "quiet"))) + (arguments (list (string-append "uid >= " + (number->string (sddm-configuration-minimum-uid config))) + "quiet"))) ;; should be factored out into system-auth (pam-entry (control "required") @@ -249,7 +251,7 @@ Relogin=" (if (sddm-configuration-relogin? config) (control "required") (module "pam_unix.so")))))) -(define (sddm-autologin-pam-service) +(define (sddm-autologin-pam-service config) "Return a PAM service for @command{sddm-autologin}" (pam-service (name "sddm-autologin") @@ -261,7 +263,9 @@ Relogin=" (if (sddm-configuration-relogin? config) (pam-entry (control "required") (module "pam_succeed_if.so") - (arguments (list "uid >= 1000" "quiet"))) + (arguments (list (string-append "uid >= " + (number->string (sddm-configuration-minimum-uid config))) + "quiet"))) (pam-entry (control "required") (module "pam_permit.so")))) @@ -282,9 +286,9 @@ Relogin=" (if (sddm-configuration-relogin? config) (module "sddm")))))) (define (sddm-pam-services config) - (list (sddm-pam-service) + (list (sddm-pam-service config) (sddm-greeter-pam-service) - (sddm-autologin-pam-service))) + (sddm-autologin-pam-service config))) (define %sddm-accounts (list (user-group (name "sddm") (system? #t)) -- 2.19.0 From unknown Mon Aug 18 04:43:18 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#35749] [PATCH 2/2] doc: update minimum-uid document for sddm-configuration. Resent-From: Reza Alizadeh Majd Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 May 2019 11:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35749 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 35749@debbugs.gnu.org Cc: Reza Alizadeh Majd Received: via spool by 35749-submit@debbugs.gnu.org id=B35749.155843899417915 (code B ref 35749); Tue, 21 May 2019 11:44:02 +0000 Received: (at 35749) by debbugs.gnu.org; 21 May 2019 11:43:14 +0000 Received: from localhost ([127.0.0.1]:38797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hT3An-0004et-NP for submit@debbugs.gnu.org; Tue, 21 May 2019 07:43:13 -0400 Received: from [5.230.148.152] (port=60391 helo=Rezas-MacBook-Pro-2.local) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hT3Am-0004ej-0R for 35749@debbugs.gnu.org; Tue, 21 May 2019 07:43:12 -0400 Received: by Rezas-MacBook-Pro-2.local (Postfix, from userid 501) id 25F3E101B300DE; Tue, 21 May 2019 16:13:10 +0430 (+0430) From: Reza Alizadeh Majd Date: Tue, 21 May 2019 16:12:46 +0430 Message-Id: <20190521114246.82283-2-r.majd@pantherx.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20190521114246.82283-1-r.majd@pantherx.org> References: <20190521114246.82283-1-r.majd@pantherx.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: --- doc/guix.texi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/guix.texi b/doc/guix.texi index 27e0f72ccb..6bce474859 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -13609, 7 +13609, 8 @@ Directory to look for faces. Default PATH to use. Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.4 NO_DNS_FOR_FROM DNS: Envelope sender has no MX or A DNS records 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --- doc/guix.texi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/guix.texi b/doc/guix.texi index 27e0f72ccb..6bce474859 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -13609,7 +13609,8 @@ Directory to look for faces. Default PATH to use. @item @code{minimum-uid} (default 1000) -Minimum UID to display in SDDM. +Minimum UID to display in SDDM. This option also used in @code{sddm-pam-service} and +@code{sddm-autologin-pam-service} in order to set minimum UID which allows to login. @item @code{maximum-uid} (default 2000) Maximum UID to display in SDDM -- 2.19.0 From unknown Mon Aug 18 04:43:18 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#35749] [PATCH] services: sddm: fix root login failure issue. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 May 2019 13:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35749 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Reza Alizadeh Majd" Cc: 35749@debbugs.gnu.org Received: via spool by 35749-submit@debbugs.gnu.org id=B35749.155844466011707 (code B ref 35749); Tue, 21 May 2019 13:18:01 +0000 Received: (at 35749) by debbugs.gnu.org; 21 May 2019 13:17:40 +0000 Received: from localhost ([127.0.0.1]:38966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hT4eC-00032l-5m for submit@debbugs.gnu.org; Tue, 21 May 2019 09:17:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hT4e8-00032S-TO for 35749@debbugs.gnu.org; Tue, 21 May 2019 09:17:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45684) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hT4e3-0001JD-Ph; Tue, 21 May 2019 09:17:31 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=40070 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hT4e3-0008PB-Bo; Tue, 21 May 2019 09:17:31 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20190515141154.31832-1-r.majd@pantherx.org> <87y330omhs.fsf@gnu.org> <41a6a5e2-86cc-42d6-995e-a20c0217924e@www.fastmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 2 Prairial an 227 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 21 May 2019 15:17:30 +0200 In-Reply-To: <41a6a5e2-86cc-42d6-995e-a20c0217924e@www.fastmail.com> (Reza Alizadeh Majd's message of "Tue, 21 May 2019 15:56:11 +0430") Message-ID: <87lfz02bh1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, "Reza Alizadeh Majd" skribis: >> Could you send an updated patch that documents the =E2=80=98minimum-uid= =E2=80=99 field >> in doc/guix.texi, under =E2=80=98sddm-configuration=E2=80=99? > > Is it possible to submit further changes to this patch, or I need to subm= it a new one with whole changes?=20 Please send us a new patch that includes all the changes. Thanks in advance! Ludo=E2=80=99. From unknown Mon Aug 18 04:43:18 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#35749] [PATCH] services: sddm: fix root login failure issue. Resent-From: "Reza Alizadeh Majd" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 May 2019 13:22:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35749 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 35749@debbugs.gnu.org Received: via spool by 35749-submit@debbugs.gnu.org id=B35749.155844491712211 (code B ref 35749); Tue, 21 May 2019 13:22:03 +0000 Received: (at 35749) by debbugs.gnu.org; 21 May 2019 13:21:57 +0000 Received: from localhost ([127.0.0.1]:38990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hT4iK-0003At-Mr for submit@debbugs.gnu.org; Tue, 21 May 2019 09:21:56 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:41497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hT4iJ-0003Ag-79 for 35749@debbugs.gnu.org; Tue, 21 May 2019 09:21:55 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 1857021FE0; Tue, 21 May 2019 09:21:50 -0400 (EDT) Received: from imap5 ([10.202.2.55]) by compute5.internal (MEProxy); Tue, 21 May 2019 09:21:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type:content-transfer-encoding; s=fm2; bh=60EeK VyhmMKKR/aCoEIcTJF8q0+6URWfr8SjTc6HcTg=; b=mI8TcPJUEra077Pv9S3MZ ddqQYKyaDD9wZpKQabXtjuCrvZQpMXDNVHKxnzY2z2ZHOeBH63XsUwiqA0eAWkNQ kDyNgIN4zXhgck9N3fPi5DkFSEgmBAQH8ZkKsQcBbhbIdn5kAfG57K+xJLHID1Zz 8j5kI1VSOOFrIusNT4X+gtAJiKZ11vnn9FrOqS+MeQMvFLVaKNe4+zHFM89sBkYQ mCNefsJEwtectiithZzanUaGpPwE0a0f3bEPnuqXsIrLgwFQux4VS90hzbPt8iDG wlybap3uir0FspRXRPSFEZqqIWUy4PplrCBm+5lDiWVXIOM6sIT7SxOa9pIZYwB9 Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=60EeKVyhmMKKR/aCoEIcTJF8q0+6URWfr8SjTc6Hc Tg=; b=yRx67zU0RkkzxU2aeAJLLDMujD+0iFrZHVe+6A27AFeZb8/i+Eez7xnWO scO95jTWhhBx4tNJsI5Xhx18yuUQjXJ9ypiNZQC49IwRwF7tqpJWrrA8vDWHrUMv u8fQQ7jTgucmt8CAIoRJC0VsnW2gvEzfMtAUiAP7XdG5Fosoo/kfWcFbaJTiMf57 XtzsTnuC1z0F1Bhk6mDHLc5OmJyATRlPdWzBlZOpjWZjsg94X0pgXUJyvOgXBbtU VJ8l9+jaEOp94Ts2X1UJ/IjWYz5TUjYrtEwz0lYrEkAkKtcFCZXLAUDKbtj3rxpG terViI+g/1wk2qDC1+gjFbVpO8AaQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddruddutddgieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgfgsehtqhertderreejnecuhfhrohhmpedftfgv iigrucetlhhiiigruggvhhcuofgrjhgufdcuoehrrdhmrghjugesphgrnhhthhgvrhigrd horhhgqeenucfrrghrrghmpehmrghilhhfrhhomheprhdrmhgrjhgusehprghnthhhvghr gidrohhrghenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id CBA8931139; Tue, 21 May 2019 09:21:49 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.6-550-g29afa21-fmstable-20190520v1 Mime-Version: 1.0 Message-Id: In-Reply-To: <87lfz02bh1.fsf@gnu.org> References: <20190515141154.31832-1-r.majd@pantherx.org> <87y330omhs.fsf@gnu.org> <41a6a5e2-86cc-42d6-995e-a20c0217924e@www.fastmail.com> <87lfz02bh1.fsf@gnu.org> Date: Tue, 21 May 2019 17:51:49 +0430 From: "Reza Alizadeh Majd" Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) OK, sure On Tue, May 21, 2019, at 5:47 PM, Ludovic Court=C3=A8s wrote: > Hi, >=20 > "Reza Alizadeh Majd" skribis: >=20 > >> Could you send an updated patch that documents the =E2=80=98minimum= -uid=E2=80=99 field > >> in doc/guix.texi, under =E2=80=98sddm-configuration=E2=80=99? > > > > Is it possible to submit further changes to this patch, or I need to= submit a new one with whole changes?=20 >=20 > Please send us a new patch that includes all the changes. >=20 > Thanks in advance! >=20 > Ludo=E2=80=99. > From unknown Mon Aug 18 04:43:18 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Reza Alizadeh Majd Subject: bug#35749: closed (Re: [bug#35749] [PATCH] services: sddm: fix root login failure issue.) Message-ID: References: <20191015193810.GD939@E5400> <20190515141154.31832-1-r.majd@pantherx.org> X-Gnu-PR-Message: they-closed 35749 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 35749@debbugs.gnu.org Date: Tue, 15 Oct 2019 19:39:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1571168342-19183-1" This is a multi-part message in MIME format... ------------=_1571168342-19183-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #35749: [PATCH] services: sddm: fix root login failure issue. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 35749@debbugs.gnu.org. --=20 35749: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D35749 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1571168342-19183-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 35749-done) by debbugs.gnu.org; 15 Oct 2019 19:38:19 +0000 Received: from localhost ([127.0.0.1]:44889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKSeB-0004yQ-4j for submit@debbugs.gnu.org; Tue, 15 Oct 2019 15:38:19 -0400 Received: from flashner.co.il ([178.62.234.194]:54040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKSe9-0004yB-MN for 35749-done@debbugs.gnu.org; Tue, 15 Oct 2019 15:38:18 -0400 Received: from localhost (unknown [37.26.148.223]) by flashner.co.il (Postfix) with ESMTPSA id B255940262; Tue, 15 Oct 2019 19:38:11 +0000 (UTC) Date: Tue, 15 Oct 2019 22:38:10 +0300 From: Efraim Flashner To: Reza Alizadeh Majd Subject: Re: [bug#35749] [PATCH] services: sddm: fix root login failure issue. Message-ID: <20191015193810.GD939@E5400> References: <20190515141154.31832-1-r.majd@pantherx.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Hf61M2y+wYpnELGG" Content-Disposition: inline In-Reply-To: <20190515141154.31832-1-r.majd@pantherx.org> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 User-Agent: Mutt/1.12.2 (2019-09-21) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 35749-done Cc: ludo@gnu.org, 35749-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Hf61M2y+wYpnELGG Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable This patch-set was pushed back in May. Closing the bug now :) --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --Hf61M2y+wYpnELGG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl2mICIACgkQQarn3Mo9 g1GbTxAAlvdwZH/67TFSxWSZWjoCGR3/3O5Uh5d43eHa8koofoxvINdjlF2MPDry 347vQ2TAjlSibJaWDZl01jfdy3XUdTrkgk9VGf4A0HhJ7sZODlTwS+fRdtXUIDEM ZI1ErxQp1QnyridMRZd2HbhGu13uDtyD03SJKkyWd/Gb66OamgOr9mys4uYIZO6l nJkah/KELoJirXx7SXx3BpMR4yor8v6Y958fyIHrpynxajx1GxKTwMHmmTc5X+fa N3dbJU5PjIhu2NPNmUWb84KdD+WvBGSYIPjsxWeII2UihUg7BKiTQch6Na+kpjSe iFP8DD3lhO1FTT2c64l8zbsjw7xs21wRBXN3juQAJc19IZZpfaQ5KCQKrQRCRseF pb3ihiKsABMRdjnzPDhPZE0YcJMrKrVu/74LTy+QkVjo7lNns0frrHTCmOIk3jSQ nLRsRPri/r2okYqf2w2FIgpma7jXpLJx+bbEDLvF4YN+LyIAM1wZYTYK0vFs/0PP Xd+JlNQpfmBSCcJceXg5nTC3HlshepOaZDuiP2OLN2cF2hYy+pNXlGnfR3/fkIiB W2zNTGQ9M5pUDmOy2U0M8i4+5Vu1VAaJsbgo95ZeI1ye8teKxRV1gIiCYpKkUIEq ag5368DCYEdeHZYZXvE4ntFdCjFnDFh/0Y7Kt7DTtM9UuIXoVXI= =ksd2 -----END PGP SIGNATURE----- --Hf61M2y+wYpnELGG-- ------------=_1571168342-19183-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 May 2019 14:25:38 +0000 Received: from localhost ([127.0.0.1]:53120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQuqg-0006Ls-7X for submit@debbugs.gnu.org; Wed, 15 May 2019 10:25:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQuqd-0006Le-OK for submit@debbugs.gnu.org; Wed, 15 May 2019 10:25:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:40912) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hQuqY-0005FD-IO for submit@debbugs.gnu.org; Wed, 15 May 2019 10:25:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQuqX-0003Wa-F4 for guix-patches@gnu.org; Wed, 15 May 2019 10:25:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_50,NO_DNS_FOR_FROM, RDNS_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQuqW-0005BL-EQ for guix-patches@gnu.org; Wed, 15 May 2019 10:25:29 -0400 Received: from [5.230.148.152] (port=53337 helo=Rezas-MacBook-Pro-2.local) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQuqW-00055y-04 for guix-patches@gnu.org; Wed, 15 May 2019 10:25:28 -0400 Received: by Rezas-MacBook-Pro-2.local (Postfix, from userid 501) id E0EAD101AF85C0; Wed, 15 May 2019 18:42:37 +0430 (+0430) From: Reza Alizadeh Majd To: guix-patches@gnu.org Subject: [PATCH] services: sddm: fix root login failure issue. Date: Wed, 15 May 2019 18:41:54 +0430 Message-Id: <20190515141154.31832-1-r.majd@pantherx.org> X-Mailer: git-send-email 2.19.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Mac OS X [generic] [fuzzy] X-Received-From: 5.230.148.152 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: submit Cc: Reza Alizadeh Majd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) * gnu/services/sddm.scm (sdm-pam-service): set uid from config. (sdm-autologin-pam-service): set uid from config. (sdm-pam-services): pass sddm-configuration to sddm-pam-service and sddm-autologin-pam-service --- gnu/services/sddm.scm | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/gnu/services/sddm.scm b/gnu/services/sddm.scm index b433c59e12..b0e6d40260 100644 --- a/gnu/services/sddm.scm +++ b/gnu/services/sddm.scm @@ -175,7 +175,7 @@ Relogin=3D" (if (sddm-configuration-relo= gin? config) (define (sddm-etc-service config) (list `("sddm.conf" ,(sddm-configuration-file config)))) =20 -(define (sddm-pam-service) +(define (sddm-pam-service config) "Return a PAM service for @command{sddm}." (pam-service (name "sddm") @@ -190,7 +190,9 @@ Relogin=3D" (if (sddm-configuration-relo= gin? config) (pam-entry (control "required") (module "pam_succeed_if.so") - (arguments (list "uid >=3D 1000" "quiet"))) + (arguments (list (string-append "uid >=3D " + (number->string (sddm-configuratio= n-minimum-uid config))) + "quiet"))) ;; should be factored out into system-auth (pam-entry (control "required") @@ -249,7 +251,7 @@ Relogin=3D" (if (sddm-configuration-relo= gin? config) (control "required") (module "pam_unix.so")))))) =20 -(define (sddm-autologin-pam-service) +(define (sddm-autologin-pam-service config) "Return a PAM service for @command{sddm-autologin}" (pam-service (name "sddm-autologin") @@ -261,7 +263,9 @@ Relogin=3D" (if (sddm-configuration-relo= gin? config) (pam-entry (control "required") (module "pam_succeed_if.so") - (arguments (list "uid >=3D 1000" "quiet"))) + (arguments (list (string-append "uid >=3D " + (number->string (sddm-configuratio= n-minimum-uid config))) + "quiet"))) (pam-entry (control "required") (module "pam_permit.so")))) @@ -282,9 +286,9 @@ Relogin=3D" (if (sddm-configuration-relo= gin? config) (module "sddm")))))) =20 (define (sddm-pam-services config) - (list (sddm-pam-service) + (list (sddm-pam-service config) (sddm-greeter-pam-service) - (sddm-autologin-pam-service))) + (sddm-autologin-pam-service config))) =20 (define %sddm-accounts (list (user-group (name "sddm") (system? #t)) --=20 2.19.0 ------------=_1571168342-19183-1--