GNU bug report logs - #35749
[PATCH] services: sddm: fix root login failure issue.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35749 in the body.
You can then email your comments to 35749 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Reza Alizadeh Majd <r.majd <at> pantherx.org>
To: guix-patches <at> gnu.org
Cc: Reza Alizadeh Majd <r.majd <at> pantherx.org>
Subject: [PATCH] services: sddm: fix root login failure issue.
Date: Wed, 15 May 2019 18:41:54 +0430

* gnu/services/sddm.scm
     (sdm-pam-service): set uid from config.
     (sdm-autologin-pam-service): set uid from config.
     (sdm-pam-services): pass sddm-configuration to sddm-pam-service and
sddm-autologin-pam-service
---
 gnu/services/sddm.scm | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/gnu/services/sddm.scm b/gnu/services/sddm.scm
index b433c59e12..b0e6d40260 100644
--- a/gnu/services/sddm.scm
+++ b/gnu/services/sddm.scm
@@ -175,7 +175,7 @@ Relogin="              (if (sddm-configuration-relogin? config)
 (define (sddm-etc-service config)
   (list `("sddm.conf" ,(sddm-configuration-file config))))
 
-(define (sddm-pam-service)
+(define (sddm-pam-service config)
   "Return a PAM service for @command{sddm}."
   (pam-service
    (name "sddm")
@@ -190,7 +190,9 @@ Relogin="              (if (sddm-configuration-relogin? config)
      (pam-entry
       (control "required")
       (module "pam_succeed_if.so")
-      (arguments (list "uid >= 1000" "quiet")))
+      (arguments (list (string-append "uid >= "
+                                      (number->string (sddm-configuration-minimum-uid config)))
+                       "quiet")))
      ;; should be factored out into system-auth
      (pam-entry
       (control "required")
@@ -249,7 +251,7 @@ Relogin="              (if (sddm-configuration-relogin? config)
       (control "required")
       (module "pam_unix.so"))))))
 
-(define (sddm-autologin-pam-service)
+(define (sddm-autologin-pam-service config)
   "Return a PAM service for @command{sddm-autologin}"
   (pam-service
    (name "sddm-autologin")
@@ -261,7 +263,9 @@ Relogin="              (if (sddm-configuration-relogin? config)
      (pam-entry
       (control "required")
       (module "pam_succeed_if.so")
-      (arguments (list "uid >= 1000" "quiet")))
+      (arguments (list (string-append "uid >= "
+                                      (number->string (sddm-configuration-minimum-uid config)))
+                       "quiet")))
      (pam-entry
       (control "required")
       (module "pam_permit.so"))))
@@ -282,9 +286,9 @@ Relogin="              (if (sddm-configuration-relogin? config)
       (module "sddm"))))))
 
 (define (sddm-pam-services config)
-  (list (sddm-pam-service)
+  (list (sddm-pam-service config)
         (sddm-greeter-pam-service)
-        (sddm-autologin-pam-service)))
+        (sddm-autologin-pam-service config)))
 
 (define %sddm-accounts
   (list (user-group (name "sddm") (system? #t))
-- 
2.19.0

Message #8 received at 35749 <at> debbugs.gnu.org (full text, mbox):

From: "Reza Alizadeh Majd" <r.majd <at> pantherx.org>
To: 35749 <at> debbugs.gnu.org
Subject: SDDM root login issue
Date: Wed, 15 May 2019 19:04:54 +0430

There was an issue for root login using SDDM, that was related to hard-coded uid  in sddm-pam-service. 
this patch set's the uid based on `minimum-uid` option in `sddm-configuration`.

Best, 
Reza

Message #11 received at 35749 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Reza Alizadeh Majd <r.majd <at> pantherx.org>
Cc: 35749 <at> debbugs.gnu.org
Subject: Re: [bug#35749] [PATCH] services: sddm: fix root login failure issue.
Date: Mon, 20 May 2019 23:16:15 +0200

Hi,

Reza Alizadeh Majd <r.majd <at> pantherx.org> skribis:

> * gnu/services/sddm.scm
>      (sdm-pam-service): set uid from config.
>      (sdm-autologin-pam-service): set uid from config.
>      (sdm-pam-services): pass sddm-configuration to sddm-pam-service and
> sddm-autologin-pam-service
> ---
>  gnu/services/sddm.scm | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)

Could you send an updated patch that documents the ‘minimum-uid’ field
in doc/guix.texi, under ‘sddm-configuration’?

Apart from that it LGTM.

Thanks for fixing this!

Ludo’.

Message #14 received at 35749 <at> debbugs.gnu.org (full text, mbox):

From: "Reza Alizadeh Majd" <r.majd <at> pantherx.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 35749 <at> debbugs.gnu.org
Subject: Re: [bug#35749] [PATCH] services: sddm: fix root login failure issue.
Date: Tue, 21 May 2019 15:56:11 +0430

Hi, 

> Could you send an updated patch that documents the ‘minimum-uid’ field
> in doc/guix.texi, under ‘sddm-configuration’?

Is it possible to submit further changes to this patch, or I need to submit a new one with whole changes? 

Thanks, 
Reza

Message #17 received at 35749 <at> debbugs.gnu.org (full text, mbox):

From: Reza Alizadeh Majd <r.majd <at> pantherx.org>
To: 35749 <at> debbugs.gnu.org
Cc: Reza Alizadeh Majd <r.majd <at> pantherx.org>
Subject: [PATCH 1/2] services: sddm: fix root login failure issue.
Date: Tue, 21 May 2019 16:12:45 +0430

* gnu/services/sddm.scm
     (sdm-pam-service): set uid from config.
     (sdm-autologin-pam-service): set uid from config.
     (sdm-pam-services): pass sddm-configuration to sddm-pam-service and
sddm-autologin-pam-service
---
 gnu/services/sddm.scm | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/gnu/services/sddm.scm b/gnu/services/sddm.scm
index b433c59e12..b0e6d40260 100644
--- a/gnu/services/sddm.scm
+++ b/gnu/services/sddm.scm
@@ -175,7 +175,7 @@ Relogin="              (if (sddm-configuration-relogin? config)
 (define (sddm-etc-service config)
   (list `("sddm.conf" ,(sddm-configuration-file config))))
 
-(define (sddm-pam-service)
+(define (sddm-pam-service config)
   "Return a PAM service for @command{sddm}."
   (pam-service
    (name "sddm")
@@ -190,7 +190,9 @@ Relogin="              (if (sddm-configuration-relogin? config)
      (pam-entry
       (control "required")
       (module "pam_succeed_if.so")
-      (arguments (list "uid >= 1000" "quiet")))
+      (arguments (list (string-append "uid >= "
+                                      (number->string (sddm-configuration-minimum-uid config)))
+                       "quiet")))
      ;; should be factored out into system-auth
      (pam-entry
       (control "required")
@@ -249,7 +251,7 @@ Relogin="              (if (sddm-configuration-relogin? config)
       (control "required")
       (module "pam_unix.so"))))))
 
-(define (sddm-autologin-pam-service)
+(define (sddm-autologin-pam-service config)
   "Return a PAM service for @command{sddm-autologin}"
   (pam-service
    (name "sddm-autologin")
@@ -261,7 +263,9 @@ Relogin="              (if (sddm-configuration-relogin? config)
      (pam-entry
       (control "required")
       (module "pam_succeed_if.so")
-      (arguments (list "uid >= 1000" "quiet")))
+      (arguments (list (string-append "uid >= "
+                                      (number->string (sddm-configuration-minimum-uid config)))
+                       "quiet")))
      (pam-entry
       (control "required")
       (module "pam_permit.so"))))
@@ -282,9 +286,9 @@ Relogin="              (if (sddm-configuration-relogin? config)
       (module "sddm"))))))
 
 (define (sddm-pam-services config)
-  (list (sddm-pam-service)
+  (list (sddm-pam-service config)
         (sddm-greeter-pam-service)
-        (sddm-autologin-pam-service)))
+        (sddm-autologin-pam-service config)))
 
 (define %sddm-accounts
   (list (user-group (name "sddm") (system? #t))
-- 
2.19.0

Message #20 received at 35749 <at> debbugs.gnu.org (full text, mbox):

From: Reza Alizadeh Majd <r.majd <at> pantherx.org>
To: 35749 <at> debbugs.gnu.org
Cc: Reza Alizadeh Majd <r.majd <at> pantherx.org>
Subject: [PATCH 2/2] doc: update minimum-uid document for sddm-configuration.
Date: Tue, 21 May 2019 16:12:46 +0430

---
 doc/guix.texi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 27e0f72ccb..6bce474859 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -13609,7 +13609,8 @@ Directory to look for faces.
 Default PATH to use.
 
 @item @code{minimum-uid} (default 1000)
-Minimum UID to display in SDDM.
+Minimum UID to display in SDDM. This option also used in @code{sddm-pam-service} and 
+@code{sddm-autologin-pam-service} in order to set minimum UID which allows to login. 
 
 @item @code{maximum-uid} (default 2000)
 Maximum UID to display in SDDM
-- 
2.19.0

Message #23 received at 35749 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Reza Alizadeh Majd" <r.majd <at> pantherx.org>
Cc: 35749 <at> debbugs.gnu.org
Subject: Re: [bug#35749] [PATCH] services: sddm: fix root login failure issue.
Date: Tue, 21 May 2019 15:17:30 +0200

Hi,

"Reza Alizadeh Majd" <r.majd <at> pantherx.org> skribis:

>> Could you send an updated patch that documents the ‘minimum-uid’ field
>> in doc/guix.texi, under ‘sddm-configuration’?
>
> Is it possible to submit further changes to this patch, or I need to submit a new one with whole changes? 

Please send us a new patch that includes all the changes.

Thanks in advance!

Ludo’.

Message #26 received at 35749 <at> debbugs.gnu.org (full text, mbox):

From: "Reza Alizadeh Majd" <r.majd <at> pantherx.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 35749 <at> debbugs.gnu.org
Subject: Re: [bug#35749] [PATCH] services: sddm: fix root login failure issue.
Date: Tue, 21 May 2019 17:51:49 +0430

OK, sure

On Tue, May 21, 2019, at 5:47 PM, Ludovic Courtès wrote:
> Hi,
> 
> "Reza Alizadeh Majd" <r.majd <at> pantherx.org> skribis:
> 
> >> Could you send an updated patch that documents the ‘minimum-uid’ field
> >> in doc/guix.texi, under ‘sddm-configuration’?
> >
> > Is it possible to submit further changes to this patch, or I need to submit a new one with whole changes? 
> 
> Please send us a new patch that includes all the changes.
> 
> Thanks in advance!
> 
> Ludo’.
>

Message #31 received at 35749-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Reza Alizadeh Majd <r.majd <at> pantherx.org>
Cc: ludo <at> gnu.org, 35749-done <at> debbugs.gnu.org
Subject: Re: [bug#35749] [PATCH] services: sddm: fix root login failure issue.
Date: Tue, 15 Oct 2019 22:38:10 +0300

[Message part 1 (text/plain, inline)]

This patch-set was pushed back in May. Closing the bug now :)


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.