From debbugs-submit-bounces@debbugs.gnu.org Tue May 14 17:26:27 2019 Received: (at submit) by debbugs.gnu.org; 14 May 2019 21:26:27 +0000 Received: from localhost ([127.0.0.1]:50086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQewN-00063H-7N for submit@debbugs.gnu.org; Tue, 14 May 2019 17:26:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQewL-000632-2H for submit@debbugs.gnu.org; Tue, 14 May 2019 17:26:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:45066) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hQewF-0001ak-EL for submit@debbugs.gnu.org; Tue, 14 May 2019 17:26:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQewD-0003wM-Cg for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 17:26:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQew9-0001X2-LH for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 17:26:15 -0400 Received: from mail-ot1-x32a.google.com ([2607:f8b0:4864:20::32a]:35693) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQew8-0001UH-Fv for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 17:26:13 -0400 Received: by mail-ot1-x32a.google.com with SMTP id n14so294325otk.2 for ; Tue, 14 May 2019 14:26:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=oJwz5MDGHMZFcfzSTvWAtsuWoqX5J2M/NSAGV4nyRTk=; b=bCR56i9vf5cUrqqWZ53cwD6eSVC93fU3kzK6vFibVgpKhwG1YnKrLGRo5CyBy3xZQm BcPl+3ZWRp/872X8/7SD6E6KmLQBhYpQYIGkh3+3NERqafX92Afgs7WMZu+il26o9Zl1 Q+UtVPw1wR+VygMcVMdMUWnYoZVMvdqz/0GAIdr/PniaAKKu+OyVJpgDXme6CbyCugQw 6sGMoAib0uxojXG0p4hW2jf0PyXdHuupLFBStGqKDRpzROTbpkASGVBxAwEkRzf4GI73 35KFlxq+0i2Ljjzln1fin3w+uO7RRzl/UjUeoK1dZMTcK9BKsGowfZGKNfj2Cx+RAdLv aGPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=oJwz5MDGHMZFcfzSTvWAtsuWoqX5J2M/NSAGV4nyRTk=; b=pjUvDuiCjrf4pBzgl07j8+eI1vpIUY6GowcNYGIfNcyQxbdsHrTWr4reMcNSkBOi6C WuWkm0CLZBm4cEVcAZ3PhHcDTNcc1fHoOwHbYMl2mfkEegWLyzRaphpglXfESWNfpXm3 gJ1q8PKbQBVES2dB147rWSPTOTar7/+WRk322gjCHIVFalJqjBHoPnNSxcphhoVqjgx7 ozKe2g4Gv7Rxk8bWKAGYDQxV5HkOPV06yo3YUzSVSpbxHU3y3OAM7MwAQmclld7zOvNy pyPt4m+x236gKj35IvQ50H8cc6WGAuWZnElXc8qbrYuc1L35nEtwnCN7TbH2t8ajxiG8 v9Ew== X-Gm-Message-State: APjAAAVLYk7PgHjhLagUko/cyoJJZ99hRTw7bjuiU31Ot2nayS59Tj7D ejKRdP/A4GGLSxxRP0Mx137vsQ2uLQA9ewn5BwIYRfQ7W/4= X-Google-Smtp-Source: APXvYqwxyI+IlgHbWoaT/OQ/2Q67QrIrDuJCAznpWzZ6IRXGC5CDK54JKwHpwwb2IBHvVpsBN+vTv0h6y0Aci5Bm0i8= X-Received: by 2002:a9d:715c:: with SMTP id y28mr18478601otj.95.1557869168955; Tue, 14 May 2019 14:26:08 -0700 (PDT) MIME-Version: 1.0 From: Richard Copley Date: Tue, 14 May 2019 22:25:42 +0100 Message-ID: Subject: Bad signature from GNU ELPA To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="0000000000006c1cec0588dfae91" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::32a X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --0000000000006c1cec0588dfae91 Content-Type: text/plain; charset="UTF-8" Recipe from 'emacs -Q': [M-x package-list-packages RET]. Symptoms: The package list is displayed but an *Error* buffer pops up: Failed to verify signature archive-contents.sig: Bad signature from 474F05837FBDEF9B GNU ELPA Signing Agent (2014) < elpasign@elpa.gnu.org> Command output: gpg: Signature made 05/14/19 22:10:03 GMT Summer Time gpg: using DSA key CA442C00F91774F17F59D9B0474F05837FBDEF9B gpg: BAD signature from "GNU ELPA Signing Agent (2014) < elpasign@elpa.gnu.org>" [unknown] GPG version: gpg (GnuPG) 2.2.11 libgcrypt 1.8.4 Copyright (C) 2018 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later < https://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Home: C:/Users/buster/AppData/Roaming/gnupg Supported algorithms: Pubkey: RSA, ELG, DSA, ECDH, ECDSA, EDDSA Cipher: IDEA, 3DES, CAST5, BLOWFISH, AES, AES192, AES256, TWOFISH, CAMELLIA128, CAMELLIA192, CAMELLIA256 Hash: SHA1, RIPEMD160, SHA256, SHA384, SHA512, SHA224 Compression: Uncompressed, ZIP, ZLIB, BZIP2 In GNU Emacs 27.0.50 (build 7, x86_64-w64-mingw32) of 2019-05-12 built on MACHINE Repository revision: 9e1bb6a2f6c2462b9652ffce706c549269740307 Repository branch: buster Windowing system distributor 'Microsoft Corp.', version 10.0.18890 System Description: Microsoft Windows 10 Pro (v10.0.1903.18890.1000) Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Importing package-keyring.gpg...done Package refresh done error in process filter: package--check-signature-content: Failed to verify signature: "archive-contents.sig" error in process filter: Failed to verify signature: "archive-contents.sig" Configured using: 'configure --config-cache --with-modules --without-pop --without-dbus --without-gconf --without-gsettings CFLAGS=-O3' Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY W32NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS MODULES THREADS JSON PDUMPER LCMS2 GMP Important settings: value of $EMACSLOADPATH: c:\emacs-lisp; value of $LANG: ENG locale-coding-system: cp1252 Major mode: Package Menu Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug sendmail help-mode mm-archive message dired dired-loaddefs format-spec rfc822 mml mml-sec epa derived gnus-util rmail rmail-loaddefs text-property-search time-date mailabbrev gmm-utils mailheader mm-decode mm-bodies mm-encode mail-utils gnutls network-stream url-http mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr url-gw nsm rmc puny url-cache url-auth url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap epg finder-inf package easymenu epg-config url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib elec-pair mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads w32notify w32 lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 76305 10007) (symbols 48 8292 1) (strings 32 24152 2632) (string-bytes 1 719178) (vectors 16 12539) (vector-slots 8 154153 12968) (floats 8 25 327) (intervals 56 2362 126) (buffers 992 13)) --0000000000006c1cec0588dfae91 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Recipe from 'emacs -= Q': [M-x package-list-packages RET].

Symptoms: The package list = is displayed but an *Error* buffer pops up:

Failed to verify signatu= re archive-contents.sig:
Bad signature from 474F05837FBDEF9B GNU ELPA Si= gning Agent (2014) <elpasign@el= pa.gnu.org>
Command output:
gpg: Signature made 05/14/19 22:10= :03 GMT Summer Time
gpg:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 using DSA key CA442C00F91774F17F= 59D9B0474F05837FBDEF9B
gpg: BAD signature from "GNU ELPA Signing Ag= ent (2014) <elpasign@elpa.gnu.o= rg>" [unknown]

GPG version:
<= div>
gpg (GnuPG) 2.2.11
libgcrypt 1.8.4
Copyright (C) 2= 018 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or = later <https://gnu.org/lic= enses/gpl.html>
This is free software: you are free to change and= redistribute it.
There is NO WARRANTY, to the extent permitted by law.<= br>
Home: C:/Users/buster/AppData/Roaming/gnupg
Supported algorithms:=
Pubkey: RSA, ELG, DSA, ECDH, ECDSA, EDDSA
Cipher: IDEA, 3DES, CAST5,= BLOWFISH, AES, AES192, AES256, TWOFISH,
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 CAMELLIA128, CAMELLIA192, CAMELLIA256
Hash: SHA1, RIPEMD160= , SHA256, SHA384, SHA512, SHA224
Compression: Uncompressed, ZIP, ZLIB, B= ZIP2


In GNU Emacs = 27.0.50 (build 7, x86_64-w64-mingw32)
=C2=A0of 2019-05-12 built on MACHI= NE
Repository revision: 9e1bb6a2f6c2462b9652ffce706c549269740307
Repo= sitory branch: buster
Windowing system distributor 'Microsoft Corp.&= #39;, version 10.0.18890
System Description: Microsoft Windows 10 Pro (v= 10.0.1903.18890.1000)

Recent messages:
For information about GNU = Emacs and the GNU system, type C-h C-a.
Importing package-keyring.gpg...= done
Package refresh done
error in process filter: package--check-sig= nature-content: Failed to verify signature: "archive-contents.sig"= ;
error in process filter: Failed to verify signature: "archive-con= tents.sig"

Configured using:
=C2=A0'configure --config-c= ache --with-modules --without-pop --without-dbus
=C2=A0--without-gconf -= -without-gsettings CFLAGS=3D-O3'

Configured features:
XPM JPE= G TIFF GIF PNG RSVG SOUND NOTIFY W32NOTIFY ACL GNUTLS LIBXML2
ZLIB TOOLK= IT_SCROLL_BARS MODULES THREADS JSON PDUMPER LCMS2 GMP

Important sett= ings:
=C2=A0 value of $EMACSLOADPATH: c:\emacs-lisp;
=C2=A0 value of = $LANG: ENG
=C2=A0 locale-coding-system: cp1252

Major mode: Packag= e Menu

Minor modes in effect:
=C2=A0 tooltip-mode: t
=C2=A0 gl= obal-eldoc-mode: t
=C2=A0 electric-indent-mode: t
=C2=A0 mouse-wheel-= mode: t
=C2=A0 tool-bar-mode: t
=C2=A0 menu-bar-mode: t
=C2=A0 fil= e-name-shadow-mode: t
=C2=A0 global-font-lock-mode: t
=C2=A0 font-loc= k-mode: t
=C2=A0 blink-cursor-mode: t
=C2=A0 auto-composition-mode: t=
=C2=A0 auto-encryption-mode: t
=C2=A0 auto-compression-mode: t
= =C2=A0 buffer-read-only: t
=C2=A0 line-number-mode: t
=C2=A0 transien= t-mark-mode: t

Load-path shadows:
None found.

Features:(shadow sort mail-extr emacsbug sendmail help-mode mm-archive message
d= ired dired-loaddefs format-spec rfc822 mml mml-sec epa derived
gnus-util= rmail rmail-loaddefs text-property-search time-date mailabbrev
gmm-util= s mailheader mm-decode mm-bodies mm-encode mail-utils gnutls
network-str= eam url-http mail-parse rfc2231 rfc2047 rfc2045 mm-util
ietf-drums mail-= prsvr url-gw nsm rmc puny url-cache url-auth url
url-proxy url-privacy u= rl-expand url-methods url-history url-cookie
url-domsuf url-util mailcap= epg finder-inf package easymenu epg-config
url-handlers url-parse auth-= source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache jso= n subr-x map url-vars seq byte-opt gv
bytecomp byte-compile cconv cl-loa= ddefs cl-lib elec-pair mule-util
tooltip eldoc electric uniquify ediff-h= ook vc-hooks lisp-float-type
mwheel dos-w32 ls-lisp disp-table term/w32-= win w32-win w32-vars
term/common-win tool-bar dnd fontset image regexp-o= pt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mo= de
prog-mode register page menu-bar rfn-eshadow isearch timer select
= scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-c= olors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tib= etan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek rom= anian slovak czech european ethiopic indian cyrillic
chinese composite c= harscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev = obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face m= acroexp files text-properties overlay sha1 md5
base64 format env code-pa= ges mule custom widget hashtable-print-readable
backquote threads w32not= ify w32 lcms2 multi-tty make-network-process
emacs)

Memory inform= ation:
((conses 16 76305 10007)
=C2=A0(symbols 48 8292 1)
=C2=A0(s= trings 32 24152 2632)
=C2=A0(string-bytes 1 719178)
=C2=A0(vectors 16= 12539)
=C2=A0(vector-slots 8 154153 12968)
=C2=A0(floats 8 25 327)=C2=A0(intervals 56 2362 126)
=C2=A0(buffers 992 13))

--0000000000006c1cec0588dfae91-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 14 17:38:08 2019 Received: (at 35739) by debbugs.gnu.org; 14 May 2019 21:38:08 +0000 Received: from localhost ([127.0.0.1]:50115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQf7f-0006Mt-Ug for submit@debbugs.gnu.org; Tue, 14 May 2019 17:38:08 -0400 Received: from mail-oi1-f179.google.com ([209.85.167.179]:35515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQf7e-0006MU-Qy for 35739@debbugs.gnu.org; Tue, 14 May 2019 17:38:07 -0400 Received: by mail-oi1-f179.google.com with SMTP id a132so284360oib.2 for <35739@debbugs.gnu.org>; Tue, 14 May 2019 14:38:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=qZ28p3Ge2EE9e5nuzNFwROKKRDiIvE6zaO+sSCHIzvo=; b=bbkf2BvVhDRXTRz8Mys9uELP2RqsmMktaCRJatNr1QwIdovSYxv5DMMJNl1IgqleK1 PlN8bvVUqkjqQwH8uSselmBkyuiud9m7ZXQRWzDqibcL6x4OVplqGYHpuxE4PpEtCk7q nDvuypmuigYxbDTLsQmRx0mA7VvWjGU1CAdLibqmwvPcczr7PfDIkscK41BZEgfRopMO 12q/wfa+yxL0I3TUzSmTH8H6o7zVZKTcYdQdFCpg07RPXNU08549Rhjh3XLxxxoMEGLi x6Z2wVxBBcfjFgI92tOSzR2ORh+oxbwPESoPnNMIcxI5v5WwTwdlHALtYuXmGRrC/1lQ bHHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=qZ28p3Ge2EE9e5nuzNFwROKKRDiIvE6zaO+sSCHIzvo=; b=TQsXQhFi9Uay0U+euiK/3ewe3Zwq77XZro7m8vXdfFUZppocvsxaaerAJ3+FBRkivM NozeJi6Dokuh4xGuqCt3YD1wZTCW3HT1BewZjIN2rrQmqTob8JI190+y8taVeq2AR4ig +5uDE9PAFN5D/WeXTSv6A8AQUzUlO/aYj3Sa40f9jP1nRnGZi0ElysqkOFfTbOayhjKq be1C6RdYP9Dh7XE7ACHTT350obuON255SAPTbRAQSn/0gCUUVd67nInC6clvTjxS0fr8 59q4tVgfljmTU5xo/xO61HSw9vwLZ9rfIACrjW6DywMIIkhant1YNMPI613g7p7/4M+M D8xw== X-Gm-Message-State: APjAAAU22YvkS4WYMSw62/b3u+oBeXnOiElO9aQU/OO1Ymex3zGT6+kb tbFl4XXOgmKbbZkZEUezWNcx5Uq5yoFQnWQNjktrmoZP2AA= X-Google-Smtp-Source: APXvYqx7HB/f9w4h0eDz4f0xQvI3XNfsMqZmvDFxSEBiNw1CMPTfVO/JY39CHhPCi97+dbIKRpJjUQDEE13KA6pFBKo= X-Received: by 2002:aca:4c4e:: with SMTP id z75mr237656oia.117.1557869879659; Tue, 14 May 2019 14:37:59 -0700 (PDT) MIME-Version: 1.0 From: Richard Copley Date: Tue, 14 May 2019 22:37:33 +0100 Message-ID: Subject: Re: bug#35739: Acknowledgement (Bad signature from GNU ELPA) To: 35739@debbugs.gnu.org Content-Type: multipart/alternative; boundary="000000000000c890f30588dfd829" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35739 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000c890f30588dfd829 Content-Type: text/plain; charset="UTF-8" I wrote: >Repository revision: 9e1bb6a2f6c2462b9652ffce706c549269740307 >Repository branch: buster This is a local branch with some irrelevant patches on top of this recent commit in the FSF master branch: fsf/master 29531785a17acf519070b73b488ad87ddd94aff7 Author: Noam Postavsky AuthorDate: Sun May 5 13:24:15 2019 -0400 Commit: Noam Postavsky CommitDate: Sun May 12 08:05:01 2019 -0400 --000000000000c890f30588dfd829 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I wrote:

>Repository revision: = 9e1bb6a2f6c2462b9652ffce706c549269740307
>Repository branch: buster
This is a local branch with some irrelevant patches on top of this re= cent
commit in the FSF master branch:

fsf/master 29531785a17acf51= 9070b73b488ad87ddd94aff7
Author:=C2=A0=C2=A0=C2=A0=C2=A0 Noam Postavsky = <npostavs@gmail.com>
Aut= horDate: Sun May 5 13:24:15 2019 -0400
Commit:=C2=A0=C2=A0=C2=A0=C2=A0 N= oam Postavsky <npostavs@gmail.com<= /a>>
CommitDate: Sun May 12 08:05:01 2019 -0400

--000000000000c890f30588dfd829-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 14 18:04:57 2019 Received: (at 35739) by debbugs.gnu.org; 14 May 2019 22:04:57 +0000 Received: from localhost ([127.0.0.1]:50157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQfXd-000743-DQ for submit@debbugs.gnu.org; Tue, 14 May 2019 18:04:57 -0400 Received: from mail-io1-f45.google.com ([209.85.166.45]:39824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQfXb-00073l-Gn; Tue, 14 May 2019 18:04:56 -0400 Received: by mail-io1-f45.google.com with SMTP id m7so557647ioa.6; Tue, 14 May 2019 15:04:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=OJT+ybfDrw3pXViYRF02q1q+DwPbawKv128hxTpX0Eo=; b=dZi13f/gmjkE65xxkWWDA6oipmgsSVnZ2KvYWOov8JFNe7hOGFnWOzFg5Ws2Uh2lPh 4pdqrq6OLJvxF+MRk5HFxIrVQmK1thMYBTiFo9s4gQvlfGSrHyhMloExWugWF5zLGVUM 9arRggVfyIjO2eCduMVr+g/E046z56EhBq95SIo83jrwqfFrWqO9zVJbxkW+yCqjhxQg e7fEQdVQgIAO1ug9v2p/NhqfTmSn0URJij5PvtBSEZlzwuoCef6fUsLhqvBAmXIQoluw JPm2KXjr2UAgF3rsohKZEr+/gRyqQ39gn40sR4s2LDIZtSb10bQpaUiki+CS9WwTZIKf wmJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=OJT+ybfDrw3pXViYRF02q1q+DwPbawKv128hxTpX0Eo=; b=mWbFi8ixKFHtX/8kVeMhbI4hTlixJ0NbQmFuQtKlo5TWCdCsDW0Du+Ct/WcYqn5+Sq lX8b31fiOfL+KbSF2HQh+/JHJe947zbwurTAPQQVacdqSTdOhZBohzuA62Rpdn083jo2 99FtHEPKZk3IILwHi2+4x4DTQy//ug6KWsX2nTR+ONLJRT4XV53N/4Nblh9XfNhubuf3 PzCxDTlmTPfuLvhoCUnDoatIkYgzfDqUT9/ox7Phk6Hed57bCIPcsYN1ltbVW3K/WrCJ SGWwbutV162pgYsWGKy21HVLRpTOly9jEupgBKqHQQj78jO46MnYMtEue5KcfAqZg3fs lQGg== X-Gm-Message-State: APjAAAUv7zHWEy87z7NHL+4NLfLkQTzm/XgcqeKlb4MQuH6RMvLFOYC8 d5XxAmkzINZ7zsO2K61TpbIvurfT X-Google-Smtp-Source: APXvYqyWyijUWGytZ0hTyAFs1fmSpsFEvBhsX5jQUs+eqoKztO6MBHpc6uXz8mUXOBhN6NEI0J+h8A== X-Received: by 2002:a5d:851a:: with SMTP id q26mr6920186ion.246.1557871489865; Tue, 14 May 2019 15:04:49 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id j11sm189226itj.11.2019.05.14.15.04.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 May 2019 15:04:49 -0700 (PDT) From: Noam Postavsky To: Richard Copley Subject: Re: bug#35739: Bad signature from GNU ELPA References: Date: Tue, 14 May 2019 18:04:47 -0400 In-Reply-To: (Richard Copley's message of "Tue, 14 May 2019 22:25:42 +0100") Message-ID: <87mujog0ao.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35739 Cc: 35739@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) retitle 35739 [w32] Bad signature from GNU ELPA for archive-contents quit Richard Copley writes: > Recipe from 'emacs -Q': [M-x package-list-packages RET]. > > Symptoms: The package list is displayed but an *Error* buffer pops up: > > Failed to verify signature archive-contents.sig: > Bad signature from 474F05837FBDEF9B GNU ELPA Signing Agent (2014) < > elpasign@elpa.gnu.org> > Command output: > gpg: Signature made 05/14/19 22:10:03 GMT Summer Time > gpg: using DSA key CA442C00F91774F17F59D9B0474F05837FBDEF9B > gpg: BAD signature from "GNU ELPA Signing Agent (2014) < > elpasign@elpa.gnu.org>" [unknown] > gpg (GnuPG) 2.2.11 > In GNU Emacs 27.0.50 (build 7, x86_64-w64-mingw32) > of 2019-05-12 built on MACHINE I can reproduce on my Windows machine, but not on GNU/Linux. Maybe some line endings are getting converted? I also noticed that doing (setq package-check-signature nil), M-x package-refresh-contents, (setq package-check-signature t), lets packages be installed successfully. It's only the archive-contents that fails to verify. From debbugs-submit-bounces@debbugs.gnu.org Tue May 14 18:27:04 2019 Received: (at 35739) by debbugs.gnu.org; 14 May 2019 22:27:04 +0000 Received: from localhost ([127.0.0.1]:50199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQft2-0001Hz-3q for submit@debbugs.gnu.org; Tue, 14 May 2019 18:27:04 -0400 Received: from mail-oi1-f179.google.com ([209.85.167.179]:35075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQfsz-0001HQ-Tn for 35739@debbugs.gnu.org; Tue, 14 May 2019 18:27:02 -0400 Received: by mail-oi1-f179.google.com with SMTP id a132so370025oib.2 for <35739@debbugs.gnu.org>; Tue, 14 May 2019 15:27:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vNsLfvvwl+vIsD7mpLj1GpnwmZKsceHzK1NXXCfbdVE=; b=TcusliUiOnGr3+O/I1anbHC6JPz21t8eTovNxWY6gNF5O9H1bezcR9O/A+93JDdwxT Iml6w9MYGcZpSwzqIHDeHhpwLxVDzHNAVFLG5gsrkV3fFa2t2lSoct8do3UUQLgCY5T1 A7Qmh6NeBpk2HwNtKUQEjFDtme2wdnqH6Q67ntdgjslWFdy4RcjSF4papkBm7GyG6BpR YIYdyL22+qby6px6Z+Z96Xj7OkWCchyoCBgpf3xUaujHg/NnKALyEkTgwRJUhGxIOLFR 7uqbNqnUn3m2+7dcJ5RS8/h8nAgoAmVn5krRmSkbrWvfh2Sxqj5CtdqJOyECO50hUcI6 vCwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vNsLfvvwl+vIsD7mpLj1GpnwmZKsceHzK1NXXCfbdVE=; b=aOfaUr4celttGkufM+ECouPAJYmsqwSGilvZ9NJOo9XTNoHXcDsRZ9QA3P3y4gSRrp gnuc1s/49hU/NI2/QIDP9XuMnlcHBtUyb8wCqbCA7EZT2ASw7WBKmM43ZyOuaSoCZsXh XlNjDvJN5R0Z1oL2DKo7H2NLd9Tpsc2HVD1zj+PRy9byVxfsNuirDNLkptMWb3Eycf+U +g0oAHpLK9xm0mSuA5vuc+YwGVRrhgdtTa3dB1H6H0k2VgHO5rgafbYfHESbR89RBzo8 TO4RaFS+SDOh1AGSsZWahtjZ4IoCioww5AvLlWxzAT21XzD/WHePQQxEC+BEXZjrgUkr 4B+A== X-Gm-Message-State: APjAAAXoB7dM7bwjv4JrkwFaUfME4MN9eyvaPKdZdASrRpebQ2YmB6GX 2XK57tHrGRudoQlxNrbfInbooYEdZl9iFrPUHko= X-Google-Smtp-Source: APXvYqzK4rhpGbrMdcgksatAZ4ccSxr+5wV9qJxkVPI4NiglqI3FyAL/BHIIwPm4GuaPSbn08ADYLeLWf4LNOP2jDVc= X-Received: by 2002:aca:4fd3:: with SMTP id d202mr4386756oib.153.1557872814172; Tue, 14 May 2019 15:26:54 -0700 (PDT) MIME-Version: 1.0 References: <87mujog0ao.fsf@gmail.com> In-Reply-To: <87mujog0ao.fsf@gmail.com> From: Richard Copley Date: Tue, 14 May 2019 23:26:27 +0100 Message-ID: Subject: Re: bug#35739: Bad signature from GNU ELPA To: Noam Postavsky Content-Type: multipart/mixed; boundary="000000000000b1c9a50588e0870b" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35739 Cc: 35739@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000b1c9a50588e0870b Content-Type: multipart/alternative; boundary="000000000000b1c9a20588e08709" --000000000000b1c9a20588e08709 Content-Type: text/plain; charset="UTF-8" On Tue, 14 May 2019 at 23:04, Noam Postavsky wrote: > I can reproduce on my Windows machine, but not on GNU/Linux. Maybe some > line endings are getting converted? > Thanks, that seems to be it: the attached patch gets rid of the bug (but obviously isn't TRT). --000000000000b1c9a20588e08709 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Tue, 14 May 2019 at 23:04, Noam Postavsky <npostavs@gmail.com> wrote:
I can reproduce on my Windows mach= ine, but not on GNU/Linux.=C2=A0 Maybe some
line endings are getting converted?

Tha= nks, that seems to be it: the attached patch gets rid of the bug (but obvio= usly isn't TRT).

--000000000000b1c9a20588e08709-- --000000000000b1c9a50588e0870b Content-Type: application/octet-stream; name="35739-test.patch" Content-Disposition: attachment; filename="35739-test.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jvod84lt0 ZGlmZiAtLWdpdCBhL2xpc3AvdXJsL3VybC1oYW5kbGVycy5lbCBiL2xpc3AvdXJsL3VybC1oYW5k bGVycy5lbAppbmRleCBlMzVkOTk5ZTBmLi5mOGFmMmNlODhjIDEwMDY0NAotLS0gYS9saXNwL3Vy bC91cmwtaGFuZGxlcnMuZWwKKysrIGIvbGlzcC91cmwvdXJsLWhhbmRsZXJzLmVsCkBAIC0zMzQs MTEgKzMzNCwxMSBAQCB1cmwtaW5zZXJ0LWJ1ZmZlci1jb250ZW50cwogICAgICAgKHdoZW4gcmVw bGFjZQogICAgICAgICAoZGVsZXRlLXJlZ2lvbiAocG9pbnQtbWluKSBzdGFydCkKICAgICAgICAg KGRlbGV0ZS1yZWdpb24gKHBvaW50KSAocG9pbnQtbWF4KSkpCi0gICAgICAodW5sZXNzIChjYWRy IHNpemUtYW5kLWNoYXJzZXQpCi0gICAgICAgIDs7IElmIHRoZSBoZWFkZXJzIGRvbid0IHNwZWNp ZnkgYW55IHBhcnRpY3VsYXIgY2hhcnNldCwgdXNlIHRoZQotICAgICAgICA7OyB1c3VhbCBoZXVy aXN0aWMvcnVsZXMgdGhhdCB3ZSBhcHBseSB0byBmaWxlcy4KLSAgICAgICAgKGRlY29kZS1jb2Rp bmctaW5zZXJ0ZWQtcmVnaW9uIChwb2ludC1taW4pIChwb2ludCkgdXJsCi0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB2aXNpdCBiZWcgZW5kIHJlcGxhY2UpKQorICAgICAg OzsgKHVubGVzcyAoY2FkciBzaXplLWFuZC1jaGFyc2V0KQorICAgICAgOzsgICA7OyBJZiB0aGUg aGVhZGVycyBkb24ndCBzcGVjaWZ5IGFueSBwYXJ0aWN1bGFyIGNoYXJzZXQsIHVzZSB0aGUKKyAg ICAgIDs7ICAgOzsgdXN1YWwgaGV1cmlzdGljL3J1bGVzIHRoYXQgd2UgYXBwbHkgdG8gZmlsZXMu CisgICAgICA7OyAgIChkZWNvZGUtY29kaW5nLWluc2VydGVkLXJlZ2lvbiAocG9pbnQtbWluKSAo cG9pbnQpIHVybAorICAgICAgOzsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdmlz aXQgYmVnIGVuZCByZXBsYWNlKSkKICAgICAgIChsZXQgKChpbnNlcnRlZCAoY2FyIHNpemUtYW5k LWNoYXJzZXQpKSkKICAgICAgICAgKHdoZW4gKGZib3VuZHAgJ2FmdGVyLWluc2VydC1maWxlLXNl dC1jb2RpbmcpCiAgICAgICAgICAgKGxldCAoKGluc3ZhbCAoYWZ0ZXItaW5zZXJ0LWZpbGUtc2V0 LWNvZGluZyBpbnNlcnRlZCB2aXNpdCkpKQo= --000000000000b1c9a50588e0870b-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 14 18:43:05 2019 Received: (at 35739) by debbugs.gnu.org; 14 May 2019 22:43:05 +0000 Received: from localhost ([127.0.0.1]:50221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQg8W-0001hL-VY for submit@debbugs.gnu.org; Tue, 14 May 2019 18:43:05 -0400 Received: from mail-oi1-f182.google.com ([209.85.167.182]:33150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQg8V-0001gq-Jm for 35739@debbugs.gnu.org; Tue, 14 May 2019 18:43:04 -0400 Received: by mail-oi1-f182.google.com with SMTP id m204so400512oib.0 for <35739@debbugs.gnu.org>; Tue, 14 May 2019 15:43:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X9x5Wp70QCkVoxY8qc0e7Qh4HZ6WsGEXIwUea9n1pQc=; b=Wtod0n3zTLifO+4s5w91XCn9u63EWnr3RJ+2HmH+TdfExhiPA0D3XeL9c8hCl+Shup QUgyhNXumaUEaIvYD6POi+X951wa2dnE0Zv+jwuFloFvHXLrW2dLwXrqiICV+K3dG3OB CRtZ07xeUe8FQVnOV+emuqL9JDS0BOj6IgplLEuzraMSKIGdnSXekUEXxp/bY7fSRMl3 YuTcIm3MWzbnwjJgUHJq85yXbblg/BhGwQYTUFfdzYAo7xpDxSDlTjPLWg9UIho5ysgk wsUTwIRddL4bvcYjNyIB/1D1W2yTy3K3QNNw/wthGGsPI/Ths5cXRZTp3znEKLxv6yP/ CxXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X9x5Wp70QCkVoxY8qc0e7Qh4HZ6WsGEXIwUea9n1pQc=; b=P+QfJhmXjCAGHXgoLFx4aYkmxDC+P0OwAZPkePWP2e9kc5+MddfuKHBBs4MSMJ6de1 NY3FOO5BgH4p6JIWSNNrSmi8Wpe3TH3ru/GRo1XjNCaivbmZZYBFUQ4T+EdNzVPIdPzo EY0Nfh9zsepm6FrksUkxOUBIUjVff+88v5YNGy85hLYi3sYcFnQvCJkpcJ/2ZRuFEuUn 7v2nJA3xOmo8w+FYJvxIRo0E/bAucT3rP+OAyShq+0CnjC2RTtBx7y7CMO0SSaGgat4E pMURYsDtT2BFI/WxiCQ0aRUka5hF2B0F2GchbmPBmtiDPQRiXaguLa23SqeD2Y02nJ95 2tlA== X-Gm-Message-State: APjAAAWQjzH+Xr91BbB8HIwe8jwkoiK1OW81Gvk6b5wFRMj7AvvSnNGx vCWJ8eGicRcg4TfVgLFMwi+k5L+vdkF4spiyFwM= X-Google-Smtp-Source: APXvYqy5PvLnlUdLxCF6jPcGLwyo1htJlo2YgR6jyYmNzcufUik9BTuB1Yw9Cg6lIjgfUy9uC5oARJkUf+0vrVDu+vI= X-Received: by 2002:aca:ef43:: with SMTP id n64mr4855453oih.79.1557873777865; Tue, 14 May 2019 15:42:57 -0700 (PDT) MIME-Version: 1.0 References: <87mujog0ao.fsf@gmail.com> In-Reply-To: From: Richard Copley Date: Tue, 14 May 2019 23:42:31 +0100 Message-ID: Subject: Re: bug#35739: Bad signature from GNU ELPA To: Noam Postavsky Content-Type: multipart/alternative; boundary="0000000000002279ef0588e0c156" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35739 Cc: 35739@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000002279ef0588e0c156 Content-Type: text/plain; charset="UTF-8" On Tue, 14 May 2019 at 23:26, Richard Copley wrote: > > On Tue, 14 May 2019 at 23:04, Noam Postavsky wrote: > >> I can reproduce on my Windows machine, but not on GNU/Linux. Maybe some >> line endings are getting converted? >> > > Thanks, that seems to be it: the attached patch gets rid of the bug (but > obviously isn't TRT). > ... and (apologies) I don't have a copyright assignment on file, so I'll have to leave it to Somebody to do TRT. TIA, Somebody! Buster. --0000000000002279ef0588e0c156 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, 14 May 2019 at 23:26, Richard Copley <rcopley@gmail.com> wrote:

On Tue, 14 M= ay 2019 at 23:04, Noam Postavsky <npostavs@gmail.com> wrote:
I can reproduce on my Windows machine, = but not on GNU/Linux.=C2=A0 Maybe some
line endings are getting converted?

Tha= nks, that seems to be it: the attached patch gets rid of the bug (but obvio= usly isn't TRT).

... and (= apologies) I don't have a copyright assignment on file, so I'll hav= e to
leave it to Somebody to do TRT.
<= div class=3D"gmail_quote">
TIA, Somebod= y!
Buster.=

--0000000000002279ef0588e0c156-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 14 22:42:25 2019 Received: (at 35739) by debbugs.gnu.org; 15 May 2019 02:42:25 +0000 Received: from localhost ([127.0.0.1]:50560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQjs9-0007mt-9A for submit@debbugs.gnu.org; Tue, 14 May 2019 22:42:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQjs7-0007mg-Am for 35739@debbugs.gnu.org; Tue, 14 May 2019 22:42:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47775) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQjrr-0001NJ-5q; Tue, 14 May 2019 22:42:09 -0400 Received: from [176.228.60.248] (port=1529 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hQjrm-0004VU-Nu; Tue, 14 May 2019 22:42:05 -0400 Date: Wed, 15 May 2019 05:41:47 +0300 Message-Id: <837easa178.fsf@gnu.org> From: Eli Zaretskii To: Richard Copley In-reply-to: (message from Richard Copley on Tue, 14 May 2019 23:26:27 +0100) Subject: Re: bug#35739: Bad signature from GNU ELPA References: <87mujog0ao.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35739 Cc: 35739@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Richard Copley > Date: Tue, 14 May 2019 23:26:27 +0100 > Cc: 35739@debbugs.gnu.org > > Thanks, that seems to be it: the attached patch gets rid of the bug (but obviously isn't TRT). > > diff --git a/lisp/url/url-handlers.el b/lisp/url/url-handlers.el > index e35d999e0f..f8af2ce88c 100644 > --- a/lisp/url/url-handlers.el > +++ b/lisp/url/url-handlers.el > @@ -334,11 +334,11 @@ url-insert-buffer-contents > (when replace > (delete-region (point-min) start) > (delete-region (point) (point-max))) > - (unless (cadr size-and-charset) > - ;; If the headers don't specify any particular charset, use the > - ;; usual heuristic/rules that we apply to files. > - (decode-coding-inserted-region (point-min) (point) url > - visit beg end replace)) > + ;; (unless (cadr size-and-charset) > + ;; ;; If the headers don't specify any particular charset, use the > + ;; ;; usual heuristic/rules that we apply to files. > + ;; (decode-coding-inserted-region (point-min) (point) url > + ;; visit beg end replace)) > (let ((inserted (car size-and-charset))) > (when (fboundp 'after-insert-file-set-coding) > (let ((insval (after-insert-file-set-coding inserted visit))) I don't see how disabling decoding could make sense, can you explain? What does this code do on GNU/Linux? From debbugs-submit-bounces@debbugs.gnu.org Tue May 14 22:42:59 2019 Received: (at 35739) by debbugs.gnu.org; 15 May 2019 02:42:59 +0000 Received: from localhost ([127.0.0.1]:50563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQjsg-0007nj-ON for submit@debbugs.gnu.org; Tue, 14 May 2019 22:42:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQjse-0007nT-CB for 35739@debbugs.gnu.org; Tue, 14 May 2019 22:42:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQjsZ-0001ta-7L; Tue, 14 May 2019 22:42:51 -0400 Received: from [176.228.60.248] (port=1575 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hQjsT-0004Xh-Un; Tue, 14 May 2019 22:42:49 -0400 Date: Wed, 15 May 2019 05:42:33 +0300 Message-Id: <835zqca15y.fsf@gnu.org> From: Eli Zaretskii To: Richard Copley In-reply-to: (message from Richard Copley on Tue, 14 May 2019 23:42:31 +0100) Subject: Re: bug#35739: Bad signature from GNU ELPA References: <87mujog0ao.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35739 Cc: 35739@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Richard Copley > Date: Tue, 14 May 2019 23:42:31 +0100 > Cc: 35739@debbugs.gnu.org > > ... and (apologies) I don't have a copyright assignment on file, so I'll have to > leave it to Somebody to do TRT. The change is small enough for us not to be bothered by that. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed May 15 02:46:53 2019 Received: (at 35739) by debbugs.gnu.org; 15 May 2019 06:46:53 +0000 Received: from localhost ([127.0.0.1]:50816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQngi-0007RY-KW for submit@debbugs.gnu.org; Wed, 15 May 2019 02:46:52 -0400 Received: from mail-oi1-f179.google.com ([209.85.167.179]:32815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQngb-0007RG-QU for 35739@debbugs.gnu.org; Wed, 15 May 2019 02:46:50 -0400 Received: by mail-oi1-f179.google.com with SMTP id m204so1042001oib.0 for <35739@debbugs.gnu.org>; Tue, 14 May 2019 23:46:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dHYN44zpYLShusEHUsbwqKzPxD0qtuX8Xh3vVPWtTCQ=; b=r7opL059qVQhqDnqlqGAKGfO1eySHhs/zOdbDSZo3rA0hyoJTRGzl0Q/VbBENMJZBC zOUe2hmwlGHhAcPjN/UxX2aXhj7k5R3l31l13JnESx5BMV+73QMLzE5omxi7ZW3NhsTk YYoEkbBQ1lvaEgbBAs+QBfi6RYoDW26hbAFz0bvatOH+NCweD1C1KDx2jXkiCv6yEDVQ slW3xTuJncBjCYU4N5JNhmAIgRSNwg8Dyfccd/1w9MTh1/SVYJfm2fkP+5rVc/d6CHBp 8R1sKOHEEznPz7fZ2B0kix4KR8nN3GzuWNeCP4dH658nmIzjdrz/wg8DabA1qlV+e8lg TNDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dHYN44zpYLShusEHUsbwqKzPxD0qtuX8Xh3vVPWtTCQ=; b=XXAuMM3FwCRg0jlYFV2xqWOFGEMuNHfgeVkr4ctksyO2M2UkvqKQhT6TuNYPkLbULo ANT6R6lA5ightMsDZ+SM5hGwcsupr+2/Z9mHEaFE9m5LaFoaRANRRl6AuQ0jqKu2fIsn OB4qhOIBZxxm9ZRlpUcudeZ06JkPgwEwSvd8W2j7HQHBa7Nt5qQyDbkfIL9rxmEtoFAR 6jpCsau2ciaEBex5fnz6JihAN/exCNCaLNiOeda53iNi+21ik4CRfD0ySDd+/DjaPMEc ZnXndHIwrtZEAgdNMpFaKzurrckAFl0ftE6edBgu1LUFPbhVC937+qXLj79zkzH+qVwB 6AtA== X-Gm-Message-State: APjAAAW7krEUTpqj1EZEMfsaxyyooepDZtzbswUIyEF1QNxGElAlME6e GaFdKuo3szPEduRyvZND1SsZzakGwKJrwbiRyR0= X-Google-Smtp-Source: APXvYqwA0iSvk+b+cTMu/Bds1vEmeZcIsJK3XbpyD5Sa5k2f80xrbIciOu+exSUYz9tR7Td/K0IZ6qragNHhN4qYG30= X-Received: by 2002:aca:b1d4:: with SMTP id a203mr5545035oif.67.1557902800009; Tue, 14 May 2019 23:46:40 -0700 (PDT) MIME-Version: 1.0 References: <87mujog0ao.fsf@gmail.com> <837easa178.fsf@gnu.org> In-Reply-To: <837easa178.fsf@gnu.org> From: Richard Copley Date: Wed, 15 May 2019 07:46:12 +0100 Message-ID: Subject: Re: bug#35739: Bad signature from GNU ELPA To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000fd516b0588e7825a" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35739 Cc: 35739@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000fd516b0588e7825a Content-Type: text/plain; charset="UTF-8" On Wed, 15 May 2019 at 03:42, Eli Zaretskii wrote: > > From: Richard Copley > > Date: Tue, 14 May 2019 23:26:27 +0100 > > Cc: 35739@debbugs.gnu.org > > > > Thanks, that seems to be it: the attached patch gets rid of the bug (but > obviously isn't TRT). > > > > diff --git a/lisp/url/url-handlers.el b/lisp/url/url-handlers.el > > index e35d999e0f..f8af2ce88c 100644 > > --- a/lisp/url/url-handlers.el > > +++ b/lisp/url/url-handlers.el > > @@ -334,11 +334,11 @@ url-insert-buffer-contents > > (when replace > > (delete-region (point-min) start) > > (delete-region (point) (point-max))) > > - (unless (cadr size-and-charset) > > - ;; If the headers don't specify any particular charset, use the > > - ;; usual heuristic/rules that we apply to files. > > - (decode-coding-inserted-region (point-min) (point) url > > - visit beg end replace)) > > + ;; (unless (cadr size-and-charset) > > + ;; ;; If the headers don't specify any particular charset, use > the > > + ;; ;; usual heuristic/rules that we apply to files. > > + ;; (decode-coding-inserted-region (point-min) (point) url > > + ;; visit beg end replace)) > > (let ((inserted (car size-and-charset))) > > (when (fboundp 'after-insert-file-set-coding) > > (let ((insval (after-insert-file-set-coding inserted visit))) > > I don't see how disabling decoding could make sense, can you explain? > Not in detail, it's not an area of expertise of mine. We call (decode-coding-region (point-min) (point-max) 'undecided) on the payload of "https://elpa.gnu.org/packages/archive-contents", which is raw text. The resulting buffer's buffer-file-coding- system is iso-latin-1-dos. > > What does this code do on GNU/Linux? > The same. The resulting coding system is iso-latin-1-unix. --000000000000fd516b0588e7825a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, 15 May 20= 19 at 03:42, Eli Zaretskii <eliz@gnu.org= > wrote:
= > From: Richard Copley <rcopley@gmail.com>
> Date: Tue, 14 May 2019 23:26:27 +0100
> Cc: 35739@d= ebbugs.gnu.org
>
> Thanks, that seems to be it: the attached patch gets rid of the bug (b= ut obviously isn't TRT).
>
> diff --git a/lisp/url/url-handlers.el b/lisp/url/url-handlers.el
> index e35d999e0f..f8af2ce88c 100644
> --- a/lisp/url/url-handlers.el
> +++ b/lisp/url/url-handlers.el
> @@ -334,11 +334,11 @@ url-insert-buffer-contents
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 (when replace
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (delete-region (point-min) start) >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (delete-region (point) (point-max)))=
> -=C2=A0 =C2=A0 =C2=A0 (unless (cadr size-and-charset)
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; If the headers don't specify any p= articular charset, use the
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; usual heuristic/rules that we apply to= files.
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 (decode-coding-inserted-region (point-min= ) (point) url
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0visit= beg end replace))
> +=C2=A0 =C2=A0 =C2=A0 ;; (unless (cadr size-and-charset)
> +=C2=A0 =C2=A0 =C2=A0 ;;=C2=A0 =C2=A0;; If the headers don't speci= fy any particular charset, use the
> +=C2=A0 =C2=A0 =C2=A0 ;;=C2=A0 =C2=A0;; usual heuristic/rules that we = apply to files.
> +=C2=A0 =C2=A0 =C2=A0 ;;=C2=A0 =C2=A0(decode-coding-inserted-region (p= oint-min) (point) url
> +=C2=A0 =C2=A0 =C2=A0 ;;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 v= isit beg end replace))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 (let ((inserted (car size-and-charset))) >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (when (fboundp 'after-insert-fil= e-set-coding)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (let ((insval (after-insert-f= ile-set-coding inserted visit)))

I don't see how disabling decoding could make sense, can you explain?

Not in detail, it's not an area of expert= ise of mine. We call
(decode-coding-region (point-min) (point-max) '= undecided) on the
payload of "https://elpa.gnu.org/packages/archive-contents&qu= ot;,
which is raw text. The resulting buffer's buffer-file-coding-system is iso-latin-1-dos.
=C2=A0
What does this code do on GNU/Linux?

Th= e same. The resulting coding system is iso-latin-1-unix.

=
--000000000000fd516b0588e7825a-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 15 03:14:19 2019 Received: (at 35739) by debbugs.gnu.org; 15 May 2019 07:14:19 +0000 Received: from localhost ([127.0.0.1]:50842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQo7G-00087s-Nz for submit@debbugs.gnu.org; Wed, 15 May 2019 03:14:19 -0400 Received: from mail-ot1-f52.google.com ([209.85.210.52]:38160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQo7E-00087d-Lc for 35739@debbugs.gnu.org; Wed, 15 May 2019 03:14:17 -0400 Received: by mail-ot1-f52.google.com with SMTP id s19so1318673otq.5 for <35739@debbugs.gnu.org>; Wed, 15 May 2019 00:14:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NCC3aG/LPCUI1k3crIocSeqRdL2Vhn6NF1eZhb/pntw=; b=uyW340Kyy8VpLlYBBSm82kExuxSjSEuY4BbU+0hpikXyBY4VPPBe/M0GfVSsLkSiC2 uO1tCJ3Plu8Gafu4UFCU7QZS7tTWLlSxXMXJbehKTU6pil3o8EYFexJq7Xg607c093mz TtOb2Q5QEqfeVlJrHUgD63Vdzn90hRZam94VaIYz70PCeZ2LHF1RPrSYBvxd5+8rPsR+ cbOQLTL70NkiNskCE2mqZCrCj3+NTpcDFJ7ckaX0BTEFMHD6a35GBuEchPfG5PfKf1XJ kgzVievt3aJXQo2b6ouluma5RKVVGkE9cSfgVl0XPh0D1OnYpN7wrGnPOCH6hr7fHUzr P1bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NCC3aG/LPCUI1k3crIocSeqRdL2Vhn6NF1eZhb/pntw=; b=GTkW7iPlYbMb+jRGGpN9XpDS7buNfvBdzUOcioRaCGj0BpRsJSsrmXcqm08q4UeNm7 YEmpjkchV14A07qLB4uNnSHuId45vbwVFzNyU3RdDihJ2mjftvCscAiUEAGjXmaoTWVt lDRm/2ma57hedw8k8urGVZgBG/qC48lb7PnclyDCT6A27XYz8trpVWmhrR5o37FOSPLB BTEA0/rBZfQd1frX+K0YttU9YZgoW0lgx7u0IX6KS22cIw8yVrcxOlnJUOp9/zGeKYor D96+nsb/gBXrNl2sb/me5/0Olmw2qQ6KRzITSkH+fpAYc4TuyErU2MV6hRQLYkcCj7gY Zbuw== X-Gm-Message-State: APjAAAUDqRCXjAFhQJlKxtPOAl2mFwvRAWW/eC152gVEet7jb3cYoXTG BPq+EReZ7muh5j6pzRIKukUQOhZbl9hXTW+Bh0o= X-Google-Smtp-Source: APXvYqzHZVkYtSozwd/qJakuHVAbcXif1obIS4DzG7sjsmul+Ya+vOuWQBSOHMri9wp7I02Zaej722jBgBxnqQlRidE= X-Received: by 2002:a9d:5e91:: with SMTP id f17mr5288217otl.368.1557904450822; Wed, 15 May 2019 00:14:10 -0700 (PDT) MIME-Version: 1.0 References: <87mujog0ao.fsf@gmail.com> <835zqca15y.fsf@gnu.org> In-Reply-To: <835zqca15y.fsf@gnu.org> From: Richard Copley Date: Wed, 15 May 2019 08:13:43 +0100 Message-ID: Subject: Re: bug#35739: Bad signature from GNU ELPA To: Eli Zaretskii Content-Type: multipart/mixed; boundary="00000000000062cd130588e7e5c1" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35739 Cc: 35739@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000062cd130588e7e5c1 Content-Type: multipart/alternative; boundary="00000000000062cd110588e7e5bf" --00000000000062cd110588e7e5bf Content-Type: text/plain; charset="UTF-8" On Wed, 15 May 2019 at 03:42, Eli Zaretskii wrote: > > From: Richard Copley > > Date: Tue, 14 May 2019 23:42:31 +0100 > > Cc: 35739@debbugs.gnu.org > > > > ... and (apologies) I don't have a copyright assignment on file, so I'll > have to > > leave it to Somebody to do TRT. > > The change is small enough for us not to be bothered by that. > OK, then I have another reason to leave it to someone else: I don't understand the code in "package.el" and "url.el" well enough to be confident making changes there. The attached patch is less stupid, in that it doesn't have the potential to break all the users of url-retrieve. Still, I'm not asserting it's a sound or complete fix, or recommending it for inclusion in Emacs. It does get rid of the error from my recipe. --00000000000062cd110588e7e5bf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, 15 May 2019 at 03:42, Eli Zaretskii <eliz@gnu.org> wrote:<= br>
> From: Richa= rd Copley <rcople= y@gmail.com>
> Date: Tue, 14 May 2019 23:42:31 +0100
> Cc: 35739@d= ebbugs.gnu.org
>
> ... and (apologies) I don't have a copyright assignment on file, s= o I'll have to
> leave it to Somebody to do TRT.

The change is small enough for us not to be bothered by that.

OK, then I have another reason to leave it to someone els= e: I don't
understand the code in "package.el" and "u= rl.el" well enough to be
confident making changes there.

The= attached patch is less stupid, in that it doesn't have the
potentia= l to break all the users of url-retrieve. Still, I'm not
asserting i= t's a sound or complete fix, or recommending it for
inclusion in Ema= cs. It does get rid of the error from my recipe.
--00000000000062cd110588e7e5bf-- --00000000000062cd130588e7e5c1 Content-Type: application/octet-stream; name="35739.patch" Content-Disposition: attachment; filename="35739.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jvovyskb0 ZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsIGIvbGlzcC9lbWFjcy1saXNw L3BhY2thZ2UuZWwKaW5kZXggOTQ5YWQ3MTFhZS4uNmI3MGM1ZTJhMyAxMDA2NDQKLS0tIGEvbGlz cC9lbWFjcy1saXNwL3BhY2thZ2UuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwK QEAgLTEyMjUsNyArMTIyNSw3IEBAIHBhY2thZ2UtLXdpdGgtd29yay1idWZmZXIKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAoZ290by1jaGFyIChwb2ludC1taW4pKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICh1bmxlc3MgKHNlYXJjaC1mb3J3 YXJkLXJlZ2V4cCAiXlxyP1xuXHI/IiBuaWwgJ25vZXJyb3IpCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZXJyb3Ig IkVycm9yIHJldHJpZXZpbmc6ICVzICVTIiAsdXJsLXN5bSAiaW5jb21wcmVoZW5zaWJsZSBidWZm ZXIiKSkpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICh1cmwtaW5zZXJ0LWJ1ZmZlci1jb250ZW50cyAsYi1zeW0gLHVybC1z eW0pCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICh1cmwtaW5zZXJ0ICxiLXN5bSkKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGtpbGwtYnVmZmVyICxi LXN5bSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgKGdvdG8tY2hhciAocG9pbnQtbWluKSkpKSkKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbmlsCg== --00000000000062cd130588e7e5c1-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 15 10:04:11 2019 Received: (at 35739) by debbugs.gnu.org; 15 May 2019 14:04:11 +0000 Received: from localhost ([127.0.0.1]:53112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQuVv-0005rZ-4g for submit@debbugs.gnu.org; Wed, 15 May 2019 10:04:11 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQuVr-0005rM-UW for 35739@debbugs.gnu.org; Wed, 15 May 2019 10:04:09 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 816BA10087A; Wed, 15 May 2019 10:04:02 -0400 (EDT) Received: from mail02.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D7AFB1006F4; Wed, 15 May 2019 10:04:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1557929040; bh=xNVYB+LNho+Jv4nm62ZgnWY3gd1UW1/Qxlb6k01nZFw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=BoZMgU+SeOGDqGKXUmGaiVZmKzWNMp6Dnci/KoXxiz2V37IbWeYQBQL6nrpWNzkI3 Kngm3CVKdy+TsIw0/FEdbj4iAvcIL+pGSTrEFLTJTNrgCA+A9jCbj89dDDg773plso y/kBaCkchL0PtIGix84Vdhc5aygPOxTHBH4wbNiavNNHTD4nimP4qpypCuQ8A3Qfk2 sCIhCigEkJB4lozOWPgeSV4ZlYB66Elr+OWNhSWXub4ws/7AizY1j/0Dk/a/4PJTMq xj+bDTKK2oh/c4VHbeJQpLn7TN7Ib/ApFHhP/l12FFmJU6s693kgC6Mnaa/I8LqNmK UV3g7QN2Phfhw== Received: from pastel (69-196-155-191.dsl.teksavvy.com [69.196.155.191]) by mail02.iro.umontreal.ca (Postfix) with ESMTPSA id 04BC3120AA3; Wed, 15 May 2019 10:03:59 -0400 (EDT) From: Stefan Monnier To: Richard Copley Subject: Re: bug#35739: Bad signature from GNU ELPA Message-ID: References: <87mujog0ao.fsf@gmail.com> <835zqca15y.fsf@gnu.org> Date: Wed, 15 May 2019 10:03:57 -0400 In-Reply-To: (Richard Copley's message of "Wed, 15 May 2019 08:13:43 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35739 Cc: 35739@debbugs.gnu.org, Eli Zaretskii , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -1225,7 +1225,7 @@ package--with-work-buffer > (goto-char (point-min)) > (unless (search-forward-regexp "^\r?\n\r?" nil 'noerror) > (error "Error retrieving: %s %S" ,url-sym "incomprehensible buffer"))) > - (url-insert-buffer-contents ,b-sym ,url-sym) > + (url-insert ,b-sym) > (kill-buffer ,b-sym) > (goto-char (point-min))))) > nil [ Boy, this macro looks awfully deeply indented. We need to rewrite this to fit into the usual 80 columns. ] That actually looks very good [it would also need to change the other url-insert-file-contents in that macro, of course]. Eli, do you think this could also be a fix for bug#34909? E.g. something like the patch below? Stefan diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 949ad711ae..8a16dba1c2 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -1202,40 +1182,45 @@ package--with-work-buffer (let ((url-sym (make-symbol "url")) (b-sym (make-symbol "b-sym"))) `(cl-macrolet ((unless-error (body-2 &rest before-body) - (let ((err (make-symbol "err"))) - `(with-temp-buffer - (when (condition-case ,err - (progn ,@before-body t) - ,(list 'error ',error-form - (list 'unless ',noerror-1 - `(signal (car ,err) (cdr ,err))))) - ,@body-2))))) + (let ((err (make-symbol "err"))) + `(with-temp-buffer + (set-buffer-multibyte nil) + (when (condition-case ,err + (progn ,@before-body t) + ,(list 'error ',error-form + (list 'unless ',noerror-1 + `(signal (car ,err) + (cdr ,err))))) + ,@body-2))))) (if (string-match-p "\\`https?:" ,url-1) (let ((,url-sym (concat ,url-1 ,file))) (if ,async (unless-error nil - (url-retrieve ,url-sym - (lambda (status) - (let ((,b-sym (current-buffer))) - (require 'url-handlers) - (unless-error ,body - (when-let* ((er (plist-get status :error))) - (error "Error retrieving: %s %S" ,url-sym er)) - (with-current-buffer ,b-sym - (goto-char (point-min)) - (unless (search-forward-regexp "^\r?\n\r?" nil 'noerror) - (error "Error retrieving: %s %S" ,url-sym "incomprehensible buffer"))) - (url-insert-buffer-contents ,b-sym ,url-sym) - (kill-buffer ,b-sym) - (goto-char (point-min))))) - nil - 'silent)) - (unless-error ,body (url-insert-file-contents ,url-sym)))) + (url-retrieve + ,url-sym + (lambda (status) + (let ((,b-sym (current-buffer))) + (require 'url-handlers) + (unless-error ,body + (when-let* ((er (plist-get status :error))) + (error "Error retrieving: %s %S" ,url-sym er)) + (with-current-buffer ,b-sym + (goto-char (point-min)) + (unless (search-forward-regexp "^\r?\n\r?" nil t) + (error "Error retrieving: %s %S" + ,url-sym "incomprehensible buffer"))) + (url-insert ,b-sym) + (kill-buffer ,b-sym) + (goto-char (point-min))))) + nil + 'silent)) + (unless-error ,body (url-insert ,url-sym)))) (unless-error ,body - (let ((url (expand-file-name ,file ,url-1))) - (unless (file-name-absolute-p url) - (error "Location %s is not a url nor an absolute file name" url)) - (insert-file-contents url)))))))) + (let ((url (expand-file-name ,file ,url-1))) + (unless (file-name-absolute-p url) + (error "Location %s is not a url nor an absolute file name" + url)) + (insert-file-contents url)))))))) (define-error 'bad-signature "Failed to verify signature") @@ -1294,7 +1279,8 @@ package--check-signature (package--with-response-buffer location :file sig-file :async async :noerror t ;; Connection error is assumed to mean "no sig-file". - :error-form (let ((allow-unsigned (eq package-check-signature 'allow-unsigned))) + :error-form (let ((allow-unsigned + (eq package-check-signature 'allow-unsigned))) (when (and callback allow-unsigned) (funcall callback nil)) (when unwind (funcall unwind)) @@ -1303,8 +1289,9 @@ package--check-signature ;; OTOH, an error here means "bad signature", which we never ;; suppress. (Bug#22089) (unwind-protect - (let ((sig (package--check-signature-content (buffer-substring (point) (point-max)) - string sig-file))) + (let ((sig (package--check-signature-content + (buffer-substring (point) (point-max)) + string sig-file))) (when callback (funcall callback sig)) sig) (when unwind (funcall unwind)))))) @@ -1581,15 +1568,18 @@ package--download-one-archive (member name package-unsigned-archives)) ;; If we don't care about the signature, save the file and ;; we're done. - (progn (let ((coding-system-for-write 'utf-8)) - (write-region content nil local-file nil 'silent)) - (package--update-downloads-in-progress archive)) + (progn + (cl-assert (not enable-multibyte-characters)) + (let ((coding-system-for-write 'binary)) + (write-region content nil local-file nil 'silent)) + (package--update-downloads-in-progress archive)) ;; If we care, check it (perhaps async) and *then* write the file. (package--check-signature location file content async ;; This function will be called after signature checking. (lambda (&optional good-sigs) - (let ((coding-system-for-write 'utf-8)) + (cl-assert (not enable-multibyte-characters)) + (let ((coding-system-for-write 'binary)) (write-region content nil local-file nil 'silent)) ;; Write out good signatures into archive-contents.signed file. (when good-sigs @@ -1903,7 +1893,8 @@ package-install-from-archive ;; Update the old pkg-desc which will be shown on the description buffer. (setf (package-desc-signed pkg-desc) t) ;; Update the new (activated) pkg-desc as well. - (when-let* ((pkg-descs (cdr (assq (package-desc-name pkg-desc) package-alist)))) + (when-let* ((pkg-descs (cdr (assq (package-desc-name pkg-desc) + package-alist)))) (setf (package-desc-signed (car pkg-descs)) t)))))))))) (defun package-installed-p (package &optional min-version) @@ -2477,10 +2468,12 @@ describe-package-1 (replace-match "")))) (if (package-installed-p desc) - ;; For installed packages, get the description from the installed files. + ;; For installed packages, get the description from the + ;; installed files. (insert (package--get-description desc)) - ;; For non-built-in, non-installed packages, get description from the archive. + ;; For non-built-in, non-installed packages, get description from + ;; the archive. (let* ((basename (format "%s-readme.txt" name)) readme-string) diff --git a/lisp/url/url-handlers.el b/lisp/url/url-handlers.el index e35d999e0f..783466ca70 100644 --- a/lisp/url/url-handlers.el +++ b/lisp/url/url-handlers.el @@ -299,7 +299,8 @@ url-file-local-copy (defun url-insert (buffer &optional beg end) "Insert the body of a URL object. BUFFER should be a complete URL buffer as returned by `url-retrieve'. -If the headers specify a coding-system, it is applied to the body before it is inserted. +If the headers specify a coding-system (and current buffer is multibyte), +it is applied to the body before it is inserted. Returns a list of the form (SIZE CHARSET), where SIZE is the size in bytes of the inserted text and CHARSET is the charset that was specified in the header, or nil if none was found. @@ -311,12 +312,13 @@ url-insert (buffer-substring (+ (point-min) beg) (if end (+ (point-min) end) (point-max))) (buffer-string)))) - (charset (mail-content-type-get (mm-handle-type handle) - 'charset))) + (charset (if enable-multibyte-characters + (mail-content-type-get (mm-handle-type handle) + 'charset)))) (mm-destroy-parts handle) - (if charset - (insert (mm-decode-string data (mm-charset-to-coding-system charset))) - (insert data)) + (insert (if charset + (mm-decode-string data (mm-charset-to-coding-system charset)) + data)) (list (length data) charset))) (defvar url-http-codes) From debbugs-submit-bounces@debbugs.gnu.org Wed May 15 10:40:45 2019 Received: (at 35739) by debbugs.gnu.org; 15 May 2019 14:40:46 +0000 Received: from localhost ([127.0.0.1]:53149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQv5F-0006kU-Hz for submit@debbugs.gnu.org; Wed, 15 May 2019 10:40:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQv5A-0006kE-27 for 35739@debbugs.gnu.org; Wed, 15 May 2019 10:40:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57396) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQv53-0002qv-2l; Wed, 15 May 2019 10:40:30 -0400 Received: from [176.228.60.248] (port=1604 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hQv52-0000Ym-7T; Wed, 15 May 2019 10:40:28 -0400 Date: Wed, 15 May 2019 17:40:16 +0300 Message-Id: <8336lfaii7.fsf@gnu.org> From: Eli Zaretskii To: Richard Copley In-reply-to: (message from Richard Copley on Wed, 15 May 2019 07:46:12 +0100) Subject: Re: bug#35739: Bad signature from GNU ELPA References: <87mujog0ao.fsf@gmail.com> <837easa178.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35739 Cc: 35739@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Richard Copley > Date: Wed, 15 May 2019 07:46:12 +0100 > Cc: Noam Postavsky , 35739@debbugs.gnu.org > > I don't see how disabling decoding could make sense, can you explain? > > Not in detail, it's not an area of expertise of mine. We call > (decode-coding-region (point-min) (point-max) 'undecided) on the > payload of "https://elpa.gnu.org/packages/archive-contents", > which is raw text. The resulting buffer's buffer-file-coding- > system is iso-latin-1-dos. > > > What does this code do on GNU/Linux? > > The same. The resulting coding system is iso-latin-1-unix. That URL seems to bring ASCII text. Are you saying that GPG produces a wrong signature because EOL format is significant for it? (Please forgive silly questions about GPG: I seldom if ever use it.) In any case, if we don't want EOL conversion, we should bind inhibit-eol-conversion to a non-nil value, and change nothing else. But this should not be done in url-insert-buffer-contents, it should be done in package.el, because the former is a general utility and not necessarily needs to inhibit EOL conversion for all of its callers. From debbugs-submit-bounces@debbugs.gnu.org Wed May 15 11:03:37 2019 Received: (at 35739) by debbugs.gnu.org; 15 May 2019 15:03:37 +0000 Received: from localhost ([127.0.0.1]:53171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQvRQ-0007Jq-Kj for submit@debbugs.gnu.org; Wed, 15 May 2019 11:03:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQvRL-0007Ja-P2 for 35739@debbugs.gnu.org; Wed, 15 May 2019 11:03:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57761) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQvRE-0007z5-Mh; Wed, 15 May 2019 11:03:26 -0400 Received: from [176.228.60.248] (port=3023 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hQvRC-0001RK-GL; Wed, 15 May 2019 11:03:23 -0400 Date: Wed, 15 May 2019 18:03:10 +0300 Message-Id: <83woir92vl.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Wed, 15 May 2019 10:03:57 -0400) Subject: Re: bug#35739: Bad signature from GNU ELPA References: <87mujog0ao.fsf@gmail.com> <835zqca15y.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35739 Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Eli Zaretskii , 35739@debbugs.gnu.org, Noam Postavsky > Date: Wed, 15 May 2019 10:03:57 -0400 > > That actually looks very good [it would also need to change the other > url-insert-file-contents in that macro, of course]. > > Eli, do you think this could also be a fix for bug#34909? > > E.g. something like the patch below? I don't know. I don't yet have a handle on what happens here, and therefore I don't understand how replacing url-insert-buffer-contents with url-insert should fix that. I'm probably missing something. From debbugs-submit-bounces@debbugs.gnu.org Wed May 15 11:13:11 2019 Received: (at 35739) by debbugs.gnu.org; 15 May 2019 15:13:11 +0000 Received: from localhost ([127.0.0.1]:53184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQvag-0007YM-Op for submit@debbugs.gnu.org; Wed, 15 May 2019 11:13:11 -0400 Received: from mail-oi1-f174.google.com ([209.85.167.174]:46046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQvae-0007Y8-A4 for 35739@debbugs.gnu.org; Wed, 15 May 2019 11:13:08 -0400 Received: by mail-oi1-f174.google.com with SMTP id w144so2072648oie.12 for <35739@debbugs.gnu.org>; Wed, 15 May 2019 08:13:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=r6PQGBPvAuWRrq+gP9LpMHgjqk63Mk4UNxgJvrFWYFM=; b=Y7QXRsY5hvRa5lLYXBbNobPFk5BtbdtMOwy+I6zsvXEDQpNeVFE6bp8GO/JXmLZgwW kcPtPy4ik86iPvcN33jPXkrpWHuJC+XswPgv1+Fxdc7+bda2cAx2h3/Y2pdOUYS03jcb x99bUdts/gRpO9aAvfN+jdGUYjS4w2STow4mybibb30kNMVs9kCuk/LnD0sayerCq4xh O6PSUNRZTjmF/YRzGtRF67CLRksKouWZRykdEA/hRnmNm0X4m0n+QMI/GBjY8ygx/7pT psEj8NFhHAsXV8DE/a/WRP9/B8S6wZom4r/SHpGqnqz7Dzk3eBwfkTlBgHT72iWVcv4i 4ZVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r6PQGBPvAuWRrq+gP9LpMHgjqk63Mk4UNxgJvrFWYFM=; b=EEoGW+R99SgoP5JyWHSTKZbVUPuemrHDNGAUEL3jOSVOgc9QwGxPVOJQlNx8KmTsUo BUh88DFPUluBFElXhSLkMS5wc66KogvACpEGullP5U1cCw0WB6/FC1uI1S/0UU8q7CRA tY8MTI9H3VYHemXtSU+6jPOzNg1wDMGkA0g8In5UGbthqAGbcRgDot2VXHSmorU1R0GR a0SWrSmGz8v+UUsTsgzP6Ve2qgJi/f2Ck/mhkmVSx1gCxgPHf0G/fGBWIZCzLfbixFgJ J29iii7ImozZ2wtnrP2xFEd+qa8/+LxfudZdDllQqVxEwMFAyt9GjYzZ5VMxFGuIF0mh g00Q== X-Gm-Message-State: APjAAAXSgN858kRy4UY1iLm2wZT64uUrK/785XsIIuPE+OhjNtF6YWf/ 0L/bl0S930sQKV4fwi1B3twNCvGwfKblfvk+DFM= X-Google-Smtp-Source: APXvYqwGPAkhluPC+7mn87at5Jfqf+zQ64OTYXG3xp08llfGlF9btD3UBxpCOInDVAbYZYdcMFKWw/vxmqCXNL2kBNI= X-Received: by 2002:aca:4fd3:: with SMTP id d202mr6721973oib.153.1557933182171; Wed, 15 May 2019 08:13:02 -0700 (PDT) MIME-Version: 1.0 References: <87mujog0ao.fsf@gmail.com> <837easa178.fsf@gnu.org> <8336lfaii7.fsf@gnu.org> In-Reply-To: <8336lfaii7.fsf@gnu.org> From: Richard Copley Date: Wed, 15 May 2019 16:12:35 +0100 Message-ID: Subject: Re: bug#35739: Bad signature from GNU ELPA To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000e83fc40588ee950b" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35739 Cc: 35739@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000e83fc40588ee950b Content-Type: text/plain; charset="UTF-8" On Wed, 15 May 2019, 15:40 Eli Zaretskii, wrote: > > From: Richard Copley > > Date: Wed, 15 May 2019 07:46:12 +0100 > > Cc: Noam Postavsky , 35739@debbugs.gnu.org > > > > I don't see how disabling decoding could make sense, can you explain? > > > > Not in detail, it's not an area of expertise of mine. We call > > (decode-coding-region (point-min) (point-max) 'undecided) on the > > payload of "https://elpa.gnu.org/packages/archive-contents", > > which is raw text. The resulting buffer's buffer-file-coding- > > system is iso-latin-1-dos. > > > > > > What does this code do on GNU/Linux? > > > > The same. The resulting coding system is iso-latin-1-unix. > > That URL seems to bring ASCII text. Are you saying that GPG produces > a wrong signature because EOL format is significant for it? (Please > forgive silly questions about GPG: I seldom if ever use it.) > Getting the signature involves applying a hash function to the bytes in question. It's desirable that two different byte sequences give rise to two different signatures, even if the difference is a carriage return. In any case, if we don't want EOL conversion, we should bind > inhibit-eol-conversion to a non-nil value, and change nothing else. > But this should not be done in url-insert-buffer-contents, it should > be done in package.el, because the former is a general utility and not > necessarily needs to inhibit EOL conversion for all of its callers. > Of course. I was confirming Noam's hunch, not suggesting a change. Sorry that wasn't clear. --000000000000e83fc40588ee950b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Wed, 15 May 2019,= 15:40 Eli Zaretskii, <eliz@gnu.org> wrote:
> From: Richard Copley <= rcopley@gmail.com>
> Date: Wed, 15 May 2019 07:46:12 +0100
> Cc: Noam Postavsky <npostavs@gmail.com>= ;, 35739@debbugs.gnu.org
>
>=C2=A0 I don't see how disabling decoding could make sense, can you= explain?
>
> Not in detail, it's not an area of expertise of mine. We call
> (decode-coding-region (point-min) (point-max) 'undecided) on the > payload of "https://elpa.gnu.org/packages/archive-contents",
> which is raw text. The resulting buffer's buffer-file-coding-
> system is iso-latin-1-dos.
>=C2=A0
>
>=C2=A0 What does this code do on GNU/Linux?
>
> The same. The resulting coding system is iso-latin-1-unix.

That URL seems to bring ASCII text.=C2=A0 Are you saying that GPG produces<= br> a wrong signature because EOL format is significant for it?=C2=A0 (Please forgive silly questions about GPG: I seldom if ever use it.)

Getting the signature involves app= lying a hash function to the bytes
in question. It's desirabl= e that two different byte sequences give rise
to two different si= gnatures, even if the difference is a carriage return.

In any case, if we don't want EOL conversion, we should bind
inhibit-eol-conversion to a non-nil value, and change nothing else.
But this should not be done in url-insert-buffer-contents, it should
be done in package.el, because the former is a general utility and not
necessarily needs to inhibit EOL conversion for all of its callers.

Of course. I w= as confirming Noam's hunch, not suggesting a change.
Sorry th= at wasn't clear.

--000000000000e83fc40588ee950b-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 18 18:37:00 2019 Received: (at 35739) by debbugs.gnu.org; 18 May 2019 22:37:00 +0000 Received: from localhost ([127.0.0.1]:33168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hS7wq-00036d-BH for submit@debbugs.gnu.org; Sat, 18 May 2019 18:37:00 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:14133) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hS7wo-00036Q-Kp for 35739@debbugs.gnu.org; Sat, 18 May 2019 18:36:58 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2BAB81011C4; Sat, 18 May 2019 18:36:53 -0400 (EDT) Received: from mail02.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DE85A1007CC; Sat, 18 May 2019 18:36:51 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1558219011; bh=11ibD4eXJRcGRnyoL0DzNvdlvchhQHPWDfQkYD6Rh2M=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=UkCa+U1ZQiYqyIeLS9Fu7r5IzLC9BESkX7XJiscxynqTJL5nahpcMaMElb6ogPCnE yVZ8vUGQ7kP+HQtGW12u2vZfTYaO59MwMyE6Sv7jAd20B+0WkderAVn1Tmmvq4Bon7 fIrx6X0KEyS+TENHsmSEGC9ehidARviKR4E/L9lisgHWJ6lcepEHqoJkvfsNPoaRBL rI8b4NRQP+9MNNws0HZE9IViGbYvGW5/TmhATNBijeKmL+Xa0cZ362QhDlEqrnuT7p 8LO76h83ryeoVX3jh/7CjlTYEL8AW4BQKgsFbuVPaZcOOoowsoLsnU5SnOClkwA7iN QYNQTGG0tg+ng== Received: from ceviche (unknown [216.154.3.168]) by mail02.iro.umontreal.ca (Postfix) with ESMTPSA id 94C681203CD; Sat, 18 May 2019 18:36:51 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#35739: Bad signature from GNU ELPA Message-ID: References: <87mujog0ao.fsf@gmail.com> <835zqca15y.fsf@gnu.org> <83woir92vl.fsf@gnu.org> Date: Sat, 18 May 2019 18:36:50 -0400 In-Reply-To: <83woir92vl.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 15 May 2019 18:03:10 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35739 Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I don't know. I don't yet have a handle on what happens here, and > therefore I don't understand how replacing url-insert-buffer-contents > with url-insert should fix that. I'm probably missing something. After playing some more with it, I found a few problems, tracked down the origin of the decoding (which was introduced for the case where we download the -readme.txt description file) and installed a patch into master which should fix this right. Now the question is how to adapt the fix for emacs-26: the patch I installed is too invasive for emacs-26, I think. Maybe we can patch over the problem by using `last-coding-system` instead of `utf-8`? Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed May 22 01:19:11 2019 Received: (at 35739) by debbugs.gnu.org; 22 May 2019 05:19:12 +0000 Received: from localhost ([127.0.0.1]:41397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTJeh-0002WP-Id for submit@debbugs.gnu.org; Wed, 22 May 2019 01:19:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTJef-0002WD-UQ for 35739@debbugs.gnu.org; Wed, 22 May 2019 01:19:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60147) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTJea-0000UD-J2; Wed, 22 May 2019 01:19:04 -0400 Received: from [176.228.60.248] (port=4840 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hTJeZ-0004kR-SG; Wed, 22 May 2019 01:19:04 -0400 Date: Wed, 22 May 2019 08:19:09 +0300 Message-Id: <83o93v83si.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Sat, 18 May 2019 18:36:50 -0400) Subject: Re: bug#35739: Bad signature from GNU ELPA References: <87mujog0ao.fsf@gmail.com> <835zqca15y.fsf@gnu.org> <83woir92vl.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35739 Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com > Date: Sat, 18 May 2019 18:36:50 -0400 > > > I don't know. I don't yet have a handle on what happens here, and > > therefore I don't understand how replacing url-insert-buffer-contents > > with url-insert should fix that. I'm probably missing something. > > After playing some more with it, I found a few problems, tracked down > the origin of the decoding (which was introduced for the case where we > download the -readme.txt description file) and installed a patch > into master which should fix this right. > > Now the question is how to adapt the fix for emacs-26: the patch > I installed is too invasive for emacs-26, I think. > > Maybe we can patch over the problem by using `last-coding-system` instead > of `utf-8`? I don't think I understand the change enough to say something intelligent here. The commit explains, o some extent, why the original code failed, but it says nothing about the way the new code solves the problem without introducing new ones. I'm also mildly worried about the incompatible change in url-insert, which is a general-purpose function not limited to package.el and its signature verification. From debbugs-submit-bounces@debbugs.gnu.org Wed May 22 12:20:13 2019 Received: (at 35739) by debbugs.gnu.org; 22 May 2019 16:20:13 +0000 Received: from localhost ([127.0.0.1]:42765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTTyO-0008JG-Sf for submit@debbugs.gnu.org; Wed, 22 May 2019 12:20:13 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:60862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTTyN-0008J1-Eg for 35739@debbugs.gnu.org; Wed, 22 May 2019 12:20:12 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2017B100DB7; Wed, 22 May 2019 12:20:06 -0400 (EDT) Received: from mail02.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0C0E3100A32; Wed, 22 May 2019 12:20:04 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1558542004; bh=e4o1P7+73obNemirALS6Va7tp/Ab3ssOo3bqbTll9eU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=lXGkO1LcopYUCCeoFM7IyFSGG6a/UAm1/j5JCNdOpWp4jHj4fe5/ibbhHGog8EwAO 0vRNebPlf6ksxre0oTC/JgDOD2ilyN25Gna5JdEcpsmmq4Vxlxt0hSodLAPKFaNLXP eaDXXKHrPUSZnW4EONufB7C5QUVEVMbQH5GRAVCz/bSma0fcN+ffgtBA0nwCVo5zuc KBPmEMCm+l1h9/6lN+R3DY6qmOcSUVGxXTTpThuhCN4pDNqeHqwg3iGKNIxxaweF6r rEmXDrL0IrdBwOn6V6pYJB7RNgqSSh9bllVgLir6GnRtPq/Hbze5YWJRUPweit6IXo NYoRPxlt+Bdog== Received: from alfajor (unknown [216.154.3.168]) by mail02.iro.umontreal.ca (Postfix) with ESMTPSA id 8B099120ABE; Wed, 22 May 2019 12:20:03 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#35739: Bad signature from GNU ELPA Message-ID: References: <87mujog0ao.fsf@gmail.com> <835zqca15y.fsf@gnu.org> <83woir92vl.fsf@gnu.org> <83o93v83si.fsf@gnu.org> Date: Wed, 22 May 2019 12:20:01 -0400 In-Reply-To: <83o93v83si.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 22 May 2019 08:19:09 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35739 Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I don't think I understand the change enough to say something > intelligent here. The commit explains, o some extent, why the > original code failed, but it says nothing about the way the new code > solves the problem without introducing new ones. It solves the problem by refraining from decoding until we know positively that it needs to happen. In the patch I installed, I only end up decoding the readme.txt descriptions. Maybe there are other places where decoding is needed, if so we'll need to fix those cases I missed when we find them. > I'm also mildly worried about the incompatible change in url-insert, > which is a general-purpose function not limited to package.el and its > signature verification. Yes, this part should definitely not be in emacs-26. Luckily, I think the rest of the change still solves our problem in practice in Emacs-26 (the change in url-insert only affects the case where the HTTP headers returned by the server specify a particular "charset", which is not the case when downloading .tar and .el files from elpa.gnu.org AFAICT). Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed May 22 13:09:43 2019 Received: (at 35739) by debbugs.gnu.org; 22 May 2019 17:09:43 +0000 Received: from localhost ([127.0.0.1]:42817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTUkJ-0001HS-Fy for submit@debbugs.gnu.org; Wed, 22 May 2019 13:09:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55937) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTUkG-0001HD-3l for 35739@debbugs.gnu.org; Wed, 22 May 2019 13:09:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41433) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTUkA-0004L5-Qr; Wed, 22 May 2019 13:09:34 -0400 Received: from [176.228.60.248] (port=3565 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hTUkA-0004WN-4j; Wed, 22 May 2019 13:09:34 -0400 Date: Wed, 22 May 2019 20:09:41 +0300 Message-Id: <83muje76wa.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Wed, 22 May 2019 12:20:01 -0400) Subject: Re: bug#35739: Bad signature from GNU ELPA References: <87mujog0ao.fsf@gmail.com> <835zqca15y.fsf@gnu.org> <83woir92vl.fsf@gnu.org> <83o93v83si.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35739 Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com > Date: Wed, 22 May 2019 12:20:01 -0400 > > It solves the problem by refraining from decoding until we know > positively that it needs to happen. You refrain from decoding what? E.g., Lisp files must be in UTF-8, right? And what about the descriptions we show in lisp-packages? Or maybe I don't really understand why we need to decode _anything_, since we just download a .tar archive, right? > > I'm also mildly worried about the incompatible change in url-insert, > > which is a general-purpose function not limited to package.el and its > > signature verification. > > Yes, this part should definitely not be in emacs-26. I'm actually asking why it should be on master. > the change in url-insert only affects the case where the HTTP > headers returned by the server specify a particular "charset", which > is not the case when downloading .tar and .el files from > elpa.gnu.org AFAICT Why not? isn't that dangerous? From debbugs-submit-bounces@debbugs.gnu.org Wed May 22 15:40:57 2019 Received: (at 35739) by debbugs.gnu.org; 22 May 2019 19:40:57 +0000 Received: from localhost ([127.0.0.1]:42984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTX6f-00050m-5F for submit@debbugs.gnu.org; Wed, 22 May 2019 15:40:57 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61197) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTX6d-00050U-1K for 35739@debbugs.gnu.org; Wed, 22 May 2019 15:40:55 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A246B81164; Wed, 22 May 2019 15:40:49 -0400 (EDT) Received: from mail02.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 64FDD80B93; Wed, 22 May 2019 15:40:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1558554047; bh=I2HiumJKRiZ2/dNVluA6efig8pJ/1F+xsIg4XZHDlIg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=aBKBRc0NdYkPiqiw0lWEutI6fhmvfGOMWlkx+rJmTwCBvAO0oRSbVFEzQIkTV9ats Z1eNxx/YgjWM9R5HPR/Z2HJz4dQrv9CulmAHeayGfhK5Hc9Gh5hfMccQDqOl21M1Qj P0P5Bs+OKtheyT7zYDP38LlFc5Xg9/C9HTJkoHfdpW3/qj+b1j8Z/kD2Fsr02nkJAz XIhR/h0s6D05/F8uSiBONF1NrE53qYsUFg2RZJem8vYwoKPIUpADAMXNSUKWOphwwS L6igWY1HgRCmJrJ6R1hhTquVx/A99ks6e73YLpNJqYfcxVyDedc7ByU+fUgOHbos82 j/7zx5K+GFBXw== Received: from alfajor (unknown [216.154.3.168]) by mail02.iro.umontreal.ca (Postfix) with ESMTPSA id 20EE612015D; Wed, 22 May 2019 15:40:47 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#35739: Bad signature from GNU ELPA Message-ID: References: <87mujog0ao.fsf@gmail.com> <835zqca15y.fsf@gnu.org> <83woir92vl.fsf@gnu.org> <83o93v83si.fsf@gnu.org> <83muje76wa.fsf@gnu.org> Date: Wed, 22 May 2019 15:40:46 -0400 In-Reply-To: <83muje76wa.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 22 May 2019 20:09:41 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.087 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain KAM_SHORT 0.001 Use of a URL Shortener for very short URL X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35739 Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> It solves the problem by refraining from decoding until we know >> positively that it needs to happen. > You refrain from decoding what? The files we download. > E.g., Lisp files must be in UTF-8, right? At first we don't care: we gets files (tarballs, GPG signatures, Elisp files, ...) and while some of them may need decoding later on, not all do. And for purposes of signature checking, for some of those files we need to get the exact original sequence of bytes, which is easier to get if we only decode *after* signature checking rather than before. For this reason we don't want to let URL do the decoding for us. It's true that for "simple packages" made of a single .el file, after signature checking we should maybe decode them as utf-8. The main thing we do with those is to save them as files and for that we don't need decoding. I haven't checked whether we do anything else significant with those undecoded .el buffers, so maybe I missed an explicit decode somewhere in there. > And what about the descriptions we show in lisp-packages? Not sure what you mean by that (I already mentioned the *-readme.txt files which we do decode explicitly now). > Or maybe I don't really understand why we need to decode _anything_, > since we just download a .tar archive, right? There's more than just tarballs. >> Yes, this part should definitely not be in emacs-26. > I'm actually asking why it should be on master. It seemed like a simple way to provide this new functionality. The functionality is needed at least by package.el, and I see no reason why it should be the only client of URL that needs this functionality. >> the change in url-insert only affects the case where the HTTP >> headers returned by the server specify a particular "charset", which >> is not the case when downloading .tar and .el files from >> elpa.gnu.org AFAICT > Why not? For tarballs, since it's not a text/* format, it wouldn't make much sense to specify a charset. For Elisp files, it might just be a happy accident of the configuration of the HTTP server, but my impression is that nowadays it's considered a bad idea to rely on the HTTP headers to tell you about the encoding (instead, the data contents should specify its own encoding), so it's only useful for text/plain files. > isn't that dangerous? Dangerous? definitely not. All it means is that if you try to view something like https://elpa.gnu.org/packages/xclip-1.8.el in your browser there's a possibility that it will not display the non-ASCII characters properly. Of course, most browsers I know won't display the file at all anyway (they ask you where to save it instead because they don't know what else to do with text/x-emacs-lisp). Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed May 22 23:50:02 2019 Received: (at 35739) by debbugs.gnu.org; 23 May 2019 03:50:02 +0000 Received: from localhost ([127.0.0.1]:43635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTejx-0002HY-F2 for submit@debbugs.gnu.org; Wed, 22 May 2019 23:50:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTejv-0002HL-QA for 35739@debbugs.gnu.org; Wed, 22 May 2019 23:50:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52203) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTejo-0007eX-Dw; Wed, 22 May 2019 23:49:53 -0400 Received: from [176.228.60.248] (port=3010 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hTejn-00016D-PQ; Wed, 22 May 2019 23:49:52 -0400 Date: Thu, 23 May 2019 06:50:00 +0300 Message-Id: <83k1eh7rtj.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Wed, 22 May 2019 15:40:46 -0400) Subject: Re: bug#35739: Bad signature from GNU ELPA References: <87mujog0ao.fsf@gmail.com> <835zqca15y.fsf@gnu.org> <83woir92vl.fsf@gnu.org> <83o93v83si.fsf@gnu.org> <83muje76wa.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35739 Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com > Date: Wed, 22 May 2019 15:40:46 -0400 > > > You refrain from decoding what? > > The files we download. > > > E.g., Lisp files must be in UTF-8, right? > > At first we don't care: we gets files (tarballs, GPG signatures, Elisp > files, ...) and while some of them may need decoding later on, not all > do. And for purposes of signature checking, for some of those files we > need to get the exact original sequence of bytes, which is easier to get > if we only decode *after* signature checking rather than before. > For this reason we don't want to let URL do the decoding for us. Where is the decoding happening, then? According to what you write, URL should just save the files as is, and then decoding should happen when we access the resulting files after saving them. Is that what happens after the changes? > > And what about the descriptions we show in lisp-packages? > > Not sure what you mean by that (I already mentioned the *-readme.txt > files which we do decode explicitly now). > > > Or maybe I don't really understand why we need to decode _anything_, > > since we just download a .tar archive, right? Sorry for the typo: I meant list-packages. Does that display come from the README files? > >> Yes, this part should definitely not be in emacs-26. > > I'm actually asking why it should be on master. > > It seemed like a simple way to provide this new functionality. > The functionality is needed at least by package.el, and I see no reason > why it should be the only client of URL that needs this functionality. Other clients might need it in other ways. From what you explain, it sounds like package.el doesn't need to decode at all when it downloads, so it should disregard the 'charset' header and always treat the stuff it gets as a raw byte stream. Is that correct? If it is correct, then there's no need to make any changes in url*.el routines. From debbugs-submit-bounces@debbugs.gnu.org Thu May 23 00:06:32 2019 Received: (at 35739) by debbugs.gnu.org; 23 May 2019 04:06:32 +0000 Received: from localhost ([127.0.0.1]:43642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTezw-0002hu-5q for submit@debbugs.gnu.org; Thu, 23 May 2019 00:06:32 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:32456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTezt-0002hc-Td for 35739@debbugs.gnu.org; Thu, 23 May 2019 00:06:30 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D5BD11011A3; Thu, 23 May 2019 00:06:23 -0400 (EDT) Received: from mail02.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B2688100A32; Thu, 23 May 2019 00:06:22 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1558584382; bh=kHjmJWYACFAMAusneqzNhwNzGG86KhKu7wSCjy/lvTM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=TKnluNUdi0RrA7QkXC5rXltAADorfRLngXyFlywxPo0N86QFxwwsKTPg3aEMUnUSN gytrLRrpYSrhDJI7TAJClKPHOiaB1CmotPi1y0xB80ue98KkQgs6WmCFEJDj+vFHCp IBZ7q+znGE693f3ljVpgd/7gg0CsMb7EMUUVsZJsRqKwV8Qr1S3DN/zZUzlvkpV8hT awCYrhVAMDP4h6M7bSjmLkPvJn2cZi7INCLbViGGDM8pAP9xBFKy5LnZ51bUgU36vC /rI8CaT7zU823xfTJh6+GzSnSvUHqF+a2Hx2P+pL4HenbZ5tD3iDUq01mZQqPeNCoY 3DQJbG8LNR3pA== Received: from alfajor (unknown [216.154.3.168]) by mail02.iro.umontreal.ca (Postfix) with ESMTPSA id 2FB42120954; Thu, 23 May 2019 00:06:22 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#35739: Bad signature from GNU ELPA Message-ID: References: <87mujog0ao.fsf@gmail.com> <835zqca15y.fsf@gnu.org> <83woir92vl.fsf@gnu.org> <83o93v83si.fsf@gnu.org> <83muje76wa.fsf@gnu.org> <83k1eh7rtj.fsf@gnu.org> Date: Thu, 23 May 2019 00:06:19 -0400 In-Reply-To: <83k1eh7rtj.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 23 May 2019 06:50:00 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35739 Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Where is the decoding happening, then? According to what you write, > URL should just save the files as is, and then decoding should happen > when we access the resulting files after saving them. Is that what > happens after the changes? That's right. > Sorry for the typo: I meant list-packages. Does that display come > from the README files? It can come from various places, but the only case affected by my change is when it comes from the remote archive in which case it's indeed the *-readme.txt file that I do decode explicitly. > Other clients might need it in other ways. From what you explain, it > sounds like package.el doesn't need to decode at all when it > downloads, so it should disregard the 'charset' header and always > treat the stuff it gets as a raw byte stream. Is that correct? That's right. > If it is correct, then there's no need to make any changes in > url*.el routines. There is, because the routine that extracts the "raw bytes" is url-insert which (until my patch) also did the decoding according to the "charset" specified in the HTTP headers returned by the server (if present). IOW it didn't always return the raw bytes. Note that other clients will only be negatively affected by the change if: - the HTTP server has returned a "charset" in its headers. - they url-insert into a unibyte buffer. - they need the text to be decoded. The last two points should be mutually exclusive in sane situations, so I think the change is pretty safe. Or to put it another way, I think it's more likely to uncover or even fix a bug than to introduce one. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu May 23 00:52:52 2019 Received: (at 35739) by debbugs.gnu.org; 23 May 2019 04:52:52 +0000 Received: from localhost ([127.0.0.1]:43710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTfim-0003uC-Bh for submit@debbugs.gnu.org; Thu, 23 May 2019 00:52:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50691) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTfik-0003tz-HQ for 35739@debbugs.gnu.org; Thu, 23 May 2019 00:52:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53687) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTfia-0007jA-Kg; Thu, 23 May 2019 00:52:42 -0400 Received: from [176.228.60.248] (port=3830 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hTfiY-0003Qc-I6; Thu, 23 May 2019 00:52:39 -0400 Date: Thu, 23 May 2019 07:52:46 +0300 Message-Id: <838sux7owx.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Thu, 23 May 2019 00:06:19 -0400) Subject: Re: bug#35739: Bad signature from GNU ELPA References: <87mujog0ao.fsf@gmail.com> <835zqca15y.fsf@gnu.org> <83woir92vl.fsf@gnu.org> <83o93v83si.fsf@gnu.org> <83muje76wa.fsf@gnu.org> <83k1eh7rtj.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35739 Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com > Date: Thu, 23 May 2019 00:06:19 -0400 > > > Where is the decoding happening, then? According to what you write, > > URL should just save the files as is, and then decoding should happen > > when we access the resulting files after saving them. Is that what > > happens after the changes? > > That's right. > > > Sorry for the typo: I meant list-packages. Does that display come > > from the README files? > > It can come from various places, but the only case affected by my change > is when it comes from the remote archive in which case it's indeed the > *-readme.txt file that I do decode explicitly. > > > Other clients might need it in other ways. From what you explain, it > > sounds like package.el doesn't need to decode at all when it > > downloads, so it should disregard the 'charset' header and always > > treat the stuff it gets as a raw byte stream. Is that correct? > > That's right. Sounds good, thanks. > > If it is correct, then there's no need to make any changes in > > url*.el routines. > > There is, because the routine that extracts the "raw bytes" is url-insert > which (until my patch) also did the decoding according to the "charset" > specified in the HTTP headers returned by the server (if present). > IOW it didn't always return the raw bytes. Then how about an optional argument to disable 'charset' handling instead? That'd be backward-compatible. > Note that other clients will only be negatively affected by the change if: > - the HTTP server has returned a "charset" in its headers. > - they url-insert into a unibyte buffer. > - they need the text to be decoded. > The last two points should be mutually exclusive in sane situations, so > I think the change is pretty safe. Or to put it another way, I think > it's more likely to uncover or even fix a bug than to introduce one. I'd prefer a backward-compatible change, because that saves us from the need to be 100% right when estimating the collateral damage, something that we have failed in several cases in the past. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu May 23 08:10:54 2019 Received: (at 35739) by debbugs.gnu.org; 23 May 2019 12:10:54 +0000 Received: from localhost ([127.0.0.1]:44039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTmYg-0008F3-B9 for submit@debbugs.gnu.org; Thu, 23 May 2019 08:10:54 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:34931) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTmYe-0008El-5a for 35739@debbugs.gnu.org; Thu, 23 May 2019 08:10:52 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 171524429DD; Thu, 23 May 2019 08:10:46 -0400 (EDT) Received: from mail02.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id F25344429D8; Thu, 23 May 2019 08:10:44 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1558613445; bh=NyMLFDcUfs6aYAmR1AqhjL313MtwTxfJAJiNEyEF+gs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=h7d72uQXeDKerX0J668FCWIeDQE74qb2GX5HHA6ulBmQ8cIRZikEQz8JGP5LawHve TbzJ8xsOZ/4ZgsSZqsZu13nEUEh9cRbvVVMrcB9aniJf8/i/7SE9AZAZd/D1tj9wx7 G3vLi7lryqrHztkFQ7ES7kWTu5eo4GUyXoxUZZu4RWsWe9wq3pX/8a+349Z7zfbk4y UmXajoipQF1RY+0KVemdfN6Nz6EVNC8VsNPTiZFtI7O7W3fCCZ2mkzgrPzI2VShC3w 9AxIG2017uo0TpIQPr5uiDaLlB7HlcrRvBYSiC0IHF5XCa0RYjmm3jsrgNlH2Lpe7l X+L05M0jd0MkQ== Received: from alfajor (unknown [167.88.27.42]) by mail02.iro.umontreal.ca (Postfix) with ESMTPSA id 0F9B6120590; Thu, 23 May 2019 08:10:43 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#35739: Bad signature from GNU ELPA Message-ID: References: <87mujog0ao.fsf@gmail.com> <835zqca15y.fsf@gnu.org> <83woir92vl.fsf@gnu.org> <83o93v83si.fsf@gnu.org> <83muje76wa.fsf@gnu.org> <83k1eh7rtj.fsf@gnu.org> <838sux7owx.fsf@gnu.org> Date: Thu, 23 May 2019 08:10:41 -0400 In-Reply-To: <838sux7owx.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 23 May 2019 07:52:46 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.532 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35739 Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> There is, because the routine that extracts the "raw bytes" is url-insert >> which (until my patch) also did the decoding according to the "charset" >> specified in the HTTP headers returned by the server (if present). >> IOW it didn't always return the raw bytes. > > Then how about an optional argument to disable 'charset' handling > instead? That'd be backward-compatible. I think people have already enough trouble dealing with character encodings that we shouldn't encourage them to put decoded text into unibyte buffers (I don't even know where/if the semantics of this is described somewhere in our manuals or code). IOW, from where I stand, the change in behavior is just fixing a long-standing bug. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu May 23 10:15:33 2019 Received: (at 35739) by debbugs.gnu.org; 23 May 2019 14:15:34 +0000 Received: from localhost ([127.0.0.1]:44952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hToVJ-0005Bk-CS for submit@debbugs.gnu.org; Thu, 23 May 2019 10:15:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36561) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hToVI-0005BX-Bg for 35739@debbugs.gnu.org; Thu, 23 May 2019 10:15:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33172) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hToV9-00019e-Od; Thu, 23 May 2019 10:15:25 -0400 Received: from [176.228.60.248] (port=2503 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hToV9-0000kG-2P; Thu, 23 May 2019 10:15:23 -0400 Date: Thu, 23 May 2019 17:15:33 +0300 Message-Id: <8336l56yuy.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Thu, 23 May 2019 08:10:41 -0400) Subject: Re: bug#35739: Bad signature from GNU ELPA References: <87mujog0ao.fsf@gmail.com> <835zqca15y.fsf@gnu.org> <83woir92vl.fsf@gnu.org> <83o93v83si.fsf@gnu.org> <83muje76wa.fsf@gnu.org> <83k1eh7rtj.fsf@gnu.org> <838sux7owx.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35739 Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com > Date: Thu, 23 May 2019 08:10:41 -0400 > > > Then how about an optional argument to disable 'charset' handling > > instead? That'd be backward-compatible. > > I think people have already enough trouble dealing with character > encodings that we shouldn't encourage them to put decoded text into > unibyte buffers (I don't even know where/if the semantics of this is > described somewhere in our manuals or code). > > IOW, from where I stand, the change in behavior is just fixing > a long-standing bug. I guess we are standing on different places, then. I'd like us not to change that behavior by default. From debbugs-submit-bounces@debbugs.gnu.org Fri May 24 10:22:21 2019 Received: (at 35739) by debbugs.gnu.org; 24 May 2019 14:22:22 +0000 Received: from localhost ([127.0.0.1]:46987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUB5R-0005q6-LT for submit@debbugs.gnu.org; Fri, 24 May 2019 10:22:21 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUB5O-0005pp-El for 35739@debbugs.gnu.org; Fri, 24 May 2019 10:22:18 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 092FB1011B6; Fri, 24 May 2019 10:22:13 -0400 (EDT) Received: from mail02.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CF1FE100C69; Fri, 24 May 2019 10:22:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1558707731; bh=wpEVU+QDJg6P3IaOQYAAEGoR+BT/5gM9k8zI97bdmqA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=OlSAD9iD1L/tB8vZlRsQXUYM2QAJQ81PJqVdBsSPekNJEzGTG//tjAU2i5mvXjzY3 LOTnj0odxpWb/eURRh7e7KbtAdsRBh2i5uBniOSwe/E+Xuwz7t6lFuJ8XrDnxFdAiB IHT95imLhr7deftrnteJX7YpNqsvadYw9PO520wIo8VS/DV7ui9CrBqsrTGPB0NOFs oyZxDHa04tR/M5+e/mPH/8hkEdkCKJkgYg6bg9yzMNL78rbn9BICbHCcXYu47AeFiA VYrnsKQTIl19Htz8neBQX243upN93Y8GgyS5QJNdq8h0hUxq7bJyP2buuJOAu0prxn NNaEfwGLvVhNg== Received: from alfajor (unknown [167.88.27.42]) by mail02.iro.umontreal.ca (Postfix) with ESMTPSA id 94720120B1A; Fri, 24 May 2019 10:22:11 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#35739: Bad signature from GNU ELPA Message-ID: References: <87mujog0ao.fsf@gmail.com> <835zqca15y.fsf@gnu.org> <83woir92vl.fsf@gnu.org> <83o93v83si.fsf@gnu.org> <83muje76wa.fsf@gnu.org> <83k1eh7rtj.fsf@gnu.org> <838sux7owx.fsf@gnu.org> <8336l56yuy.fsf@gnu.org> Date: Fri, 24 May 2019 10:22:05 -0400 In-Reply-To: <8336l56yuy.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 23 May 2019 17:15:33 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35739 Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I guess we are standing on different places, then. We all do ;-) > I'd like us not to change that behavior by default. I think in this case we need to define it (i.e. document what it means to insert decoded text into a unibyte buffer). Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri May 24 11:01:45 2019 Received: (at 35739) by debbugs.gnu.org; 24 May 2019 15:01:45 +0000 Received: from localhost ([127.0.0.1]:47027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUBhY-00070E-V8 for submit@debbugs.gnu.org; Fri, 24 May 2019 11:01:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUBhW-000700-TY for 35739@debbugs.gnu.org; Fri, 24 May 2019 11:01:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40349) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUBhR-0004NS-E8; Fri, 24 May 2019 11:01:37 -0400 Received: from [176.228.60.248] (port=3294 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hUBhO-0006jG-Ot; Fri, 24 May 2019 11:01:37 -0400 Date: Fri, 24 May 2019 18:00:59 +0300 Message-Id: <83zhnb5238.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Fri, 24 May 2019 10:22:05 -0400) Subject: Re: bug#35739: Bad signature from GNU ELPA References: <87mujog0ao.fsf@gmail.com> <835zqca15y.fsf@gnu.org> <83woir92vl.fsf@gnu.org> <83o93v83si.fsf@gnu.org> <83muje76wa.fsf@gnu.org> <83k1eh7rtj.fsf@gnu.org> <838sux7owx.fsf@gnu.org> <8336l56yuy.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35739 Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com > Date: Fri, 24 May 2019 10:22:05 -0400 > > > I'd like us not to change that behavior by default. > > I think in this case we need to define it (i.e. document what it means > to insert decoded text into a unibyte buffer). Why do we have to define that only for that specific function? And why is that relevant to the issue at hand, which is not to make backward-incompatible changes in existing APIs? From debbugs-submit-bounces@debbugs.gnu.org Fri May 24 15:31:52 2019 Received: (at 35739) by debbugs.gnu.org; 24 May 2019 19:31:52 +0000 Received: from localhost ([127.0.0.1]:47378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUFuy-0001yp-0u for submit@debbugs.gnu.org; Fri, 24 May 2019 15:31:52 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUFuv-0001yc-Tr for 35739@debbugs.gnu.org; Fri, 24 May 2019 15:31:50 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 85FAB100C69; Fri, 24 May 2019 15:31:44 -0400 (EDT) Received: from mail02.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4DB30100A37; Fri, 24 May 2019 15:31:43 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1558726303; bh=dfTu7/XrL/CtLPXdi7aY+45XbPQE+HoKygRcO6NEOQ0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=PBnaHl3oqcoNTHjJq11s4axKPdw0/y+zzSz8JOmYQii1SjhGFTk9r7gGgv+WQJn6x hYiMO9HobinjrGHuaUsFzjJ2MSp8XhW4el6BrKkBcwLEk25PxKNks9UpM3Tw3Qlzqz U4/822m5LCOYfDEEu4zjyw7kkqd/BG8I4ZIg6U2LqOMcVJZSD9v7hLFhPLntYcvpPt 7/65OTf4s5cAfU/VB7q9P7kpcOYjDo3/7gxRABK7TTY/7p9QhPpE39951Wy6DOolbX Be2s4O3fdfn75LIhgCN4nSHG4+5FPID5puIt2iVeBDzXw7zDJ15NNkGbAYS/YWl6DH U8t/zkn3XNdOQ== Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail02.iro.umontreal.ca (Postfix) with ESMTPSA id 2BDA012084D; Fri, 24 May 2019 15:31:43 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#35739: Bad signature from GNU ELPA Message-ID: References: <87mujog0ao.fsf@gmail.com> <835zqca15y.fsf@gnu.org> <83woir92vl.fsf@gnu.org> <83o93v83si.fsf@gnu.org> <83muje76wa.fsf@gnu.org> <83k1eh7rtj.fsf@gnu.org> <838sux7owx.fsf@gnu.org> <8336l56yuy.fsf@gnu.org> <83zhnb5238.fsf@gnu.org> Date: Fri, 24 May 2019 15:31:42 -0400 In-Reply-To: <83zhnb5238.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 24 May 2019 18:00:59 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.532 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35739 Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> > I'd like us not to change that behavior by default. >> I think in this case we need to define it (i.e. document what it means >> to insert decoded text into a unibyte buffer). > Why do we have to define that only for that specific function? I didn't mean for this specific function, I meant in general. > And why is that relevant to the issue at hand, which is not to make > backward-incompatible changes in existing APIs? I consider myself fairly well versed in Emacs's coding systems. Yet, I don't know what decoding text into a unibyte buffer will do and can't find any doc that describes it. I such a context, I think preserving such a behavior is harmful in the long term because it will keep fundamentally buggy code half-working and keep spreading confusion about how coding systems work and people copy&pasting broken code. In the long term, I think we're better off introducing limited breakage where it leads to clearer errors that help clear up such confusions and fix bugs. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri May 24 15:43:59 2019 Received: (at 35739) by debbugs.gnu.org; 24 May 2019 19:43:59 +0000 Received: from localhost ([127.0.0.1]:47389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUG6g-0002IL-RL for submit@debbugs.gnu.org; Fri, 24 May 2019 15:43:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUG6f-0002I7-4I for 35739@debbugs.gnu.org; Fri, 24 May 2019 15:43:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45803) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUG6Z-0004aZ-OL; Fri, 24 May 2019 15:43:51 -0400 Received: from [176.228.60.248] (port=4700 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hUG6Z-0007Ca-7E; Fri, 24 May 2019 15:43:51 -0400 Date: Fri, 24 May 2019 22:43:48 +0300 Message-Id: <83pno74ozv.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Fri, 24 May 2019 15:31:42 -0400) Subject: Re: bug#35739: Bad signature from GNU ELPA References: <87mujog0ao.fsf@gmail.com> <835zqca15y.fsf@gnu.org> <83woir92vl.fsf@gnu.org> <83o93v83si.fsf@gnu.org> <83muje76wa.fsf@gnu.org> <83k1eh7rtj.fsf@gnu.org> <838sux7owx.fsf@gnu.org> <8336l56yuy.fsf@gnu.org> <83zhnb5238.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35739 Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com > Date: Fri, 24 May 2019 15:31:42 -0400 > > > And why is that relevant to the issue at hand, which is not to make > > backward-incompatible changes in existing APIs? > > I consider myself fairly well versed in Emacs's coding systems. Yet, > I don't know what decoding text into a unibyte buffer will do and can't > find any doc that describes it. > > I such a context, I think preserving such a behavior is harmful in the > long term because it will keep fundamentally buggy code half-working > and keep spreading confusion about how coding systems work and people > copy&pasting broken code. > > In the long term, I think we're better off introducing limited > breakage where it leads to clearer errors that help clear up such > confusions and fix bugs. I disagree. This stuff worked for decades, and breaking it only because it is under-documented is not a good idea. I'm okay with documenting what that produces somewhere, but not with breaking it. From debbugs-submit-bounces@debbugs.gnu.org Fri May 24 15:51:40 2019 Received: (at 35739) by debbugs.gnu.org; 24 May 2019 19:51:40 +0000 Received: from localhost ([127.0.0.1]:47394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUGE7-0002Va-MH for submit@debbugs.gnu.org; Fri, 24 May 2019 15:51:39 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUGE5-0002VN-JR for 35739@debbugs.gnu.org; Fri, 24 May 2019 15:51:38 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E13A581159; Fri, 24 May 2019 15:51:31 -0400 (EDT) Received: from mail02.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 45DA680BAF; Fri, 24 May 2019 15:51:30 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1558727490; bh=bRBJJCIUGV1ygoPJZeGczIilDaM3poTL2aAMs+fKULk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=VwRms+qJ6SCgndmHf8dPWhCkdKKoi+3xshJ4xGyIKf3SqOzuaaXtwi4Do0OW2L47B AQWUWp7GvNBt0/9YWmPjyZp/x3bjrdB7z7HjmHLFxAeUDkajm31RPmKW4T4YN2F4gk 2rIfPmyrpSQNUfIKqRfIzEGaWCRuabLnSsL4WncK0LIVJF0cRbvsQtsNJpaBYzzyx/ 0A5wlE8wDw51nk1lFFM6HM0mi52InYckQP+Akl8sHFt7ja4zZwifIABLwkMwBQSABI VDFtJ4ZV0VhRqcGs9HftQYDNFjV+03WJLXJd6FgrIbqjQ350HiZvd7xKYglj0sc3vZ hYk2Yi89U4ntg== Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail02.iro.umontreal.ca (Postfix) with ESMTPSA id C23B8120B30; Fri, 24 May 2019 15:51:29 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#35739: Bad signature from GNU ELPA Message-ID: References: <835zqca15y.fsf@gnu.org> <83woir92vl.fsf@gnu.org> <83o93v83si.fsf@gnu.org> <83muje76wa.fsf@gnu.org> <83k1eh7rtj.fsf@gnu.org> <838sux7owx.fsf@gnu.org> <8336l56yuy.fsf@gnu.org> <83zhnb5238.fsf@gnu.org> <83pno74ozv.fsf@gnu.org> Date: Fri, 24 May 2019 15:51:28 -0400 In-Reply-To: <83pno74ozv.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 24 May 2019 22:43:48 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 1.112 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35739 Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I'm okay with documenting what that produces somewhere That would be a big help, Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat May 25 03:36:48 2019 Received: (at 35739) by debbugs.gnu.org; 25 May 2019 07:36:48 +0000 Received: from localhost ([127.0.0.1]:48054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUREV-0005R9-PV for submit@debbugs.gnu.org; Sat, 25 May 2019 03:36:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUREU-0005Qx-BQ for 35739@debbugs.gnu.org; Sat, 25 May 2019 03:36:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55957) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUREO-00059i-Oq; Sat, 25 May 2019 03:36:40 -0400 Received: from [176.228.60.248] (port=4474 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hUREO-0001I7-1w; Sat, 25 May 2019 03:36:40 -0400 Date: Sat, 25 May 2019 10:36:36 +0300 Message-Id: <83imtz3rzv.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Fri, 24 May 2019 15:51:28 -0400) Subject: Re: bug#35739: Bad signature from GNU ELPA References: <835zqca15y.fsf@gnu.org> <83woir92vl.fsf@gnu.org> <83o93v83si.fsf@gnu.org> <83muje76wa.fsf@gnu.org> <83k1eh7rtj.fsf@gnu.org> <838sux7owx.fsf@gnu.org> <8336l56yuy.fsf@gnu.org> <83zhnb5238.fsf@gnu.org> <83pno74ozv.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35739 Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com > Date: Fri, 24 May 2019 15:51:28 -0400 > > > I'm okay with documenting what that produces somewhere > > That would be a big help, Where would you like this to be documented? Btw, in two different messages in this thread you mentioned two different situations. One is this: > document what it means to insert decoded text into a unibyte buffer The other is this: > I don't know what decoding text into a unibyte buffer will do The former seems to imply the following: (with-current-buffer BUFFER (set-buffer-multibyte nil) (insert (decode-coding-string STRING CODING-SYSTEM))) while the latter implies this: (with-current-buffer BUFFER (set-buffer-multibyte nil)) (decode-coding-string STRING CODING-SYSTEM nil BUFFER) The results of these 2 use cases are not the same. So I don't yet have a clear idea what exactly you want to be documented. In particular, what 'insert' does in the 1st use case seems to be documented in its doc string, but maybe that is not enough? From debbugs-submit-bounces@debbugs.gnu.org Sat May 25 14:39:07 2019 Received: (at 35739) by debbugs.gnu.org; 25 May 2019 18:39:07 +0000 Received: from localhost ([127.0.0.1]:49627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUbZT-0007BD-29 for submit@debbugs.gnu.org; Sat, 25 May 2019 14:39:07 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:42649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUbZQ-0007Ac-SJ for 35739@debbugs.gnu.org; Sat, 25 May 2019 14:39:05 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 734E48116B; Sat, 25 May 2019 14:38:59 -0400 (EDT) Received: from mail02.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5CC0F80ACD; Sat, 25 May 2019 14:38:58 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1558809538; bh=ti0NJmjciw4WjV1lpeIOufu6EN0y2uw0kEKLFEDSHPw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=X7XiVgmR4JMOqsK0xZYDTGeOfDbYkBVCcxSOI7PKP02KvMMPOtAPPgYJuqTs1JtCF /dvH6P/AU4uwbOGpwr0eX0/jY5/xRWgrBIyhVCwCqoHZ98ZpQhCN7ul1u4Bi+mW26Z E5wY+IPiLymqbKyj/ZTCKNw1twG+Ysgi7JVON0M6Gr7M6Pk5TT37aBl0Azr43uLZ8P O0gJBm0isY7tZ2ctch+Y/267zEwQKyadtmmfC0+XdR4QYHj6wIhCa1o87OQuD00y+N +4ROaK0DpJL7tYUh5Md1ijlVwpm4tIpYCKyka/29m1gajsSImloVQZTsINJtg0/0jP XjrC3JHSk5f8w== Received: from pastel (unknown [167.88.27.42]) by mail02.iro.umontreal.ca (Postfix) with ESMTPSA id 228FA1206EB; Sat, 25 May 2019 14:38:58 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#35739: Bad signature from GNU ELPA Message-ID: References: <835zqca15y.fsf@gnu.org> <83woir92vl.fsf@gnu.org> <83o93v83si.fsf@gnu.org> <83muje76wa.fsf@gnu.org> <83k1eh7rtj.fsf@gnu.org> <838sux7owx.fsf@gnu.org> <8336l56yuy.fsf@gnu.org> <83zhnb5238.fsf@gnu.org> <83pno74ozv.fsf@gnu.org> <83imtz3rzv.fsf@gnu.org> Date: Sat, 25 May 2019 14:38:56 -0400 In-Reply-To: <83imtz3rzv.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 May 2019 10:36:36 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.178 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35739 Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> > I'm okay with documenting what that produces somewhere >> That would be a big help, > Where would you like this to be documented? Any place is fine by me (including a comment in a C file). But I guess it would be better in Texinfo somewhere so we can point to it more easily. > Btw, in two different messages in this thread you mentioned two > different situations. One is this: >> document what it means to insert decoded text into a unibyte buffer > The other is this: >> I don't know what decoding text into a unibyte buffer will do [ Indeed, I corrected myself along the way. ] I'm mostly interested in the second, because I think I know what the first does (tho I think what it does is basically flawed, a holdover from the Emacs-20/21 days where most code was so hopelessly confused about chars-vs-bytes that it was a good idea to try and patch things over so it at least keeps working for environments like latin1 and koi-r, but nowadays we'd be better off signaling errors to try and fix the remaining confusion). Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat May 25 15:13:30 2019 Received: (at 35739) by debbugs.gnu.org; 25 May 2019 19:13:30 +0000 Received: from localhost ([127.0.0.1]:49646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUc6j-000829-Sp for submit@debbugs.gnu.org; Sat, 25 May 2019 15:13:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUc6h-00081x-Mg for 35739@debbugs.gnu.org; Sat, 25 May 2019 15:13:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35650) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUc6a-0003jk-Ri; Sat, 25 May 2019 15:13:22 -0400 Received: from [176.228.60.248] (port=4164 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hUc6Z-0002hQ-3u; Sat, 25 May 2019 15:13:20 -0400 Date: Sat, 25 May 2019 22:13:17 +0300 Message-Id: <83v9xy2vqq.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Sat, 25 May 2019 14:38:56 -0400) Subject: Re: bug#35739: Bad signature from GNU ELPA References: <835zqca15y.fsf@gnu.org> <83woir92vl.fsf@gnu.org> <83o93v83si.fsf@gnu.org> <83muje76wa.fsf@gnu.org> <83k1eh7rtj.fsf@gnu.org> <838sux7owx.fsf@gnu.org> <8336l56yuy.fsf@gnu.org> <83zhnb5238.fsf@gnu.org> <83pno74ozv.fsf@gnu.org> <83imtz3rzv.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35739 Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com > Date: Sat, 25 May 2019 14:38:56 -0400 > > >> > I'm okay with documenting what that produces somewhere > >> That would be a big help, > > Where would you like this to be documented? > > Any place is fine by me (including a comment in a C file). > But I guess it would be better in Texinfo somewhere so we can point to > it more easily. Done. I hope we can now talk about removing the incompatible change from url-insert. From debbugs-submit-bounces@debbugs.gnu.org Wed May 29 14:46:00 2019 Received: (at 35739) by debbugs.gnu.org; 29 May 2019 18:46:00 +0000 Received: from localhost ([127.0.0.1]:59864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hW3aK-0007Xf-Fm for submit@debbugs.gnu.org; Wed, 29 May 2019 14:46:00 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:40298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hW3aJ-0007XP-Dc for 35739@debbugs.gnu.org; Wed, 29 May 2019 14:45:59 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 06C88442DD8; Wed, 29 May 2019 14:45:54 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 26033442DD5; Wed, 29 May 2019 14:45:52 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1559155552; bh=1EPo1D74GW7B9Umm62ENGFzfrA8iu3G+kmbN/65kGa8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=RsEySvAmI/5oQf3uFNm/ot1Nz05UiEOf2giqhyNliI2ir/L8/vDxa++auMlQxS/VY NSXM/lSSt2EqLY9eHDqg4xo5WeLONLPWVJWIdjcFctgwFUZAzssTs5/dxfYVFMxTlS o1Fatp7xD1wrARN1M+PD4G/piW7sPtjDvuivvS7Mwzrf2aWUyMksXxtzhbe0gCrIfG EKI5LbTHAiesLG40ojX2tw9YudTQesmtmvHN/0UsuMm3Fo3Kf/lr1UQlnR3HuOw9Wu xo8ep99zlEHUZoScPkz7RJxm1LO6l9S1MY0RTU6rNpfaQeCha6PFp2xntz+jmp+4Db s6FE2hg13pedw== Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 84DA0120B7F; Wed, 29 May 2019 14:45:51 -0400 (EDT) From: Stefan Monnier To: Richard Copley Subject: Re: bug#35739: Bad signature from GNU ELPA Message-ID: References: <87mujog0ao.fsf@gmail.com> <837easa178.fsf@gnu.org> Date: Wed, 29 May 2019 14:45:50 -0400 In-Reply-To: (Richard Copley's message of "Wed, 15 May 2019 07:46:12 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.660 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain KAM_SHORT 0.001 Use of a URL Shortener for very short URL X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35739 Cc: 35739@debbugs.gnu.org, Eli Zaretskii , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Not in detail, it's not an area of expertise of mine. We call > (decode-coding-region (point-min) (point-max) 'undecided) on the > payload of "https://elpa.gnu.org/packages/archive-contents", > which is raw text. The resulting buffer's buffer-file-coding- > system is iso-latin-1-dos. Indeed, it seems that url-insert-file-contents sets buffer-file-coding-system. Maybe we can use that in the emacs-26 branch. Can you try the emacs-26 code with the patch below to see if it fixes the current problem? Stefan 2019-05-29 Stefan Monnier * lisp/emacs-lisp/package.el: Obey buffer-file-coding-system. `url-insert-file-contents` saves in buffer-file-coding-system the coding-system used to decode the contents. Preserve this as the contents is moved from buffer to string to buffer, and use it when saving the contents to file, so as to try and better preserve the original byte sequence (bug#35739). (package--buffer-string, package--cs): New functions. (package--check-signature): Encode `string` if a coding-system was specified in buffer-file-coding-system. (package--download-one-archive, package-install-from-archive): Obey and preserve the buffer-file-coding-system if specified. diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 1a185de4a5..46f7c91272 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -1241,6 +1241,17 @@ package--check-signature-content (signal 'bad-signature (list sig-file))) good-signatures))) +(defun package--buffer-string () + (let ((string (buffer-string))) + (when (and buffer-file-coding-system + (> (length string) 0)) + (put-text-property 0 1 'package--cs buffer-file-coding-system string)) + string)) + +(defun package--cs (string) + (and (> (length string) 0) + (get-text-property 0 'package--cs string))) + (defun package--check-signature (location file &optional string async callback unwind) "Check signature of the current buffer. Download the signature file from LOCATION by appending \".sig\" @@ -1260,8 +1271,12 @@ package--check-signature UNWIND, if provided, is a function to be called after everything else, even if an error is signaled." - (let ((sig-file (concat file ".sig")) - (string (or string (buffer-string)))) + (let* ((sig-file (concat file ".sig")) + (string (or string (package--buffer-string))) + (cs (package--cs string))) + ;; Re-encode the downloaded file with the coding-system with which + ;; it was decoded, so we (hopefully) get the exact same bytes back. + (when cs (setq string (encode-coding-string string cs))) (package--with-response-buffer location :file sig-file :async async :noerror t ;; Connection error is assumed to mean "no sig-file". @@ -1529,7 +1544,7 @@ package--download-one-archive :error-form (package--update-downloads-in-progress archive) (let* ((location (cdr archive)) (name (car archive)) - (content (buffer-string)) + (content (package--buffer-string)) (dir (expand-file-name (format "archives/%s" name) package-user-dir)) (local-file (expand-file-name file dir))) (when (listp (read content)) @@ -1538,7 +1553,8 @@ package--download-one-archive (member name package-unsigned-archives)) ;; If we don't care about the signature, save the file and ;; we're done. - (progn (let ((coding-system-for-write 'utf-8)) + (progn (let ((coding-system-for-write + (or (package--cs content) 'utf-8))) (write-region content nil local-file nil 'silent)) (package--update-downloads-in-progress archive)) ;; If we care, check it (perhaps async) and *then* write the file. @@ -1546,7 +1562,7 @@ package--download-one-archive location file content async ;; This function will be called after signature checking. (lambda (&optional good-sigs) - (let ((coding-system-for-write 'utf-8)) + (let ((coding-system-for-write (or (package--cs content) 'utf-8))) (write-region content nil local-file nil 'silent)) ;; Write out good signatures into archive-contents.signed file. (when good-sigs @@ -1838,15 +1854,17 @@ package-install-from-archive (let ((save-silently t)) (package-unpack pkg-desc)) ;; If we care, check it and *then* write the file. - (let ((content (buffer-string))) + (let ((content (package--buffer-string))) (package--check-signature location file content nil ;; This function will be called after signature checking. (lambda (&optional good-sigs) ;; Signature checked, unpack now. - (with-temp-buffer (insert content) - (let ((save-silently t)) - (package-unpack pkg-desc))) + (with-temp-buffer + (insert content) + (setq buffer-file-coding-system (package--cs content)) + (let ((save-silently t)) + (package-unpack pkg-desc))) ;; Here the package has been installed successfully, mark it as ;; signed if appropriate. (when good-sigs From debbugs-submit-bounces@debbugs.gnu.org Wed May 29 15:12:26 2019 Received: (at 35739) by debbugs.gnu.org; 29 May 2019 19:12:26 +0000 Received: from localhost ([127.0.0.1]:59885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hW3zt-0008DB-RV for submit@debbugs.gnu.org; Wed, 29 May 2019 15:12:26 -0400 Received: from mail-oi1-f181.google.com ([209.85.167.181]:42644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hW3zs-0008Cy-90 for 35739@debbugs.gnu.org; Wed, 29 May 2019 15:12:24 -0400 Received: by mail-oi1-f181.google.com with SMTP id v25so2442401oic.9 for <35739@debbugs.gnu.org>; Wed, 29 May 2019 12:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qCMb9MdMOu21naqnGU5TGxZRMjYNx+poHDhbqrYtOak=; b=EFK/LZ+cLr1OPvUQdIoY6j8rPF1JHMJvseeuFF+MAk3M5kxN5Fea5MiZHXq7B2FJbT Ie5JiXqd4cLyCEG6MVtAsz/6O1wHwWyDKfhM8hmglQSLOqKPc4HBMvIJ6uAJRRk26jdU zOdN8fr8ItQjqO03rfOHjWstZKrSYvTJyC9fMGybbxEjDIZdyn5X/R2q+M8bEbrdpHd0 AbMj21M1gS8Sy88NwTgp/Tfwu6mYM00Di65GZetHgCLtxeU6G/7x960ARijh2fxCzwpQ 4TvAFJKjsQds5Wa8DZb27KMRe1xnqgIUgsFxiIACyNZzKRf1YGYAcdkyP0zP4w4LNsPu FnrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qCMb9MdMOu21naqnGU5TGxZRMjYNx+poHDhbqrYtOak=; b=Kk2bQE2ajGpflOrLg3YkFgBTSSZC8iuZkK0pTOlhTfqJD43n027Q/vI3peGAFCveuG hLd0L1v+R8I1MgVwBycAceulvcSedEOJ3Ky3kvdjDUL5S5zauOD7mfiAiKFpRZk4pqkQ CO5yOoc7jbmAINFxHqtUjtxEXmR75BOBD9KZnQ7l7ImtkYVX5/v+Omd/LucACvoYDFZu QsC6AbVQVYRAUGnRcsd8fR53uBfJL4Ymejj2UN9msrT/Fe1yWVMC78vVTFShRerBTgOc WTO05ca5fuQSZ9P+Yot5Ar+DkSG66Rj9xm4UmE3MS5fmfGtkm7jeiWmG6r7F+NKlgTdv lTSg== X-Gm-Message-State: APjAAAURPMfPhPPYKzTh17RGnxoEqGpaOb/L29zaccWSkwronkmUiWqr bcntOcPcLfOXyxIDGKz9p7Tmy55CirlZFp8obKA= X-Google-Smtp-Source: APXvYqzBPTXSoo6OQS3pRjPYJuJGC8WgwtcuoFj4iQBd1V2wpA8Wxzpf0QUPbkg8H5GPcWSiXr2ZE+IaqmV49b2dIeQ= X-Received: by 2002:aca:ef43:: with SMTP id n64mr2414982oih.79.1559157133672; Wed, 29 May 2019 12:12:13 -0700 (PDT) MIME-Version: 1.0 References: <87mujog0ao.fsf@gmail.com> <837easa178.fsf@gnu.org> In-Reply-To: From: Richard Copley Date: Wed, 29 May 2019 20:11:46 +0100 Message-ID: Subject: Re: bug#35739: Bad signature from GNU ELPA To: Stefan Monnier Content-Type: multipart/alternative; boundary="0000000000001a076f058a0b8f56" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35739 Cc: 35739@debbugs.gnu.org, Eli Zaretskii , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000001a076f058a0b8f56 Content-Type: text/plain; charset="UTF-8" On Wed, 29 May 2019 at 19:45, Stefan Monnier wrote: > > Not in detail, it's not an area of expertise of mine. We call > > (decode-coding-region (point-min) (point-max) 'undecided) on the > > payload of "https://elpa.gnu.org/packages/archive-contents", > > which is raw text. The resulting buffer's buffer-file-coding- > > system is iso-latin-1-dos. > > Indeed, it seems that url-insert-file-contents sets > buffer-file-coding-system. Maybe we can use that in the emacs-26 > branch. Can you try the emacs-26 code with the patch below to see if it > fixes the current problem? > Yes, it seems to. At least, there's no error from [M-x package-list-packages] in emacs -Q. --0000000000001a076f058a0b8f56 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, 29 May 2019 at 19:45, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">> Not in detail, it'= ;s not an area of expertise of mine. We call
> (decode-coding-region (point-min) (point-max) 'undecided) on the > payload of "https://elpa.gnu.org/packages/ar= chive-contents",
> which is raw text. The resulting buffer's buffer-file-coding-
> system is iso-latin-1-dos.

Indeed, it seems that url-insert-file-contents sets
buffer-file-coding-system.=C2=A0 Maybe we can use that in the emacs-26
branch.=C2=A0 Can you try the emacs-26 code with the patch below to see if = it
fixes the current problem?

Yes, it seem= s to. At least, there's no error from [M-x package-list-packages] in em= acs -Q.

--0000000000001a076f058a0b8f56-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 29 16:07:30 2019 Received: (at 35739) by debbugs.gnu.org; 29 May 2019 20:07:30 +0000 Received: from localhost ([127.0.0.1]:59991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hW4rC-0001F2-4K for submit@debbugs.gnu.org; Wed, 29 May 2019 16:07:30 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:43479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hW4rA-0001Eq-Ii for 35739@debbugs.gnu.org; Wed, 29 May 2019 16:07:28 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D7AF51011C4; Wed, 29 May 2019 16:07:22 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5EE5B101138; Wed, 29 May 2019 16:07:21 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1559160441; bh=wUTeeKD2k3wwFgK0cv5y0DPeByZ94GIDiZIe7/etSaY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=pOXn5JwzQHkpSzhJMHOVvk08WKU/CfJPgEF3LqF962ypnMKXuVHOsbH6W4H8UThZs tRQ9UCBNuhWqG9tOv6VjL2PS/2xEW4cGnyhgw2Ul966GIqQYILPJFN3b44Q9yWLjZ5 dZx3QV73ZO4DmTMdZ4WxXR2jV0tBR/ONQ4uOqkWmBT4VHoTxZ+0SoeUAbArv67HzpY knr2oFHVmev1Y7Qrf4TuDD6xUeVJSRUtvNFtgY0gLNgDoJrMXcePENlVYrKGl9oRLT qqcfKlCFGLJfjDNKFjExGyxfRK1trm2A1vWTez66NbEfBR3I7A4mCGYnKXrYPlOGpo kS3GGd/TPTkbA== Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8BD17120AEF; Wed, 29 May 2019 16:07:18 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii , Noam Postavsky Subject: Re: bug#35739: Bad signature from GNU ELPA Message-ID: References: <87mujog0ao.fsf@gmail.com> <837easa178.fsf@gnu.org> Date: Wed, 29 May 2019 16:07:10 -0400 In-Reply-To: (Richard Copley's message of "Wed, 29 May 2019 20:11:46 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.478 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain KAM_SHORT 0.001 Use of a URL Shortener for very short URL X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35739 Cc: 35739@debbugs.gnu.org, Richard Copley X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> > Not in detail, it's not an area of expertise of mine. We call >> > (decode-coding-region (point-min) (point-max) 'undecided) on the >> > payload of "https://elpa.gnu.org/packages/archive-contents", >> > which is raw text. The resulting buffer's buffer-file-coding- >> > system is iso-latin-1-dos. >> >> Indeed, it seems that url-insert-file-contents sets >> buffer-file-coding-system. Maybe we can use that in the emacs-26 >> branch. Can you try the emacs-26 code with the patch below to see if it >> fixes the current problem? >> > > Yes, it seems to. At least, there's no error from [M-x > package-list-packages] in emacs -Q. Thanks Richard for promptly testing it. Noam, can you confirm that you can also still reproduce the problem in `emacs-26` and that my patch fixes it when you try it? Eli, do you think this is safe enough for the `emacs-26` branch? Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed May 29 16:51:14 2019 Received: (at 35739) by debbugs.gnu.org; 29 May 2019 20:51:14 +0000 Received: from localhost ([127.0.0.1]:60048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hW5XW-0002MX-Fp for submit@debbugs.gnu.org; Wed, 29 May 2019 16:51:14 -0400 Received: from mail-ot1-f45.google.com ([209.85.210.45]:38036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hW5XT-0002MK-8R for 35739@debbugs.gnu.org; Wed, 29 May 2019 16:51:13 -0400 Received: by mail-ot1-f45.google.com with SMTP id s19so3468462otq.5 for <35739@debbugs.gnu.org>; Wed, 29 May 2019 13:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2NkPBoidQyVHzFSrQ9zrCqNDzfiGWoCnzbQphFLFMvU=; b=MdyvVEaCW5NH9EQG1QZjAfaYlTNDZhuy+sfCgp7N5QvPZU3ZDxMamnBCWKNZ0piDuD RilP/xb/tyr3v4eQHAGTIn2slfLupoYZvT1GTcqda+zjLwsBiuITN1LenQjKUuBwOTbp t9/2t/AsHsG1yZLmqtdpx8njgZz4M/2zPNpTrNkmpnGufzjUs/ejBSE34ITa2N26YZwM sAH0CGxjcxpt/M7dnZ4ZVoG9mu94kZz1LmakoptdvJQuappjAF+iWRqClI4Cgbz7b0ML fK1rSteS035WuWVZ8TyuES04/GyOZIiza+57wbrqBJZqcp0QjIlXy7LNQl1oouxZwqA2 lyIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2NkPBoidQyVHzFSrQ9zrCqNDzfiGWoCnzbQphFLFMvU=; b=oAlWsNZPu+aNuWQpZCTyQ14ZuWL/z0GO1VykBuS0xk9T/A3weKpD0veQWrI7+TK0Bn uJknF7+EIOm52zktKd6OWtQXHw2pbvlHwEJs4+LlQ3w0Nkai3AdgNWYPBX5q+1S2eTRi jaUtWoZm3s9bcLvpe0+YWT8oH44y5RLS1UoTO/gEO/Ae5gIFkCS8tOKg/L7Cuedho/vI MKfs/GwUwxxdSBP4PQ0ag3xwG1IBr7DMPjiVK33Mt19HaA5XDbFo7IXoc/lG30jK3MED gdssLH5ZrkKGJhzHr8Qt4bEJip9++mjWfn8954y4sSIuzifxSmtDxHwcoz/owoXJp2sz sIIA== X-Gm-Message-State: APjAAAUTV+tRJpQy0adwIij04QUfBLk3OGhMG/Dh8ifEt4pkdoDpi2sH wPsd/mKOKNwmwPHxDmBZYhHtdqrtjZTQSUbG91o= X-Google-Smtp-Source: APXvYqxtvL2l0WXsm5yyBVH1OfgTVb07/YPwosnYwLMNJ9qbsS//jzM6sHTr/pMmHJkgCs5glgwrGo2sA+eStQjMc1s= X-Received: by 2002:a9d:735a:: with SMTP id l26mr27954464otk.308.1559163065675; Wed, 29 May 2019 13:51:05 -0700 (PDT) MIME-Version: 1.0 References: <87mujog0ao.fsf@gmail.com> <837easa178.fsf@gnu.org> In-Reply-To: From: Noam Postavsky Date: Wed, 29 May 2019 16:50:49 -0400 Message-ID: Subject: Re: bug#35739: Bad signature from GNU ELPA To: Stefan Monnier Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 35739 Cc: 35739@debbugs.gnu.org, Richard Copley , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) On Wed, 29 May 2019 at 16:07, Stefan Monnier wrote: > Noam, can you confirm that you can also still reproduce the problem in > `emacs-26` and that my patch fixes it when you try it? Yes and yes. I also tried installing ascii-art-to-unicode (since it has some "interesting" characters) and it downloaded fine too. From debbugs-submit-bounces@debbugs.gnu.org Wed May 29 22:35:12 2019 Received: (at 35739) by debbugs.gnu.org; 30 May 2019 02:35:12 +0000 Received: from localhost ([127.0.0.1]:60501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWAuO-0005IZ-Am for submit@debbugs.gnu.org; Wed, 29 May 2019 22:35:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWAuM-0005IJ-Dj for 35739@debbugs.gnu.org; Wed, 29 May 2019 22:35:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34545) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWAuH-0002P9-2c; Wed, 29 May 2019 22:35:05 -0400 Received: from [176.228.60.248] (port=2745 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hWAuG-0004QD-11; Wed, 29 May 2019 22:35:04 -0400 Date: Thu, 30 May 2019 05:35:15 +0300 Message-Id: <83ftowy8ik.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Wed, 29 May 2019 16:07:10 -0400) Subject: Re: bug#35739: Bad signature from GNU ELPA References: <87mujog0ao.fsf@gmail.com> <837easa178.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35739 Cc: 35739@debbugs.gnu.org, rcopley@gmail.com, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: 35739@debbugs.gnu.org, Richard Copley > Date: Wed, 29 May 2019 16:07:10 -0400 > > Eli, do you think this is safe enough for the `emacs-26` branch? Yes. From debbugs-submit-bounces@debbugs.gnu.org Fri May 31 00:54:40 2019 Received: (at 35739-done) by debbugs.gnu.org; 31 May 2019 04:54:41 +0000 Received: from localhost ([127.0.0.1]:34605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWZYt-0004LV-SC for submit@debbugs.gnu.org; Fri, 31 May 2019 00:54:40 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11767) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWZYq-0004L5-N0 for 35739-done@debbugs.gnu.org; Fri, 31 May 2019 00:54:38 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 49E551011B6; Fri, 31 May 2019 00:54:31 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 29F43100DB7; Fri, 31 May 2019 00:54:30 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1559278470; bh=qrheXuU7U3ra8YVCwfhtt+r8xL3tJDlmrM9kDZTGgbs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=T80QnQui97btIP19v1y6N6Ak0BWlAjhB8ydRKCjewiVuaSlDh+HGzFybliGGxAJ7p saQG21ZqaCSL+aJRjYjK7NogZEu08cQPcQNGImREeOBII3Rhy9/XLDQI2HWkHWr14Y aJ9iyfN8thgn+Q5VsvDli7lZ2YfV4+3RCnbi+d2OnGP5sotZGltVRx9uS0/bhcie+R 5GeXI3LS0kpBIQD2xjAG5AGpB25Qz7pOkoGsPOAbZu1WZrIK6Cc3kTpqoNOv6tKTIM q7Z6nWWd1lYBWcj/Yxr8EnlmuQwSOruQdQib65R/LNhs2SCTGb1hanEbvM0WNLrno7 oNO7jTzqWyHJA== Received: from pastel (unknown [157.52.6.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E3E82120563; Fri, 31 May 2019 00:54:29 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#35739: Bad signature from GNU ELPA Message-ID: References: <87mujog0ao.fsf@gmail.com> <837easa178.fsf@gnu.org> <83ftowy8ik.fsf@gnu.org> Date: Fri, 31 May 2019 00:54:28 -0400 In-Reply-To: <83ftowy8ik.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 30 May 2019 05:35:15 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35739-done Cc: 35739-done@debbugs.gnu.org, rcopley@gmail.com, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> Eli, do you think this is safe enough for the `emacs-26` branch? > Yes. Thanks, installed, Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 01 18:04:19 2019 Received: (at control) by debbugs.gnu.org; 1 Jun 2019 22:04:19 +0000 Received: from localhost ([127.0.0.1]:38877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXC6t-000137-Gx for submit@debbugs.gnu.org; Sat, 01 Jun 2019 18:04:19 -0400 Received: from mail-it1-f180.google.com ([209.85.166.180]:35717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXC6r-00012q-Oc for control@debbugs.gnu.org; Sat, 01 Jun 2019 18:04:18 -0400 Received: by mail-it1-f180.google.com with SMTP id n189so2638622itd.0 for ; Sat, 01 Jun 2019 15:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=68TkFA9nRibCLDk6/5dO1oej/JqwbUhXdUmD28P/xn0=; b=iimixM/o6ribz9TMzF4uA9ICWuGVUSTyYsJwhQ3BN5h+I4OYD3xfcvgYFm8PiIOJHt dOT8enVTTRBIrjHm/1QQBd7hKlkoe1oSJhSbXgN08ivhudLSHOIpCZiBZz6Cqr/f8mib M2kcqsIUdt6mFa1gmc2v+851RVipzSiGrer/h+fm0YoGM/OMIBmTfOrVF7W339vcurEW CR0NOFuvAIRwSmTiEoI+63zzeWiJkcdqRy3+7UFo/HQbd5edFmuiyxWZYN23i6HuZZcr A5aUZhhg7C5sNgc613VJ39blU9kxK+4mHccSbkg/rsDFchGo0FvtzDLGzKxwmaelQYwa FE0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=68TkFA9nRibCLDk6/5dO1oej/JqwbUhXdUmD28P/xn0=; b=I97gzadFEFhyqgJ2e44L6gGraNDRhDpGFo6RE/R2QeouYg0dFtczd5L77hTNMZPO9n FDXCnkEvyaOl2uoEb7dVKzwZ/cPkWeaM8y6YNX11oTWmrKSFWAi7OcGvybReE6F4HamJ 4/LrhHdXgCh3MBVCd6gVg7/KvPLM+0EgchdHAjQi2m0dTgp7AzRQFUUWfXJZoiAih7Nm i1jaVtRG1SwIyWNL8t34Ay9VdJxHuWBd9peekMaid/6UoiNaFpgXtuHEV7SWNFsoIjJR 1wvvDpTJW6W4ZH131aN+XxcHXV3BOndHQVL4PajXfe2EODE4nIlrUJ73Kk6tTkboAjAF XUAg== X-Gm-Message-State: APjAAAVjFwa3h4guzxx+yc8qxdjbPKziUqctmxujQ8ttLt38qXhDbXmC 6/EuuJa8O5f7P/g8crThQ7cLcU9z X-Google-Smtp-Source: APXvYqzMyOrCB3eNV3e7uwFsKoMRcSkSikmsH4c0TgG4yEXZ+CtdS/3ltJ/OrgMvXPzcxc2VLKUdqA== X-Received: by 2002:a24:4794:: with SMTP id t142mr11873450itb.121.1559426652021; Sat, 01 Jun 2019 15:04:12 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id r62sm4507107ita.37.2019.06.01.15.04.11 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 01 Jun 2019 15:04:11 -0700 (PDT) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for bug #35739 Date: Sat, 01 Jun 2019 18:04:10 -0400 Message-ID: <87a7f155et.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) fixed 35739 26.3 quit From unknown Sat Jun 21 10:29:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 30 Jun 2019 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator