GNU bug report logs - #35708
[27.0.50]: thingatpt.el, thing-at-point-looking-at redundant

Previous Next

Package: emacs;

Reported by: Andreas Röhler <andreas.roehler <at> easy-emacs.de>

Date: Mon, 13 May 2019 07:19:01 UTC

Severity: wishlist

Tags: notabug, wontfix

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #23 received at 35708 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> gmail.com
To: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
Cc: 35708 <at> debbugs.gnu.org, npostavs <at> gmail.com
Subject: Re: bug#35708: [27.0.50]: thingatpt.el,
 thing-at-point-looking-at redundant
Date: Tue, 14 May 2019 10:34:55 -0400

Andreas Röhler <andreas.roehler <at> easy-emacs.de> writes:

>> Hmm, current thing-at-point-looking-at might be slow with large
>> buffers. The slightly modified test should reveal it:
>>
>> (ert-deftest thing-at-point-looking-at-2 ()
>>   (with-temp-buffer
>>     (insert "1abcd 222abcd")
>>     (dotimes (_ 99999) (insert " asdf "))
>>     (goto-char (point-min))

>>       (search-forward "2ab")
>>       (should (thing-at-point-looking-at "2abcd"))

Yes, in this case, since the loop over looking-at only needs to iterate
twice, so it will be faster.  But what about when there is no match?
E.g.,

(with-temp-buffer
  (dotimes (_ 99999) (insert " asdf "))
  (goto-char (point-max))
  (list :ar-regexp-atpt (benchmark-run (ar-regexp-atpt "foo"))
        :thing-at-point-looking-at (benchmark-run (thing-at-point-looking-at "foo"))))

> Another fix, as a bug showed up when testing (ar-regexp-atpt "[a-z]+"):
>
> (defun ar-regexp-atpt (regexp)
>   "Return t if REGEXP matches at or before point, nil otherwise.
>
> Changes match-data"
>   (save-excursion
>     (if (looking-at regexp)
>     (while
>         (and (not (bobp))
>          (or (progn (backward-char) (looking-at regexp))
>              (forward-char 1))))
>       (while (not (or (bobp) (backward-char) (looking-at regexp))))
>       (ar-regexp-atpt regexp))

What's this recursive call for?  It triggers (error "Lisp nesting
exceeds ‘max-lisp-eval-depth’") in the benchmark above.

>     (looking-at regexp)))
This bug report was last modified 5 years and 362 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.