From debbugs-submit-bounces@debbugs.gnu.org Mon May 13 03:18:47 2019 Received: (at submit) by debbugs.gnu.org; 13 May 2019 07:18:47 +0000 Received: from localhost ([127.0.0.1]:43937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQ5EV-0007B6-DS for submit@debbugs.gnu.org; Mon, 13 May 2019 03:18:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQ5ET-0007Ai-5U for submit@debbugs.gnu.org; Mon, 13 May 2019 03:18:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:56964) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hQ5EO-0000MC-0F for submit@debbugs.gnu.org; Mon, 13 May 2019 03:18:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQ5EN-00014K-3k for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 03:18:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQ5EM-0000Lc-Bh for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 03:18:39 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:42161) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQ5EM-0000Kx-3R for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 03:18:38 -0400 Received: from [192.168.178.39] ([87.123.193.71]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MWhxY-1hAlHN3kmu-00X8Kl for ; Mon, 13 May 2019 09:18:34 +0200 To: bug-gnu-emacs@gnu.org From: =?UTF-8?Q?Andreas_R=c3=b6hler?= Subject: [27.0.50]: thingatpt.el, thing-at-point-looking-at redundant Message-ID: <8a73a0c9-5b38-4089-2780-28e62a1e162b@easy-emacs.de> Date: Mon, 13 May 2019 09:19:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Provags-ID: V03:K1:sqX5NsbH6P+TG4WXgpzkuGCtXN2pFS+V8Mns2OnV7n5A9MYDTsB 76bvPAjtaRwti6bEkeZC9MKdo64POscelfgFHHt6vRz/Fov6llAdCoFoLwBp1Z07o0JIS5I elxsIlr9O+2CHEeUD2crPKAcXvgdXuB/h8IplhSSsZjPKwDVoiybrkGJdU7eH884QMV0D0K YRI1zClboBKfI2G596fOA== X-UI-Out-Filterresults: notjunk:1;V03:K0:CPktwuRU+To=:aP/p/PyeMSRDKGa8MLCqZq VxsTfwRScM4X6oGD5reyl5H0gsCNNbuWhcub9/01Aq/BY7+1ahcBHYMYnoIws4aphLH1f51+Q 1bhgU6+WCsy7qUj9Lp4AOR16kbb1tDpb1YRRnb89Ng9D9M9NNNw1wEeaZ4rR1zrg6cQvdiu3T LQtF2bKRw9gcY3Zs5/uT2K4ou0kmd3Hc2vvTUfucz3d8rIEH9WZ4aS5VVtqhbFZY8sli2/BZG Hp0viQKIuEoVCf/a5XadhLQEIVDbGw7jTDDKo+yIAav1KNu0DQJI+iHvVPDd0l1JKQ3gLz9MO tnRbo3xVWpxO/lAgi4fUPBt/EzdbAv0xDUbFTQHRtg/8DCH+Rp/ImSvY7CA4hsoyAURAVgT+J 57gLEV4te1VCPOr8v2QZYT6Wegm/5GVU6cnO/3UMkmDhnU8uX9paX4vENdDC4AFzd9Uy6luZV BNZ87gab1eHnn5a4GC2mYvLjg1UaKnWvks+5S9cOs6Dn8XiiYVz3yYoddPNNOspHcVGsGK3pC LDt4knpOeSAuYtrnDGp2cU3VgFpOUC4/Xn/cBslW6OsCimDrnXjx/eL08Q3SscCEwi0vVOuwX OCta8tYC4NjLRKN5UnFiS5OxouOTSRStAbFwseuKN8eEN/6BKfbxSwcXj+3G3cZeNf9k6ZXs+ nOa3Z0PxUEm0nimHGlKd/Kbaqeyxv2eW1Q3xAvZN7iFVShFf1Il10RZtixOu4j7Z3o5xz+2ou OJw8eR6P3EyoavLy84W99RbiVODaYpjBw67h8fMkFdOv/FV5TPXmec5yiGIapcovfRGYoLvf9 t5tIti1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.135 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi all, as result of ‘thing-at-point-looking-at’ finally is delivered by ‘looking-at’, don't see any sense in calling ‘re-search-forward’ first. Best, Andreas GNU Emacs 27.0.50 (build 1, i686-pc-linux-gnu, GTK+ Version 3.14.5) of 2019-04-29 From debbugs-submit-bounces@debbugs.gnu.org Mon May 13 08:41:13 2019 Received: (at 35708) by debbugs.gnu.org; 13 May 2019 12:41:13 +0000 Received: from localhost ([127.0.0.1]:44419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQAGW-0000GL-Q4 for submit@debbugs.gnu.org; Mon, 13 May 2019 08:41:13 -0400 Received: from mail-io1-f54.google.com ([209.85.166.54]:45613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQAGU-0000G4-BV for 35708@debbugs.gnu.org; Mon, 13 May 2019 08:41:11 -0400 Received: by mail-io1-f54.google.com with SMTP id b3so9838323iob.12 for <35708@debbugs.gnu.org>; Mon, 13 May 2019 05:41:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=tfYUjXuOwZ5ubrBTMGJxgD5PP7/XdpgUGj+hZ8d9cVE=; b=lZxAe1AqO3CJG1ur8WsjvJKiBifXRvslSLvZrgAs3QvBBIIgkn3cMcYMj73zbtK9ZU HQIA8EawtoSpofzQ7Y725NQQmIqcwUKpmMtEfrzb5NveDXcOC+8lKvoC2EpdijPQ5cBa 9flUc0kP6++3oCX19WYth6dgwHdap16mz24JXnqOceUOPvEwkJJN5V4nROE18oi5UvyL 7P4FMeky6vDHxLqD2aYrQj/I8CfMs+aQ0p12DqxIj8qFL1fRlZfahPFygJ9/tNdyYRAa qRD6u+5H+Ow+RyuUZQeE/wPYdxDoSqb42XetTZ5g08ToJ+oEnCuU6m/jvvzzBq5uBBDt rsAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=tfYUjXuOwZ5ubrBTMGJxgD5PP7/XdpgUGj+hZ8d9cVE=; b=RAFrruurY8FSPkiu327Fgsbn53ZkXURBWGBjPJZ7djttiRkOu1PZNS7NyDCQAY4s/C ur4FcYUP6wrXC2RgGXvPGo1mVd/eZasvWDwlVsfJghp5RL9DNX4JbKg6wT8PvEUU3ApX M4s2zUj8/cvbhRKsQdtLxr/Gn8GNabp74eof5ApWyUqUldXA5OMh1UVoBaH8Y16/WJT/ 4b+YcCc/SuUzdow/SInxvId9oNILaIkMNFowpNpxIz514h+ZjPxMBPpuWCWIfWJwPd8v HB113XWrtGST2MK/n5SrF6KeG7F+jNMMTaXgYKdn5cNQLEP0bFRkyOLG6ibbpVG/omxv soLw== X-Gm-Message-State: APjAAAXX4ohqa609gHYM/8thhYtbdPlyPFtMKgyGWmUAiXbbzrkTJPni QGQ19uc9jmp3APGQ1ywsz7PSQYeI X-Google-Smtp-Source: APXvYqytFnJKhNbCOPfpAtvvk9kfWcGAgVWXCedxJwlscp0IvJl4QYfWrrddQ9bVa+gqTffJw8TfgA== X-Received: by 2002:a5e:8216:: with SMTP id l22mr14691034iom.269.1557751264314; Mon, 13 May 2019 05:41:04 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id i141sm6159745ite.20.2019.05.13.05.41.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 May 2019 05:41:03 -0700 (PDT) From: Noam Postavsky To: Andreas =?utf-8?Q?R=C3=B6hler?= Subject: Re: bug#35708: [27.0.50]: thingatpt.el, thing-at-point-looking-at redundant References: <8a73a0c9-5b38-4089-2780-28e62a1e162b@easy-emacs.de> Date: Mon, 13 May 2019 08:41:03 -0400 In-Reply-To: <8a73a0c9-5b38-4089-2780-28e62a1e162b@easy-emacs.de> ("Andreas \=\?utf-8\?Q\?R\=C3\=B6hler\=22's\?\= message of "Mon, 13 May 2019 09:19:20 +0200") Message-ID: <87ftpih6hs.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35708 Cc: 35708@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Andreas R=C3=B6hler writes: > as result of =E2=80=98thing-at-point-looking-at=E2=80=99 finally is deliv= ered by > =E2=80=98looking-at=E2=80=99, > don't see any sense in calling =E2=80=98re-search-forward=E2=80=99 first. The test added below fails if the re-search-forward in thing-at-point-looking-at is commented out. Does that tell you what the "sense" is? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Add-thing-at-point-looking-at-test-Bug-35708.patch Content-Description: patch >From 79b55e8e6dfee9cba9e464860546dbab2cdd36d8 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Mon, 13 May 2019 08:39:00 -0400 Subject: [PATCH] ; Add thing-at-point-looking-at test (Bug#35708) * test/lisp/thingatpt-tests.el (thing-at-point-looking-at): New test. --- test/lisp/thingatpt-tests.el | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/test/lisp/thingatpt-tests.el b/test/lisp/thingatpt-tests.el index 452fcc6895..339a4a4b81 100644 --- a/test/lisp/thingatpt-tests.el +++ b/test/lisp/thingatpt-tests.el @@ -131,4 +131,15 @@ (ert-deftest thing-at-point-url-in-comment () (goto-char 23) (should (equal (thing-at-point 'url) "http://foo/bar(baz)")))) +(ert-deftest thing-at-point-looking-at () + (with-temp-buffer + (insert "1abcd 2abcd 3abcd") + (goto-char (point-min)) + (let ((m2 (progn (search-forward "2abcd") + (match-data)))) + (goto-char (point-min)) + (search-forward "2ab") + (should (thing-at-point-looking-at "2abcd")) + (should (equal (match-data) m2))))) + ;;; thingatpt.el ends here -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 13 14:31:16 2019 Received: (at 35708) by debbugs.gnu.org; 13 May 2019 18:31:16 +0000 Received: from localhost ([127.0.0.1]:46155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQFjH-0007g2-UU for submit@debbugs.gnu.org; Mon, 13 May 2019 14:31:16 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:52307) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQFjF-0007fm-Ph for 35708@debbugs.gnu.org; Mon, 13 May 2019 14:31:15 -0400 Received: from [192.168.178.39] ([87.123.193.71]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mnqfc-1gtcav07J4-00pO9O; Mon, 13 May 2019 20:31:07 +0200 Subject: Re: bug#35708: [27.0.50]: thingatpt.el, thing-at-point-looking-at redundant To: Noam Postavsky References: <8a73a0c9-5b38-4089-2780-28e62a1e162b@easy-emacs.de> <87ftpih6hs.fsf@gmail.com> From: =?UTF-8?Q?Andreas_R=c3=b6hler?= Message-ID: <1bbebe25-9c4e-2563-701b-9bed85fcabb0@easy-emacs.de> Date: Mon, 13 May 2019 20:31:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <87ftpih6hs.fsf@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Provags-ID: V03:K1:R+ZJyDCgXxeFIA5WmTo37U9KoizSzWzXpreywwuD/DpFlssKXyz 9im2yH8i4tecYEeEBo//1Gwg0CaGakRCgeop0IdsDtB+gmSPdb7BikRz/UsHq/WoNsGahJr tcfBgbvrN1bs1w3KSpH+Qud38wTQ6QiTl1hMrdUX4kYugwp1/GqAptE10k5qKXRfOFmeCVu lOIZJko+PSX6lSE0H0bng== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:FjZ8CnvD5Cc=:vXu5XxlpOobRE1CLEJkSDI UUzwXx5Zms/bDM4Hx42cT7bIHDOt92Ldozw+BCCN6JSx242gkEtmYEM5sxxBEac4gQLBJa3RN poa86cewy0igDJ3of3h7JcCGszM1ykOZq/5QsDGQA54ZefehcjZgUpDsQTGKh/F/LVWxlNI5O 3nUUjKxncA3OzODIxXJgmn57m56C6KKkLw9VSL2PresFTT6fz1FdNfhSwi3zSTApwsW5GM1/J LI58q6LZ7Tp0Ma43sZONZdjATp4slj/fXraTpWWob6L8TfUCFpf8irUIwq8iLdtscKrO213uj dZI5kB2FaeJJxcqv9YU0KdsGFDpvwaM2GpZfELOO8dhGr6Z6l744p7FQbfTeRRngVmD8Fv2Fo RsF5PrRkbd0ogeizJcmyTgYv7XBRHG+0KQEDHmNpwJ6cXqoe8zerJSLwwdzy+HYTbgFwi+guq lqwQ+snXxpwvuyK8WcYuHUYlprzmh5OAx1W2V3+Gsbs1MqFP19YAjFDMXWWMJFTXVoBXuE90a C9EZwJ/KDWufN2wLNEmw4Usz6TIx1ypO9pyczKFP504RcZ0rJxwLmOPgh5oVSxh5vhZkFvpfQ 0Hg3H/AsdShjOrDsF9+wavHOW0C6RRNd0a+gF7UeUfqJ4Z5LrcaPTPxN1ZQC6eIdHsUtjKAZE qt3JfA+VKLwZsaD7jVzEk6bG6CXvWICERYstFkVy8bPXJgEZDR5jcsfN7YHAMLSkZMUhcXUpk EdmBXc3kOvKa7Oo8vOtlHyg8RjSbOy34fW8upBm5GGlTbfTIN2yRfasE0EAmv47SmWn7oBL3N GbNYnYI X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35708 Cc: 35708@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 13.05.19 14:41, Noam Postavsky wrote: > Andreas Röhler writes: > >> as result of ‘thing-at-point-looking-at’ finally is delivered by >> ‘looking-at’, >> don't see any sense in calling ‘re-search-forward’ first. > The test added below fails if the re-search-forward in > thing-at-point-looking-at is commented out. Does that tell you what the > "sense" is? > Thought at something like below, which should pass the test: (defun ar-thing-at-point-looking-at (regexp)   "Return t if regexp matches at or before point, nil otherwise."   (save-excursion       (while (not (or (looking-at regexp)(bolp)))       (forward-char -1))       (looking-at regexp))) From debbugs-submit-bounces@debbugs.gnu.org Mon May 13 15:25:47 2019 Received: (at 35708) by debbugs.gnu.org; 13 May 2019 19:25:47 +0000 Received: from localhost ([127.0.0.1]:46277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQGa3-0002kG-3c for submit@debbugs.gnu.org; Mon, 13 May 2019 15:25:47 -0400 Received: from mail-it1-f174.google.com ([209.85.166.174]:52849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQGa2-0002k4-1C for 35708@debbugs.gnu.org; Mon, 13 May 2019 15:25:46 -0400 Received: by mail-it1-f174.google.com with SMTP id q65so993932itg.2 for <35708@debbugs.gnu.org>; Mon, 13 May 2019 12:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=AIEnrMaf5V0CoGzcHo1dovF1U663XIEkKF4R0rOikX8=; b=dTHGG/t8vJAMKeDznqjyJs0C92cDIp44hvVX2TKU+8Gh8/OhaTbXfGRl1uNZyddn0s n9ieuZz08qdB2Fyc5Q2ZaDfuOqMFXnx2WmW3qv15mnxtyg7k8p01POvk+eLqtdQnrjEN 5dvunZQstWdwNtFRvIF8VdbeowNe+r+ozSUDevHSdRkPrRvUgiqtS/oyfoBFOKeTgtwz 1HB/xr6dFNsxwF0g4PTXGy4DqcvvEY9sq1XG7PA+4mFNa9wGZHVZPK6+v3Rt+8rvfjan EGz6k1oKEq6F+QukHWtLmgyC3J7XtiTpRQG8bk8+h/j7paUUy6yOs6UKpuscrBaN9BdK yb8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=AIEnrMaf5V0CoGzcHo1dovF1U663XIEkKF4R0rOikX8=; b=I6wXIF3wB89UJ8UWTzknzCz00Zng3ZpR/89IuhzaWh09nR6mpSSwzJFWymPfGyu3uZ U48Z9XSFNx8Oel6aDCCO/n/wqGlv181EloErj3dV9IIxKEtH8yhKtWkZgzjClCRiMpxm Tp+qHOpi1gtWdhzc6k/EXJlP3UV/LNwelj4O1wiszL9At1w2cyrERlqTOzWwaukyZzU1 BfqtEft1bNVGnMUCMaJ7tHTN0IzN62/fC79mIQYounwehvDewtpNbXyLRzA/mv77FKWJ sdeeBWTMKeOt0avfc/750ylnxXs4xvc2e34FVO6RI1upq8BFbHnXHBEwCRIE8rWrWjBY Drvw== X-Gm-Message-State: APjAAAV5Kdtp03Ls+iNtP1OiY3txenMoQwiNO/pSEQyu52iPWN5JI0zS VSgJVItSts3KMG+wyjhqTtuSYBAg X-Google-Smtp-Source: APXvYqw4Wp2riUNNsBhNCROJXYFWrX1maPLkutca+pkoL3SFktDi4nY1JT9lvPeDkAFtR4lqhxsk6w== X-Received: by 2002:a24:51:: with SMTP id 78mr681476ita.20.1557775540272; Mon, 13 May 2019 12:25:40 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.gmail.com with ESMTPSA id e23sm5022707iob.43.2019.05.13.12.25.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 May 2019 12:25:39 -0700 (PDT) From: npostavs@gmail.com To: Andreas =?iso-8859-1?Q?R=F6hler?= Subject: Re: bug#35708: [27.0.50]: thingatpt.el, thing-at-point-looking-at redundant References: <8a73a0c9-5b38-4089-2780-28e62a1e162b@easy-emacs.de> <87ftpih6hs.fsf@gmail.com> <1bbebe25-9c4e-2563-701b-9bed85fcabb0@easy-emacs.de> Date: Mon, 13 May 2019 15:25:38 -0400 In-Reply-To: <1bbebe25-9c4e-2563-701b-9bed85fcabb0@easy-emacs.de> ("Andreas \=\?iso-8859-1\?Q\?R\=F6hler\=22's\?\= message of "Mon, 13 May 2019 20:31:54 +0200") Message-ID: <8536lixikt.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35708 Cc: 35708@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andreas R=F6hler writes: > Thought at something like below, which should pass the test: > > (defun ar-thing-at-point-looking-at (regexp) > =A0 "Return t if regexp matches at or before point, nil otherwise." > =A0 (save-excursion > =A0=A0=A0=A0=A0 (while (not (or (looking-at regexp)(bolp))) > =A0=A0=A0 =A0 (forward-char -1)) > =A0=A0=A0=A0=A0 (looking-at regexp))) I think it's an optimization to use re-search-backward instead of moving on character at a time and calling looking-at in lisp. From debbugs-submit-bounces@debbugs.gnu.org Tue May 14 06:01:39 2019 Received: (at 35708) by debbugs.gnu.org; 14 May 2019 10:01:39 +0000 Received: from localhost ([127.0.0.1]:47433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQUFe-0006kb-M1 for submit@debbugs.gnu.org; Tue, 14 May 2019 06:01:39 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:39951) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQUFa-0006ci-M7 for 35708@debbugs.gnu.org; Tue, 14 May 2019 06:01:37 -0400 Received: from [192.168.178.39] ([87.123.193.177]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MD9jV-1hZav30GWX-00980M; Tue, 14 May 2019 12:01:28 +0200 Subject: Re: bug#35708: [27.0.50]: thingatpt.el, thing-at-point-looking-at redundant To: npostavs@gmail.com References: <8a73a0c9-5b38-4089-2780-28e62a1e162b@easy-emacs.de> <87ftpih6hs.fsf@gmail.com> <1bbebe25-9c4e-2563-701b-9bed85fcabb0@easy-emacs.de> <8536lixikt.fsf@gmail.com> From: =?UTF-8?Q?Andreas_R=c3=b6hler?= Message-ID: <364b372e-7896-d92c-f848-0e7abc152a20@easy-emacs.de> Date: Tue, 14 May 2019 12:02:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <8536lixikt.fsf@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Provags-ID: V03:K1:9bJFgtzvuROGWBltEER06PITy5cwbx4A/wno1LattUR6GrmYmMV GuYPRVLjkYWCWSjD488ozd5OxFu7eqgcIT1JPxMywAdgFuiYT2j8GLbEIN1wPELF2OaSDkO tbvvxLKF06FsZRFDlpFCVX1syYdVIFCDhaKuYwLdhglpg6tTNzEUK3u0fu0DpEvnST9kPCF 5MaXFIov/X8EtvFmtwhaA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:OPIY+dwUX20=:eL0qaN81HNutQp0/A3M+KJ Ak18iH/PKitLEebAM8sexBuzydvm12hBXxdYxrAER5AFaYRFI5CrAuZ0JLX5BizPB6QR9+yJ7 MZstjstayqYnb5WevDy4TWksm96qkirH9WrKVLomtg8WcGIl2A/9c4t2aMKyJeuZO+q+/0Ayu NC9pvN98fTvEfUV8L7lK7tHCwVAmx3CUps6f33fBO7xVZJYOmhkRv8nQsLML97yNJxVUM5Pmf R2fYpKreiuUAMEYYAGiv/WlBJm8i2FOb2sAu82vxEXu7gTAMWuSgNPmKUmco/Jzr/fYJGYk9f O/Iuok8WR9mGJF8/XeVEo/xFflOl/YH6QP9JvlQvwutcCNXa++SlMROTTW3N0emSs2GLTfqnq DqABvealMj7d4b3QZ4XYBVKzfZo1Rhu31YQZ5rBJZjpLkiTF+RSyKCJXMkoFyw3p+HtWQwAPi 7Q2tnHmggHD/9p8IKzFh5unju8BzUgRCgYKwJy+FHjj8fHWgzJKwf84+zVKQl3nCRt3qiZPUZ 0IvLjzUhbjgjNhXihp2MyBEDrdEcVCSfoh5GfXAFuTwLGi4jSzSWEb+EAFvNPp9I4aS9r/ec0 6bnkt4FA40YJ8G3gx07P5hEj78dhXAx3fuwgolcyKSbi2GhMGw+QjYfWMENYw4QcwiUaXSEih 5GtPQwFsk2QfZImCHAtQJ63ENjl4IURlLqbFn1BSspyHW5TBj1odsl4dIcUItpkEZXgBQNwR2 dr2Cp4j1XWiA08PqQ/cmZF2Dluy6ccn6Dxt/PfSpPzfwbV7IHPxecFjP9f9tExJh3rSOhswND vedNPVK X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35708 Cc: 35708@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 13.05.19 21:25, npostavs@gmail.com wrote: > Andreas Röhler writes: > >> Thought at something like below, which should pass the test: >> >> (defun ar-thing-at-point-looking-at (regexp) >>   "Return t if regexp matches at or before point, nil otherwise." >>   (save-excursion >>       (while (not (or (looking-at regexp)(bolp))) >>       (forward-char -1)) >>       (looking-at regexp))) > I think it's an optimization to use re-search-backward instead of moving > on character at a time and calling looking-at in lisp. > > Hmm, current thing-at-point-looking-at might be slow with large buffers. The slightly modified test should reveal it: (ert-deftest thing-at-point-looking-at-2 ()   (with-temp-buffer     (insert "1abcd 222abcd")     (dotimes (_ 99999) (insert " asdf "))     (goto-char (point-min))     (let ((m2 (progn (search-forward "2abcd")                      (match-data))))       (goto-char (point-min))       (search-forward "2ab")       (should (thing-at-point-looking-at "2abcd"))       (should (equal (match-data) m2))))) But let me correct the alternative delivered, as it didn't match before point: (defun ar-regexp-atpt (regexp) "Return t if REGEXP matches at or before point, nil otherwise. Changes match-data"   (save-excursion     (if (looking-at regexp)     (while         (save-excursion           (and (not (bobp))            (progn (backward-char) (looking-at regexp)))))       (while (not (or (bobp) (backward-char) (looking-at regexp))))       (ar-regexp-atpt regexp))     (looking-at regexp))) From debbugs-submit-bounces@debbugs.gnu.org Tue May 14 06:48:32 2019 Received: (at submit) by debbugs.gnu.org; 14 May 2019 10:48:32 +0000 Received: from localhost ([127.0.0.1]:47512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQUz2-0000KS-2v for submit@debbugs.gnu.org; Tue, 14 May 2019 06:48:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQUz1-0000KG-23 for submit@debbugs.gnu.org; Tue, 14 May 2019 06:48:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:55981) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hQUyu-0004dy-Vn for submit@debbugs.gnu.org; Tue, 14 May 2019 06:48:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQUyt-0002Ss-Qs for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 06:48:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQUyq-0004Wz-V0 for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 06:48:23 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:37617) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQUyq-0004RA-L8 for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 06:48:20 -0400 Received: from [192.168.178.39] ([87.123.193.177]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MJmX3-1h72Hz0cFF-00KAwX; Tue, 14 May 2019 12:48:18 +0200 Subject: Re: bug#35708: [27.0.50]: thingatpt.el, thing-at-point-looking-at redundant From: =?UTF-8?Q?Andreas_R=c3=b6hler?= To: npostavs@gmail.com References: <8a73a0c9-5b38-4089-2780-28e62a1e162b@easy-emacs.de> <87ftpih6hs.fsf@gmail.com> <1bbebe25-9c4e-2563-701b-9bed85fcabb0@easy-emacs.de> <8536lixikt.fsf@gmail.com> <364b372e-7896-d92c-f848-0e7abc152a20@easy-emacs.de> Message-ID: <2d6578ec-8d7c-d3d0-7d1c-08eab22cae79@easy-emacs.de> Date: Tue, 14 May 2019 12:49:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <364b372e-7896-d92c-f848-0e7abc152a20@easy-emacs.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Provags-ID: V03:K1:1duAwDAw3WkykydU+VOOr0SBh+w0B7uQZ7U/0F0apfGwUssifIQ 5Zs9foUTyPU1t9GdhsOHhqtvbvUjqIhsNIu4oPAN03GW2RvIbL3fHLabhXfzssPJKk1xtiD Ow8NRnpNzYmssxjGrOfdWQGnH0+hsiuDMWaKDTGa63vUZu7WqUCQQsLLfqYznxIMeq13iXm GogTIzndgzMmQzgxltQEA== X-UI-Out-Filterresults: notjunk:1;V03:K0:gmZpekJkENU=:4wTUV3jupYK72pmlZPYisF 8vnePmaeq4Tk0UqiinEbZclO/PmL7lQvWhQsVKcxgJ24MU/oWQN38T03lIIuonHkCvMOGKXI1 +6tLRi92tBMg/NPinZN+hXXreGw7ePq8LLXsVsjuKwJxDbP292SeMW/ogLlYchT5jaUn7vjyg wqM2Pb26GZWGhHbf9OZTCw2Aaxmpi/O+kzQr9eB4QQshcZxuvA0yHj1DDLpilCMA9meXKfAj1 JL3s1sgat2mxacy6Ftwl1YJEfxRr4K/JJdRxYGhOuGYiRyy6LV8E6ZyzcNdml07BIzTCGNejV MnT8TowDjjrHKgdyBIPDBpQt0aS1l2VkSKEj6zhOjagSY705AkjNbxmW+qgS7e2B7gASeM1ym JQuseugJ3n0put8ZwoDOdgOZtRWTDtzQhqv/Up9ryPHGMUeWbGIJ7s7F2mp3q4rU/1RTrBf9a WlD0H3PtmrBkGh3KQWbrQFKcZaXjrY0e3gimzdEnzjIV/esLJ5XcUSW72TZnExVcuDxf0X02P CNCBI2qhAvhsG0gK1q2wSccinQYv4oorz10eR0yzbawWyM3qJapefnqeGqUuLUJEMlW4qlg2g jUAOAxBHrROqJxaa4VyOUlhhoko7T/UZtcCenfC/qfxC4Jawz1zhDahb3w4moo7l4rVKKFXdN qW8l/4KaXlB5DxiAn+t8IrwGI2FSf82qWzCKsq9lmYup/7/z9a1bnk5pildgcYKOioXmYe3sT PBKEQRVsfOlVuJKimmfY2ttz5khaR/GIIXBDJ6JA2oDpiJoDkf4zB79PJyQDOOKfprCEnw9b+ QJHpFO9 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.134 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 14.05.19 12:02, Andreas Röhler wrote: > > On 13.05.19 21:25, npostavs@gmail.com wrote: >> Andreas Röhler writes: >> >>> Thought at something like below, which should pass the test: >>> >>> (defun ar-thing-at-point-looking-at (regexp) >>>    "Return t if regexp matches at or before point, nil otherwise." >>>    (save-excursion >>>        (while (not (or (looking-at regexp)(bolp))) >>>        (forward-char -1)) >>>        (looking-at regexp))) >> I think it's an optimization to use re-search-backward instead of moving >> on character at a time and calling looking-at in lisp. >> >> > > Hmm, current thing-at-point-looking-at might be slow with large > buffers. The slightly modified test should reveal it: > > (ert-deftest thing-at-point-looking-at-2 () >   (with-temp-buffer >     (insert "1abcd 222abcd") >     (dotimes (_ 99999) (insert " asdf ")) >     (goto-char (point-min)) >     (let ((m2 (progn (search-forward "2abcd") >                      (match-data)))) >       (goto-char (point-min)) >       (search-forward "2ab") >       (should (thing-at-point-looking-at "2abcd")) >       (should (equal (match-data) m2))))) > > But let me correct the alternative delivered, as it didn't match > before point: > > (defun ar-regexp-atpt (regexp) > > "Return t if REGEXP matches at or before point, nil otherwise. > > Changes match-data" >   (save-excursion >     (if (looking-at regexp) >     (while >         (save-excursion >           (and (not (bobp)) >            (progn (backward-char) (looking-at regexp))))) >       (while (not (or (bobp) (backward-char) (looking-at regexp)))) >       (ar-regexp-atpt regexp)) >     (looking-at regexp))) > > > > Another fix, as a bug showed up when testing (ar-regexp-atpt "[a-z]+"): (defun ar-regexp-atpt (regexp)   "Return t if REGEXP matches at or before point, nil otherwise. Changes match-data"   (save-excursion     (if (looking-at regexp)     (while         (and (not (bobp))          (or (progn (backward-char) (looking-at regexp))              (forward-char 1))))       (while (not (or (bobp) (backward-char) (looking-at regexp))))       (ar-regexp-atpt regexp))     (looking-at regexp))) From debbugs-submit-bounces@debbugs.gnu.org Tue May 14 10:35:10 2019 Received: (at 35708) by debbugs.gnu.org; 14 May 2019 14:35:10 +0000 Received: from localhost ([127.0.0.1]:49575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQYWK-0000Gj-W5 for submit@debbugs.gnu.org; Tue, 14 May 2019 10:35:10 -0400 Received: from mail-it1-f181.google.com ([209.85.166.181]:36827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQYWG-0000Fm-2E for 35708@debbugs.gnu.org; Tue, 14 May 2019 10:35:07 -0400 Received: by mail-it1-f181.google.com with SMTP id e184so5051899ite.1 for <35708@debbugs.gnu.org>; Tue, 14 May 2019 07:35:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=oPM3PxnR7pCPltbaZwCfKCiDv/YsJCFG6SKcYZ6lXVs=; b=qRgqBLZJVBwQrANU5GxbEhCNjk8RX6OzF5FlQdlTB98XKL0Wb3rZcaf6RMVqadJEPE QN48omrUMKHfJ+XRU2EZvNsg24U20d+sFYzfBkdPTeEb/uUpjzOfAiGiBD3CJC0SWh6w 0npCqvP8GW5yJhkc1nBCJOJ70VxyJ5uV8ISMfNCV2MlPrbgHKw4brvNkFez2PfPFJ34q 8l8RxlpY6ygAWIddRKueCh/lGN6PpUr8UIKBAePVjetkaDy+vZE/2Xv0l2pbVDKYQ3bl VkEGFYh3iBg84mrU5hVxl57NPhsSWVacRAg2eRI1euVuh7HmpSj5AZg31foEFiOzCJO2 b2Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=oPM3PxnR7pCPltbaZwCfKCiDv/YsJCFG6SKcYZ6lXVs=; b=hsrVOZa5xsHECMHth92fkASG3WzVEWYeXTM4eberVnFbb6mecdNokyXQcWbuJlseWk xzUipN4gNmIQdgBdBXVzVTJ4hWmQi84gK7xSrogd72GJYUv9tHHvYGvtIDWysGnQT/pp H2KRLDmW+EBPoQ+y6ZZUkLf7MpuZ6EA/UIlwVjFWrAY3vgpBJCYQYLA12WlVTta3KJCg O9S4vP6vvDnF54MReuKvrA1UiQN+aSvduroK6ugcrQyzhc9QyqfxjykyzNbLAx+IJvh0 S2iA6o3hJdA797bRKdjWjMbCGFhMkMBi7/xHW730iG2G6WgGqNVQW1SQuX5qR+2Xqcgg stAQ== X-Gm-Message-State: APjAAAU4IJUsyGJVdQbzoTk9JS8QfdSn762RjNHAhT7/xZ2iICyL9PYi XDCC4yqKyL+ERtBgbeU/wboKE9OL X-Google-Smtp-Source: APXvYqy1B0fL558iP8WiYuft9JzTtEV2Hya4+Kx0yaz3V4vuLG1Z1VDQXH/h58CZQ2VUDQmPUJ+/IQ== X-Received: by 2002:a24:678e:: with SMTP id u136mr1278311itc.75.1557844498071; Tue, 14 May 2019 07:34:58 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.gmail.com with ESMTPSA id x77sm1245873ita.1.2019.05.14.07.34.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 May 2019 07:34:56 -0700 (PDT) From: npostavs@gmail.com To: Andreas =?iso-8859-1?Q?R=F6hler?= Subject: Re: bug#35708: [27.0.50]: thingatpt.el, thing-at-point-looking-at redundant References: <8a73a0c9-5b38-4089-2780-28e62a1e162b@easy-emacs.de> <87ftpih6hs.fsf@gmail.com> <1bbebe25-9c4e-2563-701b-9bed85fcabb0@easy-emacs.de> <8536lixikt.fsf@gmail.com> <364b372e-7896-d92c-f848-0e7abc152a20@easy-emacs.de> <2d6578ec-8d7c-d3d0-7d1c-08eab22cae79@easy-emacs.de> Date: Tue, 14 May 2019 10:34:55 -0400 In-Reply-To: <2d6578ec-8d7c-d3d0-7d1c-08eab22cae79@easy-emacs.de> ("Andreas \=\?iso-8859-1\?Q\?R\=F6hler\=22's\?\= message of "Tue, 14 May 2019 12:49:07 +0200") Message-ID: <85tvdxw1dc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35708 Cc: 35708@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andreas R=C3=B6hler writes: >> Hmm, current thing-at-point-looking-at might be slow with large >> buffers. The slightly modified test should reveal it: >> >> (ert-deftest thing-at-point-looking-at-2 () >> =C2=A0 (with-temp-buffer >> =C2=A0=C2=A0=C2=A0 (insert "1abcd 222abcd") >> =C2=A0=C2=A0=C2=A0 (dotimes (_ 99999) (insert " asdf ")) >> =C2=A0=C2=A0=C2=A0 (goto-char (point-min)) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (search-forward "2ab") >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (should (thing-at-point-looking-at "2abcd= ")) Yes, in this case, since the loop over looking-at only needs to iterate twice, so it will be faster. But what about when there is no match? E.g., (with-temp-buffer (dotimes (_ 99999) (insert " asdf ")) (goto-char (point-max)) (list :ar-regexp-atpt (benchmark-run (ar-regexp-atpt "foo")) :thing-at-point-looking-at (benchmark-run (thing-at-point-looking-a= t "foo")))) > Another fix, as a bug showed up when testing (ar-regexp-atpt "[a-z]+"): > > (defun ar-regexp-atpt (regexp) > =C2=A0 "Return t if REGEXP matches at or before point, nil otherwise. > > Changes match-data" > =C2=A0 (save-excursion > =C2=A0=C2=A0=C2=A0 (if (looking-at regexp) > =C2=A0=C2=A0=C2=A0 (while > =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 (and (not (bobp)) > =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0(or (progn (backward-char) (l= ooking-at regexp)) > =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 (forward-c= har 1)))) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (while (not (or (bobp) (backward-char) (lo= oking-at regexp)))) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (ar-regexp-atpt regexp)) What's this recursive call for? It triggers (error "Lisp nesting exceeds =E2=80=98max-lisp-eval-depth=E2=80=99") in the benchmark above. > =C2=A0=C2=A0=C2=A0 (looking-at regexp))) From debbugs-submit-bounces@debbugs.gnu.org Wed May 15 02:59:29 2019 Received: (at 35708) by debbugs.gnu.org; 15 May 2019 06:59:29 +0000 Received: from localhost ([127.0.0.1]:50826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQnsu-0007k9-UE for submit@debbugs.gnu.org; Wed, 15 May 2019 02:59:29 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:54847) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQnst-0007jx-Dq for 35708@debbugs.gnu.org; Wed, 15 May 2019 02:59:27 -0400 Received: from [192.168.178.31] ([88.130.49.114]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MploR-1guRDZ1tWf-00qDvx; Wed, 15 May 2019 08:59:20 +0200 Subject: Re: bug#35708: [27.0.50]: thingatpt.el, thing-at-point-looking-at redundant To: npostavs@gmail.com References: <8a73a0c9-5b38-4089-2780-28e62a1e162b@easy-emacs.de> <87ftpih6hs.fsf@gmail.com> <1bbebe25-9c4e-2563-701b-9bed85fcabb0@easy-emacs.de> <8536lixikt.fsf@gmail.com> <364b372e-7896-d92c-f848-0e7abc152a20@easy-emacs.de> <2d6578ec-8d7c-d3d0-7d1c-08eab22cae79@easy-emacs.de> <85tvdxw1dc.fsf@gmail.com> From: =?UTF-8?Q?Andreas_R=c3=b6hler?= Message-ID: <6bf2ad95-5a41-cbf1-c5ea-07dc06d0f9a1@easy-emacs.de> Date: Wed, 15 May 2019 08:59:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <85tvdxw1dc.fsf@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Provags-ID: V03:K1:N0DtEay4rmAUGQoejyAf9o5C+KMm6sxa0OMBQl5rzkveIR8SznN mM8if+z6lqGyFQwOMro9bE5G4UcgpSiDPeaFlFQa8Fb4eqDZkNTnK7ckZ/TSbIlp/ko2OGV a6CKSjc5cdhDnuLBVgqIkNdR7ln9Bkn1fN0YPeUaiAyJbQol56oj7DRSC02tQMlAGLMavXa iPuWePX6VkIh4x20ejh2w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:UAnWTBdQDww=:b669cvt9Ilm08smr5qjaoM 4AcFaMlh1C/aQh5twI9MuWUuYXrX7FvY7vytBFPtrg3O8L3CogLFpq32fXSyCUKYPryDOkNGz CH6t4uk3vaJ959zsbdbaMibt7fgVVbzc4bp0g50Vs333CdLDLaTH3PIqpChNT203w9Y66MdqC BdUDiSF+VHrGXyY6FKsPlTSUbtLktS3oFcHLlHx4qBUVuIX2gzrPHuEQhCtiCgV0INlo0uFKw 6Nauaz2TTBPNXtXx+WM+8ZkYEwOPm+WH42OGVjxABc3evnPKjxLo9RpUkCOMF7XMirN+m1ZcM mcq7e0uiu687ANLa65ihTtR9bPX6dSErev7Dh2OW4lFeld9cdF1wsb5rpCWpJ0eJucEUYuLiW TdwGgNmlVanTk+5l9WJN8Khut083G3aWXeJrbzo2v9+kXtUQFy+yWohRwcw+XmJilYq+wgX2q TAWAlUsYn4XbZEHGE2kGcQzosDfg0uvzBcbT6eBNDZmwCak17lZZxZYqaZrf8+UF9lEog4dhc NJtKQ5BRRCYGxRz1rHPBuzY+Gpv/5B1HtJFxmC9Ifb1w0xjMSE7Jp5QwYJDKROocllc8kA0Xr 1JoFcJLWnYbUJFsAVKQ7DW7yQ7vjiH2dbS3rKqyNw1UccWXTJaeMnITputLK5dTrF9cU1CGe6 ulsRN+35s9znf03dWS8fGCGCEHgeWYs6oga05SRrZnIvczzClmtiRoD/dlN3Uepn3Trkwkx65 FS4McMTCa8JvOrxDEu1HmgCqZxNuVuSavCYtbx9hYCAJzKTFynuFQiYf9L3Rrvk0FbUa/MjBj LXvWS9B X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35708 Cc: 35708@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am 14.05.19 um 16:34 schrieb npostavs@gmail.com: > Andreas Röhler writes: > >>> Hmm, current thing-at-point-looking-at might be slow with large >>> buffers. The slightly modified test should reveal it: >>> >>> (ert-deftest thing-at-point-looking-at-2 () >>>   (with-temp-buffer >>>     (insert "1abcd 222abcd") >>>     (dotimes (_ 99999) (insert " asdf ")) >>>     (goto-char (point-min)) >>>       (search-forward "2ab") >>>       (should (thing-at-point-looking-at "2abcd")) > Yes, in this case, since the loop over looking-at only needs to iterate > twice, so it will be faster. But what about when there is no match? > E.g., > > (with-temp-buffer > (dotimes (_ 99999) (insert " asdf ")) > (goto-char (point-max)) > (list :ar-regexp-atpt (benchmark-run (ar-regexp-atpt "foo")) > :thing-at-point-looking-at (benchmark-run (thing-at-point-looking-at "foo")))) > >> Another fix, as a bug showed up when testing (ar-regexp-atpt "[a-z]+"): >> >> (defun ar-regexp-atpt (regexp) >>   "Return t if REGEXP matches at or before point, nil otherwise. >> >> Changes match-data" >>   (save-excursion >>     (if (looking-at regexp) >>     (while >>         (and (not (bobp)) >>          (or (progn (backward-char) (looking-at regexp)) >>              (forward-char 1)))) >>       (while (not (or (bobp) (backward-char) (looking-at regexp)))) >>       (ar-regexp-atpt regexp)) > What's this recursive call for? It triggers (error "Lisp nesting > exceeds ‘max-lisp-eval-depth’") in the benchmark above. > >>     (looking-at regexp))) The recursive call needed a guard:     (unless (bobp) It is called after function went backward while not looking-at matches, Now the result for the 99999 is (:ar-regexp-atpt (0.774574453 0 0.0) :thing-at-point-looking-at (0.000798669 0 0.0)) The fixed form: (defun ar-regexp-atpt (regexp)   "Return t if REGEXP matches at or before point, nil otherwise. Changes match-data"   (save-excursion     (if (looking-at regexp)     (while         (and (not (bobp))          (or (progn (backward-char) (looking-at regexp))              (forward-char 1))))       (while (not (or (bobp) (backward-char) (looking-at regexp))))       (unless (bobp) (ar-regexp-atpt regexp)))     (looking-at regexp))) From debbugs-submit-bounces@debbugs.gnu.org Wed May 15 06:11:16 2019 Received: (at 35708) by debbugs.gnu.org; 15 May 2019 10:11:16 +0000 Received: from localhost ([127.0.0.1]:51079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQqsV-000643-KQ for submit@debbugs.gnu.org; Wed, 15 May 2019 06:11:15 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:42897) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQqsT-00063q-1f for 35708@debbugs.gnu.org; Wed, 15 May 2019 06:11:14 -0400 Received: from [192.168.178.31] ([88.130.49.114]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MI5YN-1hVVQj1GGV-00FAu7; Wed, 15 May 2019 12:11:06 +0200 Subject: Re: bug#35708: [27.0.50]: thingatpt.el, thing-at-point-looking-at redundant From: =?UTF-8?Q?Andreas_R=c3=b6hler?= To: npostavs@gmail.com References: <8a73a0c9-5b38-4089-2780-28e62a1e162b@easy-emacs.de> <87ftpih6hs.fsf@gmail.com> <1bbebe25-9c4e-2563-701b-9bed85fcabb0@easy-emacs.de> <8536lixikt.fsf@gmail.com> <364b372e-7896-d92c-f848-0e7abc152a20@easy-emacs.de> <2d6578ec-8d7c-d3d0-7d1c-08eab22cae79@easy-emacs.de> <85tvdxw1dc.fsf@gmail.com> <6bf2ad95-5a41-cbf1-c5ea-07dc06d0f9a1@easy-emacs.de> Message-ID: Date: Wed, 15 May 2019 12:11:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <6bf2ad95-5a41-cbf1-c5ea-07dc06d0f9a1@easy-emacs.de> Content-Type: multipart/alternative; boundary="------------96E31B7BEC272D5D29D7970D" Content-Language: en-US X-Provags-ID: V03:K1:Zw+HlcF8W4KgLlFl5ihiiofNgAnINGlPwT06LOhFGZhnTUnuC++ +MpgoXD0r+jX5ULIERfvr1gWHdubwk1Xbbx7gxcxyS9M/zExtBrzne9CJ8hHHOrdpd1eVzw bL3B7Ba6vdwUiw+Y93sd+g/3NnZUTRT4ZuW9vRWvQAdFNMn8hKJ9lgo2ZQmv7Po/LsqQ9Dt ETnW+LvWHzEo9WZo/8fjA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:KGJgb6CvSlA=:nBQUuwX9XUcb7wZ2JhV3ZC VVqTf8+bqBcJShTTgPpgmEtUefXZgPOPFQ2Q59i09fcRc3fa8Yda1Enan6wS8d1skKtCHoHoi kW1guz/wjibIJHNUpYh/O3M0d01By0zfhQhSgzOINYnn0pAqOk1YfPytYIG0N5kTawDT7Q71u s9pvQplEaouNBrYyUXadOlqP5TBI1Fb4PxT4+WE6Jk+u7UHWlpomEtRM3WpQ0jfCzqwNp9Z1v jLA4dbUsX+zeakMD7LKLvaibrl+2dSE2qYU4nHeQt2WjRQUVSoVDGXku/bgPr4GRWJYKX4VN/ zpBQycSmj/2HBbJTaGovpdmV/fLUwZJn1N+QXxNerIAJf7GOzV65OjhHi4DbX4m+VFlQS/RZr 0CwXITEoKww30972pdwP8gBX8kO+wUcKrjT7YmxS1jMkTV32hTzokJTtw9ShWVV2ZroAiSWMg dt7yYD6Nu+GvZEcyG1JFvDtEhlwQYHRi9/7MRUvSGnJuOhoYQqh4efZRbEK92rSWyENdlnUHZ 58+qa4VEhiku/iokGW8VE3hBd3R6GPe+Dk2fPZmy88xVEfqjHtEFf3kwsGO0MhCZfswefTuvc J1TXNyK+7nUkMiibMP2PPO/WjQItgGxxsVGwDKy6G7kYRqyQ630P5hrKlF5m0vF48zllbtbHp ar1K1/yFl8eHwSHW+AzU+ULVacqFUK1i7yyahRk1fzswrquLjksZQ/I3ohnklOUjHB5Gx9mpa QGmCQ8OA1JxrJ1CFssO+8yDrvk3oernrmwPvnsJW9OnUCvyGx+cikD5oC9JrD4lfdLXumDdHw wENMnoJ X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35708 Cc: 35708@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------96E31B7BEC272D5D29D7970D Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Am 15.05.19 um 08:59 schrieb Andreas Röhler: > > Am 14.05.19 um 16:34 schrieb npostavs@gmail.com: >> Andreas Röhler writes: >> >>>> Hmm, current thing-at-point-looking-at might be slow with large >>>> buffers. The slightly modified test should reveal it: >>>> >>>> (ert-deftest thing-at-point-looking-at-2 () >>>>    (with-temp-buffer >>>>      (insert "1abcd 222abcd") >>>>      (dotimes (_ 99999) (insert " asdf ")) >>>>      (goto-char (point-min)) >>>>        (search-forward "2ab") >>>>        (should (thing-at-point-looking-at "2abcd")) >> Yes, in this case, since the loop over looking-at only needs to iterate >> twice, so it will be faster.  But what about when there is no match? >> E.g., >> >> (with-temp-buffer >>    (dotimes (_ 99999) (insert " asdf ")) >>    (goto-char (point-max)) >>    (list :ar-regexp-atpt (benchmark-run (ar-regexp-atpt "foo")) >>          :thing-at-point-looking-at (benchmark-run >> (thing-at-point-looking-at "foo")))) >> >>> Another fix, as a bug showed up when testing (ar-regexp-atpt "[a-z]+"): >>> >>> (defun ar-regexp-atpt (regexp) >>>    "Return t if REGEXP matches at or before point, nil otherwise. >>> >>> Changes match-data" >>>    (save-excursion >>>      (if (looking-at regexp) >>>      (while >>>          (and (not (bobp)) >>>           (or (progn (backward-char) (looking-at regexp)) >>>               (forward-char 1)))) >>>        (while (not (or (bobp) (backward-char) (looking-at regexp)))) >>>        (ar-regexp-atpt regexp)) >> What's this recursive call for?  It triggers (error "Lisp nesting >> exceeds ‘max-lisp-eval-depth’") in the benchmark above. >> >>>      (looking-at regexp))) > > > The recursive call needed a guard:     (unless (bobp) > > It is called after function went backward while not looking-at matches, > > Now the result for the 99999 is > > (:ar-regexp-atpt (0.774574453 0 0.0) :thing-at-point-looking-at > (0.000798669 0 0.0)) > > > The fixed form: > > Make sure match pos includes cursor pos: (defun ar-regexp-atpt (regexp)   "Return t if REGEXP matches at or before point, nil otherwise. Changes match-data"   (save-excursion     (let ((orig (point)))       (if (looking-at regexp)       (while           (and (not (bobp))            (or (progn (backward-char) (looking-at regexp))                (forward-char 1))))     (while (not (or (bobp) (backward-char) (looking-at regexp))))     (unless (bobp) (ar-regexp-atpt regexp)))       (and        (looking-at regexp)        (<= (match-beginning 0) orig)        (>= (match-end 0) orig))))) --------------96E31B7BEC272D5D29D7970D Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit
Am 15.05.19 um 08:59 schrieb Andreas Röhler:

Am 14.05.19 um 16:34 schrieb npostavs@gmail.com:
Andreas Röhler <andreas.roehler@easy-emacs.de> writes:

Hmm, current thing-at-point-looking-at might be slow with large
buffers. The slightly modified test should reveal it:

(ert-deftest thing-at-point-looking-at-2 ()
   (with-temp-buffer
     (insert "1abcd 222abcd")
     (dotimes (_ 99999) (insert " asdf "))
     (goto-char (point-min))
       (search-forward "2ab")
       (should (thing-at-point-looking-at "2abcd"))
Yes, in this case, since the loop over looking-at only needs to iterate
twice, so it will be faster.  But what about when there is no match?
E.g.,

(with-temp-buffer
   (dotimes (_ 99999) (insert " asdf "))
   (goto-char (point-max))
   (list :ar-regexp-atpt (benchmark-run (ar-regexp-atpt "foo"))
         :thing-at-point-looking-at (benchmark-run (thing-at-point-looking-at "foo"))))

Another fix, as a bug showed up when testing (ar-regexp-atpt "[a-z]+"):

(defun ar-regexp-atpt (regexp)
   "Return t if REGEXP matches at or before point, nil otherwise.

Changes match-data"
   (save-excursion
     (if (looking-at regexp)
     (while
         (and (not (bobp))
          (or (progn (backward-char) (looking-at regexp))
              (forward-char 1))))
       (while (not (or (bobp) (backward-char) (looking-at regexp))))
       (ar-regexp-atpt regexp))
What's this recursive call for?  It triggers (error "Lisp nesting
exceeds ‘max-lisp-eval-depth’") in the benchmark above.

     (looking-at regexp)))


The recursive call needed a guard:     (unless (bobp)

It is called after function went backward while not looking-at matches,

Now the result for the 99999 is

(:ar-regexp-atpt (0.774574453 0 0.0) :thing-at-point-looking-at (0.000798669 0 0.0))


The fixed form:


Make sure match pos includes cursor pos:


(defun ar-regexp-atpt (regexp)

  "Return t if REGEXP matches at or before point, nil otherwise.
Changes match-data"
  (save-excursion
    (let ((orig (point)))
      (if (looking-at regexp)
      (while
          (and (not (bobp))
           (or (progn (backward-char) (looking-at regexp))
               (forward-char 1))))
    (while (not (or (bobp) (backward-char) (looking-at regexp))))
    (unless (bobp) (ar-regexp-atpt regexp)))
      (and
       (looking-at regexp)
       (<= (match-beginning 0) orig)
       (>= (match-end 0) orig)))))


--------------96E31B7BEC272D5D29D7970D-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 20 13:17:45 2019 Received: (at 35708) by debbugs.gnu.org; 20 May 2019 17:17:45 +0000 Received: from localhost ([127.0.0.1]:37639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSluy-00049N-S1 for submit@debbugs.gnu.org; Mon, 20 May 2019 13:17:45 -0400 Received: from mail-io1-f42.google.com ([209.85.166.42]:46916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSluw-000493-7u; Mon, 20 May 2019 13:17:42 -0400 Received: by mail-io1-f42.google.com with SMTP id q21so11603466iog.13; Mon, 20 May 2019 10:17:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=N0R3ag7R80+IKAKZ6e2LbHLMeEamNE77gp5USDTkTWk=; b=SExfgtkkC/KnrVsbXLcuMA7yZHhUYUyDuYoSHef5r+oCu9PigFV28TJdt356vwilLn OXl7FmvcOceXXsXNQrvT/fGzNWFUk1O0sWMKddaJlCv2Sop/AAeHhidpzLiIFJppsGLB yoSSaWmCMB69gx4F2KWvPfyABUoIu577EXwN61Y6IlnMtPfjSnzLOqZB6EWd4vIDz3PW VSllrmX6W9UiblkrRc1JfkWt3MYP6/mdvXVX3qJ9bmR7YycTcxyWeIeNa+4aHK4ACMTe DqEb+xyt9N3sgs5PnBICnqk0xBvLCfyaOGYNdlPYz7e4eVQ6oQ8WUdupQCcbNBdsxIv+ L9Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=N0R3ag7R80+IKAKZ6e2LbHLMeEamNE77gp5USDTkTWk=; b=AiIyeg/hrkENnsCDsVia803eRaaiScC9JulU5BuxEnrzh7/qTs+Iiz93Xq9iwhc1Kc 33t2tadqf+43NRleH7E1DxsjelCJqKdcx6sBtxfgEQTL8ifJ9h0ZwF2VKiuWPQxfDhnA ZaR0NFKYRsFKwIMujOt2/hqzWNNbZM3XWumLqMVp0m7+/hEq8SUk0u7Bt7gbDsfwW/Gd vl7v5a4jF9d/R67LCvLed2Ys6nZrs/k6KUYAYYqed1Euh0OQL78YGhNwum8q2i/ORyMj x3gMUExjS6bgN/z7pDDxuLQ/oc1Ahl12kSHA1Jzq6nm+CYcP/HleyYxCkEeaDqLhpKLt 6Y9w== X-Gm-Message-State: APjAAAVAM2kIO6WvzYVP1OtXbcSMNKxJmAXqRLdgTYU2xXq9nBS898hp XQzbhvDSAb03YorZqncpJQWwnxDd X-Google-Smtp-Source: APXvYqzuLKsEbx6aSNPBwphyN/WTJfffcQPOle1CbaXqwSk0L3rmULCUZMudF+IWOBadtd3s6JSBNw== X-Received: by 2002:a5d:8b0d:: with SMTP id k13mr12774237ion.134.1558372656155; Mon, 20 May 2019 10:17:36 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id f1sm5757945iop.53.2019.05.20.10.17.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 May 2019 10:17:35 -0700 (PDT) From: Noam Postavsky To: Andreas =?utf-8?Q?R=C3=B6hler?= Subject: Re: bug#35708: [27.0.50]: thingatpt.el, thing-at-point-looking-at redundant References: <8a73a0c9-5b38-4089-2780-28e62a1e162b@easy-emacs.de> <87ftpih6hs.fsf@gmail.com> <1bbebe25-9c4e-2563-701b-9bed85fcabb0@easy-emacs.de> <8536lixikt.fsf@gmail.com> <364b372e-7896-d92c-f848-0e7abc152a20@easy-emacs.de> <2d6578ec-8d7c-d3d0-7d1c-08eab22cae79@easy-emacs.de> <85tvdxw1dc.fsf@gmail.com> <6bf2ad95-5a41-cbf1-c5ea-07dc06d0f9a1@easy-emacs.de> Date: Mon, 20 May 2019 13:17:33 -0400 In-Reply-To: <6bf2ad95-5a41-cbf1-c5ea-07dc06d0f9a1@easy-emacs.de> ("Andreas \=\?utf-8\?Q\?R\=C3\=B6hler\=22's\?\= message of "Wed, 15 May 2019 08:59:19 +0200") Message-ID: <878sv1avv6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35708 Cc: 35708@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 35708 notabug wontfix close 35708 quit Andreas R=C3=B6hler writes: > Now the result for the 99999 is > > (:ar-regexp-atpt (0.774574453 0 0.0) > :thing-at-point-looking-at (0.000798669 0 0.0)) I trust that explains well enough why the current implementation is used. From unknown Fri Jun 13 10:25:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 18 Jun 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator