GNU bug report logs - #357
ffap-string-at-point-mode-alist should include multibyte

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: bug#357: marked as done (ffap-string-at-point-mode-alist should 
 include multibyte)

[Message part 1 (text/plain, inline)]

Your message dated Tue, 10 Jun 2008 15:35:44 -0400
with message-id <jwv8wxdqe3y.fsf-monnier+emacsbugreports <at> gnu.org>
and subject line Re: ffap-string-at-point-mode-alist should include multibyte 
has caused the Emacs bug report #357,
regarding ffap-string-at-point-mode-alist should include multibyte
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don <at> donarmstrong.com
immediately.)


-- 
357: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=357
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: jidanni <at> jidanni.org
To: emacs-w3m <at> namazu.org
Cc: bug-gnu-emacs <at> gnu.org
Subject: ffap-string-at-point-mode-alist should include multibyte
Date: Wed, 04 Jun 2008 08:47:10 +0800

>>>>> "KY" == Katsumi Yamaoka <yamaoka <at> jpl.org> writes:

>>>>> In [emacs-w3m : No.10204] jidanni <at> jidanni.org wrote:
>> U runs the command w3m-goto-url
>> but when the cursor is upon the link
>> http://www.coolloud.org.tw/tag/移民工/feed
>> it only prompts with
>> http://www.coolloud.org.tw/tag/
>> apparently unable to deal with the non-ASCII.

KY> Besause emacs-w3m uses the `ffap-url-at-point' function, what
KY> should be improved is the url element of the variable
KY> `ffap-string-at-point-mode-alist' defined in ffap.el.  For
KY> instance:

KY> (eval-after-load "ffap"
KY>   '(setcar (cdr (assq 'url ffap-string-at-point-mode-alist))
KY> 	   "--:=&?$+@-Z_[:lower:][:multibyte:]~#,%;*"))

KY> It defaults to "--:=&?$+@-Z_[:lower:]~#,%;*" which does not
KY> match non-ASCII characters.

OK, your workaround works.  I'm CCing this to bug-gnu-emacs.

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: 357-done <at> debbugs.gnu.org
Subject: Re: ffap-string-at-point-mode-alist should include multibyte 
Date: Tue, 10 Jun 2008 15:35:44 -0400

I've installed the following patch instead, which seems to work as well.


        Stefan


=== modified file 'lisp/ffap.el'
--- lisp/ffap.el	2008-06-06 06:58:42 +0000
+++ lisp/ffap.el	2008-06-10 19:32:25 +0000
@@ -978,11 +978,11 @@
     ;; Slightly controversial decisions:
     ;; * strip trailing "@" and ":"
     ;; * no commas (good for latex)
-    (file "--:\\\\$+<>@-Z_[:lower:]~*?" "<@" "@>;.,!:")
+    (file "--:\\\\$+<>@-Z_[:alpha:]~*?" "<@" "@>;.,!:")
     ;; An url, or maybe a email/news message-id:
-    (url "--:=&?$+@-Z_[:lower:]~#,%;*" "^[:alnum:]" ":;.,!?")
+    (url "--:=&?$+@-Z_[:alpha:]~#,%;*" "^[:alnum:]" ":;.,!?")
     ;; Find a string that does *not* contain a colon:
-    (nocolon "--9$+<>@-Z_[:lower:]~" "<@" "@>;.,!?")
+    (nocolon "--9$+<>@-Z_[:alpha:]~" "<@" "@>;.,!?")
     ;; A machine:
     (machine "-[:alnum:]." "" ".")
     ;; Mathematica paths: allow backquotes

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.