From unknown Sun Jun 22 17:13:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35695: 27.0.50; Faces diff-added and diff-removed look the same in a 256 color terminal Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 May 2019 05:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 35695@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.155763783110461 (code B ref -1); Sun, 12 May 2019 05:11:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 May 2019 05:10:31 +0000 Received: from localhost ([127.0.0.1]:41602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPgko-0002if-PZ for submit@debbugs.gnu.org; Sun, 12 May 2019 01:10:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPgkm-0002iP-Mt for submit@debbugs.gnu.org; Sun, 12 May 2019 01:10:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:37414) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hPgkh-000789-FH for submit@debbugs.gnu.org; Sun, 12 May 2019 01:10:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPgkf-0008B2-P5 for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 01:10:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hPge2-0000bQ-9K for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 01:03:31 -0400 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]:45429) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hPge1-0000UR-RP for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 01:03:30 -0400 Received: by mail-lf1-x144.google.com with SMTP id n22so6713678lfe.12 for ; Sat, 11 May 2019 22:03:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=c1qF43AsterVkbT3r1lkKIxoBq/d59NTRNfYgzHpf08=; b=uXdmKh9X5pFvORZrMOvNtj5Rg7QbeosilL29XzgMacgywH9I3VSK2hUftL+txiKO/c Pnd2gTPqAzO0ZW8MOJJvKhmtaL2mzQx4Hjc16i9ldAm4cihCEKLLpe5Hnw6WNOhZx+FA cDyinaAt8UPOeAfhZmk2pZX3HkGhnE+qztw7ImczI5QyCAfB0fNW44gP4GfyifBtihe2 Ahu+e4dg2j7XF0vyBpZDShTArKOwd7MUB4Yt3y53L703uZGev1oHQ18iBsVQ+BEGpIRF EaqWYpwty8brXhuMkkzpMCjz3XASujFnya85Ih+F36xnxDWmUJxwxQb+otFaluxxILWv yvxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=c1qF43AsterVkbT3r1lkKIxoBq/d59NTRNfYgzHpf08=; b=Ukuqi9Q3n3TP5w8z9EbUY4HPqISShQqwpgF2PfPqnBN8yNf8Cvm21ju3OiZyZ3NQ/+ yBupU6uXk/d9jYZqhPW6cejhMsPD48z2W60vFKe//IhNgiaj2JxdJLaYJqZUcq1IIJsQ tPYJMovtmSAmxf5rUbsRAmqizuLpb289iNM0ruZXPdoMz7PUeF73a8y1EPGeLxjpVX// JpeGA/8Z07RGmCssonnV1GZ4b3quCPQTkgnNkTxxz8OuqOYMtnm/ptL+OZzZjIyJR2Qa gkzs/uOs/LHYxn/ryb7ZAQYxnGqQVjBh1V3T5k+FoYXJ1JQgcFatwwHSkkRZb6r9JOSz je7w== X-Gm-Message-State: APjAAAXd+1Cpl1NeEfVlvXJBAJaSBIUyzOEqVyrrhNIc+d82Ia8Lvces WeIM5k4c96BQP76BJThMYgvhv9A3glCSwaW3A9DSAjPufrQ= X-Google-Smtp-Source: APXvYqxA3GIZOKKcdKTfS4OWpKkMV7+8PwXY21YFcUFW7MhEw8GtN1c33iX80KWNDL5PTOw6CjGe7aqFOkzZAv/V5GQ= X-Received: by 2002:a19:c394:: with SMTP id t142mr5520656lff.102.1557637406807; Sat, 11 May 2019 22:03:26 -0700 (PDT) MIME-Version: 1.0 From: Anders Lindgren Date: Sun, 12 May 2019 07:03:41 +0200 Message-ID: Content-Type: multipart/alternative; boundary="0000000000005259920588a9b8df" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::144 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --0000000000005259920588a9b8df Content-Type: text/plain; charset="UTF-8" Hi! When using Emacs in a terminal that supports 256 colors (such as the built-in terminal on macOS), the faces diff-added and diff-removed look the same. They are defined to have a background color of #eeffee and #ffeeee, respectively, in light background mode. When a diff is viewed in a terminal, they are both rendered using light grey background, so it's impossible to distinguish between them. In Emac 26, they were defined using #ddffdd and #ffdddd, respectively, which is rendered fine in the terminal (on both Emacs 26 and 27). One way to solve this is to add alternative color definitions using the "min-colors" requirement. Another is to go back to the old values. -- Anders Lindgren In GNU Emacs 27.0.50 (build 1, x86_64-apple-darwin16.7.0, NS appkit-1504.83 Version 10.12.6 (Build 16G29)) of 2019-05-01 built on mbp.lan Repository revision: 7dafbe3ab91e838803a84ab388bca03ff985e312 Repository branch: master System Description: Mac OS X 10.12.6 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. delete-backward-char: Text is read-only Quit Mark saved where search started Making completion list... Configured using: 'configure --with-gnutls=no' Configured features: NOTIFY KQUEUE ACL LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS THREADS PDUMPER GMP Important settings: value of $LC_CTYPE: UTF-8 value of $LANG: en_SE.UTF-8 locale-coding-system: utf-8-unix Major mode: Apropos Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils misearch multi-isearch help-mode cl-loaddefs cl-lib apropos smerge-mode vc-dispatcher vc-svn diff-mode easymenu easy-mmode term/xterm xterm elec-pair tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 56669 7188) (symbols 48 6625 1) (strings 32 17368 1666) (string-bytes 1 565596) (vectors 16 7835) (vector-slots 8 78808 10720) (floats 8 25 439) (intervals 56 860 4) (buffers 992 14)) --0000000000005259920588a9b8df Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi!

<= /div>
When using Emacs in a terminal that supports 256 colors (such as = the built-in terminal on macOS), the faces diff-added and diff-removed look= the same.

They are defined to have a background c= olor of #eeffee and #ffeeee, respectively, in light background mode. When a= diff is viewed in a terminal, they are both rendered using light grey back= ground, so it's impossible to distinguish between them.

<= /div>
In Emac 26, they were defined using #ddffdd and #ffdddd, respecti= vely, which is rendered fine in the terminal (on both Emacs 26 and 27).

One way to solve this is to add alternative color def= initions using the "min-colors" requirement. Another is to go bac= k to the old values.

=C2=A0 =C2=A0 =C2=A0-- Anders= Lindgren

In GNU Emacs 27.0.50 (build 1, x86_64-ap= ple-darwin16.7.0, NS appkit-1504.83 Version 10.12.6 (Build 16G29))
=C2=A0of 2019-05-01 built on mbp.lan
Repository revision: 7dafb= e3ab91e838803a84ab388bca03ff985e312
Repository branch: master
System Description:=C2=A0 Mac OS X 10.12.6

= Recent messages:
For information about GNU Emacs and the GNU syst= em, type C-h C-a.
delete-backward-char: Text is read-only
Quit
Mark saved where search started
Making completi= on list...

Configured using:
=C2=A0'= configure --with-gnutls=3Dno'

Configured featu= res:
NOTIFY KQUEUE ACL LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS THREAD= S PDUMPER
GMP

Important settings:
<= div>=C2=A0 value of $LC_CTYPE: UTF-8
=C2=A0 value of $LANG: en_SE= .UTF-8
=C2=A0 locale-coding-system: utf-8-unix

Major mode: Apropos

Minor modes in effect:<= /div>
=C2=A0 tooltip-mode: t
=C2=A0 global-eldoc-mode: t
=C2=A0 electric-indent-mode: t
=C2=A0 mouse-wheel-mode: t
=C2=A0 tool-bar-mode: t
=C2=A0 menu-bar-mode: t
=C2=A0 file-name-shadow-mode: t
=C2=A0 global-font-lock-mode: t=
=C2=A0 font-lock-mode: t
=C2=A0 auto-composition-mode:= t
=C2=A0 auto-encryption-mode: t
=C2=A0 auto-compressi= on-mode: t
=C2=A0 buffer-read-only: t
=C2=A0 line-numbe= r-mode: t
=C2=A0 transient-mark-mode: t

= Load-path shadows:
None found.

Features:=
(shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv=
bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc= 822 mml
mml-sec password-cache epa derived epg epg-config gnus-ut= il rmail
rmail-loaddefs text-property-search time-date mm-decode = mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailh= eader sendmail
rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail= -utils misearch
multi-isearch help-mode cl-loaddefs cl-lib apropo= s smerge-mode
vc-dispatcher vc-svn diff-mode easymenu easy-mmode = term/xterm xterm
elec-pair tooltip eldoc electric uniquify ediff-= hook vc-hooks
lisp-float-type mwheel term/ns-win ns-win ucs-norma= lize mule-util
term/common-win tool-bar dnd fontset image regexp-= opt fringe
tabulated-list replace newcomment text-mode elisp-mode= lisp-mode
prog-mode register page menu-bar rfn-eshadow isearch t= imer select
scroll-bar mouse jit-lock font-lock syntax facemenu f= ont-core
term/tty-colors frame cl-generic cham georgian utf-8-lan= g misc-lang
vietnamese tibetan thai tai-viet lao korean japanese = eucjp-ms cp51932
hebrew greek romanian slovak czech european ethi= opic indian cyrillic
chinese composite charscript charprop case-t= able epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer= cl-preloaded nadvice loaddefs
button faces cus-face macroexp fil= es text-properties overlay sha1 md5
base64 format env code-pages = mule custom widget hashtable-print-readable
backquote threads kqu= eue cocoa ns multi-tty make-network-process emacs)

Memory information:
((conses 16 56669 7188)
=C2=A0(sym= bols 48 6625 1)
=C2=A0(strings 32 17368 1666)
=C2=A0(st= ring-bytes 1 565596)
=C2=A0(vectors 16 7835)
=C2=A0(vec= tor-slots 8 78808 10720)
=C2=A0(floats 8 25 439)
=C2=A0= (intervals 56 860 4)
=C2=A0(buffers 992 14))

=
--0000000000005259920588a9b8df-- From unknown Sun Jun 22 17:13:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35695: 27.0.50; Faces diff-added and diff-removed look the same in a 256 color terminal Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 May 2019 05:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Anders Lindgren Cc: 35695@debbugs.gnu.org Received: via spool by 35695-submit@debbugs.gnu.org id=B35695.155763962613911 (code B ref 35695); Sun, 12 May 2019 05:41:02 +0000 Received: (at 35695) by debbugs.gnu.org; 12 May 2019 05:40:26 +0000 Received: from localhost ([127.0.0.1]:41625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPhDm-0003cI-Fh for submit@debbugs.gnu.org; Sun, 12 May 2019 01:40:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPhDk-0003bv-8c for 35695@debbugs.gnu.org; Sun, 12 May 2019 01:40:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52507) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPhDf-0005X4-3M; Sun, 12 May 2019 01:40:19 -0400 Received: from [176.228.60.248] (port=4990 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hPhDe-0002XE-Ek; Sun, 12 May 2019 01:40:18 -0400 Date: Sun, 12 May 2019 08:39:58 +0300 Message-Id: <83woiwb58x.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Anders Lindgren on Sun, 12 May 2019 07:03:41 +0200) References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Anders Lindgren > Date: Sun, 12 May 2019 07:03:41 +0200 > > In Emac 26, they were defined using #ddffdd and #ffdddd, respectively, which is rendered fine in the terminal > (on both Emacs 26 and 27). > > One way to solve this is to add alternative color definitions using the "min-colors" requirement. Another is to go > back to the old values. I think we should go to the back values when min-colors is 256 or less. From unknown Sun Jun 22 17:13:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35695: 27.0.50; Faces diff-added and diff-removed look the same in a 256 color terminal Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 May 2019 06:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: andlind@gmail.com Cc: 35695@debbugs.gnu.org Received: via spool by 35695-submit@debbugs.gnu.org id=B35695.155764075216456 (code B ref 35695); Sun, 12 May 2019 06:00:02 +0000 Received: (at 35695) by debbugs.gnu.org; 12 May 2019 05:59:12 +0000 Received: from localhost ([127.0.0.1]:41639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPhVw-0004HK-HB for submit@debbugs.gnu.org; Sun, 12 May 2019 01:59:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37579) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPhVu-0004H8-Ip for 35695@debbugs.gnu.org; Sun, 12 May 2019 01:59:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52585) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPhVp-0006Lh-BK; Sun, 12 May 2019 01:59:05 -0400 Received: from [176.228.60.248] (port=2243 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hPhVo-0008Rs-OI; Sun, 12 May 2019 01:59:05 -0400 Date: Sun, 12 May 2019 08:58:45 +0300 Message-Id: <83v9ygb4dm.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <83woiwb58x.fsf@gnu.org> (message from Eli Zaretskii on Sun, 12 May 2019 08:39:58 +0300) References: <83woiwb58x.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 12 May 2019 08:39:58 +0300 > From: Eli Zaretskii > Cc: 35695@debbugs.gnu.org > > I think we should go to the back values when min-colors is 256 or > less. I meant: I think we should go back to the old values when min-colors is 256 or less. Sorry. From unknown Sun Jun 22 17:13:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35695: 27.0.50; Faces diff-added and diff-removed look the same in a 256 color terminal Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 May 2019 18:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 35695@debbugs.gnu.org Received: via spool by 35695-submit@debbugs.gnu.org id=B35695.15576869042865 (code B ref 35695); Sun, 12 May 2019 18:49:01 +0000 Received: (at 35695) by debbugs.gnu.org; 12 May 2019 18:48:24 +0000 Received: from localhost ([127.0.0.1]:43307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPtWJ-0000k8-Mg for submit@debbugs.gnu.org; Sun, 12 May 2019 14:48:24 -0400 Received: from mail-lf1-f43.google.com ([209.85.167.43]:34357) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPtWH-0000ju-DH for 35695@debbugs.gnu.org; Sun, 12 May 2019 14:48:22 -0400 Received: by mail-lf1-f43.google.com with SMTP id v18so7429465lfi.1 for <35695@debbugs.gnu.org>; Sun, 12 May 2019 11:48:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kpMM/vwdkiEzE3odtQ5aU5Xw9aK5pj7sXM6JaowHTMw=; b=hAiamHDE3Q+IhM31moFcdRmW/tN7HRKjQpQV66RdHIw9EdemQY3oz1dfC4HY77+xj7 Y+1tPynU053fZ4ZmrpP8CL3XCUimaDrLgJuP/ZLtB/wlJrvuQcZxRPIVIs92Egngrppc a6TmAyji/gIRCaiaLVdnV/Bd3Iire+lDUK8SBWncSK854ho6Tc/DEoCXc5XRxm2i4wsX eT0/d9gvO8TLaL/Ijecb4WRSlIgBR7Q37+wdidg+kSZLnfyPI0nqcs3x+jglxgcPqKBK x9MTGfFonCmHKjsQylZfaGMZ2Ks3Rom/+0JO+2tupHdVBMKUxKnR7e7XzoYowmXDPNVX oJWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kpMM/vwdkiEzE3odtQ5aU5Xw9aK5pj7sXM6JaowHTMw=; b=aNzA/2Rjtk8CIKU/LF/CateAL9c8bR+tfAXlD5Wzd2ev+y6NN8xXChkWPsuY6tMmvf gjLGRL/TGBNCc5vaH6KV4BZWtthdttfXS1mB7TT+qQTh5hOdyXTGyZpwff1IU3gRNkCE 6j5kYY/AJbAuUZvpE+Jd6XlghvbRk8L4ZrxLTL/fm+LFJJwsn4SosAHfq+GYoUk5sFq5 3p+cHtl6g7yct/I1Ms8V/JatJGl99QkSV8kZccyO/+VScTdIsNIYFjr35wLJdT2O5ww8 AA9kDW8pvNtzHYfMnwWbfoG3cOJKiD4FTs8eHdrQ/nhSWkuLNx+wSe/2aJvdlhrT1cvw hciQ== X-Gm-Message-State: APjAAAVOILfG8l2NRGSuZ/+m/rY0EGt3RM1unmDPGN3+Q4FL5ozJSNyh Wq8+GqgfBF0rSC8J5/rSw4tPvPS3MPtbx+YmB7zbwc0bR6Q= X-Google-Smtp-Source: APXvYqzOjU7CqKhZ0/Ubn7EV1bMGBiQe3A8fep6luCprF5tS1g4b6dsdqVJgxjiqkh+8guI0zySol9rV20zqmxboj1Q= X-Received: by 2002:a19:760e:: with SMTP id c14mr11570047lff.48.1557686894876; Sun, 12 May 2019 11:48:14 -0700 (PDT) MIME-Version: 1.0 References: <83woiwb58x.fsf@gnu.org> <83v9ygb4dm.fsf@gnu.org> In-Reply-To: <83v9ygb4dm.fsf@gnu.org> From: Anders Lindgren Date: Sun, 12 May 2019 20:48:03 +0200 Message-ID: Content-Type: multipart/alternative; boundary="0000000000000a5c110588b53ebf" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000000a5c110588b53ebf Content-Type: text/plain; charset="UTF-8" Hi! On Sun, May 12, 2019 at 7:59 AM Eli Zaretskii wrote: > I think we should go back to the old values when min-colors is 256 > or less. > Sounds good to me. I just gave the following a try. It seems to be working, but I'd like to double check the details so that I haven't missed a face. (Dark mode isn't affected, as far as I can see.) diff --git a/lisp/vc/diff-mode.el b/lisp/vc/diff-mode.el index a26e9ee..079806d 100644--- a/lisp/vc/diff-mode.el +++ b/lisp/vc/diff-mode.el@@ -314,8 +314,10 @@ diff-hunk-header (defface diff-removed '((default :inherit diff-changed)- (((class color) (min-colors 88) (background light))+ (((class color) (min-colors 257) (background light)) :background "#ffeeee")+ (((class color) (min-colors 88) (background light))+ :background "#ffdddd") (((class color) (min-colors 88) (background dark)) :background "#553333") (((class color))@@ -325,8 +327,10 @@ diff-removed (defface diff-added '((default :inherit diff-changed)- (((class color) (min-colors 88) (background light))+ (((class color) (min-colors 257) (background light)) :background "#eeffee")+ (((class color) (min-colors 88) (background light))+ :background "#ddffdd") (((class color) (min-colors 88) (background dark)) :background "#335533") (((class color))@@ -2040,8 +2044,10 @@ diff-refine-changed (defface diff-refine-removed '((default :inherit diff-refine-changed)- (((class color) (min-colors 88) (background light))+ (((class color) (min-colors 257) (background light)) :background "#ffcccc")+ (((class color) (min-colors 88) (background light))+ :background "#ffbbbb") (((class color) (min-colors 88) (background dark)) :background "#aa2222")) "Face used for removed characters shown by `diff-refine-hunk'." -- Anders Lindgren --0000000000000a5c110588b53ebf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi!

On Sun, May 12, 2019 at 7:59 AM Eli Zaretskii <= eliz@gnu.org> wrote:
=C2=A0 I think we should go bac= k to the old values when min-colors is 256
=C2=A0 or less.
=C2=A0
Sounds g= ood to me.

I just gave the following = a try. It seems to be working, but I'd like to double check the details= so that I haven't missed a face. (Dark mode isn't affected, as far= as I can see.)

diff --git a/lisp/vc/diff-mode.el b/lisp/vc/diff-mode.el
= 
index a26e9ee..079806d 100644
--- a/lisp/vc/diff-=
mode.el
+++ b/lisp/vc/diff-mode.el
@@ -314,8 +314,10 =
@@ diff-hunk-heade=
r
 (defface diff-removed
   '((default
      :inherit diff-changed)
-    (((class color) (min-colors 88)=
 (background light))
+    (((class color) (min-colors 257=
) (background light))
      :background "#ffeeee&=
quot;)
+    (((class color) (min-colors 88)=
 (background light))
+     :background "#ffdddd"=
;)
     (((class color) (min-colors=
 88) (background dark))
      :background "#553333")
     (((class color))
@@ -325,8 +327,10 =
@@ diff-removed
 (defface diff-added
   '((default
      :inherit diff-changed)
-    (((class color) (min-colors 88)=
 (background light))
+    (((class color) (min-colors 257=
) (background light))
      :background "#eeffee&=
quot;)
+    (((class color) (min-colors 88)=
 (background light))
+     :background "#ddffdd"=
;)
     (((class color) (min-colors=
 88) (background dark))
      :background "#335533")
     (((class color))
@@ -2040,8 +2044,1=
0 @@ diff-refine-c=
hanged
 (defface diff-refine-removed
   '((default
      :inherit diff-refine-changed)
-    (((class color) (min-colors 88)=
 (background light))
+    (((class color) (min-colors 257=
) (background light))
      :background "#ffcccc&=
quot;)
+    (((class color) (min-colors 88)=
 (background light))
+     :background "#ffbbbb"=
;)
     (((class color) (min-colors=
 88) (background dark))
      :background "#aa2222"))
   "Face used for removed characters shown by `diff-refine-hunk'.&=
quot;

=C2=A0 =C2=A0 -- Anders Lindgren=C2=A0
--0000000000000a5c110588b53ebf-- From unknown Sun Jun 22 17:13:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35695: 27.0.50; Faces diff-added and diff-removed look the same in a 256 color terminal In-Reply-To: Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 May 2019 19:29:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Anders Lindgren Cc: Eli Zaretskii , 35695@debbugs.gnu.org Received: via spool by 35695-submit@debbugs.gnu.org id=B35695.15576893056598 (code B ref 35695); Sun, 12 May 2019 19:29:03 +0000 Received: (at 35695) by debbugs.gnu.org; 12 May 2019 19:28:25 +0000 Received: from localhost ([127.0.0.1]:43358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPu93-0001iM-6L for submit@debbugs.gnu.org; Sun, 12 May 2019 15:28:25 -0400 Received: from eastern.maple.relay.mailchannels.net ([23.83.214.55]:14680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPu91-0001iE-ID for 35695@debbugs.gnu.org; Sun, 12 May 2019 15:28:24 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 90DE5123C84; Sun, 12 May 2019 19:28:22 +0000 (UTC) Received: from pdx1-sub0-mail-a64.g.dreamhost.com (unknown [100.96.11.48]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 5265B123D2A; Sun, 12 May 2019 19:28:22 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a64.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Sun, 12 May 2019 19:28:22 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Average-Stop: 0cc501ea0cd77c89_1557689302420_150329524 X-MC-Loop-Signature: 1557689302420:320143722 X-MC-Ingress-Time: 1557689302420 Received: from pdx1-sub0-mail-a64.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a64.g.dreamhost.com (Postfix) with ESMTP id 1D5A180510; Sun, 12 May 2019 12:28:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; s=linkov.net; bh=Q7UdK0yvV3MfiOzBpMfrh3OpRiY=; b=hJ9HtxtY/TZYRy UNlsb/YggwnaIGdy8bLnrRSUqGdtzlAhdeioALfviMW7dkQUJtA5MIanD2Dw02Du IMUebNMRcGbLiPITVt9gC8epEVOwhk4u8qcUueKQV3ODo471MN/Akk6WX5UW42Aj IO4+Gms58/LznuW08YS/EycC0swFg= Received: from mail.jurta.org (m91-129-96-230.cust.tele2.ee [91.129.96.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a64.g.dreamhost.com (Postfix) with ESMTPSA id A49DD80502; Sun, 12 May 2019 12:28:19 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a64 From: Juri Linkov Organization: LINKOV.NET References: <83woiwb58x.fsf@gnu.org> <83v9ygb4dm.fsf@gnu.org> Date: Sun, 12 May 2019 22:24:48 +0300 Message-ID: <877eavwkin.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrledvgddugedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledrleeirddvfedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleeirddvfedtpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtoheprghnughlihhnugesghhmrghilhdrtghomhenucevlhhushhtvghrufhiiigvpedt X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> I think we should go back to the old values when min-colors is 256 >> or less. > > Sounds good to me. > > I just gave the following a try. It seems to be working, but I'd like to > double check the details so that I haven't missed a face. (Dark mode isn't > affected, as far as I can see.) Thanks, diff-refine-added needs old values for 288 colors as well. From unknown Sun Jun 22 17:13:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35695: 27.0.50; Faces diff-added and diff-removed look the same in a 256 color terminal Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 May 2019 20:47:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: Eli Zaretskii , 35695@debbugs.gnu.org Received: via spool by 35695-submit@debbugs.gnu.org id=B35695.155778038631823 (code B ref 35695); Mon, 13 May 2019 20:47:03 +0000 Received: (at 35695) by debbugs.gnu.org; 13 May 2019 20:46:26 +0000 Received: from localhost ([127.0.0.1]:46470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQHq5-0008Gm-SK for submit@debbugs.gnu.org; Mon, 13 May 2019 16:46:26 -0400 Received: from mail-lf1-f43.google.com ([209.85.167.43]:39574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQHpw-00083P-Tf for 35695@debbugs.gnu.org; Mon, 13 May 2019 16:46:21 -0400 Received: by mail-lf1-f43.google.com with SMTP id f1so10094858lfl.6 for <35695@debbugs.gnu.org>; Mon, 13 May 2019 13:46:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uZ9gBc6lU9xBWl7ffuQDkB3YVCFeJ4BeOVakWSwfuPc=; b=Basv72LgnpPj1uGEAaLVYq8B0LzrDc2bqyU91lPk0NAuXkbc4qXixEndlnHIPjAvFi 03rM6yGgzHJMUKKocyVnXvzrpdAQSjXGed7SkD2ey0LEYVbOy9yrbRBvX5nCbrptMjH7 MSs7ZuBL+wB5W/je+7zF0c27lR8vR9/zCUi8HV25FEK+F4P7I5mvh6+AlQyAksJtbA3Z X75D+of0gR97W3Btis33DGP78JJveSPU3eoN68GQFiFwLUAdNB+L/1WF2k+r6u1lYc0R R/tXSyjlRz3u2WMQZagJS5ENoh2U3vivDU18msWvTcy7+oq9p09jbrLfDDB5dH4rIDnc hLWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uZ9gBc6lU9xBWl7ffuQDkB3YVCFeJ4BeOVakWSwfuPc=; b=s0yFGRwUpbg7Lugvh6wSbC1RXiAmTVd2srnRw+/8sPdv4CGF1WOmn++ojNCUt3Jkgh pbN3TiBFap+8D96XSY6TA9BBrSv7iUJKknYieUrkGGi5TLuBN5RAHUITKmk7Dme378k7 ZVWxbAOw4fgXiFRnocIvlH8aPGAg57f+QgpdwyjZqB4VB8Szu3if+exwoaZoYFMcx0IU uaeR9G8ReCnpdcbO0z+J4cj12W3PE0OS1rp/DtEvZNFiqj+6G0MVw6y/TQO7pT2uI2OP oDMUdalCKukzZ4IiYIWfThh/1biEwoHxKfs0qVBaPnMMudWYGQq5V9RI2f7/lrTLo0wB rUrA== X-Gm-Message-State: APjAAAWrXZefxDaiOYoHbS/yZ5Ze8il3jPHdQIrYpI4NQyjf7u0PMkaX bcyJM06y58eF4iW/9PnLUkAd5OjtxIU7VMWMDIs= X-Google-Smtp-Source: APXvYqzsMgpCiYCg98v0RKJ5hARyrLr7vhCIyipy5H0QPBmHsAwYnoZtqBs5R4TUkG0Nm2EhKlv4LtHlrZhFdhDPG5k= X-Received: by 2002:a19:29c4:: with SMTP id p187mr14564102lfp.69.1557780370806; Mon, 13 May 2019 13:46:10 -0700 (PDT) MIME-Version: 1.0 References: <83woiwb58x.fsf@gnu.org> <83v9ygb4dm.fsf@gnu.org> <877eavwkin.fsf@mail.linkov.net> In-Reply-To: <877eavwkin.fsf@mail.linkov.net> From: Anders Lindgren Date: Mon, 13 May 2019 22:45:59 +0200 Message-ID: Content-Type: multipart/alternative; boundary="000000000000a3dee00588cb01f2" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000a3dee00588cb01f2 Content-Type: text/plain; charset="UTF-8" Hi! On Sun, May 12, 2019 at 9:28 PM Juri Linkov wrote: > Thanks, diff-refine-added needs old values for 288 colors as well. > I didn't include it since the output looked good with the new value. However, for consistency, we should probably add one for it as well. Should I include a comment describing why we need to treat 256 color displays differently? -- Anders --000000000000a3dee00588cb01f2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi!

On Sun, May 12, 2019 at 9:28 PM Juri Linkov <juri@linkov.net> wrote:
Thanks, diff-refine-added n= eeds old values for 288 colors as well.

I didn't include it since the output looked good with the new value. H= owever, for consistency, we should probably add one for it as well.

Should I include a comment describing why we need to trea= t 256 color displays differently?

=C2=A0 =C2=A0 --= Anders

--000000000000a3dee00588cb01f2-- From unknown Sun Jun 22 17:13:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35695: 27.0.50; Faces diff-added and diff-removed look the same in a 256 color terminal Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 May 2019 20:37:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Anders Lindgren Cc: Eli Zaretskii , 35695@debbugs.gnu.org Received: via spool by 35695-submit@debbugs.gnu.org id=B35695.155786617118008 (code B ref 35695); Tue, 14 May 2019 20:37:03 +0000 Received: (at 35695) by debbugs.gnu.org; 14 May 2019 20:36:11 +0000 Received: from localhost ([127.0.0.1]:49970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQe9j-0004gN-4G for submit@debbugs.gnu.org; Tue, 14 May 2019 16:36:11 -0400 Received: from catfish.maple.relay.mailchannels.net ([23.83.214.32]:31357) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQe9f-0004gB-4r for 35695@debbugs.gnu.org; Tue, 14 May 2019 16:36:09 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 7BF21142608; Tue, 14 May 2019 20:36:05 +0000 (UTC) Received: from pdx1-sub0-mail-a88.g.dreamhost.com (100-96-6-25.trex.outbound.svc.cluster.local [100.96.6.25]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 951C41423DD; Tue, 14 May 2019 20:36:01 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a88.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Tue, 14 May 2019 20:36:05 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Attack-Relation: 14e19d62256cad5c_1557866165313_3475148093 X-MC-Loop-Signature: 1557866165313:426172065 X-MC-Ingress-Time: 1557866165312 Received: from pdx1-sub0-mail-a88.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a88.g.dreamhost.com (Postfix) with ESMTP id B46F0806C0; Tue, 14 May 2019 13:36:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=FRPpFIPxCwagpxmEs1fMlWD20VA=; b= QSvf7GSgcm2RnuzXHUAl9/9IldyILrIckwJxzMhyPSsUQlGPbbVN3YyeIaOd05W5 cesiIPw4U23LWyuWilcSDsNtsaR9/fFxeOr2EWZokFWUTt9QakN939N3LF9al3XG 1XfHIB/Sqn9K3SW69AxKVgku1VTe+gyDFJSVW3E1KWE= Received: from mail.jurta.org (m91-129-96-230.cust.tele2.ee [91.129.96.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a88.g.dreamhost.com (Postfix) with ESMTPSA id BF4B7806BC; Tue, 14 May 2019 13:35:58 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a88 From: Juri Linkov Organization: LINKOV.NET References: <83woiwb58x.fsf@gnu.org> <83v9ygb4dm.fsf@gnu.org> <877eavwkin.fsf@mail.linkov.net> Date: Tue, 14 May 2019 23:06:18 +0300 In-Reply-To: (Anders Lindgren's message of "Mon, 13 May 2019 22:45:59 +0200") Message-ID: <87d0kkzv4d.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrleeigdduhedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdeliedrvdeftdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrdeliedrvdeftddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegrnhgulhhinhgusehgmhgrihhlrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> Thanks, diff-refine-added needs old values for 288 colors as well. > > I didn't include it since the output looked good with the new value. > However, for consistency, we should probably add one for it as well. > > Should I include a comment describing why we need to treat 256 color > displays differently? Yes, comments are preferable because we don't have deffaces with more than 88 min-colors anywhere else. From unknown Sun Jun 22 17:13:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35695: 27.0.50; Faces diff-added and diff-removed look the same in a 256 color terminal Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 May 2019 19:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 35695-done@debbugs.gnu.org, Eli Zaretskii , 35695@debbugs.gnu.org Received: via spool by 35695-submit@debbugs.gnu.org id=B35695.155794745527431 (code B ref 35695); Wed, 15 May 2019 19:11:02 +0000 Received: (at 35695) by debbugs.gnu.org; 15 May 2019 19:10:55 +0000 Received: from localhost ([127.0.0.1]:53400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQzIj-00078K-Fx for submit@debbugs.gnu.org; Wed, 15 May 2019 15:10:53 -0400 Received: from mail-lf1-f51.google.com ([209.85.167.51]:36166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQzIh-000782-Ch; Wed, 15 May 2019 15:10:51 -0400 Received: by mail-lf1-f51.google.com with SMTP id y10so692742lfl.3; Wed, 15 May 2019 12:10:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pyxJoQYSFxODF4zbddGRBXNz7BGoVI1/9Xtf78YdY3Y=; b=DnuB/dltzw4dd8MMef/VhAw8rsAru44ObhvzBXvwiwLnoG4AfmwJypMGKz4i8ap1+A 4bZHEC9bVRViJvwy43nGCcWoM8QI8HNK7B84wQ7MZ2GJsRrE6TDd+MBFxsl9DpHDr/GX mKmu+uMqZRSuTdsbshj8Bdlq4D+ANiLQE0kv2IhkPigISQERd6vX9sSYlDrk3lgQJUTP LV9S1krpBnW04n+Qlq9EHe6iPKCuY6t1/6CIEkV1rwnlvCwuNWP/yhi94OGBmEGpbMBK JJ3TP7ie+aEHlw6Mk502p476ncXq7aarH07usLJw7JVI6BmY09OjW6THofQfe9AXqWjo GtSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pyxJoQYSFxODF4zbddGRBXNz7BGoVI1/9Xtf78YdY3Y=; b=tk82yueMuwYesLlmkDJL53EhZb1VoZZerM3LpNmgmO6BdMBrwNY/uixG9cFRd10Ndd AnSE5tXctqRzGNiy24L9H1GFsvZRXydJb9uU7IzTAOBnRsisguA/2poWcFqOhXLckhys mfF+n+weWkdd1ZUOzcesdHaWfkfruYkg/Kj+DOSmtafmpQ1FzKyfZlBoQKOkrlUtUYTX 3wh+OO4VzV1IrqN0MYMpKiuf38XphTWdJrP8ITyW7GkwOpMD7AhRhjKTj4lXDFWpXMTG oZd+Oxa8AuH50fKdj+07ReOXzOB9I8xuzXObhq0Hi07LOF7KZ9qPdLocUY1Wh4sux8GV N4+A== X-Gm-Message-State: APjAAAVaa8UJMrIBUGCnqK64kU7bcA2ZIqigYakNbT6XbTH4TfP78aAG +yrlI+f6j4P/3IPXjGWoZSmUZe9TwddqNk5gt2I= X-Google-Smtp-Source: APXvYqw6++oVibHi+Nx9J8lv9B7+a/EzYvGXl2d48iYlfUGe8EkaTjtYD92IshJ6BhRE60ge/S/6YJ7sr2TmDvHnz7A= X-Received: by 2002:a19:760e:: with SMTP id c14mr4573630lff.48.1557947445479; Wed, 15 May 2019 12:10:45 -0700 (PDT) MIME-Version: 1.0 References: <83woiwb58x.fsf@gnu.org> <83v9ygb4dm.fsf@gnu.org> <877eavwkin.fsf@mail.linkov.net> <87d0kkzv4d.fsf@mail.linkov.net> In-Reply-To: <87d0kkzv4d.fsf@mail.linkov.net> From: Anders Lindgren Date: Wed, 15 May 2019 21:10:34 +0200 Message-ID: Content-Type: multipart/alternative; boundary="000000000000110eb60588f1e87c" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000110eb60588f1e87c Content-Type: text/plain; charset="UTF-8" On Tue, May 14, 2019 at 10:36 PM Juri Linkov wrote: > > Should I include a comment describing why we need to treat 256 color > > displays differently? > > Yes, comments are preferable because we don't have deffaces > with more than 88 min-colors anywhere else. > Thanks for the feedback! I've pushed a patch fixing this issue. -- Anders --000000000000110eb60588f1e87c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, May 14, 2019 at 10:36 PM Juri Lin= kov <juri@linkov.net> wrote:
> Should I include a comment describing why we need to treat = 256 color
> displays differently?

Yes, comments are preferable because we don't have deffaces
with more than 88 min-colors anywhere else.

=
Thanks for the feedback!

I've pushed a pa= tch fixing this issue.

=C2=A0 =C2=A0 -- Anders

--000000000000110eb60588f1e87c-- From unknown Sun Jun 22 17:13:41 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Anders Lindgren Subject: bug#35695: closed (Re: bug#35695: 27.0.50; Faces diff-added and diff-removed look the same in a 256 color terminal) Message-ID: References: X-Gnu-PR-Message: they-closed 35695 X-Gnu-PR-Package: emacs Reply-To: 35695@debbugs.gnu.org Date: Wed, 15 May 2019 19:11:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1557947463-27461-1" This is a multi-part message in MIME format... ------------=_1557947463-27461-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #35695: 27.0.50; Faces diff-added and diff-removed look the same in a 256 c= olor terminal which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 35695@debbugs.gnu.org. --=20 35695: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D35695 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1557947463-27461-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 35695-done) by debbugs.gnu.org; 15 May 2019 19:10:55 +0000 Received: from localhost ([127.0.0.1]:53402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQzIl-00078O-1Q for submit@debbugs.gnu.org; Wed, 15 May 2019 15:10:55 -0400 Received: from mail-lf1-f51.google.com ([209.85.167.51]:36166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQzIh-000782-Ch; Wed, 15 May 2019 15:10:51 -0400 Received: by mail-lf1-f51.google.com with SMTP id y10so692742lfl.3; Wed, 15 May 2019 12:10:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pyxJoQYSFxODF4zbddGRBXNz7BGoVI1/9Xtf78YdY3Y=; b=DnuB/dltzw4dd8MMef/VhAw8rsAru44ObhvzBXvwiwLnoG4AfmwJypMGKz4i8ap1+A 4bZHEC9bVRViJvwy43nGCcWoM8QI8HNK7B84wQ7MZ2GJsRrE6TDd+MBFxsl9DpHDr/GX mKmu+uMqZRSuTdsbshj8Bdlq4D+ANiLQE0kv2IhkPigISQERd6vX9sSYlDrk3lgQJUTP LV9S1krpBnW04n+Qlq9EHe6iPKCuY6t1/6CIEkV1rwnlvCwuNWP/yhi94OGBmEGpbMBK JJ3TP7ie+aEHlw6Mk502p476ncXq7aarH07usLJw7JVI6BmY09OjW6THofQfe9AXqWjo GtSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pyxJoQYSFxODF4zbddGRBXNz7BGoVI1/9Xtf78YdY3Y=; b=tk82yueMuwYesLlmkDJL53EhZb1VoZZerM3LpNmgmO6BdMBrwNY/uixG9cFRd10Ndd AnSE5tXctqRzGNiy24L9H1GFsvZRXydJb9uU7IzTAOBnRsisguA/2poWcFqOhXLckhys mfF+n+weWkdd1ZUOzcesdHaWfkfruYkg/Kj+DOSmtafmpQ1FzKyfZlBoQKOkrlUtUYTX 3wh+OO4VzV1IrqN0MYMpKiuf38XphTWdJrP8ITyW7GkwOpMD7AhRhjKTj4lXDFWpXMTG oZd+Oxa8AuH50fKdj+07ReOXzOB9I8xuzXObhq0Hi07LOF7KZ9qPdLocUY1Wh4sux8GV N4+A== X-Gm-Message-State: APjAAAVaa8UJMrIBUGCnqK64kU7bcA2ZIqigYakNbT6XbTH4TfP78aAG +yrlI+f6j4P/3IPXjGWoZSmUZe9TwddqNk5gt2I= X-Google-Smtp-Source: APXvYqw6++oVibHi+Nx9J8lv9B7+a/EzYvGXl2d48iYlfUGe8EkaTjtYD92IshJ6BhRE60ge/S/6YJ7sr2TmDvHnz7A= X-Received: by 2002:a19:760e:: with SMTP id c14mr4573630lff.48.1557947445479; Wed, 15 May 2019 12:10:45 -0700 (PDT) MIME-Version: 1.0 References: <83woiwb58x.fsf@gnu.org> <83v9ygb4dm.fsf@gnu.org> <877eavwkin.fsf@mail.linkov.net> <87d0kkzv4d.fsf@mail.linkov.net> In-Reply-To: <87d0kkzv4d.fsf@mail.linkov.net> From: Anders Lindgren Date: Wed, 15 May 2019 21:10:34 +0200 Message-ID: Subject: Re: bug#35695: 27.0.50; Faces diff-added and diff-removed look the same in a 256 color terminal To: Juri Linkov Content-Type: multipart/alternative; boundary="000000000000110eb60588f1e87c" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35695-done Cc: 35695-done@debbugs.gnu.org, Eli Zaretskii , 35695@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000110eb60588f1e87c Content-Type: text/plain; charset="UTF-8" On Tue, May 14, 2019 at 10:36 PM Juri Linkov wrote: > > Should I include a comment describing why we need to treat 256 color > > displays differently? > > Yes, comments are preferable because we don't have deffaces > with more than 88 min-colors anywhere else. > Thanks for the feedback! I've pushed a patch fixing this issue. -- Anders --000000000000110eb60588f1e87c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, May 14, 2019 at 10:36 PM Juri Lin= kov <juri@linkov.net> wrote:
> Should I include a comment describing why we need to treat = 256 color
> displays differently?

Yes, comments are preferable because we don't have deffaces
with more than 88 min-colors anywhere else.

=
Thanks for the feedback!

I've pushed a pa= tch fixing this issue.

=C2=A0 =C2=A0 -- Anders

--000000000000110eb60588f1e87c-- ------------=_1557947463-27461-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 12 May 2019 05:10:31 +0000 Received: from localhost ([127.0.0.1]:41602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPgko-0002if-PZ for submit@debbugs.gnu.org; Sun, 12 May 2019 01:10:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPgkm-0002iP-Mt for submit@debbugs.gnu.org; Sun, 12 May 2019 01:10:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:37414) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hPgkh-000789-FH for submit@debbugs.gnu.org; Sun, 12 May 2019 01:10:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPgkf-0008B2-P5 for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 01:10:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hPge2-0000bQ-9K for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 01:03:31 -0400 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]:45429) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hPge1-0000UR-RP for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 01:03:30 -0400 Received: by mail-lf1-x144.google.com with SMTP id n22so6713678lfe.12 for ; Sat, 11 May 2019 22:03:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=c1qF43AsterVkbT3r1lkKIxoBq/d59NTRNfYgzHpf08=; b=uXdmKh9X5pFvORZrMOvNtj5Rg7QbeosilL29XzgMacgywH9I3VSK2hUftL+txiKO/c Pnd2gTPqAzO0ZW8MOJJvKhmtaL2mzQx4Hjc16i9ldAm4cihCEKLLpe5Hnw6WNOhZx+FA cDyinaAt8UPOeAfhZmk2pZX3HkGhnE+qztw7ImczI5QyCAfB0fNW44gP4GfyifBtihe2 Ahu+e4dg2j7XF0vyBpZDShTArKOwd7MUB4Yt3y53L703uZGev1oHQ18iBsVQ+BEGpIRF EaqWYpwty8brXhuMkkzpMCjz3XASujFnya85Ih+F36xnxDWmUJxwxQb+otFaluxxILWv yvxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=c1qF43AsterVkbT3r1lkKIxoBq/d59NTRNfYgzHpf08=; b=Ukuqi9Q3n3TP5w8z9EbUY4HPqISShQqwpgF2PfPqnBN8yNf8Cvm21ju3OiZyZ3NQ/+ yBupU6uXk/d9jYZqhPW6cejhMsPD48z2W60vFKe//IhNgiaj2JxdJLaYJqZUcq1IIJsQ tPYJMovtmSAmxf5rUbsRAmqizuLpb289iNM0ruZXPdoMz7PUeF73a8y1EPGeLxjpVX// JpeGA/8Z07RGmCssonnV1GZ4b3quCPQTkgnNkTxxz8OuqOYMtnm/ptL+OZzZjIyJR2Qa gkzs/uOs/LHYxn/ryb7ZAQYxnGqQVjBh1V3T5k+FoYXJ1JQgcFatwwHSkkRZb6r9JOSz je7w== X-Gm-Message-State: APjAAAXd+1Cpl1NeEfVlvXJBAJaSBIUyzOEqVyrrhNIc+d82Ia8Lvces WeIM5k4c96BQP76BJThMYgvhv9A3glCSwaW3A9DSAjPufrQ= X-Google-Smtp-Source: APXvYqxA3GIZOKKcdKTfS4OWpKkMV7+8PwXY21YFcUFW7MhEw8GtN1c33iX80KWNDL5PTOw6CjGe7aqFOkzZAv/V5GQ= X-Received: by 2002:a19:c394:: with SMTP id t142mr5520656lff.102.1557637406807; Sat, 11 May 2019 22:03:26 -0700 (PDT) MIME-Version: 1.0 From: Anders Lindgren Date: Sun, 12 May 2019 07:03:41 +0200 Message-ID: Subject: 27.0.50; Faces diff-added and diff-removed look the same in a 256 color terminal To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="0000000000005259920588a9b8df" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::144 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --0000000000005259920588a9b8df Content-Type: text/plain; charset="UTF-8" Hi! When using Emacs in a terminal that supports 256 colors (such as the built-in terminal on macOS), the faces diff-added and diff-removed look the same. They are defined to have a background color of #eeffee and #ffeeee, respectively, in light background mode. When a diff is viewed in a terminal, they are both rendered using light grey background, so it's impossible to distinguish between them. In Emac 26, they were defined using #ddffdd and #ffdddd, respectively, which is rendered fine in the terminal (on both Emacs 26 and 27). One way to solve this is to add alternative color definitions using the "min-colors" requirement. Another is to go back to the old values. -- Anders Lindgren In GNU Emacs 27.0.50 (build 1, x86_64-apple-darwin16.7.0, NS appkit-1504.83 Version 10.12.6 (Build 16G29)) of 2019-05-01 built on mbp.lan Repository revision: 7dafbe3ab91e838803a84ab388bca03ff985e312 Repository branch: master System Description: Mac OS X 10.12.6 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. delete-backward-char: Text is read-only Quit Mark saved where search started Making completion list... Configured using: 'configure --with-gnutls=no' Configured features: NOTIFY KQUEUE ACL LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS THREADS PDUMPER GMP Important settings: value of $LC_CTYPE: UTF-8 value of $LANG: en_SE.UTF-8 locale-coding-system: utf-8-unix Major mode: Apropos Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils misearch multi-isearch help-mode cl-loaddefs cl-lib apropos smerge-mode vc-dispatcher vc-svn diff-mode easymenu easy-mmode term/xterm xterm elec-pair tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 56669 7188) (symbols 48 6625 1) (strings 32 17368 1666) (string-bytes 1 565596) (vectors 16 7835) (vector-slots 8 78808 10720) (floats 8 25 439) (intervals 56 860 4) (buffers 992 14)) --0000000000005259920588a9b8df Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi!

<= /div>
When using Emacs in a terminal that supports 256 colors (such as = the built-in terminal on macOS), the faces diff-added and diff-removed look= the same.

They are defined to have a background c= olor of #eeffee and #ffeeee, respectively, in light background mode. When a= diff is viewed in a terminal, they are both rendered using light grey back= ground, so it's impossible to distinguish between them.

<= /div>
In Emac 26, they were defined using #ddffdd and #ffdddd, respecti= vely, which is rendered fine in the terminal (on both Emacs 26 and 27).

One way to solve this is to add alternative color def= initions using the "min-colors" requirement. Another is to go bac= k to the old values.

=C2=A0 =C2=A0 =C2=A0-- Anders= Lindgren

In GNU Emacs 27.0.50 (build 1, x86_64-ap= ple-darwin16.7.0, NS appkit-1504.83 Version 10.12.6 (Build 16G29))
=C2=A0of 2019-05-01 built on mbp.lan
Repository revision: 7dafb= e3ab91e838803a84ab388bca03ff985e312
Repository branch: master
System Description:=C2=A0 Mac OS X 10.12.6

= Recent messages:
For information about GNU Emacs and the GNU syst= em, type C-h C-a.
delete-backward-char: Text is read-only
Quit
Mark saved where search started
Making completi= on list...

Configured using:
=C2=A0'= configure --with-gnutls=3Dno'

Configured featu= res:
NOTIFY KQUEUE ACL LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS THREAD= S PDUMPER
GMP

Important settings:
<= div>=C2=A0 value of $LC_CTYPE: UTF-8
=C2=A0 value of $LANG: en_SE= .UTF-8
=C2=A0 locale-coding-system: utf-8-unix

Major mode: Apropos

Minor modes in effect:<= /div>
=C2=A0 tooltip-mode: t
=C2=A0 global-eldoc-mode: t
=C2=A0 electric-indent-mode: t
=C2=A0 mouse-wheel-mode: t
=C2=A0 tool-bar-mode: t
=C2=A0 menu-bar-mode: t
=C2=A0 file-name-shadow-mode: t
=C2=A0 global-font-lock-mode: t=
=C2=A0 font-lock-mode: t
=C2=A0 auto-composition-mode:= t
=C2=A0 auto-encryption-mode: t
=C2=A0 auto-compressi= on-mode: t
=C2=A0 buffer-read-only: t
=C2=A0 line-numbe= r-mode: t
=C2=A0 transient-mark-mode: t

= Load-path shadows:
None found.

Features:=
(shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv=
bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc= 822 mml
mml-sec password-cache epa derived epg epg-config gnus-ut= il rmail
rmail-loaddefs text-property-search time-date mm-decode = mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailh= eader sendmail
rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail= -utils misearch
multi-isearch help-mode cl-loaddefs cl-lib apropo= s smerge-mode
vc-dispatcher vc-svn diff-mode easymenu easy-mmode = term/xterm xterm
elec-pair tooltip eldoc electric uniquify ediff-= hook vc-hooks
lisp-float-type mwheel term/ns-win ns-win ucs-norma= lize mule-util
term/common-win tool-bar dnd fontset image regexp-= opt fringe
tabulated-list replace newcomment text-mode elisp-mode= lisp-mode
prog-mode register page menu-bar rfn-eshadow isearch t= imer select
scroll-bar mouse jit-lock font-lock syntax facemenu f= ont-core
term/tty-colors frame cl-generic cham georgian utf-8-lan= g misc-lang
vietnamese tibetan thai tai-viet lao korean japanese = eucjp-ms cp51932
hebrew greek romanian slovak czech european ethi= opic indian cyrillic
chinese composite charscript charprop case-t= able epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer= cl-preloaded nadvice loaddefs
button faces cus-face macroexp fil= es text-properties overlay sha1 md5
base64 format env code-pages = mule custom widget hashtable-print-readable
backquote threads kqu= eue cocoa ns multi-tty make-network-process emacs)

Memory information:
((conses 16 56669 7188)
=C2=A0(sym= bols 48 6625 1)
=C2=A0(strings 32 17368 1666)
=C2=A0(st= ring-bytes 1 565596)
=C2=A0(vectors 16 7835)
=C2=A0(vec= tor-slots 8 78808 10720)
=C2=A0(floats 8 25 439)
=C2=A0= (intervals 56 860 4)
=C2=A0(buffers 992 14))

=
--0000000000005259920588a9b8df-- ------------=_1557947463-27461-1--