From unknown Tue Jun 24 13:57:56 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3564: 23.0.94; compose-region doc string Reply-To: "Drew Adams" , 3564@debbugs.gnu.org Resent-From: "Drew Adams" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 14 Jun 2009 19:35:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 3564 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.124500786830789 (code B ref -1); Sun, 14 Jun 2009 19:35:04 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 14 Jun 2009 19:31:08 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.9 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5EJV3jZ030783 for ; Sun, 14 Jun 2009 12:31:04 -0700 Received: from mail.gnu.org ([199.232.76.166]:50489 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MFvPz-0000rc-4s for emacs-pretest-bug@gnu.org; Sun, 14 Jun 2009 15:31:03 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MFvPx-0007uP-EX for emacs-pretest-bug@gnu.org; Sun, 14 Jun 2009 15:31:02 -0400 Received: from acsinet11.oracle.com ([141.146.126.233]:54100) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MFvPw-0007u9-N3 for emacs-pretest-bug@gnu.org; Sun, 14 Jun 2009 15:31:01 -0400 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by acsinet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n5EJVrtK007925 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 14 Jun 2009 19:31:54 GMT Received: from abhmt006.oracle.com (abhmt006.oracle.com [141.146.116.15]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n5EJV1jP023203 for ; Sun, 14 Jun 2009 19:31:01 GMT Received: from dradamslap1 (/141.144.160.38) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 14 Jun 2009 12:30:54 -0700 From: "Drew Adams" To: Date: Sun, 14 Jun 2009 12:30:54 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 Thread-Index: AcntJqJcOFkoqjQoQASVdZ6hM2KdvA== X-Source-IP: abhmt006.oracle.com [141.146.116.15] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090201.4A354FEF.0251:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) 1. Typo: "stricking" -> "striking". 2. Please add an explanation of what "overstriking" and "stacking" mean. In GNU Emacs 23.0.94.1 (i386-mingw-nt5.1.2600) of 2009-05-24 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4)' From unknown Tue Jun 24 13:57:56 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3564: 23.0.94; compose-region doc string Reply-To: Kenichi Handa , 3564@debbugs.gnu.org Resent-From: Kenichi Handa Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 15 Jun 2009 06:50:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3564 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3564-submit@emacsbugs.donarmstrong.com id=B3564.1245048189803 (code B ref 3564); Mon, 15 Jun 2009 06:50:04 +0000 Received: (at 3564) by emacsbugs.donarmstrong.com; 15 Jun 2009 06:43:09 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.6 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER, SPF_HELO_PASS autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx1.aist.go.jp (mx1.aist.go.jp [150.29.246.133]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5F6h4bQ000798 for <3564@emacsbugs.donarmstrong.com>; Sun, 14 Jun 2009 23:43:06 -0700 Received: from rqsmtp1.aist.go.jp (rqsmtp1.aist.go.jp [150.29.254.115]) by mx1.aist.go.jp with ESMTP id n5F6h2vI007959; Mon, 15 Jun 2009 15:43:02 +0900 (JST) env-from (handa@m17n.org) Received: from smtp3.aist.go.jp by rqsmtp1.aist.go.jp with ESMTP id n5F6h2BI006376; Mon, 15 Jun 2009 15:43:02 +0900 (JST) env-from (handa@m17n.org) Received: by smtp3.aist.go.jp with ESMTP id n5F6h20S016025; Mon, 15 Jun 2009 15:43:02 +0900 (JST) env-from (handa@m17n.org) Received: from handa by etlken with local (Exim 4.69) (envelope-from ) id 1MG5uI-0003m1-9A; Mon, 15 Jun 2009 15:43:02 +0900 From: Kenichi Handa To: Drew Adams , 3564@debbugs.gnu.org In-reply-to: (drew.adams@oracle.com) References: Message-Id: Date: Mon, 15 Jun 2009 15:43:02 +0900 In article , "Drew Adams" writes: > 1. Typo: "stricking" -> "striking". > 2. Please add an explanation of what "overstriking" and "stacking" > mean. How about this change? --- composite.el.~1.47.~ 2009-06-08 20:48:58.000000000 +0900 +++ composite.el 2009-06-15 15:39:21.000000000 +0900 @@ -185,8 +185,17 @@ (defun compose-region (start end &optional components modification-func) "Compose characters in the current region. -Characters are composed relatively, i.e. composed by overstricking or -stacking depending on ascent, descent and other properties. +Characters are composed relatively, i.e. composed by overstriking +or stacking depending on ascent, descent and other metrics values +of glyphs. + +For instance, if the region has three characters \"XYZ\", X is +regarded as BASE glyph, and Y is displayed: + (1) above BASE if Y's descent is not positive, + (2) below BASE if Y's ascent is not positive, + (3) over BASE (at the same position of BASE) otherwise. +and Z is displayed with the same rule while regarding the whole +XY glyphs as BASE. When called from a program, expects these four arguments. --- Kenichi Handa handa@m17n.org From unknown Tue Jun 24 13:57:56 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3564: 23.0.94; compose-region doc string Reply-To: "Drew Adams" , 3564@debbugs.gnu.org Resent-From: "Drew Adams" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 15 Jun 2009 13:20:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3564 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3564-submit@emacsbugs.donarmstrong.com id=B3564.124507168927403 (code B ref 3564); Mon, 15 Jun 2009 13:20:04 +0000 Received: (at 3564) by emacsbugs.donarmstrong.com; 15 Jun 2009 13:14:49 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.4 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from rgminet12.oracle.com (rcsinet12.oracle.com [148.87.113.124]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5FDEiEI027392 for <3564@emacsbugs.donarmstrong.com>; Mon, 15 Jun 2009 06:14:46 -0700 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rgminet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n5FDEMo7004093 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 15 Jun 2009 13:14:23 GMT Received: from abhmt008.oracle.com (abhmt008.oracle.com [141.146.116.17]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n5FDEfwK025625; Mon, 15 Jun 2009 13:14:41 GMT Received: from dradamslap1 (/141.144.160.38) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 15 Jun 2009 06:14:34 -0700 From: "Drew Adams" To: "'Kenichi Handa'" , <3564@debbugs.gnu.org> References: Date: Mon, 15 Jun 2009 06:14:37 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 Thread-Index: AcnthJNUfeZ1RzjSQsKXhS1H9nyMcAANeswQ X-Source-IP: abhmt008.oracle.com [141.146.116.17] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010205.4A36493B.0156:SCFSTAT5015188,ss=1,fgs=0 That helps a lot; thanks. See inline for English suggestions. But I'm ignorant of this area, so hopefully someone else will speak to the correct terminology to use - I don't know it. > From: Kenichi Handa Sent: Sunday, June 14, 2009 11:43 PM > +Characters are composed relatively, i.e. composed by overstriking > +or stacking depending on ascent, descent and other metrics values > +of glyphs. "other metrics" or "other metric values" > +For instance, if the region has three characters \"XYZ\", X is > +regarded as BASE glyph, and Y is displayed: > + (1) above BASE if Y's descent is not positive, > + (2) below BASE if Y's ascent is not positive, I wonder if "descent" and "ascent" shouldn't be "descender" and "ascender" or something like that? Need to check with someone who knows typography terminology, unless you're sure about "descent" and "ascent". > + (3) over BASE (at the same position of BASE) otherwise. "on BASE" or "at BASE" or "on top of BASE" or "at the BASE position" > +and Z is displayed with the same rule while regarding the whole > +XY glyphs as BASE. > > When called from a program, expects these four arguments. Sounds good. Without that, I understood nothing. Now, I understand a little. Thx. From unknown Tue Jun 24 13:57:56 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3564: 23.0.94; compose-region doc string Reply-To: Kenichi Handa , 3564@debbugs.gnu.org Resent-From: Kenichi Handa Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 16 Jun 2009 00:45:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3564 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3564-submit@emacsbugs.donarmstrong.com id=B3564.124511261016212 (code B ref 3564); Tue, 16 Jun 2009 00:45:04 +0000 Received: (at 3564) by emacsbugs.donarmstrong.com; 16 Jun 2009 00:36:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.6 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER, SPF_HELO_PASS autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx1.aist.go.jp (mx1.aist.go.jp [150.29.246.133]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5G0afea016207 for <3564@emacsbugs.donarmstrong.com>; Mon, 15 Jun 2009 17:36:47 -0700 Received: from rqsmtp1.aist.go.jp (rqsmtp1.aist.go.jp [150.29.254.115]) by mx1.aist.go.jp with ESMTP id n5G0aefh011981; Tue, 16 Jun 2009 09:36:40 +0900 (JST) env-from (handa@m17n.org) Received: from smtp1.aist.go.jp by rqsmtp1.aist.go.jp with ESMTP id n5G0aeF3021651; Tue, 16 Jun 2009 09:36:40 +0900 (JST) env-from (handa@m17n.org) Received: by smtp1.aist.go.jp with ESMTP id n5G0aeeU003637; Tue, 16 Jun 2009 09:36:40 +0900 (JST) env-from (handa@m17n.org) Received: from handa by etlken with local (Exim 4.69) (envelope-from ) id 1MGMfI-0006Ys-3d; Tue, 16 Jun 2009 09:36:40 +0900 From: Kenichi Handa To: "Drew Adams" CC: 3564@debbugs.gnu.org In-reply-to: (drew.adams@oracle.com) References: Message-Id: Date: Tue, 16 Jun 2009 09:36:40 +0900 In article , "Drew Adams" writes: > > +For instance, if the region has three characters \"XYZ\", X is > > +regarded as BASE glyph, and Y is displayed: > > + (1) above BASE if Y's descent is not positive, > > + (2) below BASE if Y's ascent is not positive, > I wonder if "descent" and "ascent" shouldn't be "descender" and "ascender" or > something like that? Need to check with someone who knows typography > terminology, unless you're sure about "descent" and "ascent". "descent" and "ascent" are commonly used term in glyph metrics. I added "value" after them for clarification. I've just committed the change while reflecting your other comments. --- Kenichi Handa handa@m17n.org From rgm@gnu.org Wed Nov 4 14:01:42 2009 Received: (at control) by emacsbugs.donarmstrong.com; 4 Nov 2009 22:01:42 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.8 required=4.0 tests=AWL,ONEWORD,VALID_BTS_CONTROL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nA4M1e7A002782 for ; Wed, 4 Nov 2009 14:01:42 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1N5nv9-0000E4-Ub; Wed, 04 Nov 2009 17:01:39 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19185.63939.653937.427902@fencepost.gnu.org> Date: Wed, 4 Nov 2009 17:01:39 -0500 From: Glenn Morris To: control Subject: control severity 3631 minor severity 3267 minor reassign 3267 emacsbugs.donarmstrong.com severity 3481 minor severity 3644 minor severity 3722 wishlist severity 4360 minor tags 3613 wontfix tags 2134 = severity 4731 minor severity 3849 wishlist close 3564 merge 4668 3227 tags 2792 wontfix minor severity 4433 minor severity 4668 minor severity 4562 minor severity 3934 minor severity 3856 minor severity 3801 minor severity 3615 minor severity 3599 minor severity 3598 minor severity 3575 minor severity 3566 minor severity 3550 minor severity 3549 minor severity 3527 minor severity 3525 minor severity 3524 minor severity 3523 minor severity 3519 minor severity 3509 minor severity 3503 minor severity 3393 minor severity 3371 minor severity 3320 minor severity 3313 minor severity 3249 minor severity 3227 minor severity 3138 minor severity 3135 minor severity 3137 minor severity 3052 minor severity 3042 minor severity 2974 minor severity 2946 minor severity 2792 minor severity 1749 minor severity 1375 minor severity 1144 minor