GNU bug report logs - #3564
23.0.94; compose-region doc string

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 3564 in the body.
You can then email your comments to 3564 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <emacs-pretest-bug <at> gnu.org>
Subject: 23.0.94; compose-region doc string
Date: Sun, 14 Jun 2009 12:30:54 -0700

1. Typo: "stricking" -> "striking".
 
2. Please add an explanation of what "overstriking" and "stacking"
mean.
 

In GNU Emacs 23.0.94.1 (i386-mingw-nt5.1.2600)
 of 2009-05-24 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'
 

Message #10 received at 3564 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Kenichi Handa <handa <at> m17n.org>
To: Drew Adams <drew.adams <at> oracle.com>, 3564 <at> debbugs.gnu.org
Subject: Re: bug#3564: 23.0.94; compose-region doc string
Date: Mon, 15 Jun 2009 15:43:02 +0900

In article <FA8E5A4812B64B7AAAC196EE35260545 <at> us.oracle.com>, "Drew Adams" <drew.adams <at> oracle.com> writes:

> 1. Typo: "stricking" -> "striking".
> 2. Please add an explanation of what "overstriking" and "stacking"
> mean.
 
How about this change?

--- composite.el.~1.47.~	2009-06-08 20:48:58.000000000 +0900
+++ composite.el	2009-06-15 15:39:21.000000000 +0900
@@ -185,8 +185,17 @@
 (defun compose-region (start end &optional components modification-func)
   "Compose characters in the current region.
 
-Characters are composed relatively, i.e. composed by overstricking or
-stacking depending on ascent, descent and other properties.
+Characters are composed relatively, i.e. composed by overstriking
+or stacking depending on ascent, descent and other metrics values
+of glyphs.
+
+For instance, if the region has three characters \"XYZ\", X is
+regarded as BASE glyph, and Y is displayed:
+  (1) above BASE if Y's descent is not positive,
+  (2) below BASE if Y's ascent is not positive,
+  (3) over BASE (at the same position of BASE) otherwise.
+and Z is displayed with the same rule while regarding the whole
+XY glyphs as BASE.
 
 When called from a program, expects these four arguments.
 
---
Kenichi Handa
handa <at> m17n.org

Message #15 received at 3564 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Kenichi Handa'" <handa <at> m17n.org>, <3564 <at> debbugs.gnu.org>
Subject: RE: bug#3564: 23.0.94; compose-region doc string
Date: Mon, 15 Jun 2009 06:14:37 -0700

That helps a lot; thanks.

See inline for English suggestions. But I'm ignorant of this area, so hopefully
someone else will speak to the correct terminology to use - I don't know it.

> From: Kenichi Handa Sent: Sunday, June 14, 2009 11:43 PM
> +Characters are composed relatively, i.e. composed by overstriking
> +or stacking depending on ascent, descent and other metrics values
> +of glyphs.

"other metrics" or "other metric values"

> +For instance, if the region has three characters \"XYZ\", X is
> +regarded as BASE glyph, and Y is displayed:
> +  (1) above BASE if Y's descent is not positive,
> +  (2) below BASE if Y's ascent is not positive,

I wonder if "descent" and "ascent" shouldn't be "descender" and "ascender" or
something like that? Need to check with someone who knows typography
terminology, unless you're sure about "descent" and "ascent".

> +  (3) over BASE (at the same position of BASE) otherwise.

"on BASE" or "at BASE" or "on top of BASE" or "at the BASE position"

> +and Z is displayed with the same rule while regarding the whole
> +XY glyphs as BASE.
>  
>  When called from a program, expects these four arguments.

Sounds good. Without that, I understood nothing. Now, I understand a little.
Thx.

Message #20 received at 3564 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Kenichi Handa <handa <at> m17n.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 3564 <at> debbugs.gnu.org
Subject: Re: bug#3564: 23.0.94; compose-region doc string
Date: Tue, 16 Jun 2009 09:36:40 +0900

In article <AAD7FAEDDC0649708F012EA7C77B39BF <at> us.oracle.com>, "Drew Adams" <drew.adams <at> oracle.com> writes:

> > +For instance, if the region has three characters \"XYZ\", X is
> > +regarded as BASE glyph, and Y is displayed:
> > +  (1) above BASE if Y's descent is not positive,
> > +  (2) below BASE if Y's ascent is not positive,

> I wonder if "descent" and "ascent" shouldn't be "descender" and "ascender" or
> something like that? Need to check with someone who knows typography
> terminology, unless you're sure about "descent" and "ascent".

"descent" and "ascent" are commonly used term in glyph
metrics.  I added "value" after them for clarification.

I've just committed the change while reflecting your other
comments.

---
Kenichi Handa
handa <at> m17n.org

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.