Subject: [bug#35627] [PATCH] Add golang-importer

From: nly <[email-masked]>
Date: Wed, 08 May 2019 11:40:55 +0530

Hi. I've attached some patches for a golang importer

To use:
1. (load "golang.scm")
2. (define gopkg (make-go-package go-name*))
3. (package-sexp gopkg)
;; go-name looks like "golang.org/auth/pkg"

;; TODO
1. reliant on github urls
2. extract license
3. Recursive?

Suggestions welcome

Thanks,
Amar

>From 847ffd151c1a46eaa2d1f764bf78ba72ae71ed08 Mon Sep 17 00:00:00 2001
From: Amar Singh <[email-masked]>
Date: Tue, 30 Apr 2019 23:17:51 +0530
Subject: [PATCH 01/10] Import: Add make-go-package.

* guix/import/golang.scm (make-go-package): New variable.

Signed-off-by: Amar Singh <[email-masked]>
---
 guix/import/golang.scm | 121 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 121 insertions(+)
 create mode 100644 guix/import/golang.scm

diff --git a/guix/import/golang.scm b/guix/import/golang.scm
new file mode 100644
index 0000000000..ad822f6b69
--- /dev/null
+++ b/guix/import/golang.scm
@@ -0,0 +1,121 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2019 by Amar Singh <[email-masked]>
+;;;
+;;; This file is part of GNU Guix.
+;;; 
+;;; This program is free software: you can redistribute it and/or modify
+;;; it under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation, either version 3 of the License, or
+;;; (at your option) any later version.
+;;; 
+;;; This program is distributed in the hope that it will be useful,
+;;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;; 
+;;; You should have received a copy of the GNU General Public License
+;;; along with this program.  If not, see <https://www.gnu.org/licenses/>.
+
+(define-module (guix import golang))
+(use-modules
+ (guix import github)  ;; latest-release
+ (guix download)       ;; download-to-store
+ ((guix import utils) #:prefix utils:)   ;; hash
+ (guix packages)       ;; packages
+ (guix build-system go)  ;; go-build-system
+ (guix store)          ;; with-store
+ (gnu packages golang) ;; inherit (simple) go package
+ (ice-9 textual-ports) ;; to parse readme.md
+ )
+
+(define go-name* "github.com/gohugoio/hugo") ;; for tests
+
+(define (go-name->url go-name)
+  (string-append "https://" go-name))
+
+(define (go-name->tarball go-name version)
+  (string-append (go-name->url go-name) "/archive/v" version
+                 ".tar.gz"))
+
+;;; Possible remove @@ if upstream exports the symbols
+(define (go-name->name go-name)
+  ((@@ (guix import github) github-repository)
+   (go-name->url go-name)))
+
+;;; Slow; accesses the network
+(define (latest-release go-name)
+  ((@@ (guix import github) latest-released-version)
+   (go-name->url go-name)
+   (go-name->name go-name)))
+
+;;; Slow; downloads the url from network;
+(define (url->store url)
+  (with-store store
+    (download-to-store store
+                       url)))
+;;; Slow; download the source tarball from network and returns base32
+;;; nix-hash
+(define (go-name->sha256 go-name version)
+  (utils:guix-hash-url (url->store (go-name->tarball go-name version))))
+
+;;; Towards go-name->synopsis,description
+(define (go-name->readme go-name)
+  (string-append "https://raw.githubusercontent.com"
+                 (substring go-name
+                            (string-length "github.com"))
+                 "/master/"
+                 "README.md"))
+
+;;; Slow; network access
+(define (go-name->readme-string go-name)
+  "Slow; network access."
+  (call-with-input-file (url->store (go-name->readme go-name))
+    (lambda (port) (get-string-n port 4096))))
+
+;;; Maybe try to match the first sentence.
+(define (go-name->synopsis go-name readme-string)
+  (string-append (go-name->name go-name)
+                 (substring readme-string 0 100)))
+
+;;; Maybe try to match the the next two sentences.
+(define (go-name->description go-name readme-string)
+  (string-append (go-name->name go-name)
+                 (substring readme-string 100 300)))
+
+(define-public (make-go-package go-name)
+  ;; Do the expensive operations only once; query network for latest version
+  (let* ((version (latest-release go-name))
+         (sha256 (go-name->sha256 go-name version))
+         (readme-string (go-name->readme-string go-name)))
+    (package (inherit go-github-com-alsm-ioprogress)
+      (name (string-append "go-" (go-name->name go-name)))
+      (version version)
+      (source (origin (method url-fetch)
+                      (uri (go-name->tarball go-name version))
+                      (sha256 (base32
+                               sha256))))
+      (home-page (go-name->url go-name))
+      (build-system go-build-system)
+      (arguments
+       `(#:import-path ,go-name))
+      ;; TODO: inputs
+      (synopsis
+       (go-name->synopsis go-name readme-string))
+      (description (go-name->description go-name readme-string))
+      ;; TODO: license
+      )))
+
+;;; STATUS
+;;; 1. latest-release  DONE
+;;; 1.b latest-commit PENDING/STALLED
+;;; 2. go-name->name DONE
+;;; 4. go-name->url DONE
+;;; 4.b go-name->tarball DONE
+;;; 5. go-name->sha256 (go-name version) DONE
+;;; 6. go-name->synopsis DONE
+;;; 7. go-name->description DONE
+;;; 6-7.b try to extract sentences. TODO
+;;; 8. go-name->license TODO
+;;; 9. go-name->inputs TODO
+
+;;; golang.scm ends here
-- 
2.21.0

>From 98fc69e26354ddf8a7111fbe6560d998d01e4415 Mon Sep 17 00:00:00 2001
From: Amar Singh <[email-masked]>
Date: Wed, 1 May 2019 04:13:05 +0530
Subject: [PATCH 02/10] golang Import: formatting

Signed-off-by: Amar Singh <[email-masked]>
---
 guix/import/golang.scm | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/guix/import/golang.scm b/guix/import/golang.scm
index ad822f6b69..f9872ee8e3 100644
--- a/guix/import/golang.scm
+++ b/guix/import/golang.scm
@@ -88,20 +88,23 @@
          (sha256 (go-name->sha256 go-name version))
          (readme-string (go-name->readme-string go-name)))
     (package (inherit go-github-com-alsm-ioprogress)
-      (name (string-append "go-" (go-name->name go-name)))
+      (name (string-append "go-"
+                           (go-name->name go-name)))
       (version version)
       (source (origin (method url-fetch)
-                      (uri (go-name->tarball go-name version))
-                      (sha256 (base32
-                               sha256))))
+                      (uri (go-name->tarball go-name
+                                             version))
+                      (sha256 (base32 sha256))))
       (home-page (go-name->url go-name))
       (build-system go-build-system)
       (arguments
        `(#:import-path ,go-name))
       ;; TODO: inputs
       (synopsis
-       (go-name->synopsis go-name readme-string))
-      (description (go-name->description go-name readme-string))
+       (go-name->synopsis go-name
+                          readme-string))
+      (description (go-name->description go-name
+                                         readme-string))
       ;; TODO: license
       )))
 
@@ -117,5 +120,6 @@
 ;;; 6-7.b try to extract sentences. TODO
 ;;; 8. go-name->license TODO
 ;;; 9. go-name->inputs TODO
+;;; 10. package-print TODO
 
 ;;; golang.scm ends here
-- 
2.21.0

>From 9cb6242b32f640887a1a7516ae469a4b6bee97cc Mon Sep 17 00:00:00 2001
From: Amar Singh <[email-masked]>
Date: Wed, 1 May 2019 04:13:40 +0530
Subject: [PATCH 03/10] Golang-Import: Add go-name->inputs.

* guix/import/golang.scm (go-name->inputs): New variable.

Signed-off-by: Amar Singh <[email-masked]>
---
 guix/import/golang.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/guix/import/golang.scm b/guix/import/golang.scm
index f9872ee8e3..e11d1c2230 100644
--- a/guix/import/golang.scm
+++ b/guix/import/golang.scm
@@ -82,6 +82,14 @@
   (string-append (go-name->name go-name)
                  (substring readme-string 100 300)))
 
+;;; go list -f '{{ join .Deps "\n" }}',recursively find dependencies
+;;; go list -f '{{ join .Imports "\n" }}' ,non recursive
+(define (go-name->inputs go-name)
+  (let ((tmp (tmpnam)))
+    (and (zero? (system (string-append "go list -f '{{ join .Deps \"\\n\" }}'" " "
+                                       go-name " > " tmp)))
+         (call-with-input-file tmp get-string-all))))
+
 (define-public (make-go-package go-name)
   ;; Do the expensive operations only once; query network for latest version
   (let* ((version (latest-release go-name))
-- 
2.21.0

>From 8172227afc651ddfcdfa0da77c7c7bf72f59fcf8 Mon Sep 17 00:00:00 2001
From: Amar Singh <[email-masked]>
Date: Wed, 1 May 2019 08:02:28 +0530
Subject: [PATCH 04/10] Golang-Import: Add package-sexp; go-name->inputs.
 (formatting)

* guix/import/golang.scm (package-sexp; go-name->inputs): New variable.

Signed-off-by: Amar Singh <[email-masked]>
---
 guix/import/golang.scm | 92 ++++++++++++++++++++++++++++++++++--------
 1 file changed, 75 insertions(+), 17 deletions(-)

diff --git a/guix/import/golang.scm b/guix/import/golang.scm
index e11d1c2230..e6ef62a3b4 100644
--- a/guix/import/golang.scm
+++ b/guix/import/golang.scm
@@ -22,6 +22,7 @@
  (guix download)       ;; download-to-store
  ((guix import utils) #:prefix utils:)   ;; hash
  (guix packages)       ;; packages
+ (guix build-system)   ;; build-system printer
  (guix build-system go)  ;; go-build-system
  (guix store)          ;; with-store
  (gnu packages golang) ;; inherit (simple) go package
@@ -86,9 +87,23 @@
 ;;; go list -f '{{ join .Imports "\n" }}' ,non recursive
 (define (go-name->inputs go-name)
   (let ((tmp (tmpnam)))
-    (and (zero? (system (string-append "go list -f '{{ join .Deps \"\\n\" }}'" " "
-                                       go-name " > " tmp)))
-         (call-with-input-file tmp get-string-all))))
+    (and (zero? (system (string-append
+                         "go list -f '{{ join .Deps \"\\n\" }}'"
+                         " " go-name " > " tmp)))
+         (string-split (string-trim-both (call-with-input-file tmp get-string-all))
+                       (string->char-set "\n")))))
+
+;;; For inputs
+(define (alist-sexp alist)
+  (let ((magic (lambda (x)
+                 (list x
+                       (string->symbol (string-append x))))))
+    (if (and (list? alist) (not (equal? '() alist)))
+        (map magic
+             (if (list? (car alist))
+                 (map car alist)
+                 alist))
+        '())))
 
 (define-public (make-go-package go-name)
   ;; Do the expensive operations only once; query network for latest version
@@ -96,26 +111,67 @@
          (sha256 (go-name->sha256 go-name version))
          (readme-string (go-name->readme-string go-name)))
     (package (inherit go-github-com-alsm-ioprogress)
-      (name (string-append "go-"
-                           (go-name->name go-name)))
+      (name
+       (string-append "go-" go-name))
       (version version)
-      (source (origin (method url-fetch)
-                      (uri (go-name->tarball go-name
-                                             version))
+      (source
+       (origin (method url-fetch)
+                      (uri (go-name->tarball go-name version))
                       (sha256 (base32 sha256))))
-      (home-page (go-name->url go-name))
-      (build-system go-build-system)
+      (home-page
+       (go-name->url go-name))
+      (build-system
+        go-build-system)
       (arguments
        `(#:import-path ,go-name))
-      ;; TODO: inputs
+      ;; TODO: make inputs into (unquote ..) form
+      (inputs
+       (alist-sexp (go-name->inputs go-name)))
       (synopsis
-       (go-name->synopsis go-name
-                          readme-string))
-      (description (go-name->description go-name
-                                         readme-string))
+       (go-name->synopsis go-name readme-string))
+      (description
+       (go-name->description go-name readme-string))
       ;; TODO: license
       )))
 
+(define (filter-newlines string)
+  (string-filter (lambda (x) (not (equal? #\ x))) string))
+
+;;; Ask the upstream to export variable?
+(define bv->nix-base32 (@@ (guix packages)
+                           bytevector->nix-base32-string))
+
+(define (origin-sexp origin)
+  `(origin
+     (method url-fetch)
+     (uri ,(origin-uri origin))
+     (sha256 (base32 ,(bv->nix-base32 (origin-sha256 origin))))
+     (file-name ,(origin-file-name origin))
+     (patches ,(origin-patches origin))
+     (snippet ,(origin-snippet origin))
+     (patch-flags ,(origin-patch-flags origin))
+     (patch-inputs ,(origin-patch-inputs origin))
+     (modules ,(origin-modules origin))
+     (patch-guile ,(origin-patch-guile origin))))
+
+(define (build-system-sexp build-system)
+  (symbol-append (build-system-name build-system) '-build-system))
+
+(define-public (package-sexp package)
+  `(package
+     (name ,(package-name package))
+     (version ,(package-version package))
+     (source ,(origin-sexp (package-source package)))
+     (home-page ,(package-home-page package))
+     (build-system ,(build-system-sexp (package-build-system package)))
+     (arguments ,(package-arguments package))
+     (synopsis ,(filter-newlines (package-synopsis package)))
+     (description ,(filter-newlines (package-description package)))
+     (inputs ,(alist-sexp (package-inputs package)))
+     (native-inputs ,(alist-sexp (package-native-inputs package)))
+     (propagated-inputs ,(alist-sexp (package-propagated-inputs package)))))
+
+
 ;;; STATUS
 ;;; 1. latest-release  DONE
 ;;; 1.b latest-commit PENDING/STALLED
@@ -127,7 +183,9 @@
 ;;; 7. go-name->description DONE
 ;;; 6-7.b try to extract sentences. TODO
 ;;; 8. go-name->license TODO
-;;; 9. go-name->inputs TODO
-;;; 10. package-print TODO
+;;; 9. go-name->inputs DONE
+;;; 9.b. inputs alist TODO
+;;; 10. package-sexp DONE
+;;; 10.a origin-sexp DONE
 
 ;;; golang.scm ends here
-- 
2.21.0

>From df7d38c18de670d71e829408d0b7e5b6666b5564 Mon Sep 17 00:00:00 2001
From: Amar Singh <[email-masked]>
Date: Thu, 2 May 2019 00:38:56 +0530
Subject: [PATCH 05/10] Removed: alist-sexp; Added: shell-command;
 go-name->guix-name

Use-Modules: (ice-9 popen) (web uri) (srfi srfi-26)
Export: go-name*;
Add: string-replace-substrings; shell-command; string->license;
     format-inputs;
Rename: go-name->name TO go-name->guix-name
Memoize: latest-release; url->store; go-name->sha256
         go-name->readme-string;
Remove: alist-sexp

Signed-off-by: Amar Singh <[email-masked]>
---
 guix/import/golang.scm | 150 +++++++++++++++++++++++------------------
 1 file changed, 85 insertions(+), 65 deletions(-)

diff --git a/guix/import/golang.scm b/guix/import/golang.scm
index e6ef62a3b4..e0ffca4b42 100644
--- a/guix/import/golang.scm
+++ b/guix/import/golang.scm
@@ -2,23 +2,27 @@
 ;;; Copyright © 2019 by Amar Singh <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
-;;; 
+;;;
 ;;; This program is free software: you can redistribute it and/or modify
 ;;; it under the terms of the GNU General Public License as published by
 ;;; the Free Software Foundation, either version 3 of the License, or
 ;;; (at your option) any later version.
-;;; 
+;;;
 ;;; This program is distributed in the hope that it will be useful,
 ;;; but WITHOUT ANY WARRANTY; without even the implied warranty of
 ;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 ;;; GNU General Public License for more details.
-;;; 
+;;;
 ;;; You should have received a copy of the GNU General Public License
 ;;; along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
 (define-module (guix import golang))
 (use-modules
+ (srfi srfi-1) ;; fold
+ (ice-9 rdelim) ;; read-string
  (guix import github)  ;; latest-release
+ (guix utils) ;; string-replace-substring
+ (guix memoization)        ;; memoize network operations
  (guix download)       ;; download-to-store
  ((guix import utils) #:prefix utils:)   ;; hash
  (guix packages)       ;; packages
@@ -27,86 +31,102 @@
  (guix store)          ;; with-store
  (gnu packages golang) ;; inherit (simple) go package
  (ice-9 textual-ports) ;; to parse readme.md
+ (ice-9 popen) ;; open-input-ouput-pipe
+ (web uri) ;; uri->string
+ (srfi srfi-26) ;; cut
  )
 
-(define go-name* "github.com/gohugoio/hugo") ;; for tests
+(define-public go-name* "github.com/gohugoio/hugo") ;; for tests
 
-(define (go-name->url go-name)
-  (string-append "https://" go-name))
+(define* (go-name->url go-name #:rest args)
+  (if (string-contains go-name ".")
+      (uri->string (string->uri (apply string-append
+                                       "https://" go-name args)))
+      #f))
 
 (define (go-name->tarball go-name version)
-  (string-append (go-name->url go-name) "/archive/v" version
-                 ".tar.gz"))
+  (go-name->url go-name "/archive/v"
+                version ".tar.gz"))
+
+(define* (string-replace-substrings string substrings
+                                    #:optional (replacement "-"))
+  (if (null-list? substrings)
+      string
+      ((cut string-replace-substring <> (car substrings) replacement)
+       (string-replace-substrings string (cdr substrings)))))
 
 ;;; Possible remove @@ if upstream exports the symbols
-(define (go-name->name go-name)
-  ((@@ (guix import github) github-repository)
-   (go-name->url go-name)))
-
-;;; Slow; accesses the network
-(define (latest-release go-name)
-  ((@@ (guix import github) latest-released-version)
-   (go-name->url go-name)
-   (go-name->name go-name)))
-
-;;; Slow; downloads the url from network;
-(define (url->store url)
-  (with-store store
-    (download-to-store store
-                       url)))
-;;; Slow; download the source tarball from network and returns base32
-;;; nix-hash
+(define (go-name->guix-name go-name)
+  (string-append "go-"
+                 (string-replace-substrings go-name '("." "/") "-")))
+
+;;; Slow; accesses the network; memoized
+(define latest-release
+  (memoize
+   (lambda (go-name)
+     ((@@ (guix import github) latest-released-version)
+      (go-name->url go-name)
+      (go-name->guix-name go-name)))))
+
+;;; Slow; downloads the url from network; memoized
+(define url->store
+  (@@ (guix import cran) download))
+
+;;; Slow; download src tarball from network, returns base32 nix-hash;
+;;; memoized
 (define (go-name->sha256 go-name version)
   (utils:guix-hash-url (url->store (go-name->tarball go-name version))))
 
-;;; Towards go-name->synopsis,description
-(define (go-name->readme go-name)
-  (string-append "https://raw.githubusercontent.com"
-                 (substring go-name
-                            (string-length "github.com"))
-                 "/master/"
-                 "README.md"))
-
-;;; Slow; network access
-(define (go-name->readme-string go-name)
-  "Slow; network access."
-  (call-with-input-file (url->store (go-name->readme go-name))
-    (lambda (port) (get-string-n port 4096))))
+;;; Slow; network access; memoized
+(define go-name->readme-string
+  (memoize
+   (lambda (go-name)
+     (define (go-name->readme go-name)
+       (go-name->url "raw.githubusercontent.com"
+                     ;; TODO, detect the domain
+                     (substring go-name
+                                (string-length "github.com"))
+                     "/master/"
+                     "README.md"))
+     (call-with-input-file (url->store (go-name->readme go-name))
+       read-string))))
 
 ;;; Maybe try to match the first sentence.
-(define (go-name->synopsis go-name readme-string)
-  (string-append (go-name->name go-name)
-                 (substring readme-string 0 100)))
+(define (go-name->synopsis go-name)
+  (substring (go-name->readme-string go-name) 0 100))
 
 ;;; Maybe try to match the the next two sentences.
-(define (go-name->description go-name readme-string)
-  (string-append (go-name->name go-name)
-                 (substring readme-string 100 300)))
-
-;;; go list -f '{{ join .Deps "\n" }}',recursively find dependencies
-;;; go list -f '{{ join .Imports "\n" }}' ,non recursive
-(define (go-name->inputs go-name)
-  (let ((tmp (tmpnam)))
-    (and (zero? (system (string-append
-                         "go list -f '{{ join .Deps \"\\n\" }}'"
-                         " " go-name " > " tmp)))
-         (string-split (string-trim-both (call-with-input-file tmp get-string-all))
-                       (string->char-set "\n")))))
+(define (go-name->description go-name)
+  (substring (go-name->readme-string go-name) 100 300))
+(go-name->description go-name*)
+
+(define shell-command
+  (lambda* (command #:rest args)
+    (let* ((cmd (string-join (cons command (delete #f (delete '() args))) " "))
+           (port (open-input-output-pipe cmd))
+           (result (read-string port))
+           (exit-code (close-pipe port)))
+      (and (zero? exit-code)
+           (string-split (string-trim-right result) #\newline)))))
+
+(define go-name->inputs
+  (lambda (go-name)
+    (let ((recursive-depends "-f '{{ join .Deps \"\\n\" }}'")
+          (direct-depends "-f '{{ join .Imports \"\\n\" }}'")
+          (go-command (car (shell-command "which go"))))
+      (shell-command go-command "list" direct-depends go-name))))
+
+;;; License
+(define (string->license license-string)
+  ((@@ (guix import cran) string->license) (string-upcase license-string)))
 
 ;;; For inputs
-(define (alist-sexp alist)
-  (let ((magic (lambda (x)
-                 (list x
-                       (string->symbol (string-append x))))))
-    (if (and (list? alist) (not (equal? '() alist)))
-        (map magic
-             (if (list? (car alist))
-                 (map car alist)
-                 alist))
-        '())))
+(define format-inputs
+  (@@ (guix import cran) format-inputs))
 
 (define-public (make-go-package go-name)
-  ;; Do the expensive operations only once; query network for latest version
+  ;; Do the expensive operations only once; query network for latest
+  ;; version
   (let* ((version (latest-release go-name))
          (sha256 (go-name->sha256 go-name version))
          (readme-string (go-name->readme-string go-name)))
-- 
2.21.0

>From 912e6fb0d35b43e3d1cf540702fa1905e704ce93 Mon Sep 17 00:00:00 2001
From: Amar Singh <[email-masked]>
Date: Thu, 2 May 2019 00:46:56 +0530
Subject: [PATCH 06/10] Formatting

Use: format-inputs instead of alist-sexp

Signed-off-by: Amar Singh <[email-masked]>
---
 guix/import/golang.scm | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/guix/import/golang.scm b/guix/import/golang.scm
index e0ffca4b42..c0679990e1 100644
--- a/guix/import/golang.scm
+++ b/guix/import/golang.scm
@@ -136,8 +136,8 @@
       (version version)
       (source
        (origin (method url-fetch)
-                      (uri (go-name->tarball go-name version))
-                      (sha256 (base32 sha256))))
+               (uri (go-name->tarball go-name version))
+               (sha256 (base32 sha256))))
       (home-page
        (go-name->url go-name))
       (build-system
@@ -146,16 +146,14 @@
        `(#:import-path ,go-name))
       ;; TODO: make inputs into (unquote ..) form
       (inputs
-       (alist-sexp (go-name->inputs go-name)))
-      (synopsis
-       (go-name->synopsis go-name readme-string))
-      (description
-       (go-name->description go-name readme-string))
+       (format-inputs (map go-name->guix-name (go-name->inputs go-name))))
+      (synopsis (go-name->synopsis go-name))
+      (description (go-name->description go-name))
       ;; TODO: license
       )))
 
 (define (filter-newlines string)
-  (string-filter (lambda (x) (not (equal? #\ x))) string))
+  (string-filter (lambda (x) (not (equal? x #\newline))) string))
 
 ;;; Ask the upstream to export variable?
 (define bv->nix-base32 (@@ (guix packages)
-- 
2.21.0

>From 3132d5e9a7293ba934111079617498ab68a61c89 Mon Sep 17 00:00:00 2001
From: Amar Singh <[email-masked]>
Date: Thu, 2 May 2019 00:48:06 +0530
Subject: [PATCH 07/10] Formatting

Update: TODO License; Meaningful Description and Synopsis

Signed-off-by: Amar Singh <[email-masked]>
---
 guix/import/golang.scm | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/guix/import/golang.scm b/guix/import/golang.scm
index c0679990e1..319807df88 100644
--- a/guix/import/golang.scm
+++ b/guix/import/golang.scm
@@ -185,24 +185,26 @@
      (arguments ,(package-arguments package))
      (synopsis ,(filter-newlines (package-synopsis package)))
      (description ,(filter-newlines (package-description package)))
-     (inputs ,(alist-sexp (package-inputs package)))
-     (native-inputs ,(alist-sexp (package-native-inputs package)))
-     (propagated-inputs ,(alist-sexp (package-propagated-inputs package)))))
+     (inputs ,(format-inputs (map car (package-inputs package))))
+     (native-inputs ,(format-inputs (map car (package-native-inputs package))))
+     (propagated-inputs ,(format-inputs (map car (package-propagated-inputs package))))))

 ;;; STATUS
 ;;; 1. latest-release  DONE
 ;;; 1.b latest-commit PENDING/STALLED
-;;; 2. go-name->name DONE
+;;; 2. go-name->guix-name DONE
+;;; 2.b style go-github-com-user-project TODO
 ;;; 4. go-name->url DONE
 ;;; 4.b go-name->tarball DONE
 ;;; 5. go-name->sha256 (go-name version) DONE
 ;;; 6. go-name->synopsis DONE
 ;;; 7. go-name->description DONE
+;;; 4-7.b. Memoize, network procedures DONE
 ;;; 6-7.b try to extract sentences. TODO
 ;;; 8. go-name->license TODO
 ;;; 9. go-name->inputs DONE
-;;; 9.b. inputs alist TODO
+;;; 9.b. inputs alist DONE
 ;;; 10. package-sexp DONE
 ;;; 10.a origin-sexp DONE
 
-- 
2.21.0

>From 65814de01030fdbf1d9d4c349f5149d645dae299 Mon Sep 17 00:00:00 2001
From: Amar Singh <[email-masked]>
Date: Thu, 2 May 2019 01:23:04 +0530
Subject: [PATCH 08/10] Mark DONE: go-name->guix-name

Signed-off-by: Amar Singh <[email-masked]>
---
 guix/import/golang.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/import/golang.scm b/guix/import/golang.scm
index 319807df88..2f0aca3331 100644
--- a/guix/import/golang.scm
+++ b/guix/import/golang.scm
@@ -194,7 +194,7 @@
 ;;; 1. latest-release  DONE
 ;;; 1.b latest-commit PENDING/STALLED
 ;;; 2. go-name->guix-name DONE
-;;; 2.b style go-github-com-user-project TODO
+;;; 2.b style go-github-com-user-project DONE
 ;;; 4. go-name->url DONE
 ;;; 4.b go-name->tarball DONE
 ;;; 5. go-name->sha256 (go-name version) DONE
-- 
2.21.0

>From 1e5386ca1369dc45390203819a3e7179381dbad2 Mon Sep 17 00:00:00 2001
From: Amar Singh <[email-masked]>
Date: Thu, 2 May 2019 01:31:43 +0530
Subject: [PATCH 09/10] Move todo to top, Add usage instructions

Fix: Also removed a leftover test expression

Signed-off-by: Amar Singh <[email-masked]>
---
 guix/import/golang.scm | 49 ++++++++++++++++++++++--------------------
 1 file changed, 26 insertions(+), 23 deletions(-)

diff --git a/guix/import/golang.scm b/guix/import/golang.scm
index 2f0aca3331..3eb74d4984 100644
--- a/guix/import/golang.scm
+++ b/guix/import/golang.scm
@@ -36,6 +36,30 @@
  (srfi srfi-26) ;; cut
  )
 
+;;; To use, simply:
+;;; 1. (load "golang.scm")
+;;; 2. (define go-package (make-package go-name*))
+;;; 3. (package-sexp go-package)
+
+;;; STATUS
+;;; 1. latest-release  DONE
+;;; 1.b latest-commit PENDING/STALLED
+;;; 2. go-name->guix-name DONE
+;;; 2.b style go-github-com-user-project DONE
+;;; 4. go-name->url DONE
+;;; 4.b go-name->tarball DONE
+;;; 5. go-name->sha256 (go-name version) DONE
+;;; 6. go-name->synopsis DONE
+;;; 7. go-name->description DONE
+;;; 4-7.b. Memoize, network procedures DONE
+;;; 6-7.b try to extract sentences. TODO
+;;; 8. go-name->license TODO
+;;; 9. go-name->inputs DONE
+;;; 9.b. inputs alist DONE
+;;; 10. package-sexp DONE
+;;; 10.a origin-sexp DONE
+;;; 11. Package Builds TODO
+
 (define-public go-name* "github.com/gohugoio/hugo") ;; for tests
 
 (define* (go-name->url go-name #:rest args)
@@ -91,14 +115,13 @@
      (call-with-input-file (url->store (go-name->readme go-name))
        read-string))))
 
-;;; Maybe try to match the first sentence.
+;;; TODO: try to match the first sentence.
 (define (go-name->synopsis go-name)
   (substring (go-name->readme-string go-name) 0 100))
 
-;;; Maybe try to match the the next two sentences.
+;;; TODO: try to match the the next two sentences.
 (define (go-name->description go-name)
   (substring (go-name->readme-string go-name) 100 300))
-(go-name->description go-name*)
 
 (define shell-command
   (lambda* (command #:rest args)
@@ -155,7 +178,6 @@
 (define (filter-newlines string)
   (string-filter (lambda (x) (not (equal? x #\newline))) string))
 
-;;; Ask the upstream to export variable?
 (define bv->nix-base32 (@@ (guix packages)
                            bytevector->nix-base32-string))
 
@@ -189,23 +211,4 @@
      (native-inputs ,(format-inputs (map car (package-native-inputs package))))
      (propagated-inputs ,(format-inputs (map car (package-propagated-inputs package))))))
 
-
-;;; STATUS
-;;; 1. latest-release  DONE
-;;; 1.b latest-commit PENDING/STALLED
-;;; 2. go-name->guix-name DONE
-;;; 2.b style go-github-com-user-project DONE
-;;; 4. go-name->url DONE
-;;; 4.b go-name->tarball DONE
-;;; 5. go-name->sha256 (go-name version) DONE
-;;; 6. go-name->synopsis DONE
-;;; 7. go-name->description DONE
-;;; 4-7.b. Memoize, network procedures DONE
-;;; 6-7.b try to extract sentences. TODO
-;;; 8. go-name->license TODO
-;;; 9. go-name->inputs DONE
-;;; 9.b. inputs alist DONE
-;;; 10. package-sexp DONE
-;;; 10.a origin-sexp DONE
-
 ;;; golang.scm ends here
-- 
2.21.0

>From 05b03042d1bd20969ff8d352372e3a9e58977276 Mon Sep 17 00:00:00 2001
From: Amar Singh <[email-masked]>
Date: Thu, 2 May 2019 19:52:51 +0530
Subject: [PATCH 10/10] Bootstrap: don't use (gnu packages golang)

---
 guix/import/golang.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/guix/import/golang.scm b/guix/import/golang.scm
index 3eb74d4984..b51d496602 100644
--- a/guix/import/golang.scm
+++ b/guix/import/golang.scm
@@ -26,10 +26,11 @@
  (guix download)       ;; download-to-store
  ((guix import utils) #:prefix utils:)   ;; hash
  (guix packages)       ;; packages
+ ((guix licenses) #:prefix license:) ;; licenses
  (guix build-system)   ;; build-system printer
  (guix build-system go)  ;; go-build-system
  (guix store)          ;; with-store
- (gnu packages golang) ;; inherit (simple) go package
+ ;; (gnu packages golang) ;; inherit (simple) go package
  (ice-9 textual-ports) ;; to parse readme.md
  (ice-9 popen) ;; open-input-ouput-pipe
  (web uri) ;; uri->string
@@ -153,7 +154,8 @@
   (let* ((version (latest-release go-name))
          (sha256 (go-name->sha256 go-name version))
          (readme-string (go-name->readme-string go-name)))
-    (package (inherit go-github-com-alsm-ioprogress)
+    (package
+      ;; (inherit go-github-com-alsm-ioprogress)
       (name
        (string-append "go-" go-name))
       (version version)
@@ -173,6 +175,7 @@
       (synopsis (go-name->synopsis go-name))
       (description (go-name->description go-name))
       ;; TODO: license
+      (license license:expat)
       )))
 
 (define (filter-newlines string)
-- 
2.21.0