GNU bug report logs - #35624
log-view-diff regression

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Juri Linkov <juri <at> linkov.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#35624: closed (log-view-diff regression)
Date: Sun, 19 May 2019 20:13:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 19 May 2019 23:11:41 +0300
with message-id <8736laqk5e.fsf <at> mail.linkov.net>
and subject line Re: bug#35624: log-view-diff regression
has caused the debbugs.gnu.org bug report #35624,
regarding log-view-diff regression
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
35624: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35624
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: log-view-diff regression
Date: Wed, 08 May 2019 00:56:29 +0300

[Message part 3 (text/plain, inline)]

bug#28466 caused a regression in 26.0.50.  Maybe it's too late to fix it
in the release branch, so the patch below is for master.

The problem is that after the change a year and a half ago 
log-view-diff always falls back to the previous revision
even when point is in the middle of the log buffer,
and not after the last entry.

This patch uses the previous revision only at the end of the log buffer:

[log-view-diff-eobp.patch (text/x-diff, inline)]

diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el
index e47fad8908..1f7d578610 100644
--- a/lisp/vc/log-view.el
+++ b/lisp/vc/log-view.el
@@ -618,10 +618,9 @@ log-view-diff-common
     ;; When TO and FR are the same, or when point is on a line after
     ;; the last entry, look at the previous revision.
     (when (or (string-equal fr to)
-              (>= (point)
-                  (save-excursion
-                    (goto-char (car fr-entry))
-                    (forward-line))))
+              (save-excursion
+                (goto-char end)
+                (eobp)))
       (setq fr (vc-call-backend log-view-vc-backend 'previous-revision nil fr)))
     (vc-diff-internal
      t (list log-view-vc-backend

[Message part 5 (message/rfc822, inline)]

From: Juri Linkov <juri <at> linkov.net>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 35624-done <at> debbugs.gnu.org
Subject: Re: bug#35624: log-view-diff regression
Date: Sun, 19 May 2019 23:11:41 +0300

> Yes, I believe a try is worth a thousand words.

So let's try this.  Pushed to master.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.