GNU bug report logs - #35624
log-view-diff regression

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 35624 <at> debbugs.gnu.org
Subject: bug#35624: log-view-diff regression
Date: Fri, 24 May 2019 21:41:59 +0300

>> -	(insert "\n")
>> +        (overlay-put (make-overlay (point) (progn (insert (propertize "\n" 'help-echo
>> +          "You can use `d' on the top empty line to compare with the current working revision"))
>> +          (point)))
>> +          'invisible t)
>
> Is this a tested patch? It doesn't seem to work over here. 'C-p'
> does nothing.

It's just a sketch, it doesn't work when trying.  This shows that
due to reveal-mode's glitches, this solution can't be used here.

> BTW, why help-echo? We have an otherwise unoccupied line, might as well
> show the text there directly.
>
> What do you think about this version, though:
>
>   (Press 'd' here to see the diff against the current working revision)
>
> ?

Ok, will show this text dimmed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.