From unknown Mon Jun 16 23:48:08 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#35624 <35624@debbugs.gnu.org> To: bug#35624 <35624@debbugs.gnu.org> Subject: Status: log-view-diff regression Reply-To: bug#35624 <35624@debbugs.gnu.org> Date: Tue, 17 Jun 2025 06:48:08 +0000 retitle 35624 log-view-diff regression reassign 35624 emacs submitter 35624 Juri Linkov severity 35624 normal tag 35624 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue May 07 18:01:40 2019 Received: (at submit) by debbugs.gnu.org; 7 May 2019 22:01:40 +0000 Received: from localhost ([127.0.0.1]:59865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hO89c-0005qW-CY for submit@debbugs.gnu.org; Tue, 07 May 2019 18:01:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34979) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hO89a-0005qG-02 for submit@debbugs.gnu.org; Tue, 07 May 2019 18:01:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:34908) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hO89T-0003uG-VQ for submit@debbugs.gnu.org; Tue, 07 May 2019 18:01:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO89S-0000bh-O3 for bug-gnu-emacs@gnu.org; Tue, 07 May 2019 18:01:31 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hO89R-0003nL-5k for bug-gnu-emacs@gnu.org; Tue, 07 May 2019 18:01:30 -0400 Received: from common.maple.relay.mailchannels.net ([23.83.214.38]:16616) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hO89P-0003W4-H1 for bug-gnu-emacs@gnu.org; Tue, 07 May 2019 18:01:29 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id A378C6A158C for ; Tue, 7 May 2019 22:01:22 +0000 (UTC) Received: from pdx1-sub0-mail-a5.g.dreamhost.com (100-96-79-5.trex.outbound.svc.cluster.local [100.96.79.5]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 84F9F6A2171 for ; Tue, 7 May 2019 22:01:20 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a5.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Tue, 07 May 2019 22:01:22 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Hysterical-Trouble: 6c0207490a70d473_1557266482197_382075682 X-MC-Loop-Signature: 1557266482197:2938379199 X-MC-Ingress-Time: 1557266482196 Received: from pdx1-sub0-mail-a5.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a5.g.dreamhost.com (Postfix) with ESMTP id 2F4187FA55 for ; Tue, 7 May 2019 15:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:date:message-id:mime-version:content-type; s= linkov.net; bh=citivUQpPVNwToZeiC7T+QlVwCU=; b=LgfvoRnKNp9uGRcwo M6cCQIAT66opFsClXm7+MRi2YDtrpqF09zAfm4OEyTyYntD3BEmoAUolWwtGXSqL PzIawakShZVDq2nqlh6K4R9w4ulLnnv4wXwpD8DFHGexaHl9moCh+WM72NcKnSwl xgM+DQFLIFHpr0PHHADu3wLeRk= Received: from mail.jurta.org (m91-129-99-37.cust.tele2.ee [91.129.99.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a5.g.dreamhost.com (Postfix) with ESMTPSA id A11327F9F5 for ; Tue, 7 May 2019 15:01:12 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a5 From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: log-view-diff regression Organization: LINKOV.NET Date: Wed, 08 May 2019 00:56:29 +0300 Message-ID: <87pnou2ak2.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrkedugddtgecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufhofffkfgggtgesmhdtreertdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdelledrfeejnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleelrdefjedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 23.83.214.38 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain bug#28466 caused a regression in 26.0.50. Maybe it's too late to fix it in the release branch, so the patch below is for master. The problem is that after the change a year and a half ago log-view-diff always falls back to the previous revision even when point is in the middle of the log buffer, and not after the last entry. This patch uses the previous revision only at the end of the log buffer: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=log-view-diff-eobp.patch diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el index e47fad8908..1f7d578610 100644 --- a/lisp/vc/log-view.el +++ b/lisp/vc/log-view.el @@ -618,10 +618,9 @@ log-view-diff-common ;; When TO and FR are the same, or when point is on a line after ;; the last entry, look at the previous revision. (when (or (string-equal fr to) - (>= (point) - (save-excursion - (goto-char (car fr-entry)) - (forward-line)))) + (save-excursion + (goto-char end) + (eobp))) (setq fr (vc-call-backend log-view-vc-backend 'previous-revision nil fr))) (vc-diff-internal t (list log-view-vc-backend --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 07 18:54:43 2019 Received: (at 35624) by debbugs.gnu.org; 7 May 2019 22:54:43 +0000 Received: from localhost ([127.0.0.1]:59926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hO8yx-0007BR-0n for submit@debbugs.gnu.org; Tue, 07 May 2019 18:54:43 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:40188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hO8yu-0007BC-KA for 35624@debbugs.gnu.org; Tue, 07 May 2019 18:54:41 -0400 Received: by mail-wm1-f68.google.com with SMTP id h11so619765wmb.5 for <35624@debbugs.gnu.org>; Tue, 07 May 2019 15:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YVoqYEkz8P82JkcgmR/yQcueQnEh/1TMjsfl6N/rt8c=; b=DMBwZmgEFvpmfgnRpgvbCgVSqucJprZ80oY0f9k0P0fKPmRZrLPjBFIoXIGbbQpnKM L9ndrwe68V48EVr0/ceV6pyBqAMi+/sqa42a+KsDu+2AkbwUrFgEBRqnxWEhLia+wqv8 SWlwOs16HDL7rl7AVRU7vThuh+YzqjvcXEzm4m0Q74jNiaSpHBR9BI1j2YCXFH6I0uEZ TJKhdlBNgSJjf+7EMfCI9susUyQQ3hq4MTfzwSf9wlJy1QfNe7Kh4BNOgZjW6m5uh9cX WCwVot1sndAMQloBILVW+YYyHVuCz47Jmf7kDdQitlcK5/gj8dquxuXWOJ7HE0ZKWdjc k05A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YVoqYEkz8P82JkcgmR/yQcueQnEh/1TMjsfl6N/rt8c=; b=uLYxEuPjQWgVyy8MXXdvshzVhqv9zCAuOENB2g0ZnkEoUW5cLLq0pYIIBXhgNjXXbD cHctNuySTIInhwkhi1SgCHU1Y4A6T36tzs091LUZoIMcpEq7IMoVRrGdH4R+39F6ESFb +KQL7JHef7j2uUUKF7CEJBEorGpTYl1vFykCmbzZEGxClB0gbwkHXlKmavLMnDGcgjSK jEfFEGoX6T4ifRvm6+wLaPbDOP33+qQpXajnU6fn2Z9fJJIIEIT8zjXHbaizZNMqEhCd iVeUGrVUFlAuVcW42PX0QNqJ2OaeayatMRuOgor9+BPpOcdZQhNCK+PrmXGOdcqmMqvP aqdw== X-Gm-Message-State: APjAAAWkDt3wKAFjhlMa38g7G3PUIiVYbJ89Rae0u9uQkf10rCSzPf7B VvNsadiCJ6v5GQJd2bBxeL91LI30 X-Google-Smtp-Source: APXvYqzDolncK2G+Hh3Jj8IDnMS4wSRH9J+PyWZ3u2a9XbHm/GrGAq5PZsS74HhRh02eOUlEUxZqpA== X-Received: by 2002:a05:600c:24d0:: with SMTP id 16mr506105wmu.21.1557269674410; Tue, 07 May 2019 15:54:34 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id p67sm309671wmp.22.2019.05.07.15.54.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 May 2019 15:54:33 -0700 (PDT) Subject: Re: bug#35624: log-view-diff regression To: Juri Linkov , 35624@debbugs.gnu.org References: <87pnou2ak2.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> Date: Wed, 8 May 2019 01:54:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <87pnou2ak2.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 35624 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 08.05.2019 0:56, Juri Linkov wrote: > bug#28466 caused a regression in 26.0.50. Maybe it's too late to fix it > in the release branch, so the patch below is for master. > > The problem is that after the change a year and a half ago > log-view-diff always falls back to the previous revision > even when point is in the middle of the log buffer, > and not after the last entry. > > This patch uses the previous revision only at the end of the log buffer: Hi Juri, I think the patch should look like the one below instead. Does it fix your problem? It also looks "obviously correct" in my opinion. Your proposal would fail in the presence of "Show 2X entries" (when the log is long enough). diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el index e47fad8908..e1e453115b 100644 --- a/lisp/vc/log-view.el +++ b/lisp/vc/log-view.el @@ -621,7 +621,8 @@ log-view-diff-common (>= (point) (save-excursion (goto-char (car fr-entry)) - (forward-line)))) + (forward-line) + (point)))) (setq fr (vc-call-backend log-view-vc-backend 'previous-revision nil fr))) (vc-diff-internal t (list log-view-vc-backend From debbugs-submit-bounces@debbugs.gnu.org Wed May 08 02:02:17 2019 Received: (at 35624) by debbugs.gnu.org; 8 May 2019 06:02:17 +0000 Received: from localhost ([127.0.0.1]:60169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOFei-0003Wr-Ue for submit@debbugs.gnu.org; Wed, 08 May 2019 02:02:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51471) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOFeh-0003We-RM for 35624@debbugs.gnu.org; Wed, 08 May 2019 02:02:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45541) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOFec-0004eh-MN; Wed, 08 May 2019 02:02:10 -0400 Received: from [176.228.60.248] (port=1988 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hOFeX-0002Dw-Oz; Wed, 08 May 2019 02:02:10 -0400 Date: Wed, 08 May 2019 09:01:54 +0300 Message-Id: <83imuliiwd.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87pnou2ak2.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 08 May 2019 00:56:29 +0300) Subject: Re: bug#35624: log-view-diff regression References: <87pnou2ak2.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Date: Wed, 08 May 2019 00:56:29 +0300 > > bug#28466 caused a regression in 26.0.50. Maybe it's too late to fix it > in the release branch, so the patch below is for master. If you want me to consider installing a change in emacs-26, please show a reproducible recipe, because I don't think I understand the situation where the problematic behavior happens. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed May 08 15:54:58 2019 Received: (at 35624) by debbugs.gnu.org; 8 May 2019 19:54:58 +0000 Received: from localhost ([127.0.0.1]:34110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOSeX-0004lr-Kq for submit@debbugs.gnu.org; Wed, 08 May 2019 15:54:58 -0400 Received: from palegreen.birch.relay.mailchannels.net ([23.83.209.140]:44877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOSeV-0004lZ-NW for 35624@debbugs.gnu.org; Wed, 08 May 2019 15:54:56 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 4E47A8C1F5C; Wed, 8 May 2019 19:54:54 +0000 (UTC) Received: from pdx1-sub0-mail-a31.g.dreamhost.com (100-96-80-14.trex.outbound.svc.cluster.local [100.96.80.14]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 5C9948C2AEC; Wed, 8 May 2019 19:54:49 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a31.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Wed, 08 May 2019 19:54:54 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Abiding-Little: 3913ac2f5c72b410_1557345289909_2599368264 X-MC-Loop-Signature: 1557345289909:773404206 X-MC-Ingress-Time: 1557345289909 Received: from pdx1-sub0-mail-a31.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTP id 7ED9880142; Wed, 8 May 2019 12:54:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=/Ine+TRkWTdI5rVOsbhorvRu+mw=; b= 2ltsrCQV2ATgu6nISBKzhryHI5MhaSulK1C7mCotPzqBcPRb0KJ/Y9IoUP0gKayL Dex3R+8Q/ZUPf/tO8kFgBWCrCkQtpYubyJkE1KY0z0jvmGsEw3fnVT2lmxybNe3W rykcdCWXQDvt+vValYTtAj/pMbOHqXUiLrf22EqDtOU= Received: from mail.jurta.org (m91-129-96-230.cust.tele2.ee [91.129.96.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTPSA id CBEB280149; Wed, 8 May 2019 12:54:40 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a31 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#35624: log-view-diff regression Organization: LINKOV.NET References: <87pnou2ak2.fsf@mail.linkov.net> <83imuliiwd.fsf@gnu.org> Date: Wed, 08 May 2019 22:52:34 +0300 In-Reply-To: <83imuliiwd.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 08 May 2019 09:01:54 +0300") Message-ID: <875zqkraf1.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrkeefgddugeefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdeliedrvdeftdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrdeliedrvdeftddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegvlhhiiiesghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> bug#28466 caused a regression in 26.0.50. Maybe it's too late to fix it >> in the release branch, so the patch below is for master. > > If you want me to consider installing a change in emacs-26, I'm not sure about a new change for emacs-26, I thought rather about reverting the previous change in emacs-26, because it is still nor clear what the right change should be, as the comment from Dmitry indicates. So a safer option would be just revert the previous change in emacs-26. > please show a reproducible recipe, because I don't think I understand > the situation where the problematic behavior happens. Here is an illustration of the problem: 1. the case when region's beginning (b) and region's end (e) is on the same revision in the log-view buffer: * h8..: 2019-05-08 Revision h8. be* g7..: 2019-05-07 Revision g7. * f6..: 2019-05-06 Revision f6. * e5..: 2019-05-05 Revision e5. compares the revision f6 (the previous revision of g7) and g7. This behavior was unchanged by the bug#28466. 2. This case demonstrates the behavior BEFORE the change in bug#28466: * h8..: 2019-05-08 Revision h8. b * g7..: 2019-05-07 Revision g7. e * f6..: 2019-05-06 Revision f6. * e5..: 2019-05-05 Revision e5. compared the revision f6 (from region's end) and g7 (from region's beginning). This was the correct behavior. 3. Now this case demonstrates the incorrect behavior AFTER the change in bug#28466: * h8..: 2019-05-08 Revision h8. b * g7..: 2019-05-07 Revision g7. e * f6..: 2019-05-06 Revision f6. * e5..: 2019-05-05 Revision e5. compares the revision e5 (the previous revision of the revision at region's end) and g7 (from region's beginning). 4. This demonstrates the case that the change in bug#28466 was intended to fix: * h8..: 2019-05-08 Revision h8. b * g7..: 2019-05-07 Revision g7. * f6..: 2019-05-06 Revision f6. * e5..: 2019-05-05 Revision e5. e When region's end is after the last visible revision, it should compare g7 (from region's beginning) with the previous revision of the last revision e5 (a hypothetical revision d4, not visible in the buffer). Before the fix, it compared e5 and g7, that was wrong. But the fix broke the case when region's end is in the middle of the buffer. From debbugs-submit-bounces@debbugs.gnu.org Wed May 08 15:55:00 2019 Received: (at 35624) by debbugs.gnu.org; 8 May 2019 19:55:00 +0000 Received: from localhost ([127.0.0.1]:34112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOSea-0004m5-31 for submit@debbugs.gnu.org; Wed, 08 May 2019 15:55:00 -0400 Received: from firebrick.maple.relay.mailchannels.net ([23.83.214.59]:29487) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOSeW-0004lc-Rt for 35624@debbugs.gnu.org; Wed, 08 May 2019 15:54:57 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 8A3415E2ACC; Wed, 8 May 2019 19:54:55 +0000 (UTC) Received: from pdx1-sub0-mail-a31.g.dreamhost.com (100-96-79-6.trex.outbound.svc.cluster.local [100.96.79.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 2B8825E17DC; Wed, 8 May 2019 19:54:52 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a31.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Wed, 08 May 2019 19:54:55 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Coil-Occur: 562cb9181d27891f_1557345295233_2482227489 X-MC-Loop-Signature: 1557345295233:1592432728 X-MC-Ingress-Time: 1557345295233 Received: from pdx1-sub0-mail-a31.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTP id F0B7B8014A; Wed, 8 May 2019 12:54:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=jUFV/gppkHMSYj96AD9zxzKleP0=; b= fAu6IAgwZN5wWm3bhlTHIJ5A2iiika19ol3G5qInnc4V/8VE7Oyly25maxPMHlLQ b7dmIHQGGhohx+9/G7uZCDo9yrRrW/er30UddmiOTxKRHp2SSB5Xc4mH0UgC4h9p u0/uTU19YPSZlW8ANAP/DE0wwAHAcBnrpgeTdE+En1M= Received: from mail.jurta.org (m91-129-96-230.cust.tele2.ee [91.129.96.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTPSA id DDE6E80149; Wed, 8 May 2019 12:54:47 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a31 From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#35624: log-view-diff regression Organization: LINKOV.NET References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> Date: Wed, 08 May 2019 22:52:41 +0300 In-Reply-To: <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> (Dmitry Gutov's message of "Wed, 8 May 2019 01:54:32 +0300") Message-ID: <874l64raeu.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrkeefgddugeefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdeliedrvdeftdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrdeliedrvdeftddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegughhuthhovheshigrnhguvgigrdhruhenucevlhhushhtvghrufhiiigvpedu X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I think the patch should look like the one below instead. Does it fix your > problem? It also looks "obviously correct" in my opinion. This is exactly what was my initial thought, but this is a wrong fix, as I realized later. > diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el > index e47fad8908..e1e453115b 100644 > --- a/lisp/vc/log-view.el > +++ b/lisp/vc/log-view.el > @@ -621,7 +621,8 @@ log-view-diff-common > (>= (point) > (save-excursion > (goto-char (car fr-entry)) > - (forward-line)))) > + (forward-line) > + (point)))) > (setq fr (vc-call-backend log-view-vc-backend 'previous-revision nil fr))) > (vc-diff-internal > t (list log-view-vc-backend This patch doesn't check if the region's end is after the last revision, also fails if the summary line is expanded to multiline revision's header/body. > Your proposal would fail in the presence of "Show 2X entries" (when the log > is long enough). Yes, I know my previous patch is not perfect, I also tried (not (re-search-forward log-view-message-re nil t)) but it seems this is impossible to do because currently log-view.el doesn't support the notion of the end of the last revision expanded body. For example, 1. with the expanded last visible revision * h8..: 2019-05-08 Revision h8. b * g7..: 2019-05-07 Revision g7. * f6..: 2019-05-06 Revision f6. * e5..: 2019-05-05 Revision e5. commit e5 Date: 2019-05-05 first line second line e third line should compare e5 and g7 2. but when region's end (e) is after the last line of the last expanded revision: * h8..: 2019-05-08 Revision h8. b * g7..: 2019-05-07 Revision g7. * f6..: 2019-05-06 Revision f6. * e5..: 2019-05-05 Revision e5. commit e5 Date: 2019-05-05 first line second line third line e should compare d4 (a previous revision of the last revision) and g7. From debbugs-submit-bounces@debbugs.gnu.org Thu May 09 09:26:54 2019 Received: (at 35624) by debbugs.gnu.org; 9 May 2019 13:26:54 +0000 Received: from localhost ([127.0.0.1]:35010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOj4Y-0002W8-56 for submit@debbugs.gnu.org; Thu, 09 May 2019 09:26:54 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:38281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOj4V-0002Vk-1c for 35624@debbugs.gnu.org; Thu, 09 May 2019 09:26:52 -0400 Received: by mail-wr1-f67.google.com with SMTP id v11so3076758wru.5 for <35624@debbugs.gnu.org>; Thu, 09 May 2019 06:26:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=C/Rm2YU356stKk30k/F1AWfQPdkxIKgeBhvQDxuL9CE=; b=XEyfkby9Vk7HgLJOdifKc+kVnksLqcLBj1Og8WnWmoAdAv//3HEBx5RNWr51wqRGw2 dh8WhsWYc/ikbuUeYgXRaNmayAg0pKRWmCQjx3ZKbcTONcQg+rAKHnlGM+aWdIfus0+N +ytP2fdcQebz5mXaT8XnwGYc2Oqmp3nLCWFZDDOey9VmUEWf0umQMrJjj8zBLa48NKk+ 5B42/HJ1zMhvqx3lmjyuC0LvJiibz8bXpUM7HMHjadrOl9ki+qJ/dGhjVvjOuWqfQw4N yO1kaAooC//jB9D+trQhFBO08gPZUVk2mtIVGfy/P0MH4B291ZIWeG0GB+WBMRXtmIdQ LCgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=C/Rm2YU356stKk30k/F1AWfQPdkxIKgeBhvQDxuL9CE=; b=jZ8ozUAJIJpawtKdZJncyf4ytDWeLRR0gfTGNyfZYM3TAZ05Wy5Aq+BQD3yFYy/Ame 50IEG62uKxp1R8YM4IsrPo9fgISxrE5Sm9WWsdszI0EmwRFRO5Zm1mWw+eR67stc37XX O2qEbyM1IpbWJatFJANB4D344i41aLr9J9WImzxWv82QRvvA0ZJQgC6M5XtFAMarsLdq RCOizMZP+a1wdXnBDUmU1uD2TsHrUtfhmFU5vzWAFSP5WRr2RAZrG8lq7psOUAoMRs53 RqYXpMUuDQ4S6iAvgwaeFH/g2U7RUI2s1npLGvoKH3IxPdqwCOdZdIBCeflkIVXYnmru wkzw== X-Gm-Message-State: APjAAAWGQYnga+7pLg90QZhtiOiU2Pf7mLjq29qX3FFzjvFlezka6bC+ hdu4AHZdXOfJmtTo5VUKdBJ099Gh X-Google-Smtp-Source: APXvYqxC6sMj5Dq4NBqgqm4grikP2al18BT4dBETeYO8/vYnmeR2SBScMOdnn1rRo5hRcShWgmWnHw== X-Received: by 2002:adf:cf0e:: with SMTP id o14mr3040640wrj.230.1557408404588; Thu, 09 May 2019 06:26:44 -0700 (PDT) Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id x5sm1116065wrt.72.2019.05.09.06.26.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 May 2019 06:26:33 -0700 (PDT) Subject: Re: bug#35624: log-view-diff regression To: Juri Linkov References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Thu, 9 May 2019 16:26:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <874l64raeu.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 08.05.2019 22:52, Juri Linkov wrote: > This is exactly what was my initial thought, but this is a wrong fix, > as I realized later. Okay, let's work on it. I do want to just commit that patch first, since it was obviously the idea behind the previous change. >> diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el >> index e47fad8908..e1e453115b 100644 >> --- a/lisp/vc/log-view.el >> +++ b/lisp/vc/log-view.el >> @@ -621,7 +621,8 @@ log-view-diff-common >> (>= (point) >> (save-excursion >> (goto-char (car fr-entry)) >> - (forward-line)))) >> + (forward-line) >> + (point)))) >> (setq fr (vc-call-backend log-view-vc-backend 'previous-revision nil fr))) >> (vc-diff-internal >> t (list log-view-vc-backend > > This patch doesn't check if the region's end is after the last revision, What do you mean it doesn't? That's the whole purpose of the comparison (the part of the function the diff above changes). > also fails if the summary line is expanded to multiline revision's header/body. Isn't it the only situation where it fails? I wouldn't say it's a hugely important case. The whole approach becomes iffy once the lower bound position is *inside* the revision entry. Should it be the lower bound? Should the changes be included in the diff? I could never be sure without looking at the docstring. >> Your proposal would fail in the presence of "Show 2X entries" (when the log >> is long enough). > > Yes, I know my previous patch is not perfect, I also tried > > (not (re-search-forward log-view-message-re nil t)) > > but it seems this is impossible to do because currently > log-view.el doesn't support the notion of the end of > the last revision expanded body. The other option is check whether all lines between the point and EOB are either empty of start with "Show 2X entries". Which is a design I don't particularly like, but it could serve your goal. From debbugs-submit-bounces@debbugs.gnu.org Thu May 09 15:49:04 2019 Received: (at 35624) by debbugs.gnu.org; 9 May 2019 19:49:04 +0000 Received: from localhost ([127.0.0.1]:36494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOp2O-0005rc-7y for submit@debbugs.gnu.org; Thu, 09 May 2019 15:49:04 -0400 Received: from bonobo.maple.relay.mailchannels.net ([23.83.214.22]:19498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOp2M-0005r8-9E; Thu, 09 May 2019 15:49:03 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id D13D83E66E7; Thu, 9 May 2019 19:49:00 +0000 (UTC) Received: from pdx1-sub0-mail-a59.g.dreamhost.com (unknown [100.96.20.60]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 872643E268B; Thu, 9 May 2019 19:49:00 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a59.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Thu, 09 May 2019 19:49:00 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Trade-Plucky: 4c957c147468d615_1557431340660_2865009672 X-MC-Loop-Signature: 1557431340660:3320052332 X-MC-Ingress-Time: 1557431340659 Received: from pdx1-sub0-mail-a59.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a59.g.dreamhost.com (Postfix) with ESMTP id 0C9C480A88; Thu, 9 May 2019 12:49:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=jK10XHFxOM1DlQh/kQq1Pt7U2Z0=; b= OVD71qExIT8H+6Pk306620KJkb1ey7q1WwSG7dKlF+GmXpG7cK/VVkPu65nBR7io FdVfNskLBtpyvzGl9WE/CH4H+55ZiF/KtCH5PWNF4wBpvdt4c/YGvCxYDarUT4NN cHGsSqXhvWxpiU/0s4Vhf2lfz6RlKM4Q3ol75n4ZJM8= Received: from mail.jurta.org (m91-129-96-230.cust.tele2.ee [91.129.96.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a59.g.dreamhost.com (Postfix) with ESMTPSA id 822C580A72; Thu, 9 May 2019 12:48:56 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a59 From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#35624: log-view-diff regression Organization: LINKOV.NET References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> Date: Thu, 09 May 2019 22:41:15 +0300 In-Reply-To: (Dmitry Gutov's message of "Thu, 9 May 2019 16:26:31 +0300") Message-ID: <87imujju04.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrkeeigdekudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehmtderredtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledrleeirddvfedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleeirddvfedtpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgeptd X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain found 35624 26.1 tags 35624 + patch quit >> This is exactly what was my initial thought, but this is a wrong fix, >> as I realized later. > > Okay, let's work on it. > > I do want to just commit that patch first, since it was obviously the idea > behind the previous change. Since it's wrong in any case, better to revert it altogether in emacs-26. >> I also tried >> >> (not (re-search-forward log-view-message-re nil t)) >> >> but it seems this is impossible to do because currently >> log-view.el doesn't support the notion of the end of >> the last revision expanded body. > > The other option is check whether all lines between the point and EOB are > either empty of start with "Show 2X entries". Which is a design I don't > particularly like, but it could serve your goal. Actually there is the much needed function log-view-inside-comment-p for expanded comments, and this patch correctly handles all cases: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=log-view-diff-message.patch diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el index e47fad8908..f7aeacc273 100644 --- a/lisp/vc/log-view.el +++ b/lisp/vc/log-view.el @@ -618,10 +618,11 @@ log-view-diff-common ;; When TO and FR are the same, or when point is on a line after ;; the last entry, look at the previous revision. (when (or (string-equal fr to) - (>= (point) - (save-excursion - (goto-char (car fr-entry)) - (forward-line)))) + (and (not (log-view-inside-comment-p end)) + (save-excursion + (goto-char end) + (beginning-of-line) + (not (re-search-forward log-view-message-re nil t))))) (setq fr (vc-call-backend log-view-vc-backend 'previous-revision nil fr))) (vc-diff-internal t (list log-view-vc-backend --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 09 20:14:48 2019 Received: (at 35624) by debbugs.gnu.org; 10 May 2019 00:14:48 +0000 Received: from localhost ([127.0.0.1]:36711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOtBY-0005rT-0o for submit@debbugs.gnu.org; Thu, 09 May 2019 20:14:48 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:46554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOtBV-0005rF-5s for 35624@debbugs.gnu.org; Thu, 09 May 2019 20:14:47 -0400 Received: by mail-lf1-f68.google.com with SMTP id k18so2816914lfj.13 for <35624@debbugs.gnu.org>; Thu, 09 May 2019 17:14:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=G7N1a48Rx/ZwyyAA+B8QoRGz+xH83/x/9Q9VGKK4Yl0=; b=Qpf7oSWxnHb1PFdELzZO/CoXR2NTxH+eebvhLdB9+1OUfF9eNSLZvRTa9Xp4XsiDCp mqqnuK6qCf/k694nbxT7E0hfLqY6wbiYHfjPhRAYlzTKBjXnLuJEugma+OMXJAIfC3/b wdj9FoW1/zXltPXQBtrtgSnx4QaFOoeM+UkioALnrXNcv30S2i9q8bxe2XBAMETAZBRN 5lfaXwAA4op3O5S1Rm2s9BoopdJbG1DSFG8mTFwyDfaC5X6UuAPe5RQOHt/gsaPHPYnV PonSF/SSnh1dKcmmgf49Qpw6A+DJnViKBRD3cSgCeAP3srksiVbpPcYHVmk5vpEVkoVe VaAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=G7N1a48Rx/ZwyyAA+B8QoRGz+xH83/x/9Q9VGKK4Yl0=; b=NECXWn3worViYu7WkB7P+6MgH3v8JVToCFIRGf+PXrtCKXKV5NVA6pxSocaZIS6Ala 1sZoo4Kp13XhHiC20X9PzAdFXQKKwzLuSDSzIKaiMAi8qEetaGtCE8pYzd1WyglnjukL 83f8bUHbM6U+vQzJk0Yrvg6ZQmysOCTRw7c74KSHPAKrSZOgz3sAKb9ImJuIZV2wbb2l 3f1qkjaztYg9zA8dcsqsYiLT9D7kSxWLIpDCtUokZW9Zf32xL2igzPDIltCRXC0ES50j 8V24I9VDQ080xEXCF5/dXwJZ5WRxAAHfgvHhja8jTdBQCBQ8SjjHRcDgymrA12ZBYHuQ zkzA== X-Gm-Message-State: APjAAAViPgjo2EQ3LkUMCQr5Yan6wrRtHncpL7RSECfDJBPeL1l390an bpqxunGxJJDgok9KM2Xcjth1SF3s X-Google-Smtp-Source: APXvYqyvfVMkvjwxjRwfuqXP0AWVj0/gsr+mLBmB07XW7uvmfiBJpX4FjmGTSKhxXkauc4XTJMreLw== X-Received: by 2002:a19:c50a:: with SMTP id w10mr4048984lfe.163.1557447278687; Thu, 09 May 2019 17:14:38 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id z12sm864327lfh.72.2019.05.09.17.14.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 May 2019 17:14:36 -0700 (PDT) Subject: Re: bug#35624: log-view-diff regression To: Juri Linkov References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> Date: Fri, 10 May 2019 03:14:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <87imujju04.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 09.05.2019 22:41, Juri Linkov wrote: > Since it's wrong in any case, better to revert it altogether in emacs-26. I kind of think that the feature the last change added is more valuable than the regression (especially if the regression is only triggered when a commit message is expanded). > Actually there is the much needed function log-view-inside-comment-p > for expanded comments, and this patch correctly handles all cases: Great! The patch LGTM. Note that we could write a smaller change using that function, if the goal is to produce as-obvious-as-possible change for emacs-26. From debbugs-submit-bounces@debbugs.gnu.org Fri May 10 03:52:00 2019 Received: (at 35624) by debbugs.gnu.org; 10 May 2019 07:52:00 +0000 Received: from localhost ([127.0.0.1]:37016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hP0Jx-0002BV-3p for submit@debbugs.gnu.org; Fri, 10 May 2019 03:51:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39633) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hP0Ju-0002BI-Jp for 35624@debbugs.gnu.org; Fri, 10 May 2019 03:51:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57762) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hP0Jp-0005No-3m; Fri, 10 May 2019 03:51:49 -0400 Received: from [176.228.60.248] (port=4820 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hP0Jo-0006VA-Gv; Fri, 10 May 2019 03:51:48 -0400 Date: Fri, 10 May 2019 10:51:40 +0300 Message-Id: <83pnoqg31v.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <875zqkraf1.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 08 May 2019 22:52:34 +0300) Subject: Re: bug#35624: log-view-diff regression References: <87pnou2ak2.fsf@mail.linkov.net> <83imuliiwd.fsf@gnu.org> <875zqkraf1.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: 35624@debbugs.gnu.org > Date: Wed, 08 May 2019 22:52:34 +0300 > > 1. the case when region's beginning (b) and region's end (e) > is on the same revision in the log-view buffer: > > * h8..: 2019-05-08 Revision h8. > be* g7..: 2019-05-07 Revision g7. > * f6..: 2019-05-06 Revision f6. > * e5..: 2019-05-05 Revision e5. > > compares the revision f6 (the previous revision of g7) and g7. > This behavior was unchanged by the bug#28466. > > 2. This case demonstrates the behavior > BEFORE the change in bug#28466: > > * h8..: 2019-05-08 Revision h8. > b * g7..: 2019-05-07 Revision g7. > e * f6..: 2019-05-06 Revision f6. > * e5..: 2019-05-05 Revision e5. > > compared the revision f6 (from region's end) and g7 (from region's beginning). > This was the correct behavior. > > 3. Now this case demonstrates the incorrect behavior > AFTER the change in bug#28466: > > * h8..: 2019-05-08 Revision h8. > b * g7..: 2019-05-07 Revision g7. > e * f6..: 2019-05-06 Revision f6. > * e5..: 2019-05-05 Revision e5. > > compares the revision e5 (the previous revision of the revision at region's end) > and g7 (from region's beginning). What does "e" signify in these examples? Does it mean the line indicated with "e" is part of the region? If so, then the current behavior (item 3) looks correct to me, and previous behavior (item 2) looks INcorrect. The '=' command should show the combined effect of all the changes included in the region, so it should compare the last revision with the one before the first. This is also what I see with Emacs 26.2 on my system. Am I missing something? > But the fix broke the case when region's end is in the middle > of the buffer. I don't yet see how it breaks anything, sorry. From debbugs-submit-bounces@debbugs.gnu.org Fri May 10 03:54:58 2019 Received: (at 35624) by debbugs.gnu.org; 10 May 2019 07:54:59 +0000 Received: from localhost ([127.0.0.1]:37024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hP0Ms-0002GB-KQ for submit@debbugs.gnu.org; Fri, 10 May 2019 03:54:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40067) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hP0Mq-0002Fx-DZ for 35624@debbugs.gnu.org; Fri, 10 May 2019 03:54:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hP0Mk-0006r7-GL; Fri, 10 May 2019 03:54:50 -0400 Received: from [176.228.60.248] (port=1032 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hP0Mj-0006mE-Uy; Fri, 10 May 2019 03:54:50 -0400 Date: Fri, 10 May 2019 10:54:43 +0300 Message-Id: <83o94ag2ws.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <874l64raeu.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 08 May 2019 22:52:41 +0300) Subject: Re: bug#35624: log-view-diff regression References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Date: Wed, 08 May 2019 22:52:41 +0300 > Cc: 35624@debbugs.gnu.org > > 1. with the expanded last visible revision > > * h8..: 2019-05-08 Revision h8. > b * g7..: 2019-05-07 Revision g7. > * f6..: 2019-05-06 Revision f6. > * e5..: 2019-05-05 Revision e5. > commit e5 > Date: 2019-05-05 > first line > second line > e third line > > should compare e5 and g7 > > 2. but when region's end (e) is after the last line > of the last expanded revision: > > * h8..: 2019-05-08 Revision h8. > b * g7..: 2019-05-07 Revision g7. > * f6..: 2019-05-06 Revision f6. > * e5..: 2019-05-05 Revision e5. > commit e5 > Date: 2019-05-05 > first line > second line > third line > e > > should compare d4 (a previous revision of the last revision) and g7. You seem to be assigning some meaning to the case where the region includes only part of a revision's display. Why is that meaning useful? From my POV, it just increases the probability of user errors if they position the region end inaccurately. Why not consider a revision included if even some part of it is in the region, let alone its header line? From debbugs-submit-bounces@debbugs.gnu.org Fri May 10 03:56:40 2019 Received: (at 35624) by debbugs.gnu.org; 10 May 2019 07:56:40 +0000 Received: from localhost ([127.0.0.1]:37028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hP0OW-0002Iw-2M for submit@debbugs.gnu.org; Fri, 10 May 2019 03:56:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hP0OU-0002Ii-LA for 35624@debbugs.gnu.org; Fri, 10 May 2019 03:56:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hP0OP-0007nW-0S; Fri, 10 May 2019 03:56:33 -0400 Received: from [176.228.60.248] (port=1138 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hP0OO-000755-Fj; Fri, 10 May 2019 03:56:32 -0400 Date: Fri, 10 May 2019 10:56:25 +0300 Message-Id: <83mujug2ty.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> (message from Dmitry Gutov on Fri, 10 May 2019 03:14:34 +0300) Subject: Re: bug#35624: log-view-diff regression References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Dmitry Gutov > Date: Fri, 10 May 2019 03:14:34 +0300 > Cc: 35624@debbugs.gnu.org > > On 09.05.2019 22:41, Juri Linkov wrote: > > > Since it's wrong in any case, better to revert it altogether in emacs-26. > > I kind of think that the feature the last change added is more valuable > than the regression (especially if the regression is only triggered when > a commit message is expanded). And I don't yet see any regression at all, so I'm definitely against reverting on the emacs-26 branch. From debbugs-submit-bounces@debbugs.gnu.org Sat May 11 17:12:23 2019 Received: (at 35624) by debbugs.gnu.org; 11 May 2019 21:12:23 +0000 Received: from localhost ([127.0.0.1]:41307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPZI6-0005n9-R1 for submit@debbugs.gnu.org; Sat, 11 May 2019 17:12:23 -0400 Received: from gecko.birch.relay.mailchannels.net ([23.83.209.66]:2794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPZI5-0005n1-IQ for 35624@debbugs.gnu.org; Sat, 11 May 2019 17:12:22 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 810F71A1854; Sat, 11 May 2019 21:12:20 +0000 (UTC) Received: from pdx1-sub0-mail-a85.g.dreamhost.com (100-96-30-28.trex.outbound.svc.cluster.local [100.96.30.28]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 03EF01A10EC; Sat, 11 May 2019 21:12:20 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a85.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Sat, 11 May 2019 21:12:20 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Cooperative-Eight: 6c39cf5e72bbf482_1557609140312_1829156722 X-MC-Loop-Signature: 1557609140312:2302798831 X-MC-Ingress-Time: 1557609140311 Received: from pdx1-sub0-mail-a85.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a85.g.dreamhost.com (Postfix) with ESMTP id AB2CB8039A; Sat, 11 May 2019 14:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=BdUCtXWJDGmSChVhOxayGg7XYuY=; b= F3wPyjG3IaZ/tQnZpjjIPBcsAZWG8pPeGfFMj7TZo7eBUJ6A6TT7dE7bSReI74do b4Is6iQwgWVcZ8X2L4wo2qb/Q/L2AXwsc+ECyKRr+ShyIvFaeUDrCdaaDiupvVFQ EGLCenWQBeKfTsMuxbqQ2H2t85wolTDfOrTLeSwEh8o= Received: from mail.jurta.org (m91-129-96-230.cust.tele2.ee [91.129.96.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a85.g.dreamhost.com (Postfix) with ESMTPSA id 6DD5180390; Sat, 11 May 2019 14:12:12 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a85 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#35624: log-view-diff regression Organization: LINKOV.NET References: <87pnou2ak2.fsf@mail.linkov.net> <83imuliiwd.fsf@gnu.org> <875zqkraf1.fsf@mail.linkov.net> <83pnoqg31v.fsf@gnu.org> Date: Sat, 11 May 2019 23:53:44 +0300 In-Reply-To: <83pnoqg31v.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 10 May 2019 10:51:40 +0300") Message-ID: <87zhnsaf1j.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrledtgdduieduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdeliedrvdeftdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrdeliedrvdeftddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegvlhhiiiesghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedu X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> 1. the case when region's beginning (b) and region's end (e) > > What does "e" signify in these examples? "e" signifies the end of the region. > The '=' command should show the combined effect of all the changes > included in the region, so it should compare the last revision with > the one before the first. > > Am I missing something? If the beginning of the region is on the line with revision g7 and the end of the region is on the line with revision f6, do you think it should show differences between g7 and f6? From debbugs-submit-bounces@debbugs.gnu.org Sat May 11 17:12:27 2019 Received: (at 35624) by debbugs.gnu.org; 11 May 2019 21:12:27 +0000 Received: from localhost ([127.0.0.1]:41310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPZIB-0005nQ-6V for submit@debbugs.gnu.org; Sat, 11 May 2019 17:12:27 -0400 Received: from common.maple.relay.mailchannels.net ([23.83.214.38]:10060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPZI9-0005nI-Ki for 35624@debbugs.gnu.org; Sat, 11 May 2019 17:12:26 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id B2B441A13F3; Sat, 11 May 2019 21:12:24 +0000 (UTC) Received: from pdx1-sub0-mail-a85.g.dreamhost.com (100-96-14-60.trex.outbound.svc.cluster.local [100.96.14.60]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 383161A1870; Sat, 11 May 2019 21:12:24 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a85.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Sat, 11 May 2019 21:12:24 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Drop-Daffy: 29d203fd4e51c3e5_1557609144533_406489180 X-MC-Loop-Signature: 1557609144532:777340443 X-MC-Ingress-Time: 1557609144532 Received: from pdx1-sub0-mail-a85.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a85.g.dreamhost.com (Postfix) with ESMTP id E83938039D; Sat, 11 May 2019 14:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=aV23FC2Kzf53H+xVO3wQKJ4qp5s=; b= FUUON1tVD/TJ990AKq0rvMGSY9mYDe5dR/aaCOK7r9tN40kGPrbauCUk8+0Fwh8l mLzSK1bcFAlz+E7mqA3ucj8orWz7mUwsIzYV+uflUszk1q2R93k74PRDFFv/KthM fwTqbsaLOHzVC3CxTt6obOqwt8TIi+JTCdqEUT9w2Io= Received: from mail.jurta.org (m91-129-96-230.cust.tele2.ee [91.129.96.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a85.g.dreamhost.com (Postfix) with ESMTPSA id 4F84780390; Sat, 11 May 2019 14:12:17 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a85 From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#35624: log-view-diff regression Organization: LINKOV.NET References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> Date: Sat, 11 May 2019 23:58:49 +0300 In-Reply-To: <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> (Dmitry Gutov's message of "Fri, 10 May 2019 03:14:34 +0300") Message-ID: <875zqgaekq.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrledtgdduieduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesmhdtreertdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdeliedrvdeftdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrdeliedrvdeftddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegughhuthhovheshigrnhguvgigrdhruhenucevlhhushhtvghrufhiiigvpedt X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain > I kind of think that the feature the last change added is more valuable > than the regression (especially if the regression is only triggered when > a commit message is expanded). It is triggered not only when a commit message is expanded. Also it is triggered on single-file logs. Admittedly, my previous patch didn't take this into account. Here is a new patch that works also for single-file logs. It relies on the function 'log-view-end-of-defun' that takes care about the "Show 2X entries" footer: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=log-view-diff-end-of-defun.patch diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el index e47fad8908..3389264ce6 100644 --- a/lisp/vc/log-view.el +++ b/lisp/vc/log-view.el @@ -618,10 +618,11 @@ log-view-diff-common ;; When TO and FR are the same, or when point is on a line after ;; the last entry, look at the previous revision. (when (or (string-equal fr to) - (>= (point) + (>= end (save-excursion - (goto-char (car fr-entry)) - (forward-line)))) + (goto-char end) + (log-view-end-of-defun) + (point)))) (setq fr (vc-call-backend log-view-vc-backend 'previous-revision nil fr))) (vc-diff-internal t (list log-view-vc-backend --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 11 22:36:55 2019 Received: (at 35624) by debbugs.gnu.org; 12 May 2019 02:36:55 +0000 Received: from localhost ([127.0.0.1]:41535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPeMA-0007QS-Rv for submit@debbugs.gnu.org; Sat, 11 May 2019 22:36:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPeM9-0007QF-Aw for 35624@debbugs.gnu.org; Sat, 11 May 2019 22:36:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPeM3-0006b8-VB; Sat, 11 May 2019 22:36:47 -0400 Received: from [176.228.60.248] (port=1362 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hPeM3-0000hx-AP; Sat, 11 May 2019 22:36:47 -0400 Date: Sun, 12 May 2019 05:36:28 +0300 Message-Id: <837eawcsb7.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87zhnsaf1j.fsf@mail.linkov.net> (message from Juri Linkov on Sat, 11 May 2019 23:53:44 +0300) Subject: Re: bug#35624: log-view-diff regression References: <87pnou2ak2.fsf@mail.linkov.net> <83imuliiwd.fsf@gnu.org> <875zqkraf1.fsf@mail.linkov.net> <83pnoqg31v.fsf@gnu.org> <87zhnsaf1j.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: 35624@debbugs.gnu.org > Date: Sat, 11 May 2019 23:53:44 +0300 > > >> 1. the case when region's beginning (b) and region's end (e) > > > > What does "e" signify in these examples? > > "e" signifies the end of the region. I asked a detailed question, but your answer doesn't make me wiser about what "e" means. Could you please humor me with a more detailed answer? > If the beginning of the region is on the line with revision g7 > and the end of the region is on the line with revision f6, > do you think it should show differences between g7 and f6? Depends on what "e" signifies. It could be. From debbugs-submit-bounces@debbugs.gnu.org Sun May 12 15:28:10 2019 Received: (at 35624) by debbugs.gnu.org; 12 May 2019 19:28:10 +0000 Received: from localhost ([127.0.0.1]:43352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPu8o-0001hh-Gn for submit@debbugs.gnu.org; Sun, 12 May 2019 15:28:10 -0400 Received: from goldenrod.birch.relay.mailchannels.net ([23.83.209.74]:43246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPu8m-0001hZ-Cs for 35624@debbugs.gnu.org; Sun, 12 May 2019 15:28:08 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 688FC5C5B67; Sun, 12 May 2019 19:28:07 +0000 (UTC) Received: from pdx1-sub0-mail-a64.g.dreamhost.com (unknown [100.96.11.48]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 2CCFB5C5B5F; Sun, 12 May 2019 19:28:07 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a64.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Sun, 12 May 2019 19:28:07 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Bored-Supply: 43de624775a9a48f_1557689287262_4165475279 X-MC-Loop-Signature: 1557689287262:2005476987 X-MC-Ingress-Time: 1557689287262 Received: from pdx1-sub0-mail-a64.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a64.g.dreamhost.com (Postfix) with ESMTP id E90188050F; Sun, 12 May 2019 12:28:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=4HlJcipEvTxAJ8Pm6lnPXglL7CM=; b= vfP4hLA8V34I3IYSwaNn0piGfn0RqItsC1D1bYssLgz+4ZRQs+Mki+ADiQi1WUqj 0iGTcqSInzzsnwq4vFeTLEHKQfk47G9ehOg1DdG6lfYpSEjS8KNu6Ttwlqjf2720 0T3uh8ADe+nGLN+lmcjjaIV5IIkbbdx18/4f/F6uhDA= Received: from mail.jurta.org (m91-129-96-230.cust.tele2.ee [91.129.96.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a64.g.dreamhost.com (Postfix) with ESMTPSA id 4382E80502; Sun, 12 May 2019 12:28:04 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a64 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#35624: log-view-diff regression Organization: LINKOV.NET References: <87pnou2ak2.fsf@mail.linkov.net> <83imuliiwd.fsf@gnu.org> <875zqkraf1.fsf@mail.linkov.net> <83pnoqg31v.fsf@gnu.org> <87zhnsaf1j.fsf@mail.linkov.net> <837eawcsb7.fsf@gnu.org> Date: Sun, 12 May 2019 22:15:20 +0300 In-Reply-To: <837eawcsb7.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 12 May 2019 05:36:28 +0300") Message-ID: <87sgtjzmz5.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrledvgddugedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdeliedrvdeftdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrdeliedrvdeftddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegvlhhiiiesghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedu X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> >> 1. the case when region's beginning (b) and region's end (e) >> > >> > What does "e" signify in these examples? >> >> "e" signifies the end of the region. > > I asked a detailed question, but your answer doesn't make me wiser > about what "e" means. Could you please humor me with a more detailed > answer? Let me describe how log-view-diff was supposed to work since its introduction ~20 years ago until its behavior was changed accidentally one and half year ago: when the user puts the beginning of the region on the line with one revision, and the end of the region on the line with another revision, the function 'log-view-diff-common' extracts the 'from' revision from the line with the first revision, and the 'to' revision from the line with the second revision. bug#28466 tried to improve the logic when the end of the region is at the end of the buffer, but mistakenly broke long-established behavior, so currently 'from' falls thru to its previous revision. From debbugs-submit-bounces@debbugs.gnu.org Sun May 12 20:32:47 2019 Received: (at 35624) by debbugs.gnu.org; 13 May 2019 00:32:47 +0000 Received: from localhost ([127.0.0.1]:43749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPyta-0002sf-UZ for submit@debbugs.gnu.org; Sun, 12 May 2019 20:32:47 -0400 Received: from mail-lf1-f45.google.com ([209.85.167.45]:38576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPytZ-0002sI-J5 for 35624@debbugs.gnu.org; Sun, 12 May 2019 20:32:46 -0400 Received: by mail-lf1-f45.google.com with SMTP id y19so7689119lfy.5 for <35624@debbugs.gnu.org>; Sun, 12 May 2019 17:32:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=UU9fLIraSlTZXmFwpk2cFgFB9AVVwg6KDhjOzzBTxMs=; b=UGNm7KOuoOVjDUf3xmbqbK8h4FSmTpchhoDJ/Mu26h/BCXr3CBikkX3vT8nbnhUX0q 44MeT0TUXeVX3t4pOK+F4SjMMIRZ1F02VBGHKN5zFl06rTPUv0WvghdnblKRbSs5AT3u ANRrcSo0lTrVq3Un2pd0uxFYpgCMhk6z3Dmp2FGKuXjJkSEWfOF8MRaf7Jxz7bM+Mmo8 bsT3Q9UGyEsUwfBBk2sW7AnWVEJuL06uB60BI3YJbHbi5k/yEVsMqwn5rd8SArBIZGUX zo4myt8FyJO//DdB5OXvuLEc8geBBmmLOhn2LXqZyMlQKasEACuILlvs/7ZEl6qX/5Kg 0xuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UU9fLIraSlTZXmFwpk2cFgFB9AVVwg6KDhjOzzBTxMs=; b=ZehtQm6clXqA2Z6MhqZA6yj6Wib6nHTJ/qTxWBZHz6I8nx8v7EBN9Fps0gPEqtWCXz 3Si2mbN1spdgzjLZVpkKhL3NJDYXG0mVBMCVBaPkT4Ga31UTQQnrx6q6b0rBU2j1Fj+r GogCHN/Lp5JcMtV1gWgWsY0/bHfyDKq2f/gl5R0ho/2sjIox5sc21iYYEppQ0ymROmAk +0pChdHRAJAzZ7ZT/Y/ptffTnIPnl+bVT1s1Wm+M/SYK+9iiihfI6DJjjgqH8VebGZwG eeh3ZqjoifPfNPYuGWjvIzEkCl1uue40d7cSpfl8zG3r+rF9kJzTWQpR2N/480SnA710 iH1g== X-Gm-Message-State: APjAAAUcazSrIRzZMZaYPwqAgpPe/WzpRKs0Ntsj08KEfX/PQFU8W7Kc yzD2RSE7NZyYCty3yyuQjKMdgVFM X-Google-Smtp-Source: APXvYqzj4NxpHsCj6VZC/GpBR+PtO99o9QPjn740SRWBsxQwbF6veNF/Z2+SPU6Flsj0KKchHdOX9w== X-Received: by 2002:a19:6f4d:: with SMTP id n13mr11931814lfk.57.1557707559229; Sun, 12 May 2019 17:32:39 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id q5sm3001415lfj.1.2019.05.12.17.32.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 12 May 2019 17:32:37 -0700 (PDT) Subject: Re: bug#35624: log-view-diff regression To: Juri Linkov References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> Date: Mon, 13 May 2019 03:32:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <875zqgaekq.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 11.05.2019 23:58, Juri Linkov wrote: > Here is a new patch that works also > for single-file logs. It relies on the function 'log-view-end-of-defun' > that takes care about the "Show 2X entries" footer: Looks good. Please install when you're comfortable with it. From debbugs-submit-bounces@debbugs.gnu.org Mon May 13 10:24:56 2019 Received: (at 35624) by debbugs.gnu.org; 13 May 2019 14:24:56 +0000 Received: from localhost ([127.0.0.1]:45866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQBst-0003Up-NS for submit@debbugs.gnu.org; Mon, 13 May 2019 10:24:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQBsr-0003Ua-FU for 35624@debbugs.gnu.org; Mon, 13 May 2019 10:24:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45535) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQBsm-0006Wk-1H; Mon, 13 May 2019 10:24:48 -0400 Received: from [176.228.60.248] (port=2304 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hQBsk-0005jh-9x; Mon, 13 May 2019 10:24:46 -0400 Date: Mon, 13 May 2019 17:24:29 +0300 Message-Id: <83bm06bffm.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87sgtjzmz5.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 12 May 2019 22:15:20 +0300) Subject: Re: bug#35624: log-view-diff regression References: <87pnou2ak2.fsf@mail.linkov.net> <83imuliiwd.fsf@gnu.org> <875zqkraf1.fsf@mail.linkov.net> <83pnoqg31v.fsf@gnu.org> <87zhnsaf1j.fsf@mail.linkov.net> <837eawcsb7.fsf@gnu.org> <87sgtjzmz5.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: 35624@debbugs.gnu.org > Date: Sun, 12 May 2019 22:15:20 +0300 > > > I asked a detailed question, but your answer doesn't make me wiser > > about what "e" means. Could you please humor me with a more detailed > > answer? > > Let me describe how log-view-diff was supposed to work since its introduction > ~20 years ago until its behavior was changed accidentally one and half year ago: > when the user puts the beginning of the region on the line with one revision, > and the end of the region on the line with another revision, the function > 'log-view-diff-common' extracts the 'from' revision from the line > with the first revision, and the 'to' revision from the line > with the second revision. Then the fix in bug#28466 makes no sense, because it treats the case when the region ends on the last revision specially. But I feel that I've exhausted my grace in trying to make sense out of this, so I will now shut up. > bug#28466 tried to improve the logic when the end of the region is > at the end of the buffer Treating EOB specially makes no sense to me, FWIW. From debbugs-submit-bounces@debbugs.gnu.org Mon May 13 10:44:29 2019 Received: (at 35624) by debbugs.gnu.org; 13 May 2019 14:44:29 +0000 Received: from localhost ([127.0.0.1]:45902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQCBp-0003zE-18 for submit@debbugs.gnu.org; Mon, 13 May 2019 10:44:29 -0400 Received: from mail-wm1-f49.google.com ([209.85.128.49]:35527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQCBn-0003yy-0m for 35624@debbugs.gnu.org; Mon, 13 May 2019 10:44:27 -0400 Received: by mail-wm1-f49.google.com with SMTP id q15so9973391wmj.0 for <35624@debbugs.gnu.org>; Mon, 13 May 2019 07:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=oyiUODjFv3HzXumsc8ZqlQVRl6mwdu1xyC0PQ5Rob4Q=; b=PII7DlfH7g2r1P+PIDHuUsezNeadZgJVFf90+oHwKPev6bRFbnaT+88XFIsO+6hKuw j+sZ3LfJnRDCv5Ev5dODxN3oNJs75wdDWyBE8bvoFuLunIr+lKFpPMVzkiCsWLxjJWDQ eZnuCxR45YRLk/JzdDOnf5et6yaSUkHrmtgyRQ6UCZyTmMgUk6G1nO3/iuDnrKrggxPn tjWDxf4Q54qq9PLV+qaj1Y1SklZbbHZJcN1d+RuuFunvQcKfPMJlP2B+FFDp8YXoPD+C qCCSFFBJ5hbyD1RO62CP+kcBAAjXr2nQSDZxBJPSaWlSzi00Ii066ue0TOczXANvNTzE Yo0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oyiUODjFv3HzXumsc8ZqlQVRl6mwdu1xyC0PQ5Rob4Q=; b=aA/Ybd4PL3BKbh7CFlbgdMeGN/6XQmzpHlar4zYWBD5HZVoIzgWaMeDZuZfl8Z79/R ERFWktgfnG99VhWLU5R8ZNk3OmzhF1r4w42osP8vlI/ifZN9/6ousD0/7P/vkjlC2RqB eWkscUoHV9EOV/FTQciCWxV/VUSagskdYerV1Xx4YizfTbN9o5LBOOrZoFlHd/q7vKm1 BQsoAAs3G8qBwC9ts+v3SvY10Ms2NJfQqqsYmfmGfvxDdD4qvURFjojvgzb9V+2vu2fa nx1qpIrc3hPkfyGci4UuotkbKsYvdNDSQpraIZeKK8VofusjimIWrsgZWoDfnw1S7k7f hvcQ== X-Gm-Message-State: APjAAAX1KPphdsnhV4vWZRhid2/dVSaVrwi4BMrLEYydQsWtlxDDRUSk r2zFWp1wyYVfLK6wC3D8tsIhpIOz X-Google-Smtp-Source: APXvYqyDfY4Z6Z4KXZomYGEHROXCQVico6IAsdWnfQqQf61FQOlTpE3VEkUJXo+29qYK1z+gQjezgA== X-Received: by 2002:a1c:494:: with SMTP id 142mr16625226wme.115.1557758660733; Mon, 13 May 2019 07:44:20 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id u17sm12535595wmj.1.2019.05.13.07.44.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 May 2019 07:44:19 -0700 (PDT) Subject: Re: bug#35624: log-view-diff regression To: Eli Zaretskii , Juri Linkov References: <87pnou2ak2.fsf@mail.linkov.net> <83imuliiwd.fsf@gnu.org> <875zqkraf1.fsf@mail.linkov.net> <83pnoqg31v.fsf@gnu.org> <87zhnsaf1j.fsf@mail.linkov.net> <837eawcsb7.fsf@gnu.org> <87sgtjzmz5.fsf@mail.linkov.net> <83bm06bffm.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Mon, 13 May 2019 17:44:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <83bm06bffm.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 13.05.2019 17:24, Eli Zaretskii wrote: > Then the fix in bug#28466 makes no sense, because it treats the case > when the region ends on the last revision specially. It's attempting to specially treat the case when the region ends *after* the last revision. To diff against the preceding one, because it's impossible to do otherwise in the "outgoing log". From debbugs-submit-bounces@debbugs.gnu.org Mon May 13 11:09:49 2019 Received: (at 35624) by debbugs.gnu.org; 13 May 2019 15:09:49 +0000 Received: from localhost ([127.0.0.1]:45937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQCaK-0006nH-Lo for submit@debbugs.gnu.org; Mon, 13 May 2019 11:09:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQCaI-0006mq-7i for 35624@debbugs.gnu.org; Mon, 13 May 2019 11:09:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46151) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQCaC-00066N-Gt; Mon, 13 May 2019 11:09:40 -0400 Received: from [176.228.60.248] (port=1308 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hQCaB-0008VW-UV; Mon, 13 May 2019 11:09:40 -0400 Date: Mon, 13 May 2019 18:09:23 +0300 Message-Id: <831s12bdcs.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: (message from Dmitry Gutov on Mon, 13 May 2019 17:44:16 +0300) Subject: Re: bug#35624: log-view-diff regression References: <87pnou2ak2.fsf@mail.linkov.net> <83imuliiwd.fsf@gnu.org> <875zqkraf1.fsf@mail.linkov.net> <83pnoqg31v.fsf@gnu.org> <87zhnsaf1j.fsf@mail.linkov.net> <837eawcsb7.fsf@gnu.org> <87sgtjzmz5.fsf@mail.linkov.net> <83bm06bffm.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 35624@debbugs.gnu.org > From: Dmitry Gutov > Date: Mon, 13 May 2019 17:44:16 +0300 > > On 13.05.2019 17:24, Eli Zaretskii wrote: > > Then the fix in bug#28466 makes no sense, because it treats the case > > when the region ends on the last revision specially. > > It's attempting to specially treat the case when the region ends *after* > the last revision. Yes, and that's what makes no sense. There's no "after", the region ends in the last revision in the buffer, by definition. Anyway, I already said that I will shut up. From debbugs-submit-bounces@debbugs.gnu.org Mon May 13 16:41:51 2019 Received: (at 35624) by debbugs.gnu.org; 13 May 2019 20:41:51 +0000 Received: from localhost ([127.0.0.1]:46453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQHlf-0006od-Jx for submit@debbugs.gnu.org; Mon, 13 May 2019 16:41:51 -0400 Received: from goldenrod.birch.relay.mailchannels.net ([23.83.209.74]:33993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQHle-0006oF-5a for 35624@debbugs.gnu.org; Mon, 13 May 2019 16:41:50 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id BB27E5C61AE; Mon, 13 May 2019 20:41:44 +0000 (UTC) Received: from pdx1-sub0-mail-a99.g.dreamhost.com (unknown [100.96.11.48]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 70E585C6219; Mon, 13 May 2019 20:41:44 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a99.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Mon, 13 May 2019 20:41:44 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Wipe-Scare: 07ec6ca86e28bfbc_1557780104581_2148137940 X-MC-Loop-Signature: 1557780104581:3584899865 X-MC-Ingress-Time: 1557780104580 Received: from pdx1-sub0-mail-a99.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a99.g.dreamhost.com (Postfix) with ESMTP id C70FA7FB92; Mon, 13 May 2019 13:41:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; s=linkov.net; bh=K1aVTzCnGiwOAogCGM41KeJa7Ks=; b=oQw/lTNm20jrhf 1T/Y5klEiuLZWrjzByQIscNuDwj9nKYX5KEol0CRqT+AOonPdIm5sHbFRMEXeuZW PJIaeId7XqiHorW5sYh/Tjmq64+UKbDbHxRtnCYKpMPlhsg04a0c3eWG2unxSYeJ qmXcJqKLVOCLzbox1EYyclK8or+6w= Received: from mail.jurta.org (m91-129-96-230.cust.tele2.ee [91.129.96.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a99.g.dreamhost.com (Postfix) with ESMTPSA id 936617FB91; Mon, 13 May 2019 13:41:39 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a99 From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#35624: log-view-diff regression Organization: LINKOV.NET References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> Date: Mon, 13 May 2019 23:40:35 +0300 Message-ID: <87y33a3x6k.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrleeggdduhedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledrleeirddvfedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleeirddvfedtpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgeptd X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> Here is a new patch that works also for single-file logs. It relies >> on the function 'log-view-end-of-defun' that takes care about the >> "Show 2X entries" footer: > > Looks good. Please install when you're comfortable with it. Pushed to master. But there is another regression. Do you remember that in older versions there was a header in the *vc-change-log* buffer? It was very useful to put the beginning of the region on the first non-revision line in the header to compare the current working revision with the last committed revision. Now this feature is gone, and the first line can't be used to compare with the working revision because now the first line contains the last committed revision. This patch restores this useful feature: diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index 192e6cf68f..040b0832be 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1017,8 +1017,8 @@ vc-git-print-log ;; If the buffer exists from a previous invocation it might be ;; read-only. (let ((inhibit-read-only t)) - (with-current-buffer - buffer + (with-current-buffer buffer + (insert "Working\n") (apply 'vc-git-command buffer 'async files (append From debbugs-submit-bounces@debbugs.gnu.org Mon May 13 17:21:37 2019 Received: (at 35624) by debbugs.gnu.org; 13 May 2019 21:21:37 +0000 Received: from localhost ([127.0.0.1]:46520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQIO9-0003Yf-2B for submit@debbugs.gnu.org; Mon, 13 May 2019 17:21:37 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]:55184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQIO5-0003YP-HY for 35624@debbugs.gnu.org; Mon, 13 May 2019 17:21:35 -0400 Received: by mail-wm1-f52.google.com with SMTP id i3so725134wml.4 for <35624@debbugs.gnu.org>; Mon, 13 May 2019 14:21:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wIPA53M4WE3wb+MAsL9nnBO5i6cMBpKtXVryjnX9qdo=; b=QFesURAg8SYk1QdfE5sOpwNYjdy1Rep2HRKRwHz0SDoDl4ig3nr1osAsFgEuZVuq/Y sXg0HPNSNMcX83UM4Iwl0A36fud3Bx7zkcrumO4ZumARxq1RFJoxGHFudlBu0/8r3l7O sr/MMsTgVpXOIiajyBTaGyx3866Dn0Joxn3neOblCYOMU2WQdE0nWD/5cDqSdqyXaCza lgErZ8BN8ctNuY31YoJF+PXrlEFnpP9lKqz8q9dt4kw6bQ/CHek3XMMpNzCI8zFUWGaj F4kkc7MgqtGBwUvnHv/zepOIh5EIlZ9SlvZvZ5ms5odQR3Eh3uRPSvHdNNPnQ9n9EcNk Im2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wIPA53M4WE3wb+MAsL9nnBO5i6cMBpKtXVryjnX9qdo=; b=cFohCMcqCYV6aQ9Ir0q/ob6uvzbxupwHCCgFA+PPbZy+J+PfH6fyIoct+4jrdD5ppi FObKM1XQrbhL+XmVxs/vbWEe9LEpbTULtY204cn/BUXkYSsiBeH22wBkMW5NyaKL1xg/ G1dyNSWVHBVrtT4NtJdLGmPqfTnedF7DxpaEKCB76tQxrh8UKg1JakvIJPQXRnJ2ayZf zjy/nKM2dm9BZXy8dIDhOqlnC5oiEEYA1g4hbGUXjQbDgaqlLuZRX8JQ4zKgl/Wij6Br 6R1oeM4pngsZ5/KhJDoriQHTSxO7CoQjsiN/eP1B/OsTfjM3PzThNsjRHqQQo1V7jpLq FIpA== X-Gm-Message-State: APjAAAWW851bPx8wahEc15EnEOLtnOAydu3AgOd7+kFBkowHb7FFKym2 b2UwNM+5CflcKzPSyOxCqpRc77IM X-Google-Smtp-Source: APXvYqyLfvWOhyceWop4+3E/9TaW8YO7bZrV+s8qNk5pYn3VfZge8CyTcK6ruHXAbH+A2XKjhZ/YrQ== X-Received: by 2002:a7b:c4d1:: with SMTP id g17mr8016874wmk.103.1557782487473; Mon, 13 May 2019 14:21:27 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id u125sm1441860wme.15.2019.05.13.14.21.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 May 2019 14:21:26 -0700 (PDT) Subject: Re: bug#35624: log-view-diff regression To: Juri Linkov References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Tue, 14 May 2019 00:21:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <87y33a3x6k.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 13.05.2019 23:40, Juri Linkov wrote: > Do you remember that in older versions > there was a header in the*vc-change-log* buffer? Sorry, I don't. Can you find the change that removed it? > + (with-current-buffer buffer > + (insert "Working\n") How does the result look? Just the word "Working" at the beginning of the buffer? From debbugs-submit-bounces@debbugs.gnu.org Tue May 14 16:36:18 2019 Received: (at 35624) by debbugs.gnu.org; 14 May 2019 20:36:18 +0000 Received: from localhost ([127.0.0.1]:49976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQe9p-0004gu-MF for submit@debbugs.gnu.org; Tue, 14 May 2019 16:36:18 -0400 Received: from golden.birch.relay.mailchannels.net ([23.83.209.73]:32283) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQe9n-0004gl-No for 35624@debbugs.gnu.org; Tue, 14 May 2019 16:36:16 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id A72ED2C1F3E; Tue, 14 May 2019 20:36:14 +0000 (UTC) Received: from pdx1-sub0-mail-a88.g.dreamhost.com (100-96-3-22.trex.outbound.svc.cluster.local [100.96.3.22]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 1A8B32C1C3F; Tue, 14 May 2019 20:36:14 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a88.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Tue, 14 May 2019 20:36:14 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Well-Made-Befitting: 74ee36994731f294_1557866174522_1571895125 X-MC-Loop-Signature: 1557866174522:1933204287 X-MC-Ingress-Time: 1557866174522 Received: from pdx1-sub0-mail-a88.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a88.g.dreamhost.com (Postfix) with ESMTP id E77A4806BC; Tue, 14 May 2019 13:36:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=atqyt4j1QKdoK4gXhx7+6qYhEDE=; b= T3ye4zC72lQbh8Jr/zC76ut2K6hU1WOdURZkJ/li3L3BvSPWHy0NA7zcEuAs9GSf l6adDqMEIFcgt8m2FTaXtJ9HvolUDgqsk44Gep3CIp8SkAbxxZfOD8xe6mk0RvLT dGrs34h5GTjmnWLXLS97rppDHKGHnU8bErEHFMzhBEA= Received: from mail.jurta.org (m91-129-96-230.cust.tele2.ee [91.129.96.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a88.g.dreamhost.com (Postfix) with ESMTPSA id 6E900806C7; Tue, 14 May 2019 13:36:10 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a88 From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#35624: log-view-diff regression Organization: LINKOV.NET References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> Date: Tue, 14 May 2019 23:29:34 +0300 In-Reply-To: (Dmitry Gutov's message of "Tue, 14 May 2019 00:21:24 +0300") Message-ID: <87bm04vky9.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrleeigdduhedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdeliedrvdeftdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrdeliedrvdeftddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegughhuthhovheshigrnhguvgigrdhruhenucevlhhushhtvghrufhiiigvpedv X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> Do you remember that in older versions >> there was a header in the *vc-change-log* buffer? > > Sorry, I don't. Can you find the change that removed it? I don't remember what VC backend produced such header, maybe vc-bzr or vc-svn. Or probably vc-cvs because CVS has the same header as RCS, and I can easily check what headers RCS produces because it doesn't require any configuration. For brevity only essential part of RCS log is left here for demonstration: Working file: ---------------------------- revision 1.4 ---------------------------- revision 1.3 ---------------------------- revision 1.2 ---------------------------- revision 1.1 When the beginning of the region is on the "Working file" line in the header, and the end of the region is on a revision line, e.g. "revision 1.4", then typing `=' displays: No changes between 1.4 and workfile and if the current workfile has some changes, then differences between 1.4 and workfile are displayed. This means that RCS supports this nice feature, but Git doesn't. >> + (with-current-buffer buffer >> + (insert "Working\n") > > How does the result look? Just the word "Working" at the beginning of > the buffer? If the word "Working" is too ambiguous, then at least an empty line at the beginning of the buffer will enable this feature for Git. From debbugs-submit-bounces@debbugs.gnu.org Tue May 14 20:34:36 2019 Received: (at 35624) by debbugs.gnu.org; 15 May 2019 00:34:37 +0000 Received: from localhost ([127.0.0.1]:50397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQhsS-0004gs-Jy for submit@debbugs.gnu.org; Tue, 14 May 2019 20:34:36 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:53706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQhsR-0004gd-00 for 35624@debbugs.gnu.org; Tue, 14 May 2019 20:34:35 -0400 Received: by mail-wm1-f42.google.com with SMTP id 198so793616wme.3 for <35624@debbugs.gnu.org>; Tue, 14 May 2019 17:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=twYjhD+A4MH3BJ+jfQ312KKntTHdMYb1AI1G65AxPAs=; b=Qj1ZFmwpQx0Pck7NAV5UCg3/2o2txAcvpTXTFlR/Wp9E61x5tL3v8IaDbHeXO/SqHY fkI9mjjIdf8il1DgIZn+gNW/VpaI2h5V9QX3+/DCyZ7SjoWw2iRyXG1CNxD9sDUn7RuB bpiYLRbvkNxRCTzX7ctmyTHVCx1R05Pvl3PFYOGPdEPiYTtJTCvz0XLZwtAE8U4mGhCo 5XZxvlQKSot5Msfp+QdFDseMrMjKI49zsjC37UXdREqmJ0pidEUwRclZhEFBaGYg8LMm LvMGY9lVnFg+igoxYQIWXo91xK8pIQZ2uwaydiG4pUPCkwWz2hEaZI+I3yv4DlUWa6GL NrOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=twYjhD+A4MH3BJ+jfQ312KKntTHdMYb1AI1G65AxPAs=; b=BN4z0unCyhP1wjgRFQOAaDSWP3FhHmcc98wAAY7VNkOHW+v10t9G+0fafjS+Qnbzq9 IMXXRf2d5iJynfiL0p73gB55GTOKWGTCSUYtSYXhmsXNJwErDUVS8Hm6f5nZggbA/85q w5UdY/a/nufj2rvziF2vqIr6aPRy1KuX3Kd6vGMwJWwk4Pwpjv90sEaB6CiM8riq3bIG gIYB2hiVNenkkrLHZSRL7nmiolkrbeReYVU+MGpU/HTrk/Vu/hZLyyo9c/rqW03qo659 uH/VzWNKSvKkCmvGIH/+b2NT8BtmjQg2ABDmniLyqAWpzQTu1FVeQ5bar7UfwqWsTm6c 6akw== X-Gm-Message-State: APjAAAX8GkDqDLNuuPeZBfFmQNAYU86OMW/uZS5XMZLenStjo/4VP9Kv HVPd0GHSL8vaVNzXWMFylrConGhH X-Google-Smtp-Source: APXvYqydBojY+rcTmy9po3xrpSBe4YBIfPczpx9j7LG7i8PD45hsIE5k6sDvKfPs08Y3v0YX6zP8dA== X-Received: by 2002:a1c:9a14:: with SMTP id c20mr5105259wme.104.1557880468670; Tue, 14 May 2019 17:34:28 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id t126sm436016wma.1.2019.05.14.17.34.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 May 2019 17:34:26 -0700 (PDT) Subject: Re: bug#35624: log-view-diff regression To: Juri Linkov References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> Date: Wed, 15 May 2019 03:34:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <87bm04vky9.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 14.05.2019 23:29, Juri Linkov wrote: >> Sorry, I don't. Can you find the change that removed it? > > I don't remember what VC backend produced such header, maybe > vc-bzr or vc-svn. Or probably vc-cvs because CVS has the same > header as RCS, and I can easily check what headers RCS produces > because it doesn't require any configuration. For brevity > only essential part of RCS log is left here for demonstration: Thank you. > Working file: I guess RCS at least outputs some pertinent information here, not just that text, so it's less puzzling. I don't know how useful it is, though. > ---------------------------- > revision 1.4 > ---------------------------- > revision 1.3 > ---------------------------- > revision 1.2 > ---------------------------- > revision 1.1 > > When the beginning of the region is on the "Working file" line > in the header, and the end of the region is on a revision line, > e.g. "revision 1.4", then typing `=' displays: > > No changes between 1.4 and workfile You can also type 'C-u C-x v =', then '1.4', RET and C-j to omit the end version. That would also show the diff against the workfile. > and if the current workfile has some changes, then differences > between 1.4 and workfile are displayed. > > This means that RCS supports this nice feature, but Git doesn't. Just how nice is it, really? It seems pretty niche to me, and I don't remember the last time I needed something like this exactly. >>> + (with-current-buffer buffer >>> + (insert "Working\n") >> >> How does the result look? Just the word "Working" at the beginning of >> the buffer? > > If the word "Working" is too ambiguous, then at least an empty line > at the beginning of the buffer will enable this feature for Git. Should we really make the log look weirder for the sake of a feature one would use at most, I don't know... once a month? Why don't we create a 'fake history' entry in vc-diff and vc-root-diff instead? Then the user could move point to a revision and type C-u C-x v = M-n RET C-j It's not as quick maybe, but this way you also avoid having to set the "other' region bound. From debbugs-submit-bounces@debbugs.gnu.org Wed May 15 17:54:57 2019 Received: (at 35624) by debbugs.gnu.org; 15 May 2019 21:54:57 +0000 Received: from localhost ([127.0.0.1]:53541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hR1rV-0002yf-CS for submit@debbugs.gnu.org; Wed, 15 May 2019 17:54:57 -0400 Received: from bird.maple.relay.mailchannels.net ([23.83.214.17]:20476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hR1rS-0002yQ-PM for 35624@debbugs.gnu.org; Wed, 15 May 2019 17:54:55 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 7BB958C19E5; Wed, 15 May 2019 21:54:53 +0000 (UTC) Received: from pdx1-sub0-mail-a19.g.dreamhost.com (100-96-6-25.trex.outbound.svc.cluster.local [100.96.6.25]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id B1BA98C17A4; Wed, 15 May 2019 21:54:52 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a19.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Wed, 15 May 2019 21:54:53 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Abaft-Eyes: 515da3d04f4e5648_1557957293302_2316896765 X-MC-Loop-Signature: 1557957293302:2669079384 X-MC-Ingress-Time: 1557957293302 Received: from pdx1-sub0-mail-a19.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a19.g.dreamhost.com (Postfix) with ESMTP id 797A381400; Wed, 15 May 2019 14:54:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=sWmAXp4AgrxpZTlSmG8eLH2nCQ4=; b= NW6n1hbPkBUGYi8mQFa9AaoQ1TXeFRZU2jcBL2y1A4RiX/ctz5DPGIAlrX7bY+hm MHL6biyCm73tlBFAV/CJQBwgVF+Gqt6vMy/B9G95Uvi39G9UpJZoHbeM0pqSkHBr gvBU0apURQuKzb75mr2QGF5XNNZ3jpp+e6p/9dZXJQ8= Received: from mail.jurta.org (m91-129-96-230.cust.tele2.ee [91.129.96.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a19.g.dreamhost.com (Postfix) with ESMTPSA id 6C54480AF2; Wed, 15 May 2019 14:54:46 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a19 From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#35624: log-view-diff regression Organization: LINKOV.NET References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> Date: Thu, 16 May 2019 00:12:54 +0300 In-Reply-To: <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> (Dmitry Gutov's message of "Wed, 15 May 2019 03:34:24 +0300") Message-ID: <87lfz7o05l.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrleelgddtudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledrleeirddvfedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleeirddvfedtpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgepud X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> I don't remember what VC backend produced such header, maybe >> vc-bzr or vc-svn. Or probably vc-cvs because CVS has the same >> header as RCS, and I can easily check what headers RCS produces >> because it doesn't require any configuration. For brevity >> only essential part of RCS log is left here for demonstration: > > Thank you. > >> Working file: > > I guess RCS at least outputs some pertinent information here, not just that > text, so it's less puzzling. I don't know how useful it is, though. Yes, RCS displays a multi-line header. >> ---------------------------- >> revision 1.4 >> ---------------------------- >> revision 1.3 >> ---------------------------- >> revision 1.2 >> ---------------------------- >> revision 1.1 >> >> When the beginning of the region is on the "Working file" line >> in the header, and the end of the region is on a revision line, >> e.g. "revision 1.4", then typing `=' displays: >> >> No changes between 1.4 and workfile > > You can also type 'C-u C-x v =', then '1.4', RET and C-j to omit the end > version. That would also show the diff against the workfile. 10 keys more to type. >>>> + (with-current-buffer buffer >>>> + (insert "Working\n") >>> >>> How does the result look? Just the word "Working" at the beginning of >>> the buffer? >> >> If the word "Working" is too ambiguous, then at least an empty line >> at the beginning of the buffer will enable this feature for Git. > > Should we really make the log look weirder for the sake of a feature one > would use at most, I don't know... once a month? When this feature was enabled, I used it every day. Currently I'm forced to type 10 more keys every time. I agree the log not to look weirder, so better to not display Working. >> and if the current workfile has some changes, then differences >> between 1.4 and workfile are displayed. >> >> This means that RCS supports this nice feature, but Git doesn't. > > Just how nice is it, really? It seems pretty niche to me, and I don't > remember the last time I needed something like this exactly. Or course, you didn't think about it, because you didn't know it exists. I didn't know too until discovered it accidentally. After that it hard to lose this ability. The problem is that this useful feature is undocumented. Here is the patch that documents it: diff --git a/doc/emacs/maintaining.texi b/doc/emacs/maintaining.texi index 4986c11103..12cee5d922 100644 --- a/doc/emacs/maintaining.texi +++ b/doc/emacs/maintaining.texi @@ -1033,6 +1033,7 @@ VC Change Log Visit the revision indicated at the current line. @item d +@itemx = Display a diff between the revision at point and the next earlier revision, for the specific file. @@ -1047,6 +1048,16 @@ VC Change Log revision at point. @end table +To compare two arbitrary revisions, activate the region: set the +beginning of the region to the line with the first revision and the +end of the region to the line with the second revision to compare, +then type @kbd{d} or @kbd{=}. When the beginning of the region is on +the top line that has no revision, it uses the current work file as +the first revision to compare. When the end of the region is on the +bottom non-revision line after the last revision line, then it uses +the next earlier revision after the last displayed revision as the +second revision to compare. + @vindex vc-log-show-limit Because fetching many log entries can be slow, the @file{*vc-change-log*} buffer displays no more than 2000 revisions by diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index 61c13026cc..b6feb3b8d1 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1017,8 +1017,8 @@ vc-git-print-log ;; If the buffer exists from a previous invocation it might be ;; read-only. (let ((inhibit-read-only t)) - (with-current-buffer - buffer + (with-current-buffer buffer + (insert "\n") (apply 'vc-git-command buffer 'async files (append From debbugs-submit-bounces@debbugs.gnu.org Wed May 15 18:05:32 2019 Received: (at 35624) by debbugs.gnu.org; 15 May 2019 22:05:32 +0000 Received: from localhost ([127.0.0.1]:53552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hR21k-0003Gh-09 for submit@debbugs.gnu.org; Wed, 15 May 2019 18:05:32 -0400 Received: from mail-lf1-f52.google.com ([209.85.167.52]:37426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hR21h-0003GR-Ts for 35624@debbugs.gnu.org; Wed, 15 May 2019 18:05:30 -0400 Received: by mail-lf1-f52.google.com with SMTP id q17so1011891lfo.4 for <35624@debbugs.gnu.org>; Wed, 15 May 2019 15:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nAb3isyxO1zmZKaSl5Y2SXlwHzKVyr5zsuRKLgFCyfw=; b=D6U904TJp0d5dLNnmnEb+TvJviGN+1A8l+CWKmr7QjaeBzdf1NquVaJtGGUiRLr+Kf BreUP+qNvuKFCo20mZV2hR0Uimd8jSmHnO7InHq5oPojS7ODM8vDVifgIcEBAkHp241m aEws1LyNE6uGUwUjUrUsEMae136lcZ15+LAK1EzcGBO7sIFEARXMtuBVQ74DTe2xluSG jWd2XEuLOrvX+PrfY2C6fSHO74zhCVplR41UNA2A91JUX48HyfVYHMvVmGYDDNkz7aFM ZyQ9PwD7/W/ykBmkTEY+irGu2Y16eRz5cqqS/QvYn5oiLE6yjUaF1O29DXWEZ+L6N1Bu t7sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nAb3isyxO1zmZKaSl5Y2SXlwHzKVyr5zsuRKLgFCyfw=; b=eMJA50akKKMjp2abWEjcQmtEidf8620BJDPPx1woWt4Iq0vFHRauj8Ob8H5q3zK2AL PDQ6nf8cmkS9UuXVpAwlQl5DrpeBIt6DKTq1MmcwHtemtPq7vTPu8sRKxEyBj6y7+9Ju PLc4bcZnnC+FNlvQQgcAhhh/TQXutwDfROjq2c3ach8gEZNwat+bkmKhWM/a4dx5WWob dvNuF333Tqars88+gLqXi0kYKGny7TxCF6E/UZheUDFFzsBBR1a4rF5wE2NofdH5UJnL KllUL6UyULxXycJgip7vQi6AVLcvHavNvx6EWjIGJiAZEsTCgTESdogmQ+8U9XU6DDJ5 C0pQ== X-Gm-Message-State: APjAAAVJWOF+K7+p9gA6bVnG3zjfV2Fc1aaAWohFaTKmQLCBR3zEUzQr vSuc2LuSVGq8Ys85ukcvwZNbnq6K X-Google-Smtp-Source: APXvYqx5HwKruu+zoRwCw3htrNpjksC15SJQshSDpTLsx4ZXTdjupnPnepjwVA0ZJa0b8eje57FG/Q== X-Received: by 2002:ac2:510b:: with SMTP id q11mr19891555lfb.11.1557957919384; Wed, 15 May 2019 15:05:19 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id w20sm556056ljd.39.2019.05.15.15.05.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 May 2019 15:05:13 -0700 (PDT) Subject: Re: bug#35624: log-view-diff regression To: Juri Linkov References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> Date: Thu, 16 May 2019 01:05:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <87lfz7o05l.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 16.05.2019 0:12, Juri Linkov wrote: >> You can also type 'C-u C-x v =', then '1.4', RET and C-j to omit the end >> version. That would also show the diff against the workfile. > > 10 keys more to type. You would normally paste the revision. And 'C-x v =' is already in my muscle memory. > When this feature was enabled, I used it every day. Was it back in the days of CVS? > Currently I'm forced > to type 10 more keys every time. I agree the log not to look weirder, > so better to not display Working. Could you explain what are you using it for? I understand a diff between revisions, and I understand a diff of the working tree against the index, but this kind of a diff seems pretty unusual. > Or course, you didn't think about it, because you didn't know it exists. > I didn't know too until discovered it accidentally. After that it hard > to lose this ability. The problem is that this useful feature is > undocumented. Here is the patch that documents it: I have tried to imagine using it, but it's still hard. Maybe doing it once a few days to compare the current progress against the master branch. Though C-u C-x v d master RET C-j might be faster that looking for the revision that corresponds to the master branch in the log. > +To compare two arbitrary revisions, activate the region: set the > +beginning of the region to the line with the first revision and the > +end of the region to the line with the second revision to compare, > +then type @kbd{d} or @kbd{=}. When the beginning of the region is on > +the top line that has no revision, it uses the current work file as > +the first revision to compare. When the end of the region is on the > +bottom non-revision line after the last revision line, then it uses > +the next earlier revision after the last displayed revision as the > +second revision to compare. The description is okay, but feature-wise, I'm not convinced. Would somebody else like to express an opinion here? > @vindex vc-log-show-limit > Because fetching many log entries can be slow, the > @file{*vc-change-log*} buffer displays no more than 2000 revisions by > diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el > index 61c13026cc..b6feb3b8d1 100644 > --- a/lisp/vc/vc-git.el > +++ b/lisp/vc/vc-git.el > @@ -1017,8 +1017,8 @@ vc-git-print-log > ;; If the buffer exists from a previous invocation it might be > ;; read-only. > (let ((inhibit-read-only t)) > - (with-current-buffer > - buffer > + (with-current-buffer buffer > + (insert "\n") Any other ideas how to reach the same functionality without making the log buffer weirder? Maybe add a prefix argument handling to log-view-diff? From debbugs-submit-bounces@debbugs.gnu.org Thu May 16 16:26:20 2019 Received: (at 35624) by debbugs.gnu.org; 16 May 2019 20:26:20 +0000 Received: from localhost ([127.0.0.1]:56572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hRMxI-00034q-5a for submit@debbugs.gnu.org; Thu, 16 May 2019 16:26:20 -0400 Received: from insect.birch.relay.mailchannels.net ([23.83.209.93]:44082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hRMxB-00033l-Az for 35624@debbugs.gnu.org; Thu, 16 May 2019 16:26:18 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id DBFBB503E8D; Thu, 16 May 2019 20:17:32 +0000 (UTC) Received: from pdx1-sub0-mail-a63.g.dreamhost.com (100-96-6-41.trex.outbound.svc.cluster.local [100.96.6.41]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id AEBB6503E5B; Thu, 16 May 2019 20:17:29 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a63.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Thu, 16 May 2019 20:17:32 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Versed-Hysterical: 629a043d73072b36_1558037850288_1193567568 X-MC-Loop-Signature: 1558037850288:546104249 X-MC-Ingress-Time: 1558037850287 Received: from pdx1-sub0-mail-a63.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a63.g.dreamhost.com (Postfix) with ESMTP id 9947B83569; Thu, 16 May 2019 13:17:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=C0idobAtxQXl+4mg3NTSB8j8YE8=; b= OOXtTqYaVClbx+UKnKs7pCYjAKXULPUwBj/34Y3YKt56OXDF/kfTtuW9bbtthbpu XaJYXuX6x0GA0x9JI4XGQnsrVBusYJAjJSAGqx0az7olBmx2rRAdb/2yCoNYfKDb 6w/MSYMqA/9tjLDcHx8Izv1jVzc7TBMEDiYBJpKYK7o= Received: from mail.jurta.org (m91-129-96-230.cust.tele2.ee [91.129.96.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a63.g.dreamhost.com (Postfix) with ESMTPSA id 3947583564; Thu, 16 May 2019 13:17:23 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a63 From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#35624: log-view-diff regression Organization: LINKOV.NET References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> Date: Thu, 16 May 2019 23:04:21 +0300 In-Reply-To: <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> (Dmitry Gutov's message of "Thu, 16 May 2019 01:05:11 +0300") Message-ID: <878sv6jhdm.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddruddttddgudeghecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledrleeirddvfedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleeirddvfedtpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgepud X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>> You can also type 'C-u C-x v =', then '1.4', RET and C-j to omit the end >>> version. That would also show the diff against the workfile. >> >> 10 keys more to type. > > You would normally paste the revision. And 'C-x v =' is already in my > muscle memory. Coping and then pasting requires more keypresses. >> When this feature was enabled, I used it every day. > > Was it back in the days of CVS? Nowadays I'm using it every day on Git: first I make the log buffer writable by typing `C-x C-q', then type `C-o' at the top of the log buffer to insert an empty line to make this feature available. >> Currently I'm forced >> to type 10 more keys every time. I agree the log not to look weirder, >> so better to not display Working. > > Could you explain what are you using it for? I understand a diff between > revisions, and I understand a diff of the working tree against the index, > but this kind of a diff seems pretty unusual. The last time I used this feature today: I needed to revert some previous commits partially, and before committing the reverting changes I needed to check if necessary changes were reverted. To do this, I inserted an empty line at the top and set the beginning of the region here, then set the end of the region on the line with the revision that started a set of related commits. Then just typed `=' and the displayed diff confirmed that the right hunks were reverted, showing the diff as it should have looked like without these reverted changes. >> Or course, you didn't think about it, because you didn't know it exists. >> I didn't know too until discovered it accidentally. After that it hard >> to lose this ability. The problem is that this useful feature is >> undocumented. Here is the patch that documents it: > > I have tried to imagine using it, but it's still hard. Maybe doing it once > a few days to compare the current progress against the master > branch. Yes, I believe a try is worth a thousand words. > Though C-u C-x v d master RET C-j might be faster that looking for > the revision that corresponds to the master branch in the log. The log buffer helps to select the revisions to compare because it displays dates and summaries of commits. From debbugs-submit-bounces@debbugs.gnu.org Sun May 19 16:12:34 2019 Received: (at 35624-done) by debbugs.gnu.org; 19 May 2019 20:12:34 +0000 Received: from localhost ([127.0.0.1]:35591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSSAc-0005U0-69 for submit@debbugs.gnu.org; Sun, 19 May 2019 16:12:34 -0400 Received: from golden.birch.relay.mailchannels.net ([23.83.209.73]:49585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSSAa-0005Ts-FT for 35624-done@debbugs.gnu.org; Sun, 19 May 2019 16:12:33 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id D51D82C14A3; Sun, 19 May 2019 20:12:30 +0000 (UTC) Received: from pdx1-sub0-mail-a42.g.dreamhost.com (100-96-86-18.trex.outbound.svc.cluster.local [100.96.86.18]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 7FD132C14D1; Sun, 19 May 2019 20:12:29 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a42.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Sun, 19 May 2019 20:12:30 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Lettuce-Befitting: 20a1bfcc3c828732_1558296750668_2845379121 X-MC-Loop-Signature: 1558296750668:2373877559 X-MC-Ingress-Time: 1558296750668 Received: from pdx1-sub0-mail-a42.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a42.g.dreamhost.com (Postfix) with ESMTP id B180C80050; Sun, 19 May 2019 13:12:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=LUC659XFvenTV0ifC6Tna1NyHKY=; b= t/EEMVxY6ACryLsMRpSOUQLbUpe/GBcrMfLc2rxvNUqyBNKBsTMJqN3EpKzw2Ucu WMmgv7kfqU+XvnJPxGkCT2mljT4EDW5n2BceV9QbeSnKQtO3JMdU+/alzvUTbNZL 42XDDatrE8yXWPbkCSRbzmp8+KOKk9cmfYOp1WK3EwI= Received: from mail.jurta.org (m91-129-96-230.cust.tele2.ee [91.129.96.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a42.g.dreamhost.com (Postfix) with ESMTPSA id ED73A8004E; Sun, 19 May 2019 13:12:23 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a42 From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#35624: log-view-diff regression Organization: LINKOV.NET References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> Date: Sun, 19 May 2019 23:11:41 +0300 In-Reply-To: <878sv6jhdm.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 16 May 2019 23:04:21 +0300") Message-ID: <8736laqk5e.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddruddtiedgudehtdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledrleeirddvfedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleeirddvfedtpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgeptd X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624-done Cc: 35624-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Yes, I believe a try is worth a thousand words. So let's try this. Pushed to master. From debbugs-submit-bounces@debbugs.gnu.org Mon May 20 19:29:15 2019 Received: (at 35624) by debbugs.gnu.org; 20 May 2019 23:29:15 +0000 Received: from localhost ([127.0.0.1]:38282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSriV-0005KI-7M for submit@debbugs.gnu.org; Mon, 20 May 2019 19:29:15 -0400 Received: from mail-wm1-f49.google.com ([209.85.128.49]:56290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSriR-0005K1-4Y for 35624@debbugs.gnu.org; Mon, 20 May 2019 19:29:13 -0400 Received: by mail-wm1-f49.google.com with SMTP id x64so966407wmb.5 for <35624@debbugs.gnu.org>; Mon, 20 May 2019 16:29:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=W/IwN1ulWNe/aNg9xeOd4ndVkZ1nHcoE6u2OM4LHKiQ=; b=Vwrd58xtgEX7S86cuyrdP+mbnwoUuWtguhtzXOY20Uck1M4dQgTesDeZYTsEoOTPtZ +RfZivv+nNBbb/dxKUUeJV442yocilxOwMbpENvJ4Vbm5nT2A1Z7sXO2S1a/5j396l+c td7PgAd27UQfFlY2+Pj3RCvcinmJ41eFmI8Tt3Qd1FjvA4bo+T7RoyodHlLilkRcrejP IGAEMtgdtPmPqRLPHN3DXYGjZhG8Twdq1IW2/STHTjitQuPKaNKhn8K5qTiOqZ5rodXe T1oRvt8+uttY6fNOPNwHk5SxPmdVF4I89BdZZ7aMUUL5UraCqOKjHdaaWMUWXXIX0AMQ klxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=W/IwN1ulWNe/aNg9xeOd4ndVkZ1nHcoE6u2OM4LHKiQ=; b=Lz1b+GvTfult5683jhffBT6R3VA7b6vlBrHkmS5c60Xly8XXBQ4MpUMrKE3YSerCxL DIsamB+bqGTS2Mqq6K4xuZJaM81fxtnM4DRaanIGddraZbvwVwSOVylcWV2/WEpoH+nk jx02T4q7LALN8Rn4UI60HHwki4tQVj567O3DOSG3EUPpDkufnJem5wtVOQqj4iS0W+AI D4Wj1901eTouJXt4B8XJ2tHiwJzHthl7KawwQ3oDJWLQ3G8jNXCJHUx6Im2WaDtC1BRp jwo1XNMdKqZmqMNn3i5PIPmIEwSSsTU64vGgUokK7/go84EhfrxBOQ2Z2vDXvvs46wmN sPYg== X-Gm-Message-State: APjAAAVr8aUiC/6uyqSLvzDpRvzBOQo2h0SW/OBarkqrV7o1eFVHl1jb 2ipAP2RS6Kb1c8uwEVtzc9g= X-Google-Smtp-Source: APXvYqy/j1G1X2XDsa9GivLz2ObpzJzwOsTPx0XuAZzNrNpP/kOSNFpOHA9o0dd5aRNX/Fkt3jDbkQ== X-Received: by 2002:a1c:1f47:: with SMTP id f68mr1081640wmf.57.1558394945226; Mon, 20 May 2019 16:29:05 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id z5sm1354262wmi.34.2019.05.20.16.29.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 May 2019 16:29:03 -0700 (PDT) Subject: Re: bug#35624: log-view-diff regression To: 35624@debbugs.gnu.org, juri@linkov.net References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> <8736laqk5e.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> Date: Tue, 21 May 2019 02:29:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <8736laqk5e.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 19.05.2019 23:11, Juri Linkov wrote: >> Yes, I believe a try is worth a thousand words. > > So let's try this. Pushed to master. Sorry, I still don't like how it looks. For the main purpose of the log buffer, the empty first line is weird (saying "working revision" would be just as weird). I could maybe live with it if were 1-character tall (and in a terminal, maybe invisible until you move point to it), but I'm still not convinced personally. And I see no others voting on this feature. One alternative which I have already mentioned is to make a different command handle this. E.g. 'C-u d' might diff workfile and the revision at point. This actually seems faster that go to bob and create the necessary region. From debbugs-submit-bounces@debbugs.gnu.org Mon May 20 19:40:04 2019 Received: (at 35624) by debbugs.gnu.org; 20 May 2019 23:40:04 +0000 Received: from localhost ([127.0.0.1]:38293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSrsy-0005eo-A5 for submit@debbugs.gnu.org; Mon, 20 May 2019 19:40:04 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:37355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSrsw-0005e9-3j for 35624@debbugs.gnu.org; Mon, 20 May 2019 19:40:02 -0400 Received: by mail-wr1-f49.google.com with SMTP id e15so16436322wrs.4 for <35624@debbugs.gnu.org>; Mon, 20 May 2019 16:40:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yIoHh9Q2o0LgGQM8zOKBVoEp/HMdMyFh8JvvChlDMvk=; b=ly8iUmJO9H/1PvMsidvenZ4MwY59rAttf0gQ2S/x0P30/v5Re18g/4Dgnf1aV1Otpl bktsLUIA3CVdThBD3A8Mipwp1qe9/GxfVj2CU503qt8p1MBX0SPwgCzQNkOJdLaEMu9i oBXciXsNkOpMNlANzZQA+P3PpDCwgTDJU5rhrkHK2/7k5lWo2iHuajiPae8CKdG7qRKD tT68gFb56UrWXl+60/rFlCDRwpxq09p28B9iX623a1Uu7jvQbD4KJLIMWR91/NLxk9JD /8m+Mps34Lj58jDvk+MUuQogrsxlK8w4Jm9OJtWrbj7aOFsqk/0nzn//9u/4oE40Qn5W GDgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yIoHh9Q2o0LgGQM8zOKBVoEp/HMdMyFh8JvvChlDMvk=; b=c3bjYaMrP3L+Pij0pADFdQmZ0BVCOa/Kmlp/SoFnYxxnqE7eZpZYfCarJ60yPRUmHo gCaB+RKX2+2uPhz48w6BZaZD0lHUIQ2BiBJ0nTrkHHAWC/uyAATsbGx+scVYXawK0iLp d+V8WKVpftQWvmpZrpK8pm6ZVp9tB4/XW2YPxXNk9RKMcGUnhuB0v6C28Bmf48Uf6pFq u/eAnzHWDby23xTbmSdlUqFgZbWlSIJfKKAZ3RNigEj+J/Xdrkdkq7lYnbF8ExtrJ4EA c/idgbe7vWJcMt6IkvXP0kJZn3n4P24QnrnuuP7T2toom4R3apmgTCWqBN/z60tPsM/x hyUg== X-Gm-Message-State: APjAAAXAl7JCFI6wGdh+0j6ktx5JDyZKCyJdCO6z/Mx4zd5b+cdeJ6Tu rv9+J4KGYJntVVgMqG9Vwohlh4PG X-Google-Smtp-Source: APXvYqw5ntMg2koM2cENEBwWuGxKtFBQdF/FgB09WKzM0UIDcMSm5/bV/6jw4S+mnMmuxcSmFGHr+w== X-Received: by 2002:a5d:4fc6:: with SMTP id h6mr34093118wrw.307.1558395595040; Mon, 20 May 2019 16:39:55 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id 6sm23820897wrd.51.2019.05.20.16.39.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 May 2019 16:39:54 -0700 (PDT) Subject: Re: bug#35624: log-view-diff regression To: Juri Linkov References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <35446787-f430-4ee0-5901-1eeccbd9ebba@yandex.ru> Date: Tue, 21 May 2019 02:39:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <878sv6jhdm.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 16.05.2019 23:04, Juri Linkov wrote: >> Was it back in the days of CVS? > > Nowadays I'm using it every day on Git: first I make the log buffer > writable by typing `C-x C-q', then type `C-o' at the top of the log > buffer to insert an empty line to make this feature available. Interesting. I could probably just use Git from console for this, though. >> Could you explain what are you using it for? I understand a diff between >> revisions, and I understand a diff of the working tree against the index, >> but this kind of a diff seems pretty unusual. > > The last time I used this feature today: I needed to revert some > previous commits partially, and before committing the reverting changes > I needed to check if necessary changes were reverted. OK. But just for the sake of the argument, here's how you could do the same thing: 1. You do the "partially revert" commit, then check whether it does what you want it to do without having to insert the extra line. 2. If it doesn't, you make the necessary extra change and do an amend commit (C-x v v; C-x C-e; C-c C-c), then goto 1. Otherwise end scenario. >> I have tried to imagine using it, but it's still hard. Maybe doing it once >> a few days to compare the current progress against the master >> branch. > > Yes, I believe a try is worth a thousand words. I actually meant that it's hard for me to imagine really needing this. Or doing it more often than once in a several days. And I do sometimes revert parts of commits, usually doing something other than what you explained. >> Though C-u C-x v d master RET C-j might be faster that looking for >> the revision that corresponds to the master branch in the log. > > The log buffer helps to select the revisions to compare > because it displays dates and summaries of commits. How about 'C-u d', then? Like I suggested in the other email. From debbugs-submit-bounces@debbugs.gnu.org Tue May 21 16:20:27 2019 Received: (at 35624) by debbugs.gnu.org; 21 May 2019 20:20:27 +0000 Received: from localhost ([127.0.0.1]:41074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTBFL-0001eD-5k for submit@debbugs.gnu.org; Tue, 21 May 2019 16:20:27 -0400 Received: from ostrich.birch.relay.mailchannels.net ([23.83.209.138]:4824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTBFI-0001dw-Fg for 35624@debbugs.gnu.org; Tue, 21 May 2019 16:20:25 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 5695722CE9; Tue, 21 May 2019 20:20:23 +0000 (UTC) Received: from pdx1-sub0-mail-a9.g.dreamhost.com (100-96-38-8.trex.outbound.svc.cluster.local [100.96.38.8]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id D886D22CDB; Tue, 21 May 2019 20:20:20 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a9.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Tue, 21 May 2019 20:20:23 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Dime-Macabre: 501514f50806f9f6_1558470022416_2668904642 X-MC-Loop-Signature: 1558470022416:119843146 X-MC-Ingress-Time: 1558470022416 Received: from pdx1-sub0-mail-a9.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTP id AA08680469; Tue, 21 May 2019 13:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=BX2GP6WdKHEFsWyDpAVpvkkVzKM=; b= r9Xl88hZzqhwbO49KbsFd+ZbwJg+tVjm9gbym/NPykrBHxXGIO2bw6jk0cHpcRXd 3R8OriEpDuxgsv5VvCJWp7YwJyrMiOSqF7vrenOlV1lCDOMQu1GX3TWytEdZXnq7 clCZA6gtzOIeDyj/TyFJFI6kSrGJ9nmRG26tLt9sRqY= Received: from mail.jurta.org (m91-129-96-230.cust.tele2.ee [91.129.96.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTPSA id 1C9AE8045C; Tue, 21 May 2019 13:20:10 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a9 From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#35624: log-view-diff regression Organization: LINKOV.NET References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> <8736laqk5e.fsf@mail.linkov.net> <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> Date: Tue, 21 May 2019 23:12:14 +0300 In-Reply-To: <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> (Dmitry Gutov's message of "Tue, 21 May 2019 02:29:00 +0300") Message-ID: <87lfyzy3c1.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddruddutddgudeglecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledrleeirddvfedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleeirddvfedtpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgepud X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > One alternative which I have already mentioned is to make a different > command handle this. E.g. 'C-u d' might diff workfile and the revision at > point. This actually seems faster that go to bob and create the > necessary region. This is not self-evident and not WYSIWYG as the visual region selection is. > For the main purpose of the log buffer, the empty first line is weird > (saying "working revision" would be just as weird). vc-rcs and vc-cvs inserts 12-lines long header in the log buffer and no one complained for several decades :) OTOH, when recently Android developers changed the position of the clock from the right side of the screen to the left, billions of users silently adapted their habits to the new position without protests :( > I could maybe live with it if were 1-character tall (and in a terminal, > maybe invisible until you move point to it) It's already 1-character tall. But it you meant 1-pixel tall, then I agree it's a good idea (like 1-pixel line is already used in log-edit.el): diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index b6feb3b8d1..238b04929b 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1018,7 +1018,7 @@ vc-git-print-log ;; read-only. (let ((inhibit-read-only t)) (with-current-buffer buffer - (insert "\n") + (insert (propertize "\n" 'font-lock-face '(:height 0.1))) (apply 'vc-git-command buffer 'async files (append From debbugs-submit-bounces@debbugs.gnu.org Tue May 21 16:39:50 2019 Received: (at 35624) by debbugs.gnu.org; 21 May 2019 20:39:50 +0000 Received: from localhost ([127.0.0.1]:41098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTBY5-000291-Ny for submit@debbugs.gnu.org; Tue, 21 May 2019 16:39:50 -0400 Received: from mail-wm1-f45.google.com ([209.85.128.45]:54110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTBY3-00028o-Q4 for 35624@debbugs.gnu.org; Tue, 21 May 2019 16:39:48 -0400 Received: by mail-wm1-f45.google.com with SMTP id 198so4279737wme.3 for <35624@debbugs.gnu.org>; Tue, 21 May 2019 13:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8lhMpoKzpCqr7wXbXfy/uS/BqLtvGochex6VfM1zLX4=; b=TF9fOiW8KC/+vhQtwfxxc9JMlz7DqB2oKOfAGigjCPDM2XykIWizj9GeuLKXQv0bsp uzwG6fADDjynsVr5Vh3J79la7s3/6O4gkY5UJ3zm4gv6bHtWyhl9MJZuIkDUnQGmJkvU amDYJ5KuG1CVBrthJlaoxlaCj1LJKHv7iFJSDLaKZU1GKCGFPa4kbNtkMupxbyVuo6t+ KTmSJ3bbIzpVktItlDtV/Tzj/1E/vzoZ7/M8qHCMijd94QO5vPHOv/KKZK2Cx5qiynkV yMWENXwpbiSAd5/QGD1P/5oLqDrS5oAthogB8WrejI6d3FdwrC3AC+KdtU63PUMg0pyj +5hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8lhMpoKzpCqr7wXbXfy/uS/BqLtvGochex6VfM1zLX4=; b=e2Qe7oRtYIdufoDoPfcXnMrQsQ2+QB9TvYInSV1eldVEOJfjOhrn5oonrXZBY8WthY v8XS6J15RX4iANNmHw7ju/9EAMIjBkceFF1h+RhzwMnp96cGePSlcvrgU5wHnkaWkq5Q 8F56E8ThXS//q4knEGs2/AkqXNAYd/IWqk7YqEja/tvWpBisIGFx6N43QqamZP2E0yJZ RFLSkPrQ//ppBVGn4MmmOLXswkiln8FgvEQ3zPO/srxSIbqUUu0ZpbL6bKLm8s1IDF72 2UVQLOohqE4rjxlhRHzARj3iTH+20l1ZjyYGrxld9xpVR5nsnn/V5Dr1VixQPq2Ww8Mf 4+fA== X-Gm-Message-State: APjAAAWIcRXkYC26yu2MefyNKrwT17eNkokdDqebIzv8bavUI0OP3zPu tTEkGP3uez8lg8s53A0N12FZ+F8k X-Google-Smtp-Source: APXvYqyToMe02EnZp9MmYK+Ptpmf1JONizi4n7xoyFdlIDt9XEOaNcfXGMkrnr9u8Rbfe+2qN/laqA== X-Received: by 2002:a1c:b743:: with SMTP id h64mr5008415wmf.16.1558471181186; Tue, 21 May 2019 13:39:41 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id y40sm42140951wrd.96.2019.05.21.13.39.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 May 2019 13:39:39 -0700 (PDT) Subject: Re: bug#35624: log-view-diff regression To: Juri Linkov References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> <8736laqk5e.fsf@mail.linkov.net> <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> <87lfyzy3c1.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Tue, 21 May 2019 23:39:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <87lfyzy3c1.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 21.05.2019 23:12, Juri Linkov wrote: >> One alternative which I have already mentioned is to make a different >> command handle this. E.g. 'C-u d' might diff workfile and the revision at >> point. This actually seems faster that go to bob and create the >> necessary region. > > This is not self-evident and not WYSIWYG as the visual region selection is. If showing diffs was the main purpose of the log buffer, I might agree with you. Okay, it's not self-evident, but going above the first visible line is not self-evident either. For instance, most users would never on purpose try C-p instead of p to get to the line before the first revision, especially if it's 1-pixel tall like your last patch did. Not to mention that most users would not simply think to create an active region before pressing 'd'. >> For the main purpose of the log buffer, the empty first line is weird >> (saying "working revision" would be just as weird). > > vc-rcs and vc-cvs inserts 12-lines long header in the log buffer > and no one complained for several decades :) Guess that's because those lines show something remotely helpful and pertinent to the main purpose of the buffer. > OTOH, when recently Android developers changed the position of the clock > from the right side of the screen to the left, billions of users silently > adapted their habits to the new position without protests :( We're talking about adding a banana to a clock hand. >> I could maybe live with it if were 1-character tall (and in a terminal, >> maybe invisible until you move point to it) > > It's already 1-character tall. > > But it you meant 1-pixel tall, then I agree it's a good idea > (like 1-pixel line is already used in log-edit.el): Yes, that's what I meant, sorry. > diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el > index b6feb3b8d1..238b04929b 100644 > --- a/lisp/vc/vc-git.el > +++ b/lisp/vc/vc-git.el > @@ -1018,7 +1018,7 @@ vc-git-print-log > ;; read-only. > (let ((inhibit-read-only t)) > (with-current-buffer buffer > - (insert "\n") > + (insert (propertize "\n" 'font-lock-face '(:height 0.1))) > (apply 'vc-git-command buffer > 'async files > (append It's better, but a) it shifts the buffer text by 1 pixel, which I actually find annoying now that I look at the bottom entry that fits in that window, b) from your side, it should look suboptimal as well, because the cursor is basically invisible when it's on the top line (speaking of WYSIWYG). If you really must have it this way, do we have an example of invisible text expanding when cursor moves inside, and then contracting when it's out again? Meaning if would look like an empty line you wanted after you press 'C-p', but not visible at all otherwise. From debbugs-submit-bounces@debbugs.gnu.org Tue May 21 17:34:30 2019 Received: (at 35624) by debbugs.gnu.org; 21 May 2019 21:34:30 +0000 Received: from localhost ([127.0.0.1]:41146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTCP0-0005b1-4a for submit@debbugs.gnu.org; Tue, 21 May 2019 17:34:30 -0400 Received: from quail.birch.relay.mailchannels.net ([23.83.209.151]:64636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTCOx-0005ar-UU for 35624@debbugs.gnu.org; Tue, 21 May 2019 17:34:28 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id F179521E59; Tue, 21 May 2019 21:34:25 +0000 (UTC) Received: from pdx1-sub0-mail-a9.g.dreamhost.com (100-96-38-7.trex.outbound.svc.cluster.local [100.96.38.7]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 595B121808; Tue, 21 May 2019 21:34:25 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a9.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Tue, 21 May 2019 21:34:25 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Unite-Bubble: 6e8a33e100ab5372_1558474465759_465485739 X-MC-Loop-Signature: 1558474465759:2757318879 X-MC-Ingress-Time: 1558474465758 Received: from pdx1-sub0-mail-a9.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTP id EF92480459; Tue, 21 May 2019 14:34:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=NXDI+4qzd8zILPFIqfwAyzofWSQ=; b= BL18yQCiH7IDU/pWLGjC78ZFTXEvDpctmYT3LQomo4D3OwfUKUdWw6XJZl66rQKu 3XAM2mfQ5i3UAjGz5teH+SMqLuVm2FxDa5n6gHaRg4ZhbjLOJiJywXU2dqeGeMXb HgEyJ+36DTYAGT+NlU474zvfqusdMH6yQUGd/cLS1q4= Received: from mail.jurta.org (m91-129-96-230.cust.tele2.ee [91.129.96.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTPSA id 9B3C68045B; Tue, 21 May 2019 14:34:20 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a9 From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#35624: log-view-diff regression Organization: LINKOV.NET References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> <8736laqk5e.fsf@mail.linkov.net> <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> <87lfyzy3c1.fsf@mail.linkov.net> Date: Wed, 22 May 2019 00:32:01 +0300 In-Reply-To: (Dmitry Gutov's message of "Tue, 21 May 2019 23:39:28 +0300") Message-ID: <87y32zv6i6.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddruddutddgudeigecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehmtderredtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledrleeirddvfedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleeirddvfedtpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgeptd X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain > Not to mention that most users would not simply think to create an active > region before pressing 'd'. This feature is documented. > It's better, but a) it shifts the buffer text by 1 pixel, which I actually > find annoying now that I look at the bottom entry that fits in that window, My bottom line is partially visible in all buffers anyway. > b) from your side, it should look suboptimal as well, because the cursor is > basically invisible when it's on the top line (speaking of WYSIWYG). Maybe just set window-start to the first non-empty line initially, thus moving the empty line out of screen? > If you really must have it this way, do we have an example of invisible > text expanding when cursor moves inside, and then contracting when it's out > again? Meaning if would look like an empty line you wanted after you press > 'C-p', but not visible at all otherwise. Yes, this is possible: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=vc-git-print-log-cursor-sensor.patch diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index b6feb3b8d1..29acb047c6 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1018,7 +1018,11 @@ vc-git-print-log ;; read-only. (let ((inhibit-read-only t)) (with-current-buffer buffer - (insert "\n") + (insert (propertize "\n" + 'invisible t + 'cursor-sensor-functions + (list #'(lambda (_w _p dir) + (visible-mode (if (eq dir 'entered) 1 0)))))) (apply 'vc-git-command buffer 'async files (append @@ -1122,7 +1126,8 @@ vc-git-log-view-mode (1 'change-log-acknowledgment) (2 'change-log-acknowledgment)) ("^Date: \\(.+\\)" (1 'change-log-date)) - ("^summary:[ \t]+\\(.+\\)" (1 'log-view-message))))))) + ("^summary:[ \t]+\\(.+\\)" (1 'log-view-message)))))) + (cursor-sensor-mode 1)) (defun vc-git-show-log-entry (revision) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 21 17:53:01 2019 Received: (at 35624) by debbugs.gnu.org; 21 May 2019 21:53:01 +0000 Received: from localhost ([127.0.0.1]:41178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTCgv-00063K-F2 for submit@debbugs.gnu.org; Tue, 21 May 2019 17:53:01 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:51627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTCgt-00062z-Ln for 35624@debbugs.gnu.org; Tue, 21 May 2019 17:53:00 -0400 Received: by mail-wm1-f50.google.com with SMTP id c77so141997wmd.1 for <35624@debbugs.gnu.org>; Tue, 21 May 2019 14:52:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lQvF/HiiPhexUYMmIitvVNo9CBa41+X3mZ3ADBYG1Ok=; b=D7qMuP/8zfQpqgwAGxglFH5FFKftrzP0OQ49EcWtD982VeTk6hBvu3OvFhpCviGKVp n7C4HN+rvsCV/5cvYxRq1weEoXWMTY4prGivmhDI8mmsywslf52ESvmD/g+fBjHKuyQ5 5NMEZQwYNCRwQLtQL1yVpvAhrpDZJc63KEp61WSPlu3vhaBhwx5JO9brzQEEeq8V6UoW J89ZzDFZbnc/O3CrvmLyBHyI3spqNJ4RZySUeHkTJ0Xeh9UkrgFpenD5TAsTBcsv7oTr ylzzJNPdYKyh+m2j06xZSikfdQI517UcIgXAgTr3A8QFs4YjlbeSet5nZW0JxnXRjWm0 QYBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lQvF/HiiPhexUYMmIitvVNo9CBa41+X3mZ3ADBYG1Ok=; b=IZBwoGyplK116T7Np1fgYx49TeioImR4djScvdi/U1WrsknxI+Oz/BfhbdjS2tpEyT ViodFW5RLi2u3sWLocc/3nGmVQ+4C/j6ui+omsYqqaz/wFJdWYayYjLUL/jRC8pn6t7v v6XBzIUR+uSJUCQKDcRXT2AXTyttuSRmLc5OYxF7BpLCYiWEKYKXHJslIlJ3Ia401ZIV dkBbX/4MI2vkojhHyRg/VbjlanD5YYPADuXxkNUzacEL5igWT6RViwlDAopemIYTNodL Q+dELoaUiJkKv7QEXX5k7UOKCOH/jfH4puLJd8s7lgdkdN8Xpj+xDjl44zmZhnGqOJDA O08A== X-Gm-Message-State: APjAAAV6/uBPQgp+EXEzyPaJWJehYnibSRJiMlbolpeAWYm//t1rOCy/ 4/9CRznYzXHQTRna42yfbvAz1W/S X-Google-Smtp-Source: APXvYqxJPvGErHws3xCImNH2KmggfPSSLw7zP2H3/zu4o34/WpQjbbAxVIL92MrsnNRHbAW+s+oalw== X-Received: by 2002:a7b:cd0e:: with SMTP id f14mr4680439wmj.127.1558475573424; Tue, 21 May 2019 14:52:53 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id j28sm40347587wrd.64.2019.05.21.14.52.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 May 2019 14:52:52 -0700 (PDT) Subject: Re: bug#35624: log-view-diff regression To: Juri Linkov References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> <8736laqk5e.fsf@mail.linkov.net> <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> <87lfyzy3c1.fsf@mail.linkov.net> <87y32zv6i6.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Wed, 22 May 2019 00:52:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <87y32zv6i6.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 22.05.2019 0:32, Juri Linkov wrote: >> Not to mention that most users would not simply think to create an active >> region before pressing 'd'. > > This feature is documented. Whatever new feature of 'd' would be documented as well. >> It's better, but a) it shifts the buffer text by 1 pixel, which I actually >> find annoying now that I look at the bottom entry that fits in that window, > > My bottom line is partially visible in all buffers anyway. It's not a huge issue, but I like the other options better. >> b) from your side, it should look suboptimal as well, because the cursor is >> basically invisible when it's on the top line (speaking of WYSIWYG). > > Maybe just set window-start to the first non-empty line initially, > thus moving the empty line out of screen? Thought about this too. Could work, but the fact that it's not easy to "undo" the view if you pressed 'C-p' accidentally is a downside. >> If you really must have it this way, do we have an example of invisible >> text expanding when cursor moves inside, and then contracting when it's out >> again? Meaning if would look like an empty line you wanted after you press >> 'C-p', but not visible at all otherwise. > > Yes, this is possible: It almost works fine, but going from the second log entry to the first with 'p' while at bol leads to the first (empty) line becoming visible. From debbugs-submit-bounces@debbugs.gnu.org Wed May 22 17:52:22 2019 Received: (at 35624) by debbugs.gnu.org; 22 May 2019 21:52:22 +0000 Received: from localhost ([127.0.0.1]:43213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTZ9q-0008In-Jn for submit@debbugs.gnu.org; Wed, 22 May 2019 17:52:22 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:46578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTZ9o-0008IY-5l for 35624@debbugs.gnu.org; Wed, 22 May 2019 17:52:20 -0400 Received: by mail-wr1-f51.google.com with SMTP id r7so3918098wrr.13 for <35624@debbugs.gnu.org>; Wed, 22 May 2019 14:52:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wu68dTiv7PP7gt9R8BsBAUuLDrZcNZ9Q5tnoGhIQZ7E=; b=X4eRnoaTcHDiu1DWCPSFOvGslpDY103/G+MCvuvrlIaV5D07Bh2gaLjNWk/8aDTejq 211WsOjpG/iSxRne9hkw0r5Y3UZ5jLsgneYD7NCqyZsPApVA9hvoizA21/3p7yykzVx/ j3NSt8ituxVBEd7q91YOLnt577YiN2hnqDTvoH7cjbZyU1rN72+xwgKS4Px8J+t8IatB Io3kmYAcaDdjMwq/vNf6Wl80S+xHjHUcr46ylQnzBnN9GTrjg7WUvpW9mUyJWdTCDKao ReuU7JAIVV0KD9Ry9C4oc1UeTcIygyE73PHk9JhqE+UW0LWx9At9SE8jjl+j7d5zm1Ky ajRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wu68dTiv7PP7gt9R8BsBAUuLDrZcNZ9Q5tnoGhIQZ7E=; b=BHPYXUopC2UdH/QcIHHzMq7GF9d3JUc7pgOcogPX0h4MGM6xWcMfLN+/+Mycc35ANW S4SaQiyqe+lrUhqzAAN6N7ZPSaRl76U/QVIVO5vAvSusMs9CypFGbWMzEidSh1yUvJW7 ybgDWaDBYLAIWSDnac8w3zG7tJ0DrY64oxBF3Fj33d3Ece2NDvctVTzmH99Zud23V8YQ 5poneuDYQKQAkXV3p78mGNwnV7qe0fVsvxNHm4aXmH49juALnpQsTm3jcjWWQr71ji4V vLdUYZAZlhmgjyg+ePDSjEUM1lA+IO0GTu24B0Ft52NRwm+X8DCg7BsUblsFtLIlNYB0 Y4hw== X-Gm-Message-State: APjAAAX3dhrrAK9TPf73XtnorCJeki60xMNredfsgwNVrPvZxI7Exftm 0/5SefJRVc56H2NcKt8w7/K7li03 X-Google-Smtp-Source: APXvYqzrnu+G0IzoQXHKO2hoicggVzWoxUbWaRZ3d9KDkAmL/J1fDf/3MS2IuAZKdLA4BKVj3ysThw== X-Received: by 2002:adf:ce07:: with SMTP id p7mr42679671wrn.241.1558561933845; Wed, 22 May 2019 14:52:13 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id z202sm16236635wmc.18.2019.05.22.14.52.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 May 2019 14:52:11 -0700 (PDT) Subject: Re: bug#35624: log-view-diff regression From: Dmitry Gutov To: Juri Linkov References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> <8736laqk5e.fsf@mail.linkov.net> <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> <87lfyzy3c1.fsf@mail.linkov.net> <87y32zv6i6.fsf@mail.linkov.net> Message-ID: Date: Thu, 23 May 2019 00:52:10 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 22.05.2019 0:52, Dmitry Gutov wrote: > It almost works fine, but going from the second log entry to the first > with 'p' while at bol leads to the first (empty) line becoming visible. BTW, if we implement this, here's something we could add as well: Instead of the empty line, how about it will contain some quick help string for the 'd' command, so that the user is not too puzzled if they hit 'C-p' by accident? From debbugs-submit-bounces@debbugs.gnu.org Thu May 23 17:10:50 2019 Received: (at 35624) by debbugs.gnu.org; 23 May 2019 21:10:50 +0000 Received: from localhost ([127.0.0.1]:45445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTuzC-0006k2-Cn for submit@debbugs.gnu.org; Thu, 23 May 2019 17:10:50 -0400 Received: from orchid.birch.relay.mailchannels.net ([23.83.209.137]:11065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTuzA-0006jq-0a for 35624@debbugs.gnu.org; Thu, 23 May 2019 17:10:48 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 1684F2C2F09; Thu, 23 May 2019 21:10:47 +0000 (UTC) Received: from pdx1-sub0-mail-a94.g.dreamhost.com (100-96-85-75.trex.outbound.svc.cluster.local [100.96.85.75]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id D073F2C2B5F; Thu, 23 May 2019 21:10:41 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a94.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Thu, 23 May 2019 21:10:47 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Abaft-Abiding: 1769b3306bdf6d66_1558645842530_663361645 X-MC-Loop-Signature: 1558645842530:4202320881 X-MC-Ingress-Time: 1558645842530 Received: from pdx1-sub0-mail-a94.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a94.g.dreamhost.com (Postfix) with ESMTP id A876280160; Thu, 23 May 2019 14:10:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=A0jF+c/vjFLNMKsZKNfcpiZvFPc=; b= zTcbLr2MAwqaXnXDYgo18oz2XNFfWRHDN0jRYnH/Qtqr1VlJ6iyi6FWnH37W+zSs uVQ0/vUn4mg9QWJ4CeWakIpI+32vjHkjij6X7Dhe1rhKkUZ168xcF3O1qbdPtYB1 Ha0EBFS/AjkpqYWoBpMPy6T0fr2ijh6KGR3ZZKPyvN8= Received: from mail.jurta.org (m91-129-96-230.cust.tele2.ee [91.129.96.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a94.g.dreamhost.com (Postfix) with ESMTPSA id AA48D80159; Thu, 23 May 2019 14:10:34 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a94 From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#35624: log-view-diff regression Organization: LINKOV.NET References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> <8736laqk5e.fsf@mail.linkov.net> <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> <87lfyzy3c1.fsf@mail.linkov.net> <87y32zv6i6.fsf@mail.linkov.net> Date: Fri, 24 May 2019 00:07:25 +0300 In-Reply-To: (Dmitry Gutov's message of "Wed, 22 May 2019 00:52:49 +0300") Message-ID: <87r28o3mnm.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddruddugedgudeivdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehmtderredtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecuffhomhgrihhnpehgnhhurdhorhhgnecukfhppeeluddruddvledrleeirddvfedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleeirddvfedtpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgeptd X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain >> Maybe just set window-start to the first non-empty line initially, >> thus moving the empty line out of screen? > > Thought about this too. Could work, but the fact that it's not easy to > "undo" the view if you pressed 'C-p' accidentally is a downside. "undo" is a minuscule issue, or rather a non-issue at all, whereas the idea is good. Created a feature request bug#35860 >>> If you really must have it this way, do we have an example of invisible >>> text expanding when cursor moves inside, and then contracting when it's out >>> again? Meaning if would look like an empty line you wanted after you press >>> 'C-p', but not visible at all otherwise. >> >> Yes, this is possible: > > It almost works fine, but going from the second log entry to the first with > 'p' while at bol leads to the first (empty) line becoming visible. Asked about this in http://lists.gnu.org/archive/html/emacs-devel/2019-05/msg00827.html and the answer was to use reveal-mode. > BTW, if we implement this, here's something we could add as well: > > Instead of the empty line, how about it will contain some quick help string > for the 'd' command, so that the user is not too puzzled if they hit 'C-p' > by accident? Good idea, added too: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=vc-git-print-log-reveal-mode.patch diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index b6feb3b8d1..1637f1106f 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1018,7 +1018,10 @@ vc-git-print-log ;; read-only. (let ((inhibit-read-only t)) (with-current-buffer buffer - (insert "\n") + (overlay-put (make-overlay (point) (progn (insert (propertize "\n" 'help-echo + "You can use `d' on the top empty line to compare with the current working revision")) + (point))) + 'invisible t) (apply 'vc-git-command buffer 'async files (append @@ -1122,7 +1125,8 @@ vc-git-log-view-mode (1 'change-log-acknowledgment) (2 'change-log-acknowledgment)) ("^Date: \\(.+\\)" (1 'change-log-date)) - ("^summary:[ \t]+\\(.+\\)" (1 'log-view-message))))))) + ("^summary:[ \t]+\\(.+\\)" (1 'log-view-message)))))) + (reveal-mode 1)) (defun vc-git-show-log-entry (revision) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 23 21:29:16 2019 Received: (at 35624) by debbugs.gnu.org; 24 May 2019 01:29:16 +0000 Received: from localhost ([127.0.0.1]:45717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTz1I-0004UF-0E for submit@debbugs.gnu.org; Thu, 23 May 2019 21:29:16 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:53234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTz1G-0004Tx-20 for 35624@debbugs.gnu.org; Thu, 23 May 2019 21:29:14 -0400 Received: by mail-wm1-f46.google.com with SMTP id y3so7646519wmm.2 for <35624@debbugs.gnu.org>; Thu, 23 May 2019 18:29:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=rCPqmVIOhua10TkJvDFva4fCjzxnRGSuIuwl6fZv0iU=; b=vM2hV72q1ypfYU/SOac87EokACIBFiCRuBygStlK590qh/y1SFoc395j1vk1i4O8gQ 5ZFKhWb8D+8AWE5GN8jEBEgPknt6u5FTBpB3Ayxw6iRvLoQ4kr855xuhGDQ7yszYhpxA IowfaTiom+enEc11BlRSa+4lZY1vTAjSRw259MxE8ekqjc581Utw111thEW3j80rPA2F E1etGl2qE+s8ZcOrEN5I9y9oyqkHKeUFMCX9uhy5zEnklvJnTK59WaP31/jTDvcB3fch ntwRT+m6c+pnNAT6jua9ut6PUIYujoTSuNND25w+82vMM1ETFjIyz+Nz9bAXkcLxQEPN jitA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rCPqmVIOhua10TkJvDFva4fCjzxnRGSuIuwl6fZv0iU=; b=IMMbM9yP0ME1XxJKjAUXzxq9Sxxgs5UfyLLXhJegZaQMtIbQYoH42jpumhmJBYaY3w Ip6j2p7ownjS7cZNLdvKMCzaa+CX6nJgwrvg931Bb5T75Gr27pX4WmwjH3MnxA2pXniH G1i2AfjbqNEWDgxdlo01+JZUmVAYxu89HHjI70XOLJJiqf3mBjLXYwAFxjTKx08QqVIm rymPwsic8cYhuTBx7BsQXRumr+6a+OdBEqOsJ28EVXmf/3b4WWI2ROnN4+tZzGiYVUz4 B+mm75UxmN90VuABLE3Go2CDxIv20ANmdCsy/g7rymZ4CkJsQLzPtb3GEwhhpA15IENt TZHQ== X-Gm-Message-State: APjAAAV5VH3k+j2Xnqzvvvt7XLQGx1AIVYxk9LQTKALXvbQCp0HEdyks agIlJV7pFSuy4YHh7ewB0/a/fyXe X-Google-Smtp-Source: APXvYqwU5dMqT3x6bis56H4+PUBj+H1DYR5yrAJtBfHcumkp9/JtFPqtn0/8PZTh5eKYjLjK6RjlNQ== X-Received: by 2002:a1c:f102:: with SMTP id p2mr13200583wmh.126.1558661347673; Thu, 23 May 2019 18:29:07 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id r4sm730427wrv.34.2019.05.23.18.29.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 May 2019 18:29:06 -0700 (PDT) Subject: Re: bug#35624: log-view-diff regression To: Juri Linkov References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> <8736laqk5e.fsf@mail.linkov.net> <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> <87lfyzy3c1.fsf@mail.linkov.net> <87y32zv6i6.fsf@mail.linkov.net> <87r28o3mnm.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <6b924be6-770e-a011-79c7-8278ff76005a@yandex.ru> Date: Fri, 24 May 2019 04:29:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <87r28o3mnm.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 24.05.2019 0:07, Juri Linkov wrote: > - (insert "\n") > + (overlay-put (make-overlay (point) (progn (insert (propertize "\n" 'help-echo > + "You can use `d' on the top empty line to compare with the current working revision")) > + (point))) > + 'invisible t) Is this a tested patch? It doesn't seem to work over here. 'C-p' does nothing. BTW, why help-echo? We have an otherwise unoccupied line, might as well show the text there directly. What do you think about this version, though: (Press 'd' here to see the diff against the current working revision) ? I don't mind the words "compare with", but they seem to elicit the question, "compare what?" The empty line? From debbugs-submit-bounces@debbugs.gnu.org Fri May 24 14:43:45 2019 Received: (at 35624) by debbugs.gnu.org; 24 May 2019 18:43:45 +0000 Received: from localhost ([127.0.0.1]:47334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUFAO-0000iy-Q9 for submit@debbugs.gnu.org; Fri, 24 May 2019 14:43:44 -0400 Received: from purple.birch.relay.mailchannels.net ([23.83.209.150]:65515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUFAM-0000iq-R7 for 35624@debbugs.gnu.org; Fri, 24 May 2019 14:43:43 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id D98905019C1; Fri, 24 May 2019 18:43:41 +0000 (UTC) Received: from pdx1-sub0-mail-a67.g.dreamhost.com (100-96-14-97.trex.outbound.svc.cluster.local [100.96.14.97]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 942CB5019AD; Fri, 24 May 2019 18:43:39 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a67.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Fri, 24 May 2019 18:43:41 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Stupid-Occur: 38b3d5d1183f24db_1558723421717_4187533140 X-MC-Loop-Signature: 1558723421717:2732086044 X-MC-Ingress-Time: 1558723421717 Received: from pdx1-sub0-mail-a67.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a67.g.dreamhost.com (Postfix) with ESMTP id 4BB4480695; Fri, 24 May 2019 11:43:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=Xm2QGgbFrrvvsHQ8zEEigj4EJDQ=; b= Dne6VVqwKYk70Of08tqbvqFdTFJUHFo/kKq2x+O1nMOOdTAceULYn3St84fbVBTr H9ZG1x7M+sn4XEeGYrmXU+vZaS7wlJ8yWfiuEIBf9DTZZPg0wE0L7NFm5jMy9OOQ YLDTFkRHlDn6mj/NNDrFHAb8XyND05gfBVRxF3Lx1ak= Received: from mail.jurta.org (m91-129-96-230.cust.tele2.ee [91.129.96.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a67.g.dreamhost.com (Postfix) with ESMTPSA id 1EF6980697; Fri, 24 May 2019 11:43:31 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a67 From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#35624: log-view-diff regression Organization: LINKOV.NET References: <87pnou2ak2.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> <8736laqk5e.fsf@mail.linkov.net> <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> <87lfyzy3c1.fsf@mail.linkov.net> <87y32zv6i6.fsf@mail.linkov.net> <87r28o3mnm.fsf@mail.linkov.net> <6b924be6-770e-a011-79c7-8278ff76005a@yandex.ru> Date: Fri, 24 May 2019 21:41:59 +0300 In-Reply-To: <6b924be6-770e-a011-79c7-8278ff76005a@yandex.ru> (Dmitry Gutov's message of "Fri, 24 May 2019 04:29:04 +0300") Message-ID: <87v9xzd948.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrudduiedgudefudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledrleeirddvfedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleeirddvfedtpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgepvd X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> - (insert "\n") >> + (overlay-put (make-overlay (point) (progn (insert (propertize "\n" 'help-echo >> + "You can use `d' on the top empty line to compare with the current working revision")) >> + (point))) >> + 'invisible t) > > Is this a tested patch? It doesn't seem to work over here. 'C-p' > does nothing. It's just a sketch, it doesn't work when trying. This shows that due to reveal-mode's glitches, this solution can't be used here. > BTW, why help-echo? We have an otherwise unoccupied line, might as well > show the text there directly. > > What do you think about this version, though: > > (Press 'd' here to see the diff against the current working revision) > > ? Ok, will show this text dimmed. From debbugs-submit-bounces@debbugs.gnu.org Mon May 27 11:27:02 2019 Received: (at 35624) by debbugs.gnu.org; 27 May 2019 15:27:03 +0000 Received: from localhost ([127.0.0.1]:53810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVHWg-0000mt-Ii for submit@debbugs.gnu.org; Mon, 27 May 2019 11:27:02 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:45282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVHWe-0000mP-Nt for 35624@debbugs.gnu.org; Mon, 27 May 2019 11:27:01 -0400 Received: by mail-wr1-f44.google.com with SMTP id b18so17224721wrq.12 for <35624@debbugs.gnu.org>; Mon, 27 May 2019 08:27:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=W7FOF4RGHSNU8aO6TMAnFEZYX1W21P9ULFfwpR/a0TE=; b=jRVWvkAMvwCe8Uio4H08aYWXZsNEEolp6DbYh2kyBntuRWiEBOVN00X7JPOIfk3jZb QimHr6xf+rEcwoQUpWaAaf8+UUismBqHDbSU2uGBhiAI3fhCsE0NCHWWAiL6nKXYyVHR MaRAryfPebPhjX2CusY2OtAOfxzg92U1oN9kRDnBlH7FUi3GQiy2FLyq81z6bUAAVKr0 M/r1Kg1ryrR1H3NNqxTu5NHJ17HQp1h2b5AjIad8OjSIJkN5ddcBM3k42lYSZDQCMd96 iqCJUxBn20ySy7eDXXiNWJk5WozHdARev6D0CkIQg+epVl8RBJ5KOZdbaO/IzXaHmqPW +hOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=W7FOF4RGHSNU8aO6TMAnFEZYX1W21P9ULFfwpR/a0TE=; b=WWKO+NtqIOA2z1bQNaL1zay/8nb9vDMkQ1TYCRxO3s0KINdKbbCUe1y4s2Q9GRYnQV lR/oNbwbdjl4HX/MoGNmto7an6OL5hS/uGXzVsm6G22zaLHFmsAdu5E/kFX3ysi3H6Hf PgP2nQM429OY1f5sEwBrqxKmWt6NcwCA7+Tui4IDZVZYEoxgpDsugmSg2Vnogm/Y5Jzi Xxs+pODl2uvEjGGGC0d61k3q9PUd1NGvwpSK3N+tLsYdfzmoD0Ms9Q5yUXgmoGMXNFjS 2sfKk+XuJZciAQLkShnt0QYxdky6D72v4XeSHeBn6nqLsqThHdFrVf/vKOENRBvFHZ/w 5Oqg== X-Gm-Message-State: APjAAAVIHbCygxwof9AaM7tEGpgKojdnic4AQT6XVy+LH8CAuh4jcGbx 4r6MF6pMSkjh/R/VJT9I6WYSEeX4 X-Google-Smtp-Source: APXvYqx6DMY6A5idG2PPRM2vRWQAXRIFdn0vPI1LXzWOIGgvZ1IAMYiujKY4HTV0t+UcWlSSrXiWvA== X-Received: by 2002:adf:e550:: with SMTP id z16mr1699784wrm.146.1558970814395; Mon, 27 May 2019 08:26:54 -0700 (PDT) Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id n10sm5840524wrr.11.2019.05.27.08.26.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 May 2019 08:26:52 -0700 (PDT) Subject: Re: bug#35624: log-view-diff regression To: Juri Linkov References: <87pnou2ak2.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> <8736laqk5e.fsf@mail.linkov.net> <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> <87lfyzy3c1.fsf@mail.linkov.net> <87y32zv6i6.fsf@mail.linkov.net> <87r28o3mnm.fsf@mail.linkov.net> <6b924be6-770e-a011-79c7-8278ff76005a@yandex.ru> <87v9xzd948.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <3b1817fd-6b81-2673-921f-b1e7c411203e@yandex.ru> Date: Mon, 27 May 2019 18:26:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <87v9xzd948.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.1 (-) On 24.05.2019 21:41, Juri Linkov wrote: >> Is this a tested patch? It doesn't seem to work over here. 'C-p' >> does nothing. > > It's just a sketch, it doesn't work when trying. This shows that > due to reveal-mode's glitches, this solution can't be used here. Apparently it only works with invisibilities that leave an ellipsis. What's our next step, then? >> What do you think about this version, though: >> >> (Press 'd' here to see the diff against the current working revision) >> >> ? > > Ok, will show this text dimmed. Sounds good. From debbugs-submit-bounces@debbugs.gnu.org Mon May 27 16:09:44 2019 Received: (at 35624) by debbugs.gnu.org; 27 May 2019 20:09:44 +0000 Received: from localhost ([127.0.0.1]:54224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVLwG-00008H-93 for submit@debbugs.gnu.org; Mon, 27 May 2019 16:09:44 -0400 Received: from common.maple.relay.mailchannels.net ([23.83.214.38]:9852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVLwD-000086-Cu for 35624@debbugs.gnu.org; Mon, 27 May 2019 16:09:42 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 455F1141B18; Mon, 27 May 2019 20:09:40 +0000 (UTC) Received: from pdx1-sub0-mail-a50.g.dreamhost.com (100-96-91-66.trex.outbound.svc.cluster.local [100.96.91.66]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 50D0214186D; Mon, 27 May 2019 20:09:39 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a50.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Mon, 27 May 2019 20:09:40 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Absorbed-Harmony: 0c13fea94a96f622_1558987779976_3652295376 X-MC-Loop-Signature: 1558987779975:3563113707 X-MC-Ingress-Time: 1558987779947 Received: from pdx1-sub0-mail-a50.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a50.g.dreamhost.com (Postfix) with ESMTP id 08988832A8; Mon, 27 May 2019 13:09:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=0hn23UxK8wtxA1XWKVbuLuh6z1s=; b= gVWCiL1fvQCoybZJjwfUWr9LQgRyQGPd1VkLh4kPz4mXZoxfmdAWnlt39eNuz+Y1 XQDm43SS4ZHMtMS3cfgcbq+5OQny/d3oDsv0N0zGp1LWW08oNUm5l0eS3s1V5DNq BjSdfsPQytelSJCR+48R659Es8RDEbbOu7A6X8UoEu0= Received: from mail.jurta.org (m91-129-96-73.cust.tele2.ee [91.129.96.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a50.g.dreamhost.com (Postfix) with ESMTPSA id 6C615832A5; Mon, 27 May 2019 13:09:35 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a50 From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#35624: log-view-diff regression Organization: LINKOV.NET References: <87pnou2ak2.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> <8736laqk5e.fsf@mail.linkov.net> <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> <87lfyzy3c1.fsf@mail.linkov.net> <87y32zv6i6.fsf@mail.linkov.net> <87r28o3mnm.fsf@mail.linkov.net> <6b924be6-770e-a011-79c7-8278ff76005a@yandex.ru> <87v9xzd948.fsf@mail.linkov.net> <3b1817fd-6b81-2673-921f-b1e7c411203e@yandex.ru> Date: Mon, 27 May 2019 22:47:25 +0300 In-Reply-To: <3b1817fd-6b81-2673-921f-b1e7c411203e@yandex.ru> (Dmitry Gutov's message of "Mon, 27 May 2019 18:26:48 +0300") Message-ID: <87tvdfem02.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddruddvfedguddvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdeliedrjeefnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleeirdejfedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegughhuthhovheshigrnhguvgigrdhruhenucevlhhushhtvghrufhiiigvpedt X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>> Is this a tested patch? It doesn't seem to work over here. 'C-p' >>> does nothing. >> >> It's just a sketch, it doesn't work when trying. This shows that >> due to reveal-mode's glitches, this solution can't be used here. > > Apparently it only works with invisibilities that leave an ellipsis. > > What's our next step, then? The next step is to implement 'window-start-marker' in bug#35860, and set it to the second line, so after displaying the log buffer the first line will be off-screen. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 09 20:57:10 2019 Received: (at 35624) by debbugs.gnu.org; 10 Jun 2019 00:57:10 +0000 Received: from localhost ([127.0.0.1]:55666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ha8cY-0000gt-EX for submit@debbugs.gnu.org; Sun, 09 Jun 2019 20:57:10 -0400 Received: from mail-wm1-f48.google.com ([209.85.128.48]:40310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ha8cW-0000gf-EK for 35624@debbugs.gnu.org; Sun, 09 Jun 2019 20:57:09 -0400 Received: by mail-wm1-f48.google.com with SMTP id v19so6517873wmj.5 for <35624@debbugs.gnu.org>; Sun, 09 Jun 2019 17:57:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MGe2Wi33oDMHwviWbiUtCQ28lrMd44s8vFvTGVwJuuc=; b=UXZJxXZsMzWD3n4LW4GHxTYrcuXy44wSgl/+lRnmDHXyTsYoOSzOeeCccBr8vZAhkf owZHo+HrtpeVKN8byhH+OqqLaNfs7uuYadHJem1k9wpLqFdULlhUtrZWnlaSnkbndL4X 2SXqMyOgDgExs4gboVYvH6+73/OESf9j73tp/WD3h4UlF7wQB4CGAUGK36cnuE9j9UfH Z4VZlK8aW7EDhelMaPE3lGVaXw9IuSPYQTgUs3FJTS0eNme4dW/08GvWf976KKu6b4c0 KxQQdkaJkA874WTsXx+eyvxDMq1jxQKADlMfHw6/5ubxT0+KRZrX5DNXndgLcDvuGvOn hzRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MGe2Wi33oDMHwviWbiUtCQ28lrMd44s8vFvTGVwJuuc=; b=VGFKwYZF2RBXHVEOLD6uzEhZZlQXviI90EGmtGWqNsRtvt4Bx98WmIadc/7jb/VJ4u 8cLieZwfpMX63q4b3uIUYMTxygIRafRYwZqt+BvNsoyv9UuYCPyPUHM3JNLJZdNX1mNY 1TwRBqzHMK+zp/jCeZFuG3bYz/N0Eaam8kf8FUj/K39r7b5OMfPNB89qrntpS9NcJj0B LdwCgzn5z1g+EV4W2WgHHCo1Nn5gdL7xZY09w56XzmeGHMvdWXigIsT/FxmUyiq+kSi1 sNVCMA6mTfqs5R0hQ1Vvm0WhsvPvRqy+HQxnOFFAnj8RFuYi8jmCK5C6GGnwV8Tkshqy Au0A== X-Gm-Message-State: APjAAAVUMc7ju7ITJ/PdMa4vvwMVEoK/PnK4M2uLS+29BaSAu3FRe3EZ bGrqayblakw9Cy8ekyf1ft70dk4y5+k= X-Google-Smtp-Source: APXvYqytwDyo5Dux9/mkWLHthyzyYRzus0UNKLF/DJrWLWZYwXsyh//7zRSU8iHRJ0Ptl02MRt6meg== X-Received: by 2002:a1c:c545:: with SMTP id v66mr11867409wmf.51.1560128222215; Sun, 09 Jun 2019 17:57:02 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id w6sm12818326wro.71.2019.06.09.17.57.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 09 Jun 2019 17:57:01 -0700 (PDT) Subject: Re: bug#35624: log-view-diff regression To: Juri Linkov References: <87pnou2ak2.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> <8736laqk5e.fsf@mail.linkov.net> <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> <87lfyzy3c1.fsf@mail.linkov.net> <87y32zv6i6.fsf@mail.linkov.net> <87r28o3mnm.fsf@mail.linkov.net> <6b924be6-770e-a011-79c7-8278ff76005a@yandex.ru> <87v9xzd948.fsf@mail.linkov.net> <3b1817fd-6b81-2673-921f-b1e7c411203e@yandex.ru> <87tvdfem02.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <684c13e5-3eef-8e99-82f0-9997dc9608fd@yandex.ru> Date: Mon, 10 Jun 2019 03:57:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <87tvdfem02.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 27.05.2019 22:47, Juri Linkov wrote: > The next step is to implement 'window-start-marker' in bug#35860, > and set it to the second line, so after displaying the log buffer > the first line will be off-screen. OK. But since there has been no progress there in the meantime, I'm reverting your experiment now. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 18:08:56 2019 Received: (at 35624) by debbugs.gnu.org; 10 Jun 2019 22:08:56 +0000 Received: from localhost ([127.0.0.1]:57596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haSTF-0006vV-Lw for submit@debbugs.gnu.org; Mon, 10 Jun 2019 18:08:56 -0400 Received: from dragonfly.birch.relay.mailchannels.net ([23.83.209.51]:14347) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haSTD-0006vM-4N for 35624@debbugs.gnu.org; Mon, 10 Jun 2019 18:08:52 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id F4078502A4A; Mon, 10 Jun 2019 22:08:49 +0000 (UTC) Received: from pdx1-sub0-mail-a19.g.dreamhost.com (100-96-11-129.trex.outbound.svc.cluster.local [100.96.11.129]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 776BD502D61; Mon, 10 Jun 2019 22:08:49 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a19.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Mon, 10 Jun 2019 22:08:49 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Grain-White: 6669601549de7c32_1560204529822_2622913185 X-MC-Loop-Signature: 1560204529822:979971911 X-MC-Ingress-Time: 1560204529821 Received: from pdx1-sub0-mail-a19.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a19.g.dreamhost.com (Postfix) with ESMTP id C44C58045E; Mon, 10 Jun 2019 15:08:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=C4hKENPxsWKgl8FmHmd7zL/Jw/0=; b= BM0xDwq4leuEbVMzUkQkIQKtTk1heTVshebt3ZshI2chTpfbyHWao/usNEfQP/0U HKcPghqZe/7ryRGe5k3HDg/WeibXcAF913f0dYb9ZNPF29cMeCZEM/doM7Mm2X52 SSX6iGUn/qks7GVYLZ4026deNXMNV7O4aBtq/cBbvhU= Received: from mail.jurta.org (m91-129-109-209.cust.tele2.ee [91.129.109.209]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a19.g.dreamhost.com (Postfix) with ESMTPSA id AC9848044D; Mon, 10 Jun 2019 15:08:42 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a19 From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#35624: log-view-diff regression Organization: LINKOV.NET References: <87pnou2ak2.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> <8736laqk5e.fsf@mail.linkov.net> <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> <87lfyzy3c1.fsf@mail.linkov.net> <87y32zv6i6.fsf@mail.linkov.net> <87r28o3mnm.fsf@mail.linkov.net> <6b924be6-770e-a011-79c7-8278ff76005a@yandex.ru> <87v9xzd948.fsf@mail.linkov.net> <3b1817fd-6b81-2673-921f-b1e7c411203e@yandex.ru> <87tvdfem02.fsf@mail.linkov.net> <684c13e5-3eef-8e99-82f0-9997dc9608fd@yandex.ru> Date: Mon, 10 Jun 2019 23:50:10 +0300 In-Reply-To: <684c13e5-3eef-8e99-82f0-9997dc9608fd@yandex.ru> (Dmitry Gutov's message of "Mon, 10 Jun 2019 03:57:00 +0300") Message-ID: <87r2819n8t.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrudehfedgtdeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdelrddvtdelnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtledrvddtledprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegughhuthhovheshigrnhguvgigrdhruhenucevlhhushhtvghrufhiiigvpedt X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> The next step is to implement 'window-start-marker' in bug#35860, >> and set it to the second line, so after displaying the log buffer >> the first line will be off-screen. > > OK. But since there has been no progress there in the meantime, I'm > reverting your experiment now. This is not constructive. Why to remove useful feature instead of helping to improve it? While it's not yet perfect, no one was disturbed by it. What is worse, you also removed documentation updates that documented the feature that already existed for many years. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 18:20:11 2019 Received: (at 35624) by debbugs.gnu.org; 10 Jun 2019 22:20:11 +0000 Received: from localhost ([127.0.0.1]:57603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haSeA-0007Br-TE for submit@debbugs.gnu.org; Mon, 10 Jun 2019 18:20:11 -0400 Received: from mail-wm1-f47.google.com ([209.85.128.47]:37799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haSe9-0007Be-0Z for 35624@debbugs.gnu.org; Mon, 10 Jun 2019 18:20:09 -0400 Received: by mail-wm1-f47.google.com with SMTP id 22so824637wmg.2 for <35624@debbugs.gnu.org>; Mon, 10 Jun 2019 15:20:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nfLUzGUpKbDGcp9U/QHXepmGLPSRd8sFOmBGgttlj3U=; b=G2r4JjXN6NL6ROWF0ZD9xhg5y/b6StVrneG1VktBV76e321Bfmjdzoex8wZXyJV5cr 9dO4yVurleFt1sMMLu+fc/EiPz/SXWPP05MK144DKxE97XfLH5k8qkaNhgABRCFupfJ/ Ll9Y67aIg7BYmQ/wvENIcJmqlRBvxAiVnmw4Y04QwrAR/x72AdcF//UiUqG2VwmuOSFi Ok7ab7E9qwX5/rG88Li8lgMLLj7ew9SJIu1tp72Ap9EYGPgJgW2Uv0Km/lJjEWGQSN0a SWzBZPWywTxYHi0wnvvLlkIaZ0VfN+IQYnzjRx2K9UIKbhbC9b26YIXGlWxis2HjouJ/ gRdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nfLUzGUpKbDGcp9U/QHXepmGLPSRd8sFOmBGgttlj3U=; b=cVPXDqoH0q9biHWpnyGogohb5amXCVE7c6iAM0tsEPqBijUgInr9TpGpMGGVv4jCcA yl4fk+PzqrNKvHPYSKEPVecX8sF2lTsvu/lX4jIu5rRFUemzOYoKTjhkzw3FH10ECqlf NAhmG+6iSbmBiO3dy/vV/8o+gEVblns6rEShf7pqd0gtnfT+08AsJIqg8iO4MisXkuo+ juPDSZX+XawjmfJh00gwQ43hE0WaPCTj540kakEuARGb72qT0OSs3xrIlxzFP5hqNudT /GN805B/lHVo3HnpqUhCVdBye6EMKRf1mQa3UzNJdWpZf0ukGrfgg+MRjSh+Zw2PuWQe dY4Q== X-Gm-Message-State: APjAAAUQdVI5dZv0J6eJBMtRK5739dNwx+fruTWu33cJ6RL1aovPv4jr 2PIkJtG/KKZPlAt36+IopzJ9su6fIWU= X-Google-Smtp-Source: APXvYqz4mlHlLVe0J3zzYPqvnKOcj5o0erPZ0uId4C6WRqA4L/0NuO8iapScc88LigfLkodWStYUDA== X-Received: by 2002:a1c:544d:: with SMTP id p13mr15974188wmi.78.1560205202635; Mon, 10 Jun 2019 15:20:02 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id t15sm3913198wrx.84.2019.06.10.15.20.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Jun 2019 15:20:01 -0700 (PDT) Subject: Re: bug#35624: log-view-diff regression To: Juri Linkov References: <87pnou2ak2.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> <8736laqk5e.fsf@mail.linkov.net> <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> <87lfyzy3c1.fsf@mail.linkov.net> <87y32zv6i6.fsf@mail.linkov.net> <87r28o3mnm.fsf@mail.linkov.net> <6b924be6-770e-a011-79c7-8278ff76005a@yandex.ru> <87v9xzd948.fsf@mail.linkov.net> <3b1817fd-6b81-2673-921f-b1e7c411203e@yandex.ru> <87tvdfem02.fsf@mail.linkov.net> <684c13e5-3eef-8e99-82f0-9997dc9608fd@yandex.ru> <87r2819n8t.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Tue, 11 Jun 2019 01:19:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <87r2819n8t.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 10.06.2019 23:50, Juri Linkov wrote: > This is not constructive. Why to remove useful feature instead of helping > to improve it? The new behavior was annoying, and there was no consensus on it. Please don't write "let's try and see" and then act hurt then the feedback is negative. I never approved your patch in the first place. > While it's not yet perfect, no one was disturbed by it. Obviously, I was. It felt like a sore thumb every time I called vc-print-log. > What is worse, you also removed documentation updates that documented > the feature that already existed for many years. The documentation updates heavily relied on the new log-view behavior, I think. But please feel free to re-add them in any shape or form without the change in behavior, if you feel they are still valuable. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 15 20:55:54 2019 Received: (at 35624) by debbugs.gnu.org; 16 Jun 2019 00:55:54 +0000 Received: from localhost ([127.0.0.1]:39459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcJSb-0003Pi-N0 for submit@debbugs.gnu.org; Sat, 15 Jun 2019 20:55:53 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:34908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcJSZ-0003PS-Rt for 35624@debbugs.gnu.org; Sat, 15 Jun 2019 20:55:52 -0400 Received: by mail-wm1-f42.google.com with SMTP id c6so5643797wml.0 for <35624@debbugs.gnu.org>; Sat, 15 Jun 2019 17:55:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aQNwsLVdw1xMnukdXnlOii/bq8b/uNvd0XsKhyFh35A=; b=NtLu4qPrfzRl8Ia4KHDKeTTVGxBnURGBB1K3F4wk9Fo+kNB5W4JSNgjCPqOFbHM5Hx QFXlHJUXoa3Yxx33vvxSq9mFj6pIAUlDhKTn9RWlhTzOncuUfTEWm5WGtiu2zxyXGmSL v9nmc618iUTgkljjMl1jzh039RagvH/Owrg7qz8f+KRRDu+aoP9744TMTon1U3Ez1sO2 NJ6vZE6FlySyT21SGnKSroCP2qVesgtCYIRYooiQlEffpTETULyo/N5Xy4Fswl1l1diN f5RE3ClfWWY4/aMUjOYK2fxHm2qe0wheolK1DJ02tcrIqURDgcGPGMLoyZD+QtL8B1Id pSkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aQNwsLVdw1xMnukdXnlOii/bq8b/uNvd0XsKhyFh35A=; b=YW7/O6UMfCxS1AX3YFVuduey2akpiEHEnP9an0v1E+g9LfXy7JBgT2u+4A5dk5TrtU QBXpK/sCYMt4kmKGdHCfmQtVuNagurWibMel44q1f7VcDKRDv20/vMk7xbzs75T6aM1r 7NL1qn0kqZaK26PyL3YxDlRbFt2B89jsnP2fwXVW06uvXJimgkVOgzK+yj5DzlD2TLiA ghlvP918U8AQp6Ra7uTGaFWDerSwo6TtaMO9JxrfP1wESEx0+eK6Oe4Iv+Gb2gZBqUvF 1n5V0JfRISHPB3SfS2zpWaeKaFCqwV3ufuv2HbUBnHeMLOFV7w2ELdlynvnMFd2Hp7QJ NP7w== X-Gm-Message-State: APjAAAXfNzPx17idOE+TJaJIQ70WBmhZmV9c6Max+o7oki6dBzWbLqW7 Pmid7rDOOKncz22TV2zu8cPa2G24crU= X-Google-Smtp-Source: APXvYqxmYIfdQu5k3Vzyn4pvZKUnpgw6KVAxqg2S5EfWd7YTi9qE0bBwM1f6Cey5J+A0dc7gf043xw== X-Received: by 2002:a1c:7008:: with SMTP id l8mr12276384wmc.64.1560646546040; Sat, 15 Jun 2019 17:55:46 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id o11sm6537039wmh.37.2019.06.15.17.55.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Jun 2019 17:55:45 -0700 (PDT) Subject: Re: bug#35624: log-view-diff regression To: Juri Linkov References: <87pnou2ak2.fsf@mail.linkov.net> <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> <875zqgaekq.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> <8736laqk5e.fsf@mail.linkov.net> <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> <87lfyzy3c1.fsf@mail.linkov.net> <87y32zv6i6.fsf@mail.linkov.net> <87r28o3mnm.fsf@mail.linkov.net> <6b924be6-770e-a011-79c7-8278ff76005a@yandex.ru> <87v9xzd948.fsf@mail.linkov.net> <3b1817fd-6b81-2673-921f-b1e7c411203e@yandex.ru> <87tvdfem02.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <2f46c05d-a656-b791-dcec-cb705f6bf955@yandex.ru> Date: Sun, 16 Jun 2019 03:55:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <87tvdfem02.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 27.05.2019 22:47, Juri Linkov wrote: > The next step is to implement 'window-start-marker' in bug#35860, > and set it to the second line, so after displaying the log buffer > the first line will be off-screen. Speaking about this approach... What happens when the whole log buffer is shorter than the window it's displayed in? It's not a frequent occurrence is our usual work, but when someone is starting a small side-project, the UI should still work, and it would be jarring if it was suddenly different from the usual. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 16 16:37:11 2019 Received: (at 35624) by debbugs.gnu.org; 16 Jun 2019 20:37:11 +0000 Received: from localhost ([127.0.0.1]:41554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcbtn-0004Oq-1o for submit@debbugs.gnu.org; Sun, 16 Jun 2019 16:37:11 -0400 Received: from egyptian.birch.relay.mailchannels.net ([23.83.209.56]:1038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcbtl-0004Oh-6W for 35624@debbugs.gnu.org; Sun, 16 Jun 2019 16:37:09 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 30702501AD9; Sun, 16 Jun 2019 20:37:08 +0000 (UTC) Received: from pdx1-sub0-mail-a70.g.dreamhost.com (100-96-14-97.trex.outbound.svc.cluster.local [100.96.14.97]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 7FB10501A1F; Sun, 16 Jun 2019 20:37:07 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a70.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Sun, 16 Jun 2019 20:37:08 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Glossy-Shelf: 2461021c3c7c3605_1560717428025_3137893612 X-MC-Loop-Signature: 1560717428025:3406924462 X-MC-Ingress-Time: 1560717428024 Received: from pdx1-sub0-mail-a70.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a70.g.dreamhost.com (Postfix) with ESMTP id 62D5681061; Sun, 16 Jun 2019 13:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=dQaS6duDmmHN3s40yyoBE94jPhg=; b= 0h800RWE+G0RexMdpldQHnl344zovuF1OOO/km1dj8E4+7PoROuZJsVmnLE6aLnC afvYgebG5aXatQyhIitawMgBlHDY2YCfhSngclIV56euq25o9lvHazM8FMuCBttX 9pso2sBq/d9TDFZMkfyLdM8a5bTW1jjLB5ay2NzZDdk= Received: from mail.jurta.org (m91-129-109-209.cust.tele2.ee [91.129.109.209]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a70.g.dreamhost.com (Postfix) with ESMTPSA id 5C08481066; Sun, 16 Jun 2019 13:37:03 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a70 From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#35624: log-view-diff regression Organization: LINKOV.NET References: <87pnou2ak2.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> <8736laqk5e.fsf@mail.linkov.net> <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> <87lfyzy3c1.fsf@mail.linkov.net> <87y32zv6i6.fsf@mail.linkov.net> <87r28o3mnm.fsf@mail.linkov.net> <6b924be6-770e-a011-79c7-8278ff76005a@yandex.ru> <87v9xzd948.fsf@mail.linkov.net> <3b1817fd-6b81-2673-921f-b1e7c411203e@yandex.ru> <87tvdfem02.fsf@mail.linkov.net> <2f46c05d-a656-b791-dcec-cb705f6bf955@yandex.ru> Date: Sun, 16 Jun 2019 23:13:17 +0300 In-Reply-To: <2f46c05d-a656-b791-dcec-cb705f6bf955@yandex.ru> (Dmitry Gutov's message of "Sun, 16 Jun 2019 03:55:43 +0300") Message-ID: <87fto98e5q.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrudeihedgudehhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtledrvddtleenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdelrddvtdelpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgepfe X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> The next step is to implement 'window-start-marker' in bug#35860, >> and set it to the second line, so after displaying the log buffer >> the first line will be off-screen. > > Speaking about this approach... What happens when the whole log buffer is > shorter than the window it's displayed in? It was difficult for me to test this case because I rely heavily on ediff for development, but ediff has been broken for a week in master. It makes sense to revert changes that break some function completely because currently ediff is unusable giving this error: Debugger entered--Lisp error: (void-function nil) nil(#("..." 39 51 (face (diff-file-header diff-header) fontified t)) (list (lambda nil (add-hook 'ediff-after-quit-hook-internal (lambda nil (if (ediff-buffer-live-p #) (ediff-show-meta-buffer # 1))) nil 'local) (setq ediff-meta-buffer # ediff-meta-session-number 1) (setq ediff-merge-store-file nil) (setcar '(nil nil (#("..." 39 51 ...) nil) (# nil) (# nil)) ediff-control-buffer)))) ediff-filegroup-action() funcall-interactively(ediff-filegroup-action) call-interactively(ediff-filegroup-action nil nil) command-execute(ediff-filegroup-action) But I tried to do ediff's work manually, and can confirm now that when the whole log buffer is shorter than the window then the patch from bug#35860 still works correctly hiding the first line initially. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 17 09:49:06 2019 Received: (at 35624) by debbugs.gnu.org; 17 Jun 2019 13:49:06 +0000 Received: from localhost ([127.0.0.1]:42177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcs0Q-000622-Ee for submit@debbugs.gnu.org; Mon, 17 Jun 2019 09:49:06 -0400 Received: from mail-wm1-f48.google.com ([209.85.128.48]:51790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcs0P-00061Y-43 for 35624@debbugs.gnu.org; Mon, 17 Jun 2019 09:49:05 -0400 Received: by mail-wm1-f48.google.com with SMTP id 207so9370168wma.1 for <35624@debbugs.gnu.org>; Mon, 17 Jun 2019 06:49:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Sm3DwBXfzlG1Rs8/yraXgpclQ2LfhCq04EMTv8d3j8k=; b=vM+rIFKfkqgaeCImmOahpMQWmPTXjSiAZLCN/TWJ6xUfYRL9z27mbjj9AMZE8UiDNC UVf3FJJfl3xXUbnDxTnl4n0k1ITiVNO8hu505HFb2bOY1WKsUurOkR9SXjxxsI9U0Bo1 tQIo8eHdxQpCFpZTYCiyDqbVpO3OdYO9vldZE+024P1TMuQPXo/MGee9DPVmItUlfFvA 4UHVFxFHBEhyVwanb5PHjeHcQimHffmOAMeOlkbAzrGDd8y/CEf5a375+lb+2JfOJgAn tGHNZOMHvAv/HgyLPpRtGelAMSg4+rlWRuWObUVnVu5ILpQFrKFjtEAFZpa3k4HSp08e r89g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Sm3DwBXfzlG1Rs8/yraXgpclQ2LfhCq04EMTv8d3j8k=; b=DcP46kpyl2lnBzyZigrxl10oTqT5j3jsIKqHDCBqxxuvXnRQB2SO90e/fYT58JG26y 8yID7N3TPgLKr/ESYIL+vxnXbZEiUIvNVAFsQXqeoiDsYaTJJ5WSC7fFVSVNP2bVsly6 QD8lqcpdw18Er/kar6l44jw0Zcb630QIQR2SrvxDJ3JPfpZP+rWzf36ALDMvlxlPGXwU wZe4iDgWUqLx0lsm/DkBYr5TJMaAkthL05B0VOy5Bdourg20WjfpKhOvXX7OTpKtyMqR YtNNrKVpabP1TdRaOz2y9FRgQbJ5ZR7uIQGrPQpirZAlFhrnIi4YMj842MCsJXAn65gd nV/Q== X-Gm-Message-State: APjAAAULltLjetjLRo4LznEq2JRaog7frYnBG2PW26JdPx+Nkio9CYBU lc4OwLtwhqnkz/M/bJKvHjgie4Z6Iuk= X-Google-Smtp-Source: APXvYqzcuRuESKg9OHe+6OPtI8kP182Ir3pF6pkLgY+7E7aYAhwNJl9OPwcfb7f+/KTU+S66osXRlA== X-Received: by 2002:a1c:b1d5:: with SMTP id a204mr10986997wmf.101.1560779338572; Mon, 17 Jun 2019 06:48:58 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id n3sm7595443wro.59.2019.06.17.06.48.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2019 06:48:57 -0700 (PDT) Subject: Re: bug#35624: log-view-diff regression To: Juri Linkov References: <87pnou2ak2.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> <8736laqk5e.fsf@mail.linkov.net> <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> <87lfyzy3c1.fsf@mail.linkov.net> <87y32zv6i6.fsf@mail.linkov.net> <87r28o3mnm.fsf@mail.linkov.net> <6b924be6-770e-a011-79c7-8278ff76005a@yandex.ru> <87v9xzd948.fsf@mail.linkov.net> <3b1817fd-6b81-2673-921f-b1e7c411203e@yandex.ru> <87tvdfem02.fsf@mail.linkov.net> <2f46c05d-a656-b791-dcec-cb705f6bf955@yandex.ru> <87fto98e5q.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <8fb39318-1416-582b-7fb6-6d5b20c9ec0a@yandex.ru> Date: Mon, 17 Jun 2019 16:48:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <87fto98e5q.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 16.06.2019 23:13, Juri Linkov wrote: >> Speaking about this approach... What happens when the whole log buffer is >> shorter than the window it's displayed in? > > It was difficult for me to test this case because I rely heavily on ediff > for development, but ediff has been broken for a week in master. > It makes sense to revert changes that break some function completely > because currently ediff is unusable giving this error: That's unfortunate, but I never use it. Maybe file a bug? > But I tried to do ediff's work manually, and can confirm now that > when the whole log buffer is shorter than the window then the patch > from bug#35860 still works correctly hiding the first line initially. Great news. I wonder if it would still trip up people who use C-v/M-v sometimes. But a defcustom would solve that, anyway. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 17 18:13:14 2019 Received: (at 35624) by debbugs.gnu.org; 17 Jun 2019 22:13:14 +0000 Received: from localhost ([127.0.0.1]:43415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hczsI-0006qx-7R for submit@debbugs.gnu.org; Mon, 17 Jun 2019 18:13:14 -0400 Received: from beetle.elm.relay.mailchannels.net ([23.83.212.15]:22182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hczsG-0006qQ-CO for 35624@debbugs.gnu.org; Mon, 17 Jun 2019 18:13:12 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id D95771403FF; Mon, 17 Jun 2019 22:13:05 +0000 (UTC) Received: from pdx1-sub0-mail-a9.g.dreamhost.com (100-96-91-148.trex.outbound.svc.cluster.local [100.96.91.148]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id AF2181421D9; Mon, 17 Jun 2019 22:12:57 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a9.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Mon, 17 Jun 2019 22:13:05 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Shoe-Shrill: 13bfb2277dce38b4_1560809585457_1943389598 X-MC-Loop-Signature: 1560809585457:653219488 X-MC-Ingress-Time: 1560809585457 Received: from pdx1-sub0-mail-a9.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTP id DF5C583C8A; Mon, 17 Jun 2019 15:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=eqGyxK12123OQQH+fUU8j67xWeQ=; b= r0SWzLtY/2O6KlxY5MkqKSywtybajRhkZ6DuFtmwM2ntGKsMyHziyNS+DQUAR1ab lBoU+nJ/pFdX3v0Inw0nmY4IFm73QUolYZsFsfHgxZtRHoXAJKFXTFg3Un8hrjO5 u8yZTJkXaV1E1LQkBTqjhrwfa3sNv5wRJNo0vqBR5sw= Received: from mail.jurta.org (m91-129-109-209.cust.tele2.ee [91.129.109.209]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTPSA id E3D0783C9A; Mon, 17 Jun 2019 15:12:50 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a9 From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#35624: log-view-diff regression Organization: LINKOV.NET References: <87pnou2ak2.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> <8736laqk5e.fsf@mail.linkov.net> <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> <87lfyzy3c1.fsf@mail.linkov.net> <87y32zv6i6.fsf@mail.linkov.net> <87r28o3mnm.fsf@mail.linkov.net> <6b924be6-770e-a011-79c7-8278ff76005a@yandex.ru> <87v9xzd948.fsf@mail.linkov.net> <3b1817fd-6b81-2673-921f-b1e7c411203e@yandex.ru> <87tvdfem02.fsf@mail.linkov.net> <2f46c05d-a656-b791-dcec-cb705f6bf955@yandex.ru> <87fto98e5q.fsf@mail.linkov.net> <8fb39318-1416-582b-7fb6-6d5b20c9ec0a@yandex.ru> Date: Mon, 17 Jun 2019 23:42:57 +0300 In-Reply-To: <8fb39318-1416-582b-7fb6-6d5b20c9ec0a@yandex.ru> (Dmitry Gutov's message of "Mon, 17 Jun 2019 16:48:55 +0300") Message-ID: <87sgs8dju6.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrudeikedgtdehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucffohhmrghinheprghnhiifrgihrdgtqdhvnecukfhppeeluddruddvledruddtledrvddtleenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdelrddvtdelpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgeptd X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>> Speaking about this approach... What happens when the whole log buffer is >>> shorter than the window it's displayed in? >> >> It was difficult for me to test this case because I rely heavily on ediff >> for development, but ediff has been broken for a week in master. >> It makes sense to revert changes that break some function completely >> because currently ediff is unusable giving this error: > > That's unfortunate, but I never use it. Maybe file a bug? There is some slow-moving discussion in bug#36157. >> But I tried to do ediff's work manually, and can confirm now that >> when the whole log buffer is shorter than the window then the patch >> from bug#35860 still works correctly hiding the first line initially. > > Great news. > > I wonder if it would still trip up people who use C-v/M-v sometimes. But > a defcustom would solve that, anyway. C-v/M-v will help them to discover this useful feature. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 17 18:23:20 2019 Received: (at 35624) by debbugs.gnu.org; 17 Jun 2019 22:23:20 +0000 Received: from localhost ([127.0.0.1]:43424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hd024-00077r-Gd for submit@debbugs.gnu.org; Mon, 17 Jun 2019 18:23:20 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:39593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hd022-00077f-Iq for 35624@debbugs.gnu.org; Mon, 17 Jun 2019 18:23:19 -0400 Received: by mail-wr1-f44.google.com with SMTP id x4so11715876wrt.6 for <35624@debbugs.gnu.org>; Mon, 17 Jun 2019 15:23:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ih99KqM+jzJND3+dY26KQ6fQ8+yH1Y54n8DU1EUhpp8=; b=GT1very7KY5NJirYhJOprMU9QSsqq4JTBRSUkjEnxnwQpH1KvgmpWFnyCyRMwN0Ypu PCTZilxjGjpWkBGLD1QqAs/ouy4uamlXoVbLGFxX5NVlvGJ3leUzv9Zvr0s58jiUmlZV GyQkbFr5paGIzyqB/K709gNYajxPTkUIY6aqDxBhPoO/LI52hmVZQmrMGGCpbEUkUfTE +MhieSTV/1t/bDFJ3tVQXwqxDjM2xoInvn09D1vlJDsN2/l7Mh0VPofbfcPizqaLRhH+ SyxSqzPwrIYnNhfMAskup0TqcHsooYoNxhu+HzpnXJx0fh2Ha1ucRV3ExIJ3yqG/tPYD e+Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ih99KqM+jzJND3+dY26KQ6fQ8+yH1Y54n8DU1EUhpp8=; b=jaz9aqtBqtkgrevunVraZHV5o6MBJdUdG3u9dabOyOVIova5XyVBVY6WSQ2GdtbRTe 3GjIOa6No3vo4AMzTkPTmVgBUcPBdmiAgTval1L7jL4jDlOkephEDMjlGCtWcK0FT0j5 DmdqPUc8C8zLBkt5abhBwKGWl0OBcHgD9COl7rPL7w8zedLhoaHpWiRfGHVG77qxyVSH d7bTj4wePRkkyvUewicfjpqgGYBY/hHILwqKp89wqwHsf3nkoqyLIotcr5Gmy2bjL2j0 ObUhdbiyYKJas7L6lWsKUQkR1++EZeS/gxX5mGncx1b1ZJGLaqs7lqXObovkWlReSYxX yQ6g== X-Gm-Message-State: APjAAAVH8WOK0tbiqrAOjFwArfhfrmWnt4lE3poVawv1G3Ay8xb9cq1k bUwS8d79ldu95Z5I8OLYLti2AqHQbgs= X-Google-Smtp-Source: APXvYqwh4NOqMbqlk/ZHfRy68sLMPAuqV6E1yay1iR01xRA2rYe4XmbKKaho27soEuOmTphP68EyBw== X-Received: by 2002:adf:e84a:: with SMTP id d10mr699565wrn.316.1560810192350; Mon, 17 Jun 2019 15:23:12 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id d18sm16720586wrb.90.2019.06.17.15.23.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2019 15:23:11 -0700 (PDT) Subject: Re: bug#35624: log-view-diff regression To: Juri Linkov References: <87pnou2ak2.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> <8736laqk5e.fsf@mail.linkov.net> <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> <87lfyzy3c1.fsf@mail.linkov.net> <87y32zv6i6.fsf@mail.linkov.net> <87r28o3mnm.fsf@mail.linkov.net> <6b924be6-770e-a011-79c7-8278ff76005a@yandex.ru> <87v9xzd948.fsf@mail.linkov.net> <3b1817fd-6b81-2673-921f-b1e7c411203e@yandex.ru> <87tvdfem02.fsf@mail.linkov.net> <2f46c05d-a656-b791-dcec-cb705f6bf955@yandex.ru> <87fto98e5q.fsf@mail.linkov.net> <8fb39318-1416-582b-7fb6-6d5b20c9ec0a@yandex.ru> <87sgs8dju6.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <502167e4-7a6b-5110-5cf0-c355ad5f7346@yandex.ru> Date: Tue, 18 Jun 2019 01:23:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <87sgs8dju6.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 35624 Cc: 35624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 17.06.2019 23:42, Juri Linkov wrote: > C-v/M-v will help them to discover this useful feature. OK. I'm fine with waiting for user complaints before adding the variable. From unknown Mon Jun 16 23:48:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 16 Jul 2019 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator