GNU bug report logs - #35611
[PATCH 1/2] gnu: cross-base: Allow using non-default glibc.

Previous Next

Package: guix-patches;

Reported by: Carl Dong <accounts <at> carldong.me>

Date: Mon, 6 May 2019 22:23:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Carl Dong <accounts <at> carldong.me>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: "35611 <at> debbugs.gnu.org" <35611 <at> debbugs.gnu.org>
Subject: [bug#35611] [PATCH 1/2] gnu: cross-base: Allow using non-default glibc.
Date: Mon, 13 May 2019 02:46:39 +0000
Hi Ludovic,

> Really a detail, but for clarity I would change “xlibc” to “libc”, because
> this argument denotes a C library, not a cross-compiled C library.
>
> Ditto in other places.
>
> You can send an updated patch or I can make this change on your behalf if you
> prefer, let me know!

Ah yes! That does make it more clear. Could you make this change for me? Thanks!

> This procedure is starting to look weird. :-) I wonder if we should inline it
> at the call sites, but we can look into it later.

Haha that's what I thought too... Inlining would probably make the most sense.
I'll submit another patch to this effect at some point!

Thank you so much for your help. Have an excellent day!

Cheers,
Carl Dong
accounts <at> carldong.me
"I fight for the users"





This bug report was last modified 6 years and 5 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.