From debbugs-submit-bounces@debbugs.gnu.org Mon May 06 18:22:02 2019 Received: (at submit) by debbugs.gnu.org; 6 May 2019 22:22:02 +0000 Received: from localhost ([127.0.0.1]:57685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNlzl-00069d-KC for submit@debbugs.gnu.org; Mon, 06 May 2019 18:22:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNlzj-000693-1r for submit@debbugs.gnu.org; Mon, 06 May 2019 18:22:00 -0400 Received: from lists.gnu.org ([209.51.188.17]:42619) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hNlzd-0006yf-VS for submit@debbugs.gnu.org; Mon, 06 May 2019 18:21:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNlzc-0002p1-T9 for guix-patches@gnu.org; Mon, 06 May 2019 18:21:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hNlzb-0006xc-Pk for guix-patches@gnu.org; Mon, 06 May 2019 18:21:52 -0400 Received: from mail-40132.protonmail.ch ([185.70.40.132]:43643) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hNlzb-0006wH-8A for guix-patches@gnu.org; Mon, 06 May 2019 18:21:51 -0400 Date: Mon, 06 May 2019 22:21:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=carldong.me; s=protonmail; t=1557181308; bh=+mkus5IuGkkphsrZ92wzHPdJqR8mq6waKm06nyLbdZk=; h=Date:To:From:Cc:Reply-To:Subject:Feedback-ID:From; b=j9kLvIAdJ1BTSW7al+MiSyxhMlkhb+GFzUzgtLNUCRWOXASWAPEWfhFu1PHaA2AD/ LpwvwY52BSiH+/Df+NeUigz8RWQ0xLRTuA3oNDvMwIWT6Y3FjIj9BbKOaseO5At1jj IO7ZCS1uOCb6Tv7usIib5tqkAxpeufO/THchyGxU= To: guix-patches@gnu.org From: Carl Dong Subject: [PATCH 1/2] gnu: cross-base: Allow using non-default glibc. Message-ID: Feedback-ID: a8j8tDUaJ4AYuDVBywMTwsJebN4w8TVXadJLsJb8td3t3dZi9RdXFlPaQvoFKnI9KgXySsPXcRkajVyY0cGTcA==:Ext:ProtonMail MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 185.70.40.132 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Carl Dong X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Carl Dong Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/cross-base.scm (cross-libc, native-libc, cross-newlib?): Add xlibc optional argument to specify using a non-default glibc package. --- gnu/packages/cross-base.scm | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/gnu/packages/cross-base.scm b/gnu/packages/cross-base.scm index 25caacb723..51e9e2962a 100644 --- a/gnu/packages/cross-base.scm +++ b/gnu/packages/cross-base.scm @@ -422,14 +422,15 @@ target that libc." =20 (define* (cross-libc target #:optional + (xlibc glibc) (xgcc (cross-gcc target)) (xbinutils (cross-binutils target)) (xheaders (cross-kernel-headers target))) - "Return a libc cross-built for TARGET, a GNU triplet. Use XGCC and -XBINUTILS and the cross tool chain." - (if (cross-newlib? target) - (native-libc target) - (let ((libc glibc)) + "Return XLIBC cross-built for TARGET, a GNU triplet. Use XGCC and XBINUT= ILS +and the cross tool chain." + (if (cross-newlib? target xlibc) + (native-libc target xlibc) + (let ((libc xlibc)) (package (inherit libc) (name (string-append "glibc-cross-" target)) (arguments @@ -502,13 +503,17 @@ XBINUTILS and the cross tool chain." ,@(package-inputs libc) ;FIXME: static-bash ,@(package-native-inputs libc))))))) =20 -(define (native-libc target) +(define* (native-libc target + #:optional + (xlibc glibc)) (if (target-mingw? target) mingw-w64 - glibc)) + xlibc)) =20 -(define (cross-newlib? target) - (not (eq? (native-libc target) glibc))) +(define* (cross-newlib? target + #:optional + (xlibc glibc)) + (not (eq? (native-libc target xlibc) xlibc))) =20 =0C ;;; Concrete cross tool chains are instantiated like this: --=20 2.21.0 From debbugs-submit-bounces@debbugs.gnu.org Mon May 06 18:34:32 2019 Received: (at 35611) by debbugs.gnu.org; 6 May 2019 22:34:32 +0000 Received: from localhost ([127.0.0.1]:57716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNmBr-00009h-Vd for submit@debbugs.gnu.org; Mon, 06 May 2019 18:34:32 -0400 Received: from mail1.protonmail.ch ([185.70.40.18]:15955) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNmBp-00009P-Tr for 35611@debbugs.gnu.org; Mon, 06 May 2019 18:34:30 -0400 Date: Mon, 06 May 2019 22:34:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=carldong.me; s=protonmail; t=1557182063; bh=bJ8cyGQqz/mc7+snfo9CTW+jdPt4FtrmQp13NtO7C70=; h=Date:To:From:Reply-To:Subject:Feedback-ID:From; b=JayQIj7rnmgGVUux55u7LZV0EqtCHcO9MmmZmyjDh5dm09tgAy8ka1uYvyUIlGfqD 1wK9PQ370J8L66WoTUK7kxDMK4VvY9s1a+jJZbdeFx9E/1GKdYoLWs7+CUGpuXC4Gm J2ywJ0vgI1T/ui9hCEFbOYEOYVJWb1zURrk7IvCE= To: "35611@debbugs.gnu.org" <35611@debbugs.gnu.org> From: Carl Dong Subject: [PATCH 2/2] gnu: Allow building gcc with non-default libc. Message-ID: Feedback-ID: a8j8tDUaJ4AYuDVBywMTwsJebN4w8TVXadJLsJb8td3t3dZi9RdXFlPaQvoFKnI9KgXySsPXcRkajVyY0cGTcA==:Ext:ProtonMail MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 35611 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Carl Dong Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/base.scm (make-gcc-libc): New procedure, returns a gcc that targets a specified libc. (gcc-glibc-2.26, gcc-glibc-2.27): New public variables. --- gnu/packages/base.scm | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm index e33e3c52c8..5c0cd36c14 100644 --- a/gnu/packages/base.scm +++ b/gnu/packages/base.scm @@ -1009,6 +1009,35 @@ with the Linux kernel.") (("/bin/pwd") "pwd")) #t)))))))) +(define (make-gcc-libc base-gcc libc) + "Return a GCC that targets LIBC." + (package (inherit base-gcc) + (name (string-append (package-name base-gcc) "-" + (package-name libc) "-" + (package-version libc))) + (arguments + (substitute-keyword-arguments + (ensure-keyword-arguments (package-arguments base-gcc) + '(#:implicit-inputs? #f)) + ((#:make-flags flags) + `(let ((libc (assoc-ref %build-inputs "libc"))) + ;; FLAGS_FOR_TARGET are needed for the target libraries t= o receive + ;; the -Bxxx for the startfiles. + (cons (string-append "FLAGS_FOR_TARGET=3D-B" libc "/lib") + ,flags))))) + (native-inputs + `(("libc" ,libc) + ("libc:static" ,libc "static") + ,@(append (package-inputs base-gcc) + (fold alist-delete (%final-inputs) '("libc" "libc:= static"))))) + (inputs '()))) + +(define-public gcc-glibc-2.27 + (make-gcc-libc gcc glibc-2.27)) + +(define-public gcc-glibc-2.26 + (make-gcc-libc gcc glibc-2.26)) + (define-public (make-glibc-locales glibc) (package (inherit glibc) -- 2.21.0 From debbugs-submit-bounces@debbugs.gnu.org Sun May 12 17:40:35 2019 Received: (at 35611) by debbugs.gnu.org; 12 May 2019 21:40:35 +0000 Received: from localhost ([127.0.0.1]:43537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPwCx-000778-AF for submit@debbugs.gnu.org; Sun, 12 May 2019 17:40:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPwCv-00076u-34 for 35611@debbugs.gnu.org; Sun, 12 May 2019 17:40:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33849) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPwCo-0002s0-7V; Sun, 12 May 2019 17:40:26 -0400 Received: from [2a01:e0a:1d:7270:6a6c:dc17:fc02:cfda] (port=37436 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hPwCn-0003Qx-Hg; Sun, 12 May 2019 17:40:25 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Carl Dong Subject: Re: [bug#35611] [PATCH 1/2] gnu: cross-base: Allow using non-default glibc. References: Date: Sun, 12 May 2019 23:40:23 +0200 In-Reply-To: (Carl Dong's message of "Mon, 06 May 2019 22:21:43 +0000") Message-ID: <87woivs660.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35611 Cc: 35611@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Carl, Carl Dong skribis: > * gnu/packages/cross-base.scm (cross-libc, native-libc, cross-newlib?): > Add xlibc optional argument to specify using a non-default glibc > package. [...] > (define* (cross-libc target > #:optional > + (xlibc glibc) > (xgcc (cross-gcc target)) > (xbinutils (cross-binutils target)) > (xheaders (cross-kernel-headers target))) > - "Return a libc cross-built for TARGET, a GNU triplet. Use XGCC and > -XBINUTILS and the cross tool chain." > - (if (cross-newlib? target) > - (native-libc target) > - (let ((libc glibc)) > + "Return XLIBC cross-built for TARGET, a GNU triplet. Use XGCC and XBIN= UTILS > +and the cross tool chain." Really a detail, but for clarity I would change =E2=80=9Cxlibc=E2=80=9D to = =E2=80=9Clibc=E2=80=9D, because this argument denotes a C library, not a cross-compiled C library. Ditto in other places. You can send an updated patch or I can make this change on your behalf if you prefer, let me know! > -(define (native-libc target) > +(define* (native-libc target > + #:optional > + (xlibc glibc)) > (if (target-mingw? target) > mingw-w64 > - glibc)) > + xlibc)) This procedure is starting to look weird. :-) I wonder if we should inline it at the call sites, but we can look into it later. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun May 12 17:41:28 2019 Received: (at 35611) by debbugs.gnu.org; 12 May 2019 21:41:29 +0000 Received: from localhost ([127.0.0.1]:43541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPwDo-00078j-NC for submit@debbugs.gnu.org; Sun, 12 May 2019 17:41:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPwDm-00078T-9X for 35611@debbugs.gnu.org; Sun, 12 May 2019 17:41:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPwDh-0006Dv-4T; Sun, 12 May 2019 17:41:21 -0400 Received: from [2a01:e0a:1d:7270:6a6c:dc17:fc02:cfda] (port=37438 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hPwDg-0003Tc-J8; Sun, 12 May 2019 17:41:20 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Carl Dong Subject: Re: [bug#35611] [PATCH 2/2] gnu: Allow building gcc with non-default libc. References: Date: Sun, 12 May 2019 23:41:19 +0200 In-Reply-To: (Carl Dong's message of "Mon, 06 May 2019 22:34:15 +0000") Message-ID: <87sgtjs64g.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35611 Cc: "35611@debbugs.gnu.org" <35611@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Carl Dong skribis: > * gnu/packages/base.scm (make-gcc-libc): New procedure, returns a gcc > that targets a specified libc. > (gcc-glibc-2.26, gcc-glibc-2.27): New public variables. Nice, LGTM! (I=E2=80=99ll push it along with patch #1.) From debbugs-submit-bounces@debbugs.gnu.org Sun May 12 22:46:51 2019 Received: (at 35611) by debbugs.gnu.org; 13 May 2019 02:46:51 +0000 Received: from localhost ([127.0.0.1]:43817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQ0zK-0008IY-Pk for submit@debbugs.gnu.org; Sun, 12 May 2019 22:46:51 -0400 Received: from mail2.protonmail.ch ([185.70.40.22]:53800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQ0zI-0008II-Aj for 35611@debbugs.gnu.org; Sun, 12 May 2019 22:46:49 -0400 Date: Mon, 13 May 2019 02:46:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=carldong.me; s=protonmail; t=1557715602; bh=8KL2Y/lYuxkexIKW5BAVOrh7PsZotPWL9AmnK5TsSbE=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References: Feedback-ID:From; b=dk0Mkuf5RBu8Z2wKtptcNvPNOtEVSDPfNU5rgltjceyHBeHgm/QWY+hOjGPavmcLV lWHjtlszgkxytm+ZqjFZe1y7V8qR2WpZB+1e8amNzQVjRW4kYTsQ8e8CTga7NWIFGU Pxksy0ErlKK2t5zEFPz7xxTiQiU/evBEsYm1l8EU= To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= From: Carl Dong Subject: Re: [bug#35611] [PATCH 1/2] gnu: cross-base: Allow using non-default glibc. Message-ID: In-Reply-To: <87woivs660.fsf@gnu.org> References: <87woivs660.fsf@gnu.org> Feedback-ID: a8j8tDUaJ4AYuDVBywMTwsJebN4w8TVXadJLsJb8td3t3dZi9RdXFlPaQvoFKnI9KgXySsPXcRkajVyY0cGTcA==:Ext:ProtonMail MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 35611 Cc: "35611@debbugs.gnu.org" <35611@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Carl Dong Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Ludovic, > Really a detail, but for clarity I would change =E2=80=9Cxlibc=E2=80= =9D to =E2=80=9Clibc=E2=80=9D, because > this argument denotes a C library, not a cross-compiled C library. > > Ditto in other places. > > You can send an updated patch or I can make this change on your behalf if= you > prefer, let me know! Ah yes! That does make it more clear. Could you make this change for me? Th= anks! > This procedure is starting to look weird. :-) I wonder if we should inlin= e it > at the call sites, but we can look into it later. Haha that's what I thought too... Inlining would probably make the most sen= se. I'll submit another patch to this effect at some point! Thank you so much for your help. Have an excellent day! Cheers, Carl Dong accounts@carldong.me "I fight for the users" From debbugs-submit-bounces@debbugs.gnu.org Mon May 13 03:46:06 2019 Received: (at 35611-done) by debbugs.gnu.org; 13 May 2019 07:46:06 +0000 Received: from localhost ([127.0.0.1]:43971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQ5ew-0000YQ-4f for submit@debbugs.gnu.org; Mon, 13 May 2019 03:46:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQ5et-0000RU-W1 for 35611-done@debbugs.gnu.org; Mon, 13 May 2019 03:46:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40368) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQ5eo-0002m7-GN; Mon, 13 May 2019 03:45:58 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=41798 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hQ5eo-0001UA-2J; Mon, 13 May 2019 03:45:58 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Carl Dong Subject: Re: [bug#35611] [PATCH 1/2] gnu: cross-base: Allow using non-default glibc. References: <87woivs660.fsf@gnu.org> Date: Mon, 13 May 2019 09:45:56 +0200 In-Reply-To: (Carl Dong's message of "Mon, 13 May 2019 02:46:39 +0000") Message-ID: <87lfzavlu3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35611-done Cc: "35611@debbugs.gnu.org" <35611-done@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Carl, Carl Dong skribis: >> Really a detail, but for clarity I would change =E2=80=9Cxlibc=E2=80=9D = to =E2=80=9Clibc=E2=80=9D, because >> this argument denotes a C library, not a cross-compiled C library. >> >> Ditto in other places. >> >> You can send an updated patch or I can make this change on your behalf i= f you >> prefer, let me know! > > Ah yes! That does make it more clear. Could you make this change for me? = Thanks! Done! >> This procedure is starting to look weird. :-) I wonder if we should inli= ne it >> at the call sites, but we can look into it later. > > Haha that's what I thought too... Inlining would probably make the most s= ense. > I'll submit another patch to this effect at some point! Awesome. :-) Thank you! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon May 13 06:09:59 2019 Received: (at 35611) by debbugs.gnu.org; 13 May 2019 10:09:59 +0000 Received: from localhost ([127.0.0.1]:44162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQ7uB-0007sn-Cy for submit@debbugs.gnu.org; Mon, 13 May 2019 06:09:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQ7u9-0007sP-TB for 35611@debbugs.gnu.org; Mon, 13 May 2019 06:09:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42202) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQ7u4-0002Vq-J1; Mon, 13 May 2019 06:09:52 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=42880 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hQ7u2-0007tZ-Cs; Mon, 13 May 2019 06:09:51 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Carl Dong Subject: Re: [bug#35611] [PATCH 1/2] gnu: cross-base: Allow using non-default glibc. References: <87woivs660.fsf@gnu.org> Date: Mon, 13 May 2019 12:09:49 +0200 In-Reply-To: (Carl Dong's message of "Mon, 13 May 2019 02:46:39 +0000") Message-ID: <87ef52u0lu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35611 Cc: "35611@debbugs.gnu.org" <35611@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Carl Dong skribis: >> Really a detail, but for clarity I would change =E2=80=9Cxlibc=E2=80=9D = to =E2=80=9Clibc=E2=80=9D, because >> this argument denotes a C library, not a cross-compiled C library. >> >> Ditto in other places. >> >> You can send an updated patch or I can make this change on your behalf i= f you >> prefer, let me know! > > Ah yes! That does make it more clear. Could you make this change for me? = Thanks! In commit 04a3ecc79ec01242acd0928f89bf982f50c866df, I had to remove the pre-defined uses of =E2=80=98make-gcc-libc=E2=80=99 because of the circular= top-level references they introduced. I suppose they were here mostly for illustrative purposes though, so hopefully that=E2=80=99s OK. Let me know! Ludo=E2=80=99. From unknown Fri Jun 13 11:07:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 10 Jun 2019 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator