GNU bug report logs - #35609
26.2; wdired-finish-edit clears find-dired listing

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: Alvaro Ramirez <alvaro <at> xenodium.com>, 35609 <at> debbugs.gnu.org, Roland Winkler <winkler <at> gnu.org>
Subject: bug#35609: 26.2; wdired-finish-edit clears find-dired listing
Date: Mon, 15 Jul 2019 19:33:46 +0200

Stephen Berman <stephen.berman <at> gmx.net> writes:

> -        (forward-line)
> -	(beginning-of-line)))))
> +        (forward-line)))))
>
>  (defun wdired-get-previous-link (&optional old move)
>
> These lines are at the end of a while (not (eobp)) loop and, unless I'm
> overlooking something, prior to the change to find-dired-sentinel, the
> use of beginning-of-line here was a noop, since forward-line always puts
> point at BOL -- except when the buffer doesn't end with a newline, and
> that's why the change to find-dired-sentinel caused the find-dired hang.
> Thus, reverting the above three lines of the find-dired-sentinel change
> makes beginning-of-line in wdired-preprocess-symlinks strictly a noop,
> while retaining that change makes calling beginning-of-line harmful, so
> in any case that call should removed.  Or does anyone see a problem with
> that?

Yes, I think you're right -- removing that beginning-of-line is the
correct thing, no matter what.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.