Subject: Re: bug#35606: Gajim

From: Ricardo Wurmus <[email-masked]>
Date: Mon, 13 May 2019 09:04:26 +0200

Ricardo Wurmus <[email-masked]> writes:

> Tobias Geerinckx-Rice <[email-masked]> writes:
>
>> Traceback (most recent call last):
>>  File
>> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/application.py",
>> line 221, in _activate
>>    self.interface.run(self)
>>  File
>> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/gui_interface.py",
>> line 2550, in run
>>    app.plugin_manager = plugins.PluginManager()
>>  File
>> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/helpers.py",
>> line 129, in __call__
>>    cls.instance = super(Singleton, cls).__call__(*args, **kwargs)
>>  File
>> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/pluginmanager.py",
>> line 115, in __init__
>>    pc = self.scan_dir_for_plugins(path)
>>  File
>> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/helpers.py",
>> line 114, in wrapper
>>    result = f(*args, **kwargs)
>>  File
>> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/pluginmanager.py",
>> line 598, in scan_dir_for_plugins
>>    if not os.path.isdir(path):
>>  File
>> "/gnu/store/h8l1pby3cm6b4fxsfwwr65b4d1hyh6cs-python-3.7.0/lib/python3.7/genericpath.py",
>> line 42, in isdir
>>    st = os.stat(s)
>> TypeError: stat: path should be string, bytes, os.PathLike or integer,
>
> This is a problem with the “add-plugin-dirs” phase.  After setting
> GAJIM_PLUGIN_PATH to “/tmp” Gajim seems to work fine for me.
>
> We need to make sure that even without setting GAJIM_PLUGIN_PATH “path”
> is a string.

I fixed this with commit a624c3631077aa3fa5c05849579932c5b67b985c.  When
GAJIM_PLUGIN_PATH is not set it will not be added to the list of
directories that are searched for plugins.

--
Ricardo