From debbugs-submit-bounces@debbugs.gnu.org Mon May 06 11:43:05 2019 Received: (at submit) by debbugs.gnu.org; 6 May 2019 15:43:05 +0000 Received: from localhost ([127.0.0.1]:57249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNflg-000211-UE for submit@debbugs.gnu.org; Mon, 06 May 2019 11:43:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53341) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNflc-00020R-J4 for submit@debbugs.gnu.org; Mon, 06 May 2019 11:43:02 -0400 Received: from lists.gnu.org ([209.51.188.17]:43096) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hNflX-0003kq-8C for submit@debbugs.gnu.org; Mon, 06 May 2019 11:42:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNflW-0002vI-4O for bug-guix@gnu.org; Mon, 06 May 2019 11:42:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hNflV-0003hZ-4C for bug-guix@gnu.org; Mon, 06 May 2019 11:42:54 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:38635) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hNflU-0003ff-Qa for bug-guix@gnu.org; Mon, 06 May 2019 11:42:53 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 2397A203ED; Mon, 6 May 2019 11:42:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 06 May 2019 11:42:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=PYvaB2J9FSKK/jhPlmv3Ys25 ufLvBm7k65a0xU7QYGQ=; b=KWwBDWIBePLLDQQXZ248D5P6/jQqnTWIngAXViJ/ iGgyGP+0Dxy3uOL9tCfd3XLI0xKbJdm6bKojzqdM3oYqPqnKEaW3kttKhXrVaBDO Kf6uPBUL5NjerLu3DFwhskmOy+3x8/oxDev366y2a4bpifxG4M7HZhnPtRVCbDs/ U7g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=PYvaB2 J9FSKK/jhPlmv3Ys25ufLvBm7k65a0xU7QYGQ=; b=sZw912WliWb0w3SREGE59K utzYX41wF2+BWmY4Dwb/qQWj5/OzKz7AYqgkddvDJ8LxEirUbuprNq3ET6159t9w KT2oh1QWSyupOOa/qtKBQci+Lkq26PWAzX6V/O3PZlx/PI43FXg3fdkU25kBWn/c XtkXOmb0Im6HsKUpyMTgDU09HYgYxlJDXgbD27Zi1LAco6kucUK8fOltUBvc2oh1 U+CmWM8t4bRvqLWz1WqAClNac0aJ5BunycjI/NrHOm8swFX+e2BoSYVqVs0RR3N5 m7KIVukUmLycJXIShCb8YQ5jcjMt5lNulFroJ48caCBzb0IXbUGb3fym2C6gbIRw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrjeejgdelhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujggfsehgtderredtreejnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucffohhmrghinh epghhithhhuhgsrdgtohhmnecukfhppeejiedruddvgedrudefkedrieefnecurfgrrhgr mhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgvnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (c-76-124-138-63.hsd1.pa.comcast.net [76.124.138.63]) by mail.messagingengine.com (Postfix) with ESMTPA id 37516E4626; Mon, 6 May 2019 11:42:51 -0400 (EDT) Date: Mon, 6 May 2019 11:42:49 -0400 From: Leo Famulari To: Maxim Cournoyer Subject: Go build system mishandles repetitive import paths (was [PATCH] build: go-build-system: Ensure uniform unpacking directory.) Message-ID: <20190506154249.GA9060@jasmine.lan> References: <87tvf1nshy.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="r5Pyd7+fXNt84Ff3" Content-Disposition: inline In-Reply-To: <87tvf1nshy.fsf@gmail.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.27 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: bug-guix@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --r5Pyd7+fXNt84Ff3 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 14, 2019 at 12:03:05AM -0400, Maxim Cournoyer wrote: > From 1f7535fbe28f7ac96e824b792e9f1a140b8c54cd Mon Sep 17 00:00:00 2001 > From: Maxim Cournoyer > Date: Fri, 5 Apr 2019 00:00:08 -0400 > Subject: [PATCH 3/3] build: go-build-system: Ensure uniform unpacking > directory. >=20 > Depending on whether the source is a directory or an archive, we strip the > source directory or preserve it, respectively. This change makes it so t= hat > whether the type of the source, it is unpacked at the expected location g= iven > by the IMPORT-PATH of the Go build system. >=20 > * guix/build/go-build-system.scm: Add the (ice-9 ftw) module. > (unpack): Add inner procedure to maybe strip the top level directory of an > archive, document it and use it. This commit (or patch series) broke the build of Syncthing and maybe others. It seems like the the new unpacking code is stripping duplicate directory names? It fails like this: ------ starting phase `increase-test-timeout' Backtrace: 6 (primitive-load "/gnu/store/yfvy06fscz726da5wjvh9jxjsah=E2=80= =A6") In ice-9/eval.scm: 191:35 5 (_ _) In srfi/srfi-1.scm: 863:16 4 (every1 # =E2=80=A6) In /gnu/store/zmc0hcmdfg5n4kl32vcla4cg9c9bspfg-module-import/guix/build/gnu= -build-system.scm: 799:28 3 (_ _) In ice-9/eval.scm: 619:8 2 (_ #(#(#) (#:inputs # =E2=80=A6= ))) In /gnu/store/zmc0hcmdfg5n4kl32vcla4cg9c9bspfg-module-import/guix/build/uti= ls.scm: 635:19 1 (with-atomic-file-replacement "src/github.com/syncthin=E2=80= =A6" =E2=80=A6) In unknown file: 0 (mkstemp! "src/github.com/syncthing/syncthing/build.go=E2=80= =A6" =E2=80=A6) ERROR: In procedure mkstemp!: In procedure mkstemp!: No such file or directory ------ And indeed, if you keep the failed build directory, you will see that the path 'src/github.com/syncthing/syncthing' does not exist, even though this corresponds to the Go import path specified in the package definition. Instead it is like src/github.com/syncthing' which is incorrect. --r5Pyd7+fXNt84Ff3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlzQVfYACgkQJkb6MLrK fwgSYA//Tygac1w4WpJpQuHUnQAzCGoWN2g5ZR9kz811zK4Qzz48LNPLq1sB0OQ6 oZnEVPY/fPOmLuajlEzkHJ+3kqcivD9ouYdTJZpyuFWuZT4Ze7E/PRfYKj9z6TpC HVf3Zj59wNzO70SO928/TPjEEWxhUnAOs1kpBX6kUs7OR6akKHBPFKMsS395V4x0 aH9ucxhrSx3lAZPJ19o92Z8OrHHJ9J/QXxlLhjIBUnQq94rn26N0BxGYifHPSY9e vMiu6SpeT559zKfdC1JXDHq5mUrRP6Nbqt6O4P8Tnxl2kJWAYH8cw6Yg4ahwrQF2 p+ws1KNpqKj5rl3oMrezzmFzpwgl+hsQTUaMtpvhFFOoOc70Dr38m7YTLZAGOWwq hLxbWBJEfcqo1tmKunS6rbkMIr70g24qrGHs5KNk6PZql2IFTtiNlpSqEarjifQE VBK29Q5hK/27QtrWQwfD4x4305ZYnujAL0OQusgyTxmEmL22LkQVA7ZDFOsAAvP+ +h4uokWUIArZ62f8HC9Cy1es/juD5im76TswM7bNjehASeSr5zqst0AOta9+REZh UlkgMpTgTWVDVsJ8kWLsAuqwZ6VW0yBFUtMueUicr5Ly9qPm8UogcdxXHPQ5Njm6 07DIsquiS2NG+tnOtTnB7JFUb4puDw9u+dXUJ2v3keD4BqtinZk= =b/W/ -----END PGP SIGNATURE----- --r5Pyd7+fXNt84Ff3-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 06 11:56:27 2019 Received: (at 35603) by debbugs.gnu.org; 6 May 2019 15:56:27 +0000 Received: from localhost ([127.0.0.1]:57270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNfyd-0002OF-Ep for submit@debbugs.gnu.org; Mon, 06 May 2019 11:56:27 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:35641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNfyb-0002O0-VW for 35603@debbugs.gnu.org; Mon, 06 May 2019 11:56:26 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 77B722395B; Mon, 6 May 2019 11:56:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 06 May 2019 11:56:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:subject:message-id:mime-version:content-type; s= mesmtp; bh=MzF1uhLZoRWlY/ndsnEAT3Q4s2FYG/kRxN2xPlG6hpI=; b=Nc1FS CqzxrmLefDuCgp5XD1tCSb2ZVBJxs2LbqxVo8ANqTWFFgM6u+bKfnTmLykRbfA0b gI6t88BavkRSrrflRRKtUKTeMQNSgJGfOKZTFW2ZCoE0As0aB7zQIv6+IA7f6t/c xKcWEE4vcNiTT68CkWIXbJa3Pdfy/Jq2BuTPQc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=MzF1uhLZoRWlY/ndsnEAT3Q4s2FYG /kRxN2xPlG6hpI=; b=f+fwNNekUn2HkKrmh7E9sfp0RyFe/BD3GMqSMGurcWXbP JtUdFcaDpgaO9ml0QlRqODhqFSnDsSXBNtIOO3o5xxrpjmZe2Uv4lK0AWKVGY2qk /3qe+ML63YkmBfDrwWzY7MbQe1SR0CyV+sl/UuOrX/2UxjYBrqHpRIX6ky7lKcWg 14V3gS1/zLdcEccOAVNe81+QMFemRg6KJ3FpSzW1DoBkiRqjMxbUP9mZZuw/MACE bpEqi5Z288RDYdjqBu1QmAIIpfKbNqFStoKUrYNJWnxaHXEa4gFd98InVwO02FQa VyCKaqEPSqVo8zQ7D/3OHrdtvB9p4PnGQPF7fp1gw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrjeejgdeliecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfggtggufgesghdtreertd ervdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhi rdhnrghmvgeqnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepjeeirdduvd egrddufeekrdeifeenucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgr rhhirdhnrghmvgenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (c-76-124-138-63.hsd1.pa.comcast.net [76.124.138.63]) by mail.messagingengine.com (Postfix) with ESMTPA id AC184103CB for <35603@debbugs.gnu.org>; Mon, 6 May 2019 11:56:19 -0400 (EDT) Date: Mon, 6 May 2019 11:56:17 -0400 From: Leo Famulari To: 35603@debbugs.gnu.org Subject: Re: Go build system mishandles repetitive import paths Message-ID: <20190506155617.GA16846@jasmine.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jI8keyz6grp/JLjh" Content-Disposition: inline User-Agent: Mutt/1.11.4 (2019-03-13) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 35603 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --jI8keyz6grp/JLjh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Looks like it affects packages that use tarballs (instead of Git checkouts) and have a repetitive element in the import path. For example, 'github.com/restic/restic' is also broken. --jI8keyz6grp/JLjh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlzQWSEACgkQJkb6MLrK fwj67w/+JDp4gcgiDi5u16GbXvuFeruv/LO65zoTdSJ+1gFvVpfkEDYXdP4Xe4Qd +Dk6E3GEOl/wFIDtjWljUXwIuu9cY71aooMTl0Tx4NhtErocOrUPvReok9oZAUDs EJEAgFEeOt3lBamB+gzY8xL/DORwSdiMBIChhCDw4lEbonC9fqcesRBHOg1KP5fO Wpxtf1EZGv9fvBsC+EHzwMU8meA5LEiV0KF+3YN1IZ7qplLUMeRpSAcSiCIRcOPh yRO6fRQE9arlojp1CBBCMZI4Qbz72cuNYmuIIcGjh3lCwvb9n+I6kdEDDTSHUJHB +CicrjLsE0ECi1ZAKt8Ot1pVxUVNKdEr8J8jrGRDW7nCuMGy9W0xLo4CTkEsWQGN WoBlPINPPh7QrzYoqyeQjyGgvDzAYYhnp09WV8ma3hOacr7QdLfkeHPVbEoOfnPX P8mlm88B82u0XpWDtSPelqzIBTcoiapia3rsg/PChXRheA8/ytQRWp39C2+L91Zq HSUe1Eut4vTI/kuoy33FZXIoX/QPlKsg8cy8yMrARX4lGW2pf32a4q/lCkZrtUOR FShaXnVtlXwsWGIS+tlBr/gdnIhkCItQKUYLe2K3H1+WsadEpA6B38ZEt50vLSx4 4FkZYwQCSUNjtbibfff/uibnOm8zb8c8A3mdTaZg27cX5WXpnDM= =jPJK -----END PGP SIGNATURE----- --jI8keyz6grp/JLjh-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 06 21:10:31 2019 Received: (at 35603-done) by debbugs.gnu.org; 7 May 2019 01:10:32 +0000 Received: from localhost ([127.0.0.1]:57863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNocp-00066P-Hr for submit@debbugs.gnu.org; Mon, 06 May 2019 21:10:31 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:44654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNoco-00066B-AY for 35603-done@debbugs.gnu.org; Mon, 06 May 2019 21:10:30 -0400 Received: by mail-qt1-f194.google.com with SMTP id f24so6759587qtk.11 for <35603-done@debbugs.gnu.org>; Mon, 06 May 2019 18:10:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=z8UA7biAO9rECz3FpkHInV6uxHT2IFoiryqv4/NHvF0=; b=T3RW2Q5sXMD1CynrME2g5VzP49ARl7pngXFANPm9e/+e4nBn/F/FkU2c0UQP6x5MCm aQTOTPLCAt/O1eC/yN9xqBF1lsDjcyHlmyN2xvmLxNgoD8IKgw1N4o23BgmnOdrZ9wL0 DdBidKJSIZ8b/MTW06Ym0PdCyAsO4rSaXi6fbAhbkz77gtXb9yjPtPFDRYGxDBhlwlZR GQGS6eXY8XrazmiBqqadbMO5VPLWopqHtp/7iRpHckZQ0MkvFJoYK2GyzfEau98VJ+Im pdHM05vIoyTIlZSpiOCpaZuH5u2vDE+mP1arf9MKLQli1RdQBgSO8EmCSXYB6DloN3zG wkAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=z8UA7biAO9rECz3FpkHInV6uxHT2IFoiryqv4/NHvF0=; b=HizFTz7o/APAFl1+iug2dhBFy0W4bSIs3NsnQNA7Vh1szXEVBi8KkUezqy+NkSKHnF PbyhBJfcugyEXtHj6qC4V7Pcb9q6/Eb8ClcpCJXt0x/tha5DuvYG6e/Uk5gSr0sdNu8d VuATZYWmwDLb0x8UD3n5KnGabG/S++BvC2nO0vuV3/sC3aSwbHsdNUS0aVInomLn/O95 prkXx16hCKcX0mrEEhdxPORzD4QSdDLirlP304yhXHUG69egmwVg8k8EIubink2xPxb+ 3lxSNvZja3jE/CELx9xPENu6vlUO5o3740Rh2M0BvLtEDYT+llTVhl0l2JjzwcNz/7ee Hc1w== X-Gm-Message-State: APjAAAX1PvC+oOBYSCn6SyyKA150mCZNpR23wqtDmYMOavBSc/hOhHft kt/DVNP4461d/bEREgVk6si7ObvW X-Google-Smtp-Source: APXvYqwWfUJ9jGtFFjSh9fQOyTJ39uKRO9cmtB/NbV1oI7n3IDQcI3d1BOTvR+pKo8EEtCnZUapEcg== X-Received: by 2002:ac8:8fb:: with SMTP id y56mr9215639qth.160.1557191424379; Mon, 06 May 2019 18:10:24 -0700 (PDT) Received: from kwak (dsl-155-225.b2b2c.ca. [66.158.155.225]) by smtp.gmail.com with ESMTPSA id c20sm5778174qkm.67.2019.05.06.18.10.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 May 2019 18:10:23 -0700 (PDT) From: Maxim Cournoyer To: Leo Famulari Subject: Re: Go build system mishandles repetitive import paths (was [PATCH] build: go-build-system: Ensure uniform unpacking directory.) References: <87tvf1nshy.fsf@gmail.com> <20190506154249.GA9060@jasmine.lan> Date: Mon, 06 May 2019 21:10:21 -0400 In-Reply-To: <20190506154249.GA9060@jasmine.lan> (Leo Famulari's message of "Mon, 6 May 2019 11:42:49 -0400") Message-ID: <87a7fzcbnm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35603-done Cc: 35603-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Leo, Leo Famulari writes: > On Sun, Apr 14, 2019 at 12:03:05AM -0400, Maxim Cournoyer wrote: >> From 1f7535fbe28f7ac96e824b792e9f1a140b8c54cd Mon Sep 17 00:00:00 2001 >> From: Maxim Cournoyer >> Date: Fri, 5 Apr 2019 00:00:08 -0400 >> Subject: [PATCH 3/3] build: go-build-system: Ensure uniform unpacking >> directory. >> >> Depending on whether the source is a directory or an archive, we strip t= he >> source directory or preserve it, respectively. This change makes it so = that >> whether the type of the source, it is unpacked at the expected location = given >> by the IMPORT-PATH of the Go build system. >> >> * guix/build/go-build-system.scm: Add the (ice-9 ftw) module. >> (unpack): Add inner procedure to maybe strip the top level directory of = an >> archive, document it and use it. > > This commit (or patch series) broke the build of Syncthing and maybe > others. Thanks for the heads-up! > It seems like the the new unpacking code is stripping duplicate > directory names? > It does as documented in the docstring of the unpack phase: If the SOURCE archive has a single top level directory, it is stripped so that the sources appear directly under UNPACK-PATH. This behavior was made possible with commit f42e4ebb56fe4f16991ca6c6e060c8f3535865cb, that made it so that: [...] whether the type of the source, it is unpacked at the expected location given by the IMPORT-PATH of the Go build system. > It fails like this: > > ------ > starting phase `increase-test-timeout' > Backtrace: > 6 (primitive-load "/gnu/store/yfvy06fscz726da5wjvh9jxjsah=E2= =80=A6") > In ice-9/eval.scm: > 191:35 5 (_ _) > In srfi/srfi-1.scm: > 863:16 4 (every1 # =E2=80=A6) > In /gnu/store/zmc0hcmdfg5n4kl32vcla4cg9c9bspfg-module-import/guix/build/g= nu-build-system.scm: > 799:28 3 (_ _) > In ice-9/eval.scm: > 619:8 2 (_ #(#(#) (#:inputs # =E2=80= =A6))) > In /gnu/store/zmc0hcmdfg5n4kl32vcla4cg9c9bspfg-module-import/guix/build/u= tils.scm: > 635:19 1 (with-atomic-file-replacement "src/github.com/syncthin=E2=80= =A6" =E2=80=A6) > In unknown file: > 0 (mkstemp! "src/github.com/syncthing/syncthing/build.go=E2=80= =A6" =E2=80=A6) > > ERROR: In procedure mkstemp!: > In procedure mkstemp!: No such file or directory > ------ > > And indeed, if you keep the failed build directory, you will see that > the path 'src/github.com/syncthing/syncthing' does not exist, even > though this corresponds to the Go import path specified in the package > definition. > > Instead it is like src/github.com/syncthing' which is incorrect. The fix was to drop the "unpack-pack" argument of the go-build-system for syncthing, which means we want the sources unpacked at the location specified by the "import-path". Done with commit d879fd80c74371120a2cfa30e18a2e28dc02d31d; closing. Thank you! Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon May 06 22:43:01 2019 Received: (at 35603) by debbugs.gnu.org; 7 May 2019 02:43:01 +0000 Received: from localhost ([127.0.0.1]:57934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNq4L-0000Dj-6O for submit@debbugs.gnu.org; Mon, 06 May 2019 22:43:01 -0400 Received: from mail-qk1-f181.google.com ([209.85.222.181]:44683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNq4H-0000DO-Dz for 35603@debbugs.gnu.org; Mon, 06 May 2019 22:42:59 -0400 Received: by mail-qk1-f181.google.com with SMTP id w25so203251qkj.11 for <35603@debbugs.gnu.org>; Mon, 06 May 2019 19:42:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=YyrXYIjbAUHF3TPmAp1Q9o5Qt46SMyBfOTo2jlM6t48=; b=Gm1wNil8Dv5dipOrht6v4rd+lP+FqtJFMJCGbfIpaeW6QmmtPQzR9TKViIlDGmcX+2 Hk/UwHmPMt6gAFYCkuFGFqAmtd99yXTHqBRdrS+gl29mmXkmwXPYjXUVmOveyHlA6Vvh FVXc5Fe69vDmmwT0fbw7dmocXg7pJpJy2OGSeKGEBIihf0jcoYXaTc5Xc+auWo2p7fQe hOmgdjcJCIlm7g2DyXmJBRDzzXk4NbH07NBn3oHvfkpU5p19ZZI6LesA2/EgJAb0u40w PPMO9VDvaKdpUOuhHJ69irryhaexLltptKJSPcWafqYyF0zaS3Q8YqWRzUrcfHAp1tk4 FCnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=YyrXYIjbAUHF3TPmAp1Q9o5Qt46SMyBfOTo2jlM6t48=; b=WILF+l6vR6eSk+nBLztpjBmYgrZdQz4NgEgr53ULpT9otlctfwhkyHnGsGhdscEnKN eYPpton8jTXC/A2ZFlwCK35AiV4s9P70EMmVJGpSZSr/iBG75ppVJGHE1M/uDgWIKO3U cBDzmMaB1c8NUoG8lGb8+M3WAX9W7WmWjTtwSq3PIrBBgd8ymk9ndTkbvcHZ3Gx5oTmw LaJIyiYJhU6Q7q+zIqw3agRQVjnsP+hpxu8N6ZPaS3WztbogXWBaTz81alo1OwtEzQG1 e5Dlpwj5c0IjSMBYTsVeRKZ22U/ZPBmrJpFm0gzPmkaoTLwxr5X7D7As4Lc98UfwqIK2 ongg== X-Gm-Message-State: APjAAAWVTqYmUNYB0hmW3pC5zj2549Z7a6OZy9Km+quKPeqft7KpichB 3yyL5SsbPpX9UvHF18ZZ27bTd5ss9TE= X-Google-Smtp-Source: APXvYqyppbKi95HQoPcLpO4YKh04+EnI0h3Vcxb4wjJO/cfzBWR+iV/rXzfjVB4c7AZvkts8Z9Seww== X-Received: by 2002:a05:620a:39b:: with SMTP id q27mr7410971qkm.223.1557196971295; Mon, 06 May 2019 19:42:51 -0700 (PDT) Received: from kwak (dsl-155-225.b2b2c.ca. [66.158.155.225]) by smtp.gmail.com with ESMTPSA id l15sm7337308qti.12.2019.05.06.19.42.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 May 2019 19:42:50 -0700 (PDT) From: Maxim Cournoyer To: Leo Famulari Subject: Re: bug#35603: Go build system mishandles repetitive import paths References: <20190506154249.GA9060@jasmine.lan> <20190506155617.GA16846@jasmine.lan> Date: Mon, 06 May 2019 22:42:49 -0400 In-Reply-To: <20190506155617.GA16846@jasmine.lan> (Leo Famulari's message of "Mon, 6 May 2019 11:56:17 -0400") Message-ID: <871s1bc7di.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 35603 Cc: 35603@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello again, Leo Famulari writes: > Looks like it affects packages that use tarballs (instead of Git > checkouts) and have a repetitive element in the import path. For > example, 'github.com/restic/restic' is also broken. I've fixed restic with commit fb09818277; sorry! Maxim From unknown Fri Jun 13 10:50:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 04 Jun 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator