From unknown Sat Aug 09 13:17:40 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#35593] [PATCH] uuid: Pad resulting FAT uuid string with leading zeroes. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 05 May 2019 21:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35593 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 35593@debbugs.gnu.org Cc: Danny Milosavljevic X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.155709265826726 (code B ref -1); Sun, 05 May 2019 21:45:01 +0000 Received: (at submit) by debbugs.gnu.org; 5 May 2019 21:44:18 +0000 Received: from localhost ([127.0.0.1]:55071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNOvh-0006x0-UX for submit@debbugs.gnu.org; Sun, 05 May 2019 17:44:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNOvf-0006wn-VG for submit@debbugs.gnu.org; Sun, 05 May 2019 17:44:16 -0400 Received: from lists.gnu.org ([209.51.188.17]:58868) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hNOvZ-0000HV-Pe for submit@debbugs.gnu.org; Sun, 05 May 2019 17:44:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNOvX-0004WS-Ln for guix-patches@gnu.org; Sun, 05 May 2019 17:44:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hNOvV-00008b-Ov for guix-patches@gnu.org; Sun, 05 May 2019 17:44:06 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:55116) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hNOvT-00089d-N9 for guix-patches@gnu.org; Sun, 05 May 2019 17:44:05 -0400 Received: from dayas.3.home (178.113.194.41.wireless.dyn.drei.com [178.113.194.41]) by dd26836.kasserver.com (Postfix) with ESMTPSA id E89B533602A1; Sun, 5 May 2019 23:43:57 +0200 (CEST) From: Danny Milosavljevic Date: Sun, 5 May 2019 23:43:54 +0200 Message-Id: <20190505214354.24882-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Tags: patch Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 85.13.145.193 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Fixes . Reported by sirgazil . * gnu/system/uuid.scm (fat-uuid->string): Pad resulting string with leadi= ng zeroes. --- gnu/system/uuid.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/system/uuid.scm b/gnu/system/uuid.scm index f13960c3e9..7204d163d0 100644 --- a/gnu/system/uuid.scm +++ b/gnu/system/uuid.scm @@ -175,7 +175,7 @@ ISO9660 UUID representation." "Convert FAT32/FAT16 UUID, a 4-byte bytevector, to its string represen= tation." (let ((high (bytevector-uint-ref uuid 0 %fat-endianness 2)) (low (bytevector-uint-ref uuid 2 %fat-endianness 2))) - (format #f "~:@(~x-~x~)" low high))) + (format #f "~:@(~4,'0x-~4,'0x~)" low high))) =20 (define %fat-uuid-rx (make-regexp "^([[:xdigit:]]{4})-([[:xdigit:]]{4})$")) From unknown Sat Aug 09 13:17:40 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Danny Milosavljevic Subject: bug#35593: closed (Re: [bug#35593] [PATCH] uuid: Pad resulting FAT uuid string with leading zeroes.) Message-ID: References: <87y33gey4w.fsf@gnu.org> <20190505214354.24882-1-dannym@scratchpost.org> X-Gnu-PR-Message: they-closed 35593 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 35593@debbugs.gnu.org Date: Thu, 09 May 2019 10:12:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1557396722-15067-1" This is a multi-part message in MIME format... ------------=_1557396722-15067-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #35593: [PATCH] uuid: Pad resulting FAT uuid string with leading zeroes. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 35593@debbugs.gnu.org. --=20 35593: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D35593 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1557396722-15067-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 35593-done) by debbugs.gnu.org; 9 May 2019 10:11:06 +0000 Received: from localhost ([127.0.0.1]:34659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOg14-0003te-BA for submit@debbugs.gnu.org; Thu, 09 May 2019 06:11:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54159) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOg11-0003t8-Lw for 35593-done@debbugs.gnu.org; Thu, 09 May 2019 06:11:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39401) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOg0w-0002XH-5t; Thu, 09 May 2019 06:10:58 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=52730 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hOg0v-0002uH-Dt; Thu, 09 May 2019 06:10:57 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Danny Milosavljevic Subject: Re: [bug#35593] [PATCH] uuid: Pad resulting FAT uuid string with leading zeroes. References: <20190505214354.24882-1-dannym@scratchpost.org> Date: Thu, 09 May 2019 12:10:55 +0200 In-Reply-To: <20190505214354.24882-1-dannym@scratchpost.org> (Danny Milosavljevic's message of "Sun, 5 May 2019 23:43:54 +0200") Message-ID: <87y33gey4w.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 35593-done Cc: 35593-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Danny, Danny Milosavljevic skribis: > Fixes . > Reported by sirgazil . > > * gnu/system/uuid.scm (fat-uuid->string): Pad resulting string with leadi= ng > zeroes. Bah, I feel guilty: I pushed the same patch with a test as 6c5790a2faf8ffc401e43b13425a707394e40874, and only now do I notice that you had fixed it too. My apologies! Perhaps in the future you should send the patch directly in the bug report? That would increase the likelihood that I=E2=80=99ll notice and wo= n=E2=80=99t duplicate work. (Perhaps in the future I should also pay more attention to email=E2=80=A6 tricky!) Ludo=E2=80=99. ------------=_1557396722-15067-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 5 May 2019 21:44:18 +0000 Received: from localhost ([127.0.0.1]:55071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNOvh-0006x0-UX for submit@debbugs.gnu.org; Sun, 05 May 2019 17:44:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNOvf-0006wn-VG for submit@debbugs.gnu.org; Sun, 05 May 2019 17:44:16 -0400 Received: from lists.gnu.org ([209.51.188.17]:58868) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hNOvZ-0000HV-Pe for submit@debbugs.gnu.org; Sun, 05 May 2019 17:44:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNOvX-0004WS-Ln for guix-patches@gnu.org; Sun, 05 May 2019 17:44:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hNOvV-00008b-Ov for guix-patches@gnu.org; Sun, 05 May 2019 17:44:06 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:55116) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hNOvT-00089d-N9 for guix-patches@gnu.org; Sun, 05 May 2019 17:44:05 -0400 Received: from dayas.3.home (178.113.194.41.wireless.dyn.drei.com [178.113.194.41]) by dd26836.kasserver.com (Postfix) with ESMTPSA id E89B533602A1; Sun, 5 May 2019 23:43:57 +0200 (CEST) From: Danny Milosavljevic To: guix-patches@gnu.org Subject: [PATCH] uuid: Pad resulting FAT uuid string with leading zeroes. Date: Sun, 5 May 2019 23:43:54 +0200 Message-Id: <20190505214354.24882-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Tags: patch Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 85.13.145.193 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Fixes . Reported by sirgazil . * gnu/system/uuid.scm (fat-uuid->string): Pad resulting string with leadi= ng zeroes. --- gnu/system/uuid.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/system/uuid.scm b/gnu/system/uuid.scm index f13960c3e9..7204d163d0 100644 --- a/gnu/system/uuid.scm +++ b/gnu/system/uuid.scm @@ -175,7 +175,7 @@ ISO9660 UUID representation." "Convert FAT32/FAT16 UUID, a 4-byte bytevector, to its string represen= tation." (let ((high (bytevector-uint-ref uuid 0 %fat-endianness 2)) (low (bytevector-uint-ref uuid 2 %fat-endianness 2))) - (format #f "~:@(~x-~x~)" low high))) + (format #f "~:@(~4,'0x-~4,'0x~)" low high))) =20 (define %fat-uuid-rx (make-regexp "^([[:xdigit:]]{4})-([[:xdigit:]]{4})$")) ------------=_1557396722-15067-1-- From unknown Sat Aug 09 13:17:40 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#35593] [PATCH] uuid: Pad resulting FAT uuid string with leading zeroes. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 09 May 2019 12:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35593 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 35593-done@debbugs.gnu.org Received: via spool by 35593-done@debbugs.gnu.org id=D35593.15574059785394 (code D ref 35593); Thu, 09 May 2019 12:47:02 +0000 Received: (at 35593-done) by debbugs.gnu.org; 9 May 2019 12:46:18 +0000 Received: from localhost ([127.0.0.1]:34939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOiRE-0001Os-Ug for submit@debbugs.gnu.org; Thu, 09 May 2019 08:46:18 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:50302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOiRB-0001Og-Ip for 35593-done@debbugs.gnu.org; Thu, 09 May 2019 08:46:14 -0400 Received: from localhost (178.112.234.177.wireless.dyn.drei.com [178.112.234.177]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 04C843362224; Thu, 9 May 2019 14:46:11 +0200 (CEST) Date: Thu, 9 May 2019 14:46:04 +0200 From: Danny Milosavljevic Message-ID: <20190509144604.7f54a1e6@scratchpost.org> In-Reply-To: <87y33gey4w.fsf@gnu.org> References: <20190505214354.24882-1-dannym@scratchpost.org> <87y33gey4w.fsf@gnu.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/dgbmu7R=4IKoAocC_Kx3ll+"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/dgbmu7R=4IKoAocC_Kx3ll+ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, On Thu, 09 May 2019 12:10:55 +0200 Ludovic Court=C3=A8s wrote: > > Fixes . > > Reported by sirgazil . > > > > * gnu/system/uuid.scm (fat-uuid->string): Pad resulting string with lea= ding > > zeroes. =20 >=20 > Bah, I feel guilty: I pushed the same patch with a test as > 6c5790a2faf8ffc401e43b13425a707394e40874, and only now do I notice that > you had fixed it too. My apologies! Don't worry. It's good that someone fixes it, doesn't matter whether it's = you or me :) > Perhaps in the future you should send the patch directly in the bug > report? That would increase the likelihood that I=E2=80=99ll notice and = won=E2=80=99t > duplicate work. Sure! --Sig_/dgbmu7R=4IKoAocC_Kx3ll+ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlzUIQwACgkQ5xo1VCww uqW+ggf/XPN0dKgdqoLsOWDp0+nN96IBnZFzCOJoCb+GOkaRwE9GOEN7HrIePKuj mc1HuESI0/yAMU7hWjW70CQ7x9l9tfHLcq9DXL3E3c+0VGgBIHtG7S2nIqeTeaic K5CXWZbAoM/tlMN9TTfh8zFKomnZIG/ODWFxb9ArSsFpJ3GkfZ6EGMjH5jsjkMxa O47TdJTTIM9F5Kl8BiPiEhuDtfhVOI24gzdykX/2OetYcVcBM1sMSFqOrTwpR+8Q n47k/YKn/gXIZZsGBNPAJ3Rv/ZuK6ZtUTK17nERyXzHsS0ll/lDRs9S5SQqAxqsn 3VXCRGbjMPmhskaJ0vrS0tej78B66g== =Blz3 -----END PGP SIGNATURE----- --Sig_/dgbmu7R=4IKoAocC_Kx3ll+--