GNU bug report logs - #35571
12.1; Changing foreground breaks previews

Previous Next

Full log

View this message in rfc822 format

From: Ikumi Keita <ikumi <at> ikumi.que.jp>
To: David Kastrup <dak <at> gnu.org>
Cc: Hua Wang <hackitforfun <at> gmail.com>, 35571 <at> debbugs.gnu.org, 35696 <at> debbugs.gnu.org, Arash Esbati <arash <at> gnu.org>, Gennady Uraltsev <gennady.uraltsev <at> gmail.com>
Subject: bug#35571: bug#35696: preview-latex does not work under any Emacs themes and bug#35571: 12.1; Changing foreground breaks previews
Date: Tue, 28 May 2019 15:55:51 +0900

[Message part 1 (text/plain, inline)]

>>>>> David Kastrup <dak <at> gnu.org> writes:
> The current code is already a sledgehammer that looks like a "not again"
> approach of evading yet another changed API.  Looking at the history of
> the recommended replacements, I see that the Ghostscript developers
> state that some of those were removed in some Ghostscript versions but
> reinstated.

> So it's conceivable that reverting the last change to these code lines
> is all that it would take to work with current Ghostscript (at the price
> of breaking _some_ older version).

> Might be worth a try.

Thanks for your advice, the attached patch works well.  The foreground
color of the generated image matches with the default face of emacs
without `preview-pdf-color-string', at least for gs 9.27 on my machine.

> (at the price of breaking _some_ older version).

I don't know which version of gs needs `preview-pdf-color-string'.
Maybe we should not delete it and instead introduce a user option as a
flag whether to disable the function or not.  What do others think?

Regards,
Ikumi Keita

[0001-Remove-walk-around-for-older-Ghostscript-bug-35696-a.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.