From unknown Tue Jun 24 17:27:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35565: 27.0.50; gnus-summary-widget-forward error with other frame Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: yamaoka@jpl.org, larsi@gnus.org, bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Sat, 04 May 2019 18:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35565 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: patch To: 35565@debbugs.gnu.org Cc: Katsumi Yamaoka , Lars Ingebrigtsen X-Debbugs-Original-To: submit@debbugs.gnu.org (The Gnus Bugfixing Girls + Boys) X-Debbugs-Original-Xcc: Katsumi Yamaoka , Lars Ingebrigtsen Received: via spool by submit@debbugs.gnu.org id=B.155699316525051 (code B ref -1); Sat, 04 May 2019 18:07:01 +0000 Received: (at submit) by debbugs.gnu.org; 4 May 2019 18:06:05 +0000 Received: from localhost ([127.0.0.1]:52217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMz2y-0006Vy-GB for submit@debbugs.gnu.org; Sat, 04 May 2019 14:06:05 -0400 Received: from mail-ed1-f51.google.com ([209.85.208.51]:47064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMz2u-0006VK-5j for submit@debbugs.gnu.org; Sat, 04 May 2019 14:06:02 -0400 Received: by mail-ed1-f51.google.com with SMTP id f37so10021699edb.13 for ; Sat, 04 May 2019 11:06:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:user-agent:mime-version; bh=8Ekh8z+YooKL/PE/BddXQexKZzyOkEW1fheohm7EZ3s=; b=FuaB4Tg4HEaYTBDCKZWsARu/Wx8QrN1wkIEBVyTu6twqbREzpmuD4hZ8xRrewAkBKy 92ESdWi6rlRA4uyomQ5iHHLc/SpZohUB08dF26wTkDe3je/x0dlrhmOfPhLWMjlEpjkw 7rAhNhqEwGce52S7YGDlHhCcetDsezYae8xTjOr7PBA4NtO+MVLs9G8f9dasJda0tVDR a7D/2i4p1kSUbJvbowmHaRwxssK7RylQgwow+faxJTL097fAvkS89UCDqjeY7fIza52E 3X9pejjwChyzmEy2uD/6a4xwkzppwGWkst45cY/zQYWdyHyvNgKFIYESyFQsKsEOvjA0 wGpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=8Ekh8z+YooKL/PE/BddXQexKZzyOkEW1fheohm7EZ3s=; b=bFGPOO64LRuCLpcpJWpOi3FlD59B7k8rbPAf+0263z2aATn9LUTgV/41CgOJSUgmPC 3bmZnsvIOZhFDI6tf5QwVzFJaawxqw1xVTKDXyccHsd+pIrb7qW2KcUuat8ZOoRrA9sJ HH0qpMJi6jdNcZkZJFPzq9DmUq3bkrYtjxYala3RrS/9Nl+bQuAXjy6oTCbGAXmDOvw6 Nhe4Biguts3NWXxVzyi3v9hEOqL8itwcGXDJJGZrxFrVO8DqXoM3qQp8yVNKgO6ND0h6 SvtXR8nyvbCQw7wQQdNzFVb8xBj+GI1lRREdkgPM2GAibWZaIk9Pp744k4v49i5ymJ0T bE/w== X-Gm-Message-State: APjAAAU59QPYzqt5A+0pWSeMvkQfeTfKmaYV22S1uDqsesS+IFnRAS5x 5r6MQ//hi1YQfJgRbPsquZEo/JNP62g= X-Google-Smtp-Source: APXvYqz4FoupFPHhE76wuJLXpriJ27Dxk/PRzK4nAnUk/6tts3PSvVw0ByUNaCaKG0xdByw6zMiPeQ== X-Received: by 2002:a17:906:3009:: with SMTP id 9mr11896421ejz.157.1556993154137; Sat, 04 May 2019 11:05:54 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:8cad:ae29:555d:852d]) by smtp.gmail.com with ESMTPSA id n7sm802588ejk.72.2019.05.04.11.05.52 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 04 May 2019 11:05:53 -0700 (PDT) From: "Basil L. Contovounesios" Date: Sat, 04 May 2019 19:05:47 +0100 Message-ID: <87pnoyumbo.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Tags: patch --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-Gnus-summary-widget-navigation-across-frames.patch >From 4190fec56ebd413e0e398d23edb55b89772ae1d0 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Sat, 4 May 2019 16:29:39 +0100 Subject: [PATCH] Fix Gnus summary widget navigation across frames * lisp/gnus/gnus-sum.el (gnus-summary-widget-forward) (gnus-summary-widget-backward): Signal more informative error if article window is not found. Consider other frames displaying article buffer, and raise its frame before navigating its widgets. * lisp/gnus/gnus-win.el (gnus-get-buffer-window): Simplify and add docstring. --- lisp/gnus/gnus-sum.el | 18 ++++++++++++------ lisp/gnus/gnus-win.el | 19 ++++++++++--------- 2 files changed, 22 insertions(+), 15 deletions(-) diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index b8aa302f11..ac222acfd2 100644 --- a/lisp/gnus/gnus-sum.el +++ b/lisp/gnus/gnus-sum.el @@ -9423,8 +9423,11 @@ gnus-summary-widget-forward (interactive "p") (gnus-summary-select-article) (gnus-configure-windows 'article) - (select-window (gnus-get-buffer-window gnus-article-buffer)) - (widget-forward arg)) + (let ((win (or (gnus-get-buffer-window gnus-article-buffer t) + (error "No article window found")))) + (select-window win) + (select-frame-set-input-focus (window-frame win)) + (widget-forward arg))) (defun gnus-summary-widget-backward (arg) "Move point to the previous field or button in the article. @@ -9432,10 +9435,13 @@ gnus-summary-widget-backward (interactive "p") (gnus-summary-select-article) (gnus-configure-windows 'article) - (select-window (gnus-get-buffer-window gnus-article-buffer)) - (unless (widget-at (point)) - (goto-char (point-max))) - (widget-backward arg)) + (let ((win (or (gnus-get-buffer-window gnus-article-buffer t) + (error "No article window found")))) + (select-window win) + (select-frame-set-input-focus (window-frame win)) + (unless (widget-at (point)) + (goto-char (point-max))) + (widget-backward arg))) (defun gnus-summary-isearch-article (&optional regexp-p) "Do incremental search forward on the current article. diff --git a/lisp/gnus/gnus-win.el b/lisp/gnus/gnus-win.el index 5f7154c545..a992fe731c 100644 --- a/lisp/gnus/gnus-win.el +++ b/lisp/gnus/gnus-win.el @@ -28,6 +28,7 @@ (require 'gnus) (require 'gnus-util) +(require 'seq) (defgroup gnus-windows nil "Window configuration." @@ -509,15 +510,15 @@ gnus-remove-some-windows (delq lowest-buf bufs))))) (defun gnus-get-buffer-window (buffer &optional frame) - (cond ((and (null gnus-use-frames-on-any-display) - (memq frame '(t 0 visible))) - (car - (let ((frames (frames-on-display-list))) - (seq-remove (lambda (win) (not (memq (window-frame win) - frames))) - (get-buffer-window-list buffer nil frame))))) - (t - (get-buffer-window buffer frame)))) + "Return a window currently displaying BUFFER, or nil if none. +Like `get-buffer-window', but respecting +`gnus-use-frames-on-any-display'." + (if (and (not gnus-use-frames-on-any-display) + (memq frame '(t 0 visible))) + (let ((frames (frames-on-display-list))) + (seq-find (lambda (win) (memq (window-frame win) frames)) + (get-buffer-window-list buffer nil frame))) + (get-buffer-window buffer frame))) (provide 'gnus-win) -- 2.20.1 --=-=-= Content-Type: text/plain Since at least Emacs 24.4, the commands gnus-summary-widget-forward and gnus-summary-widget-backward have been signalling an error in multiframe configurations: 0. HOME=$(mktemp -d) emacs -Q 1. (progn (setq debug-on-error t gnus-select-method '(nntp "news.gwene.org")) (gnus-add-configuration '(article (frame 1.0 (summary 1.0 point frame-focus) (article 1.0))))) 2. C-j 3. M-x gnus RET 4. s [session only] 5. ^ [gnus-group-enter-server-mode] 6. n [goto nntp:news.gwene.org] 7. RET [gnus-server-read-server] 8. C-s gmane.emacs.devel RET 9. u [gnus-browse-unsubscribe-current-group] 10. q [gnus-browse-exit] 11. q [gnus-server-exit] 12. RET 1 RET [gnus-group-select-group] 13. TAB [gnus-summary-widget-forward] Debugger entered--Lisp error: (wrong-type-argument window-live-p nil) select-window(nil) gnus-summary-widget-forward(1) funcall-interactively(gnus-summary-widget-forward 1) call-interactively(gnus-summary-widget-forward nil nil) command-execute(gnus-summary-widget-forward) Is it okay to push the attached fix, which additionally simplifies the subroutine gnus-get-buffer-window used by the two commands? Thanks, -- Basil Gnus v5.13 In GNU Emacs 27.0.50 (build 14, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2019-05-04 built on thunk Repository revision: b5376e0ebd7b62f00c1b64aef87cd8d96cfbc71a Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12003000 System Description: Debian GNU/Linux buster/sid --=-=-=-- From unknown Tue Jun 24 17:27:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35565: 27.0.50; gnus-summary-widget-forward error with other frame Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Sun, 05 May 2019 20:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35565 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: patch To: "Basil L. Contovounesios" Cc: Katsumi Yamaoka , 35565@debbugs.gnu.org Received: via spool by 35565-submit@debbugs.gnu.org id=B35565.155708661414596 (code B ref 35565); Sun, 05 May 2019 20:04:01 +0000 Received: (at 35565) by debbugs.gnu.org; 5 May 2019 20:03:34 +0000 Received: from localhost ([127.0.0.1]:54960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNNMD-0003nL-P4 for submit@debbugs.gnu.org; Sun, 05 May 2019 16:03:34 -0400 Received: from quimby.gnus.org ([80.91.231.51]:51552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNNMA-0003nB-O1 for 35565@debbugs.gnu.org; Sun, 05 May 2019 16:03:31 -0400 Received: from 216-164-243-137.s1927.c3-0.smt-cbr2.atw-smt.pa.cable.rcncustomer.com ([216.164.243.137] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hNNM5-00034j-Ac; Sun, 05 May 2019 22:03:27 +0200 From: Lars Ingebrigtsen References: <87pnoyumbo.fsf@tcd.ie> Date: Sun, 05 May 2019 16:03:23 -0400 In-Reply-To: <87pnoyumbo.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sat, 04 May 2019 19:05:47 +0100") Message-ID: <87v9yopt2s.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "Basil L. Contovounesios" writes: > Is it okay to push the attached fix, which additionally simplifies the > subroutine gnus-get-buffer-window used by the two commands? I have not tested the patch, but it does look reasonable to me. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Basil L. Contovounesios" writes: > Is it okay to push the attached fix, which additionally simplifies the > subroutine gnus-get-buffer-window used by the two commands? I have not tested the patch, but it does look reasonable to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Tue Jun 24 17:27:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#35565: 27.0.50; gnus-summary-widget-forward error with other frame Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Sun, 05 May 2019 22:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35565 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: Katsumi Yamaoka , 35565@debbugs.gnu.org Received: via spool by 35565-submit@debbugs.gnu.org id=B35565.1557096000477 (code B ref 35565); Sun, 05 May 2019 22:40:01 +0000 Received: (at 35565) by debbugs.gnu.org; 5 May 2019 22:40:00 +0000 Received: from localhost ([127.0.0.1]:55140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNPnc-00007d-Bo for submit@debbugs.gnu.org; Sun, 05 May 2019 18:40:00 -0400 Received: from mail-ed1-f52.google.com ([209.85.208.52]:44809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hNPnZ-00007K-Oc for 35565@debbugs.gnu.org; Sun, 05 May 2019 18:39:59 -0400 Received: by mail-ed1-f52.google.com with SMTP id b8so13156007edm.11 for <35565@debbugs.gnu.org>; Sun, 05 May 2019 15:39:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=FXxEjAuS57r4zE29JLZPl1Kti7hhZ2ieIOYxHkN9tLg=; b=gqommGR3aEVZrEMTr6uQw+5fe/PKfP1XVGh66spwWeM8X6DTgww2IBzrk0ApU0x5kY KcD9lzThx+SysFakrGjX9y+D587i6m+NgI5wFoWo/1FQxbpTiSd3NIQZUhgZ9fg1Syr0 H/c6S657tCNtB1kK8VRn909A4R57IN/tmZQOe/htOHVJmQ7FdUPFUL7j4r5RboenKTsP BT7sG0BAFqGRdDxFyx6XLfoKR2e1AcK1lTFCzrNZbhxZdenCo+cjJCjUyC0V506sAPif DkptZ81tphPU3LiC8nuw5Wv0J6yEEv/WT74pBCzKs3qxfMPMv3F20zIqPowcP6a1zQYL WHnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=FXxEjAuS57r4zE29JLZPl1Kti7hhZ2ieIOYxHkN9tLg=; b=GtzYTHd/lSyyXD9IVZnV0/2J0Ct8eV1DJhjpa1+PAM7Xkid5nvgER25P2RzmUTURH1 4ExGraAOJc1DyT45bQq2MB9TazGVwBPOwshxjJPX091cVnoDifgYJRZsSfJ6LSfrub/V kut9uBpiM8ezocXnfMibKC3X66uPLDQ9s5PFfokrwyqd44PyBq+gpsuavmWKXav5ovQS OCYVloju8TUSWuxXadIMCMcGzGtq2Z3aJ+vgY1idfyJhwJUF+xFG8HAZ7M2fg4N0X0/r rxBpZVWjJGFOGVLzYPpnXqdQ0CnrdKP61k4TYabLcQgJbEkZOkDtQiimSQp54x7PXA/v MRZg== X-Gm-Message-State: APjAAAX5V1RacUh/izAizb54EHHOgodXpqe5Cmj6or+FvGsTPhnShYE0 SAhCAMsklSW6bDV7PKLJ7U9OOg== X-Google-Smtp-Source: APXvYqzmBTUH+aJwc9ION/eZM3hsUHRqDb1CRxeH5IVvyM63RXuJdpH8EPBMDO05eTsWcHcqoBeQNQ== X-Received: by 2002:a17:906:69ce:: with SMTP id g14mr16458328ejs.68.1557095991703; Sun, 05 May 2019 15:39:51 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:6fa:38d6:1fce:ddb3]) by smtp.gmail.com with ESMTPSA id h10sm2450746ede.21.2019.05.05.15.39.50 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 05 May 2019 15:39:50 -0700 (PDT) From: "Basil L. Contovounesios" References: <87pnoyumbo.fsf@tcd.ie> <87v9yopt2s.fsf@mouse.gnus.org> Date: Sun, 05 May 2019 23:39:49 +0100 In-Reply-To: <87v9yopt2s.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Sun, 5 May 2019 16:03:23 -0400") Message-ID: <87d0kwr0ei.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > "Basil L. Contovounesios" writes: > >> Is it okay to push the attached fix, which additionally simplifies the >> subroutine gnus-get-buffer-window used by the two commands? > > I have not tested the patch, but it does look reasonable to me. Thanks, I'll push in a few days if there are no objections before then. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Sun May 12 07:54:15 2019 Received: (at control) by debbugs.gnu.org; 12 May 2019 11:54:15 +0000 Received: from localhost ([127.0.0.1]:42024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPn3X-0000X0-A5 for submit@debbugs.gnu.org; Sun, 12 May 2019 07:54:15 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:33230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPn3V-0000Wd-Nf for control@debbugs.gnu.org; Sun, 12 May 2019 07:54:14 -0400 Received: by mail-ed1-f67.google.com with SMTP id n17so12900299edb.0 for ; Sun, 12 May 2019 04:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=zcIgDw7NejONNT+xbLUMrI8tRm5kk2O4AuUBnRymKUE=; b=usD3Kbz3vIMwEcRhK4M6w9Uf1nAOBMvk2O8wX/g9BzHgoBdoQLzHOyB15KxX5OqEZl cKd8ID0Y43Olk0N9PCidtlv61baC5pGgPYgIqMadpSYnfid7wY/UzgmdPr9OICXVKg+X JzG7UE0kPApvosIl/UY+0e1tg/2cSvuuQS1+hrCUAAx2WTg1/TftgUYWrXq7rhnwVuX8 tDy0bvzLCTdOQIQRrSDfsKX0Az43szOFGm5zj1w3FN3lm4IbyVTCsDyop1y09ZU3NilA lwvk+XnoZ+7NtnfCkWmMkrQNaa6vCf1A1tSI4duT5r2b6nQA/Gaj/tT2f0+oc3x9uKeA BaHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=zcIgDw7NejONNT+xbLUMrI8tRm5kk2O4AuUBnRymKUE=; b=HDxRUuLZi0x2weQRt6nuHugGxqX94CxNnS+OSzUj8ISfIKvhMZxWgwQQvhDjM6u0/I kZXUiElv/wUTaevD+ZBaOlQN554x4CAXM35QNf83BtKn5UFcDU3rMJx3WTU8LtxMTX0f 599RAKMbkvKooFZ9PTNRra70IONqrAhVE5HdMg0y+7sJWkcdC5ha3Ad+GD0WgjosSkUh 6p3wsTQmX/k8Zg0T1Kqj2ekVlmdAuE4lbR4DoAuULscjn2HWwPbCQ3XPpl0TFnVcLrV0 nUEVNp02HSRclOLKY6jgddcNF+mdaACiz1h0SVcp+6rdbSLcI/Fh9M7nQOauSLOjafOM 1rCA== X-Gm-Message-State: APjAAAUJJ54yTcV8VziLW6S4QXAInvCIWzro6Yu/VUrf3W/OLaBtjIC6 R5paa8FjyasBr1aCWLFans1s4Q== X-Google-Smtp-Source: APXvYqzSfTC6Bda6dy+FdkNyugeE1nbuYcDkZz3Xo8cvD8T/7UrViUhDwUycWfaeo5zgn2tiZPqbbw== X-Received: by 2002:a17:906:685:: with SMTP id u5mr17581078ejb.125.1557662048045; Sun, 12 May 2019 04:54:08 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:8cad:ae29:555d:852d]) by smtp.gmail.com with ESMTPSA id w54sm3039959edw.40.2019.05.12.04.54.06 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 12 May 2019 04:54:06 -0700 (PDT) From: "Basil L. Contovounesios" To: Lars Ingebrigtsen Subject: Re: bug#35565: 27.0.50; gnus-summary-widget-forward error with other frame References: <87pnoyumbo.fsf@tcd.ie> <87v9yopt2s.fsf@mouse.gnus.org> <87d0kwr0ei.fsf@tcd.ie> Date: Sun, 12 May 2019 12:54:05 +0100 In-Reply-To: <87d0kwr0ei.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 05 May 2019 23:39:49 +0100") Message-ID: <87lfzb7usi.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: Katsumi Yamaoka , 35565-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 35565 fixed close 35565 quit "Basil L. Contovounesios" writes: > Lars Ingebrigtsen writes: > >> "Basil L. Contovounesios" writes: >> >>> Is it okay to push the attached fix, which additionally simplifies the >>> subroutine gnus-get-buffer-window used by the two commands? >> >> I have not tested the patch, but it does look reasonable to me. > > Thanks, I'll push in a few days if there are no objections before then. Done[1], so I'm closing this report. [1: 571d802df3]: Fix Gnus summary widget navigation across frames 2019-05-12 12:47:56 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=571d802df38cb1d3f93222f2977b766995616ac7 -- Basil