GNU bug report logs - #35564
27.0.50; [PATCH] Tweak dired-do-shell-command warning about "wildcard" characters

Previous Next

Package: emacs;

Reported by: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>

Date: Sat, 4 May 2019 18:03:02 UTC

Severity: normal

Tags: fixed, moreinfo, patch

Merged with 28969

Found in version 27.0.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: martin rudalics <rudalics <at> gmx.at>
To: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>, 35564 <at> debbugs.gnu.org
Subject: bug#35564: 27.0.50; [PATCH] Tweak dired-do-shell-command warning about "wildcard" characters
Date: Sun, 5 May 2019 10:44:21 +0200

> … and ended up with the attached patch, which I am not entirely
> satisfied with (for one, it replaces `y-or-n-p' with `yes-or-no-p'
> merely because the former seems to strip my prompt's text attributes
> somehow[1]).

[...]

> [1] Compare:
>
> (let ((prompt "foobar "))
>    (add-face-text-property 3 6 'warning nil prompt)
>    (yes-or-no-p prompt))
>
> With:
>
> (let ((prompt "foobar "))
>    (add-face-text-property 3 6 'warning nil prompt)
>    (y-or-n-p prompt))

'y-or-n-p' propertizes the prompt rigidly as

                    (read-key (propertize (if (memq answer scroll-actions)
                                              prompt
                                            (concat "Please answer y or n.  "
                                                    prompt))
                                          'face 'minibuffer-prompt)))))

while 'yes-or-no-p' carefully applies 'minibuffer-prompt-properties'
to any text properties provided with PROMPT.

martin
This bug report was last modified 4 years and 297 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.