GNU bug report logs - #35564
27.0.50; [PATCH] Tweak dired-do-shell-command warning about "wildcard" characters

Previous Next

Full log

View this message in rfc822 format

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: 35564 <at> debbugs.gnu.org
Cc: Michael Heerdegen <michael_heerdegen <at> web.de>, Noam Postavsky <npostavs <at> gmail.com>, Juri Linkov <juri <at> linkov.net>, Stefan Monnier <monnier <at> iro.umontreal.ca>, Eli Zaretskii <eliz <at> gnu.org>, Drew Adams <drew.adams <at> oracle.com>
Subject: bug#35564: [PATCH v5] Tweak dired warning about "wildcard" characters
Date: Wed, 18 Dec 2019 08:11:25 +0100

[Message part 1 (text/plain, inline)]

Hello,

Here is a new revision of this patch series, which aims to rephrase
dired-do-shell-command's warning about occurrences of '?' and '*' that
will not be substituted for filenames, with the following goals in mind:

1. cease to call these characters "wildcards" since they may be quoted
   or escaped,
2. cater to users who do not know about the substitution feature,
3. keep the default prompt as concise as the current one.

The first revisions[1][2][3][4] focused on goals 1 and 2, to the
detriment of 3.  The last revision[5] hid the verbosity behind an
optional explanatory buffer, using read-multiple-choice.  Since this
function already generates a help buffer bound to '?', I bound the
explanatory buffer to 'd' for "details", a la nsm-query-user.

Juri suggested[6] that read-char-from-minibuffer might fit the bill
better.  Since I feel kind of torn between these options, I'm putting
them both forward.

First, the scaffolding patches (same as v5):

[0001-Tweak-dired-warning-about-wildcard-characters.patch (text/x-patch, attachment)]

[0002-Dedup-dired-aux-isolated-char-searching-Bug-35564.patch (text/x-patch, attachment)]

[0003-Add-markers-below-non-isolated-chars-in-dired-prompt.patch (text/x-patch, attachment)]

[0004-Simplify-highlighting-assertions.patch (text/x-patch, attachment)]

[Message part 6 (text/plain, inline)]

Then, the patch adding read-multiple-choice (mostly the same as v5):

[0005-Hide-detailed-explanations-in-a-togglable-help-buffe-rmc.patch (text/x-patch, attachment)]

[Message part 8 (text/plain, inline)]

Or, the patch adding read-char-from-minibuffer:

[0005-Hide-detailed-explanations-in-a-togglable-help-buffe-rcfm.patch (text/x-patch, attachment)]

[Message part 10 (text/plain, inline)]

Squashed patches:

[0001-Tweak-dired-warning-about-wildcard-characters-rmc-squashed.patch (text/x-patch, attachment)]

[0001-Tweak-dired-warning-about-wildcard-characters-rcfm-squashed.patch (text/x-patch, attachment)]

[Message part 13 (text/plain, inline)]

For reference, here is the diff between both the read-multiple-choice
and the read-char-from-minibuffer options:

[rmc-vs-rcfm.patch (text/x-patch, attachment)]

[Message part 15 (text/plain, inline)]

Once applied, the patches can be tried out by

- opening a Dired buffer,
- hitting '!',
- inputting e.g. "sed 's/?/!/'".


WDYT?


Thank you for your time.


[1] bug#35564#5
[2] bug#35564#38
[3] bug#35564#62
[4] bug#35564#101
[5] bug#35564#157
[6] bug#35564#187

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.