Subject: Re: bug#35564: [PATCH v4] Tweak dired warning about "wildcard" characters

From: "Basil L. Contovounesios" <[email-masked]>
Date: Sat, 27 Jul 2019 23:03:27 +0100

Eli Zaretskii <[email-masked]> writes:

> Any more comments, anyone?

Just a couple of very minor questions from me:

Kévin Le Gouguec <[email-masked]> writes:

> -(defun dired--no-subst-prompt (char-positions command)
> +(defun dired--mark-positions (positions)
> +  (let ((markers (make-string
> +                  (1+ (apply #'max positions))

Is POSITIONS guaranteed to be non-nil?  (The max function takes at least
one argument.)

> Subject: [PATCH 6/6] Simplify highlighting assertions
>
> * test/lisp/dired-aux-tests.el (dired-test--check-highlighting):
> New function.
> (dired-test-highlight-metachar): Use it.

Will this simplification hinder debugging of test failures?  I don't
have an opinion on the proposed change, it's just something to consider.

> Again, thank you for your patience and your reviews.

Thank you for working on this,

-- 
Basil